BPirkle added a comment.
In T198341#5022332 <https://phabricator.wikimedia.org/T198341#5022332>, @daniel wrote: > > includes/Revision/RevisionStore.php (I'll touch only getQueryInfo(). All other references are either gated directly, or are in private functions with all calls gated) > > getQueryInfo() should have proper gating as well. If you think it does not, let's talk before you change things. I looked again, you are correct. I saw the comment mentioning this task (T198341 <https://phabricator.wikimedia.org/T198341>) and initially thought there was something to do. We just need to be sure callers don't pass a "text" option, but that's already covered under T198342 <https://phabricator.wikimedia.org/T198342> (which is probably a good candidate for my next task after I finish this one). So nothing to do to getQueryInfo() at the moment. Thanks very much for your comments on the other items. I'll proceed down the list, making separate patches for each. TASK DETAIL https://phabricator.wikimedia.org/T198341 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: BPirkle Cc: tstarling, gerritbot, Tgr, Jdforrester-WMF, Anomie, Addshore, aude, Aklapper, daniel, alaa_wmde, EvanProdromou, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Ramsey-WMF, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, JJMC89, Maathavan, _jensen, rosalieper, Agabi10, Wikidata-bugs, Mbch331, Ltrlg
_______________________________________________ Wikidata-bugs mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
