[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 432156 abandoned by Lucas Werkmeister (WMDE): Retry SELECT FOR UPDATE in SqlIdGenerator once Reason: This was superseded by other efforts, mainly I4fd46adae1, I believe. https://gerrit.wikimedia.org/r/432156 TASK DETAIL https://phabricator.wikimedia.org/T194299 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Addshore, gerritbot Cc: Zeroth, jcrespo, abian, Fnielsen, Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, alaa_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair ___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
aaron added a comment. That sounds right.TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, aaronCc: Fnielsen, Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
Addshore added a comment.
From yesterday:
Wikibase\UpsertSqlIdGenerator::upsertId 10.64.48.26 1205 Lock wait timeout exceeded; try restarting transaction (10.64.48.26) INSERT INTO `wb_id_counters` (id_type,id_value) VALUES ('wikibase-item','1') ON DUPLICATE KEY UPDATE id_value = LAST_INSERT_ID(id_value + 1)
So we will need another different approach in order to make this stop happening as the small optimization didn't cut it.
The next thing would be T194299#4713654
Looking at T194299#4715287 it sounds like right now we should be aiming to use CONN_TRX_AUTO still.
@aaron is that correct? We can just add a note next to the use stating that we don't actually care about the TRX mode.TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Fnielsen, Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-12-19T17:22:39Z] Synchronized wmf-config: Wikibase: wikidatawiki upsert idGenerator, T194299 (duration: 00m 52s)TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, StashbotCc: Fnielsen, Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 480778 merged by jenkins-bot: [operations/mediawiki-config@master] Wikibase, use mysql-upsert on all Wikibases https://gerrit.wikimedia.org/r/480778TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Fnielsen, Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-12-19T17:13:31Z] Synchronized wmf-config: Wikibase: testwikidatawiki upsert idGenerator, T194299 (duration: 00m 52s)TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, StashbotCc: Fnielsen, Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 480777 merged by jenkins-bot: [operations/mediawiki-config@master] Wikibase, use mysql-upsert id generator on testwikidatawiki https://gerrit.wikimedia.org/r/480777TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Fnielsen, Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
Stashbot added a comment. Mentioned in SAL (#wikimedia-operations) [2018-12-19T17:04:40Z] Synchronized wmf-config: Wikibase: prepare to set $wgWBRepoSettings idGenerator, T194299 (duration: 00m 53s)TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, StashbotCc: Fnielsen, Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 480774 merged by jenkins-bot: [operations/mediawiki-config@master] Wikibase: prepare to set $wgWBRepoSettings['idGenerator'] https://gerrit.wikimedia.org/r/480774TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Fnielsen, Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 480775 merged by jenkins-bot: [operations/mediawiki-config@master] BETA: Wikibase, use mysql-upsert id generator https://gerrit.wikimedia.org/r/480775TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Fnielsen, Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 480778 had a related patch set uploaded (by Addshore; owner: Addshore): [operations/mediawiki-config@master] Wikibase, use mysql-upsert on all Wikibases https://gerrit.wikimedia.org/r/480778TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Fnielsen, Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 480777 had a related patch set uploaded (by Addshore; owner: Addshore): [operations/mediawiki-config@master] Wikibase, use mysql-upsert id generator on testwikidatawiki https://gerrit.wikimedia.org/r/480777TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Fnielsen, Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 480774 had a related patch set uploaded (by Addshore; owner: Addshore): [operations/mediawiki-config@master] Wikibase: prepare to set $wgWBRepoSettings['idGenerator'] https://gerrit.wikimedia.org/r/480774TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Fnielsen, Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 480775 had a related patch set uploaded (by Addshore; owner: Addshore): [operations/mediawiki-config@master] BETA: Wikibase, use mysql-upsert id generator https://gerrit.wikimedia.org/r/480775TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Fnielsen, Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
Lucas_Werkmeister_WMDE added a comment. And then also leave it enabled on all three, I assume. Should we attach the necessary config changes to this task or create a subtask?TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
Addshore added a comment. In T194299#4814414, @Lucas_Werkmeister_WMDE wrote: Yes – what I meant is: do we want to write and deploy a config change to enable it on Test Wikidata separately, or go ahead with Wikidata directly (and only test on the debug server before deploying it everywhere)? WE want to do beta, then test, then prod :)TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
Lucas_Werkmeister_WMDE added a comment. Yes – what I meant is: do we want to write and deploy a config change to enable it on Test Wikidata separately, or go ahead with Wikidata directly (and only test on the debug server before deploying it everywhere)?TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
Ladsgroup added a comment. In T194299#4813650, @Lucas_Werkmeister_WMDE wrote: The new ID generator should be deployed to Test Wikidata within the next few hours – do we want to test it afterwards, or wait until the train reaches Wikidata and test there? It's behind a config variable and should be turned off for now. That's my understanding of it.TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, LadsgroupCc: Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
Lucas_Werkmeister_WMDE added a comment. The new ID generator should be deployed to Test Wikidata within the next few hours – do we want to test it afterwards, or wait until the train reaches Wikidata and test there?TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, Lucas_Werkmeister_WMDECc: Lucas_Werkmeister_WMDE, Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
hoo added a comment. Given the lock timeouts happen on SELECT, I don't really see how using a single query instead of SELECT+UPDATE/INSERT would greatly help us here. While that's definitely nice to have performance wise (less queries, less roundtrips), the main problem seems to me that something is getting a new id and then keeping the transaction (=> the lock) open to do other things before commit/rollback. While I definitely think that using UpsertSqlIdGenerator is an improvement and will greatly help us here once the contention around this table grows even more… I don't think it can fix the problem at hand. We wont be able to solve the problem as long as we don't commit immediately after UPDATE/INSERT, I fear.TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, hooCc: Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 474278 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] IdGenerator, Introduce UpsertSqlIdGenerator https://gerrit.wikimedia.org/r/474278TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 474725 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Inject IdGenerator into SqlStore https://gerrit.wikimedia.org/r/474725TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 474731 merged by jenkins-bot: [mediawiki/extensions/Wikibase@master] Add config to choose which IdGenerator to use https://gerrit.wikimedia.org/r/474731TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, gerritbotCc: Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
Ladsgroup added a comment. For now I suggest wrapping it up in onTransactionPreCommitOrIdle similar to T207881: excessive "lock wait timeout exceeded " error rate after deploying 1.33.0-wmf.1 to group1 TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Addshore, LadsgroupCc: Ladsgroup, aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 474274 abandoned by Addshore: WIP SqlIdGenerator, Use upsert for ID Generation Reason: See https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikibase/ /474731/ https://gerrit.wikimedia.org/r/474274TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 474731 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Add config to choose which IdGenerator to use https://gerrit.wikimedia.org/r/474731TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 474725 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] Inject IdGenerator into SqlStore https://gerrit.wikimedia.org/r/474725TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
mmodell added a comment. Yeah it's definitely a mysql-specific technique but it's atomic, fast and recommended in the mysql documentation.TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
daniel added a comment.
In T194299#4753796, @Addshore wrote:
That will indeed work:
INSERT INTO wb_id_counters (id_type, id_value) VALUES ('wikibase-item', 1) ON DUPLICATE KEY UPDATE id_value = LAST_INSERT_ID(id_value + 1);
SELECT LAST_INSERT_ID();
This solution is specific to MySQL, right?
I guess that's ok, since Wikibase doesn't support anything else. Do we check on install?TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 474278 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] IdGenerator, Introduce UpsertSqlIdGenerator https://gerrit.wikimedia.org/r/474278TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 474274 had a related patch set uploaded (by Addshore; owner: Addshore): [mediawiki/extensions/Wikibase@master] WIP SqlIdGenerator, Use upsert for ID Generation https://gerrit.wikimedia.org/r/474274TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
Addshore added a comment.
That will indeed work:
INSERT INTO wb_id_counters (id_type, id_value) VALUES ('wikibase-item', 1) ON DUPLICATE KEY UPDATE id_value = LAST_INSERT_ID(id_value + 1);
SELECT LAST_INSERT_ID();TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, D3r1ck01, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
mmodell added a comment.
In T194299#4713400, @daniel wrote:
For context, note that we are not using an auto-increment field, we are doing the increment in code, and write it back to the database.
Why not do something like this?
INSERT INTO sequence_table ('sequence_name', 'sequence_value') VALUES (?, 1)
ON DUPLICATE KEY UPDATE sequence_value = LAST_INSERT_ID(sequence_value + 1);
SELECT LAST_INSERT_ID();
Wouldn't that at least reduce the time to hold a lock while still being atomic?TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: mmodellCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
daniel added a comment. @aaron yea, but using CONN_TRX_AUTO in places where we want a different connection, but don't care at all about the TRX mode, is just bad. It obfuscates the code. If you read something like this for the first time, you can end up spending hours trying to understand why CONN_TRX_AUTO is relevant here - and perhaps decide it isn't, and remove it. We should really have a flag that describes the actual use case, e.g. CONN_NEW if we want to force a new connection, and CONN_AUX if all we need is "not the default" connection.TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
aaron added a comment. In T194299#4714630, @daniel wrote: In T194299#4714614, @aaron wrote: openConnection is badly named and still reuses connections. You'd probably want getConnection with CONN_TRX_AUTO I hate this hack. This may *still* re-use connections, if anything else used CONN_TRX_AUTO. We should have CONN_NEW. Reuse is fine here, it's just confusing for something called "openConnection". CONN_TRX_AUTO will just reuse other CONN_TRX_AUTO connections.TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaronCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
Addshore added a comment. In T194299#4714630, @daniel wrote: In T194299#4714614, @aaron wrote: openConnection is badly named and still reuses connections. You'd probably want getConnection with CONN_TRX_AUTO I hate this hack. This may *still* re-use connections, if anything else used CONN_TRX_AUTO. We should have CONN_NEW. Yup, something like CONN_NEW sounds ideal.TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
daniel added a comment. In T194299#4714614, @aaron wrote: openConnection is badly named and still reuses connections. You'd probably want getConnection with CONN_TRX_AUTO I hate this hack. This may *still* re-use connections, if anything else used CONN_TRX_AUTO. We should have CONN_NEW.TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
aaron added a comment. openConnection is badly named and still reuses connections. You'd probably want getConnection with CONN_TRX_AUTOTASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: aaronCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
Addshore added a comment. In T194299#4713654, @hoo wrote: @aaron Suggested to use a separate master DB connection for this (if were in a transaction and don't immediately autocommit), so that it never ends up in the main transaction. That might mean slightly more wasted IDs, but should significantly reduce contention. I guess that would be as simple as switching from getConnection to openConnection in SqlIdGenerator::getNewId ?TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: aaron, TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
Addshore added a comment. In T194299#4713400, @daniel wrote: In T194299#4712763, @Addshore wrote: One idea that @daniel and I had for this was simply to spread the ItemId counter out over 2 or more rows.. having one row deal with an odd counter and another deal with an even counter. For context, note that we are not using an auto-increment field, we are doing the increment in code, and write it back to the database. Indeed. And this 'solution' would also only work if we have row level locks here, which afaik we doTASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
daniel added a comment. In T194299#4712763, @Addshore wrote: One idea that @daniel and I had for this was simply to spread the ItemId counter out over 2 or more rows.. having one row deal with an odd counter and another deal with an even counter. For context, note that we are not using an auto-increment field, we are doing the increment in code, and write it back to the database.TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: danielCc: TerraCodes, Stashbot, Banyek, Paladox, mmodell, daniel, Addshore, Aklapper, gerritbot, hoo, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
Addshore added a comment. After a quick discussion with @hoo on IRC we should decide if we actually want to do this at all.TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: gerritbot, Aklapper, hoo, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, lisong, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, Lewizho99, Maathavan, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
[Wikidata-bugs] [Maniphest] [Commented On] T194299: Lock wait timeout exceeded in SqlIdGenerator::generateNewId
gerritbot added a comment. Change 432156 had a related patch set uploaded (by Hoo man; owner: Hoo man): [mediawiki/extensions/Wikibase@master] Retry SELECT+UPDATE in SqlIdGenerator once https://gerrit.wikimedia.org/r/432156TASK DETAILhttps://phabricator.wikimedia.org/T194299EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: gerritbotCc: gerritbot, Aklapper, hoo, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331, Jay8g, Krenair___ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
