[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2021-03-17 Thread gerritbot 
gerritbot added a comment.


  Change 672663 **merged** by Tobias Andersson:
  [mediawiki/extensions/Wikibase@REL1_35] Skip 0 page ID in hook handler
  
  https://gerrit.wikimedia.org/r/672663

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore, gerritbot
Cc: noarave, WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Verdy_p, abian, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2021-03-17 Thread gerritbot 
gerritbot added a comment.


  Change 672662 **merged** by Tobias Andersson:
  [mediawiki/extensions/Wikibase@REL1_35] Use LinksUpdate::$mId in hook handler
  
  https://gerrit.wikimedia.org/r/672662

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore, gerritbot
Cc: noarave, WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Verdy_p, abian, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2021-03-16 Thread gerritbot 
gerritbot added a comment.


  Change 672663 had a related patch set uploaded (by Tobias Andersson; owner: 
Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@REL1_35] Skip 0 page ID in hook handler
  
  https://gerrit.wikimedia.org/r/672663

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore, gerritbot
Cc: noarave, WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Verdy_p, abian, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2021-03-16 Thread gerritbot 
gerritbot added a comment.


  Change 672662 had a related patch set uploaded (by Tobias Andersson; owner: 
Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@REL1_35] Use LinksUpdate::$mId in hook handler
  
  https://gerrit.wikimedia.org/r/672662

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore, gerritbot
Cc: noarave, WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
maantietaja, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, 
darthmon_wmde, Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, 
lucamauri, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Scott_WUaS, Jonas, Verdy_p, abian, Wikidata-bugs, aude, 
Lydia_Pintscher, Jdforrester-WMF, Addshore, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2021-02-01 Thread Addshore 
Addshore closed this task as "Resolved".
Addshore moved this task from Test (Verification) to Done on the 
Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Addshore claimed this task.
Restricted Application added a project: User-Addshore.

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: noarave, WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, 
Addshore, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2021-01-21 Thread noarave 
noarave moved this task from To Do (prioritised from top to bottom) to Test 
(Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
noarave added a comment.


  Moving to test (verification) as there are no objections from within the 
campsite to the comment above therefore no further work is required here.

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: noarave, WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2021-01-13 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this 
task.
Lucas_Werkmeister_WMDE added a comment.


  If that’s true (Noa thought it sounded sensible), then the only thing left to 
do would be to remove some of the logging we added here. (You can find the log 
messages by searching for `T264929` in the source code.)
  
  - The “info” message in `DataUpdateHookHandler` I would keep, since it 
doesn’t hurt and (due to the low level) doesn’t clutter logstash either, even 
if it starts happening again.
  - I’m less sure about the “warning” message in `EntityUsageTable`. I’m 
tempted to turn that case back into an exception, like it was at the beginning 
of this task. But maybe that’s not a good idea? After all, in both cases, 
there’s a sensible “default” action (when writing entity usages: produce empty 
array of usage rows for page ID 0; when reading entity usages: skip rows with 
page ID 0), and warnings already go to logstash – do we gain anything from 
turning the warning into an error? I guess uncaught errors are still more 
visible than warnings in logstash, but is that worth the cost of aborting the 
current request / job?
  
  Thoughts?

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2021-01-12 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE moved this task from Stalled/Waiting to Peer Review on 
the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Lucas_Werkmeister_WMDE added a comment.


  So the new logging should be deployed by now. Logstash has no more 
occurrences of the old log message since January 3rd, which makes sense. It 
also has no occurrences at all of the new log message, which makes some sense, 
since the new message is at “info” level, which IIUC doesn’t go to Logstash. 
(The old message is at “warning” level.) But the new message also isn’t found 
on `mwlog1001`, where “info” messages are included as far as I can tell:
  
lucaswerkmeister-wmde@mwlog1001:~$ zgrep T264929 
/srv/mw-log{/archive,}/Wikibase.log*
/srv/mw-log/archive/Wikibase.log-20201208.gz:2020-12-07 19:41:49 
[X86FeApAMOEAADvkL3wAAABF] mw1383 enwiki 1.36.0-wmf.20 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201208.gz:2020-12-08 06:11:37 
[X88ZGQpAEDYAAIdy0DMAAACI] mw1289 dewiki 1.36.0-wmf.20 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201210.gz:2020-12-10 01:18:04 
[X9F3SgpAAK4AAK4GYAgU] mw1312 arwiki 1.36.0-wmf.20 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201210.gz:2020-12-10 01:53:20 
[X9F-jgpAMOEAAR0ByH4AAAED] mw1383 arwiki 1.36.0-wmf.20 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201210.gz:2020-12-10 01:54:02 
[X9F-uApAMNwAAr89DUEAAABG] mw1378 arwiki 1.36.0-wmf.20 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201210.gz:2020-12-10 01:54:28 
[X9F-0gpAMMsAAhPn6v8AAACC] mw1361 arwiki 1.36.0-wmf.20 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201210.gz:2020-12-10 01:54:53 
[X9F-6wpAMMcAAxEEaJ4AAAER] mw1357 arwiki 1.36.0-wmf.20 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201210.gz:2020-12-10 06:08:44 
[X9G7bApAAEgAAIISUzMAAABR] mw1277 dewiki 1.36.0-wmf.20 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201212.gz:2020-12-12 03:17:38 
[X9Q1ugpAAEUAAJYMkXUB] mw1298 ptwiki 1.36.0-wmf.21 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201214.gz:2020-12-13 20:10:23 
[X9Z1KgpAEDYAAAoAZ7kAAABX] mw1289 enwiki 1.36.0-wmf.21 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201216.gz:2020-12-15 16:16:41 
[X9jhZwpAIDkAAL7FczQU] mw1345 arwiki 1.36.0-wmf.21 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201216.gz:2020-12-15 16:16:48 
[X9jhbgpAIDkAABKScUYAAADE] mw1345 arwiki 1.36.0-wmf.21 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201216.gz:2020-12-15 16:17:24 
[X9jhkQpAMN0AAkDDz0gAAABK] mw1379 arwiki 1.36.0-wmf.21 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201216.gz:2020-12-15 16:17:38 
[X9jhnwpAMN0AAkDD00MAAABS] mw1379 arwiki 1.36.0-wmf.21 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201216.gz:2020-12-15 16:18:16 
[X9jhxQpAMNsAACQMuL4AAACT] mw1377 arwiki 1.36.0-wmf.21 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201216.gz:2020-12-15 16:18:22 
[X9jhywpAEMMAACkulgMAAABF] mw1314 arwiki 1.36.0-wmf.21 Wikibase WARNING: 
Wikibase\Client\Usage\Sql\EntityUsageTable::makeUsageRows: skipping invalid 
page ID 0 (T264929) {"pageId":0} 
/srv/mw-log/archive/Wikibase.log-20201216.gz:2020-12-15 16:18:30 
[X9jh0wpAEKEAAq0bPhQAAAEJ] mw1400 arwiki 1.36.0-wmf.21 Wikibase WARNING:

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-12-18 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE moved this task from Peer Review to Stalled/Waiting on 
the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Lucas_Werkmeister_WMDE added a comment.


  Back to Stalled until the new logging is deployed.

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-12-18 Thread ReleaseTaggerBot 
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.25; 
2021-01-05); removed MW-1.36-notes (1.36.0-wmf.20; 2020-12-01).

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-12-18 Thread gerritbot 
gerritbot added a comment.


  Change 649362 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Skip 0 page ID in hook handler
  
  https://gerrit.wikimedia.org/r/649362

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-12-18 Thread gerritbot 
gerritbot added a comment.


  Change 649361 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Use LinksUpdate::$mId in hook handler
  
  https://gerrit.wikimedia.org/r/649361

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-12-14 Thread gerritbot 
gerritbot added a comment.


  Change 649362 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] Skip 0 page ID in hook handler
  
  https://gerrit.wikimedia.org/r/649362

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-12-14 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-12-14 Thread gerritbot 
gerritbot added a comment.


  Change 649361 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] Use LinksUpdate::$mId in hook handler
  
  https://gerrit.wikimedia.org/r/649361

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-12-14 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  I’m still confused where these IDs come from. I thought it might be from 
`LinksDeletionUpdate`, which is a subclass of `LinksUpdate` and probably runs 
the same hook, but the stack trace shows that’s not the case:
  
#4 
/srv/mediawiki/php-1.36.0-wmf.21/extensions/Wikibase/client/includes/Hooks/DataUpdateHookHandler.php(124):
 Wikibase\Client\Hooks\DataUpdateHookHandler->doLinksUpdateComplete(LinksUpdate)
#5 
/srv/mediawiki/php-1.36.0-wmf.21/includes/HookContainer/HookContainer.php(163): 
Wikibase\Client\Hooks\DataUpdateHookHandler->onLinksUpdateComplete(LinksUpdate, 
integer)
  
  These methods are being called with an instance of `LinksUpdate`, not 
`LinksDeletionUpdate`, unless I’m misunderstanding how PHP formats stack traces.
  
  However, while looking through the `LinksUpdate`/`LinksDeletionUpdate` code, 
I noticed the (parent) class has an `mId` member, which I guess we want to use 
instead of `->getTitle()->getArticleId()` – the `mId` looks like it’s more 
stable. (There’s no getter for `mId`, but the field itself is public, and the 
stable interface policy 
 says it’s stable to 
access public class fields.)

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-12-14 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Happened 10 times in the last 7 days (logstash 
), the 
invalid page ID is indeed 0, and it always seems to come from the 
`DataUpdateHookHandler`:
  
#0 
/srv/mediawiki/php-1.36.0-wmf.21/extensions/Wikibase/client/includes/Usage/Sql/EntityUsageTable.php(195):
 Wikibase\Client\Usage\Sql\EntityUsageTable->makeUsageRows(integer, array)
#1 
/srv/mediawiki/php-1.36.0-wmf.21/extensions/Wikibase/client/includes/Usage/Sql/SqlUsageTracker.php(224):
 Wikibase\Client\Usage\Sql\EntityUsageTable->addUsages(integer, array)
#2 
/srv/mediawiki/php-1.36.0-wmf.21/extensions/Wikibase/client/includes/Store/UsageUpdater.php(107):
 Wikibase\Client\Usage\Sql\SqlUsageTracker->replaceUsedEntities(integer, array)
#3 
/srv/mediawiki/php-1.36.0-wmf.21/extensions/Wikibase/client/includes/Hooks/DataUpdateHookHandler.php(135):
 Wikibase\Client\Store\UsageUpdater->replaceUsagesForPage(integer, array)
#4 
/srv/mediawiki/php-1.36.0-wmf.21/extensions/Wikibase/client/includes/Hooks/DataUpdateHookHandler.php(124):
 Wikibase\Client\Hooks\DataUpdateHookHandler->doLinksUpdateComplete(LinksUpdate)
#5 
/srv/mediawiki/php-1.36.0-wmf.21/includes/HookContainer/HookContainer.php(163): 
Wikibase\Client\Hooks\DataUpdateHookHandler->onLinksUpdateComplete(LinksUpdate, 
integer)
#6 
/srv/mediawiki/php-1.36.0-wmf.21/includes/HookContainer/HookRunner.php(2376): 
MediaWiki\HookContainer\HookContainer->run(string, array)
#7 /srv/mediawiki/php-1.36.0-wmf.21/includes/deferred/LinksUpdate.php(203): 
MediaWiki\HookContainer\HookRunner->onLinksUpdateComplete(LinksUpdate, integer)
#8 
/srv/mediawiki/php-1.36.0-wmf.21/includes/deferred/AutoCommitUpdate.php(44): 
LinksUpdate->{closure}(Wikimedia\Rdbms\MaintainableDBConnRef, string)
#9 
/srv/mediawiki/php-1.36.0-wmf.21/includes/deferred/DeferredUpdates.php(467): 
AutoCommitUpdate->doUpdate()
#10 
/srv/mediawiki/php-1.36.0-wmf.21/includes/deferred/DeferredUpdates.php(344): 
DeferredUpdates::attemptUpdate(AutoCommitUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#11 
/srv/mediawiki/php-1.36.0-wmf.21/includes/deferred/DeferredUpdates.php(288): 
DeferredUpdates::run(AutoCommitUpdate, Wikimedia\Rdbms\LBFactoryMulti, 
Monolog\Logger, BufferingStatsdDataFactory, string)
#12 
/srv/mediawiki/php-1.36.0-wmf.21/includes/deferred/DeferredUpdates.php(194): 
DeferredUpdates::handleUpdateQueue(array, string, integer)
#13 /srv/mediawiki/php-1.36.0-wmf.21/includes/MediaWiki.php(1118): 
DeferredUpdates::doUpdates(string)
#14 /srv/mediawiki/php-1.36.0-wmf.21/includes/MediaWiki.php(854): 
MediaWiki->restInPeace()
#15 /srv/mediawiki/php-1.36.0-wmf.21/includes/MediaWiki.php(866): 
MediaWiki->{closure}()
#16 /srv/mediawiki/php-1.36.0-wmf.21/api.php(125): 
MediaWiki->doPostOutputShutdown()
#17 /srv/mediawiki/php-1.36.0-wmf.21/api.php(45): wfApiMain()
#18 /srv/mediawiki/w/api.php(3): require(string)
#19 {main}
  
  Sometimes, as above, the stack trace ends in the API, sometimes it’s a job.

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-11-24 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE moved this task from Peer Review to Stalled/Waiting on 
the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Lucas_Werkmeister_WMDE added a comment.


  Moving to Stalled until wmf.20 is deployed next week, then we can start 
looking for the new log messages in Logstash.

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-11-24 Thread Maintenance_bot 
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, Maintenance_bot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g, Alter-paule, Beast1978, Un1tY, Hook696, Kent7301, joker88john, 
CucyNoiD, Gaboe420, Giuliamocci, Cpaulf30, Af420, Bsandipan, Lewizho99, 
Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-11-24 Thread ReleaseTaggerBot 
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.20; 2020-12-01).

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, ReleaseTaggerBot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-11-24 Thread gerritbot 
gerritbot added a comment.


  Change 642452 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] Log+skip bad page IDs when 
reading/writing entity usage
  
  https://gerrit.wikimedia.org/r/642452

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-11-20 Thread gerritbot 
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, 
Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Iflorez, darthmon_wmde, 
Kent7301, alaa_wmde, joker88john, CucyNoiD, Nandana, Gaboe420, lucamauri, 
Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, 
QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-11-20 Thread gerritbot 
gerritbot added a comment.


  Change 642452 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] Log+skip bad page IDs when 
reading/writing entity usage
  
  https://gerrit.wikimedia.org/r/642452

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE, gerritbot
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-11-20 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Okay, I don’t know where these bad page IDs would be coming from. 
`eu_page_id` is only written from very few places:
  
  - `AddUsagesForPageJob::run()` → `UsageUpdater::addUsagesForPage()` → 
`SqlUsageTracker::addUsedEntities()` → `EntityUsageTable::addUsages()` – but 
`AddUsagesForPageJob` asserts in the constructor that the page ID is greater 
than 0
  - `DataUpdateHookHandler::onLinksUpdateComplete()` → 
``DataUpdateHookHandler::doLinksUpdateComplete()` → 
`UsageUpdater::replaceUsagesForPage()` → 
`SqlUsageTracker::replaceUsedEntities()` → `EntityUsageTable::addUsages()` – 
but while the `LinksUpdateComplete` hook runs as a deferred update (see 
`LinksUpdate::doUpdate()`), the `DataUpdateHookHandler` gets the page ID from 
the `LinksUpdate`’s `Title` object, so even if the page is deleted in the 
meantime, as far as I can tell the page ID should still be nonzero, since I 
don’t see how the `Title` would know that its page ID was no longer valid
  
  I suggest adding some logging for when invalid page IDs are written (probably 
at Warning level) and then looking at the stack traces of those warnings in 
logstash (if they happen at all).

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-11-20 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from To Do (prioritised from top to 
bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞) board.
Lucas_Werkmeister_WMDE added a comment.


  Claiming this since I already started to look a bit more into it.

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-11-20 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  The stack trace looks like we’re getting the bad page ID from the database; 
`EntityUsageTable::getPagesUsing()` reads the `eu_page_id` from the 
`wbc_entity_usage` table, and then `foldRowsIntoPageEntityUsages()` passes the 
`$pageId` into the `PageEntityUsages` constructor, which complains if it’s not 
an int or less than one. (`foldRowsIntoPageEntityUsages()` casts it to `int`, 
so I think the `< 1` is the only relevant part of that condition.)
  
  However, I can’t find any such rows in the arwiki or dewiki tables now (the 
two wikis where this error is found in logstash):
  
MariaDB [arwiki]> SELECT * FROM wbc_entity_usage WHERE eu_page_id < 1 OR 
eu_page_id IS NULL LIMIT 10;
Empty set (0.001 sec)

MariaDB [dewiki]> SELECT * FROM wbc_entity_usage WHERE eu_page_id < 1 OR 
eu_page_id IS NULL LIMIT 10;
Empty set (0.001 sec)
  
  So I’m guessing that this is a transient situation that resolves itself after 
a while.

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-11-20 Thread WMDE-leszek 
WMDE-leszek moved this task from Prioritized Tech (prioritised from top to 
bottom) to Wikidata-Campsite-Iteration-∞ on the Wikidata-Campsite board.
WMDE-leszek edited projects, added Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞); removed Wikidata-Campsite.

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3402/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, Akuckartz, 
Iflorez, darthmon_wmde, alaa_wmde, Nandana, lucamauri, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Verdy_p, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, 
Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-11-20 Thread WMDE-leszek 
WMDE-leszek added a comment.


  Start with: Investigate (4h max) how to reproduce this error in the local 
environment. 
  Update the description with the details discovered

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: WMDE-leszek
Cc: WMDE-leszek, Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, Akuckartz, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, 
aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-11-20 Thread Lucas_Werkmeister_WMDE 
Lucas_Werkmeister_WMDE added a comment.


  Seems to happen a handful of times per week: 
https://logstash.wikimedia.org/goto/852228f37c434dacb72cec6ffe618ab8

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Michael, Aklapper, BPirkle, Akuckartz, 
darthmon_wmde, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Verdy_p, Wikidata-bugs, 
aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-10-13 Thread Michael 
Michael added a comment.


  I got this error in the frontend on a deleted item: 
https://www.wikidata.org/wiki/Q99297838

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Michael, Aklapper, BPirkle, Akuckartz, darthmon_wmde, Nandana, lucamauri, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, 
Mbch331, Rxy, Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

[Wikidata-bugs] [Maniphest] T264929: $pageId must be an integer > 0

2020-10-07 Thread BPirkle 
BPirkle created this task.
BPirkle added projects: Wikimedia-production-error, Wikidata-Campsite, 
MediaWiki-extensions-WikibaseClient.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  Error
  -
  
  `MediaWiki version:`  **`1.36.0-wmf.10`**
  
  name=message
$pageId must be an integer > 0
  
  
  
  Impact
  --
  
  Notes
  -
  
  See https://phabricator.wikimedia.org/T114352 (old ticket)
  
  exception.class: InvalidArgumentException
  exception.code: 0

TASK DETAIL
  https://phabricator.wikimedia.org/T264929

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: BPirkle
Cc: Aklapper, BPirkle, Akuckartz, darthmon_wmde, Nandana, lucamauri, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, 
Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Jdforrester-WMF, Mbch331, Rxy, 
Jay8g, Krenair
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs