[Wikidata-bugs] [Maniphest] [Commented On] T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field

2019-06-21 Thread ericP
ericP added a comment.


  The RDF model asserts that a literal with a langtag is considered to have a 
datatype of `rdf:langString`. The various formats state exactly how literals 
with langtags are written. The former specifies how APIs behave, such as a 
SPARQL FILTER ```DATATYPE("ab"@es) = rdf:langTag```; the latter specifies how 
they are written. The rules for the XML and JSON results formats are that the 
implicit datatype of langtagged literals  is omitted.
  
  I can see how this is confusing but I believe the community doesn't see them 
as conflicting.  Also, sadly, it seems that these are covered for the XML 
results format (look for `xml:lang` in the results for strlang03 
, 
but not for JSON.

TASK DETAIL
  https://phabricator.wikimedia.org/T225996

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: ericP
Cc: ericP, Smalyshev, Lucas_Werkmeister_WMDE, Fnielsen, Aklapper, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, _jensen, rosalieper, Cirdan, Jonas, Xmlizer, jkroll, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unblock] T192006: wdqs-frontend docker image should (BLUBBER) rebuild automatically when a new patch is pushed to master

2019-06-21 Thread hashar
hashar closed subtask T209292: Create a wmf production ready nginx image as 
Declined.

TASK DETAIL
  https://phabricator.wikimedia.org/T192006

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: Ladsgroup, LarsWirzenius, Lydia_Pintscher, Joe, gerritbot, akosiaris, 
thcipriani, Addshore, Aklapper, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, darthmon_wmde, Jelabra, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, mobrovac, 
Wikidata-bugs, aude, dduvall, Jdforrester-WMF, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Declined] T209292: Create a wmf production ready nginx image

2019-06-21 Thread hashar
hashar added a project: serviceops.
hashar closed this task as "Declined".
hashar added a comment.


  This was for #serviceops !
  
  But I decline the task based on @Ladsgroup comment which it would be better 
to have the application to use NodeJS / service-runner like most of the other 
MediaWiki services.

TASK DETAIL
  https://phabricator.wikimedia.org/T209292

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: Ladsgroup, hashar, fsero, Aklapper, thcipriani, Joe, Addshore, 
darthmon_wmde, Jelabra, Legado_Shulgin, Nandana, thifranc, AndyTan, 
Davinaclare77, Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, 
QZanden, LawExplorer, Zppix, _jensen, rosalieper, Wong128hk, mobrovac, 
Wikidata-bugs, aude, dduvall, faidon, Jdforrester-WMF, Mbch331, Jay8g, 
fgiunchedi, Dzahn
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226084: Wikidata server slow

2019-06-21 Thread Magnus
Magnus added a comment.


  In T226084#5271761 , 
@Krinkle wrote:
  
  > @Magnus It is well-known currently that MediaWiki exposes many powerful API 
that we do not support to perform well, but allow regardless as a convenience 
service. If we were stricter about response times for all features, we'd 
probably just turn many of them off and limit the capabilities of those APIs 
until and unless the amount of resources required to make them work reliably 
fast is justified.
  >
  > I expect the maintainers of this API to have tested the supported and 
encouraged use cases and to know whether they are fast. I haven't personally 
looked at the p99 for this particular API, but from experience in other 
endpoints, it tends to be extreme cases that we'd be very unlikely to support 
with fast responses.
  >
  > But if they haven't in a while, it's certainly worth looking at those again 
from time to time.
  
  
  That's not what the issue is about.
  
  If a query usually runs 1-3sec, no problem if it takes 10, or 30 in rare 
cases. This issue is different because:
  
  - timing differences are extreme. 3sec vs 3min
  - this kind of thing is new, as in a few days ago, when it's been working 
fine for years
  - the exact same query, run again, will very likely return in the usual short 
time
  - the extremely long response makes tools unusable. If I'd get an error I 
could possibly recover, but just waiting is not easily caught
  - the extremely long response breaks some default settings, e.g. the one I 
use for my Rust tools
  
  This all points to a single point of failure, either on the response 
generation or on the transport. Trying to weasle out of it with "APIs are 
complicated" is not helpful.
  
  > Meanwhile, do let us know if you find a response with a slow value recorded 
in the Backend-Timing header. You can use this to see whether the time was 
spent on the web server or in transportation/routing. If it's in routing that 
still doesn't mean it's outside Wikimedia control, we do influence a lot of the 
routes between DCs and for ISPs/peering and BGP stuff. It just helps narrow it 
down.
  
  How would I "find a response with a slow value recorded in the Backend-Timing 
header"? I think I have posted all the data I can get from slow responses.

TASK DETAIL
  https://phabricator.wikimedia.org/T226084

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Magnus
Cc: Tgr, Krinkle, jcrespo, Addshore, alaa_wmde, Lea_Lacroix_WMDE, WMDE-leszek, 
Aklapper, Magnus, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226084: Wikidata server slow

2019-06-21 Thread Magnus
Magnus added a comment.


  On another note, the Reasonator example in my original post seems to load 
now. I'll check if the Rust code works as well now.

TASK DETAIL
  https://phabricator.wikimedia.org/T226084

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Magnus
Cc: Tgr, Krinkle, jcrespo, Addshore, alaa_wmde, Lea_Lacroix_WMDE, WMDE-leszek, 
Aklapper, Magnus, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T226153: Remove BETA from Wikidata entities dump

2019-06-21 Thread Lea_Lacroix_WMDE
Lea_Lacroix_WMDE added subscribers: Envlh, Maxlath, Hydriz, hoo.
Lea_Lacroix_WMDE added a comment.


  Pinging @hoo @Envlh @Hydriz @Maxlath FYI

TASK DETAIL
  https://phabricator.wikimedia.org/T226153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lea_Lacroix_WMDE
Cc: hoo, Hydriz, Maxlath, Envlh, Lea_Lacroix_WMDE, ArielGlenn, Smalyshev, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, 
CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, 
Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, 
Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, Adik2382, 
Lunewa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, LawExplorer, 
WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Cirdan, Jonas, Xmlizer, 
gnosygnu, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T217018: Upgrade Wikibase extension to use newer phan

2019-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE removed a project: Wikidata-Campsite 
(Wikidata-TechDebt-Exploration).

TASK DETAIL
  https://phabricator.wikimedia.org/T217018

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: MaxSem, Lucas_Werkmeister_WMDE
Cc: hashar, Jdforrester-WMF, gerritbot, Aklapper, Lucas_Werkmeister_WMDE, 
darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, 
_jensen, rosalieper, Wikidata-bugs, aude, Mbch331, Jonas, Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field

2019-06-21 Thread Andrawaag
Andrawaag added a comment.


  The Wikidata app in Cytoscape  
is also affected by this. F29609064: Screenshot 2019-06-21 at 10.46.41.png 


TASK DETAIL
  https://phabricator.wikimedia.org/T225996

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Andrawaag
Cc: Andrawaag, Lydia_Pintscher, Lea_Lacroix_WMDE, ericP, Smalyshev, 
Lucas_Werkmeister_WMDE, Fnielsen, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, 
Cirdan, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, 
Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Andrawaag
Andrawaag updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T226238

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Andrawaag
Cc: Jane023, Andrawaag, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

2019-06-21 Thread Multichill
Multichill added a subscriber: Bene.
Multichill added a comment.


  Serialization:
  
  - 
https://github.com/wmde/WikibaseDataModelSerialization/blob/master/src/Serializers/ItemSerializer.php#L127
  - 
https://github.com/wikimedia/mediawiki-extensions-WikibaseMediaInfo/blob/master/src/DataModel/Serialization/MediaInfoSerializer.php#L82
  
  And the other way around:
  
  - 
https://github.com/wmde/WikibaseDataModelSerialization/blob/master/src/Deserializers/ItemDeserializer.php#L125
  - 
https://github.com/wikimedia/mediawiki-extensions-WikibaseMediaInfo/blob/master/src/DataModel/Serialization/MediaInfoDeserializer.php#L122

TASK DETAIL
  https://phabricator.wikimedia.org/T149410

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Multichill
Cc: Bene, Lucas_Werkmeister_WMDE, Ramsey-WMF, Keegan, Multichill, Magnus, 
Addshore, matthiasmullie, Aklapper, Ladsgroup, aude, Lydia_Pintscher, 
thiemowmde, daniel, hoo, darthmon_wmde, Nandana, JKSTNK, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
Ricordisamoa, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

2019-06-21 Thread Multichill
Multichill added a subscriber: Lucas_Werkmeister_WMDE.
Multichill added a comment.


  Another inconsistency pointed out by @Lucas_Werkmeister_WMDE is at T222159 


TASK DETAIL
  https://phabricator.wikimedia.org/T149410

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Multichill
Cc: Lucas_Werkmeister_WMDE, Ramsey-WMF, Keegan, Multichill, Magnus, Addshore, 
matthiasmullie, Aklapper, Ladsgroup, aude, Lydia_Pintscher, thiemowmde, daniel, 
hoo, darthmon_wmde, Nandana, JKSTNK, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, Ricordisamoa, Jdforrester-WMF, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Reedy
Reedy added a project: Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T226238

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Reedy
Cc: Jane023, Andrawaag, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T222159: WikibaseMediaInfo serializes empty statements as empty array [] instead of empty object {} in JSON

2019-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T222159

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, Nandana, JKSTNK, Lahi, 
Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, V4switch, LawExplorer, _jensen, 
rosalieper, Wong128hk, Wikidata-bugs, matthiasmullie, aude, Ricordisamoa, 
Lydia_Pintscher, Fabrice_Florin, Jdforrester-WMF, Matanya, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Jane023
Jane023 added a comment.


  I am back and after checking, happy to report I was right. One is the town, 
and the other is the municipality. They are not the same and should not be 
merged.

TASK DETAIL
  https://phabricator.wikimedia.org/T226238

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jane023
Cc: Jane023, Andrawaag, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Michael
Michael created this task.
Michael added projects: Wikidata-Campsite, User-Michael, 
Continuous-Integration-Config, phan.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  Currently, all Lexeme builds fail with an error in phan:
  
  counterexample
[InvalidArgumentException]
Package phan/phan at version 0.8 has a PHP requirement incompatible with 
your PHP version (7.2.16)
  
  As far as I can see, this might be caused by the interplay of 3 different 
patches. First having WikibaseLexeme's phan integration-config explicitly 
depend on Wikibase  for T225524 
, then adjusting Wikibase's local 
phan configuration to use phan 1.3.4  
for T217018: Upgrade Wikibase extension to use newer phan 
 and finally to raise the php 
version of the phan runner for Wikibase in the integration config from 7.0 to 
7.2 . However, that left WikibaseLexeme 
with the old phan 0.8, but a new PHP 7.2 phan runner.
  
  Full log:
  
00:01:17.870 [mwext-php72-phan-docker] $ /bin/bash -eu 
/tmp/jenkins1200382226019678461.sh
00:01:17.874 + chmod 2777 src
00:01:17.900 [mwext-php72-phan-docker] $ /bin/bash 
/tmp/jenkins6530407008460609516.sh
00:01:17.903 ++ pwd
00:01:17.903 ++ pwd
00:01:17.904 ++ pwd
00:01:17.905 ++ pwd
00:01:17.906 + exec docker run --volume 
/srv/jenkins-workspace/workspace/mwext-php72-phan-docker/src:/mediawiki 
--volume /srv/jenkins-workspace/workspace/mwext-php72-phan-docker/src:/src 
--volume /srv/jenkins-workspace/workspace/mwext-php72-phan-docker/cache:/cache 
--volume /srv/jenkins-workspace/workspace/mwext-php72-phan-docker/log:/log 
--init --rm --label jenkins.job=mwext-php72-phan-docker --label 
jenkins.build=278 --env-file /dev/fd/63 
docker-registry.wikimedia.org/releng/mediawiki-phan:0.3.0 -m checkstyle
00:01:17.908 ++ /usr/bin/env
00:01:17.908 ++ egrep -v 
'^(HOME|SHELL|PATH|LOGNAME|MAIL|HHVM_REPO_CENTRAL_PATH)='
00:01:18.311 + umask 002
00:01:18.311 + cd /mediawiki/extensions/WikibaseLexeme
00:01:18.311 + '[' '!' -f 
/mediawiki/extensions/WikibaseLexeme/.phan/config.php ']'
00:01:18.311 + jq -e '.extra."phan"' composer.json
00:01:18.312 null
00:01:18.312 + 
CFG_COMPOSER=vendor/mediawiki/mediawiki-phan-config/composer.json
00:01:18.313 + jq -e '.extra."phan"' 
vendor/mediawiki/mediawiki-phan-config/composer.json
00:01:18.317 jq: error: Could not open file 
vendor/mediawiki/mediawiki-phan-config/composer.json: No such file or directory
00:01:18.318 + PHAN_VERSION=0.8
00:01:18.318 + '[' -f .phan/config.php ']'
00:01:18.318 + export PHP_ARGS=-dextension=ast_101.so
00:01:18.318 + PHP_ARGS=-dextension=ast_101.so
00:01:18.318 + install_phan
00:01:18.318 + cd /srv/phan
00:01:18.319 + composer require phan/phan:0.8
00:01:19.466 
00:01:19.477
   
00:01:19.478   [InvalidArgumentException]   
   
00:01:19.478   Package phan/phan at version 0.8 has a PHP requirement 
incompatible with your PHP version (7.2.16)

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Jdforrester-WMF, Michael, darthmon_wmde, Redabr4, Zanziii, 
Sadisticturd, Nandana, A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331, hashar, Daimona
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Andrawaag
Andrawaag added a comment.


  In T226238#5273387 , 
@Jane023 wrote:
  
  > I am back and after checking, happy to report I was right. One is the town, 
and the other is the municipality. They are not the same and should not be 
merged.
  
  
  Can you elaborate a bit more on this? I am trying to understand these ceb 
originated statements, but I don't speak ceb and most of the ceb originated 
statements are poorly referenced. If you look at the specific wikidata page you 
argue should not be merged, it is hard to see what it actually is and why it 
should stay a Wikidata item on its own merit. Except for two statements (P31 
 and P625 
), none of the statements has 
references. Based on both having P31  -> 
city, it makes sense to merge those.

TASK DETAIL
  https://phabricator.wikimedia.org/T226238

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Andrawaag
Cc: Jane023, Andrawaag, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Michael
Michael triaged this task as "High" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Jdforrester-WMF, Michael, darthmon_wmde, Redabr4, Zanziii, 
Sadisticturd, Nandana, A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331, hashar
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Michael
Michael updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Aklapper, Jdforrester-WMF, Michael, darthmon_wmde, Redabr4, Zanziii, 
Sadisticturd, Nandana, A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331, hashar
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Jane023
Jane023 added a comment.


  The message you received was correct. There is a help page for this: 
https://www.wikidata.org/wiki/Help:Merge

TASK DETAIL
  https://phabricator.wikimedia.org/T226238

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jane023
Cc: Jane023, Andrawaag, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T209803: wikibaseImport in the docker images does not add statements when importing an entity

2019-06-21 Thread DD063520
DD063520 added a comment.


  I have some other pull requests that I didn't do up to now because they seam 
not to be accepted:
  
  1. adds a property Wikidata ID so that one has a link between the new and the 
old entities
  2. some refactoring making the import faster
  3. a bug about the number of statements of entities
  
  Salut
  Dennis
  
  PS the problem is that I'm not a php coder so the code might not have hight 
quality

TASK DETAIL
  https://phabricator.wikimedia.org/T209803

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: DD063520
Cc: Addshore, Lydia_Pintscher, aude, DD063520, dbs, erik_s_paulson, Aklapper, 
darthmon_wmde, Jelabra, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T225950: 3.- Jest unit test + CI

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 518228 had a related patch set uploaded (by Pablo Grass (WMDE); owner: 
Pablo Grass (WMDE)):
  [mediawiki/extensions/Wikibase@master] tests: allow jest watch inside 
container
  
  https://gerrit.wikimedia.org/r/518228

TASK DETAIL
  https://phabricator.wikimedia.org/T225950

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, gerritbot
Cc: Pablo-WMDE, Aklapper, darthmon_wmde, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Andrawaag
Andrawaag added a comment.


  In T226238#5273312 , 
@Aklapper wrote:
  
  > @Andrawaag: What is "Merge Wizard"? Where to find / see Merge Wizard? Is 
this on wikidata.org ? Please include steps to reproduce and set a project tag, 
if possible, so someone else can find this task. Thanks!
  
  
  I added additional screen-dumps. I was assuming this is a default wikidata 
feature, but I guess its something I installed a long time ago.

TASK DETAIL
  https://phabricator.wikimedia.org/T226238

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Andrawaag
Cc: Jane023, Andrawaag, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

2019-06-21 Thread Multichill
Multichill added a comment.


  Magnus ran into this and this is very confusing and inconsistent. The longer 
we wait with fixing this, the more effort it will cost. Example 
https://commons.wikimedia.org/w/api.php?action=wbgetentities=M27401711 uses 
"statements" as the key, but we expect "claims" as the key, like 
https://commons.wikimedia.org/w/api.php?action=wbgetentities=Q422341 . This 
is also consistent with the api calls like 
https://commons.wikimedia.org/w/api.php?action=help=wbcreateclaim , 
https://commons.wikimedia.org/w/api.php?action=wbgetclaims=M27401711 , 
https://commons.wikimedia.org/w/api.php?action=help=wbremoveclaims and 
https://commons.wikimedia.org/w/api.php?action=help=wbsetclaim
  
  By the way, I noticed another difference: The imageinfo output doesn't 
contain the line "datatype": "wikibase-item". Not sure if this is related or 
not?

TASK DETAIL
  https://phabricator.wikimedia.org/T149410

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Multichill
Cc: Ramsey-WMF, Keegan, Multichill, Magnus, Addshore, matthiasmullie, Aklapper, 
Ladsgroup, aude, Lydia_Pintscher, thiemowmde, daniel, hoo, darthmon_wmde, 
Nandana, JKSTNK, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Wikidata-bugs, Ricordisamoa, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T225603: Wire up read logic for normalized storage in Wikibase

2019-06-21 Thread alaa_wmde
alaa_wmde added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞).

TASK DETAIL
  https://phabricator.wikimedia.org/T225603

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, Aklapper, Lucas_Werkmeister_WMDE, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T226153: Remove BETA from Wikidata entities dump

2019-06-21 Thread Maxlath
Maxlath added a subscriber: nichtich.
Maxlath added a comment.


  ping @nichtich

TASK DETAIL
  https://phabricator.wikimedia.org/T226153

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maxlath
Cc: nichtich, hoo, Hydriz, Maxlath, Envlh, Lea_Lacroix_WMDE, ArielGlenn, 
Smalyshev, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Lucas_Werkmeister_WMDE, GoranSMilovanovic, 
Adik2382, Lunewa, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, merbst, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Cirdan, Jonas, 
Xmlizer, gnosygnu, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, 
Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T223968: Split Wikibase tests into unit and integration tests

2019-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE removed a project: Wikidata-Campsite 
(Wikidata-TechDebt-Exploration).

TASK DETAIL
  https://phabricator.wikimedia.org/T223968

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, Michael, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331, Jonas, 
Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T223214: Start converting Wikibase extensions to use extension registration

2019-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE removed a project: Wikidata-Campsite 
(Wikidata-TechDebt-Exploration).

TASK DETAIL
  https://phabricator.wikimedia.org/T223214

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Agabi10, Michael, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Ferenczy, sarhan.alaa, 
Samuditha24, IM3847, joker88john, CucyNoiD, Nandana, NebulousIris, kostajh, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Jayprakash12345, Chicocvenancio, Th3d3v1ls, Ramalepe, 
MichaelSchoenitzer_WMDE, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, Jogi_don, _jensen, rosalieper, D3r1ck01, Izno, Wikidata-bugs, 
Jdlrobson, aude, Dinoguy1000, Mbch331, Rxy, Jay8g, Jonas, Lydia_Pintscher
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T221315: Determine future of bare-metal hosting for services like WDQS, ElasticSearch, RESTBase Cassandra, etc.

2019-06-21 Thread jijiki
jijiki triaged this task as "Low" priority.

TASK DETAIL
  https://phabricator.wikimedia.org/T221315

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jijiki
Cc: EBernhardson, MoritzMuehlenhoff, mobrovac, Smalyshev, Jdforrester-WMF, 
Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, Lucas_Werkmeister_WMDE, 
GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, 
Jonas, Xmlizer, Eevans, thcipriani, jkroll, Hardikj, Wikidata-bugs, Jdouglas, 
aude, Tobias1984, GWicke, Manybubbles, Gryllida, dduvall, Mbch331, Jay8g, Dzahn
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread noarave
noarave added a comment.


  @Daimona unfortunately requiring phan config 0.6.1 in composer.json did not 
seem to have an effect.

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, Zanziii, 
Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, hashar
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T225935: Implement Feature Flag for Mediawiki

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 517657 **merged** by jenkins-bot:
  [mediawiki/extensions/Wikibase@master] bridge: Add feature flag to enable 
Wikidata bridge
  
  https://gerrit.wikimedia.org/r/517657

TASK DETAIL
  https://phabricator.wikimedia.org/T225935

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, gerritbot
Cc: Aklapper, darthmon_wmde, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread alaa_wmde
alaa_wmde added a comment.


  @Daimona understood. I also think the clean-up work is necessary. I'm not 
such a fan of statements of the sort "extensions must use mediawiki config 
rather than overriding/changing them" but that's a separate topic anyway.
  
  > At this point, I'd like to fix all issues reported for my patch, but that 
could take some time. And at the end, the same config change will have to be 
applied to Wikibase itself.
  
  I would actually like to merge my patch first to fix the build first.. your 
patch can then rebase on it. Is that fine by you?

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread alaa_wmde
alaa_wmde added a comment.


  > Ah, I haven't been clear. Extensions *should* override the default config, 
e.g. to define additional dependencies (many extensions do that). But it's 
vital that the default config is first included, then overridden for the 
necessary part. What happened for Lexeme (and WB itself) is that the default 
config has just been copypasted. And you'll probably agree that copypastas are 
always very bad for maintainability in the long term.
  
  Ah I see .. I might have also read through your comment too quickly .. thanks 
for the second clarification.
  
  > Definitely, I implicitly meant that.
  
  Awesome! thanks for taking care of the clean-up too :)

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unblock] T225937: Implement Bridge Setup

2019-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T225935: Implement Feature Flag for 
Mediawiki as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T225937

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T206256: Un-redirected items should be instant-indexed

2019-06-21 Thread debt
debt closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T206256

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev, debt
Cc: Aklapper, Sjoerddebruin, Smalyshev, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, jayvdb, Mbch331, jeremyb
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T55652: Special:Search doesn't use labels and descriptions for suggestions but just the item ID

2019-06-21 Thread debt
debt closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T55652

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev, debt
Cc: Lea_Lacroix_WMDE, gerritbot, Smalyshev, Wikidata-bugs, Yair_rand, 
Lydia_Pintscher, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, EBjune, LawExplorer, _jensen, rosalieper, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unblock] T46529: Wikidata search problems (tracking)

2019-06-21 Thread debt
debt closed subtask T55652: Special:Search doesnt use labels and 
descriptions for suggestions but just the item ID as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T46529

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: debt
Cc: Liuxinyu970226, PokestarFan, Smalyshev, Wikidata-bugs, Nemo_bis, Aklapper, 
darthmon_wmde, Nickleh, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T223372: Constraint was removed from property but still displayed on Lexeme

2019-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE added a comment.


  Note: after the fix is deployed, we should also run 
`extensions/WikibaseQualityConstraints/maintenance/ImportConstraintStatements.php`
 to fix the constraints for all current properties without having to wait for 
the next constraint statements edit.

TASK DETAIL
  https://phabricator.wikimedia.org/T223372

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Michael, Lucas_Werkmeister_WMDE, WMDE-leszek, Lydia_Pintscher, 
Lea_Lacroix_WMDE, Aklapper, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, 
darthmon_wmde, alaa_wmde, joker88john, CucyNoiD, Nandana, NebulousIris, 
Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Agabi10, Jonas, Wikidata-bugs, aude, 
Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread jjkoehorst
jjkoehorst added a comment.


  So if I understand it correctly, Q33512910 is the historical entity of 
Wageningen and Q1305 is the current city of Wageningen? What exactly is meant 
by historical? 100 years, 10 years? ... Also can we not report in the current 
wageningen historical changes using e.g. the end time property? In the "old" 
city it should then be clearly mentioned that this is an old city with a rough 
end estimation or not?

TASK DETAIL
  https://phabricator.wikimedia.org/T226238

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: jjkoehorst
Cc: jjkoehorst, Jane023, Andrawaag, Aklapper, darthmon_wmde, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona
Daimona added a comment.


  @noarave It actually did. It's just that phan completed its analysis and 
found several errors. Of note, you should also add a phan config file - I can 
amend your patch, although I don't know if I'll have time to fix all the errors.
  @hashar Actually, it's not Lexeme. It's the phan runner, specifically this 
line 

 which chooses 0.8.0 as fallback if it cannot find phan in the composer. So 
basically, this issue also affects any repo where no phan version is specified. 
Changing the fallback option to phan 1.3.4 could solve it - unless it creates 
more troubles.

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, Zanziii, 
Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T225952: 4.- Linting

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 518246 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [mediawiki/extensions/Wikibase@master] bridge: also apply eslint to own 
config file
  
  https://gerrit.wikimedia.org/r/518246

TASK DETAIL
  https://phabricator.wikimedia.org/T225952

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Matthias_Geisler_WMDE, gerritbot
Cc: Aklapper, darthmon_wmde, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T226254: Fix and unsuppress reported Phan errors on WikibaseLexeme

2019-06-21 Thread alaa_wmde
alaa_wmde updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T226254

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: Aklapper, alaa_wmde, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona
Daimona added a comment.


  In T226244#5273866 , 
@alaa_wmde wrote:
  
  > @Daimona understood. I also think the clean-up work is necessary. I'm not 
such a fan of statements of the sort "extensions must use mediawiki config 
rather than overriding/changing them" but that's a separate topic anyway.
  
  
  Ah, I haven't been clear. Extensions *should* override the default config, 
e.g. to define additional dependencies (many extensions do that). But it's 
vital that the default config is first included, then overridden for the 
necessary part. What happened for Lexeme (and WB itself) is that the default 
config has just been copypasted. And you'll probably agree that copypastas are 
always very bad for maintainability in the long term.
  
  > I would actually like to merge my patch first to fix the build first.. your 
patch can then rebase on it. Is that fine by you?
  
  Definitely, I implicitly meant that.

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T225952: 4.- Linting

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 518246 abandoned by Lucas Werkmeister (WMDE):
  bridge: also apply eslint to own config file
  
  Reason:
  squashed into parent change
  
  https://gerrit.wikimedia.org/r/518246

TASK DETAIL
  https://phabricator.wikimedia.org/T225952

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Matthias_Geisler_WMDE, gerritbot
Cc: Aklapper, darthmon_wmde, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Jane023
Jane023 added a comment.


  No I have not explained it well then. Try to think of it in terms of postal 
districts or voting districts. As a town grows, generally neighboring villages 
are annexed, but they do not lose their postal codes or voting district names. 
This is just as true for the original "core" district as it is for any other 
municipal district. In this case the core district and the wider municipal area 
have the same name. That is all.

TASK DETAIL
  https://phabricator.wikimedia.org/T226238

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jane023
Cc: jjkoehorst, Jane023, Andrawaag, Aklapper, darthmon_wmde, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T226254: Fix and unsuppress reported Phan errors on WikibaseLexeme

2019-06-21 Thread alaa_wmde
alaa_wmde updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T226254

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: Aklapper, alaa_wmde, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T225935: Implement Feature Flag for Mediawiki

2019-06-21 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T225935

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Maintenance_bot
Cc: Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, joker88john, 
CucyNoiD, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Baloch007, Darkminds3113, Bsandipan, Lordiis, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, WSH1906, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 518256 had a related patch set uploaded (by Daimona Eaytoy; owner: 
Daimona Eaytoy):
  [mediawiki/extensions/WikibaseLexeme@master] [WIP] Update phan, cleanup config
  
  https://gerrit.wikimedia.org/r/518256

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 518248 **merged** by jenkins-bot:
  [wikibase/termbox@master] Re-add padding to externally styled `.external` link
  
  https://gerrit.wikimedia.org/r/518248

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona
Daimona added a comment.


  AIUI, only the last mentioned patch is culprit. The dependency on Wikibase 
should only be used to tell what MW extensions to install before testing 
Lexeme, but that shouldn't be related to the phan version to use. What 
happened, instead, is that IMHO phan72 jobs were made live too early. 
Currently, the phan runner still supports phan 0.8.0, which in turn can only 
run on PHP70. Lexeme doesn't specify a phan version to run, and for some reason 
the 0.8.0 version is picked.
  I think some solutions could be to:
  
  1. Explicitly require phan config 0.6.1 in Lexeme's composer.json
  2. Make the phan72 job install a recent version of phan (not 0.8.0)
  
  CC @Jdforrester-WMF

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: Daimona, Aklapper, Jdforrester-WMF, Michael, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, Nandana, A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, hashar
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Daimona, Aklapper, Jdforrester-WMF, Michael, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, Zanziii, Sadisticturd, 
joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, A.S.Kochergin, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, 
Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, 
Mbch331, hashar
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Jane023
Jane023 added a comment.


  Yes sorry if the statements seem so ambiguous, this is just one of many cases 
where such things occur. One is a historic city and one is a current city. The 
problem probably arises because there is so little left of the original 
historic center in today's city, due to WWII bombing. The maps of both should 
make it clear, as do the titles in cebwiki themselves, which simply reflect the 
Dutch. A municipality has generally over time annexed various lands due to 
growth. The historic city limits generally follow some historic city wall 
footprint, though in this case it is hard to tell.

TASK DETAIL
  https://phabricator.wikimedia.org/T226238

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Jane023
Cc: Jane023, Andrawaag, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 518236 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
  [mediawiki/extensions/WikibaseLexeme@master] Use newer phan version on 
WikibaseLexeme
  
  https://gerrit.wikimedia.org/r/518236

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Daimona, Aklapper, Jdforrester-WMF, Michael, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, Nandana, A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331, hashar
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

2019-06-21 Thread gerritbot
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T225212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Krinkle, Aklapper, Lucas_Werkmeister_WMDE, hoo, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T225212: Specify $wgWBRepoSettings['conceptBaseUri']

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 518239 had a related patch set uploaded (by Lucas Werkmeister (WMDE); 
owner: Lucas Werkmeister (WMDE)):
  [operations/mediawiki-config@master] Specify 
$wgWBRepoSettings['conceptBaseUri'] again
  
  https://gerrit.wikimedia.org/r/518239

TASK DETAIL
  https://phabricator.wikimedia.org/T225212

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Krinkle, Aklapper, Lucas_Werkmeister_WMDE, hoo, darthmon_wmde, Nandana, 
Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread hashar
hashar added a comment.


  That did cause the container to trigger the installation of phan 1.3.4 
instead of the outdated 0.8.0 fallback.
  
  
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/518236/
 now fails because of new Phan reported errors. I guess the easiest is to just 
suppress them using `@suppress` comment:
  https://github.com/phan/phan/wiki/Annotating-Your-Source-Code#suppress
  
  I guess we have missed WikibaseLexeme was still using 0.8.0 :-\

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, Zanziii, 
Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread alaa_wmde
alaa_wmde added a comment.


  Another possible source?
  WikibaseLexeme `.phan/config.php` looks different from Wikibase one.
  
  For example, one reported error on Lexeme build:
  
12:37:08   
12:37:08 
12:37:08   
  
  Looking in Lexemes phan config, `PhanUnreferencedUseNormal` is not configured 
to be ignored, while it is configured to be ignored in Wikibase 
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/Wikibase/+/refs/heads/master/.phan/config.php#371
  
  So ignoring those checks for now in Lexeme phan config should as well be 
enough until we enable them again later and fix one by one

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T225930: Implement Link Counter

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 518255 had a related patch set uploaded (by Michael Große; owner: 
Michael Große):
  [mediawiki/extensions/Wikibase@master] bridge: Implement basic link counter 
in typescript
  
  https://gerrit.wikimedia.org/r/518255

TASK DETAIL
  https://phabricator.wikimedia.org/T225930

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, darthmon_wmde, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Daimona
Daimona added a comment.


  In T226244#5273853 , 
@alaa_wmde wrote:
  
  > In T226244#5273849 , 
@gerritbot wrote:
  >
  > > Change 518256 had a related patch set uploaded (by Daimona Eaytoy; owner: 
Daimona Eaytoy):
  > >  [mediawiki/extensions/WikibaseLexeme@master] [WIP] Update phan, cleanup 
config
  > >
  > > https://gerrit.wikimedia.org/r/518256
  >
  >
  > @Daimona think you are trying to achieve the same effect I did with 
https://gerrit.wikimedia.org/r/518249 
(https://phabricator.wikimedia.org/T226244#5273778).
  >
  > Though I wouldn't add an explicit dependency here on Wikibase phan config. 
Lexeme and Wikibase can have different configurations in the long run. What do 
you think?
  
  
  @alaa_wmde Actually, not really. With the phan dependency in composer, we can 
use the standard MediaWiki config (source 
), which is what all 
extensions should do. For some reason, Wikibase redeclares its own config, so 
that it'll inevitably drift from the default. My change introduces a dependency 
on the standard config, not the Wikibase one, so this is the right way to go :-)
  I also tried to *remove* all suppressions to see what's really left to fix. 
The first thing I noticed is that all "A inherits B which is declared at X and 
also at Y" warnings have gone, and that was due to misconfiguration including 
Wikibase twice, probably.
  Now it complains about some methods not being declared (instead of being 
declared twice, eheh), but that's probably something we can fix via config. 
You'll also notice many warnings like "...can usually be simplified to...". 
They come from a phan plugin which is included in the standard config, but not 
in Wikibase - that's what I meant with "it'll inevitably drift from the 
default".
  
  At this point, I'd like to fix all issues reported for my patch, but that 
could take some time. And at the end, the same config change will have to be 
applied to Wikibase itself.

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Daimona
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T225935: Implement Feature Flag for Mediawiki

2019-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T225935

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Lucas_Werkmeister_WMDE
Cc: Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unblock] T225938: Implement Testing Environment

2019-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed subtask T225948: 1.- Research Webpack + RL as 
Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T225938

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T225948: 1.- Research Webpack + RL

2019-06-21 Thread Lucas_Werkmeister_WMDE
Lucas_Werkmeister_WMDE closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T225948

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Matthias_Geisler_WMDE, Lucas_Werkmeister_WMDE
Cc: Michael, Matthias_Geisler_WMDE, Aklapper, darthmon_wmde, Nandana, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T221832: Create Cookbook to restart WDQS

2019-06-21 Thread debt
debt closed this task as "Resolved".

TASK DETAIL
  https://phabricator.wikimedia.org/T221832

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mathew.onipe, debt
Cc: Lucas_Werkmeister_WMDE, Smalyshev, Mathew.onipe, Gehel, Aklapper, 
darthmon_wmde, Legado_Shulgin, Nandana, thifranc, AndyTan, Davinaclare77, 
Qtn1293, Lahi, Gq86, GoranSMilovanovic, Th3d3v1ls, Hfbn0, QZanden, EBjune, 
merbst, LawExplorer, Zppix, _jensen, rosalieper, Jonas, Xmlizer, Wong128hk, 
jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, Manybubbles, faidon, 
Mbch331, Jay8g, fgiunchedi
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 518249 had a related patch set uploaded (by Alaa Sarhan; owner: Alaa 
Sarhan):
  [mediawiki/extensions/WikibaseLexeme@master] Temporarily suppress phan checks 
to unbreak build.
  
  https://gerrit.wikimedia.org/r/518249

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 518048 abandoned by Jakob:
  reset css: ability to replace some selectors
  
  https://gerrit.wikimedia.org/r/518048

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 518248 had a related patch set uploaded (by Jakob; owner: Jakob):
  [wikibase/termbox@master] Re-add padding to externally styled `.external` link
  
  https://gerrit.wikimedia.org/r/518248

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T226254: Fix and unsuppress reported Phan errors on WikibaseLexeme

2019-06-21 Thread alaa_wmde
alaa_wmde created this task.
alaa_wmde added projects: Wikidata Tech Debt Exploration, Wikidata, phan.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  From Lexeme's `.phan/config.php`:
  
'suppress_issue_types' => [
// ...
// Temporarily due to T226244
"PhanParamTooFew",
"PhanUndeclaredVariableDim",
"PhanUnreferencedUseNormal",
"PhanUndeclaredTypeThrowsType",
"PhanRedefinedInheritedInterface",
"PhanRedefinedExtendedClass",
"PhanCommentParamWithoutRealParam",
"PhanUndeclaredFunction",
"PhanTypeMismatchDeclaredParam",
"PhanTypeNoPropertiesForeach",
// ...
],
  
  Without suppressing those errors, Phan fails on Lexeme (T226244 
). Those were temporarily suppressed 
to unbreak the build pipeline.
  
  Ideally, all of these checks should be unsuppressed and errors should be 
fixed. It can be that some will stay suppressed for much longer, in case 
there's a strong reason or blocker against fixing the reported errors.

TASK DETAIL
  https://phabricator.wikimedia.org/T226254

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: Aklapper, alaa_wmde, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T226255: Log and count occurances of save attempts of alises containing pipes

2019-06-21 Thread noarave
noarave created this task.
noarave added projects: Wikidata, Wikidata-Campsite.
Restricted Application added a subscriber: Aklapper.

TASK DESCRIPTION
  Based on the result of T223270 , 
we would like to know how often users attempt to save aliases containing pipe | 
characters. 
  A log entry is made each time a user attempts this, either through 
Special:SetAliases or through Special:SetLavelDescriptionAliases.
  
  We need to count those log entries. The easiest would be adding a Grafana 
board for this data.

TASK DETAIL
  https://phabricator.wikimedia.org/T226255

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave
Cc: Aklapper, noarave, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T225935: Implement Feature Flag for Mediawiki

2019-06-21 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).

TASK DETAIL
  https://phabricator.wikimedia.org/T225935

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, ReleaseTaggerBot
Cc: Aklapper, darthmon_wmde, Daryl-TTMG, RomaAmorRoma, 0010318400, 
E.S.A-Sheild, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, 
Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, 
_jensen, rosalieper, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread alaa_wmde
alaa_wmde added a comment.


  In T226244#5273849 , 
@gerritbot wrote:
  
  > Change 518256 had a related patch set uploaded (by Daimona Eaytoy; owner: 
Daimona Eaytoy):
  >  [mediawiki/extensions/WikibaseLexeme@master] [WIP] Update phan, cleanup 
config
  >
  > https://gerrit.wikimedia.org/r/518256
  
  
  @Daimona think you are trying to achieve the same effect I did with 
https://gerrit.wikimedia.org/r/518249 
(https://phabricator.wikimedia.org/T226244#5273778).
  
  Though I wouldn't add an explicit dependency here on Wikibase phan config. 
Lexeme and Wikibase can have different configurations in the long run. What do 
you think?

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T221835: Add CC0 License overlay popup on termbox editing

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 518041 abandoned by Pablo Grass (WMDE):
  reset css: ability to replace some selectors
  
  Reason:
  This does work somewhat but is costly (as in "not clear") and still does not 
resolve the task at hand completely as the use of the :not pseudo-selector 
causes too low specificity on some of our existing rules (e.g. 
EventEmittingButton)
  
  https://bitsofco.de/on-not-and-specificity/#whataboutnot
  
  https://gerrit.wikimedia.org/r/518041

TASK DETAIL
  https://phabricator.wikimedia.org/T221835

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Aklapper, Lea_WMDE, Lydia_Pintscher, Pablo-WMDE, Jakob_WMDE, 
Matthias_Geisler_WMDE, Tarrow, Hanna_Petruschat_WMDE, WMDE-leszek, Daryl-TTMG, 
RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, 
Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, 
Adrian1985, Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, 
LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Created] T226264: CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread Mholloway
Mholloway created this task.
Mholloway added projects: Recommendation-API, Wikidata-Query-Service.
Restricted Application added a subscriber: Aklapper.
Restricted Application added a project: Wikidata.

TASK DESCRIPTION
  The recommendation API CI tests frequently fail due to a 429 response from 
WDQS in the one test that consumes it.
  
  Example: 
https://integration.wikimedia.org/ci/job/service-pipeline-test/2270/console
  
  Is CI really consuming WDQS to the point of regularly hitting the intended 
rate limiting threshold, or is this a WDQS bug?  If not a bug, can some 
provision for CI be made in WDQS, or should this be addressed on the 
recommendation API side (perhaps by running the offending test on something 
like one run in ten)?

TASK DETAIL
  https://phabricator.wikimedia.org/T226264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mholloway
Cc: Aklapper, Mholloway, darthmon_wmde, Nandana, Lahi, Gq86, 
Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Smalyshev, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Capt_Swing, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T223792: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items

2019-06-21 Thread Keegan
Keegan added a comment.


  I should have some sort of update on Monday relating to this.

TASK DETAIL
  https://phabricator.wikimedia.org/T223792

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Keegan
Cc: Keegan, Jheald, Mike_Peel, Cparle, Aklapper, Jarekt, darthmon_wmde, 
Nandana, JKSTNK, Lahi, PDrouin-WMF, Gq86, E1presidente, Ramsey-WMF, Anooprao, 
SandraF_WMF, GoranSMilovanovic, QZanden, Tramullas, Acer, LawExplorer, Salgo60, 
Silverfish, _jensen, rosalieper, Susannaanas, Jane023, Wikidata-bugs, Base, 
matthiasmullie, aude, Ricordisamoa, Wesalius, Lydia_Pintscher, Fabrice_Florin, 
Raymond, Steinsplitter, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226152: Add WikibaseSchema extension to wikibase-docker

2019-06-21 Thread Lydia_Pintscher
Lydia_Pintscher added a comment.


  In T226152#5272025 , 
@Addshore wrote:
  
  > The one thing to be decided here is should this be in the base image or the 
bundle?
  >  I'm personally leaning toward the bundle, and keeping the base image as 
just wikibase, no frills.
  
  
  Agreed.

TASK DETAIL
  https://phabricator.wikimedia.org/T226152

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher
Cc: Lydia_Pintscher, Addshore, Aklapper, Jelabra, darthmon_wmde, pdehaye, 
Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Jonas, 
MisterSynergy, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Unblock] T208489: [Story] Create LilyPond datatype

2019-06-21 Thread alaa_wmde
alaa_wmde closed subtask T218191: Long score overlaps with statement box and 
edit button as Resolved.

TASK DETAIL
  https://phabricator.wikimedia.org/T208489

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lydia_Pintscher, alaa_wmde
Cc: alaa_wmde, Lydia_Pintscher, Mahir256, mb, Lucas_Werkmeister_WMDE, Aklapper, 
Jc86035, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Ebe123, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T218191: Long score overlaps with statement box and edit button

2019-06-21 Thread alaa_wmde
alaa_wmde moved this task from Stalled/Waiting to Done on the Wikidata-Campsite 
(Wikidata-Campsite-Iteration-∞) board.
alaa_wmde closed this task as "Resolved".
alaa_wmde added a comment.


  T226269  is to cover the issue we 
encountered with bumping up CACHE_VERSION

TASK DETAIL
  https://phabricator.wikimedia.org/T218191

WORKBOARD
  https://phabricator.wikimedia.org/project/board/3539/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde
Cc: WMDE-leszek, Lokal_Profil, noarave, Ebe123, TheDJ, Jc86035, Aklapper, 
Lucas_Werkmeister_WMDE, mb, Mahir256, Lydia_Pintscher, alaa_wmde, 
Lea_Lacroix_WMDE, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

2019-06-21 Thread Multichill
Multichill added a comment.


  https://commons.wikimedia.org/wiki/File:Wikidata_statement.svg might be 
useful for the relation between a claim and a statement.

TASK DETAIL
  https://phabricator.wikimedia.org/T149410

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Multichill
Cc: Bene, Lucas_Werkmeister_WMDE, Ramsey-WMF, Keegan, Multichill, Magnus, 
Addshore, matthiasmullie, Aklapper, Ladsgroup, aude, Lydia_Pintscher, 
thiemowmde, daniel, hoo, darthmon_wmde, Nandana, JKSTNK, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
Ricordisamoa, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 518249 abandoned by Jforrester:
  Temporarily suppress phan checks to unbreak build.
  
  Reason:
  Squashed into parent.
  
  https://gerrit.wikimedia.org/r/518249

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread Mholloway
Mholloway renamed this task from "CI testing is flaky due to frequent 429s from 
Wikidata Query Service" to "Recommendation-API CI testing is flaky due to 
frequent 429s from Wikidata Query Service".

TASK DETAIL
  https://phabricator.wikimedia.org/T226264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mholloway
Cc: Aklapper, Mholloway, darthmon_wmde, Nandana, Lahi, Gq86, 
Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Smalyshev, 
Wikidata-bugs, Jdouglas, aude, Tobias1984, Capt_Swing, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread Smalyshev
Smalyshev added a comment.


  Could you give some details on what recommendation API is actually doing 
there? Maybe post a link to the relevant code and probably explanation of which 
queries it is running and how often? Generally 429 means it is sending too many 
queries too often. Which shouldn't really happen on the test. But need some 
details.

TASK DETAIL
  https://phabricator.wikimedia.org/T226264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev
Cc: Smalyshev, MSantos, Aklapper, Mholloway, darthmon_wmde, Nandana, Lahi, 
Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Capt_Swing, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field

2019-06-21 Thread Smalyshev
Smalyshev added a comment.


  > The rules for the XML and JSON results formats are that the implicit 
datatype of langtagged literals is omitted.
  
  The problem is I haven't see this codified in any standard. JSON result 
standard predates RDF 1.1 so I can't be sure whether it's just out of date with 
RDF 1.1 or actually is meant to override RDF 1.1 changes. And the test suite 
you're quoting is from 2009, while RDF 1.1 is from 2014 so again, how can I be 
sure?

TASK DETAIL
  https://phabricator.wikimedia.org/T225996

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev
Cc: Andrawaag, Lydia_Pintscher, Lea_Lacroix_WMDE, ericP, Smalyshev, 
Lucas_Werkmeister_WMDE, Fnielsen, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, 
Cirdan, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, 
Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread Mholloway
Mholloway added a comment.


  Sure.  The specific URL that the flaky test is hitting is 
https://de.wikipedia.org/api/rest_v1/data/recommendation/article/creation/translation/en.
  
  Under the hood, the service is querying WDQS with this up to 10 times in 
rapid succession, for a batched set of ~500 Wikidata item IDs:
  
SELECT ?item (COUNT(?sitelink) as ?count) WHERE {
  VALUES ?item {  }
  FILTER NOT EXISTS { ?item wdt:P31 wd:Q4167410 . }
  OPTIONAL { ?sitelink schema:about ?item }
  FILTER NOT EXISTS {
?article schema:about ?item .
?article schema:isPartOf  .
  }
} GROUP BY ?item
  
  
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/services/recommendation-api/+/master/lib/article.creation.translation.js#158

TASK DETAIL
  https://phabricator.wikimedia.org/T226264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mholloway
Cc: Smalyshev, MSantos, Aklapper, Mholloway, darthmon_wmde, Nandana, Lahi, 
Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Capt_Swing, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 518236 **merged** by Jforrester:
  [mediawiki/extensions/WikibaseLexeme@master] Use newer phan version on 
WikibaseLexeme and make pass
  
  https://gerrit.wikimedia.org/r/518236

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, Redabr4, 
Zanziii, Sadisticturd, joker88john, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
A.S.Kochergin, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, 
Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, 
Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, 
Lewizho99, Maathavan, _jensen, rosalieper, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field

2019-06-21 Thread Smalyshev
Smalyshev added a comment.


  This: https://issues.apache.org/jira/browse/JENA-1077 suggests JENA also 
thinks types should be omitted on output for plain/language literals.

TASK DETAIL
  https://phabricator.wikimedia.org/T225996

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev
Cc: Andrawaag, Lydia_Pintscher, Lea_Lacroix_WMDE, ericP, Smalyshev, 
Lucas_Werkmeister_WMDE, Fnielsen, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, 
Cirdan, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, 
Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread ReleaseTaggerBot
ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde, ReleaseTaggerBot
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
darthmon_wmde, Redabr4, Zanziii, Sadisticturd, Nandana, A.S.Kochergin, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Closed] T226244: Phan fails with php72 on WikibaseLexeme

2019-06-21 Thread Jdforrester-WMF
Jdforrester-WMF removed a project: Patch-For-Review.
Jdforrester-WMF closed this task as "Resolved".
Jdforrester-WMF assigned this task to alaa_wmde.
Jdforrester-WMF added a comment.


  Thank you for fixing this.

TASK DETAIL
  https://phabricator.wikimedia.org/T226244

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: alaa_wmde, Jdforrester-WMF
Cc: alaa_wmde, hashar, noarave, Daimona, Aklapper, Jdforrester-WMF, Michael, 
darthmon_wmde, Redabr4, Zanziii, Sadisticturd, Nandana, A.S.Kochergin, Lahi, 
Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Jonas, 
Wikidata-bugs, aude, Lydia_Pintscher, Mbch331, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, joker88john, CucyNoiD, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
WSH1906, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field

2019-06-21 Thread Smalyshev
Smalyshev added a comment.


  OK, I did a survey of existing SPARQL endpoints and looks like they all omit 
datatypes on plain literals on JSON. So I'll fix WDQS to do the same.

TASK DETAIL
  https://phabricator.wikimedia.org/T225996

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Smalyshev
Cc: Andrawaag, Lydia_Pintscher, Lea_Lacroix_WMDE, ericP, Smalyshev, 
Lucas_Werkmeister_WMDE, Fnielsen, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, 
Cirdan, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, 
Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field

2019-06-21 Thread gerritbot
gerritbot added a comment.


  Change 518310 had a related patch set uploaded (by Smalyshev; owner: 
Smalyshev):
  [wikidata/query/blazegraph@master] Fix writing JSON result literals
  
  https://gerrit.wikimedia.org/r/518310

TASK DETAIL
  https://phabricator.wikimedia.org/T225996

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Andrawaag, Lydia_Pintscher, Lea_Lacroix_WMDE, ericP, Smalyshev, 
Lucas_Werkmeister_WMDE, Fnielsen, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, EBjune, merbst, LawExplorer, _jensen, rosalieper, 
Cirdan, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, 
Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T225996: JSON results serializer in Wikidata Query Service generates an extra "datatype" field

2019-06-21 Thread gerritbot
gerritbot added a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T225996

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: gerritbot
Cc: Andrawaag, Lydia_Pintscher, Lea_Lacroix_WMDE, ericP, Smalyshev, 
Lucas_Werkmeister_WMDE, Fnielsen, Aklapper, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, darthmon_wmde, joker88john, CucyNoiD, Nandana, 
NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, 
Cpaulf30, Lahi, Gq86, Baloch007, Darkminds3113, Bsandipan, Lordiis, 
GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, EBjune, 
merbst, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, 
Cirdan, Jonas, Xmlizer, jkroll, Wikidata-bugs, Jdouglas, aude, Tobias1984, 
Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T226264: Recommendation-API CI testing is flaky due to frequent 429s from Wikidata Query Service

2019-06-21 Thread Mholloway
Mholloway added a comment.


  Hmm, now that I'm digging, I see that the batching was just introduced: 
https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/services/recommendation-api/+/9603d4282492103eecc0b1646ea2911138c848af%5E%21/lib/article.creation.translation.js

TASK DETAIL
  https://phabricator.wikimedia.org/T226264

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mholloway
Cc: Smalyshev, MSantos, Aklapper, Mholloway, darthmon_wmde, Nandana, Lahi, 
Gq86, Lucas_Werkmeister_WMDE, GoranSMilovanovic, QZanden, EBjune, merbst, 
LawExplorer, _jensen, rosalieper, Jonas, Xmlizer, jkroll, Wikidata-bugs, 
Jdouglas, aude, Tobias1984, Capt_Swing, Manybubbles, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Changed Subscribers] T226238: Identical items can't be merged due to duplicate articles in ceb wikipedia

2019-06-21 Thread Mahir256
Mahir256 added subscribers: Lsj, Mahir256.
Mahir256 added a comment.


  The bug, if there is any, is in GeoNames or in wherever else @Lsj's bot 
obtains its geographic information. Ultimately it must be corrected there or 
there is still a risk of reintroducing it to Wikidata.

TASK DETAIL
  https://phabricator.wikimedia.org/T226238

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Mahir256
Cc: Mahir256, Lsj, jjkoehorst, Jane023, Andrawaag, Aklapper, darthmon_wmde, 
Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T153866: Wikibase hacks prevent AbuseFilter from inserting revision ids

2019-06-21 Thread Addshore
Addshore added a comment.


  So, Wikibase does not run PageContentSaveComplete itself, this is done within 
core.
  This is now done in PageUpdater.php (i just updated the mw.org docs) 
https://github.com/wikimedia/mediawiki/blob/7b3631abc85ff63947908022803b245bcefafd49/includes/Storage/PageUpdater.php#L1238
  
  The method that calls the hook "getAtomicSectionUpdate", is called by the 
doCreate and doModify methods in PageUpdater.
  These 2 methods are called from within the saveRevision public method in 
PageUpdater.
  All logic to do with Revisions as far as I can tell is handled in PageUpdater.
  
  I'm not sure why wikibase would be creating a fake title or anything like 
that for edits? I don't know of any such place (but I may have forgotten it)
  
  When I look at the abuse logs it looks like AF is correctly getting 
revisions? https://www.wikidata.org/wiki/Special:AbuseLog/8084330 but I guess 
this comes form a different route, the content of the revisions rather than the 
rev ids...

TASK DETAIL
  https://phabricator.wikimedia.org/T153866

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, matej_suchanek, Aklapper, darthmon_wmde, Nandana, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T153866: Wikibase hacks prevent AbuseFilter from inserting revision ids

2019-06-21 Thread Addshore
Addshore added a project: AbuseFilter.

TASK DETAIL
  https://phabricator.wikimedia.org/T153866

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, matej_suchanek, Aklapper, darthmon_wmde, DannyS712, Nandana, 
Lahi, Gq86, Daimona, GoranSMilovanovic, QZanden, LawExplorer, Litanwei, 
_jensen, rosalieper, Wong128hk, Nirmos, Wikidata-bugs, aude, Huji, Jackmcbarn, 
Mbch331, chasemp
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T218901: Track number of Wikidata edits by namespace

2019-06-21 Thread Addshore
Addshore added a comment.


  This dashboard panel should probably use the time range selected for the 
dashboard as a whole.
  This will allow users of the dashboard to easily look at different ranges of 
data for the panel without needing someone to actually edit the dashboard.
  
  I'm aware this is currently only daily data, but it probably still make sense 
to have it all line up.
  Thoughts @Lydia_Pintscher ?

TASK DETAIL
  https://phabricator.wikimedia.org/T218901

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael, Addshore
Cc: Lydia_Pintscher, JAllemandou, Addshore, Aklapper, Lucas_Werkmeister_WMDE, 
Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, darthmon_wmde, pdehaye, 
alaa_wmde, joker88john, Michael, CucyNoiD, Nandana, NebulousIris, Gaboe420, 
Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, 
Baloch007, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, 
Th3d3v1ls, Ramalepe, Liugev6, QZanden, YULdigitalpreservation, LawExplorer, 
Salgo60, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Jonas, 
MisterSynergy, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Triaged] T226254: Fix and unsuppress reported Phan errors on WikibaseLexeme

2019-06-21 Thread Addshore
Addshore triaged this task as "Low" priority.
Addshore moved this task from Backlog to Campsite Candidates on the Wikidata 
Tech Debt Exploration board.

TASK DETAIL
  https://phabricator.wikimedia.org/T226254

WORKBOARD
  https://phabricator.wikimedia.org/project/board/4106/

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Aklapper, alaa_wmde, darthmon_wmde, Nandana, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T222159: WikibaseMediaInfo serializes empty statements as empty array [] instead of empty object {} in JSON

2019-06-21 Thread Addshore
Addshore added a comment.


  Would be great to get this fixed by the #structureddataoncommons 
 team, should 
be pretty trivial!

TASK DETAIL
  https://phabricator.wikimedia.org/T222159

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Addshore, Lucas_Werkmeister_WMDE, Aklapper, darthmon_wmde, Nandana, JKSTNK, 
Lahi, Gq86, Ramsey-WMF, GoranSMilovanovic, QZanden, V4switch, LawExplorer, 
_jensen, rosalieper, Wong128hk, Wikidata-bugs, matthiasmullie, aude, 
Ricordisamoa, Lydia_Pintscher, Fabrice_Florin, Jdforrester-WMF, Matanya, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Edited] T226152: Add WikibaseSchema extension to wikibase-docker bundle image

2019-06-21 Thread Addshore
Addshore updated the task description.

TASK DETAIL
  https://phabricator.wikimedia.org/T226152

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Lydia_Pintscher, Addshore, Aklapper, Jelabra, darthmon_wmde, pdehaye, 
Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Jonas, 
MisterSynergy, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T226218: snak hashes should not appear in AbuseFilter text for Wikibase

2019-06-21 Thread Addshore
Addshore added a project: Performance.

TASK DETAIL
  https://phabricator.wikimedia.org/T226218

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Sjoerddebruin, matej_suchanek, Aklapper, alaa_wmde, Addshore, 
darthmon_wmde, Nandana, Lahi, Gq86, Darkminds3113, GoranSMilovanovic, QZanden, 
LawExplorer, Vali.matei, _jensen, rosalieper, Jonas, Volker_E, Wikidata-bugs, 
aude, GWicke, Dinoguy1000, Lydia_Pintscher, Mbch331, Jay8g
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Retitled] T226152: Add WikibaseSchema extension to wikibase-docker bundle image

2019-06-21 Thread Addshore
Addshore renamed this task from "Add WikibaseSchema extension to 
wikibase-docker" to "Add WikibaseSchema extension to wikibase-docker bundle 
image".

TASK DETAIL
  https://phabricator.wikimedia.org/T226152

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Lydia_Pintscher, Addshore, Aklapper, Jelabra, darthmon_wmde, pdehaye, 
Michael, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
YULdigitalpreservation, LawExplorer, Salgo60, _jensen, rosalieper, Jonas, 
MisterSynergy, abian, Wikidata-bugs, aude, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Commented On] T149410: For consistency MediaInfo serialization should use "claims" as key, rather than "statements"

2019-06-21 Thread Addshore
Addshore added a comment.


  > Magnus ran into this and this is very confusing and inconsistent. The 
longer we wait with fixing this, the more effort it will cost.
  
  Totally agree there, we have already put this off for years.
  It's a pretty breaking change though.
  But with the correct announcement and time that would all be fine, and even 
if people miss it, fixing their code should be trivial.
  
  Thoughts @Lydia_Pintscher ?

TASK DETAIL
  https://phabricator.wikimedia.org/T149410

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Addshore
Cc: Bene, Lucas_Werkmeister_WMDE, Ramsey-WMF, Keegan, Multichill, Magnus, 
Addshore, matthiasmullie, Aklapper, Ladsgroup, aude, Lydia_Pintscher, 
thiemowmde, daniel, hoo, darthmon_wmde, Nandana, JKSTNK, Lahi, Gq86, 
GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Wikidata-bugs, 
Ricordisamoa, Jdforrester-WMF, Mbch331
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


[Wikidata-bugs] [Maniphest] [Updated] T224905: Move wikiba.se tests from php56 to php72

2019-06-21 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review.

TASK DETAIL
  https://phabricator.wikimedia.org/T224905

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Maintenance_bot
Cc: hashar, Dzahn, Ladsgroup, WMDE-leszek, Jdforrester-WMF, Aklapper, 
darthmon_wmde, Redabr4, Zanziii, Sadisticturd, Nandana, NebulousIris, 
A.S.Kochergin, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, 
rosalieper, Liudvikas, Wikidata-bugs, aude, Mbch331, Daryl-TTMG, RomaAmorRoma, 
0010318400, E.S.A-Sheild, joker88john, CucyNoiD, Gaboe420, Versusxo, 
Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Baloch007, 
Darkminds3113, Bsandipan, Lordiis, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, 
WSH1906, Lewizho99, Maathavan
___
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs


  1   2   >