[MediaWiki-CodeReview] [MediaWiki r89452]: Revision status changed
User MaxSem changed the status of MediaWiki.r89452. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89452#c0 Commit summary: follow up r89278 — remove FTP support. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] IE6
On 04/06/11 02:07, Mono mium wrote: I still supportinput type=crash. On a multiple millions visitors per day website, this is unacceptable. Most users do not even know what a 'browser' is. They just look at their computer desktop and double click the 'e' icon. Plus, 'internet explorer' sounds much better than: - 'Firefox' : will it light my computer? - 'Opera' : I listen to R'n'B I do support your crash method... on your personal website. -- Ashar Voultoiz ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r89387]: Revision status changed
User MaxSem changed the status of MediaWiki.r89387. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89387#c0 Commit summary: Fix for r89166: need self ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89451]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r89451. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r89451. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89451#c17580 Commit summary: Followup r88124: fix the most glaring bug of the week Comment: \o/ ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89455]: Revision status changed
User Reedy changed the status of MediaWiki.r89455. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89455#c0 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] On the IE6 query string security check breakage (bug 28235)
On 04/06/11 03:53, Brion Vibber wrote: On Thu, Jun 2, 2011 at 5:21 PM, Tim Starling tstarl...@wikimedia.orgwrote: The main issue here is that we don't a wide variety of web servers set up for testing. We know that Apache lets you detect %2E versus dot via $_SERVER['REQUEST_URI'], but we don't know if any other web servers do that. Note that checking for %2E alone is not sufficient, a lot of installations (including Wikimedia) have an alias /wiki - /w/index.php which can be used to exploit action=raw. Well that should be fine; as long as we can see the /wiki?/foo.bat then we can identify that it doesn't contain an unencoded dot in the path. It sounds like simply checking REQUEST_URI when available would eliminate a huge portion of our false positives that affect real-world situations. Apache is still the default web server in most situations for most folks, and of course runs our own production servers. You mean by checking $_SERVER[SERVER_SOFTWARE] or something to check if it's Apache that we're running under? I suppose that could work. It's easy enough to find out if REQUEST_URI is available. What we don't know is whether REQUEST_URI is really what was sent to the server, or whether it has %2E converted to . before PHP gets to see it. Are there any additional exploit vectors for API output other than HTML tags mixed unescaped into JSON? Yes, all other content types, as I said above. Only as drive-by downloads, or as things that execute without interaction? Presumably that depends on what plugins are registered. I think it's better to avoid taking risks like this unless there is some good reason for doing so. With a REQUEST_URI check in place, in addition to all the other mitigating measures we now have in place, overblocking should be vanishingly rare. -- Tim Starling ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r89359]: Revision status changed
User Krinkle changed the status of MediaWiki.r89359. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89359#c0 Commit summary: (bug 29117) A string is missing when the UI is in Hebrew Backport r88658 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89420]: Revision status changed
User Krinkle changed the status of MediaWiki.r89420. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89420#c0 Commit summary: Extension to r89419, removing a bugous CSS code ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89401]: Revision status changed
User Krinkle changed the status of MediaWiki.r89401. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89401#c0 Commit summary: (bug 29121) jquery.suggestions uses jquery.autoEllipsis but didn't have it in its dependency list, causing JS errors in non-Vector skins ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89406]: New comment added
User Happy-melon posted a comment on MediaWiki.r89406. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89406#c17581 Commit summary: Start unpicking r85288 (magic __get() accessor for RequestContext). Instead, bring back some of r86872 (abstract base class for classes providing access to RequestContext methods), which is a more 'classical' solution. Comment: Grr, my tterror_reporting = E_ALL|E_STRICT)/tt config is only in php.ini for ''some'' of my nine versions of PHP... /sulks I'm afraid uni finals are a higher priority for me right now than redoing this, or otherwise reworking r85288. If people agree with the general principle of using a ContextSource base class, do go ahead and stick it back in. Otherwise I'll try and get back round to it sometime towards the end of June. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87164]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r87164.
Old Status: new
New Status: fixme
User Krinkle also posted a comment on MediaWiki.r87164.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87164#c17582
Commit summary:
Recommit r87129 and follow-ups but with a fix for the bug Brion found (sorry)
Comment:
pre
+ if ( isset( $row-user_name ) ) {
+ $this-mName = $row-user_name;
..
+ }
+
+ if ( isset( $row-user_name ) ) {
+ $this-mRealName = $row-user_real_name;
..
+ }
+
if ( isset( $row-user_id ) ) {
$this-mId = intval( $row-user_id );
/pre
The second one should be checking codeuser_'''real'''_name/code instead of
codeuser_name/code
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87164]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r87164. Old Status: fixme New Status: new User Krinkle also posted a comment on MediaWiki.r87164. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87164#c17583 Commit summary: Recommit r87129 and follow-ups but with a fix for the bug Brion found (sorry) Comment: I fixed it myself for now since it was causing issues in another project I'm working on. r89464. Setting status back to new. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89419]: New comment added
User Huji posted a comment on MediaWiki.r89419. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89419#c17584 Commit summary: (bug 29263) Add LTR class to the shared CSS to be used for left-to-right text such as SQL queries shown in dberrortext and similiar messages in RTL environements Comment: I made ltr a generic reusable class style with r89466. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added
User Nikerabbit posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17585 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's leave the calls in with a wfDeprecated() for a while... Comment: Notice: Use of RequestContext::__get() is deprecated; use $context-getFoo() instead is deprecated. [Called from StubUserLang::_newObject in /www/sandwiki/includes/StubObject.php at line 151] in /www/sandwiki/includes/GlobalFunctions.php on line 3342 Notice: Use of RequestContext::__set() is deprecated; use $context-setFoo() instead is deprecated. [Called from SpecialPageFactory::executePath in /www/sandwiki/includes/SpecialPageFactory.php at line 447] in /www/sandwiki/includes/GlobalFunctions.php on line 3342 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89421]: Revision status changed
User Krinkle changed the status of MediaWiki.r89421. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89421#c0 Commit summary: Extension to r89419, I was too excited fixing the bug ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89466]: Revision status changed
User Krinkle changed the status of MediaWiki.r89466. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89466#c0 Commit summary: Follow up to r89419: Per Brion's comment on Code Review, a generically named ltr class is created and used to reduce the number of rules ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89419]: Revision status changed
User Krinkle changed the status of MediaWiki.r89419. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89419#c0 Commit summary: (bug 29263) Add LTR class to the shared CSS to be used for left-to-right text such as SQL queries shown in dberrortext and similiar messages in RTL environements ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89440]: Revision status changed
User Krinkle changed the status of MediaWiki.r89440. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89440#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-06-03 20:33:00 UTC) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89459]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r89459. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r89459. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89459#c17586 Commit summary: Add Jarry1250's Translate tool Possibly completely wrong, I've no idea Comment: This broke the TsIntuition sandbox with an E_FATAL. Where are the comma's after the array values ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89459]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r89459. Old Status: fixme New Status: ok User Krinkle also posted a comment on MediaWiki.r89459. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89459#c17587 Commit summary: Add Jarry1250's Translate tool Possibly completely wrong, I've no idea Comment: Also, altho non-breaking, in order to be shown in the list of tools on the [http://toolserver.org/~intuition/#tab-about Dashboard], a 'title' message must be present. Added in r89467. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89464]: New comment added
User IAlex posted a comment on MediaWiki.r89464. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89464#c17588 Commit summary: Fixing fixme in r87164 (wrong if check) Comment: Thanks for the fix! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89470]: New comment added
User Krinkle posted a comment on MediaWiki.r89470. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89470#c17589 Commit summary: TsIntuition fixes * Re-alphabetize order Domains.php (r89459) * Synchronize Optional and Ignore marks between comments after ['en'], templates in ['qqq'] and Translate/toolserver-domains.txt * Add Templatecount to translation routine on TranslateWiki Comment: The rest of this commit is in r89469. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89402]: Revision status changed
User Krinkle changed the status of MediaWiki.r89402. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89402#c0 Commit summary: (bug 29104) Fix r86622: make splitlines default to false, makes much more sense ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?
Hi all, MediaWiki has a user setting to add a CSS class to article links whose length is below a certain threshold (preferences/appearance/advanced options/threshold for stub link formatting). Is it possible to enable this by default on a Wikimedia wiki? Some of the advantages: - a lot of editors seem to use it already to find articles which need some care, and currently it slows down page loading for them because it breaks caching, so they could work quicker. - like red links, it could bring in new editors by making readers realize that some of the linked articles need help. - it could make readers waste less time because they could realize the article is a stub without clicking at it. On the other hand, I suppose it would raise database load because the length of all linked pages would need to be queried at HTML generation. (Or is that query already already necessary to see which links are red?) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r89419]: Revision status changed
User Krinkle changed the status of MediaWiki.r89419. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89419#c0 Commit summary: (bug 29263) Add LTR class to the shared CSS to be used for left-to-right text such as SQL queries shown in dberrortext and similiar messages in RTL environements ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88301]: New comment added
User Solitarius posted a comment on MediaWiki.r88301. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88301#c17592 Commit summary: Added UTF-8 encoding for data retrieved from DB Comment: In my MSSQLBackCompat external databases, nvarchar() columns are already encoded in utf-8. This patch cause a double encoding (example: répertoire). Other points to take into consideration: * In my apache configuration, I have codephp_value mssql.charset UTF-8/code. * Are other Database (Oracle, IBM DB2, ...) classes using a UTF-8 charset? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] [Foundation-l] YouTube and Creative Commons
A nice script to download YouTube videos is youtube-dl[1]. Link that with a flv/mp4 - ogg converter and an uploader to Commons is trivial. [1] http://rg3.github.com/youtube-dl/ 2011/6/4 Michael Dale md...@wikimedia.org Comments inline: On Fri, Jun 3, 2011 at 4:51 PM, Brion Vibber br...@pobox.com wrote: (I'm not sure offhand if I'm set up to cross-post to Foundation-l; if this doesn't make it, somebody please CC a mention if necessary. Thanks!) On Fri, Jun 3, 2011 at 4:42 PM, aude aude.w...@gmail.com wrote: Aside from the very real privacy issue, YouTube videos can disappear at any time. I would much rather we host them on Commons. A youtube2commons script is pretty easy to implement, yes a basic youtube2commons script was posted by Jan on wikivideo-l list recently: http://lists.wikimedia.org/pipermail/wikivideo-l/2011-May/56.html But as you point out we really need to work on increasing the upload size limit. There's been some ongoing work on TimedMediaHandler extension which will replace the older OggHandler Yes, been hammering away on associated bugs. People can help by testing and filing bugs :) thedj has helped file a lot of bugs, and Brion too recently has been taking a look at the transcoding side of things and Roan did a good first pass review and thous suggestions have since been integrated. I hope to have a new version up prototype soon that integrates all the known requested features / bugs listed in bugzilla some time next week. (with the exception of features tagged for version 1.1 like server side srt parsing and timed wikitext - html - srt text with html tag removal ) Once I get this update out to prototype I will try and do a blog post at that point to invite people to put test it out. Basic uploads by URL work in theory, but I'm not sure the deployment status. Background large-file downloads are currently disabled in the latest code and needs to be reimplemented if that's to be used. Yea we have bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=20512tracking re-enabling copy by url. Once we have webm TMH deployed it would make for simple youtube cc content with importing without conversion :) For straight uploads, regular uploads of large files are a bit problematic in general (they hit memory limits and such and have to make it through caching proxies and whatnot), but there's also been some new work on improved chunked uploads for FireFogg (and perhaps for general modern browsers that can do fancier uploads). Michael Dale can probably give some updates on this, but it'll be a bit yet before it's ready to go. Yes we are reimplementing the firefogg chunk uploading as ResumableUpload ( name of new extension ) in a way that allows both HTML5 XHR browsers to use the chunk protocol in addition to firefogg ( if your converting video from a proprietary source ). In addition we had disscutions at the Berlin Hack-a-ton that cleared up some confusion about the concerns with the firefogg protocol and modified it to explicitly state the byte ranges of chunks in requests and server responses. Also had a brief chat with Russell on IRC, so that we can support this append chunks system as we move to the swiftMedia back end. --michael ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added
User Platonides posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17593 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's leave the calls in with a wfDeprecated() for a while... Comment: We can't really change the way the hook parameters are passed. We should revert this change. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added
User Platonides posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17594 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's leave the calls in with a wfDeprecated() for a while... Comment: The point is, StubObject::_newObject is doing RequestContext::getMain()-lang; so it shouldn't have triggered __get(). Either php or our expectations are wrong. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89292]: Revision status changed
User ^demon changed the status of MediaWiki.r89292. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89292#c0 Commit summary: Tweak HttpTest following r89278: * remove FTP test case URL (shouldn't actually work, and as a directory listing, not super stable) * remove old test case URLs that are now 30x redirects (example.com and a toolserver link), which broke the comparison tests * added in http://en.wikipedia.org/robots.txt so we've got a nice basic fetch on one of our servers too Now this test class is down to 3 failures, in URL domain validation stuff ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added
User Happy-melon posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17595 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's leave the calls in with a wfDeprecated() for a while... Comment: Hooks can still do things like tt$user-setSomething()/tt and that will stick; it's just that they can't do tt$user = $otherUser/tt. Which as Brion says is not kosher anyway. Changing it to be truly read-only would indeed not be feasible; but changing from pass-by-reference to pass-by-object is ok, IMO. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added
User Happy-melon posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17596 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's leave the calls in with a wfDeprecated() for a while... Comment: Yes it should; ttRequestContext::getMain()-lang/tt is equivalent to tt$context-lang/tt; the __get() magic accessor is to rewrite that to tt$context-getLang()/tt. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89472]: Revision status changed
User Reedy changed the status of MediaWiki.r89472. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89472#c0 Commit summary: Adding my USERINFO file. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89472]: New comment added
User Reedy posted a comment on MediaWiki.r89472. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89472#c17597 Commit summary: Adding my USERINFO file. Comment: Yay. Tied your SVN account in with your MW account :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89471]: New comment added
User Reedy posted a comment on MediaWiki.r89471. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89471#c17598 Commit summary: Add BlockTest to the tests autoloader. Needed by ApiBlockTest.php Added tabs to other items (compare ignoring whitespace). Comment: Have you purposely seemingly extra indented it? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added
User Platonides posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17599 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's leave the calls in with a wfDeprecated() for a while... Comment: Oops. You are right. I was looking just at the RequestContext::getMain() Fixed that at r89474. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added
User Platonides posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c17600 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's leave the calls in with a wfDeprecated() for a while... Comment: Can they, or will old extensions hooking it fail to run because they were expecting a reference and it is now given by value? That's the reason we didn't fix all prototypes everywhere long time ago. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89474]: New comment added, and revision status changed
User Reedy changed the status of MediaWiki.r89474. Old Status: new New Status: fixme User Reedy also posted a comment on MediaWiki.r89474. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89474#c17601 Commit summary: Follow up r89408. Magic lang to getLang(). Comment: ialex Platonides: you missed the () ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89474]: New comment added, and revision status changed
User IAlex changed the status of MediaWiki.r89474. Old Status: fixme New Status: new User IAlex also posted a comment on MediaWiki.r89474. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89474#c17602 Commit summary: Follow up r89408. Magic lang to getLang(). Comment: Fixed in r89477. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89479]: New comment added, and revision status changed
User MaxSem changed the status of MediaWiki.r89479. Old Status: new New Status: fixme User MaxSem also posted a comment on MediaWiki.r89479. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89479#c17603 Commit summary: Also support macports Comment: Did you mean tthas_binary port/tt? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89254]: Revision status changed
User MaxSem changed the status of MediaWiki.r89254. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89254#c0 Commit summary: * trying to create a way to update/install extension already included in the LocalSettings.php * wgHooks and wgAutoloadClasses are initialized so they can be appended within extension inits ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89481]: Revision status changed
User Krinkle changed the status of MediaWiki.r89481. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89481#c0 Commit summary: Revert r89254: * It breaks if any extension uses any global except $IP, $wgHooks or $wgAutoloadClasses. Some unit tests that try updating a virtual database are already affected. * If we have LocalSettings.php, we already have it loaded - are there code paths that don't have it? * Parsing PHP with regexes is fragile and scary ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89481]: New comment added, and revision status changed
User MaxSem changed the status of MediaWiki.r89481. Old Status: ok New Status: new User MaxSem also posted a comment on MediaWiki.r89481. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89481#c17604 Commit summary: Revert r89254: * It breaks if any extension uses any global except $IP, $wgHooks or $wgAutoloadClasses. Some unit tests that try updating a virtual database are already affected. * If we have LocalSettings.php, we already have it loaded - are there code paths that don't have it? * Parsing PHP with regexes is fragile and scary Comment: Another great way to break stuff I forgot to mention: source lang=php /* these extensions are broken -- don't reenable require_once( $IP/extensions/BreakYourSite/BreakYourSite.php ); require_once( $IP/extensions/WorksOnlyOnMW_1.1/WorksOnlyOnMW_1.1.php ); */ /source ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89481]: Revision status changed
User ^demon changed the status of MediaWiki.r89481. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89481#c0 Commit summary: Revert r89254: * It breaks if any extension uses any global except $IP, $wgHooks or $wgAutoloadClasses. Some unit tests that try updating a virtual database are already affected. * If we have LocalSettings.php, we already have it loaded - are there code paths that don't have it? * Parsing PHP with regexes is fragile and scary ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Showing stub links by default - is it possible in a Wikimedia project?
Tisza Gergö wrote: Hi all, MediaWiki has a user setting to add a CSS class to article links whose length is below a certain threshold (preferences/appearance/advanced options/threshold for stub link formatting). Is it possible to enable this by default on a Wikimedia wiki? No. Currently it would mean not caching any page view. The feature would need to be adapted to allow efficient stub linking (I have some ideas about it, and the new linker makes things easier). Still, we might not allow stub links for anons in miser mode. Feel free to open a bug. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r89475]: New comment added
User ^demon posted a comment on MediaWiki.r89475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89475#c17605 Commit summary: Added missing $PAGEEDITTIME replacement for impersonal mails Comment: Every time I see this I cry a little bit inside. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89476]: New comment added
User Krinkle posted a comment on MediaWiki.r89476. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89476#c17606 Commit summary: Fix for r89475: let's make this correctly Comment: Is $timecorrection not needed anymore ? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] [Foundation-l] YouTube and Creative Commons
On 4 June 2011 17:47, Michael Dale md...@wikimedia.org wrote: On Fri, Jun 3, 2011 at 4:51 PM, Brion Vibber br...@pobox.com wrote: There's been some ongoing work on TimedMediaHandler extension which will replace the older OggHandler Yes, been hammering away on associated bugs. People can help by testing and filing bugs :) A question that wasn't clear from reading the bug: why is reading a file format (WebM) blocked on the entire Timed Media Handler? - d. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r89476]: New comment added
User IAlex posted a comment on MediaWiki.r89476. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89476#c17607 Commit summary: Fix for r89475: let's make this correctly Comment: This was a copy/paste error. We are in sendImpersonal() here, so we need to use server time. $timecorrection is only defined in sendPersonalised(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
