[MediaWiki-CodeReview] [MediaWiki r89925]: New comment added
User Tim Starling posted a comment on MediaWiki.r89925. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89925#c18018 Commit summary: safer check if mhash is available (and I'm about to make it unavailable by disabling the fn in the php.ini for lucid builds) Comment: OK, I guess I can fix it myself, if you're refusing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90035]: New comment added
User ArielGlenn posted a comment on MediaWiki.r90035. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90035#c18019 Commit summary: Revert r89925, setting disable_functions in php.ini is definitely the wrong way to fix hash mismatches. Comment: The extension_loaded check is broader than it needs to be; the function_exists check is better, regardless of other issues. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89925]: Revision status changed
User Tim Starling changed the status of MediaWiki.r89925. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89925#c0 Commit summary: safer check if mhash is available (and I'm about to make it unavailable by disabling the fn in the php.ini for lucid builds) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89927]: Revision status changed
User Tim Starling changed the status of MediaWiki.r89927. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89927#c0 Commit summary: mft r89925 so we can disable mhash in php.ini instead of at build time ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90036]: New comment added
User ArielGlenn posted a comment on MediaWiki.r90036. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90036#c18020 Commit summary: Reverted r89927 and applied a more appropriate fix for the reported hash mismatches. Comment: I don't understand why this is better; it seems much more intrusive to me. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90036]: New comment added
User Tim Starling posted a comment on MediaWiki.r90036. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90036#c18021 Commit summary: Reverted r89927 and applied a more appropriate fix for the reported hash mismatches. Comment: It's better because it has documentation, it's clear about what it's doing and why, and it doesn't subtly break unrelated code. By less intrusive I suppose you mean your way changes less bytes of code, but that's not a goal. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88583]: Revision status changed
User Lcawte changed the status of MediaWiki.r88583. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88583#c0 Commit summary: Update tags. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89143]: Revision status changed
User Lcawte changed the status of MediaWiki.r89143. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89143#c0 Commit summary: Update support for Wikia extensions. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89469]: Revision status changed
User Lcawte changed the status of MediaWiki.r89469. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89469#c0 Commit summary: TsIntuition fixes * Re-alphabetize order Domains.php (r89459) * Synchronize Optional and Ignore marks between comments after ['en'], templates in ['qqq'] and Translate/toolserver-domains.txt * Add Templatecount to translation routine on TranslateWiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89470]: Revision status changed
User Lcawte changed the status of MediaWiki.r89470. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89470#c0 Commit summary: TsIntuition fixes * Re-alphabetize order Domains.php (r89459) * Synchronize Optional and Ignore marks between comments after ['en'], templates in ['qqq'] and Translate/toolserver-domains.txt * Add Templatecount to translation routine on TranslateWiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90035]: New comment added
User Tim Starling posted a comment on MediaWiki.r90035. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90035#c18022 Commit summary: Revert r89925, setting disable_functions in php.ini is definitely the wrong way to fix hash mismatches. Comment: You mean just in case there is some other extension that provides mhash(), other than the mhash extension? But if that was the situation, how would you know whether the function had the same parameters, and had the same definitions of the hash functions? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90035]: New comment added
User ArielGlenn posted a comment on MediaWiki.r90035. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90035#c18023 Commit summary: Revert r89925, setting disable_functions in php.ini is definitely the wrong way to fix hash mismatches. Comment: No; I mean that it is possible for the extension to be enabled (at build time) but the function to be disabled (at run time). In that case the extension_loaded() test will not do the job. I note that in general we seem to prefer calls to function_exists() instead of extension_loaded(), I assume for this reason. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Code review process (was: Status of more regular code deployments)
On Thu, Jun 2, 2011 at 2:26 AM, Roan Kattouw roan.katt...@gmail.com wrote: I like the 20% model as well. It goes a little bit further than my suggestion, which was 20, 25 or 33% model for certain senior devs, but if you're volunteering to give me more than what I asked for that's even better :) . For numerous reasons, I think getting /everyone/ involved with service work is a great idea. To keep the ball rolling, I've started a draft here, based in part on your comments: http://www.mediawiki.org/wiki/Development_process_improvement/20%25_policy Please be bold and/or add your thoughts. As per the note on the page and other comments in this thread, a policy like this isn't a replacement for dedicated staff supporting the code review and release process; it's merely one component of ensuring appropriate capacity is available for relevant work. -- Erik Möller Deputy Director, Wikimedia Foundation Support Free Knowledge: http://wikimediafoundation.org/wiki/Donate ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90036]: New comment added
User ArielGlenn posted a comment on MediaWiki.r90036. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90036#c18024 Commit summary: Reverted r89927 and applied a more appropriate fix for the reported hash mismatches. Comment: No, what I meant was: function_exists() is narrower as a check, and it also will not need to be removed later. The place for information about the hash issue is bugzilla; I will be opening a report with a few textids there so the issue can be looked at separately. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89993]: New comment added
User F.trott posted a comment on MediaWiki.r89993. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89993#c18025 Commit summary: fixed compat issues in timeline and eventline formats Comment: Finally! :-) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90037]: Revision status changed
User Reedy changed the status of MediaWiki.r90037. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90037#c0 Commit summary: * Dir for new extension ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] I'm in ur trunk, reviewing pre-1.18 branch code
On Mon, Jun 13, 2011 at 4:19 PM, Brion Vibber br...@pobox.com wrote: When we were prepping 1.17 for deployment the theory seemed to be that it'd be out the door and *done* within a couple weeks and we'd be able to concentrate on 1.18 from there out and keep up with everything. Part of the problem was that we weren't doing a good job of minding this list: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/tag/1.17 That was my fault for not specifically tracking that, but it was something that all of us who wanted to get 1.17 could have done. By tracking, I mean looking out for superfluous additions to that list, and nixing them. Also, making sure that anything on that list was truly ready to go (e.g. proper release notes already written, reviews done, etc). We also found that people would attach bugs to the 1.17 release blocker just to get our attention. Even bugs that were clearly deployment-only got attached from time to time. For 1.18, I've at least added a new pre-release preparation section to this doc: http://www.mediawiki.org/wiki/Release_checklist#Pre-release_preparation Anyone interested in helping the 1.18 release process go faster can make sure that that list is correct, and by pitching in on anything necessary to get through that list more quickly. There's a number of things that I'll be talking to folks on my team about in order to make go smoother for 1.18, and there's a number of things that I'm planning to do differently myself. However, there's a wider commitment that's needed to make the 1.18 cycle significantly different from the 1.17 cycle. Give us a deployment date for 1.18 and make it a top priority for engineering. Give us a release date for 1.18 and make it a top priority for engineering. If releasing 1.18 becomes a top priority over anything that actually goes into it, then committing to a date is easy. We'll just rename 1.17 to 1.18 and call it good. :-) If, however, people care about the actual features that go in, and actually care about getting through the review queue and all of that, we need to establish how quickly we can do that in the first place. The 1.17 deployment only provides us with so much historical guidance. Trevor and Roan were pretty motivated to get Resource Loader out the door, and busted tail to get through the review queue much more quickly than we might have otherwise done. They sprinted through a big backlog, and when they were done, they were ready to move on to other stuff (and there was plenty more the org wanted them to do). We probably won't have the same level of dedication to the problem that they had last go around. We also need to figure out which things can afford to wait while we retool. My understanding of the Features team work is that the 20% tax is unaccounted for in the current model. I'll let Alolita speak to it, but I don't believe we've agreed to change any dates yet as a result of adding 20% time to the devs schedules. Even when we get 20% of everyone's time, that will help, but we're going to have to use that time more effectively than we have. I think it's more than just telling everyone to work harder. I think there's a fundamental problem with the way we accept and review code. Brion, you and I have spoken about this, but I don't think we've gotten to the heart of the matter. It's pretty clear that for most reviewers, they just haven't hit the sweet spot of speed necessary to deal with the velocity of commits we're getting, and completeness necessary for reviewers to feel good having their names associated with an ok mark (or comfortable reverting, or whatever). That may be a matter of training, it may be other things, but we've gotta figure that problem, too. We've proven we can sprint fast enough to make a dent in the backlog (e.g. late 2010), but we can't sustain that pace. Also, releasing 1.18 isn't my top priority. Het Deploy[1] is higher on the list. I'm not willing to cut Het Deploy from this release just to make a date. We are going to have a more sane way of doing deployments before we deploy another major version of MediaWiki. I'm not budging on that one. We can set a goal, but in my experience, setting a date that engineers don't actually believe in is counterproductive. I'm personally not willing to set a date until we establish that we can go *a week* at the pace necessary to achieve anything like the goals we set out (e.g. July). At this point, I can set a date, but you probably won't like it (probably September-ish). I'd rather we show better results on the code review process first, and only then would I venture a more optimistic target. I wouldn't set the date without at least making sure that it passes the smell test with some key people here. Anyway, I don't want to be down on the idea that we should release more often. It should be possible for us to get the queue down, and keep it down with a concerted effort, and I think the concerted effort will be worth it. Rob
[MediaWiki-CodeReview] [MediaWiki r90000]: New comment added
User MaxSem posted a comment on MediaWiki.r9. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/9#c18026 Commit summary: avoid test being marked as incomplete due to lack of assertions Comment: That function returns error message, not bool. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r66872]: New comment added
User Duplicatebug posted a comment on MediaWiki.r66872. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/66872#c18027 Commit summary: bug 23524 - url for ApiQueryIWLinks to expand full URL Comment: It there any action to change this? Or it is better to open a bug, because it is easy to track (for you)? Thanks. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89539]: New comment added
User Duplicatebug posted a comment on MediaWiki.r89539. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89539#c18028 Commit summary: * (bug 29237) add interwiki target url attribute to api/query/interwiki Comment: This produce wrong output for tturl/tt, because tt$rawTitleStr/tt contains the interwiki prefix already. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90038]: Revision status changed
User ^demon changed the status of MediaWiki.r90038. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90038#c0 Commit summary: * Initial commit ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90038]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r90038.
Old Status: deferred
New Status: new
User Nikerabbit also posted a comment on MediaWiki.r90038.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90038#c18029
Commit summary:
* Initial commit
Comment:
pre
+/* run this script out of your $IP/maintenance folder */
+require_once( 'Maintenance.php' );
/pre
I don't think this is the best way to do this. I've used:
pre
if ( getenv( 'MW_INSTALL_PATH' ) !== false ) {
$IP = getenv( 'MW_INSTALL_PATH' );
} else {
$dir = dirname( __FILE__ ); $IP = $dir/../..;
}
require_once( $IP/maintenance/commandLine.inc );
/pre
+$this-output('Updating '.$titleObj-getText().' ... ');
+$this-output('complete'.\n);
You could use the second parameter for output() for this. Doesn't matter so
much if you are not throwing errors in the middle.
Here the indentation looks horrible. I suggest using tabs only up to the
current indentation level and do the rest with spaces if at all. Here you could
just split the line after array( to avoid the extra indentation.
pre
+$wgExIndexMIMETypes = array( 'application/pdf',
+
'application/xml',
+ 'text/xml',
+
'application/msword' ,
+ 'text/plain',
+ 'text/html' );
/pre
Running stylize script over the code would be nice.
I haven't seen $wgEx prefixed used elsewhere.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90028]: Revision status changed
User ^demon changed the status of MediaWiki.r90028. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90028#c0 Commit summary: Tagging for release of 1.17.0rc1 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90022]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90022. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90022#c18030 Commit summary: home link on the RTL wiki leads to the English mobile main page Comment: Addition w.gif was unmentioned in commit message. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90032]: Revision status changed
User ^demon changed the status of MediaWiki.r90032. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90032#c0 Commit summary: Code style cleanup from r90024 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90021]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90021. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90021#c18031 Commit summary: Convert a couple of wfDie()s to exceptions Comment: Do we get backtraces on cli? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90008]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90008. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90008#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-06-13 20:07:00) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90021]: New comment added
User ^demon posted a comment on MediaWiki.r90021. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90021#c18032 Commit summary: Convert a couple of wfDie()s to exceptions Comment: If $wgShowExceptionDetails is enabled, just like in the UI. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90007]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90007. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90007#c18033 Commit summary: Comment: So what is the user visible change? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89937]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r89937. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r89937. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89937#c18034 Commit summary: Update per r89898 Comment: interwiki-defaulturl is both optional and ignored. Should only be either. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89870]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r89870. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89870#c0 Commit summary: Fix a typing error in a comment. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90005]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90005. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90005#c0 Commit summary: Followup r89973: Update for Translatewiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90004]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90004. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90004#c0 Commit summary: Followup r89973: Remove useless spaces, ignore 1 message for Translatewiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89791]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r89791. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89791#c0 Commit summary: Add extension description message Add extension to Translatewiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89768]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r89768. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89768#c0 Commit summary: * Move special page alias defintion to its own file * Sort i18n file: 'en', 'qqq' and the translations * Slights message tweaks for consistency * Normalize 'descriptionmsg' key * 'de' translations are always informell (Du). formal address goes into 'de-formal' and will be done by our Translatewiki folks * Add extension to Translatewiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89446]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r89446. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r89446. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89446#c18035 Commit summary: Update checker for EOL. Comment: You probably want to use your name and update the year :) + * @copyright Copyright © 2009-2010, Niklas Laxström ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89087]: New comment added
User Nikerabbit posted a comment on MediaWiki.r89087. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89087#c18036 Commit summary: PreviousTarget is now optional when blocking a user The API does not seem to give a PreviousTarget field all the time. This patch also fix the an assertion for ApiBlockTest::testMakeNormalBlock Comment: Some reason isset() cannot be used here? I'd prefer !== because we know both should be strings to match. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89176]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r89176.
Old Status: new
New Status: fixme
User Nikerabbit also posted a comment on MediaWiki.r89176.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89176#c18037
Commit summary:
* make preprocessorFuzzTest.php pass the Title object to Parser, removed checks
for non-object in Parser
* make the parser use ParserOptions::getUser() instead of $wgUser
* fixed some E_NOTICE and E_STRICT in preprocessorFuzzTest.php
Comment:
pre
+ function getOption( $oname, $defaultOverride = null, $ignoreHidden =
false ) {
if ( $option === 'fancysig' ) {
/pre
This doesn't look right.
Would it make sense to add Title type hint to arguments of testFoo methods?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89038]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r89038. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89038#c0 Commit summary: Loads more documentation for this file.. Hopefully CR will show it all ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89446]: New comment added
User Siebrand posted a comment on MediaWiki.r89446. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89446#c18038 Commit summary: Update checker for EOL. Comment: It is just a lame copy, so I claim no copyright. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89446]: New comment added
User Nikerabbit posted a comment on MediaWiki.r89446. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89446#c18039 Commit summary: Update checker for EOL. Comment: Fine, too much effort. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89950]: Revision status changed
User Catrope changed the status of MediaWiki.r89950. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89950#c0 Commit summary: do not sent api requests for empty inputs, e.g. after a character input followed by a backspace in the search input. Make sure to clear the result div to wipe previous results at the client w/o sending a request. Lowers server load ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89952]: Revision status changed
User Catrope changed the status of MediaWiki.r89952. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89952#c0 Commit summary: corrected comment ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89955]: Revision status changed
User Catrope changed the status of MediaWiki.r89955. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89955#c0 Commit summary: essage=corrected my mistake when comparing if textbox length is empty, or not. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89954]: Revision status changed
User Catrope changed the status of MediaWiki.r89954. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89954#c0 Commit summary: removed code for clearing result div in case of empty input textbox. This is now handled in the jquery.suggestion.js class see r89951 and bug29368 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89953]: Revision status changed
User Catrope changed the status of MediaWiki.r89953. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89953#c0 Commit summary: corrected comment ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89951]: Revision status changed
User Catrope changed the status of MediaWiki.r89951. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89951#c0 Commit summary: fix for bug29368 which may have consequences. Please code reviewers, pls. check for potential side effects - I cannot detect any, currently. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89957]: Revision status changed
User Catrope changed the status of MediaWiki.r89957. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89957#c0 Commit summary: resinserted context.data.prevText = context.data..val(); which was accidentially dropped ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89956]: Revision status changed
User Catrope changed the status of MediaWiki.r89956. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89956#c0 Commit summary: follow up patch to r89950 r89952 r89953 r89955 : moved div clearing inside call back function maybeFetch so that this is also done when coming from timeouts ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89982]: Revision status changed
User Catrope changed the status of MediaWiki.r89982. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89982#c0 Commit summary: Check if page is ArticleFeedback-enabled before saving in the API * (bug ) * Fix TypeErorr exception in 'condition' function (wgRestrictionEdit is only defined on existing pages, checking length requires that it defined, adding fallback to empty array) * Correct comment in ext.articleFeedback.startup.js namespace check, not main namespace perse, anything allowed by wgArticleFeedbackNamespaces. * Add 'invalidpage' to getPossibleErrors ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90017]: New comment added, and revision status changed
User Catrope changed the status of MediaWiki.r90017. Old Status: new New Status: fixme User Catrope also posted a comment on MediaWiki.r90017. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90017#c18040 Commit summary: Fixed problem: Edit Summary should mention WikiLove Comment: pre - 'section' = 'new', - 'text' = $params['text'], + 'text' = Article::newFromTitle( $talk, new RequestContext() )-replaceSection( 'new', $params['text'], $params['subject'] ), /pre * Please don't use RequestContext in this extension, that makes it undeployable (1.17wmf1 doesn't have RequestContext) ** For creating an Article can't you still just use codenew Article( $title, 0 ) /code ? * You should add a comment explaining why you're doing this instead of using section=new. I only noticed when reading the code the third time (section name and summary differ by a codewfMsgForContent()/code call) OK otherwise. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90018]: Revision status changed
User Catrope changed the status of MediaWiki.r90018. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90018#c0 Commit summary: Fixed JS leakage ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90043]: New comment added
User Siebrand posted a comment on MediaWiki.r90043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90043#c18041 Commit summary: First pass at http://www.mediawiki.org/wiki/MoodBar backend. Comment: Can you please rename the messages file to MoodBar.i18n.php as this is the current naming convention for messages files? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90043]: New comment added
User Werdna posted a comment on MediaWiki.r90043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90043#c18042 Commit summary: First pass at http://www.mediawiki.org/wiki/MoodBar backend. Comment: I prefer to use a different name because it makes autocomplete and scanning the file list easier — is there a convincing reason to stick to MoodBar.i18n.php other than all the other extensions do it? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90043]: New comment added
User Siebrand posted a comment on MediaWiki.r90043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90043#c18043 Commit summary: First pass at http://www.mediawiki.org/wiki/MoodBar backend. Comment: It takes more configuration to add support for the Translate extension, and all the other couple of hundred extensions do it. We have just taken a few years cleaning everything up. But if it is really important, just add a no rename request in the i18n file. People will understand. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90043]: New comment added
User Werdna posted a comment on MediaWiki.r90043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90043#c18044 Commit summary: First pass at http://www.mediawiki.org/wiki/MoodBar backend. Comment: I've renamed it, I didn't realise it caused issues with Translate. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89176]: New comment added
User IAlex posted a comment on MediaWiki.r89176. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89176#c18045 Commit summary: * make preprocessorFuzzTest.php pass the Title object to Parser, removed checks for non-object in Parser * make the parser use ParserOptions::getUser() instead of $wgUser * fixed some E_NOTICE and E_STRICT in preprocessorFuzzTest.php Comment: Done in r90053. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90054]: Revision status changed
User MaxSem changed the status of MediaWiki.r90054. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90054#c0 Commit summary: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90046]: Revision status changed
User Catrope changed the status of MediaWiki.r90046. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90046#c0 Commit summary: Fixed r90017 per https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90017#c18040 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90017]: Revision status changed
User Catrope changed the status of MediaWiki.r90017. Old Status: fixme New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90017#c0 Commit summary: Fixed problem: Edit Summary should mention WikiLove ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90050]: Revision status changed
User Catrope changed the status of MediaWiki.r90050. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90050#c0 Commit summary: Actually fills the database with registration and edit count data now. Removed the recent edit count as I don't see a way to efficiently include that right now. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Code review process (was: Status of more regular code deployments)
Erik Moeller wrote: On Thu, Jun 2, 2011 at 2:26 AM, Roan Kattouw roan.katt...@gmail.com wrote: I like the 20% model as well. It goes a little bit further than my suggestion, which was 20, 25 or 33% model for certain senior devs, but if you're volunteering to give me more than what I asked for that's even better :) . For numerous reasons, I think getting /everyone/ involved with service work is a great idea. To keep the ball rolling, I've started a draft here, based in part on your comments: http://www.mediawiki.org/wiki/Development_process_improvement/20%25_policy Please be bold and/or add your thoughts. As per the note on the page and other comments in this thread, a policy like this isn't a replacement for dedicated staff supporting the code review and release process; it's merely one component of ensuring appropriate capacity is available for relevant work. This looks great! Both your post and Brion's yesterday have been spot-on. I think with a few people doing shell bugs every week (as an example), the backlog will be killed in no time. Shell bugs are generally some of the most user-facing issues, so reducing time between filing and fulfillment on those will go a long way toward keeping users happy. There are also structural improvements that can be made (such as getting a Configure extension working on Wikimedia wikis) that could eliminate the need for sysadmin intervention a lot of the time. I'm not sure if working on projects that like would fall within the 20% rule as written, but it's something to think about. The only other point from your list that I think maybe could possibly be made explicit is a focus on the sister projects. It's pretty clear that during the 80%, Wikipedia is the central focus. I've been doing some work on Wikisource lately and without looking very hard, it's very easy to see how some support structures on the sister sites (API support, rewrites of some of these extensions, moving code from JavaScript to PHP, etc.) could really enable third-party developers. Overall, this seems like a really positive step in the right direction. :-) MZMcBride ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] Map not displaying
I just installed the maps extension. - Version 0.7.6.1
Mediawiki version 1.15.3
PHP version 5.2.8 (isapi)
MySQL 5.1.40-community
I have {{#display_map:
30° 44'14 N, 76° 47' 14E | service=googlemaps}}
I received a google api key and added that to localSettings after including the
extension. It tries to draw the map but stops at Loading Map ...
Is there something else I need to do.
Thanks,
Mary Beebe
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] background shell process control and exit status
For the TimedMediaHandler I was adding more fine grain control over background processes [1] and ran into a unix issue around getting both a pid and exit status for a given background shell command. Essentially with a background task I can get the pid or the exit status but can't seem to get both: to get the pid: $pid = wfShellExec(nohup nice -n 19 $cmd /tmp/stdout.log echo $!; put the exit status into a file: $pid = wfShellExec(nohup nice -n 19 $cmd /tmp/stdout.log echo $? /tmp/exit.status; But if I try to get both either my exit status is for the echo pid command or my pid is for the echo exit status command. It seems like there should be some shell trick back-reference background tasks or something If nothing else I think this could be done with a shell script and pass in a lot of path targets and use the wait $pid command at the end to grab the exit code of the background process. Did a quick guess at what this would look like in that same commit[1], but would rather just do some command line magic instead of putting a .sh script in the extension. [1] http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90068 peace, --michael ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90062]: Revision status changed
User ^demon changed the status of MediaWiki.r90062. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90062#c0 Commit summary: MFT r89598 to 1.17 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88965]: Revision status changed
User Catrope changed the status of MediaWiki.r88965. Old Status: fixme New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88965#c0 Commit summary: Removed the old gallery function and moved some functionality to the current gallery function. It's now possible to show a random selection of images. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90068]: New comment added
User ^demon posted a comment on MediaWiki.r90068. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90068#c18046 Commit summary: bug 29184 Adds background transcoding support. $wgEnableNiceBackgroundTranscodeJobs configuration option enables: * Global Timeout, don't let any transcode go on indefinitely * Growing target files, don't let transcodes not do any work for more than 10 seconds. * Enables us to set lower resource priority on transcodes to keep multi-threaded transcode boxes responsive for other tasks ( like monitoring transcodes ) TODO figure out a way to get exit status and PID for background tasks ( some notes in the header ) Comment: I just happened to notice this here, seems to go back further...I'm not sure why you need to introduce a global for the path to the maintenance directory. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90064]: New comment added, and revision status changed
User Nikerabbit changed the status of MediaWiki.r90064. Old Status: new New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r90064. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90064#c18047 Commit summary: Adding the Create page Job class. Comment: Article constructor needs zero as second parameter. +$article = new Article( $this-title ); doEdit nowdays takes user as parameter - use it instead of the global + global $wgUser; ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90068]: New comment added
User Mdale posted a comment on MediaWiki.r90068. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90068#c18048 Commit summary: bug 29184 Adds background transcoding support. $wgEnableNiceBackgroundTranscodeJobs configuration option enables: * Global Timeout, don't let any transcode go on indefinitely * Growing target files, don't let transcodes not do any work for more than 10 seconds. * Enables us to set lower resource priority on transcodes to keep multi-threaded transcode boxes responsive for other tasks ( like monitoring transcodes ) TODO figure out a way to get exit status and PID for background tasks ( some notes in the header ) Comment: not sure why ... fixed in r90072 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90067]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90067. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90067#c0 Commit summary: Fix extension credits Register i18n file Tweak messages for consistency Add extension to Translatewiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90069]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90069. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90069#c0 Commit summary: Tweak message for consistency Add extension to Translatewiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Interested in Postgres support? Submit a talk to Postgres Open
You have two weeks to submit a talk to Postgres Open (Chicago, USA, September 14-16). If you care about MediaWiki running on Postgres, this would be a great opportunity to activate the Postgres community and get more of them using and contributing. http://postgresopen.org/2011/speaker/ Talk proposals will be accepted until June 27, 2011 at 11:59pm (Chicago time, I assume). They're looking for workshops, case studies, HOWTOs, product presentations, and innovation and scaling reports. More details: http://postgresopen.org/2011/blog/2011/06/03/cfp-2011/ I'll happily help anyone who wants help preparing a proposal. Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90070]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90070. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90070#c0 Commit summary: Fix extension credits Add extension to Translatewiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90071]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90071. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90071#c0 Commit summary: Tweak message for consistency Add extension to Translatewiki ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89811]: Revision status changed
User Catrope changed the status of MediaWiki.r89811. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89811#c0 Commit summary: adding new fields for requested analytics ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90072]: New comment added
User ^demon posted a comment on MediaWiki.r90072.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90072#c18049
Commit summary:
r90068#c18046 no need for global to grab maintenance directory
Comment:
Entry points for extension maintenance scripts should be something like this
(from CodeReview):
pre
$IP = getenv( 'MW_INSTALL_PATH' );
if ( $IP === false ) {
$IP = dirname( __FILE__ ) . '/../..';
}
require( $IP/maintenance/Maintenance.php );
class SvnImport extends Maintenance {
/pre
You would use /../../.., but the point is the same :)
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r71412]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r71412. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/71412#c0 Commit summary: Added $wgAdaptiveMessageCache to avoid caching huge pile of never used messages at twn. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90072]: New comment added
User ^demon posted a comment on MediaWiki.r90072. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90072#c18050 Commit summary: r90068#c18046 no need for global to grab maintenance directory Comment: You're also still using the global in runCheckJobThreadsLoop(), just use $IP. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90073]: Revision status changed
User ^demon changed the status of MediaWiki.r90073. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90073#c0 Commit summary: r90072#c18049 check for env MW_INSTALL_PATH in include of maintenance script ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86467]: Revision status changed
User ^demon changed the status of MediaWiki.r86467. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86467#c0 Commit summary: * Made SiteStatsInit::articles() give a correct result when $wgUseCommaCount is false (btw, do we really need to keep that variable?) * Changed updateArticleCount.php to use that function instead of doing its own query ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86798]: Revision status changed
User ^demon changed the status of MediaWiki.r86798. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86798#c0 Commit summary: Some type-hinting and documentation in HTMLForm.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86800]: Revision status changed
User ^demon changed the status of MediaWiki.r86800. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86800#c0 Commit summary: Tidy up some unused variables and such ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90072]: Revision status changed
User ^demon changed the status of MediaWiki.r90072. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90072#c0 Commit summary: r90068#c18046 no need for global to grab maintenance directory ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90074]: Revision status changed
User ^demon changed the status of MediaWiki.r90074. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90074#c0 Commit summary: r90072#c18050 opps .. forgot to update function reference to maintenance path ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r77893]: New comment added, and revision status changed
User Aaron Schulz changed the status of MediaWiki.r77893. Old Status: new New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r77893. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/77893#c18051 Commit summary: More skin system improvements; Create a new BaseTemplate class extended from QuickTemplate, this class will house helper methods that interact with QuickTemplate data set by SkinTemplate to help cut down on boilerplate for common uses of that data. For the first helper in this class add a helper to use in generating a toolbox. Include a list item and link generating method that can be used to generate most of our sidebar links with minimal code. Eventually this toolbox code will be used in code abstracting common sidebar generating code away into common helpers. For now make MonoBook and Vector and the skins based off of them use this method of generating toolboxes and sidebar links. Comment: The new SkinTemplate() functions are like Swiss army knives ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86821]: Revision status changed
User ^demon changed the status of MediaWiki.r86821. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86821#c0 Commit summary: * Use wfMsgNoTrans() instead of wfMsgReal() * Simplify getPageTitle() * Remove a useless call to getPageTitle(), img tag does not have content ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86373]: Revision status changed
User ^demon changed the status of MediaWiki.r86373. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86373#c0 Commit summary: Removed action=print; I can't find anything using this ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86373]: New comment added
User ^demon posted a comment on MediaWiki.r86373. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86373#c18052 Commit summary: Removed action=print; I can't find anything using this Comment: Needs release notes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r78003]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r78003. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78003#c0 Commit summary: Commit getFooterLinks and getFooterIcons helpers to abstract the common code used to trim footerlinks down to only valid items, flatten it if needed, trim non-image icons out of footericons, and remove the copyright icon if needed. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r78127]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r78127. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78127#c0 Commit summary: For consistency: call set both article and article related flags to false instead of only article flag ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r78170]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r78170. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78170#c0 Commit summary: Fix regression in r78117 per CR, was causing read, edit and history tabs to disappear for users who couldn't edit due to $wgEmailConfirmToEdit or $wgNamespaceProtection ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89948]: New comment added
User Platonides posted a comment on MediaWiki.r89948. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89948#c18053 Commit summary: * Fix I18nTags #languagename to use ParserOptions::getUserLang() * Fix ParserOptions::getUserLang() to return code as documented Comment: You weren't supposed to pass setUserLang() a Language object. Maybe it should thrown an exception instead of doing the right thing. Passing setUserLang() an object and getting a Language code is also weird... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89948]: New comment added
User Nikerabbit posted a comment on MediaWiki.r89948. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89948#c18054 Commit summary: * Fix I18nTags #languagename to use ParserOptions::getUserLang() * Fix ParserOptions::getUserLang() to return code as documented Comment: This was just a quick fix. Feel free to replace with a better one. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86354]: Revision status changed
User ^demon changed the status of MediaWiki.r86354. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86354#c0 Commit summary: Add ThrottledError to throw when the user hits a rate limit. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86201]: Revision status changed
User ^demon changed the status of MediaWiki.r86201. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86201#c0 Commit summary: Update $wgEXIFMessages for r86169. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86219]: Revision status changed
User ^demon changed the status of MediaWiki.r86219.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86219#c0
Commit summary:
(follow-up r86169) I had {{plural}} screwed up in
Exif-gpsaltitude-below-sealevel and Exif-gpsaltitude-above-sealevel
Thank you to DCLXVI from translatewiki for pointing this out to me :)
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89836]: Revision status changed
User Catrope changed the status of MediaWiki.r89836. Old Status: new New Status: resolved Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89836#c0 Commit summary: better field size for registration ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85934]: Revision status changed
User ^demon changed the status of MediaWiki.r85934. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85934#c0 Commit summary: * Removed getSelectOptions, which did nothing other than send FOR UPDATE on some slave queries to barely used features * Removed only Core use of forUpdate(); same issue ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85930]: Revision status changed
User ^demon changed the status of MediaWiki.r85930. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85930#c0 Commit summary: Follow-up r85928: AutoLoader entry. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85928]: Revision status changed
User ^demon changed the status of MediaWiki.r85928. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85928#c0 Commit summary: allow methods to generate a user does not have required permissions error by throwing an exception rather than calling $wgOut-permissionRequired(). Currently somewhat circular as the exception goes back to OutputPage::showErrorPage(), but hopefully that global dependency can be reduced in future. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
