[MediaWiki-CodeReview] [MediaWiki r85324]: New comment added
User Happy-melon posted a comment on MediaWiki.r85324. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85324#c18796 Commit summary: Styling for revdel'd revision links for oversighters/admins: make the links still be greyed out, but still active and with underline-on-hover. Comment: But here we're talking about administrators and oversighters who will be better versed in where links ''ought'' to be. As an oversighter I found it incredibly irritating to not be able to see easily what ordinary editors were seeing; the general principle is that having extra permissions shouldn't ''change'' what's already in the interface, just add new features. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89408]: New comment added
User Happy-melon posted a comment on MediaWiki.r89408. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89408#c18797 Commit summary: More unpicking of r85288. I think this is all of the magic method calls, but they're very hard to grep for (part of the problem with them!), so let's leave the calls in with a wfDeprecated() for a while... Comment: Is anyone still seeing these? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88738]: Revision status changed
User Happy-melon changed the status of MediaWiki.r88738. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88738#c0 Commit summary: (bug 29116) follow-up r84475: normalise the empty string to null in Block::newFromTarget(). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86335]: New comment added
User Happy-melon posted a comment on MediaWiki.r86335. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86335#c18798 Commit summary: (bug 28583) chase down and beat to death external calls of functions marked /*private*/, and make those declarations actually binding. Patch by yuvipanda. Comment: I'd say that's a good thing; the actual maximum length of the text of a title shouldn't depend on whether the namespace happens to have an unusually long name. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86044]: New comment added, and revision status changed
User Happy-melon changed the status of MediaWiki.r86044. Old Status: fixme New Status: new User Happy-melon also posted a comment on MediaWiki.r86044. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86044#c18799 Commit summary: Follow-up r 86041 per CR and IRC: * Article constructor needs to be called with zero as second parameter * Run stylize.php over new files * Add Action::getLang() for consistency with other context accessors * Fix declaration of FormAction::alterForm(), doesn't need to be passed by reference * Fix inline use of Credits::getCredits() in SkinTemplate and SkinLegacy Comment: Fixed in r90877. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90868]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90868. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90868#c0 Commit summary: switching from instanceof Array to jquery.isArray() ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90806]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90806. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90806#c0 Commit summary: switching to blue hearts per discussion ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90807]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90807. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90807#c0 Commit summary: improvements to css, messages, and default config ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90808]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90808. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90808#c0 Commit summary: removing outdated image files, adding red hearts for back-up ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90810]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90810. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90810#c0 Commit summary: disabling jquery.elastic for now - buggy in firefox ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90813]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90813. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90813#c0 Commit summary: Fix svn:mime-type for 2 images in folder ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90820]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90820. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90820#c0 Commit summary: reverting r90817 per discussion with jorm ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90821]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90821. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90821#c0 Commit summary: disambiguting file name ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90822]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90822. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90822#c0 Commit summary: switching back to red icons per popular demand ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90823]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90823. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90823#c0 Commit summary: mw.util.wikiUrlencode is not meant for encoding entire URLs, or if it is, its too agressive. For example, it encodes tildes, which will break some URLs. Its great for encoding page names, though, which may include question marks, etc. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90842]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90842. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90842#c0 Commit summary: removing wgServer since it isnt necessary (also should be called with mw.config.get anyway) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90746]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90746. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90746#c0 Commit summary: button icons only supported by vector currently ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90677]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90677. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90677#c0 Commit summary: updating jQuery elastic plugin ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90621]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90621. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90621#c0 Commit summary: fixing bad path in r90567 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90567]: New comment added
User JanPaul123 posted a comment on MediaWiki.r90567. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90567#c18800 Commit summary: making message field configurable in preparation for welcome templates, disabling email for barnstars for now (per Howie and Alolita), making label verbiage consistant Comment: I see that you made the message box shown/hidden based on configuration options, but when shown it is still not required to enter a message. I guess we can put that back in now, did so in r90879. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90567]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r90567. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90567#c0 Commit summary: making message field configurable in preparation for welcome templates, disabling email for barnstars for now (per Howie and Alolita), making label verbiage consistant ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Reproducing localurl by python urllib.quote()
I found a number of troubles when trying to replicate localurl: parser function by python urllib.quote(), with a number of annoying bugs. Is this correct-complete? /wiki/+urllib.quote(name-of-page.replace( ,_),/!,;:.-_) where name-of-page is utf-8 encoded. Thanks! I apologyze for so a banal question. Alex brollo ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r88358]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r88358. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88358#c0 Commit summary: refactored to depend less on templates, you can now build most items with just an image and text ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88216]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r88216. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88216#c0 Commit summary: setting tabindex to 0 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87949]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r87949. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87949#c0 Commit summary: a couple css tweaks and fixing circle image so that numbers are properly centered ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87761]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r87761. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87761#c0 Commit summary: Added in icons; modified js to use barnstar icon ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87059]: Revision status changed
User JanPaul123 changed the status of MediaWiki.r87059. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87059#c0 Commit summary: initial files for WikiLove ext ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] MediaWiki 1.17.0 released
On Tue, Jun 21, 2011 at 10:24 PM, Erik Moeller e...@wikimedia.org wrote: \o/ Congratulations, everyone! :-) It's been a long road -- great to see all the hard work that's gone into the new installer, ResourceLoader, and the tons of accumulated fixes and enhancements get out there. -- Erik Möller Deputy Director, Wikimedia Foundation Seconding Erik. Big giant congrats! Thanks for the detailed release notes and the useful summary! I got to tell people about the new MediaWiki at a conference last week and the release notes were very handy. This release also gave me the opportunity to brag about our new features and fixes in front of Ward Cunningham: http://twitpic.com/5gcekn So that was pretty cool. Onwards to 1.18 and beyond! Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85322]: Revision status changed
User Happy-melon changed the status of MediaWiki.r85322. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85322#c0 Commit summary: Add the revision-info and revision-info-current messages directly to the page, don't stick them in the content sub; this adds unwanted extra CSS styling which screws with the margin and font size. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90877]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90877. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90877#c18802 Commit summary: Follow-up r86044 CR (correct subtitle message for action=credits), and some documentation. Comment: What do you think ttstrtolower( 'creditspage' )/tt will return? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90877]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r90877. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90877#c0 Commit summary: Follow-up r86044 CR (correct subtitle message for action=credits), and some documentation. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90866]: New comment added, and revision status changed
User Hashar changed the status of MediaWiki.r90866. Old Status: new New Status: ok User Hashar also posted a comment on MediaWiki.r90866. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90866#c18803 Commit summary: Tweaked r90766 messages. Still awkward. Also, this still needs JS to disable the check if all is selected, to be less confusing. Comment: Thanks for the review Aaron ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86490]: Revision status changed
User Reedy changed the status of MediaWiki.r86490. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86490#c0 Commit summary: Restore r84687 (reverted in r84751). Now with a few extra features: * Now called 'overview' rather than 'scapmap', to hopefully prevent more IRC-cabal reverts :P * Tab is added to p-namespaces, not into the dropdown menu in p-cactions * Clicking again on the tab hides the overview. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81087]: New comment added
User Reedy posted a comment on MediaWiki.r81087. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81087#c18806 Commit summary: Added a warning so non-mediawiki-developers understand that they are getting a snapshot from trunk and not something that has been tested to be compatible with the selected MW version or work at all Comment: Can we decide what to do here, whether revert, fix the message or whatever to finish this off? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r70095]: Revision status changed
User Reedy changed the status of MediaWiki.r70095. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/70095#c0 Commit summary: Restructured upload-by-url: * In ApiUpload: moved stuff that is checking instead of actual uploading out of performUpload method * Made UploadFromUrl conform to standards: ** In initialize* do only initialization, no actual work ** Moved file fetching to fetchFile ** Consistent use of tempnam() ** Perform the uploading in performUpload, don't define our own doUpload method * Moved almost all job magic to the UploadFromUrlJob class. This way the job is almost a regular client, and we don't need many special cases to deal with async uploading. * Made leaving a message optional; results will be stored in the session otherwise I did not actually test the async uploading, because I first wanted to commit a properly working synchronous upload-by-url system. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r72475]: Revision status changed
User Reedy changed the status of MediaWiki.r72475. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/72475#c0 Commit summary: Follow-up r70137: Made asynchronous upload working a bit more. It now fully works from the API; works still needs to be done for the normal UI. PHPUnit tests are updated and should cover most code paths that can be called from the API. ApiUpload: * Added statuskey parameter; this is the key that is returned by an async upload * Refactored warnings transformation into its own function * filename is no longer required on all uploads UploadFromUrlJob: * Moved upload results to its own entry in $_SESSION, instead of using the one from upload * Fix storing in session by calling wfSetupSession and session_write_close where needed Tests: * Set $wgUser in ApiSetup, so that individual tests don't have to do this for themselves * Added tests to cover most code paths from the API * Fixed UploadFromUrlTestSuite so that its tests are included in a regular phpunit invocation (something strange with the AutoLoader; not sure what) Other files: * Allow passing session id to wfSetupSession * Explicitly close the session before doing jobs, so that jobs can't manipulate the current session ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r78179]: Revision status changed
User Reedy changed the status of MediaWiki.r78179. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78179#c0 Commit summary: Fix regression in r70657. Misplaced else condition was causing cache misses to try to load the message text and cache the result individually. However in the default configuration cache miss always means that the message doesn't exists in the database. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89583]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r89583. Old Status: new New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r89583. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89583#c18807 Commit summary: fundraising specific code - mostly for automatic link construction and tracking Comment: Only problem that stood out on the PHP/JS interface was the stray console.debug; has been removed in r90892. Renamed component of banner JSON data looks like it should be fine as long as code data go out together. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90680]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r90680. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90680#c0 Commit summary: making fundraising interface dependant on wgNoticeEnableFundraising global var ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89279]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r89279. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r89279. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89279#c18808 Commit summary: better function names Comment: Updates to modern terminology to make maintenance easier for the fundraising devs :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81087]: New comment added
User ^demon posted a comment on MediaWiki.r81087. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81087#c18809 Commit summary: Added a warning so non-mediawiki-developers understand that they are getting a snapshot from trunk and not something that has been tested to be compatible with the selected MW version or work at all Comment: I still say revert, but I'm not willing to argue this in circles again. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89284]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r89284. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r89284. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89284#c18810 Commit summary: changing some var names to reflect current naming, fixing some tabs, adding some comments Comment: Leaving a todo tag for the extra internal escaping stuff -- they'll get to it as maintenance cleanup later, it works for now and is safe, just confusing. :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89286]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r89286. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89286#c0 Commit summary: add static method for looking up campaign name ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90326]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r90326. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90326#c0 Commit summary: using better function name, adding function documentation ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90327]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r90327. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90327#c0 Commit summary: consistant formatting for list ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90890]: Revision status changed
User ^demon changed the status of MediaWiki.r90890. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90890#c0 Commit summary: Remove commented out live code which we don't use now ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90889]: Revision status changed
User ^demon changed the status of MediaWiki.r90889. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90889#c0 Commit summary: Followup r86490, remove spurious r ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90328]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r90328. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r90328. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90328#c18811 Commit summary: adding php unit testing (with a simple test for testing) Comment: Yay testing :D ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90886]: Revision status changed
User ^demon changed the status of MediaWiki.r90886. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90886#c0 Commit summary: Removed unused call to variable ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90891]: Revision status changed
User ^demon changed the status of MediaWiki.r90891. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90891#c0 Commit summary: Kill unused css as of r90890 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88515]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r88515. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88515#c0 Commit summary: fix to make page work on wikis that use a db table prefix ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90893]: Revision status changed
User ^demon changed the status of MediaWiki.r90893. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90893#c0 Commit summary: Follow-up r86490 CR: localise strings and synchronise CSS styles. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87224]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r87224. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87224#c0 Commit summary: Message 'centralnotice-multiple' was used in two different contexts. Now there is a message for each context. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85832]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r85832. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85832#c0 Commit summary: we want all supported languages even if they dont have customized system messages ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83746]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r83746. Old Status: new New Status: fixme User Brion VIBBER also posted a comment on MediaWiki.r83746. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83746#c18812 Commit summary: Load SpecialNoticeTemplate class also on non-infrastructure wikis. PHP Fatal error: Class 'SpecialNoticeTemplate' not found in CentralNotice/SpecialBannerLoader.php on line 66 Comment: Per discussion with kaldari this seems like it shouldn't happen -- Special:BannerLoader is never supposed to be called except from the banner host wiki (metawiki in production), and that's the only thing calling templateExists. Client wikis should never access the banner database directly... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83745]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r83745. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r83745. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83745#c18813 Commit summary: Fix fatal error when running without CentralAuth PHP Fatal error: Class 'CentralAuthUser' not found in SpecialHideBanners.php on line 35 was experienced when running standalone (i.e. not on Wikimedia cluster with CentralAuth). Comment: This looks correct; previous is_callable call was wrong form. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90874]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90874. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90874#c0 Commit summary: Follow-up r88738: this check is no longer needed since r88750. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83718]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r83718. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83718#c0 Commit summary: Fix PHP Parse error from r83715, use $wgExtensionAssetsPath * $wgScriptPath/extensions - $wgExtensionAssetsPath * Fix syntax error, unexpected T_DOUBLE_ARROW in CentralNotice/SpecialBannerLoader.php on line 16 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83715]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r83715. Old Status: new New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r83715. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83715#c18815 Commit summary: Improve fetching of the donation amount, remove unecessary globals. * Add User-Agent header when accessing wikimediafoundation.org to prevent 403s * If remote information is for some reason unavailable, don't display the banner at all * Remove globals that are no longer used * Use $wgDBName as the default $wgCentralDBname for small wikis. Schema update will create tables in $wgDBName anyway. Comment: Looks ok, though there is a lot of additional code duplication added in r83744 which should be undone. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83744]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r83744. Old Status: fixme New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r83744. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83744#c18816 Commit summary: Followup to r83715: use internal HTTP client, handle exception when previewing * Replace own HTTP client with the generic HTTP::get (as per code review) * SpecialBannerLoaderException needs to be handled when previewing banners. This exception needs to handled in the user interface, currently a newly introduced 'centralnotice-nopreview' message is displayed in case of banner generation failure. Further work: * Unfortunately, UI code is full of duplication and should probably be refactored. * getDonationAmount() and friends should factored out of the SpecialBannerLoader Comment: Marking this as 'todo' for now; there is code duplication that's unneeded but it looks harmless. kaldari will follow up on it later with additional cleanup. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90490]: Revision status changed
User Catrope changed the status of MediaWiki.r90490. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/90490#c0 Commit summary: * (bug 29278) server error 500 when attempting to add text to a page via redirect (redirect points to the page and page is edited) Needs 1.17 and 1.18 backporting, so release notes will go in 1.17 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90895]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90895. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90895#c0 Commit summary: (bug 29511) block dropdown reasons should be in wiki content language. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89779]: New comment added
User Catrope posted a comment on MediaWiki.r89779. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89779#c18817 Commit summary: Fix messages on Special:ArticleFeedback per Howie Comment: No, it's not 70% or (more low) ratings where (more low) == (lower), it's (70% or more) low ratings, as in 70% or more bad things ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r89779]: New comment added, and revision status changed
User Aaron Schulz changed the status of MediaWiki.r89779. Old Status: fixme New Status: new User Aaron Schulz also posted a comment on MediaWiki.r89779. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/89779#c18818 Commit summary: Fix messages on Special:ArticleFeedback per Howie Comment: Then can the wording at least be tweaked? Resetting to 'new' as non-urgent. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83746]: New comment added
User Kaldari posted a comment on MediaWiki.r83746. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83746#c18819 Commit summary: Load SpecialNoticeTemplate class also on non-infrastructure wikis. PHP Fatal error: Class 'SpecialNoticeTemplate' not found in CentralNotice/SpecialBannerLoader.php on line 66 Comment: I went ahead and moved the bannerExists() function to the CentralNoticeDB class, which is where it belongs anyway (public static methods that just return information from the DB). This removes the dependency on SpecialNoticeTemplate. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90897]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r90897. Old Status: new New Status: ok User Brion VIBBER also posted a comment on MediaWiki.r90897. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90897#c18820 Commit summary: follow-up to r83746 - move static method into DB class Comment: Looks good! ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83746]: Revision status changed
User Brion VIBBER changed the status of MediaWiki.r83746. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83746#c0 Commit summary: Load SpecialNoticeTemplate class also on non-infrastructure wikis. PHP Fatal error: Class 'SpecialNoticeTemplate' not found in CentralNotice/SpecialBannerLoader.php on line 66 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85288]: New comment added, and revision status changed
User Happy-melon changed the status of MediaWiki.r85288. Old Status: fixme New Status: reverted User Happy-melon also posted a comment on MediaWiki.r85288. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85288#c18821 Commit summary: Implement magic accessors for RequestContext variables: you can now just call $context-request-stuff(), and that is internally mapped to the get accessor. Rename the private variables to the old $mName syntax: I know that that's discouraged in new code, but in this case it stops over-clever IDEs highlighting the magic accesses as potential visibility errors and sticking big error tags on them. Comment: I've reverted in r90899 what bits of this haven't already been overwritten by later changes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90899]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90899. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90899#c0 Commit summary: Revert r85288 (magic accessors for RequestContext); much more trouble than they're worth. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90901]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r90901. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90901#c0 Commit summary: Follow-up r89408, r86872: restore IContextSource and ContextSource, to be more carefully reimplemented. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90901]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r90901. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90901#c18824 Commit summary: Follow-up r89408, r86872: restore IContextSource and ContextSource, to be more carefully reimplemented. Comment: I think so IMO. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90901]: New comment added
User Reedy posted a comment on MediaWiki.r90901. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90901#c18825 Commit summary: Follow-up r89408, r86872: restore IContextSource and ContextSource, to be more carefully reimplemented. Comment: INameOfInterface is the .NET way of naming interfaces PHP examples seems to do the same, but with lowercase... http://php.net/manual/en/language.oop5.interfaces.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90901]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90901. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90901#c18826 Commit summary: Follow-up r89408, r86872: restore IContextSource and ContextSource, to be more carefully reimplemented. Comment: Whatever we end up with, it should be made a coding convention. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86044]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r86044. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86044#c0 Commit summary: Follow-up r 86041 per CR and IRC: * Article constructor needs to be called with zero as second parameter * Run stylize.php over new files * Add Action::getLang() for consistency with other context accessors * Fix declaration of FormAction::alterForm(), doesn't need to be passed by reference * Fix inline use of Credits::getCredits() in SkinTemplate and SkinLegacy ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90901]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r90901. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90901#c18827 Commit summary: Follow-up r89408, r86872: restore IContextSource and ContextSource, to be more carefully reimplemented. Comment: Generally you can think of interfaces as abstract or incomplete classes (and that's what we do rather than explicit separate interfaces, though we do have some). Our current convention is to simply use clear regular names for base interfaces, same as for both concrete and abstract base classes: * DatabaseType * Field * DBMasterPos * HistoryBlob * LoadMonitor * LCStore * Pager * Preprocessor * PPFrame * PPNode Concrete implementation classes that implement one in some specific way should generally then have a nice clear name that prefixes or suffixes the base interface/class's name, like: * HistoryBlob: ConcatenatedGzipHistoryBlob, DiffHistoryBlob * LoadMonitor: LoadMonitor_Null, LoadMonitor_MySQL * Preprocessor: Preprocessor_Hash, Preprocessor_DOM ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] WMF XML dump title case problem
Emmanuel Engelhart wrote: Hi Titles should be stored in the table page with a first letter uppercased. http://en.wikipedia.org/wiki/Wikipedia:Naming_conventions_%28technical_restrictions%29#Lower_case_first_letter Unfortunately, it seems that we have XML dumps (and consequently mwdumper generated SQL) containing titles with a first letter lowercased. For example: $wget http://download.wikimedia.org/mywiktionary/20110617/mywiktionary-20110617-pages-articles.xml.bz2 $bzip2 -d -c mywiktionary-20110617-pages-articles.xml.bz2 | grep title| grep tationery | more titlestationery/title titlestationery shop/title Is that a bug? No. Those titles are fully case sensitive. Look at the top of the file: casecase-sensitive/case ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90901]: New comment added
User Nikerabbit posted a comment on MediaWiki.r90901. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90901#c18828 Commit summary: Follow-up r89408, r86872: restore IContextSource and ContextSource, to be more carefully reimplemented. Comment: But what if you want both an interface and an abstract class? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85886]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r85886. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85886#c0 Commit summary: No need to quote just to avoid the prefixes. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] should we join the Unicode Constortium?
I'm not sure who would be in charge of this, but I think it would be useful if the WMF was a liaison member of the Unicode Constortium: http://unicode.org/consortium/memblogo.html This body makes all sorts of important decisions about the Unicode standard—decisions that affects many aspects of our projects. If an issue were to come up that adversely affected us, we would not have a formal way to object at the moment. Being a liason member gives us official standing with the organization, allowing us to participate alongside Google, Apple, and Microsoft in any Unicode-related discussions that are important to us. Other open sources projects that are currently liaison members: The GNOME Foundation The Mozilla Project OpenOffice.org I'm not sure if there is any fee for becoming a liaison member. The instructions simply say to contact the Unicode Office for details. Would it be worth contacting them to find out? Ryan Kaldari ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90508]: New comment added
User Platonides posted a comment on MediaWiki.r90508. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90508#c18829 Commit summary: create images with orientation (had to use exiv2 hack, imagemagick not helpful) Comment: You are using an undefined variable. They are usually defined in DefaultSettings.php, although being only used in a test, I'd be comfortable with having it hardcoded in the test or in a class constant, too. Note that even guessing by its name that it should be set in LocalSettings to some arcane invocation of a program called exiv2, there's no information on which is the proper spell. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90866]: New comment added
User Hashar posted a comment on MediaWiki.r90866. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90866#c18830 Commit summary: Tweaked r90766 messages. Still awkward. Also, this still needs JS to disable the check if all is selected, to be less confusing. Comment: : ''Also, this still needs JS to disable the check if all is selected, to be less confusing.'' I have written the javascript for it. Still need to carefully test it before committing. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] should we join the Unicode Constortium?
Ryan Kaldari wrote: I'm not sure who would be in charge of this, but I think it would be useful if the WMF was a liaison member of the Unicode Constortium: http://unicode.org/consortium/memblogo.html This body makes all sorts of important decisions about the Unicode standard—decisions that affects many aspects of our projects. If an issue were to come up that adversely affected us, we would not have a formal way to object at the moment. Being a liason member gives us official standing with the organization, allowing us to participate alongside Google, Apple, and Microsoft in any Unicode-related discussions that are important to us. Other open sources projects that are currently liaison members: The GNOME Foundation The Mozilla Project OpenOffice.org I'm not sure if there is any fee for becoming a liaison member. The instructions simply say to contact the Unicode Office for details. Would it be worth contacting them to find out? Ryan Kaldari Looks appropiate, although I don't really see a potential for problems. This proposal should be sent up to the board. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85884]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r85884. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85884#c18831 Commit summary: Abstract tableName() by adding new function isQuotedIdentifier() to databases. This fixes bug in DatabaseOracle.php tableName() on line 671 and allows it to call the parent implementation instead of copying it with different quotes. Adapt Mssql addIdentifierQuotes(). Replace its addIdentifierQuotes calls with addQuotes as it's what it really is. The serialize() is probably unneeded, since I don't think it will ever be called with objects but I kept it anyway. Comment: Are there still problems with this? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85293]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r85293. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85293#c0 Commit summary: Clean out some globals from SpecialPage.php ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Reproducing localurl by python urllib.quote()
Alex Brollo wrote: I found a number of troubles when trying to replicate localurl: parser function by python urllib.quote(), with a number of annoying bugs. Is this correct-complete? /wiki/+urllib.quote(name-of-page.replace( ,_),/!,;:.-_) where name-of-page is utf-8 encoded. Thanks! I apologyze for so a banal question. Alex brollo The relevant function is Title::getLocalURL() I think that in your quote function you need to skip '@$*(),' as well, and .-_ wouldn't be needed there (but urllib.quote could differ from php urlencode). See wfUrlEncode in GlobalFunctions.php ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] should we join the Unicode Constortium?
On Mon, Jun 27, 2011 at 1:53 PM, Ryan Kaldari rkald...@wikimedia.orgwrote: I'm not sure who would be in charge of this, but I think it would be useful if the WMF was a liaison member of the Unicode Constortium: http://unicode.org/consortium/memblogo.html This body makes all sorts of important decisions about the Unicode standard—decisions that affects many aspects of our projects. If an issue were to come up that adversely affected us, we would not have a formal way to object at the moment. Being a liason member gives us official standing with the organization, allowing us to participate alongside Google, Apple, and Microsoft in any Unicode-related discussions that are important to us. Other open sources projects that are currently liaison members: The GNOME Foundation The Mozilla Project OpenOffice.org I'm not sure if there is any fee for becoming a liaison member. The instructions simply say to contact the Unicode Office for details. Would it be worth contacting them to find out? I think that'd be worth doing; I had a great chat with Michael Everson at our Berlin meetup (Michael's been involved in lots of Unicode standardization stuff over the years and has many tales to tell :) and it definitely sounds like it would be useful for us to be a little more on the inside at times to help push on requirements for specific language support, or making sure that concerns about labeling, character types, and normalization (shudder) get looked at and addressed. In comparison, we have a couple of folks who keep an eye on some of the W3C / WHATWG lists that are working on the HTML 5 specifications -- these are mostly open lists which made it easier for particularly interested individuals like Aryeh Tim to pop on either for specific issues or just as voracious list readers. ;) Unicode's development has traditionally been a little more closed and old-fashioned -- not a horrible thing for something as delicate as the universal character set! -- but it does mean that if we want to be involved, we need to work with the system to make sure that we're heard. I'll see if we can figure out who gets jurisdiction internally on this. :) -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Question regarding reverting a certain own version in SVN; and asking you to update two MW pages with such how-to information
Ashar Voultoiz wrote: On 24/06/11 08:33, Thomas Gries wrote: When I think that a version committed by myself r90650 (marked as new) is fully obsolete and already replaced in my other commit r90684 (marked as fixed) I would say, if it is reverted, mark it reverted :) Or maybe resolved, if it's just rewritten. It's true that no status seems to fit this exact case. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r85301]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r85301. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85301#c0 Commit summary: Update index.php and Wiki.php to make better use of the context. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85298]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r85298. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85298#c0 Commit summary: Remove $this-context-output-setTitle( $this-context-title ); calls from Wiki.php, this are unnecessary, OutputPage no longer keeps track of it's own desynchronized mTitle. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85297]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r85297. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85297#c0 Commit summary: Fix use of mUser noted by c15657 on r85250. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84534]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r84534. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84534#c0 Commit summary: (hopefully) last bit of heavy lifting in Block.php: now that we've internalised most of the variables, untangle their twisted connections to the database layer and remove various now-unused protected methods and variables. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r84660]: New comment added, and revision status changed
User Aaron Schulz changed the status of MediaWiki.r84660. Old Status: new New Status: ok User Aaron Schulz also posted a comment on MediaWiki.r84660. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84660#c18835 Commit summary: (follow-up 79778) Make $wgLang-truncate function consider the length of the ... (ellipsis message) in the truncation length. The length of this message varries by localization, so the previous solution of telling truncate to truncate 5 bytes less than needed is not good since this will be too little or too much. Updated places where its used. Some places I left as is, as it looked like the new behaviour would work fine for them to. (for example, the autosummary feature - it was cutting off at 200 bytes, which is no where near 250 limit, so I presume that was for asethic reasons rather then to fit as much in before the db limit). Will do another commit for extension callers in a moment. Comment: Working on test now. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90911]: New comment added
User Krinkle posted a comment on MediaWiki.r90911. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90911#c18836 Commit summary: Fix get/set accessors from request context stuffs Comment: Changes to context were made in r90899. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] IRC Bug Triage
Tomorrow is the first IRC bug triage (finally!). We'll start the meeting at 2300 UTC (see http://hexm.de/44 for the UTC impaired, like myself). The triage agenda is all set on http://etherpad.wikimedia.org/BugTriage-2011-06. Feel free to make comments, but please do not delete items. Here is the broad overview: * Start with bugs that are affecting Wikipedia users *now* * Followup on bugs discussed in previous triages and get updates on progress * Discuss an outstanding API issue that a tracking bug covers Following that, I'd like to get brief input on bugs that were marked “High” priority going into the 1.18 cycle and have been marked deployment or tarball blockers as a result. Let's discuss if the deployment blockers should really be blocking deployment. Some are older bugs, so we may remain relatively unconcerned about them and decide that they shouldn't block 1.18. Or, maybe we'll find a willing hacker to fix them. So join us in #wikimedia-dev for our first ever IRC Bug Triage. See you there, Mark. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r90742]: New comment added
User Platonides posted a comment on MediaWiki.r90742. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90742#c18838 Commit summary: Directionality and language improvements as part of bug 6100 (under $wgBetterDirectionality): * Make TOC numberings be in the page content language instead of wiki content language. * Update getPageLanguage() and add a hook (for bug 9360/28970). * Show redirects (when viewing a page with redirect=no) in the user language direction (not essential but nicer imo). Comment: The parser shouldn't call mTitle-getPageLanguage(); Use of Parser-getFunctionLang (that you changed in r90858) seems a better option. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90858]: New comment added
User Platonides posted a comment on MediaWiki.r90858. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90858#c18839 Commit summary: Make parser-getFunctionLang be dependent on title-getPageLanguage() instead of $wgContLang, i.e. the page content language instead of the wiki content language. This sets the right language on page view + edit for all pages, instead of only edit preview on MediaWiki namespace pages (as in EditPage.php). Comment: I'm not convinced about this, since that requires a much bigger knowledge at the parser side. Setting the getPageLanguage() to the ParserOptions seems a better alternative IMHO. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90900]: Revision status changed
User Reedy changed the status of MediaWiki.r90900. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90900#c0 Commit summary: adding support for CLDR language lists ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90508]: New comment added
User NeilK posted a comment on MediaWiki.r90508. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90508#c18840 Commit summary: create images with orientation (had to use exiv2 hack, imagemagick not helpful) Comment: Fixed in r90919 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90924]: Revision status changed
User Krinkle changed the status of MediaWiki.r90924. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90924#c0 Commit summary: Followup r90923, best to actually use displayPrefix ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90858]: New comment added
User SPQRobin posted a comment on MediaWiki.r90858. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90858#c18841 Commit summary: Make parser-getFunctionLang be dependent on title-getPageLanguage() instead of $wgContLang, i.e. the page content language instead of the wiki content language. This sets the right language on page view + edit for all pages, instead of only edit preview on MediaWiki namespace pages (as in EditPage.php). Comment: It's a temporary fix/improvement, because as I said in an earlier commit, there should probably be a better way but I don't know enough about MediaWiki core (and certainly not the parser) to find the best way. See also [[bugzilla:6100#c49]]. Move the code from getPageLanguage to getFunctionLang? Move getPageLanguage to OutputPage? Something else? It should at least be easy to define the page content language in extensions. Also, what do you mean with that requires a much bigger knowledge at the parser side? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
