[MediaWiki-CodeReview] [MediaWiki r91496]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91496. Old Status: fixme New Status: new Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/91496#c0 Commit summary: DumpHTML fixes: * Made SkinOffline use getTitle() instead of non-existing mTitle * Made getArticleHTML() use RequestContext (follow-up r85250) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91506]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91506. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91506#c0 Commit summary: code readability is everything ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90585]: New comment added
User Freakolowsky posted a comment on MediaWiki.r90585. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90585#c19241 Commit summary: * removed DEFAULT '' NOT NULL constraints as '' is internaly converted to NULL in Oracle and throws an error * fixed tableName handling doSchemaUpgrade17 (must be careful to avoid multiple tableName calls as names don't get taged in DDL mode) * exit/reenter DDL mode on updatelog inserts Comment: I tried finding a workaround for this one but this is too deep inside oracle. The only way this could work is by converting fields to static character fields, but that has a pile of problems on it's own. Well ... we shall see ... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88134]: New comment added
User Nikerabbit posted a comment on MediaWiki.r88134. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88134#c19242 Commit summary: Fixed a bug in transformation where previous language could leak into later transformations in UI language. Not sure what do with userlang. Comment: You mean dropping wfSerVar and doing it manually? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91449]: New comment added
User Nikerabbit posted a comment on MediaWiki.r91449. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91449#c19243 Commit summary: rewritten code related to encoding/storage/retrieval of containers using internal objects; internal objects now represented by DIWikiPages, no more special cases for blank nodes; extended dictionary table for SMWIDs accordingly; updated read and write methods to use the new encoding Comment: taught you :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91031]: New comment added
User Tim Starling posted a comment on MediaWiki.r91031. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91031#c19244 Commit summary: (bug 29277) MediaWiki:Filepage.css not loaded on foreignwiki itself. Fixup to r68904. Yay Roan finally taught me how to use the resourceloader :D Comment: The impact on non-Wikimedia websites seems a bit too small to bother backporting it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r88134]: New comment added
User Tim Starling posted a comment on MediaWiki.r88134.
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88134#c19245
Commit summary:
Fixed a bug in transformation where previous language could leak into later
transformations in UI language. Not sure what do with userlang.
Comment:
That would work too, but I was thinking more like
pre
function wfSetAndReturnOld( $ref, $newValue ) {
$old = $ref;
$ref = $newValue;
return $old;
}
/pre
Then use that everywhere except in the combined accessor/mutator functions that
wfSetVar() was intended for.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91528]: New comment added
User Nikerabbit posted a comment on MediaWiki.r91528. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91528#c19246 Commit summary: Make the reply count in the URL (reply_(X)) use $wgContLang-formatNum(), so it uses e.g. Persian numbers when the content language is Persian. Reported by user Ebraminio on Translatewiki.net. Comment: Will existing discussions keep working? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91528]: New comment added
User Werdna posted a comment on MediaWiki.r91528. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91528#c19247 Commit summary: Make the reply count in the URL (reply_(X)) use $wgContLang-formatNum(), so it uses e.g. Persian numbers when the content language is Persian. Reported by user Ebraminio on Translatewiki.net. Comment: Yes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91528]: New comment added
User SPQRobin posted a comment on MediaWiki.r91528. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91528#c19248 Commit summary: Make the reply count in the URL (reply_(X)) use $wgContLang-formatNum(), so it uses e.g. Persian numbers when the content language is Persian. Reported by user Ebraminio on Translatewiki.net. Comment: It starts counting again, so reply, reply (2), reply (3), then reply, reply (٢), but everything still works. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Printing
Quick one for the tech folks: is there a known issue with printing at the moment? OTRS keeps getting comments that printing gets cut off after one page... I searched bugzilla to no avail and am 99% certain this is a local computer issue each time, but I wanted to check no one was aware of an issue ;) Tom ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r86047]: New comment added
User DieBuche posted a comment on MediaWiki.r86047. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c19249 Commit summary: History: Adding JS that converts buttons to links for better UX. Patch based on one by Matthew Flaschen. Fixes Bug 16165 Comment: Reverted until we have uniform buttons sitewide. In atleast Chrome Safari it's possible to command (on a mac, no idea which key on win) click a button to open in a new tab. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86056]: New comment added, and revision status changed
User DieBuche changed the status of MediaWiki.r86056. Old Status: fixme New Status: new User DieBuche also posted a comment on MediaWiki.r86056. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86056#c19250 Commit summary: Followup to r86047: Rewrite the radio-button updater move everything to action.history. Also move to fixCompare version by Helder, since HTMLdiff is scrapped Comment: Respective part is reverted in r91547 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86305]: New comment added, and revision status changed
User DieBuche changed the status of MediaWiki.r86305. Old Status: fixme New Status: new User DieBuche also posted a comment on MediaWiki.r86305. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86305#c19251 Commit summary: Followup r86088 per CR: Move month array builder into language; use mw.config.get(); Fix rowspans and some cleanup Comment: Remarking as new; known regressions are fixed, rowspans got some tests. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86108]: New comment added, and revision status changed
User DieBuche changed the status of MediaWiki.r86108. Old Status: fixme New Status: new User DieBuche also posted a comment on MediaWiki.r86108. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86108#c19252 Commit summary: Followup ro r86088: Use data-sort-type instead of classes to specify the parser-type; add support for data-sort-value; strip legacy code (CR) Comment: Remarking as new ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91549]: New comment added
User ^demon posted a comment on MediaWiki.r91549. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91549#c19253 Commit summary: CodeReview: Resolved is effectively the same as (or very similar to) OK; but the green background makes it standout unnecessarily. Coloring the same as ok Comment: Um, it's supposed to stand out. Please revert. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91490]: Revision status changed
User ^demon changed the status of MediaWiki.r91490. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91490#c0 Commit summary: Moved 'MW_HTML_FOR_DUMP' check before config vars (localsettings may try to access them) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91500]: New comment added, and revision status changed
User DieBuche changed the status of MediaWiki.r91500. Old Status: new New Status: ok User DieBuche also posted a comment on MediaWiki.r91500. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91500#c19254 Commit summary: mw.util.wikiGetlink default to wgPageName * (bug 29723) mw.util.wikiGetlink() should default to wgPageName * Solution by mybugs.mail * Adding unit tests Comment: Logically it's the same. You save a few bytes and one assignment. The second one is useful if you use str multiple times ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87271]: New comment added
User DieBuche posted a comment on MediaWiki.r87271. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87271#c19255 Commit summary: AFT Fixes * Linking page titles in the Dashboard at Special:ArticleFeedback * (bug 28125) Don't load the ext.articleFeedback module, nor initialize it on inexisting pages * Comment: L224: After reformatting -2 became a 2. On purpose? Otherwise it looks fine. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87048]: Revision status changed
User DieBuche changed the status of MediaWiki.r87048. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87048#c0 Commit summary: Using new jquery.json module in ext.UserBuckets module ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87046]: Revision status changed
User DieBuche changed the status of MediaWiki.r87046.
Old Status: new
New Status: ok
Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87046#c0
Commit summary:
AFT/ClickTracking JsPerf + JsLint fixes:
* Combining (function($){}(jQuery); and $(document).ready (check
[[Conventions]] for details)
* Cache $(this) instead of re-initializing the same object multiple times.
* Don't use .each() for plugings that do this already internally. (ie.
.remove(), .css() etc.)
* Make use of jQuery chaining where possible
($(...).foo().bar().more().calls(); etc.);
* Delete $.json_encode, using jquery.json module instead
* Use dot.notation instead array['brackets'] whenever possible.
* Using Array literal instead of Object constructor (var = []; / var = new
Array();)
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86047]: Revision status changed
User DieBuche changed the status of MediaWiki.r86047. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86047#c0 Commit summary: History: Adding JS that converts buttons to links for better UX. Patch based on one by Matthew Flaschen. Fixes Bug 16165 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91549]: New comment added
User DieBuche posted a comment on MediaWiki.r91549. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91549#c19256 Commit summary: CodeReview: Resolved is effectively the same as (or very similar to) OK; but the green background makes it standout unnecessarily. Coloring the same as ok Comment: Why? Both OK and Resolved are revisions that don't need additional care. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91549]: New comment added
User ^demon posted a comment on MediaWiki.r91549. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91549#c19257 Commit summary: CodeReview: Resolved is effectively the same as (or very similar to) OK; but the green background makes it standout unnecessarily. Coloring the same as ok Comment: They may not need additional care, but they're different states. Now that I [[Special:Code/MediaWiki/status|look]], we should probably put a different color for deferred/old as well. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82783]: New comment added
User ^demon posted a comment on MediaWiki.r82783. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82783#c19258 Commit summary: * (bug 24230) Added JAR detection. ZIP archives containing a .class file will be rejected by default. Malformed ZIP archives will be rejected due to the danger of ambiguous parsing on the client side. * Removed the ZIP subtypes from $wgMimeTypeBlacklist, they no longer need to be there. * Added ZipDirectoryReader. Added some small ZIP files which are used to test its various error cases. Most were constructed with a hex editor. * Fixed getStatusArray() to return a consistent type regardless of whether the error message has parameters. This allows error messages with no parameters to work with the Status object conversion code in UploadBase::verifyFile(). Comment: Is there a reason you didn't make ZipDirectoryReaderError extend MWException and Exception instead? From the looks of it the idea was to make it reusable like some of our code in /includes/libs/. The only thing I see preventing that is the use of Status objects and the one wfDebug() call. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82783]: New comment added
User ^demon posted a comment on MediaWiki.r82783. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82783#c19259 Commit summary: * (bug 24230) Added JAR detection. ZIP archives containing a .class file will be rejected by default. Malformed ZIP archives will be rejected due to the danger of ambiguous parsing on the client side. * Removed the ZIP subtypes from $wgMimeTypeBlacklist, they no longer need to be there. * Added ZipDirectoryReader. Added some small ZIP files which are used to test its various error cases. Most were constructed with a hex editor. * Fixed getStatusArray() to return a consistent type regardless of whether the error message has parameters. This allows error messages with no parameters to work with the Status object conversion code in UploadBase::verifyFile(). Comment: Wow that first sentence makes little sense. I meant: why make ZipDirectoryReaderError extend Exception over MWException? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91426]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r91426. Old Status: new New Status: fixme User ^demon also posted a comment on MediaWiki.r91426. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91426#c19260 Commit summary: fixing rounding problem, per comment at r82309 Comment: Still not right. I'm still getting [[User:^demon/gallery failure r91426|a parser test failure]] as of HEAD. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91426]: New comment added
User ^demon posted a comment on MediaWiki.r91426. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91426#c19261 Commit summary: fixing rounding problem, per comment at r82309 Comment: Stupid CR parsing. Use [[User:^demon/gallery failure 91426|this link]] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91543]: Revision status changed
User ^demon changed the status of MediaWiki.r91543. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91543#c0 Commit summary: lseek and read failures return -1 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91549]: New comment added
User DieBuche posted a comment on MediaWiki.r91549. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91549#c19262 Commit summary: CodeReview: Resolved is effectively the same as (or very similar to) OK; but the green background makes it standout unnecessarily. Coloring the same as ok Comment: In a lot of color coding green is good, red is bad and hues between (orange/yellow) are in the middle. A similar system is used here. Fixme is obviously not good, thus red. New is neither, thus yellow. Ok is good, why isn't it green? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91435]: New comment added, and revision status changed
User Bawolff changed the status of MediaWiki.r91435. Old Status: new New Status: fixme User Bawolff also posted a comment on MediaWiki.r91435. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91435#c19263 Commit summary: * Added getFileVersion()/setFileVersion() functions to OutputPage * Removed getDisplayedFile() from FlaggedPage and simplified getFile() * Cleaned up getIncludeParams() to just do formatting * Made template/file IDs mandatory for RevisionReviewFormUI Comment: Viewing a non-existant file: br / bNotice/b: Undefined variable: val in b/var/www/w/phase3/includes/OutputPage.php/b on line b1313/bbr / ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91556]: Revision status changed
User ^demon changed the status of MediaWiki.r91556. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91556#c0 Commit summary: Codereview: Fix grammar of one i18n string ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91549]: New comment added
User ^demon posted a comment on MediaWiki.r91549. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91549#c19264 Commit summary: CodeReview: Resolved is effectively the same as (or very similar to) OK; but the green background makes it standout unnecessarily. Coloring the same as ok Comment: Because we wanted different colors for different statuses, having ok/resolved as the same color is a bad idea. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91491]: Revision status changed
User ^demon changed the status of MediaWiki.r91491. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91491#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-07-05 21:00:00 UTC) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91430]: Revision status changed
User ^demon changed the status of MediaWiki.r91430. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91430#c0 Commit summary: using proper margin heights: 14 + 68 * 2 = 150 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91426]: Revision status changed
User ^demon changed the status of MediaWiki.r91426. Old Status: fixme New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91426#c0 Commit summary: fixing rounding problem, per comment at r82309 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91419]: Revision status changed
User ^demon changed the status of MediaWiki.r91419. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91419#c0 Commit summary: tests for Html::testExpandAttributes() FIXME: seems a code duplication of Xml::expandAttributes() follow up r81571 (skip attributes with null value) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91270]: New comment added
User ^demon posted a comment on MediaWiki.r91270. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91270#c19265 Commit summary: Merge ApiTestSetup into ApiTestCase and update all subclasses. The amount of duplication here was nasty, and also lets us get rid of a bunch of useless require_once()s. ./phpunit.php --filter Api currently gives me: Tests: 24, Assertions: 107, Incomplete: 1, Skipped: 2. Comment: [https://bugs.php.net/bug.php?id=42472 Related] ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91561]: New comment added
User Bawolff posted a comment on MediaWiki.r91561. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91561#c19266 Commit summary: (Bug 19725) Do not include suppressed edits in the View X deleted edits message, and when doing prefix search of special:undelete. I'm not 100% sure this is the right thing to do, see the bug for the details. But basically this doesn't include an edit in the count if its text is hidden and its hidden from admins. (Not sure if it should not be included only if everything is hidden). Its also weird to show people different things depending if they have suppress rights, without really indicating that. Minor db note: This causes the query to no longer use a covering index. I don't think that matters but just thought i'd mention. p.s. The upload page show deleted edits link is broken right now, (from before) I'll fix in a follow-up. Comment: adding tag 1.18 since relevant bug was a 1.18 blocker. (My personal opinion is its not really that important of a bug, and don't overly care either way if it gets backported) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91565]: Revision status changed
User Reedy changed the status of MediaWiki.r91565. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91565#c0 Commit summary: public static ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91435]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91435. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91435#c0 Commit summary: * Added getFileVersion()/setFileVersion() functions to OutputPage * Removed getDisplayedFile() from FlaggedPage and simplified getFile() * Cleaned up getIncludeParams() to just do formatting * Made template/file IDs mandatory for RevisionReviewFormUI ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91558]: Revision status changed
User Aaron Schulz changed the status of MediaWiki.r91558. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91558#c0 Commit summary: Removed usage of error suppression operator ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86056]: Revision status changed
User Krinkle changed the status of MediaWiki.r86056. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86056#c0 Commit summary: Followup to r86047: Rewrite the radio-button updater move everything to action.history. Also move to fixCompare version by Helder, since HTMLdiff is scrapped ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91547]: Revision status changed
User Krinkle changed the status of MediaWiki.r91547. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91547#c0 Commit summary: Revert r86047 for now per CR. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r87271]: New comment added
User Krinkle posted a comment on MediaWiki.r87271. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87271#c19267 Commit summary: AFT Fixes * Linking page titles in the Dashboard at Special:ArticleFeedback * (bug 28125) Don't load the ext.articleFeedback module, nor initialize it on inexisting pages * Comment: They were dummy values since the database didn't exist yet at this point in development. I choose different dummy values per experimentation. That part of the commit is redundant tho as those functions no longer exist. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91537]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r91537. Old Status: new New Status: fixme User Raymond also posted a comment on MediaWiki.r91537. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91537#c19268 Commit summary: v0.8.0a It is possible to interpretate poll results and store user ratings / marks - as educational tool or as psychological tests. Step towards HMVC separation. Still is not fully tested and requires some polishing. Do not use in the production. Comment: It looks like you have copied the files only. SVN history is lost now. You have to use svn move instead. Please revert this revision and commit again. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r246]: Revision status changed
User Awjrichards changed the status of Wikimedia.r246. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/246#c0 Commit summary: Stops logging the payflopro username and password (and the unit tests reflect this) and stops trying to reference a protected variable in the stomp library. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91499]: New comment added
User Krinkle posted a comment on MediaWiki.r91499. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91499#c19269 Commit summary: another fix for old jQuery UI on live Comment: Change (not to self): ''1'': * Prepends selectors: code.ui-button-text-icon-primary .ui-button-icon-primary/code * Change left from 0.5em to 0 ''2'': * Prepends selectors: code.ui-button-text-icon-secondary .ui-button-icon-secondary, .ui-button-text-icon .ui-button-icon-secondary/code * Change right from 0.5em to 16px ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91499]: New comment added
User Krinkle posted a comment on MediaWiki.r91499. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91499#c19270 Commit summary: another fix for old jQuery UI on live Comment: Changed (note to self): ''1'': * Prepends selectors: code.ui-button-text-icon-primary .ui-button-icon-primary/code * Change left from 0.5em to 0 ''2'': * Prepends selectors: code.ui-button-text-icon-secondary .ui-button-icon-secondary, .ui-button-text-icon .ui-button-icon-secondary/code * Change right from 0.5em to 16px ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91444]: Revision status changed
User Krinkle changed the status of MediaWiki.r91444. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91444#c0 Commit summary: follow-up r91439: Change option parse to parsemag (MediaWiki option in this context) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91507]: Revision status changed
User ^demon changed the status of MediaWiki.r91507. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91507#c0 Commit summary: Added file wrapper class (tested) and R work for overworked ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91578]: Revision status changed
User ^demon changed the status of MediaWiki.r91578. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91578#c0 Commit summary: fixing parser test per r91573 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91579]: Revision status changed
User ^demon changed the status of MediaWiki.r91579. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91579#c0 Commit summary: Removed unused function param ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91106]: New comment added
User ^demon posted a comment on MediaWiki.r91106. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91106#c19272 Commit summary: Add wfUnserialize() wrapper around unserialize to prevent E_NOTICE and use it in ExifBitmap.php. There are probably many more places that could use this. This should fix Platonides' problem at r90421, but also added a check for $wgShowExif to prevent the test from failing. Comment: This rev shouldn't be necessary anymore with that, right? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91378]: Revision status changed
User ^demon changed the status of MediaWiki.r91378. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91378#c0 Commit summary: enhance tests name (for --testdox option) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91071]: Revision status changed
User ^demon changed the status of MediaWiki.r91071. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91071#c0 Commit summary: Make BitmapMetadataHandlerTest incomplete if $wgShowEXIF is not set. It was throwing 'MWException: Internal error: exif_read_data not present. $wgShowEXIF may be incorrectly set or not checked by an extension.' Fixed typo in LocalSettings. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90016]: Revision status changed
User ^demon changed the status of MediaWiki.r90016. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90016#c0 Commit summary: Start on test cases for bug 6672 (Exif orientation support), follow up to r79845. Unfortunately seem to be hitting a wall right off at checking width height; BitmapHandler reports back the pre-rotation width height, leading to the oddity that a file that's clearly 1024px tall and 768px wide reports itself as 1024px wide and 768px tall. Haven't gotten to generating rotated output to confirm file size. :) Marked test case as broken pending fix so it doesn't add to surprise regressions in test reports. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90194]: Revision status changed
User ^demon changed the status of MediaWiki.r90194. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90194#c0 Commit summary: Fixes for r90105, r90193: * Actually removed $wgProto. * Per Aryeh's suggestions on the future of $wgServer: made $wgServer detection in DefaultSettings.php more permanent by merging it with the new code from r90105. This means that bug 14977 is properly fixed now. * Require entry points to set up the autoloader before including DefaultSettings.php. Comments on bug 14977 indicate that at some point in the past, this may have broken something. Anything that breaks now should just be fixed, we need the autoloader. Tested the most common entry points. * Since the detection code has moved from Installer to WebRequest, I also moved the relevant test file and updated the test. The function under test is now public static, so r90154 is superseded. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91106]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r91106. Old Status: new New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r91106. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91106#c19274 Commit summary: Add wfUnserialize() wrapper around unserialize to prevent E_NOTICE and use it in ExifBitmap.php. There are probably many more places that could use this. This should fix Platonides' problem at r90421, but also added a check for $wgShowExif to prevent the test from failing. Comment: I took out wfUnserialize() and the call to it in r91581. The tweak to disable the exif tests when required libraries are unavailable is kept. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91512]: Revision status changed
User ^demon changed the status of MediaWiki.r91512. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91512#c0 Commit summary: + _readme.txt ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91348]: Revision status changed
User ^demon changed the status of MediaWiki.r91348. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91348#c0 Commit summary: Removed some dead code (useless since r87806) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r90741]: Revision status changed
User ^demon changed the status of MediaWiki.r90741. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90741#c0 Commit summary: Fixed silly test bug ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91537]: New comment added
User QuestPC posted a comment on MediaWiki.r91537. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91537#c19276 Commit summary: v0.8.0a It is possible to interpretate poll results and store user ratings / marks - as educational tool or as psychological tests. Step towards HMVC separation. Still is not fully tested and requires some polishing. Do not use in the production. Comment: Recommitted with svn move in r91587. I hope it fits, probably cannot do better. It is after major refactoring so the diffs will be large anyway. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91584]: New comment added
User Aaron Schulz posted a comment on MediaWiki.r91584. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91584#c19277 Commit summary: * Call viewRedirect() on Article (WikiPage doesn't inherit this anymore) * Fixed bug 29734 - categories on redirect pages don't appear on stable version * Fixed globalArticleInstance() to account for RequestContext stuff which broke it (it was loading the pre-redirected title) * Renamed $parserOptions vars for briefity Comment: Tagged for porting to 1.18. Note that the change to account for WikiPage doesn't effect 1.18. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91537]: New comment added
User QuestPC posted a comment on MediaWiki.r91537. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91537#c19278 Commit summary: v0.8.0a It is possible to interpretate poll results and store user ratings / marks - as educational tool or as psychological tests. Step towards HMVC separation. Still is not fully tested and requires some polishing. Do not use in the production. Comment: Looking for online diff of i18n file now produces 400 bad request on me: http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/QPoll/i18n/qp.i18n.php?pathrev=91587r1=91586r2=91587 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91537]: New comment added, and revision status changed
User Raymond changed the status of MediaWiki.r91537. Old Status: fixme New Status: ok User Raymond also posted a comment on MediaWiki.r91537. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91537#c19280 Commit summary: v0.8.0a It is possible to interpretate poll results and store user ratings / marks - as educational tool or as psychological tests. Step towards HMVC separation. Still is not fully tested and requires some polishing. Do not use in the production. Comment: Dunno why but http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/QPoll/i18n/qp.i18n.php?view=logr1=91587pathrev=91587 looks good. Thanks a lot. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91439]: New comment added, and revision status changed
User Krinkle changed the status of MediaWiki.r91439. Old Status: deferred New Status: fixme User Krinkle also posted a comment on MediaWiki.r91439. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91439#c19281 Commit summary: Add PLURAL-support Comment: The Language.php is mangled with messed up characters. I suspect you might have copied it from /viewvc/ and/or in a text editor with the wrong encoding set (not UTF-8). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91439]: Revision status changed
User Krinkle changed the status of MediaWiki.r91439. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91439#c0 Commit summary: Add PLURAL-support ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91106]: New comment added
User Bawolff posted a comment on MediaWiki.r91106. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91106#c19282 Commit summary: Add wfUnserialize() wrapper around unserialize to prevent E_NOTICE and use it in ExifBitmap.php. There are probably many more places that could use this. This should fix Platonides' problem at r90421, but also added a check for $wgShowExif to prevent the test from failing. Comment: Most other calls to unserialize are wrapped in wfSuppressErrors anyways. If bad data ever got into the db (which should not happen), it would generate an E_NOTICE. I'd prefer to leave the error suppression in, but don't have strong opinions. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91106]: New comment added
User Bawolff posted a comment on MediaWiki.r91106. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91106#c19283 Commit summary: Add wfUnserialize() wrapper around unserialize to prevent E_NOTICE and use it in ExifBitmap.php. There are probably many more places that could use this. This should fix Platonides' problem at r90421, but also added a check for $wgShowExif to prevent the test from failing. Comment: Or actually we do a validity check before the unserialize that would catch that, so I guess there's no way for there to be an E_NOTICE at this point, so nevermind what i just said :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91589]: Revision status changed
User ^demon changed the status of MediaWiki.r91589. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91589#c0 Commit summary: Minor fixes and follow-up to r91439 (Integration of PLURAL / MediaWiki language classes) * Names.php - Deleting now-redundant copy Names.php - Using languages/classes/Names.php instead - new demo7 to test/demonstrate language names * Language.php - Re-fork Languages.php (it was probably copied from wikimedia-svn/viewvc, many mangling/encoding issues) - new demo8 for MessagesFunctions * Minor fixes - line break in LICENSE.txt intro - Starting function documentation with 1-word type then the description (@foo type Description; @return object Instance of MessagesFunction) - Renaming /classes/ to /mw-classes/ to emphasize the fork - Moved getFallbacks.php to /scripts/ (Follow-up r90764) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91106]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r91106. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91106#c19284 Commit summary: Add wfUnserialize() wrapper around unserialize to prevent E_NOTICE and use it in ExifBitmap.php. There are probably many more places that could use this. This should fix Platonides' problem at r90421, but also added a check for $wgShowExif to prevent the test from failing. Comment: In this particular case we don't need generic validation/error handling for our expected cases, since there's a particular symbolic value we're looking for that indicates we shouldn't try to unserialize. :) But some others check to see if the item could be unserialized and then have some error-handling code (skip this item, recalculate, whatever). This might feel clearer with a wfUnserialize() wrapper that suppresses the notice on failure '''but throws an exception''' -- which can be caught by callers that need error recovery, or left to kill the process log the exception for cases that weren't expecting it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r198]: New comment added, and revision status changed
User Awjrichards changed the status of Wikimedia.r198. Old Status: fixme New Status: resolved User Awjrichards also posted a comment on Wikimedia.r198. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/198#c19286 Commit summary: Fixing my unit test, adding a config.ini-dist, and fixing the thing it was testing as well. Story 149 in the 2011 fundraiser. Comment: All looks fixed in r254, marking resolved ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r204]: New comment added, and revision status changed
User Awjrichards changed the status of Wikimedia.r204. Old Status: fixme New Status: resolved User Awjrichards also posted a comment on Wikimedia.r204. Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/204#c19287 Commit summary: Actually started communicating with pfp's test system. Pulled out a bunch of reusable stuff and stashed it in the ActiveMQStompTest.class file (in fundraising-misc/test_resources/phpUnit_Classes), added comments, general cleanup. Comment: Ok - marking resolved. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r85918]: Revision status changed
User ^demon changed the status of MediaWiki.r85918. Old Status: fixme New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85918#c0 Commit summary: Improvements to handling of 'catastrophic' errors, like unsupported PHP versions, no MySQL functions, no LocalSettings, etc. * Fix parsing of the three major entry points (index.php, api.php, load.php) back to PHP 4.4.9. We don't care what happens if you actually try to run these files on old versions, but the entry files need to parse correctly. * consign /includes/templates/PHP4.php and /includes/templates/NoLocalSettings.php to the fiery pit of hell where they belong. * Prevent loading of any other files for PHP 5. WebStart.php was rendered unparseable in PHP 4 by the introduction of try/catch blocks in r85327. * Die outright with a pretty error message on PHP 5.2.3 as well as PHP 4. All versions of PHP below that throw parse errors of various sorts. * Reimplement wfDie() to provide an entry-point-dependent die-with-readable-error-message function (for instance, we want a pretty human-readable page in index.php, something wrapped in CSS/JS /*...*/ comment block in load.php, etc). * Standardise the appearance of the catastrophic errors thrown at the top of the stack with the ones lower down (exception-within-exception, etc). There isn't really a way to do this without duplication, AFAICT. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91466]: New comment added, and revision status changed
User NeilK changed the status of MediaWiki.r91466. Old Status: new New Status: ok User NeilK also posted a comment on MediaWiki.r91466. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91466#c19288 Commit summary: adjusting width of ArticleFeedback-tooltip container. - Previously much wider than the actual 5-star-rating-container, which was done as a middle way to have tooltips on one line, but due to the last rating-box not having any space to the right this in-between solution looked inconsistent. However when making it as wide as the 5-star-rating-container (11em) some tooltips will wrap three lines: http://i.imgur.com/HHbGW.png For now made the width equal to that 11em + 1em = 12em where 1em is the margin between the boxes so it's still wider and won't cause tooltips to span 3 lines, and still not underneath other rating boxes either. This solution is better than what it was but not ideal and especially when i18n comes in, it's simply unacceptable. This will probably be a moot point when the widget is redesigned to take all the recent modifications into account. Comment: seems like a dubious solution (enclosing items of fixed pixel width with ems?) but Krinkle is aware of the issue so marking it okay for deploy ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] ResourceLoader JavaScript validation on trunk (bug 28626)
Some of you may have found that ResourceLoader's bundled minified JavaScript loads can be a bit frustrating when syntax errors creep into your JavaScript code -- not only are the line numbers reported in your browser of limited help, but a broken file can cause *all* JS modules loaded in the same request to fail[1]. This can manifest as for instance a jquery-using Gadget breaking the initial load of jquery itself because it gets bundled together into the same request. I've taken a copy of JSMin+ (MPL 1.1/GPL 2.0/LGPL 2.1 triple-license) to our includes/libs -- it's a JS minification library that had originally gotten knocked out of the running for merging due to being a bit slow, but has the advantage of coming with an actual JavaScript parser [2]. Only the parser is being used right now, in two places: - on the JavaScriptMinifier test cases to confirm that results are valid JS (should be extended to a fuzz tester, probably) - on each individual file loaded via ResourceLoaderFileModule or ResourceLoaderWikiModule, so we can throw a JavaScript exception with details of the parse error *with line numbers for the original input file* This can be disabled by turning off $wgResourceLoaderValidateJs, but I'm setting it on by default to aid testing. I'd like for folks to keep an eye out to make sure they don't get any false positive parse errors in real-world modules, and to see if there are any noticeable performance regressions. Like ResourceLoader's minification itself the validation parses are cached so shouldn't cause too much ongoing load, but it still takes some time. [1] https://bugzilla.wikimedia.org/show_bug.cgi?id=28626 [2] http://crisp.tweakblogs.net/blog/1856/jsmin+-version-13.html -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] ResourceLoader JavaScript validation on trunk (bug 28626)
How is JSMin+ different to the plain JSMin that we had and was removed due to licensing conflicts? (See: http://lists.wikimedia.org/pipermail/wikitech-l/2011-January/051308.html https://bugzilla.wikimedia.org/show_bug.cgi?id=26791) ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91606]: Revision status changed
User Nikerabbit changed the status of MediaWiki.r91606. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91606#c0 Commit summary: Fix trailing whitespace ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91608]: New comment added
User Nikerabbit posted a comment on MediaWiki.r91608. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91608#c19289 Commit summary: * (bug 28626) Validate JavaScript files and pages loaded via ResourceLoader before minification, protecting separate modules from interference This is possibly not perfect but seems to serve for a start; follows up on r91591 that adds JSMin+ to use it in some unit tests. May want to adjust some related bits. - $wgResourceLoaderValidateJs on by default (can be disabled) - when loading a JS file through ResourceLoaderFileModule or ResourceLoaderWikiModule, parse it using JSMinPlus's JSParser class. If the parser throws an exception, the JS code of the offending file will be replaced by a JS exception throw listing the file or page name, line number (in original form), and description of the error from the parser. - parsing results are cached based on md5 of content to avoid re-parsing identical text - for JS pages loaded via direct load.php request, the parse error is thrown and visible in the JS console/error log Issues: - the primary use case for this is when a single load.php request implements multiple modules via mw.loader.implement() -- the loader catches the exception and skips on to the next module (good) but doesn't re-throw the exception for the JS console. It does log to console if present, but it'll only show up as a regular debug message, not an error. This can suppress visibility of errors in a module that's loaded together with other modules (such as a gadget). - have not done performance testing on the JSParser - have not done thorough unit testing with the JSParser Comment: No non-js logging yet? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91613]: Revision status changed
User ^demon changed the status of MediaWiki.r91613. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91613#c0 Commit summary: Adding directory and work for vandal_conversion ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91598]: Revision status changed
User ^demon changed the status of MediaWiki.r91598. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91598#c0 Commit summary: * Removed isPatrollable(); unused * Fixed comment ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91557]: Revision status changed
User ^demon changed the status of MediaWiki.r91557. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91557#c0 Commit summary: Revert r91426 and followups r91427, r91430: Breaks Gallery-related parser tests ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r259]: Revision status changed
User Awjrichards changed the status of Wikimedia.r259. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/259#c0 Commit summary: Command-line wrapper should exit with an error if the processor execute returns false. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] ResourceLoader JavaScript validation on trunk (bug 28626)
On Wed, Jul 6, 2011 at 3:18 PM, K. Peachey p858sn...@gmail.com wrote: How is JSMin+ different to the plain JSMin that we had and was removed due to licensing conflicts? It's a different program, written by different people, based on code from another unrelated project, under a different license. Open Source is a wonderful thing; we use it every day and in this case it would be a waste if we were the only one to benefit from the hard work of others. We dubbed our little project JSMin+ because essentially it acts as Douglas Crockford's JSMin but is far less restrictive, and released it under the same MPL/GPL/LGPL tri-license as the original Narcissus code. http://crisp.tweakblogs.net/blog/1665/a-new-javascript-minifier-jsmin+.html -- brion ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r91608]: New comment added
User Brion VIBBER posted a comment on MediaWiki.r91608. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91608#c19290 Commit summary: * (bug 28626) Validate JavaScript files and pages loaded via ResourceLoader before minification, protecting separate modules from interference This is possibly not perfect but seems to serve for a start; follows up on r91591 that adds JSMin+ to use it in some unit tests. May want to adjust some related bits. - $wgResourceLoaderValidateJs on by default (can be disabled) - when loading a JS file through ResourceLoaderFileModule or ResourceLoaderWikiModule, parse it using JSMinPlus's JSParser class. If the parser throws an exception, the JS code of the offending file will be replaced by a JS exception throw listing the file or page name, line number (in original form), and description of the error from the parser. - parsing results are cached based on md5 of content to avoid re-parsing identical text - for JS pages loaded via direct load.php request, the parse error is thrown and visible in the JS console/error log Issues: - the primary use case for this is when a single load.php request implements multiple modules via mw.loader.implement() -- the loader catches the exception and skips on to the next module (good) but doesn't re-throw the exception for the JS console. It does log to console if present, but it'll only show up as a regular debug message, not an error. This can suppress visibility of errors in a module that's loaded together with other modules (such as a gadget). - have not done performance testing on the JSParser - have not done thorough unit testing with the JSParser Comment: There could perhaps be some benefit to logging if we're attempting to detect bad .js files creeping into source. For user JS it's probably unnecessary noise to record that. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91617]: New comment added
User Kaldari posted a comment on MediaWiki.r91617. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91617#c19291 Commit summary: moving DB function into DB class and giving functions more logical names Comment: This rev also added banner assignment and weight logging to the campaign logging system. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91619]: Revision status changed
User Krinkle changed the status of MediaWiki.r91619. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91619#c0 Commit summary: (bug 23086) AbuseFilter config diff date and time should use user preference instead of UTC ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91516]: Revision status changed
User ^demon changed the status of MediaWiki.r91516. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91516#c0 Commit summary: Don't use an example query that gives a warning ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91615]: Revision status changed
User ^demon changed the status of MediaWiki.r91615. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91615#c0 Commit summary: * (bug 29481) Add German namespace names to LQT ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91588]: Revision status changed
User Reedy changed the status of MediaWiki.r91588. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91588#c0 Commit summary: Removed stray ; ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91597]: New comment added, and revision status changed
User ^demon changed the status of MediaWiki.r91597. Old Status: new New Status: fixme User ^demon also posted a comment on MediaWiki.r91597. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91597#c19292 Commit summary: Added sourcetracking sql file Comment: * We don't typically denote our table/column names with backticks, just use the bare name * Please put tt/*_*//tt in front of 'sourcetracking' so it respects $wgDBprefix * Rather than using PRIMARY KEY(trackingid), do this: tttrackingid int(11) NOT NULL AUTO_INCREMENT PRIMARY KEY/tt. This way you can support Sqlite * Don't hardcode Engine=InnoDB and the charset, replace them with tt/*$wgDBTableOptions*//tt ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] ResourceLoader JavaScript validation on trunk (bug 28626)
On 07/06/2011 03:04 PM, Brion Vibber wrote: Some of you may have found that ResourceLoader's bundled minified JavaScript loads can be a bit frustrating when syntax errors creep into your JavaScript code -- not only are the line numbers reported in your browser of limited help, but a broken file can cause *all* JS modules loaded in the same request to fail[1]. This can manifest as for instance a jquery-using Gadget breaking the initial load of jquery itself because it gets bundled together into the same request. Long term I wonder if we should not be looking at closure compiler [1], we could gain an additional 10% or so compression with simple optimisations, and it has tools for inspecting compiled output [2] Long term we could work toward making code compatible with advanced optimisations, as a side effect we could get improved jsDoc docs and even better compression and optimisations would be possible. [1] http://code.google.com/closure/compiler/ [2] http://code.google.com/closure/compiler/docs/inspector.html ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r88628]: Revision status changed
User ^demon changed the status of MediaWiki.r88628. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88628#c0 Commit summary: Made $wgFlaggedRevsAutoconfirm a wrapper around $wgAutopromote ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91293]: Revision status changed
User ^demon changed the status of MediaWiki.r91293. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91293#c0 Commit summary: Better RTL interface support for CodeReview (bug 29658): paths and code diff should be LTR ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91541]: Revision status changed
User ^demon changed the status of MediaWiki.r91541. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91541#c0 Commit summary: Follow-up r91293, r91519: use wfUILang() for better backwards compatibility ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91519]: Revision status changed
User ^demon changed the status of MediaWiki.r91519. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91519#c0 Commit summary: (follow-up r91518; bug 29658 et al.) Improving RTL support for several extensions: AbuseFilter: aligning rules edit box as LTR, since they are essentially English CodeReview: aligning commit messages according to content language direction; and aligning input boxes on SpecialRepoAdmin as LTR FlaggedRevs: aligning box shown on articles to content language dir; and adding direction marks to ReviewedPages UnreviewedPages LiquidThreads: * add direction mark * make headings follow the content language dir * remove lqt_post_ltr/rtl (added a few commits ago) to use mw-content-ltr/rtl in core UploadWizard: make calendar input follow user direction (not content direction, as since r91518) (see bug 28902) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82783]: New comment added
User Tim Starling posted a comment on MediaWiki.r82783. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82783#c19293 Commit summary: * (bug 24230) Added JAR detection. ZIP archives containing a .class file will be rejected by default. Malformed ZIP archives will be rejected due to the danger of ambiguous parsing on the client side. * Removed the ZIP subtypes from $wgMimeTypeBlacklist, they no longer need to be there. * Added ZipDirectoryReader. Added some small ZIP files which are used to test its various error cases. Most were constructed with a hex editor. * Fixed getStatusArray() to return a consistent type regardless of whether the error message has parameters. This allows error messages with no parameters to work with the Status object conversion code in UploadBase::verifyFile(). Comment: Maybe at an early stage of development, it was imagined as a standalone library. But it turns out that the PEAR ZIP library was not as bad as I thought it was, so it should be sufficient for most people who need a standalone library. So the main motivation for completing ZipDirectoryReader became the fact that it could be tuned for MediaWiki and integrated with it. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r82125]: Revision status changed
User Krinkle changed the status of MediaWiki.r82125. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82125#c0 Commit summary: fixes Bug #27381 Don't (un)expand headings on right click with attached patch ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r91618]: New comment added
User Reedy posted a comment on MediaWiki.r91618. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/91618#c19295 Commit summary: Replace bullet-icon.png with an 8-bit version (became 24-bit due to r78011 which removed the color palette) * Fixes (bug 19514) Unordered list list-style-image should be IE6-compatible (8-bit) Comment: Tagging 1.17, as there is likely to be a 1.17.1 bugfix + i18n update soon ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
