[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added, and revision status changed
User Brion VIBBER changed the status of MediaWiki.r86041. Old Status: fixme New Status: resolved User Brion VIBBER also posted a comment on MediaWiki.r86041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c18484 Commit summary: r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form. Also implement a few changes suggested by Brion on IRC last night. Comment: Per notes above though, it's true that there have been problems with using action=purge as an alternate view, sometimes confusing JS etc. So actually I'll consider this ok for now (but if we find a better solution, spiff!) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added, and revision status changed
User Happy-melon changed the status of MediaWiki.r86041. Old Status: fixme New Status: new User Happy-melon also posted a comment on MediaWiki.r86041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c17720 Commit summary: r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form. Also implement a few changes suggested by Brion on IRC last night. Comment: Was fixed as part of r89547. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added, and revision status changed
User Happy-melon changed the status of MediaWiki.r86041. Old Status: fixme New Status: new User Happy-melon also posted a comment on MediaWiki.r86041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c16664 Commit summary: r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form. Also implement a few changes suggested by Brion on IRC last night. Comment: Added in r87642. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added, and revision status changed
User Platonides changed the status of MediaWiki.r86041. Old Status: new New Status: fixme User Platonides also posted a comment on MediaWiki.r86041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c16524 Commit summary: r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form. Also implement a few changes suggested by Brion on IRC last night. Comment: You are freely using FormAction and FormlessAction but they aren't registered in the autoloader. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added, and revision status changed
User IAlex changed the status of MediaWiki.r86041. Old Status: new New Status: fixme User IAlex also posted a comment on MediaWiki.r86041. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/86041#c15948 Commit summary: r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form. Also implement a few changes suggested by Brion on IRC last night. Comment: * This broke inline credits: bFatal error/b: Class 'Credits' not found in bincludes/SkinTemplate.php/b on line b385/b (there's a similar call in SkinLegacy) * Action class is missing an accessor for the user language object (i.e. replacement of $wgLang) * Asking people to ''not use globals $wgOut, $wgRequest, etc'' and in the meantime using wfMessage() or other wfMsg*() functions is inconsistent, since wfMessage() is depending on $wgLang, $wgOut and $wgTitle (depending on how your are using it). ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r86041]: New comment added, and revision status changed
User Bawolff changed the status of MediaWiki.r86041. Old Status: new New Status: fixme User Bawolff also posted a comment on MediaWiki.r86041. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86041#c15973 Commit summary: r86001, now with less scariness :P I took out the delete action and did purge instead, which is a much more self-contained action-with-a-form. Also implement a few changes suggested by Brion on IRC last night. Comment: This does look much nicer :) Unfortunately it breaks action=purge, because it tries to redirect to $this-getTitle() instead of $this-getTitle()-getFullUrl() (works sometimes due to relative url, but breaks horribly if the page is not in main namespace since colon is un-escaped, or if person is not using short urls, etc). Also we'd probably want to preserve the query parameters there (except possibly the action=purge parameter) if for example someone was purging a category with the frompage=foo parameter, etc. I'm not really sure if there's actually much benefit of redirecting after the purge... ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
