Re: [Wikitech-l] Krenair for core
On Jan 6, 2013, at 3:39 AM, Ori Livneh o...@wikimedia.org wrote: On Saturday, January 5, 2013 at 2:08 PM, Alex Monk wrote: Okay then, so what query do you use to get a history of +1 and -1 reviews a user has made? The best I could come up with is: reviewer:krenair project:mediawiki/core -owner:krenair (label:CodeReview=1 OR label:CodeReview=-1) https://gerrit.wikimedia.org/r/#/q/reviewer:krenair+project:mediawiki/core+-owner:krenair+(label:CodeReview%253D1+OR+label:CodeReview%253D-1),n,z It seems more useful to cast a wider net, though: reviewer:krenair -owner:krenair https://gerrit.wikimedia.org/r/#/q/reviewer:krenair+-owner:krenair,n,z I'll add them to the request on MediaWiki.org. Just pointing out the obvious but this returns all commits where *someone* did CR+1/-1 and where Krenair is in the reviewer list. Such as https://gerrit.wikimedia.org/r/#/c/38258/: where Bsitu did CR+1 and Alex no review on the final version but is in the reviewer/CC list. -- Krinkle ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Krenair for core
On Wed, 26 Dec 2012 16:37:47 -0800, Ori Livneh o...@wikimedia.org wrote: Hi, Just a heads-up that I nominated Krenair (Alex Monk) for inclusion in mediawiki/core: http://www.mediawiki.org/wiki/Git/Gerrit_project_ownership#Krenair_for_MediaWiki_Core For supporting evidence, see: * https://gerrit.wikimedia.org/r/#/q/owner:krenair+project:mediawiki/core,n,z * https://bugzilla.wikimedia.org/buglist.cgi?query_format=specificproduct=MediaWikicontent=krenair%40gmail.com * http://www.mediawiki.org/wiki/Special:Contributions/Krenair Please consider weighing in. Thanks, Ori -- Ori Livneh Why is a list of commits considered valid evidence for determining if someone is worth giving +2? One does not review their own commits. The commits made by the user themselves are irrelevant as it would be irresponsible for the +2 to be given in order for said line of commits to be reviewed. The +2 is for use in reviewing other users' commits. More to the point, better evidence would be a history of -1 and +1 the user has made. Are the user's +1's in line with whether a +2 was eventually made (not retaining +1 on something that was decided should be rejected)? Does the user make +1 and -1's to aid review of commits that don't get much review from others till after the user has already been helping review the commits for awhile? etc... -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://danielfriesen.name/] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Krenair for core
Okay then, so what query do you use to get a history of +1 and -1 reviews a user has made? On Sat, Jan 5, 2013 at 10:00 PM, Daniel Friesen dan...@nadir-seen-fire.comwrote: On Wed, 26 Dec 2012 16:37:47 -0800, Ori Livneh o...@wikimedia.org wrote: Hi, Just a heads-up that I nominated Krenair (Alex Monk) for inclusion in mediawiki/core: http://www.mediawiki.org/wiki/**Git/Gerrit_project_ownership#** Krenair_for_MediaWiki_Corehttp://www.mediawiki.org/wiki/Git/Gerrit_project_ownership#Krenair_for_MediaWiki_Core For supporting evidence, see: * https://gerrit.wikimedia.org/**r/#/q/owner:krenair+project:** mediawiki/core,n,zhttps://gerrit.wikimedia.org/r/#/q/owner:krenair+project:mediawiki/core,n,z * https://bugzilla.wikimedia.**org/buglist.cgi?query_format=** specificproduct=MediaWiki**content=krenair%40gmail.comhttps://bugzilla.wikimedia.org/buglist.cgi?query_format=specificproduct=MediaWikicontent=krenair%40gmail.com * http://www.mediawiki.org/wiki/**Special:Contributions/Krenairhttp://www.mediawiki.org/wiki/Special:Contributions/Krenair Please consider weighing in. Thanks, Ori -- Ori Livneh Why is a list of commits considered valid evidence for determining if someone is worth giving +2? One does not review their own commits. The commits made by the user themselves are irrelevant as it would be irresponsible for the +2 to be given in order for said line of commits to be reviewed. The +2 is for use in reviewing other users' commits. More to the point, better evidence would be a history of -1 and +1 the user has made. Are the user's +1's in line with whether a +2 was eventually made (not retaining +1 on something that was decided should be rejected)? Does the user make +1 and -1's to aid review of commits that don't get much review from others till after the user has already been helping review the commits for awhile? etc... -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://danielfriesen.name/] __**_ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/**mailman/listinfo/wikitech-lhttps://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Krenair for core
On Saturday, January 5, 2013 at 2:08 PM, Alex Monk wrote: Okay then, so what query do you use to get a history of +1 and -1 reviews a user has made? The best I could come up with is: reviewer:krenair project:mediawiki/core -owner:krenair (label:CodeReview=1 OR label:CodeReview=-1) https://gerrit.wikimedia.org/r/#/q/reviewer:krenair+project:mediawiki/core+-owner:krenair+(label:CodeReview%253D1+OR+label:CodeReview%253D-1),n,z It seems more useful to cast a wider net, though: reviewer:krenair -owner:krenair https://gerrit.wikimedia.org/r/#/q/reviewer:krenair+-owner:krenair,n,z I'll add them to the request on MediaWiki.org. -- Ori Livneh ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
