Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo 
Looks like I made it.

https://github.com/crondaemon/wireshark/runs/490547471?check_suite_focus=true

The artifact can be found in the upper right area of the screen.

On Fri, Mar 6, 2020 at 3:29 PM Dario Lombardo  wrote:

>
>
> On Fri, Mar 6, 2020 at 3:21 PM João Valverde <
> joao.valve...@tecnico.ulisboa.pt> wrote:
>
>> If you want to spare some CPU cycles I believe only the user_guide_chm
>> target is mandatory for NSIS.
>>
>> Seems you are missing some dependencies too, asciidoctor and maybe others
>> as well.
>>
>>
> Yes to both. I'm working on it.
>


-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo 
On Fri, Mar 6, 2020 at 3:21 PM João Valverde <
joao.valve...@tecnico.ulisboa.pt> wrote:

> If you want to spare some CPU cycles I believe only the user_guide_chm
> target is mandatory for NSIS.
>
> Seems you are missing some dependencies too, asciidoctor and maybe others
> as well.
>
>
Yes to both. I'm working on it.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread João Valverde 



On 06/03/20 13:55, Dario Lombardo wrote:


Si it seems like it is not running the MSVC 2019 command prompt
that takes care of setting the various environment variables.


Well... this is a point. I added the proper action and it made it a 
bit further.


https://github.com/crondaemon/wireshark/runs/490228280?check_suite_focus=true

However it failed because of:
File: "D:\a\wireshark\wireshark\build\docbook\user-guide.chm" -> no 
files found.


Then I guess I need to build the "all_guides" target.


If you want to spare some CPU cycles I believe only the user_guide_chm 
target is mandatory for NSIS.


Seems you are missing some dependencies too, asciidoctor and maybe 
others as well.



--
Naima is online.

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo 
>
> Si it seems like it is not running the MSVC 2019 command prompt that takes
> care of setting the various environment variables.
>

Well... this is a point. I added the proper action and it made it a bit
further.

https://github.com/crondaemon/wireshark/runs/490228280?check_suite_focus=true

However it failed because of:
File: "D:\a\wireshark\wireshark\build\docbook\user-guide.chm" -> no files
found.

Then I guess I need to build the "all_guides" target.
-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Pascal Quantin 
Le ven. 6 mars 2020 à 14:02, Dario Lombardo  a écrit :

>
>
> On Fri, Mar 6, 2020 at 12:44 PM Pascal Quantin 
> wrote:
>
>>
>>
>> Le ven. 6 mars 2020 à 12:28, Dario Lombardo  a écrit :
>>
>>> I am sorry, I still don't understand, I beg your pardon.
>>> You said
>>>
>>> > your machine does not have the MSVC redistributable copied in the
>>> wireshark-libs folder (as explained in the developer guide) while it is
>>> required for the NSIS installer.
>>>
>>> But I cannot find any point in the developer guide where it is explained
>>> that the MSVC redistributable has to be copied somewhere, nor I know how to
>>> do it myself without a more detailed explanation.
>>>
>>
>> This is why I said it used to be more visible in the documentation .
>> We used to have to download vcredist_x86.exe or vcredist_x64.exe from
>> Microsoft website and copy it in the Wireshark-win32-libs or
>> Wireshark-win64-libs folder. It is no more required because the
>> redistributables are bundled in the MSVC 2019 community edition (for
>> example mine is located by CMake in C:/Program Files (x86)/Microsoft Visual
>> Studio/2019/Community/VC/Redist/MSVC/14.24.28127).
>>
>> I now realize that you have 2 errors: one about the VCINSTALLDIR (root
>> cause of your NSIS issue) and one about MERGE_MODULE_DIR (for WiX). Sorry
>> for not seeing this earlier.
>>
>> As found in our CMakeLists.txt file:
>>
>> # Try to find the Redist folder in VCINSTALLDIR which is set by
>> vcvarsall.bat.
>> # If it is not set, query it within the registry. VS2015 looks for the
>> "VC7" key
>> # in two locations (four if you count HKCU instead of HKLM). However,
>> VS2017
>> # does not use "VC7" (it sets a directory relative to
>> vsdevcmd_start.bat). As
>> # both versions do set "VS7", use that instead.
>> find_path(VCINSTALLDIR Redist PATHS
>> "$ENV{VCINSTALLDIR}"
>>
>> "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
>>
>> "[HKEY_LOCAL_MACHINE\\SOFTWARE\\WOW6432Node\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
>> NO_DEFAULT_PATH
>> )
>> file(TO_NATIVE_PATH "${VCINSTALLDIR}" VCINSTALLDIR_NATIVE)
>> message(STATUS "Using VCINSTALLDIR: ${VCINSTALLDIR_NATIVE}")
>>
>> That's what Gerald indicated in his message.
>>
>> When I open the MSVC 2019 command prompt, and type 'set VCINSTALLDIR', I
>> get as expected:
>> VCINSTALLDIR=C:\Program Files (x86)\Microsoft Visual
>> Studio\2019\Community\VC\
>>
>> What do you get?
>>
>>
> Unfortunately the builder doesn't print anything with that command
>
>
> https://github.com/crondaemon/wireshark/runs/490180639?check_suite_focus=true
>
> see the "set" step.
>

Si it seems like it is not running the MSVC 2019 command prompt that takes
care of setting the various environment variables.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Graham Bloice 
For the WiX installer merge module, IIRC CMake will print the "not found"
path if WiX isn't installed.  That's been on my cleanup list for some time.

On Fri, 6 Mar 2020 at 06:44, Pascal Quantin  wrote:

>
>
> Le ven. 6 mars 2020 à 12:28, Dario Lombardo  a écrit :
>
>> I am sorry, I still don't understand, I beg your pardon.
>> You said
>>
>> > your machine does not have the MSVC redistributable copied in the
>> wireshark-libs folder (as explained in the developer guide) while it is
>> required for the NSIS installer.
>>
>> But I cannot find any point in the developer guide where it is explained
>> that the MSVC redistributable has to be copied somewhere, nor I know how to
>> do it myself without a more detailed explanation.
>>
>
> This is why I said it used to be more visible in the documentation .
> We used to have to download vcredist_x86.exe or vcredist_x64.exe from
> Microsoft website and copy it in the Wireshark-win32-libs or
> Wireshark-win64-libs folder. It is no more required because the
> redistributables are bundled in the MSVC 2019 community edition (for
> example mine is located by CMake in C:/Program Files (x86)/Microsoft Visual
> Studio/2019/Community/VC/Redist/MSVC/14.24.28127).
>
> I now realize that you have 2 errors: one about the VCINSTALLDIR (root
> cause of your NSIS issue) and one about MERGE_MODULE_DIR (for WiX). Sorry
> for not seeing this earlier.
>
> As found in our CMakeLists.txt file:
>
> # Try to find the Redist folder in VCINSTALLDIR which is set by
> vcvarsall.bat.
> # If it is not set, query it within the registry. VS2015 looks for the
> "VC7" key
> # in two locations (four if you count HKCU instead of HKLM). However,
> VS2017
> # does not use "VC7" (it sets a directory relative to vsdevcmd_start.bat).
> As
> # both versions do set "VS7", use that instead.
> find_path(VCINSTALLDIR Redist PATHS
> "$ENV{VCINSTALLDIR}"
>
> "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
>
> "[HKEY_LOCAL_MACHINE\\SOFTWARE\\WOW6432Node\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
> NO_DEFAULT_PATH
> )
> file(TO_NATIVE_PATH "${VCINSTALLDIR}" VCINSTALLDIR_NATIVE)
> message(STATUS "Using VCINSTALLDIR: ${VCINSTALLDIR_NATIVE}")
>
> That's what Gerald indicated in his message.
>
> When I open the MSVC 2019 command prompt, and type 'set VCINSTALLDIR', I
> get as expected:
> VCINSTALLDIR=C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Community\VC\
>
> What do you get?
>
>
>> On Fri, Mar 6, 2020 at 12:20 PM Pascal Quantin 
>> wrote:
>>
>>> Hi Dario,
>>>
>>> Le ven. 6 mars 2020 à 12:16, Dario Lombardo  a écrit :
>>>
 Hi Pascal
 I'm not sure I got the point. I try to explain what I understand. I
 have one single build, that may have multiple problems, some trivial, some
 not. The error I see in cmake could be ignored, while the one that counts
 is the fact I need the MSVC redistributable in the wireshark-lib folder.
 Am I correct?

>>>
>>> Yes if you do not have a step building the WiX installer (which seems to
>>> be the case).
>>>
>>>

>> Joao is correct: on one side you have a non fatal error in CMake that
> only impacts the WiX installer, and in the other side your machine does 
> not
> have the MSVC redistributable copied in the wireshark-libs folder (as
> explained in the developer guide) while it is required for the NSIS
> installer.
>
> Can you link the devel guide where it's explained? I just found


 https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html#ChSrcNSIS

>>>
>>> https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html
>>>
>>> In the past it used to be more visible if I remember correctly.
>>>
>>> BR,
>>> Pascal.
>>>
>>> ___
>>> Sent via:Wireshark-dev mailing list 
>>> Archives:https://www.wireshark.org/lists/wireshark-dev
>>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>>  mailto:wireshark-dev-requ...@wireshark.org
>>> ?subject=unsubscribe
>>
>>
>>
>> --
>>
>> Naima is online.
>>
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 
Graham Bloice
Software Developer
Trihedral UK Limited
___
Sent via:Wireshark-dev

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo 
On Fri, Mar 6, 2020 at 12:44 PM Pascal Quantin  wrote:

>
>
> Le ven. 6 mars 2020 à 12:28, Dario Lombardo  a écrit :
>
>> I am sorry, I still don't understand, I beg your pardon.
>> You said
>>
>> > your machine does not have the MSVC redistributable copied in the
>> wireshark-libs folder (as explained in the developer guide) while it is
>> required for the NSIS installer.
>>
>> But I cannot find any point in the developer guide where it is explained
>> that the MSVC redistributable has to be copied somewhere, nor I know how to
>> do it myself without a more detailed explanation.
>>
>
> This is why I said it used to be more visible in the documentation .
> We used to have to download vcredist_x86.exe or vcredist_x64.exe from
> Microsoft website and copy it in the Wireshark-win32-libs or
> Wireshark-win64-libs folder. It is no more required because the
> redistributables are bundled in the MSVC 2019 community edition (for
> example mine is located by CMake in C:/Program Files (x86)/Microsoft Visual
> Studio/2019/Community/VC/Redist/MSVC/14.24.28127).
>
> I now realize that you have 2 errors: one about the VCINSTALLDIR (root
> cause of your NSIS issue) and one about MERGE_MODULE_DIR (for WiX). Sorry
> for not seeing this earlier.
>
> As found in our CMakeLists.txt file:
>
> # Try to find the Redist folder in VCINSTALLDIR which is set by
> vcvarsall.bat.
> # If it is not set, query it within the registry. VS2015 looks for the
> "VC7" key
> # in two locations (four if you count HKCU instead of HKLM). However,
> VS2017
> # does not use "VC7" (it sets a directory relative to vsdevcmd_start.bat).
> As
> # both versions do set "VS7", use that instead.
> find_path(VCINSTALLDIR Redist PATHS
> "$ENV{VCINSTALLDIR}"
>
> "[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
>
> "[HKEY_LOCAL_MACHINE\\SOFTWARE\\WOW6432Node\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
> NO_DEFAULT_PATH
> )
> file(TO_NATIVE_PATH "${VCINSTALLDIR}" VCINSTALLDIR_NATIVE)
> message(STATUS "Using VCINSTALLDIR: ${VCINSTALLDIR_NATIVE}")
>
> That's what Gerald indicated in his message.
>
> When I open the MSVC 2019 command prompt, and type 'set VCINSTALLDIR', I
> get as expected:
> VCINSTALLDIR=C:\Program Files (x86)\Microsoft Visual
> Studio\2019\Community\VC\
>
> What do you get?
>
>
Unfortunately the builder doesn't print anything with that command

https://github.com/crondaemon/wireshark/runs/490180639?check_suite_focus=true

see the "set" step.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Pascal Quantin 
Le ven. 6 mars 2020 à 12:28, Dario Lombardo  a écrit :

> I am sorry, I still don't understand, I beg your pardon.
> You said
>
> > your machine does not have the MSVC redistributable copied in the
> wireshark-libs folder (as explained in the developer guide) while it is
> required for the NSIS installer.
>
> But I cannot find any point in the developer guide where it is explained
> that the MSVC redistributable has to be copied somewhere, nor I know how to
> do it myself without a more detailed explanation.
>

This is why I said it used to be more visible in the documentation .
We used to have to download vcredist_x86.exe or vcredist_x64.exe from
Microsoft website and copy it in the Wireshark-win32-libs or
Wireshark-win64-libs folder. It is no more required because the
redistributables are bundled in the MSVC 2019 community edition (for
example mine is located by CMake in C:/Program Files (x86)/Microsoft Visual
Studio/2019/Community/VC/Redist/MSVC/14.24.28127).

I now realize that you have 2 errors: one about the VCINSTALLDIR (root
cause of your NSIS issue) and one about MERGE_MODULE_DIR (for WiX). Sorry
for not seeing this earlier.

As found in our CMakeLists.txt file:

# Try to find the Redist folder in VCINSTALLDIR which is set by
vcvarsall.bat.
# If it is not set, query it within the registry. VS2015 looks for the
"VC7" key
# in two locations (four if you count HKCU instead of HKLM). However, VS2017
# does not use "VC7" (it sets a directory relative to vsdevcmd_start.bat).
As
# both versions do set "VS7", use that instead.
find_path(VCINSTALLDIR Redist PATHS
"$ENV{VCINSTALLDIR}"
"[HKEY_LOCAL_MACHINE\\SOFTWARE\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
"[HKEY_LOCAL_MACHINE\\SOFTWARE\\WOW6432Node\\Microsoft\\VisualStudio\\SxS\\VS7;${_msvs_version}]\\VC"
NO_DEFAULT_PATH
)
file(TO_NATIVE_PATH "${VCINSTALLDIR}" VCINSTALLDIR_NATIVE)
message(STATUS "Using VCINSTALLDIR: ${VCINSTALLDIR_NATIVE}")

That's what Gerald indicated in his message.

When I open the MSVC 2019 command prompt, and type 'set VCINSTALLDIR', I
get as expected:
VCINSTALLDIR=C:\Program Files (x86)\Microsoft Visual
Studio\2019\Community\VC\

What do you get?


> On Fri, Mar 6, 2020 at 12:20 PM Pascal Quantin 
> wrote:
>
>> Hi Dario,
>>
>> Le ven. 6 mars 2020 à 12:16, Dario Lombardo  a écrit :
>>
>>> Hi Pascal
>>> I'm not sure I got the point. I try to explain what I understand. I have
>>> one single build, that may have multiple problems, some trivial, some not.
>>> The error I see in cmake could be ignored, while the one that counts is the
>>> fact I need the MSVC redistributable in the wireshark-lib folder.
>>> Am I correct?
>>>
>>
>> Yes if you do not have a step building the WiX installer (which seems to
>> be the case).
>>
>>
>>>
> Joao is correct: on one side you have a non fatal error in CMake that
 only impacts the WiX installer, and in the other side your machine does not
 have the MSVC redistributable copied in the wireshark-libs folder (as
 explained in the developer guide) while it is required for the NSIS
 installer.

 Can you link the devel guide where it's explained? I just found
>>>
>>>
>>> https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html#ChSrcNSIS
>>>
>>
>> https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html
>>
>> In the past it used to be more visible if I remember correctly.
>>
>> BR,
>> Pascal.
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
>
>
> --
>
> Naima is online.
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo 
I am sorry, I still don't understand, I beg your pardon.
You said

> your machine does not have the MSVC redistributable copied in the
wireshark-libs folder (as explained in the developer guide) while it is
required for the NSIS installer.

But I cannot find any point in the developer guide where it is explained
that the MSVC redistributable has to be copied somewhere, nor I know how to
do it myself without a more detailed explanation.

On Fri, Mar 6, 2020 at 12:20 PM Pascal Quantin  wrote:

> Hi Dario,
>
> Le ven. 6 mars 2020 à 12:16, Dario Lombardo  a écrit :
>
>> Hi Pascal
>> I'm not sure I got the point. I try to explain what I understand. I have
>> one single build, that may have multiple problems, some trivial, some not.
>> The error I see in cmake could be ignored, while the one that counts is the
>> fact I need the MSVC redistributable in the wireshark-lib folder.
>> Am I correct?
>>
>
> Yes if you do not have a step building the WiX installer (which seems to
> be the case).
>
>
>>
 Joao is correct: on one side you have a non fatal error in CMake that
>>> only impacts the WiX installer, and in the other side your machine does not
>>> have the MSVC redistributable copied in the wireshark-libs folder (as
>>> explained in the developer guide) while it is required for the NSIS
>>> installer.
>>>
>>> Can you link the devel guide where it's explained? I just found
>>
>>
>> https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html#ChSrcNSIS
>>
>
> https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html
>
> In the past it used to be more visible if I remember correctly.
>
> BR,
> Pascal.
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Pascal Quantin 
Hi Dario,

Le ven. 6 mars 2020 à 12:16, Dario Lombardo  a écrit :

> Hi Pascal
> I'm not sure I got the point. I try to explain what I understand. I have
> one single build, that may have multiple problems, some trivial, some not.
> The error I see in cmake could be ignored, while the one that counts is the
> fact I need the MSVC redistributable in the wireshark-lib folder.
> Am I correct?
>

Yes if you do not have a step building the WiX installer (which seems to be
the case).


>
>>> Joao is correct: on one side you have a non fatal error in CMake that
>> only impacts the WiX installer, and in the other side your machine does not
>> have the MSVC redistributable copied in the wireshark-libs folder (as
>> explained in the developer guide) while it is required for the NSIS
>> installer.
>>
>> Can you link the devel guide where it's explained? I just found
>
> https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html#ChSrcNSIS
>

https://www.wireshark.org/docs/wsdg_html_chunked/ChSetupWin32.html

In the past it used to be more visible if I remember correctly.

BR,
Pascal.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo 
Hi Pascal
I'm not sure I got the point. I try to explain what I understand. I have
one single build, that may have multiple problems, some trivial, some not.
The error I see in cmake could be ignored, while the one that counts is the
fact I need the MSVC redistributable in the wireshark-lib folder.
Am I correct?


>> Joao is correct: on one side you have a non fatal error in CMake that
> only impacts the WiX installer, and in the other side your machine does not
> have the MSVC redistributable copied in the wireshark-libs folder (as
> explained in the developer guide) while it is required for the NSIS
> installer.
>
> Can you link the devel guide where it's explained? I just found

https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcBinary.html#ChSrcNSIS

Thanks.
Dario.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Pascal Quantin 
Hi Dario,

Le ven. 6 mars 2020 à 11:30, Dario Lombardo  a écrit :

> No, it's the same. Have a look at the cmake section and you will see the
> error messages below.
>

Joao is correct: on one side you have a non fatal error in CMake that only
impacts the WiX installer, and in the other side your machine does not have
the MSVC redistributable copied in the wireshark-libs folder (as explained
in the developer guide) while it is required for the NSIS installer.


> On Fri, Mar 6, 2020 at 10:54 AM João Valverde <
> joao.valve...@tecnico.ulisboa.pt> wrote:
>
>>
>>
>> On 06/03/20 08:23, Dario Lombardo wrote:
>>
>> Example of failing build
>>
>>
>> https://github.com/crondaemon/wireshark/runs/489648430?check_suite_focus=true
>>
>>
>> A quick look suggests this is a different build than you indicated
>> before, for an NSIS package, and the problem seems to be that the VC_REDIST
>> exe is missing.
>>
>>
>> On Fri, Mar 6, 2020 at 9:07 AM Dario Lombardo  wrote:
>>
>>> Are you saying "set v"? It doesn't print anything.
>>> The installation of VS is pre-made by the github builder itself, not by
>>> me, hence I don't have any control over the installation options. However I
>>> guess every component is in place, and maybe I just need to add the proper
>>> dir to the PATH. What do you think?
>>>
>>> On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs 
>>> wrote:
>>>
 On 3/5/20 7:27 AM, Dario Lombardo wrote:
 > Hi,
 > I'm getting this output from a windows build
 >
 > -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
 > -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for
 the WiX installer
 > -- Configuring done
 > -- Generating done
 > -- Build files have been written to: D:/a/wireshark/wireshark/build
 >
 > What's going wrong? The rest of the output looks good.

 VCINSTALLDIR should have been set by Visual Studio, e.g. by
 vcvarsall.bat. What does `set v` show?

 ___
 Sent via:Wireshark-dev mailing list 
 Archives:https://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org
 ?subject=unsubscribe
>>>
>>>
>>>
>>> --
>>>
>>> Naima is online.
>>>
>>>
>>
>> --
>>
>> Naima is online.
>>
>>
>> ___
>> Sent via:Wireshark-dev mailing list  
>> 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe 
>> 
>>
>>
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
>
>
> --
>
> Naima is online.
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo 
No, it's the same. Have a look at the cmake section and you will see the
error messages below.

On Fri, Mar 6, 2020 at 10:54 AM João Valverde <
joao.valve...@tecnico.ulisboa.pt> wrote:

>
>
> On 06/03/20 08:23, Dario Lombardo wrote:
>
> Example of failing build
>
>
> https://github.com/crondaemon/wireshark/runs/489648430?check_suite_focus=true
>
>
> A quick look suggests this is a different build than you indicated before,
> for an NSIS package, and the problem seems to be that the VC_REDIST exe is
> missing.
>
>
> On Fri, Mar 6, 2020 at 9:07 AM Dario Lombardo  wrote:
>
>> Are you saying "set v"? It doesn't print anything.
>> The installation of VS is pre-made by the github builder itself, not by
>> me, hence I don't have any control over the installation options. However I
>> guess every component is in place, and maybe I just need to add the proper
>> dir to the PATH. What do you think?
>>
>> On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs  wrote:
>>
>>> On 3/5/20 7:27 AM, Dario Lombardo wrote:
>>> > Hi,
>>> > I'm getting this output from a windows build
>>> >
>>> > -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
>>> > -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the
>>> WiX installer
>>> > -- Configuring done
>>> > -- Generating done
>>> > -- Build files have been written to: D:/a/wireshark/wireshark/build
>>> >
>>> > What's going wrong? The rest of the output looks good.
>>>
>>> VCINSTALLDIR should have been set by Visual Studio, e.g. by
>>> vcvarsall.bat. What does `set v` show?
>>>
>>> ___
>>> Sent via:Wireshark-dev mailing list 
>>> Archives:https://www.wireshark.org/lists/wireshark-dev
>>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>>  mailto:wireshark-dev-requ...@wireshark.org
>>> ?subject=unsubscribe
>>
>>
>>
>> --
>>
>> Naima is online.
>>
>>
>
> --
>
> Naima is online.
>
>
> ___
> Sent via:Wireshark-dev mailing list  
> 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe 
> 
>
>
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread João Valverde 



On 06/03/20 08:23, Dario Lombardo wrote:

Example of failing build

https://github.com/crondaemon/wireshark/runs/489648430?check_suite_focus=true


A quick look suggests this is a different build than you indicated 
before, for an NSIS package, and the problem seems to be that the 
VC_REDIST exe is missing.




On Fri, Mar 6, 2020 at 9:07 AM Dario Lombardo > wrote:


Are you saying "set v"? It doesn't print anything.
The installation of VS is pre-made by the github builder itself,
not by me, hence I don't have any control over the installation
options. However I guess every component is in place, and maybe I
just need to add the proper dir to the PATH. What do you think?

On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs mailto:ger...@wireshark.org>> wrote:

On 3/5/20 7:27 AM, Dario Lombardo wrote:
> Hi,
> I'm getting this output from a windows build
>
> -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
> -- Using
MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the
WiX installer
> -- Configuring done
> -- Generating done
> -- Build files have been written to:
D:/a/wireshark/wireshark/build
>
> What's going wrong? The rest of the output looks good.

VCINSTALLDIR should have been set by Visual Studio, e.g. by
vcvarsall.bat. What does `set v` show?

___
Sent via:    Wireshark-dev mailing list
mailto:wireshark-dev@wireshark.org>>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe:
https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-requ...@wireshark.org
?subject=unsubscribe



-- 


Naima is online.



--
Naima is online.

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread João Valverde 

Maybe this helps?

https://github.com/actions/virtual-environments/issues/195

On 06/03/20 08:07, Dario Lombardo wrote:

Are you saying "set v"? It doesn't print anything.
The installation of VS is pre-made by the github builder itself, not 
by me, hence I don't have any control over the installation options. 
However I guess every component is in place, and maybe I just need to 
add the proper dir to the PATH. What do you think?


On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs > wrote:


On 3/5/20 7:27 AM, Dario Lombardo wrote:
> Hi,
> I'm getting this output from a windows build
>
> -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
> -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm
for the WiX installer
> -- Configuring done
> -- Generating done
> -- Build files have been written to: D:/a/wireshark/wireshark/build
>
> What's going wrong? The rest of the output looks good.

VCINSTALLDIR should have been set by Visual Studio, e.g. by
vcvarsall.bat. What does `set v` show?
___
Sent via:    Wireshark-dev mailing list
mailto:wireshark-dev@wireshark.org>>
Archives: https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
             mailto:wireshark-dev-requ...@wireshark.org
?subject=unsubscribe



--
Naima is online.

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo 
Example of failing build

https://github.com/crondaemon/wireshark/runs/489648430?check_suite_focus=true

On Fri, Mar 6, 2020 at 9:07 AM Dario Lombardo  wrote:

> Are you saying "set v"? It doesn't print anything.
> The installation of VS is pre-made by the github builder itself, not by
> me, hence I don't have any control over the installation options. However I
> guess every component is in place, and maybe I just need to add the proper
> dir to the PATH. What do you think?
>
> On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs  wrote:
>
>> On 3/5/20 7:27 AM, Dario Lombardo wrote:
>> > Hi,
>> > I'm getting this output from a windows build
>> >
>> > -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
>> > -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the
>> WiX installer
>> > -- Configuring done
>> > -- Generating done
>> > -- Build files have been written to: D:/a/wireshark/wireshark/build
>> >
>> > What's going wrong? The rest of the output looks good.
>>
>> VCINSTALLDIR should have been set by Visual Studio, e.g. by
>> vcvarsall.bat. What does `set v` show?
>>
>> ___
>> Sent via:Wireshark-dev mailing list 
>> Archives:https://www.wireshark.org/lists/wireshark-dev
>> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>>  mailto:wireshark-dev-requ...@wireshark.org
>> ?subject=unsubscribe
>
>
>
> --
>
> Naima is online.
>
>

-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-06 Thread Dario Lombardo 
Are you saying "set v"? It doesn't print anything.
The installation of VS is pre-made by the github builder itself, not by me,
hence I don't have any control over the installation options. However I
guess every component is in place, and maybe I just need to add the proper
dir to the PATH. What do you think?

On Thu, Mar 5, 2020 at 9:36 PM Gerald Combs  wrote:

> On 3/5/20 7:27 AM, Dario Lombardo wrote:
> > Hi,
> > I'm getting this output from a windows build
> >
> > -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
> > -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the
> WiX installer
> > -- Configuring done
> > -- Generating done
> > -- Build files have been written to: D:/a/wireshark/wireshark/build
> >
> > What's going wrong? The rest of the output looks good.
>
> VCINSTALLDIR should have been set by Visual Studio, e.g. by vcvarsall.bat.
> What does `set v` show?
> ___
> Sent via:Wireshark-dev mailing list 
> Archives:https://www.wireshark.org/lists/wireshark-dev
> Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
>  mailto:wireshark-dev-requ...@wireshark.org
> ?subject=unsubscribe



-- 

Naima is online.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-05 Thread Gerald Combs 
On 3/5/20 2:36 PM, João Valverde wrote:
> 
> 
> On 05/03/20 15:27, Dario Lombardo wrote:
>> Hi,
>> I'm getting this output from a windows build
>>
>> -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
>> -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the WiX 
>> installer
>> -- Configuring done
>> -- Generating done
>> -- Build files have been written to: D:/a/wireshark/wireshark/build
>>
>> What's going wrong? The rest of the output looks good.
>>
> 
> If I recall correctly you need to select some option from the Visual Studio 
> installer that is not documented in the Wireshark docs.
> 
> This is only necessary for the WiX installer (not NSIS).
> 
> I can't recall the exact component you need to install at the moment and I 
> can't look it up right now.

It's the "C++ 2019 Redistributable MSMs" component. An update to the 
Developer's Guide is inbound in change 36306.
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-05 Thread João Valverde 



On 05/03/20 15:27, Dario Lombardo wrote:

Hi,
I'm getting this output from a windows build

-- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
-- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the 
WiX installer

-- Configuring done
-- Generating done
-- Build files have been written to: D:/a/wireshark/wireshark/build

What's going wrong? The rest of the output looks good.



If I recall correctly you need to select some option from the Visual 
Studio installer that is not documented in the Wireshark docs.


This is only necessary for the WiX installer (not NSIS).

I can't recall the exact component you need to install at the moment and 
I can't look it up right now.



--
Naima is online.

___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe


___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Cmake on windows

2020-03-05 Thread Gerald Combs 
On 3/5/20 7:27 AM, Dario Lombardo wrote:
> Hi,
> I'm getting this output from a windows build
> 
> -- Using VCINSTALLDIR: VCINSTALLDIR-NOTFOUND
> -- Using MERGE_MODULE_DIR-NOTFOUND\Microsoft_VC142_CRT_x64.msm for the WiX 
> installer
> -- Configuring done
> -- Generating done
> -- Build files have been written to: D:/a/wireshark/wireshark/build
> 
> What's going wrong? The rest of the output looks good.

VCINSTALLDIR should have been set by Visual Studio, e.g. by vcvarsall.bat. What 
does `set v` show?
___
Sent via:Wireshark-dev mailing list 
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] CMake on Windows - Can build, but not run executable

2015-03-26 Thread Graham Bloice 
I seem to remember earlier issues with other folks using VS2012 and wanting
a 64 bit build, due to qt support problems.

VS2013 CE is available for free, you might want to consider that.

As for CMake build instructions did you look at README.cmake in the top
level sources?

When we get CMake totally sorted, I'll update the Developers Guide to use
that rather than nmake.  Still some things to do yet.


On 26 March 2015 at 13:10, Roland Knall rkn...@gmail.com wrote:

 Hi

 I have only VStudio 2012 available here at my workplace. Using CMake
 3.0.2, msvc2012_64_opengl.

 The error log (in german) produces the following output:

 =
 Startet die Generierung des Aktivierungskontextes.
 Eingabeparameter:
 Flags = 0
 ProcessorArchitecture = AMD64
 CultureFallBacks = de-DE;de
 ManifestPath = C:\dev\Wireshark\cmakebuild\run\wireshark-gtk.exe
 AssemblyDirectory = C:\dev\Wireshark\cmakebuild\run\
 Application Config File =
 -
 INFORMATION: Manifestdatei
 C:\dev\Wireshark\cmakebuild\run\wireshark-gtk.exe wird analysiert.
 INFORMATION: Die Manifestsdefinitionsidentität ist (null).
 FEHLER: Zeile 8: Der Wert  des processorArchitecture-Attributs im
 assemblyIdentity-Element ist ungültig.
 FEHLER: Bei der Generierung des Aktivierungskontextes ist ein Fehler
 aufgetreten.
 Beendet die Generierung des Aktivierungskontextes.


 I am trying to build with 32bit now, and will keep you updated. I've
 figured it may have something to do with Qt, and the fact, that the package
 for opensource is only supporting 64 bit with VStudio2013. Why tshark and
 wireshark-gtk are affected by this, I can't really figure out.

 Btw, should there be another page on the wiki for building with cmake on
 Windows? Running the setup script was one thing, but the main thing with my
 devenv.bat was, that I used to set WIRESHARK_BASE_DIR, but with that I
 never got the build running. As soon as I set WIRESHARK_LIB_DIR as
 environment variable, the build worked. I used the stdio information from
 the buildbot to figure it out, but others may well have some issues here.

 regards,
 Roland

 On Wed, Mar 25, 2015 at 6:32 PM, Graham Bloice 
 graham.blo...@trihedral.com wrote:

 On 25 March 2015 at 08:17, Roland Knall rkn...@gmail.com wrote:

 Hi

 I can build wireshark successfully (gtk and qt interfaces) on Windows,
 but If I want to execute it, he complains that the side-by-side
 configuration is not correct.

 If I trace the launch with sxstrace, he complains, that the
 ProcessorArchitecture is wrong for the target (amd64).

 The build is a Windows 64bit build



 Using VS2013, CMake 3.1.3, QT 5.4.1 msvc2013_64_opengl.

 I don't normally build x64, so gave it a go using the x64 native compiler
 and CMake fails configure, the testing for various sizes fails as CMake is
 asking the linker to use both x64 and x86 modes??

 If I use the cross compiler (i.e. x86 building x64) then CMake does
 configure and the resulting build runs for me (both qt and gtk).

 I usually run depends (http://www.dependencywalker.com/) to check what
 DLL's etc are to be loaded.


 --
 Graham Bloice


 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:https://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org
 ?subject=unsubscribe



 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:https://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org
 ?subject=unsubscribe




-- 
Graham Bloice
Software Developer
Trihedral UK Limited
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] CMake on Windows - Can build, but not run executable

2015-03-26 Thread Roland Knall 
Hi

The 32bit is not working either. I am not trying to upgrade my Qt version
(although I really can't figure out what the issue should be here for
tshark and wireshark-gtk, and if this is not working, I'll try your debug
scenario.

VS2013 is unfortunately not allowed in our company, not even the CE
version, and therefore not an option for me.

regards,
Roland

On Thu, Mar 26, 2015 at 2:19 PM, Graham Bloice graham.blo...@trihedral.com
wrote:

 I seem to remember earlier issues with other folks using VS2012 and
 wanting a 64 bit build, due to qt support problems.

 VS2013 CE is available for free, you might want to consider that.

 As for CMake build instructions did you look at README.cmake in the top
 level sources?

 When we get CMake totally sorted, I'll update the Developers Guide to use
 that rather than nmake.  Still some things to do yet.


 On 26 March 2015 at 13:10, Roland Knall rkn...@gmail.com wrote:

 Hi

 I have only VStudio 2012 available here at my workplace. Using CMake
 3.0.2, msvc2012_64_opengl.

 The error log (in german) produces the following output:

 =
 Startet die Generierung des Aktivierungskontextes.
 Eingabeparameter:
 Flags = 0
 ProcessorArchitecture = AMD64
 CultureFallBacks = de-DE;de
 ManifestPath = C:\dev\Wireshark\cmakebuild\run\wireshark-gtk.exe
 AssemblyDirectory = C:\dev\Wireshark\cmakebuild\run\
 Application Config File =
 -
 INFORMATION: Manifestdatei
 C:\dev\Wireshark\cmakebuild\run\wireshark-gtk.exe wird analysiert.
 INFORMATION: Die Manifestsdefinitionsidentität ist (null).
 FEHLER: Zeile 8: Der Wert  des processorArchitecture-Attributs im
 assemblyIdentity-Element ist ungültig.
 FEHLER: Bei der Generierung des Aktivierungskontextes ist ein Fehler
 aufgetreten.
 Beendet die Generierung des Aktivierungskontextes.


 I am trying to build with 32bit now, and will keep you updated. I've
 figured it may have something to do with Qt, and the fact, that the package
 for opensource is only supporting 64 bit with VStudio2013. Why tshark and
 wireshark-gtk are affected by this, I can't really figure out.

 Btw, should there be another page on the wiki for building with cmake on
 Windows? Running the setup script was one thing, but the main thing with my
 devenv.bat was, that I used to set WIRESHARK_BASE_DIR, but with that I
 never got the build running. As soon as I set WIRESHARK_LIB_DIR as
 environment variable, the build worked. I used the stdio information from
 the buildbot to figure it out, but others may well have some issues here.

 regards,
 Roland

 On Wed, Mar 25, 2015 at 6:32 PM, Graham Bloice 
 graham.blo...@trihedral.com wrote:

 On 25 March 2015 at 08:17, Roland Knall rkn...@gmail.com wrote:

 Hi

 I can build wireshark successfully (gtk and qt interfaces) on Windows,
 but If I want to execute it, he complains that the side-by-side
 configuration is not correct.

 If I trace the launch with sxstrace, he complains, that the
 ProcessorArchitecture is wrong for the target (amd64).

 The build is a Windows 64bit build



 Using VS2013, CMake 3.1.3, QT 5.4.1 msvc2013_64_opengl.

 I don't normally build x64, so gave it a go using the x64 native
 compiler and CMake fails configure, the testing for various sizes fails as
 CMake is asking the linker to use both x64 and x86 modes??

 If I use the cross compiler (i.e. x86 building x64) then CMake does
 configure and the resulting build runs for me (both qt and gtk).

 I usually run depends (http://www.dependencywalker.com/) to check what
 DLL's etc are to be loaded.


 --
 Graham Bloice


 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:https://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org
 ?subject=unsubscribe




 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:https://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org
 ?subject=unsubscribe




 --
 Graham Bloice
 Software Developer
 Trihedral UK Limited

 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:https://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org
 ?subject=unsubscribe

___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev

Re: [Wireshark-dev] CMake on Windows - Can build, but not run executable

2015-03-25 Thread Graham Bloice 
On 25 March 2015 at 08:17, Roland Knall rkn...@gmail.com wrote:

 Hi

 I can build wireshark successfully (gtk and qt interfaces) on Windows, but
 If I want to execute it, he complains that the side-by-side configuration
 is not correct.

 If I trace the launch with sxstrace, he complains, that the
 ProcessorArchitecture is wrong for the target (amd64).

 The build is a Windows 64bit build



Using VS2013, CMake 3.1.3, QT 5.4.1 msvc2013_64_opengl.

I don't normally build x64, so gave it a go using the x64 native compiler
and CMake fails configure, the testing for various sizes fails as CMake is
asking the linker to use both x64 and x86 modes??

If I use the cross compiler (i.e. x86 building x64) then CMake does
configure and the resulting build runs for me (both qt and gtk).

I usually run depends (http://www.dependencywalker.com/) to check what
DLL's etc are to be loaded.


-- 
Graham Bloice
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:https://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] CMake for Windows

2013-06-26 Thread Roland Knall 
Hi

As I am somewhat converse in cmake, I can give you a few pointers, if you like.

In general for each package a cmake system should look for, a
FindPackageName.cmake file should exist in either one of two places:

- The local directory (in wireshark underneath src/cmake/modules/Find
- Or the global cmake directory cmake_install_dir/Modules/Find...

Those packages usually comply to a definition, where you can provide a
searchpath by setting a directory before including the package.

So if you have a CMakeLists.txt with the following context:



INCLUDE(Findzlib)
IF(ZLIB_FOUND)

   ...

ENDIF(ZLIB_FOUND)



then you can set a search path by using:

...
IF(WIN32)
SET(ZLIB_INCLUDE_DIRS c:\\wireshark-win32-libs\\zlib125\\include)
SET(ZLIB_LIBRARY_DIRS c:\\wireshark-win32-libs\\zlib125\\bin
c:\\wireshark-win32-libs\\zlib125\\lib )
ENDIF(WIN32)
INCLUDE(Findzlib)


But setting static routes should be avoided, so better set a relative
path (aka ${PROJECT_BINARY_DIR}/../..) or
using a system variable.

If you have to call a script, you should do this by using either
EXECUTE_PROCESS or better create a CUSTOM_TARGET which you can depend
on, so that the right libraries will allways be downloaded, if they
cannot be found.

Finally, if you include user-editable scripts, they should start with
CMake.. and end in .txt. Something like config.CMake should be
avoided, as it is nmake specific.

kind regards,
Roland



On Fri, Jun 21, 2013 at 1:55 AM, Graham Bloice
graham.blo...@trihedral.com wrote:
 As the starter for some planned major improvements|changes to the win32
 build, I'd like to get CMake working for building Wireshark on Windows.

 I know what I'm doing with the nmake builds, and have once built
 successfully on Ubuntu with CMake, but that's about it for my CMake
 knowledge, so I'm looking for support (Joerg?) to do this, so that:

 a) I don't break CMake on other platforms
 b) I actually get CMake working on Windows

 The first issue I ran into was that CMake wasn't able to find all the third
 party libraries we link with, and required very laborious editing of the
 required items in the CMake GUI.

 Currently the third party libs are retrieved by a bash script run via nmake
 (tools\win-setup.sh) that I'm leaving alone for the moment.  That script
 pulls the required libraries from wireshark.org as zip bundles and then
 expands all the bundles into a single libs directory, the path to which is
 configured by the user in config.nmake.

 My current trunk contents of this libs directory is shown below:

 AirPcap_Devpack_4_1_0_1622
 c-ares-1.9.1-1-win32ws
 GeoIP-1.4.8-2-win32ws
 gnutls-2.12.18-1.2-win32ws
 gtk2
 kfw-3-2-2-i386-ws-vc6
 libsmi-svn-40773-win32ws
 lua5.1.4
 nasm-2.09.08
 portaudio_v19_2
 upx303w
 user-guide
 WinSparkle-0.3-44-g2c8d9d3-win32ws
 WpdPack
 zlib125

 Most of these directories contain the required items in three
 sub-directories; bin for DLL's, include for headers and lib for .lib
 import libraries used when linking but some don't follow this pattern (blame
 the originating projects) and the gtk2 directory is an enormous bit-bucket
 of all things gnome including glib.

 So, given all the above, how do I get CMake to search the libs directory
 for the required items?  I'm not adverse to adding a config.CMake for the
 user to edit as required.  I suspect I'll need to add some custom CMake
 search packages?? to do this on win32.

 Graham

 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:http://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] CMake for Windows

2013-06-26 Thread Graham Bloice 
On 26 June 2013 10:10, Roland Knall rkn...@gmail.com wrote:

 Hi

 As I am somewhat converse in cmake, I can give you a few pointers, if you
 like.

 In general for each package a cmake system should look for, a
 FindPackageName.cmake file should exist in either one of two places:

 - The local directory (in wireshark underneath src/cmake/modules/Find
 - Or the global cmake directory cmake_install_dir/Modules/Find...

 Those packages usually comply to a definition, where you can provide a
 searchpath by setting a directory before including the package.

 So if you have a CMakeLists.txt with the following context:


 
 INCLUDE(Findzlib)
 IF(ZLIB_FOUND)

...

 ENDIF(ZLIB_FOUND)
 


 then you can set a search path by using:

 ...
 IF(WIN32)
 SET(ZLIB_INCLUDE_DIRS c:\\wireshark-win32-libs\\zlib125\\include)
 SET(ZLIB_LIBRARY_DIRS c:\\wireshark-win32-libs\\zlib125\\bin
 c:\\wireshark-win32-libs\\zlib125\\lib )
 ENDIF(WIN32)
 INCLUDE(Findzlib)
 

 But setting static routes should be avoided, so better set a relative
 path (aka ${PROJECT_BINARY_DIR}/../..) or
 using a system variable.

 If you have to call a script, you should do this by using either
 EXECUTE_PROCESS or better create a CUSTOM_TARGET which you can depend
 on, so that the right libraries will allways be downloaded, if they
 cannot be found.

 Finally, if you include user-editable scripts, they should start with
 CMake.. and end in .txt. Something like config.CMake should be
 avoided, as it is nmake specific.

 kind regards,
 Roland


I've been attempting that sort of thing but success eludes me.

Take cares for instance.  The path to the include dir is
$(PROJECT_LIB_DIR)/c-ares-1.9.1.1-win32ws/include.

I don't want to hard-code the library version suffix so I'd like to get
CMake to search within $(PROJECT_LIB_DIR) for a directory that begins
c-ares-.

My current attempt is (with hard-coded paths and debugging messages):

IF (WIN32)
  MESSAGE(Searching wireshark libs for c-ares)
  FILE(GLOB subdir W:/Wireshark/wireshark-win32-libs/*)
  FOREACH(dir $(subdir))
MESSAGE(Found: $(dir))
IF(IS_DIRECTORY $(dir))
  MESSAGE(Found: $(dir))
  IF($(dir) MATCHES ^c-ares-.*)
SET(CARES_HINTS $(dir))
  ENDIF()
ENDIF()
  ENDFOREACH()
ENDIF(WIN32)

This fails to find any subdirectories at all.  I've also tried GLOB_RECURSE
with no change.

Graham
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] CMake for Windows

2013-06-26 Thread Roland Knall 
Hi

GLOB and GLOB_RECURSE should normally only catch files, not
directories. (As noted on
http://www.cmake.org/cmake/help/v2.8.11/cmake.html#command:file)

You should look for ares.h. From the returned path you could deduct
the directory path with STRING.

Alternativly you could look on google for Findcares.cmake, which will
get you some matches for other people, who attempted the same thing.
From there you can either take their hints or create your own version.

More problematic is finding the library. But you could either use the
built-in function find_library or use the cmake module
FindPackageHandleStandardArgs.cmake (Description in the header of the
file).

Allways try to use as many built-in commands as possible, because even
something simple as a little foreach and some paths you set may lead
to cross-compilation mayhem in the future.

kind regards,
Roland

On Wed, Jun 26, 2013 at 11:35 AM, Graham Bloice
graham.blo...@trihedral.com wrote:

 On 26 June 2013 10:10, Roland Knall rkn...@gmail.com wrote:

 Hi

 As I am somewhat converse in cmake, I can give you a few pointers, if you
 like.

 In general for each package a cmake system should look for, a
 FindPackageName.cmake file should exist in either one of two places:

 - The local directory (in wireshark underneath
 src/cmake/modules/Find
 - Or the global cmake directory cmake_install_dir/Modules/Find...

 Those packages usually comply to a definition, where you can provide a
 searchpath by setting a directory before including the package.

 So if you have a CMakeLists.txt with the following context:


 
 INCLUDE(Findzlib)
 IF(ZLIB_FOUND)

...

 ENDIF(ZLIB_FOUND)
 


 then you can set a search path by using:

 ...
 IF(WIN32)
 SET(ZLIB_INCLUDE_DIRS c:\\wireshark-win32-libs\\zlib125\\include)
 SET(ZLIB_LIBRARY_DIRS c:\\wireshark-win32-libs\\zlib125\\bin
 c:\\wireshark-win32-libs\\zlib125\\lib )
 ENDIF(WIN32)
 INCLUDE(Findzlib)
 

 But setting static routes should be avoided, so better set a relative
 path (aka ${PROJECT_BINARY_DIR}/../..) or
 using a system variable.

 If you have to call a script, you should do this by using either
 EXECUTE_PROCESS or better create a CUSTOM_TARGET which you can depend
 on, so that the right libraries will allways be downloaded, if they
 cannot be found.

 Finally, if you include user-editable scripts, they should start with
 CMake.. and end in .txt. Something like config.CMake should be
 avoided, as it is nmake specific.

 kind regards,
 Roland


 I've been attempting that sort of thing but success eludes me.

 Take cares for instance.  The path to the include dir is
 $(PROJECT_LIB_DIR)/c-ares-1.9.1.1-win32ws/include.

 I don't want to hard-code the library version suffix so I'd like to get
 CMake to search within $(PROJECT_LIB_DIR) for a directory that begins
 c-ares-.

 My current attempt is (with hard-coded paths and debugging messages):

 IF (WIN32)
   MESSAGE(Searching wireshark libs for c-ares)
   FILE(GLOB subdir W:/Wireshark/wireshark-win32-libs/*)
   FOREACH(dir $(subdir))
 MESSAGE(Found: $(dir))
 IF(IS_DIRECTORY $(dir))
   MESSAGE(Found: $(dir))
   IF($(dir) MATCHES ^c-ares-.*)
 SET(CARES_HINTS $(dir))
   ENDIF()
 ENDIF()
   ENDFOREACH()
 ENDIF(WIN32)

 This fails to find any subdirectories at all.  I've also tried GLOB_RECURSE
 with no change.

 Graham

 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:http://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
  mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] CMake for Windows

2013-06-26 Thread Graham Bloice 
On 26 June 2013 11:07, Roland Knall rkn...@gmail.com wrote:

 Hi

 GLOB and GLOB_RECURSE should normally only catch files, not
 directories. (As noted on
 http://www.cmake.org/cmake/help/v2.8.11/cmake.html#command:file)


Several references found on Google imply that it did return directories as
well despite the docs.  My empirical testing seems to show that it doesn't.


 You should look for ares.h. From the returned path you could deduct
 the directory path with STRING.


I'll try this next.


 Alternativly you could look on google for Findcares.cmake, which will
 get you some matches for other people, who attempted the same thing.
 From there you can either take their hints or create your own version.


I'm hacking in the  Wireshark copy of that file and all the ones I find on
Google are similar.  None of them cater for Windows oddities.

More problematic is finding the library. But you could either use the
 built-in function find_library or use the cmake module
 FindPackageHandleStandardArgs.cmake (Description in the header of the
 file).


Again, it appears that there is nothing in standard CMake to handle the
Windows oddities.  There is an existing bug/enhancement for CMake to add
VPATHS to find_path et al to cater for the version in the path but it
hasn't been progressed since 2010.

My plan was to work out the path under $(PROJECT_LIB_DIR ) for each library
and supply that as HINTS to find_path and find_library.

I believe there's another issue as well, on Windows the linker requires
access to the import library for linking (e.g.
$(PROJECT_LIB_DIR)/c-ares-1.9.1-1-win32ws/lib/libcares-2.lib) and then the
dll should be copied to the output directory to load at run-time
($(PROJECT_LIB_DIR)/c-ares-1.9.1-1-win32ws/lib/libcares-2.dll).

I haven't worked out how CMake handles the import library yet.

Allways try to use as many built-in commands as possible, because even
 something simple as a little foreach and some paths you set may lead
 to cross-compilation mayhem in the future.


I think all the Windows oddities will have to be wrapped in IF(WIN32) or
similar to prevent other breaking CMake on other platforms.


 kind regards,
 Roland

 On Wed, Jun 26, 2013 at 11:35 AM, Graham Bloice
 graham.blo...@trihedral.com wrote:
 
  On 26 June 2013 10:10, Roland Knall rkn...@gmail.com wrote:
 
  Hi
 
  As I am somewhat converse in cmake, I can give you a few pointers, if
 you
  like.
 
  In general for each package a cmake system should look for, a
  FindPackageName.cmake file should exist in either one of two places:
 
  - The local directory (in wireshark underneath
  src/cmake/modules/Find
  - Or the global cmake directory cmake_install_dir/Modules/Find...
 
  Those packages usually comply to a definition, where you can provide a
  searchpath by setting a directory before including the package.
 
  So if you have a CMakeLists.txt with the following context:
 
 
  
  INCLUDE(Findzlib)
  IF(ZLIB_FOUND)
 
 ...
 
  ENDIF(ZLIB_FOUND)
  
 
 
  then you can set a search path by using:
 
  ...
  IF(WIN32)
  SET(ZLIB_INCLUDE_DIRS c:\\wireshark-win32-libs\\zlib125\\include)
  SET(ZLIB_LIBRARY_DIRS c:\\wireshark-win32-libs\\zlib125\\bin
  c:\\wireshark-win32-libs\\zlib125\\lib )
  ENDIF(WIN32)
  INCLUDE(Findzlib)
  
 
  But setting static routes should be avoided, so better set a relative
  path (aka ${PROJECT_BINARY_DIR}/../..) or
  using a system variable.
 
  If you have to call a script, you should do this by using either
  EXECUTE_PROCESS or better create a CUSTOM_TARGET which you can depend
  on, so that the right libraries will allways be downloaded, if they
  cannot be found.
 
  Finally, if you include user-editable scripts, they should start with
  CMake.. and end in .txt. Something like config.CMake should be
  avoided, as it is nmake specific.
 
  kind regards,
  Roland
 
 
  I've been attempting that sort of thing but success eludes me.
 
  Take cares for instance.  The path to the include dir is
  $(PROJECT_LIB_DIR)/c-ares-1.9.1.1-win32ws/include.
 
  I don't want to hard-code the library version suffix so I'd like to get
  CMake to search within $(PROJECT_LIB_DIR) for a directory that begins
  c-ares-.
 
  My current attempt is (with hard-coded paths and debugging messages):
 
  IF (WIN32)
MESSAGE(Searching wireshark libs for c-ares)
FILE(GLOB subdir W:/Wireshark/wireshark-win32-libs/*)
FOREACH(dir $(subdir))
  MESSAGE(Found: $(dir))
  IF(IS_DIRECTORY $(dir))
MESSAGE(Found: $(dir))
IF($(dir) MATCHES ^c-ares-.*)
  SET(CARES_HINTS $(dir))
ENDIF()
  ENDIF()
ENDFOREACH()
  ENDIF(WIN32)
 
  This fails to find any subdirectories at all.  I've also tried
 GLOB_RECURSE
  with no change.
 
  Graham
 
 
 ___
  Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
  Archives:http://www.wireshark.org/lists/wireshark-dev

Re: [Wireshark-dev] CMake for Windows

2013-06-26 Thread Graham Bloice 
On 26 June 2013 11:29, Graham Bloice graham.blo...@trihedral.com wrote:

 On 26 June 2013 11:07, Roland Knall rkn...@gmail.com wrote:

 Hi

 GLOB and GLOB_RECURSE should normally only catch files, not
 directories. (As noted on
 http://www.cmake.org/cmake/help/v2.8.11/cmake.html#command:file)


 Several references found on Google imply that it did return directories as
 well despite the docs.  My empirical testing seems to show that it doesn't.


 You should look for ares.h. From the returned path you could deduct
 the directory path with STRING.


 I'll try this next.


 Alternativly you could look on google for Findcares.cmake, which will
 get you some matches for other people, who attempted the same thing.
 From there you can either take their hints or create your own version.


 I'm hacking in the  Wireshark copy of that file and all the ones I find on
 Google are similar.  None of them cater for Windows oddities.

 More problematic is finding the library. But you could either use the
 built-in function find_library or use the cmake module
 FindPackageHandleStandardArgs.cmake (Description in the header of the
 file).


 Again, it appears that there is nothing in standard CMake to handle the
 Windows oddities.  There is an existing bug/enhancement for CMake to add
 VPATHS to find_path et al to cater for the version in the path but it
 hasn't been progressed since 2010.

 My plan was to work out the path under $(PROJECT_LIB_DIR ) for each
 library and supply that as HINTS to find_path and find_library.

 I believe there's another issue as well, on Windows the linker requires
 access to the import library for linking (e.g.
 $(PROJECT_LIB_DIR)/c-ares-1.9.1-1-win32ws/lib/libcares-2.lib) and then the
 dll should be copied to the output directory to load at run-time
 ($(PROJECT_LIB_DIR)/c-ares-1.9.1-1-win32ws/lib/libcares-2.dll).

 I haven't worked out how CMake handles the import library yet.

 Allways try to use as many built-in commands as possible, because even
 something simple as a little foreach and some paths you set may lead
 to cross-compilation mayhem in the future.


 I think all the Windows oddities will have to be wrapped in IF(WIN32) or
 similar to prevent other breaking CMake on other platforms.



This now works for finding the include path, it appears FILE(GLOB) does
locate dirs, where I was going wrong was with round braces instead of curly
braces when using CMake vars:

IF (WIN32)
  SET(PROJECT_LIB_DIR W:/Wireshark/wireshark-win32-libs)
  FILE(GLOB subdir ${PROJECT_LIB_DIR}/*)
  FOREACH(dir ${subdir})
IF(IS_DIRECTORY ${dir})
  IF(${dir} MATCHES .*/c-ares-.*)
MESSAGE(Found c-ares: ${dir})
SET(CARES_HINTS ${dir})
  ENDIF()
ENDIF()
  ENDFOREACH()
ENDIF(WIN32)

FIND_PATH(CARES_INCLUDE_DIR ares.h HINTS ${CARES_HINTS}/include)

Note that I still had to add the /include suffix to FIND_PATH.  I thought
CMake did that automagically.  Shouldn't be too hard to make a macro
function to do the search for an aribitrary library string.

Next is fixing the FIND_LIBRARY.  I assume it's looking for the import
library to supply to the linker, in this case the library name is
.../lib/libcares-2.lib which is different from the unix name and has a
version number and a different extension.

Graham
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] CMake for Windows

2013-06-25 Thread Joerg Mayer 
Hello Graham,

On Thu, Jun 20, 2013 at 04:55:01PM -0700, Graham Bloice wrote:
 As the starter for some planned major improvements|changes to the win32
 build, I'd like to get CMake working for building Wireshark on Windows.
 
 I know what I'm doing with the nmake builds, and have once built
 successfully on Ubuntu with CMake, but that's about it for my CMake
 knowledge, so I'm looking for support (Joerg?) to do this, so that:

...

I have been under a lot of stress for the last few weeks. Tomorrow I will
go on holiday without laptop or smartphone. I will support you with this
starting the second week in July! Maybe we can meet on #wireshark and you
can help me set up a build environment on Windows 7 ;-)

 Ciao
   Jörg
-- 
Joerg Mayer   jma...@loplof.de
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe