Re: [Wireshark-dev] Feature Request - Comments attached to a packet

2011-08-11 Thread Tyson Key
Hi Alex,

Whilst no-one's looking into implementing support for attaching comments to
packets (as far as I'm aware); someone recently wrote a patch to enable
reading comments from pcap-ng/NTAR files, and attached it to bug #6229.

Tyson.

On 11 August 2011 19:04, Alex Lindberg alind...@yahoo.com wrote:

 Has anyone looked into creating the ability to attach comments to a capture
 file or to a specific packet?

 It would make sharing decode efforts easier.

 Any input would be welcome.

 Alex Lindberg

 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:http://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe




-- 
  Fight Internet Censorship!
http://www.eff.org
http://vmlemon.wordpress.com | Twitter/FriendFeed/Skype: vmlemon |
00447934365844
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Feature Request - Comments attached to a packet

2011-08-11 Thread Tyson Key
Right. Feel free to disregard my previous e-mail, then. :)

Sorry for the inconvenience/false hope,

Tyson.

On 11 August 2011 19:24, Guy Harris g...@alum.mit.edu wrote:


 On Aug 11, 2011, at 11:16 AM, Tyson Key wrote:

  Whilst no-one's looking into implementing support for attaching comments
 to packets (as far as I'm aware); someone recently wrote a patch to enable
 reading comments from pcap-ng/NTAR files, and attached it to bug #6229.

 Actually, that bug sounds more like if a packet has a comment attached to
 it, Wireshark won't even read the packet data correctly; the fix doesn't
 cause Wireshark to process the comment, it just causes it not to screw up if
 a packet *has* a comment.  I.e., we need to fix this before we even consider
 allowing comments to be added to packets, and should backport the fix to the
 1.6 and 1.4 branches (that might still leave older versions of Wireshark
 incapable of reading pcap-ng files with comments attached to them).
 ___
 Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
 Archives:http://www.wireshark.org/lists/wireshark-dev
 Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe




-- 
  Fight Internet Censorship!
http://www.eff.org
http://vmlemon.wordpress.com | Twitter/FriendFeed/Skype: vmlemon |
00447934365844
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe

Re: [Wireshark-dev] Feature Request - Comments attached to a packet

2011-08-11 Thread Guy Harris

On Aug 11, 2011, at 11:16 AM, Tyson Key wrote:

 Whilst no-one's looking into implementing support for attaching comments to 
 packets (as far as I'm aware); someone recently wrote a patch to enable 
 reading comments from pcap-ng/NTAR files, and attached it to bug #6229.

Actually, that bug sounds more like if a packet has a comment attached to it, 
Wireshark won't even read the packet data correctly; the fix doesn't cause 
Wireshark to process the comment, it just causes it not to screw up if a packet 
*has* a comment.  I.e., we need to fix this before we even consider allowing 
comments to be added to packets, and should backport the fix to the 1.6 and 1.4 
branches (that might still leave older versions of Wireshark incapable of 
reading pcap-ng files with comments attached to them).
___
Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org
Archives:http://www.wireshark.org/lists/wireshark-dev
Unsubscribe: https://wireshark.org/mailman/options/wireshark-dev
 mailto:wireshark-dev-requ...@wireshark.org?subject=unsubscribe