Re: [WiX-devs] appsyn feed: documentation
FYI, I believe I've fixed the feed. ___ FireGiant | Dedicated support for the WiX toolset | http://www.firegiant.com/ From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Saturday, July 19, 2014 12:03 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation On 19-Jul-14 14:54, Hoover, Jacob wrote: Yeah, but I have a branch out there for our discussed changes so WixBA uses the engine atom feed parsing. Unfortunately, there are outstanding issues with the existing WiX feed so the engine as is won't accept it (lacking the app id throws out all the possible updates). I'm sure Rob wouldn't mind if you fixed that too. :) You could do a cherry-pick merge, I think. I do wonder why we have a CoreInitialize but not a CoreUninitialize. Pretty sure the standard is to have them only when they're needed. -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
Yeah, I noticed. The web side of things is still a bit cloudy to me, but I did see the fix go in and my mods to WixBA function as expected now. From: Rob Mensching [mailto:r...@firegiant.com] Sent: Sunday, July 20, 2014 1:51 PM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] appsyn feed: documentation FYI, I believe I've fixed the feed. ___ FireGiant | Dedicated support for the WiX toolset | http://www.firegiant.com/ From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Saturday, July 19, 2014 12:03 PM To: wix-devs@lists.sourceforge.netmailto:wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation On 19-Jul-14 14:54, Hoover, Jacob wrote: Yeah, but I have a branch out there for our discussed changes so WixBA uses the engine atom feed parsing. Unfortunately, there are outstanding issues with the existing WiX feed so the engine as is won't accept it (lacking the app id throws out all the possible updates). I'm sure Rob wouldn't mind if you fixed that too. :) You could do a cherry-pick merge, I think. I do wonder why we have a CoreInitialize but not a CoreUninitialize. Pretty sure the standard is to have them only when they're needed. -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
Are we clear on PR 121? On 20-Jul-14 15:17, Hoover, Jacob wrote: Yeah, I noticed. The web side of things is still a bit cloudy to me, but I did see the fix go in and my mods to WixBA function as expected now. *From:*Rob Mensching [mailto:r...@firegiant.com] *Sent:* Sunday, July 20, 2014 1:51 PM *To:* WiX toolset developer mailing list *Subject:* Re: [WiX-devs] appsyn feed: documentation FYI, I believe I've fixed the feed. ___ FireGiant | Dedicated support for the WiX toolset | http://www.firegiant.com/ *From:*Bob Arnson [mailto:b...@joyofsetup.com] *Sent:* Saturday, July 19, 2014 12:03 PM *To:* wix-devs@lists.sourceforge.net mailto:wix-devs@lists.sourceforge.net *Subject:* Re: [WiX-devs] appsyn feed: documentation On 19-Jul-14 14:54, Hoover, Jacob wrote: Yeah, but I have a branch out there for our discussed changes so WixBA uses the engine atom feed parsing. Unfortunately, there are outstanding issues with the existing WiX feed so the engine as is won't accept it (lacking the app id throws out all the possible updates). I'm sure Rob wouldn't mind if you fixed that too. :) You could do a cherry-pick merge, I think. I do wonder why we have a CoreInitialize but not a CoreUninitialize. Pretty sure the standard is to have them only when they're needed. -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
121 depends on 120 (which is what it's based off of). Have you reviewed 120? From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Sunday, July 20, 2014 2:28 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation Are we clear on PR 121? On 20-Jul-14 15:17, Hoover, Jacob wrote: Yeah, I noticed. The web side of things is still a bit cloudy to me, but I did see the fix go in and my mods to WixBA function as expected now. From: Rob Mensching [mailto:r...@firegiant.com] Sent: Sunday, July 20, 2014 1:51 PM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] appsyn feed: documentation FYI, I believe I've fixed the feed. ___ FireGiant | Dedicated support for the WiX toolset | http://www.firegiant.com/ From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Saturday, July 19, 2014 12:03 PM To: wix-devs@lists.sourceforge.netmailto:wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation On 19-Jul-14 14:54, Hoover, Jacob wrote: Yeah, but I have a branch out there for our discussed changes so WixBA uses the engine atom feed parsing. Unfortunately, there are outstanding issues with the existing WiX feed so the engine as is won't accept it (lacking the app id throws out all the possible updates). I'm sure Rob wouldn't mind if you fixed that too. :) You could do a cherry-pick merge, I think. I do wonder why we have a CoreInitialize but not a CoreUninitialize. Pretty sure the standard is to have them only when they're needed. -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.netmailto:WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
Thanks for posting it, (http://wixtoolset.org/releases/feed/v3.9). I will use it as a model to adjust my feed generator. I originally used wix3.7 the model but made changes based on what I could find for specifications and experimenting with the code. One very minor detail is that there is an undefined UI tag in line 35 (the line that says 'WIXBUG:4134 - Add UI ' IE ignores it, and I assume others will as well. -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/appsyn-feed-documentation-tp7595938p7595998.html Sent from the wix-devs mailing list archive at Nabble.com. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
The content is properly escaped: lt;ligt;BobArnson: WIXBUG:4134 - Add lt;UIgt; overrides to WixUI localization for pt-BR.lt;/ligt; -Original Message- From: Phill Hogland [mailto:phogl...@rimage.com] Sent: Sunday, July 20, 2014 2:55 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation Thanks for posting it, (http://wixtoolset.org/releases/feed/v3.9). I will use it as a model to adjust my feed generator. I originally used wix3.7 the model but made changes based on what I could find for specifications and experimenting with the code. One very minor detail is that there is an undefined UI tag in line 35 (the line that says 'WIXBUG:4134 - Add UI ' IE ignores it, and I assume others will as well. -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/appsyn-feed-documentation-tp7595938p7595998.html Sent from the wix-devs mailing list archive at Nabble.com. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
It's properly escaped at the Atom level, but it will be unescaped once (that way the lt;ligt; turns into an HTML li), and at the HTML level you get an undefined UI tag. I think you need to double-escape the UI if you want it to appear as text in the HTML. -- Nicolás 2014-07-20 17:05 GMT-03:00 Hoover, Jacob jacob.hoo...@greenheck.com: The content is properly escaped: lt;ligt;BobArnson: WIXBUG:4134 - Add lt;UIgt; overrides to WixUI localization for pt-BR.lt;/ligt; -Original Message- From: Phill Hogland [mailto:phogl...@rimage.com] Sent: Sunday, July 20, 2014 2:55 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation Thanks for posting it, (http://wixtoolset.org/releases/feed/v3.9). I will use it as a model to adjust my feed generator. I originally used wix3.7 the model but made changes based on what I could find for specifications and experimenting with the code. One very minor detail is that there is an undefined UI tag in line 35 (the line that says 'WIXBUG:4134 - Add UI ' IE ignores it, and I assume others will as well. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
The issue is with 'Add lt;UIgt; overrides' which should be 'Add amp;lt;UIamp;gt; overrides' -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/appsyn-feed-documentation-tp7595938p7596002.html Sent from the wix-devs mailing list archive at Nabble.com. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
Well that did not work. -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/appsyn-feed-documentation-tp7595938p7596003.html Sent from the wix-devs mailing list archive at Nabble.com. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
For what it's worth, I did test it locally in the debugger while skipping over
the appId check and it functions as I expect it to.
In the mean time I did some profiling and found some memory leaks. Shall I
submit a PR based off the WixBAUpdates branch, or should I rebase off of
develop?
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Friday, July 18, 2014 3:12 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
Rob,
In case you want to test your feed changes...
https://github.com/jchoover/wix3/compare/WixBAUpdates?expand=1
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Friday, July 18, 2014 11:57 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
Yes,
And that would satisfy the parser. I haven't' been in the web source until
yesterday, so I'm hoping you can do that fix and PR.
From: Rob Mensching [mailto:r...@firegiant.com]
Sent: Friday, July 18, 2014 11:49 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
The feed is busted. sigh/ In the past the Id was pulled out of the MSI using
a little Jscript. Unfortunately, not as easy to do with Bundles. I think the
straight forward thing to do is add the Bundle/@UpgradeCode as the default
application id for the feed. Does that make sense?
___
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Friday, July 18, 2014 9:31 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
Rob/Bob,
Should I focus on trying to fix the feed or should I make the native parser
more tolerant of the feed that we currently are publishing? I've fixed the
version handling, but the missing application identity is causing the entire
feed to be ignored.
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Thursday, July 17, 2014 4:13 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
Even after fixing this, the new feed doesn't have an application identity which
causes the apuputil ProcessEntry parser to ignore it.
code
// If there is no application identity or no version, skip the whole thing.
if ((!pApupEntry-wzApplicationId !wzDefaultAppId) || !fVersionFound)
{
ExitFunction1(hr = S_FALSE); // skip this update since it has no
application id or version.
}
/code
After that, I found another issue in ApupCalculateChainFromAtom where the chain
happily had nulled entries out in the chain if the feed was missing required
data. I think I have a simple fix for this as well to just ReAlloc at the end
to free the unused memory.
From: Rob Mensching [mailto:r...@firegiant.com]
Sent: Thursday, July 17, 2014 2:20 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
As Burn came along we realized we need to differentiate versions from numbers.
That's why in Burn you put a v in front of numbers that are to be compared as
versions (instead of numbers). That concept kinda' spread.
I think it would be great if FireVersionFromString respected the v concept.
___
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Thursday, July 17, 2014 10:35 AM
To: WiX toolset developer mailing list
Subject: [WiX-devs] appsyn feed: documentation
Rob,
Can you tell me the allowed formats of as:version (or better yet make
available that hidden documentation on the appsyn namespace)? It seems the WiX
feed decided to place a v prefix on the number, and the apuputil is using
FileVersionFromString(pElement-wzValue, dwMajor, dwMinor) which does not
like the v prefix.
Thanks,
Jacob
--
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds___
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
On 19-Jul-14 12:31, Hoover, Jacob wrote: In the mean time I did some profiling and found some memory leaks. Shall I submit a PR based off the WixBAUpdates branch, or should I rebase off of develop? You can probably just merge; there hasn't been that much churn. -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
Yeah, but I have a branch out there for our discussed changes so WixBA uses the engine atom feed parsing. Unfortunately, there are outstanding issues with the existing WiX feed so the engine as is won't accept it (lacking the app id throws out all the possible updates). I do wonder why we have a CoreInitialize but not a CoreUninitialize. From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Saturday, July 19, 2014 1:49 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation On 19-Jul-14 12:31, Hoover, Jacob wrote: In the mean time I did some profiling and found some memory leaks. Shall I submit a PR based off the WixBAUpdates branch, or should I rebase off of develop? You can probably just merge; there hasn't been that much churn. -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
On 19-Jul-14 14:54, Hoover, Jacob wrote: Yeah, but I have a branch out there for our discussed changes so WixBA uses the engine atom feed parsing. Unfortunately, there are outstanding issues with the existing WiX feed so the engine as is won't accept it (lacking the app id throws out all the possible updates). I'm sure Rob wouldn't mind if you fixed that too. :) You could do a cherry-pick merge, I think. I do wonder why we have a CoreInitialize but not a CoreUninitialize. Pretty sure the standard is to have them only when they're needed. -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
Leaks put into their own PR, https://github.com/wixtoolset/wix3/pull/118 From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Saturday, July 19, 2014 2:03 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation On 19-Jul-14 14:54, Hoover, Jacob wrote: Yeah, but I have a branch out there for our discussed changes so WixBA uses the engine atom feed parsing. Unfortunately, there are outstanding issues with the existing WiX feed so the engine as is won't accept it (lacking the app id throws out all the possible updates). I'm sure Rob wouldn't mind if you fixed that too. :) You could do a cherry-pick merge, I think. I do wonder why we have a CoreInitialize but not a CoreUninitialize. Pretty sure the standard is to have them only when they're needed. -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
Merged. Thanks! On 19-Jul-14 15:19, Hoover, Jacob wrote: Leaks put into their own PR, https://github.com/wixtoolset/wix3/pull/118 https://github.com/wixtoolset/wix3/pull/118 *From:*Bob Arnson [mailto:b...@joyofsetup.com] *Sent:* Saturday, July 19, 2014 2:03 PM *To:* wix-devs@lists.sourceforge.net *Subject:* Re: [WiX-devs] appsyn feed: documentation On 19-Jul-14 14:54, Hoover, Jacob wrote: Yeah, but I have a branch out there for our discussed changes so WixBA uses the engine atom feed parsing. Unfortunately, there are outstanding issues with the existing WiX feed so the engine as is won't accept it (lacking the app id throws out all the possible updates). I'm sure Rob wouldn't mind if you fixed that too. :) You could do a cherry-pick merge, I think. I do wonder why we have a CoreInitialize but not a CoreUninitialize. Pretty sure the standard is to have them only when they're needed. -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
Now if only I could cleanup the 63 CRT heap leaks... From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Saturday, July 19, 2014 2:27 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation Merged. Thanks! On 19-Jul-14 15:19, Hoover, Jacob wrote: Leaks put into their own PR, https://github.com/wixtoolset/wix3/pull/118 From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Saturday, July 19, 2014 2:03 PM To: wix-devs@lists.sourceforge.netmailto:wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation On 19-Jul-14 14:54, Hoover, Jacob wrote: Yeah, but I have a branch out there for our discussed changes so WixBA uses the engine atom feed parsing. Unfortunately, there are outstanding issues with the existing WiX feed so the engine as is won't accept it (lacking the app id throws out all the possible updates). I'm sure Rob wouldn't mind if you fixed that too. :) You could do a cherry-pick merge, I think. I do wonder why we have a CoreInitialize but not a CoreUninitialize. Pretty sure the standard is to have them only when they're needed. -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.netmailto:WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
I was concerned when I saw that your branch had 39 memory leaks... Do the 63 leaks start in WiX/Burn? Maybe I'll put the RC2 build through AppVerifier... On 19-Jul-14 15:33, Hoover, Jacob wrote: Now if only I could cleanup the 63 CRT heap leaks... *From:*Bob Arnson [mailto:b...@joyofsetup.com] *Sent:* Saturday, July 19, 2014 2:27 PM *To:* wix-devs@lists.sourceforge.net *Subject:* Re: [WiX-devs] appsyn feed: documentation Merged. Thanks! On 19-Jul-14 15:19, Hoover, Jacob wrote: Leaks put into their own PR, https://github.com/wixtoolset/wix3/pull/118 https://github.com/wixtoolset/wix3/pull/118 *From:*Bob Arnson [mailto:b...@joyofsetup.com] *Sent:* Saturday, July 19, 2014 2:03 PM *To:* wix-devs@lists.sourceforge.net mailto:wix-devs@lists.sourceforge.net *Subject:* Re: [WiX-devs] appsyn feed: documentation On 19-Jul-14 14:54, Hoover, Jacob wrote: Yeah, but I have a branch out there for our discussed changes so WixBA uses the engine atom feed parsing. Unfortunately, there are outstanding issues with the existing WiX feed so the engine as is won't accept it (lacking the app id throws out all the possible updates). I'm sure Rob wouldn't mind if you fixed that too. :) You could do a cherry-pick merge, I think. I do wonder why we have a CoreInitialize but not a CoreUninitialize. Pretty sure the standard is to have them only when they're needed. -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net mailto:WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
Ahh, was meant to be v 3.9 leaks, not indicating the number of leaks. No, all remaining leaks look like they are CRT. Ex: Routine Name Source File Unit Name Source Line Class Name HeapAlloc0 _heap_alloc_base MALLOC.C malloc.obj 47 _nh_malloc_dbg_impl DBGHEAP.Cdbgheap.obj 232 _calloc_dbg_impl DBGHEAP.Cdbgheap.obj 586 _wsetenvp STDENVP.C wstdenvp.obj77 __tmainCRTStartupCRT0.C wwincrt0.obj 171 wWinMainCRTStartup CRT0.C wwincrt0.obj 154 And Routine Name Source File Unit Name Source Line Class Name HeapAlloc0 _heap_alloc_base MALLOC.C malloc.obj 47 _nh_malloc_dbg_impl DBGHEAP.Cdbgheap.obj 232 _calloc_dbg_impl DBGHEAP.Cdbgheap.obj 586 _ioinit IOINIT.C ioinit.obj 110 __tmainCRTStartupCRT0.C wwincrt0.obj 171 wWinMainCRTStartup CRT0.C wwincrt0.obj 154 From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Saturday, July 19, 2014 2:44 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation I was concerned when I saw that your branch had 39 memory leaks... Do the 63 leaks start in WiX/Burn? Maybe I'll put the RC2 build through AppVerifier... On 19-Jul-14 15:33, Hoover, Jacob wrote: Now if only I could cleanup the 63 CRT heap leaks... From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Saturday, July 19, 2014 2:27 PM To: wix-devs@lists.sourceforge.netmailto:wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation Merged. Thanks! On 19-Jul-14 15:19, Hoover, Jacob wrote: Leaks put into their own PR, https://github.com/wixtoolset/wix3/pull/118 From: Bob Arnson [mailto:b...@joyofsetup.com] Sent: Saturday, July 19, 2014 2:03 PM To: wix-devs@lists.sourceforge.netmailto:wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation On 19-Jul-14 14:54, Hoover, Jacob wrote: Yeah, but I have a branch out there for our discussed changes so WixBA uses the engine atom feed parsing. Unfortunately, there are outstanding issues with the existing WiX feed so the engine as is won't accept it (lacking the app id throws out all the possible updates). I'm sure Rob wouldn't mind if you fixed that too. :) You could do a cherry-pick merge, I think. I do wonder why we have a CoreInitialize but not a CoreUninitialize. Pretty sure the standard is to have them only when they're needed. -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.netmailto:WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.netmailto:WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
On 19-Jul-14 15:50, Hoover, Jacob wrote: Ahh, was meant to be v 3.9 leaks, not indicating the number of leaks. I figured it out. Eventually. :) No, all remaining leaks look like they are CRT. Those might be intentional, in that they don't explicitly clean up stuff that goes away at process close. -- sig://boB http://joyofsetup.com/ -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
Rob/Bob,
Should I focus on trying to fix the feed or should I make the native parser
more tolerant of the feed that we currently are publishing? I've fixed the
version handling, but the missing application identity is causing the entire
feed to be ignored.
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Thursday, July 17, 2014 4:13 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
Even after fixing this, the new feed doesn't have an application identity which
causes the apuputil ProcessEntry parser to ignore it.
code
// If there is no application identity or no version, skip the whole thing.
if ((!pApupEntry-wzApplicationId !wzDefaultAppId) || !fVersionFound)
{
ExitFunction1(hr = S_FALSE); // skip this update since it has no
application id or version.
}
/code
After that, I found another issue in ApupCalculateChainFromAtom where the chain
happily had nulled entries out in the chain if the feed was missing required
data. I think I have a simple fix for this as well to just ReAlloc at the end
to free the unused memory.
From: Rob Mensching [mailto:r...@firegiant.com]
Sent: Thursday, July 17, 2014 2:20 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
As Burn came along we realized we need to differentiate versions from numbers.
That's why in Burn you put a v in front of numbers that are to be compared as
versions (instead of numbers). That concept kinda' spread.
I think it would be great if FireVersionFromString respected the v concept.
___
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Thursday, July 17, 2014 10:35 AM
To: WiX toolset developer mailing list
Subject: [WiX-devs] appsyn feed: documentation
Rob,
Can you tell me the allowed formats of as:version (or better yet make
available that hidden documentation on the appsyn namespace)? It seems the WiX
feed decided to place a v prefix on the number, and the apuputil is using
FileVersionFromString(pElement-wzValue, dwMajor, dwMinor) which does not
like the v prefix.
Thanks,
Jacob
--
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds___
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
The feed is busted. sigh/ In the past the Id was pulled out of the MSI using
a little Jscript. Unfortunately, not as easy to do with Bundles. I think the
straight forward thing to do is add the Bundle/@UpgradeCode as the default
application id for the feed. Does that make sense?
___
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Friday, July 18, 2014 9:31 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
Rob/Bob,
Should I focus on trying to fix the feed or should I make the native parser
more tolerant of the feed that we currently are publishing? I've fixed the
version handling, but the missing application identity is causing the entire
feed to be ignored.
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Thursday, July 17, 2014 4:13 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
Even after fixing this, the new feed doesn't have an application identity which
causes the apuputil ProcessEntry parser to ignore it.
code
// If there is no application identity or no version, skip the whole thing.
if ((!pApupEntry-wzApplicationId !wzDefaultAppId) || !fVersionFound)
{
ExitFunction1(hr = S_FALSE); // skip this update since it has no
application id or version.
}
/code
After that, I found another issue in ApupCalculateChainFromAtom where the chain
happily had nulled entries out in the chain if the feed was missing required
data. I think I have a simple fix for this as well to just ReAlloc at the end
to free the unused memory.
From: Rob Mensching [mailto:r...@firegiant.com]
Sent: Thursday, July 17, 2014 2:20 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
As Burn came along we realized we need to differentiate versions from numbers.
That's why in Burn you put a v in front of numbers that are to be compared as
versions (instead of numbers). That concept kinda' spread.
I think it would be great if FireVersionFromString respected the v concept.
___
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Thursday, July 17, 2014 10:35 AM
To: WiX toolset developer mailing list
Subject: [WiX-devs] appsyn feed: documentation
Rob,
Can you tell me the allowed formats of as:version (or better yet make
available that hidden documentation on the appsyn namespace)? It seems the WiX
feed decided to place a v prefix on the number, and the apuputil is using
FileVersionFromString(pElement-wzValue, dwMajor, dwMinor) which does not
like the v prefix.
Thanks,
Jacob
--
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds___
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
Yes,
And that would satisfy the parser. I haven't' been in the web source until
yesterday, so I'm hoping you can do that fix and PR.
From: Rob Mensching [mailto:r...@firegiant.com]
Sent: Friday, July 18, 2014 11:49 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
The feed is busted. sigh/ In the past the Id was pulled out of the MSI using
a little Jscript. Unfortunately, not as easy to do with Bundles. I think the
straight forward thing to do is add the Bundle/@UpgradeCode as the default
application id for the feed. Does that make sense?
___
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Friday, July 18, 2014 9:31 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
Rob/Bob,
Should I focus on trying to fix the feed or should I make the native parser
more tolerant of the feed that we currently are publishing? I've fixed the
version handling, but the missing application identity is causing the entire
feed to be ignored.
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Thursday, July 17, 2014 4:13 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
Even after fixing this, the new feed doesn't have an application identity which
causes the apuputil ProcessEntry parser to ignore it.
code
// If there is no application identity or no version, skip the whole thing.
if ((!pApupEntry-wzApplicationId !wzDefaultAppId) || !fVersionFound)
{
ExitFunction1(hr = S_FALSE); // skip this update since it has no
application id or version.
}
/code
After that, I found another issue in ApupCalculateChainFromAtom where the chain
happily had nulled entries out in the chain if the feed was missing required
data. I think I have a simple fix for this as well to just ReAlloc at the end
to free the unused memory.
From: Rob Mensching [mailto:r...@firegiant.com]
Sent: Thursday, July 17, 2014 2:20 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
As Burn came along we realized we need to differentiate versions from numbers.
That's why in Burn you put a v in front of numbers that are to be compared as
versions (instead of numbers). That concept kinda' spread.
I think it would be great if FireVersionFromString respected the v concept.
___
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Thursday, July 17, 2014 10:35 AM
To: WiX toolset developer mailing list
Subject: [WiX-devs] appsyn feed: documentation
Rob,
Can you tell me the allowed formats of as:version (or better yet make
available that hidden documentation on the appsyn namespace)? It seems the WiX
feed decided to place a v prefix on the number, and the apuputil is using
FileVersionFromString(pElement-wzValue, dwMajor, dwMinor) which does not
like the v prefix.
Thanks,
Jacob
--
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds___
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
I am not sure that I follow the conversation, and I don't confuse the conversation.. The wix 3.7 feed had the following: as:application type=application/vnd.ms-msi3618724B-2523-44F9-A908-866AA619504D/as:application which is the upgrade code. And it had this. application xmlns=http://appsyndication.org/2006/appsyn; type=application/exe975AEB44-64A0-4D52-9BBA-63C9C0342462/application Is the above supposed to be the BundleId (which is not correct for wix 3.7)? The Wix 3.8 feed does not have the above lines. -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/appsyn-feed-documentation-tp7595938p7595970.html Sent from the wix-devs mailing list archive at Nabble.com. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
Rob,
In case you want to test your feed changes...
https://github.com/jchoover/wix3/compare/WixBAUpdates?expand=1
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Friday, July 18, 2014 11:57 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
Yes,
And that would satisfy the parser. I haven't' been in the web source until
yesterday, so I'm hoping you can do that fix and PR.
From: Rob Mensching [mailto:r...@firegiant.com]
Sent: Friday, July 18, 2014 11:49 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
The feed is busted. sigh/ In the past the Id was pulled out of the MSI using
a little Jscript. Unfortunately, not as easy to do with Bundles. I think the
straight forward thing to do is add the Bundle/@UpgradeCode as the default
application id for the feed. Does that make sense?
___
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Friday, July 18, 2014 9:31 AM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
Rob/Bob,
Should I focus on trying to fix the feed or should I make the native parser
more tolerant of the feed that we currently are publishing? I've fixed the
version handling, but the missing application identity is causing the entire
feed to be ignored.
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Thursday, July 17, 2014 4:13 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
Even after fixing this, the new feed doesn't have an application identity which
causes the apuputil ProcessEntry parser to ignore it.
code
// If there is no application identity or no version, skip the whole thing.
if ((!pApupEntry-wzApplicationId !wzDefaultAppId) || !fVersionFound)
{
ExitFunction1(hr = S_FALSE); // skip this update since it has no
application id or version.
}
/code
After that, I found another issue in ApupCalculateChainFromAtom where the chain
happily had nulled entries out in the chain if the feed was missing required
data. I think I have a simple fix for this as well to just ReAlloc at the end
to free the unused memory.
From: Rob Mensching [mailto:r...@firegiant.com]
Sent: Thursday, July 17, 2014 2:20 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
As Burn came along we realized we need to differentiate versions from numbers.
That's why in Burn you put a v in front of numbers that are to be compared as
versions (instead of numbers). That concept kinda' spread.
I think it would be great if FireVersionFromString respected the v concept.
___
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Thursday, July 17, 2014 10:35 AM
To: WiX toolset developer mailing list
Subject: [WiX-devs] appsyn feed: documentation
Rob,
Can you tell me the allowed formats of as:version (or better yet make
available that hidden documentation on the appsyn namespace)? It seems the WiX
feed decided to place a v prefix on the number, and the apuputil is using
FileVersionFromString(pElement-wzValue, dwMajor, dwMinor) which does not
like the v prefix.
Thanks,
Jacob
--
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds___
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
[WiX-devs] appsyn feed: documentation
Rob, Can you tell me the allowed formats of as:version (or better yet make available that hidden documentation on the appsyn namespace)? It seems the WiX feed decided to place a v prefix on the number, and the apuputil is using FileVersionFromString(pElement-wzValue, dwMajor, dwMinor) which does not like the v prefix. Thanks, Jacob -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
And I have also been trying to understand the meaning of GUIDs, such as this from the wix37 feed (maybe it is obsolete). application xmlns=http://appsyndication.org/2006/appsyn; type=application/exe975AEB44-64A0-4D52-9BBA-63C9C0342462/application -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/appsyn-feed-documentation-tp7595938p7595939.html Sent from the wix-devs mailing list archive at Nabble.com. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
I think I just found the answer to my question by snooping in wixtoolset/site/common/layouts/appsyn.feed.jade Did not mean to side-track this thread. -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/appsyn-feed-documentation-tp7595938p7595940.html Sent from the wix-devs mailing list archive at Nabble.com. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
Good catch, though I challenge if as:version= release.title is the right way to do it. The 3.6/3.7 feeds didn't have the v prefix. -Original Message- From: Phill Hogland [mailto:phogl...@rimage.com] Sent: Thursday, July 17, 2014 1:34 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation I think I just found the answer to my question by snooping in wixtoolset/site/common/layouts/appsyn.feed.jade Did not mean to side-track this thread. -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/appsyn-feed-documentation-tp7595938p7595940.html Sent from the wix-devs mailing list archive at Nabble.com. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
As Burn came along we realized we need to differentiate versions from numbers. That's why in Burn you put a v in front of numbers that are to be compared as versions (instead of numbers). That concept kinda' spread. I think it would be great if FireVersionFromString respected the v concept. ___ FireGiant | Dedicated support for the WiX toolset | http://www.firegiant.com/ From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com] Sent: Thursday, July 17, 2014 10:35 AM To: WiX toolset developer mailing list Subject: [WiX-devs] appsyn feed: documentation Rob, Can you tell me the allowed formats of as:version (or better yet make available that hidden documentation on the appsyn namespace)? It seems the WiX feed decided to place a v prefix on the number, and the apuputil is using FileVersionFromString(pElement-wzValue, dwMajor, dwMinor) which does not like the v prefix. Thanks, Jacob -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
The growth of the v prefix didn't happen until really v3.8 since we were just trying to get Burn done in v3.6 and v3.7 was a really tiny release. ___ FireGiant | Dedicated support for the WiX toolset | http://www.firegiant.com/ -Original Message- From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com] Sent: Thursday, July 17, 2014 12:02 PM To: WiX toolset developer mailing list Subject: Re: [WiX-devs] appsyn feed: documentation Good catch, though I challenge if as:version= release.title is the right way to do it. The 3.6/3.7 feeds didn't have the v prefix. -Original Message- From: Phill Hogland [mailto:phogl...@rimage.com] Sent: Thursday, July 17, 2014 1:34 PM To: wix-devs@lists.sourceforge.net Subject: Re: [WiX-devs] appsyn feed: documentation I think I just found the answer to my question by snooping in wixtoolset/site/common/layouts/appsyn.feed.jade Did not mean to side-track this thread. -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/appsyn-feed-documentation-tp7595938p7595940.html Sent from the wix-devs mailing list archive at Nabble.com. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
Actually it did not answer my confusion. The wix37 (which is what I used to model my update design) and wix36 feed files have guid(s) that the wix38 atom does not have. One guid is the update code but I am not clear on what the other one is for. I am not saying that there is any problem, just that I don't understand it and can't tell whether I am creating a problem by having a guid that I don't know what it means. I agree that wix36, and wix37 feeds did not have the v prepended to the version, (which is what I modeled). They do have a v prepended where the version string is part of the title or some other string. My guess is that the version is being set by the string intended for the title. But I really don't know much about what is 'correct' on these issues. -- View this message in context: http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/appsyn-feed-documentation-tp7595938p7595946.html Sent from the wix-devs mailing list archive at Nabble.com. -- Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds ___ WiX-devs mailing list WiX-devs@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-devs
Re: [WiX-devs] appsyn feed: documentation
Even after fixing this, the new feed doesn't have an application identity which
causes the apuputil ProcessEntry parser to ignore it.
code
// If there is no application identity or no version, skip the whole thing.
if ((!pApupEntry-wzApplicationId !wzDefaultAppId) || !fVersionFound)
{
ExitFunction1(hr = S_FALSE); // skip this update since it has no
application id or version.
}
/code
After that, I found another issue in ApupCalculateChainFromAtom where the chain
happily had nulled entries out in the chain if the feed was missing required
data. I think I have a simple fix for this as well to just ReAlloc at the end
to free the unused memory.
From: Rob Mensching [mailto:r...@firegiant.com]
Sent: Thursday, July 17, 2014 2:20 PM
To: WiX toolset developer mailing list
Subject: Re: [WiX-devs] appsyn feed: documentation
As Burn came along we realized we need to differentiate versions from numbers.
That's why in Burn you put a v in front of numbers that are to be compared as
versions (instead of numbers). That concept kinda' spread.
I think it would be great if FireVersionFromString respected the v concept.
___
FireGiant | Dedicated support for the WiX toolset |
http://www.firegiant.com/
From: Hoover, Jacob [mailto:jacob.hoo...@greenheck.com]
Sent: Thursday, July 17, 2014 10:35 AM
To: WiX toolset developer mailing list
Subject: [WiX-devs] appsyn feed: documentation
Rob,
Can you tell me the allowed formats of as:version (or better yet make
available that hidden documentation on the appsyn namespace)? It seems the WiX
feed decided to place a v prefix on the number, and the apuputil is using
FileVersionFromString(pElement-wzValue, dwMajor, dwMinor) which does not
like the v prefix.
Thanks,
Jacob
--
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds___
WiX-devs mailing list
WiX-devs@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-devs
