Re: [Xen-devel] [PATCH for-4.12] iommu: fix order of arguments in iommu_map call at iommu_hwdom_init

2019-01-24 Thread Juergen Gross 
On 24/01/2019 10:49, Jan Beulich wrote:
 On 23.01.19 at 19:08,  wrote:
>> The order of the page_order and the flags parameters are inverted in
>> the call to iommu_map made in iommu_hwdom_init.
>>
>> Fixes: e8afe1124cc1 ("iommu: elide flushing for higher order map/unmap 
>> operations")
>> Signed-off-by: Roger Pau Monné 
> 
> I notice you didn't Cc Jürgen - now done.

Thanks.

Release-acked-by: Juergen Gross 


Juergen

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-4.12] iommu: fix order of arguments in iommu_map call at iommu_hwdom_init

2019-01-24 Thread Jan Beulich 
>>> On 24.01.19 at 10:43,  wrote:
>>  -Original Message-
>> From: Jan Beulich [mailto:jbeul...@suse.com]
>> Sent: 24 January 2019 09:41
>> To: Roger Pau Monne 
>> Cc: Paul Durrant ; xen-devel > de...@lists.xenproject.org>
>> Subject: Re: [PATCH for-4.12] iommu: fix order of arguments in iommu_map
>> call at iommu_hwdom_init
>> 
>> >>> On 23.01.19 at 19:08,  wrote:
>> > The order of the page_order and the flags parameters are inverted in
>> > the call to iommu_map made in iommu_hwdom_init.
>> >
>> > Fixes: e8afe1124cc1 ("iommu: elide flushing for higher order map/unmap
>> operations")
>> > Signed-off-by: Roger Pau Monné 
>> 
>> Reviewed-by: Jan Beulich 
>> 
>> If you don't mind I'd convert to PAGE_ORDER_4K while committing.
> 
> No, I don't think that's correct is it? This code is common, not x86 
> specific and so 4K may not be the base order.

Oh, indeed, right you are.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-4.12] iommu: fix order of arguments in iommu_map call at iommu_hwdom_init

2019-01-24 Thread Jan Beulich 
>>> On 23.01.19 at 19:08,  wrote:
> The order of the page_order and the flags parameters are inverted in
> the call to iommu_map made in iommu_hwdom_init.
> 
> Fixes: e8afe1124cc1 ("iommu: elide flushing for higher order map/unmap 
> operations")
> Signed-off-by: Roger Pau Monné 

I notice you didn't Cc Jürgen - now done.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-4.12] iommu: fix order of arguments in iommu_map call at iommu_hwdom_init

2019-01-24 Thread Paul Durrant 
> -Original Message-
> From: Jan Beulich [mailto:jbeul...@suse.com]
> Sent: 24 January 2019 09:41
> To: Roger Pau Monne 
> Cc: Paul Durrant ; xen-devel  de...@lists.xenproject.org>
> Subject: Re: [PATCH for-4.12] iommu: fix order of arguments in iommu_map
> call at iommu_hwdom_init
> 
> >>> On 23.01.19 at 19:08,  wrote:
> > The order of the page_order and the flags parameters are inverted in
> > the call to iommu_map made in iommu_hwdom_init.
> >
> > Fixes: e8afe1124cc1 ("iommu: elide flushing for higher order map/unmap
> operations")
> > Signed-off-by: Roger Pau Monné 
> 
> Reviewed-by: Jan Beulich 
> 
> If you don't mind I'd convert to PAGE_ORDER_4K while committing.

No, I don't think that's correct is it? This code is common, not x86 specific 
and so 4K may not be the base order.

  Paul

> 
> Jan

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-4.12] iommu: fix order of arguments in iommu_map call at iommu_hwdom_init

2019-01-24 Thread Jan Beulich 
>>> On 23.01.19 at 19:08,  wrote:
> The order of the page_order and the flags parameters are inverted in
> the call to iommu_map made in iommu_hwdom_init.
> 
> Fixes: e8afe1124cc1 ("iommu: elide flushing for higher order map/unmap 
> operations")
> Signed-off-by: Roger Pau Monné 

Reviewed-by: Jan Beulich 

If you don't mind I'd convert to PAGE_ORDER_4K while committing.

Jan


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Xen-devel] [PATCH for-4.12] iommu: fix order of arguments in iommu_map call at iommu_hwdom_init

2019-01-24 Thread Paul Durrant 
> -Original Message-
> From: Roger Pau Monne [mailto:roger@citrix.com]
> Sent: 23 January 2019 18:08
> To: xen-devel@lists.xenproject.org
> Cc: Roger Pau Monne ; Jan Beulich
> ; Paul Durrant 
> Subject: [PATCH for-4.12] iommu: fix order of arguments in iommu_map call
> at iommu_hwdom_init
> 
> The order of the page_order and the flags parameters are inverted in
> the call to iommu_map made in iommu_hwdom_init.
> 
> Fixes: e8afe1124cc1 ("iommu: elide flushing for higher order map/unmap
> operations")
> Signed-off-by: Roger Pau Monné 

Good grief. I was clearly having a bad day.

Reviewed-by: Paul Durrant 

> ---
> Cc: Jan Beulich 
> Cc: Paul Durrant 
> ---
>  xen/drivers/passthrough/iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/drivers/passthrough/iommu.c
> b/xen/drivers/passthrough/iommu.c
> index 98e6fc35e2..acd17ac2dc 100644
> --- a/xen/drivers/passthrough/iommu.c
> +++ b/xen/drivers/passthrough/iommu.c
> @@ -226,7 +226,7 @@ void __hwdom_init iommu_hwdom_init(struct domain *d)
>== PGT_writable_page) )
>  mapping |= IOMMUF_writable;
> 
> -ret = iommu_map(d, _dfn(dfn), _mfn(mfn), mapping, 0,
> +ret = iommu_map(d, _dfn(dfn), _mfn(mfn), 0, mapping,
>  _flags);
> 
>  if ( !rc )
> --
> 2.20.1

___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[Xen-devel] [PATCH for-4.12] iommu: fix order of arguments in iommu_map call at iommu_hwdom_init

2019-01-23 Thread Roger Pau Monne 
The order of the page_order and the flags parameters are inverted in
the call to iommu_map made in iommu_hwdom_init.

Fixes: e8afe1124cc1 ("iommu: elide flushing for higher order map/unmap 
operations")
Signed-off-by: Roger Pau Monné 
---
Cc: Jan Beulich 
Cc: Paul Durrant 
---
 xen/drivers/passthrough/iommu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/drivers/passthrough/iommu.c b/xen/drivers/passthrough/iommu.c
index 98e6fc35e2..acd17ac2dc 100644
--- a/xen/drivers/passthrough/iommu.c
+++ b/xen/drivers/passthrough/iommu.c
@@ -226,7 +226,7 @@ void __hwdom_init iommu_hwdom_init(struct domain *d)
   == PGT_writable_page) )
 mapping |= IOMMUF_writable;
 
-ret = iommu_map(d, _dfn(dfn), _mfn(mfn), mapping, 0,
+ret = iommu_map(d, _dfn(dfn), _mfn(mfn), 0, mapping,
 _flags);
 
 if ( !rc )
-- 
2.20.1


___
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel