Re: [PATCH] os: Add CryptoAPI as a choice of SHA1 implementation
Twas brillig at 02:11:28 26.04.2012 UTC-05 when yselkow...@users.sourceforge.net did gyre and gimble: Y Both Cygwin and MinGW can use Windows' native CryptoAPI for SHA1, Y saving a dependency on libgcrypt or OpenSSL. The necessary functions Y are in ADVAPI32.DLL, which is among the default lib flags and is Y already used in hw/xwin for accessing the registry. Y Signed-off-by: Yaakov Selkowitz yselkow...@users.sourceforge.net Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- pgpiwJWiMSHWl.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PULL to discuss] Remove kdrive, Xnest, and Xvfb
Twas brillig at 22:06:30 26.03.2012 UTC-07 when alan.coopersm...@oracle.com did gyre and gimble: AC While I've heard about this before, I've not seen the sources for this wrapper AC (can someone provide a pointer? all I'm finding in google is man pages bug AC reports that reference it) http://anonscm.debian.org/gitweb/?p=pkg-xorg/debian/xorg.git;a=blob;f=debian/local/xserver-wrapper.c;h=d4a6ab8de82e4a7759994e513f20412c8d3e3cd7;hb=HEAD -- pgpJvvkm3tL2R.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: indent quirks
Twas brillig at 02:44:41 23.03.2012 UTC-07 when jerem...@apple.com did gyre and gimble: JH Is there a way we can tweak indent to not mess up blocks like this: I had to resort to post-processing script recently, exactly for this issue. -- pgpzeQ4QCCPnj.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 5/5] Add dummy return 0 to Xnest Xephyr io error handler for Sun compilers
Twas brillig at 15:08:49 02.12.2011 UTC-08 when alan.coopersm...@oracle.com did gyre and gimble: AC Uses Studio-specific pragma to avoid causing gcc to warn about having AC a redundant prototype for the exit() function. AC Signed-off-by: Alan Coopersmith alan.coopersm...@oracle.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- pgpWUfmUhoMTb.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Xephyr: Remove socket and its lock file on exit
Twas brillig at 12:19:01 10.10.2011 UTC-07 when jerem...@apple.com did gyre and gimble: JH https://bugs.freedesktop.org/show_bug.cgi?id=11484 JH Signed-off-by: Jeremy Huddleston jerem...@apple.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- pgp49UPqO0zl9.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Xnest: Remove socket and its lock file on exit
Twas brillig at 12:19:19 10.10.2011 UTC-07 when jerem...@apple.com did gyre and gimble: JH https://bugs.freedesktop.org/show_bug.cgi?id=11484 JH Signed-off-by: Jeremy Huddleston jerem...@apple.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- pgpC41ofjcsFZ.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: xserver forces 96 DPI on randr-1.2-capable drivers, overriding correct autodetection
Twas brillig at 16:19:29 24.09.2011 UTC+02 when hramr...@centrum.cz did gyre and gimble: [..] Oh, please fork the server already. And the mailing list as well. -- http://fossarchy.blogspot.com/ pgpBRWdREkraA.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH modular] libdrm now requires pciaccess
Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net --- xorg.modules |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/xorg.modules b/xorg.modules index a97ac89..1d53914 100644 --- a/xorg.modules +++ b/xorg.modules @@ -50,6 +50,7 @@ checkoutdir=mesa/drm/ dependencies dep package=macros/ + dep package=libpciaccess/ /dependencies /autotools -- 1.7.2.5 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH modular] libdrm now requires pciaccess
Twas brillig at 20:24:32 24.09.2011 UTC+02 when dotted...@dottedmag.net did gyre and gimble: MG + dep package=libpciaccess/ Please disregard this patch. -- http://fossarchy.blogspot.com/ pgp8D2e5lB95o.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH modular] libdrm now requires pciaccess
Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net --- xorg.modules |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/xorg.modules b/xorg.modules index a97ac89..e3bbde0 100644 --- a/xorg.modules +++ b/xorg.modules @@ -50,6 +50,7 @@ checkoutdir=mesa/drm/ dependencies dep package=macros/ + dep package=libpciaccess/ /dependencies /autotools -- 1.7.2.5 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 4/4] Add a missing search for libdl to configure.ac.
Twas brillig at 21:26:50 08.08.2011 UTC+02 when mc...@redhat.com did gyre and gimble: MC +AC_SEARCH_LIBS([dlopen], [dl]) MC MC # Function dl() comes from the C library or -ldl MC AC_SEARCH_LIBS([dlopen], [dl]) Uhm? -- http://fossarchy.blogspot.com/ pgp7eSsQNkM9m.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 2/5] Use correct swap{l,s} (or none at all for CARD8)
Twas brillig at 16:54:57 05.08.2011 UTC+02 when wha...@bfs.de did gyre and gimble: wh But is this a common problem in network programming ? In X11 client decides the byte order, and server has to deal with what comes over the wire. Most of the protocols have fixed endianess, so they might use htonl and friends. -- http://fossarchy.blogspot.com/ pgpl904ntJZwf.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: Cross Compilation problem in libdmx package.
Twas brillig at 12:14:53 08.07.2011 UTC+05 when ankitgarg...@gmail.com did gyre and gimble: Ag [root@localhost libdmx-1.1.1]# make Building from root? Really? Ag make all-recursive Ag make[1]: Entering directory `/home/ankit/Downloads/X_code/libdmx-1.1.1' Ag Making all in src Ag make[2]: Entering directory `/home/ankit/Downloads/X_code/libdmx-1.1.1/src' Ag CC dmx.lo Ag CCLD libdmx.la Ag /home/toolchain/entone_bcm/bin/mipsel-linux-ar: .libs/libdmx.a: No such file Ag or directory Try to run make V=1 and see what actually happens here. -- http://fossarchy.blogspot.com/ pgpvaW5OSKe6O.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: Howto determine screen geometry?
Twas brillig at 16:19:49 22.05.2011 UTC+02 when s...@bononline.nl did gyre and gimble: SB Isn't it possible to just get that information from the Xserver?? xrandr + awk -- http://fossarchy.blogspot.com/ pgpkvnX3vwpbs.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xserver] config/udev: add input subsystem filter for udev events
Twas brillig at 16:22:22 19.05.2011 UTC+08 when djku...@google.com did gyre and gimble: DK libudev allows adding an efficient in-kernel filter on udev events. DK Since we manually filter for ID_INPUT anyway, it seems reasonable to ask the kernel to send only events for the input subsystem. DK This filtering is performed both for initial device enumeration, and for subsequent udev events. DK Signed-off-by: Daniel Kurtz djku...@google.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpUREHwl3ZpK.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: xorg fbdev support for 8 bits per pixel
Twas brillig at 16:31:58 12.05.2011 UTC+03 when jonathan.mor...@movial.com did gyre and gimble: JM Would it be sufficient to use an 8bpp greyscale framebuffer and simply JM ignore the low-order bits on scanout? That's exactly what OpenInkpot does for 2-3-4-bit-depth grayscale eInk screens. -- http://fossarchy.blogspot.com/ pgpv6H3X3bNfM.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] xf86-video-mga: replace deprecated X*alloc functions
Twas brillig at 20:17:08 02.04.2011 UTC+02 when ni...@nikai.net did gyre and gimble: NK Replace deprecated X*alloc functions. NK Signed-off-by: Nicolas Kaiser ni...@nikai.net Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpBlwY0xfFvl.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH v2 1/2] [libXau] XauGetFileName: added a thread-safe variant of XauFileName
Twas brillig at 13:13:23 31.03.2011 UTC+01 when mark.marsh...@csr.com
did gyre and gimble:
+static const char *
+xau_getenv(const char *name)
+{
+size_t len= 64;
+char *buffer = malloc (len);
+intrc = 0;
+
+while (buffer
+ (rc = getenv_r (name, buffer, len)) == -1
+ errno == ERANGE) {
+len *= 2;
+free (buffer);
+buffer = malloc (len);
+}
+return rc == 0 ? buffer : NULL;
+}
MM There's a (very unlikely) memory leak here.
MM (getenv_r() == -1 and errno != ERANGE)
Actually quite likely:
[ENOENT] The variable name was not found in the environment.
--
http://fossarchy.blogspot.com/
pgpTC7AxRpDSr.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] mi: Remove unused overlay support
The only reference to it in server and free drivers is in XAA overlay code which
would segfault as no miInitOverlay is called ever.
Quoting Jamey Sharp:
It wasn't obvious to me that the patch was correct, because you pretend that
miOverlayCopyUnderlay returns false instead of crashing. But on further
inspection I see that XAACopyWindow8_32 could only set doUnderlay to true if
it's called from miOverlayMoveWindow or miOverlayResizeWindow, which can only be
called if miInitOverlay has hooked those functions, and I can confirm that no
driver or server code calls that.
The only known user of this code is proprietary NVidia driver, and NVidia
developers were notified about this breakage since June of 2010, so there was
enough time to adapt to it by e.g. putting copy of file into driver itself.
Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net
Reviewed-by: Jamey Sharp ja...@minilop.net
---
hw/xfree86/loader/sdksyms.sh |1 -
hw/xfree86/xaa/xaaOverlay.c | 29 +-
mi/Makefile.am |4 +-
mi/mioverlay.c | 1946 --
mi/mioverlay.h | 32 -
5 files changed, 2 insertions(+), 2010 deletions(-)
delete mode 100644 mi/mioverlay.c
delete mode 100644 mi/mioverlay.h
diff --git a/hw/xfree86/loader/sdksyms.sh b/hw/xfree86/loader/sdksyms.sh
index 18bb735..0670f4e 100755
--- a/hw/xfree86/loader/sdksyms.sh
+++ b/hw/xfree86/loader/sdksyms.sh
@@ -227,7 +227,6 @@ cat sdksyms.c EOF
#include miwideline.h
#include mistruct.h
#include mifpoly.h
-#include mioverlay.h
/* randr/Makefile.am */
diff --git a/hw/xfree86/xaa/xaaOverlay.c b/hw/xfree86/xaa/xaaOverlay.c
index 4b52bf6..58c4a58 100644
--- a/hw/xfree86/xaa/xaaOverlay.c
+++ b/hw/xfree86/xaa/xaaOverlay.c
@@ -16,7 +16,6 @@
#include xaawrap.h
#include gcstruct.h
#include pixmapstr.h
-#include mioverlay.h
#ifdef PANORAMIX
#include panoramiX.h
@@ -37,7 +36,6 @@ XAACopyWindow8_32(
ScreenPtr pScreen = pWin-drawable.pScreen;
XAAInfoRecPtr infoRec =
GET_XAAINFORECPTR_FROM_DRAWABLE((pWin-drawable));
-Bool doUnderlay = miOverlayCopyUnderlay(pScreen);
RegionPtr borderClip = pWin-borderClip;
Bool freeReg = FALSE;
@@ -56,9 +54,6 @@ XAACopyWindow8_32(
pwinRoot = pScreen-root;
-if(doUnderlay)
- freeReg = miOverlayCollectUnderlayRegions(pWin, borderClip);
-
RegionNull(rgnDst);
dx = ptOldOrg.x - pWin-drawable.x;
@@ -81,7 +76,7 @@ XAACopyWindow8_32(
ppt++; pbox++;
}
-infoRec-ScratchGC.planemask = doUnderlay ? 0x00ff : 0xff00;
+infoRec-ScratchGC.planemask = 0xff00;
infoRec-ScratchGC.alu = GXcopy;
XAADoBitBlt((DrawablePtr)pwinRoot, (DrawablePtr)pwinRoot,
@@ -93,25 +88,6 @@ XAACopyWindow8_32(
RegionDestroy(borderClip);
}
-static void
-XAASetColorKey8_32(
-ScreenPtr pScreen,
-int nbox,
-BoxPtr pbox
-){
-XAAInfoRecPtr infoRec = GET_XAAINFORECPTR_FROM_SCREEN(pScreen);
-ScrnInfoPtr pScrn = infoRec-pScrn;
-
-/* I'm counting on writes being clipped away while switched away.
- If this isn't going to be true then I need to be wrapping instead. */
-if(!infoRec-pScrn-vtSema) return;
-
-(*infoRec-FillSolidRects)(pScrn, pScrn-colorKey 24, GXcopy,
- 0xff00, nbox, pbox);
-
-SET_SYNC_FLAG(infoRec);
-}
-
void
XAASetupOverlay8_32Planar(ScreenPtr pScreen)
{
@@ -120,9 +96,6 @@ XAASetupOverlay8_32Planar(ScreenPtr pScreen)
pScreen-CopyWindow = XAACopyWindow8_32;
-if(!(infoRec-FillSolidRectsFlags NO_PLANEMASK))
- miOverlaySetTransFunction(pScreen, XAASetColorKey8_32);
-
infoRec-FullPlanemask = ~0;
for(i = 0; i 32; i++) /* haven't thought about this much */
infoRec-FullPlanemasks[i] = ~0;
diff --git a/mi/Makefile.am b/mi/Makefile.am
index 96ceeaa..3d1152e 100644
--- a/mi/Makefile.am
+++ b/mi/Makefile.am
@@ -3,7 +3,7 @@ noinst_LTLIBRARIES = libmi.la
if XORG
sdk_HEADERS = micmap.h miline.h mipointer.h mi.h mibstore.h \
migc.h mipointrst.h mizerarc.h micoord.h mifillarc.h \
- mispans.h miwideline.h mistruct.h mifpoly.h mioverlay.h
+ mispans.h miwideline.h mistruct.h mifpoly.h
endif
AM_CFLAGS = $(DIX_CFLAGS)
@@ -31,8 +31,6 @@ libmi_la_SOURCES =\
migc.h \
miglblt.c \
miline.h\
- mioverlay.c \
- mioverlay.h \
mipointer.c \
mipointer.h \
mipointrst.h\
diff --git a/mi/mioverlay.c b/mi/mioverlay.c
deleted file mode 100644
index 766c5e7..000
--- a/mi/mioverlay.c
+++ /dev/null
@@ -1,1946 +0,0 @@
-
-#ifdef HAVE_DIX_CONFIG_H
-#include dix-config.h
-#endif
-
-#include X11/X.h
-#include scrnintstr.h
-#include X11/extensions/shapeproto.h
-#include validate.h
-#include windowstr.h
-#include mi.h
-#include gcstruct.h
-#include regionstr.h
-#include privates.h
-#include mivalidate.h
-#include mioverlay.h
-#include
Re: [PATCH] mi: Remove unused overlay support
Twas brillig at 09:26:19 29.03.2011 UTC-07 when aplatt...@nvidia.com did gyre and gimble: AP NAK. This code is not NVIDIA-specific just because only the NVIDIA AP driver currently uses it. I did not claim it. I just said it's unused. AP We can move it into the driver if you really think it's necessary, AP but from a software design standpoint it's the wrong thing to do. Keeping unused code in mi is wrong from software engineering standpoint as well. Quoting IRC: keithp airlied: I thought mga was using mioverlay airlied keithp: no I think its been gutted keithp sweet! keithp sounds like it's time to nuke it then airlied the old patch in-tree still works airlied dottedmag: feel like resubmitting it? AP It's ironic that I'm the one arguing to keep our driver less AP proprietary. Why not bundle mioverlay.c beside the driver with MIT license attached then? It makes no differene if some driver would ever start use it by pulling back in server, but it won't clutter mi until then. -- http://fossarchy.blogspot.com/ pgp8qG4Qd8Cem.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] dix: remove unused debug code
Twas brillig at 11:56:08 28.03.2011 UTC+02 when mark.kette...@xs4all.nl did gyre and gimble: MK I guess what I mean is that somebody took the time to write that code, MK so presumable it served a purpose. It may very well be that that MK purpose is no longer there. MK But I'd expect that only somebody who recently hacked on the font MK code can make that judgement. This code is introduced by commit commit d568221710959cf7d783e6ff0fb80fb43a231124 Author: Kaleb Keithley ka...@freedesktop.org Date: Fri Nov 14 16:49:22 2003 + XFree86 4.3.0.1 And has not changed since, beside xalloc-malloc conversion. So it quite probably serves no particular purpose anymore, aside from being quite silly and probably belonging to local dev's tree, not to the public one. 2Tiago: Kill it with fire, please. R-b from me. -- http://fossarchy.blogspot.com/ pgpGmD27m0O53.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH util/macros] Add sed pattern for __xorgconfd__ (xorg.conf.d).
Twas brillig at 10:53:54 18.03.2011 UTC+10 when peter.hutte...@who-t.net did gyre and gimble: The Xorg xorg.conf substitutions are leftover from the transitional period where some distros were building our sources with the XFree86 and XF86config names until they had time to adjust the rest of their packages/installer/config code to the new names. PH probably not, I'm fine either way but right now the man pages have PH text like blah blah __xconfigfile__ or xorg.conf.d which is a bit PH asymmetrical. So why not fix it to by symmetrical in other way 'round, by substituting __xconfigfile__ back? -- http://fossarchy.blogspot.com/ pgpzOzUszfZEq.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xinit] xcb port of xinit. Unsure of correctness in removing error handling in shutdown
Twas brillig at 22:59:49 10.03.2011 UTC+00 when gunkm...@gmail.com did gyre and
gimble:
FYI: I've got similar patch (not submitted upstream as it broke
Xfree86_VT functionality here:
http://git.iplinux.org/xinit.git/commit/?id=9bae70664b1dfb2731fc6ceaab6dbf1b7acaf783
DR Signed-off-by: Demur Rumed gunkm...@gmail.com
DR ---
DR configure.ac |6 ++--
DR xinit.c | 95
+++---
DR 2 files changed, 47 insertions(+), 54 deletions(-)
DR diff --git a/configure.ac b/configure.ac
DR index 67214cb..2a9d5da 100644
DR --- a/configure.ac
DR +++ b/configure.ac
DR @@ -1,5 +1,5 @@
DR dnl Copyright 2005 Red Hat, Inc.
DR -dnl
DR +dnl
Please don't mix whitespace and semantic changes in single patch.
DR dnl Permission to use, copy, modify, distribute, and sell this software
and its
DR dnl documentation for any purpose is hereby granted without fee,
provided that
DR dnl the above copyright notice appear in all copies and that both that
DR @@ -9,7 +9,7 @@ dnl advertising or publicity pertaining to distribution
of the software without
DR dnl specific, written prior permission. Red Hat makes no
DR dnl representations about the suitability of this software for any
purpose. It
DR dnl is provided as is without express or implied warranty.
DR -dnl
DR +dnl
DR dnl RED HAT DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE,
DR dnl INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS, IN
NO
DR dnl EVENT SHALL RED HAT BE LIABLE FOR ANY SPECIAL, INDIRECT OR
DR @@ -134,7 +134,7 @@ AM_CONDITIONAL(LAUNCHD, [test x$LAUNCHD = xyes])
DR AM_CONDITIONAL(TIGER_LAUNCHD, [test x$TIGER_LAUNCHD = xyes])
DR
DR # Checks for pkg-config packages
DR -PKG_CHECK_MODULES(XINIT, x11)
DR +PKG_CHECK_MODULES(XINIT, xcb)
DR
DR case $host_os in
DR *bsd*)
DR diff --git a/xinit.c b/xinit.c
DR index 42ff008..8e50d78 100644
DR --- a/xinit.c
DR +++ b/xinit.c
DR @@ -28,9 +28,8 @@ in this Software without prior written authorization
from The Open Group.
DR # include config.h
DR #endif
DR
DR -#include X11/Xlib.h
DR +#include xcb/xcb.h
DR #include X11/Xos.h
DR -#include X11/Xatom.h
DR #include stdio.h
DR #include ctype.h
DR #include stdint.h
DR @@ -38,7 +37,6 @@ in this Software without prior written authorization
from The Open Group.
DR #include signal.h
DR #include sys/wait.h
DR #include errno.h
DR -#include setjmp.h
DR #include stdarg.h
DR
DR #ifdef __APPLE__
DR @@ -101,18 +99,17 @@ static char **server = serverargv + 2;/* make
sure room for sh .xserverr
DR static char **client = clientargv + 2;/* make sure room for sh
.xinitrc args */
DR static char *displayNum = NULL;
DR static char *program = NULL;
DR -static Display *xd = NULL;/* server connection */
DR +static xcb_connection_t *xd = NULL;/* server connection */
DR int status;
DR int serverpid = -1;
DR int clientpid = -1;
DR volatile int gotSignal = 0;
DR
DR static void Execute(char **vec);
DR -static Bool waitforserver(void);
DR -static Bool processTimeout(int timeout, char *string);
DR +static int waitforserver(void);
DR +static int processTimeout(int timeout, char *string);
DR static int startServer(char *server[]);
DR static int startClient(char *client[]);
DR -static int ignorexio(Display *dpy);
DR static void shutdown(void);
DR static void set_environment(void);
DR
DR @@ -134,13 +131,13 @@ sigIgnore(int sig)
DR }
DR
DR static void
DR -Execute(char **vec)/* has room from up above */
DR +Execute(char **vec)/* has room from up above */
Ditto.
DR {
DR execvp(vec[0], vec);
DR if (access(vec[0], R_OK) == 0) {
DR -vec--;/* back it up to stuff
shell in */
DR -vec[0] = SHELL;
DR -execvp(vec[0], vec);
DR +vec--;/* back it up to stuff shell in */
DR +vec[0] = SHELL;
DR +execvp(vec[0], vec);
Ditto.
DR }
DR return;
DR }
DR @@ -215,12 +212,12 @@ main(int argc, char *argv[])
DR */
DR if (!client_given) {
DR char *cp;
DR -Bool required = False;
DR +int required = FALSE;
Where does this FALSE come from? xcb? Why not bool / true / false with
autoconf check?
DR
DR xinitrcbuf[0] = '\0';
DR if ((cp = getenv(XINITRC)) != NULL) {
DR snprintf(xinitrcbuf, sizeof(xinitrcbuf), %s, cp);
DR -required = True;
DR +required = TRUE;
DR } else if ((cp = getenv(HOME)) != NULL) {
DR snprintf(xinitrcbuf, sizeof(xinitrcbuf),
DR %s/%s, cp, XINITRC);
DR @@ -241,12 +238,12 @@ main(int argc, char *argv[])
DR */
DR if (!server_given) {
DR char *cp;
DR -Bool required = False;
DR +int required = FALSE;
DR
DR xserverrcbuf[0]
Re: [PATCH] XDM: Fix FTBFS with gold or recent gcc releases.
Twas brillig at 09:19:24 19.02.2011 UTC-08 when alan.coopersm...@oracle.com did gyre and gimble: AC Neither of those explain what FTBFS means. fails to build from source. First result of google://FTBFS gives you this answer, by the way. -- http://fossarchy.blogspot.com/ pgp9cZHbBy8yi.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 0/6] Move main() from DIX to DDXen
Twas brillig at 14:20:35 17.01.2011 UTC+00 when jon.tur...@dronecode.org.uk did gyre and gimble: JT Jon TURNEY (6): JT Move main() from dix to ddx JT Replace DDXBEFORERESET with a more general way of doing DDX-specific JT hooks JT Add a DDX specific GLX provider push hook JT Add a DDX specific hook into miPaintWindow for DDXen which support JT the rootless extension JT Make building XWin with WINDOWSWM and ROOTLESS mandatory JT Revert libmain.a Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpMVEZP60QYN.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH:libICE] Fix stdio.h include for asprintf.
Twas brillig at 18:43:49 19.12.2010 UTC+01 when k...@debian.org did gyre and gimble: CB asprintf is a GNU extension and one needs to define _GNU_SOURCE before CB including stdio.h. Otherwise, the build breaks this way with CB CFLAGS=-Wall -Werror: CB | CC process.lo CB | cc1: warnings being treated as errors CB | process.c: In function ‘ProcessError’: CB | process.c:672: error: implicit declaration of function ‘asprintf’ CB | process.c:672: error: nested extern declaration of ‘asprintf’ CB | make[2]: *** [process.lo] Error 1 CB Signed-off-by: Cyril Brulebois k...@debian.org Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpK5FGeLrSb0.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 2/2] xfree86: Remove the teeth from SIGIO input processing
Twas brillig at 12:52:54 13.12.2010 UTC-05 when a...@redhat.com did gyre and gimble: AJ Instead of actually processing input in the handler, raise just enough AJ of a dispatch exception to bomb out of request processing and handle input AJ instead. This gets us back to exactly two input processing methods: AJ - input thread AJ - main loop dispatch AJ where the SIGIO handler is merely an optimization for the second case. AJ Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpA5qKji3aPZ.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH v4 0/7] Xprintf - asprintf
Twas brillig at 12:14:34 04.12.2010 UTC-08 when alan.coopersm...@oracle.com did gyre and gimble: AC [PATCH v4 1/7] Sun's copyrights now belong to Oracle AC [PATCH v4 2/7] Add asprintf() implementation for platforms without it AC [PATCH v4 3/7] Convert existing Xprintf style calls to asprintf style AC [PATCH v4 4/7] Convert hw/xfree86/parser code to use asprintf() calls AC [PATCH v4 5/7] Convert alloc+sprintf pairs into asprintf() XNFasprintf() calls AC [PATCH v4 6/7] Replace alloc+strcpy+strcat with asprintf() XNFasprintf() calls AC [PATCH v4 7/7] Convert cvt code to use XNFasprintf() For the series: Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpwrPNS7iLPo.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 1/6 v2] Add X*asprintf() routines to mirror common asprintf() routines
Twas brillig at 10:42:56 01.12.2010 UTC-08 when kei...@keithp.com did gyre and gimble: Provides a portable implementation of this common allocating sprintf() API found in many, but not yet all, of the platforms we support. If the platform provides vasprintf() we simply wrap it, otherwise we implement it - either way callers can use it regardless of platform. KP I didn't see any closure to my question as to whether we should just be KP exporting these as 'asprintf' et al., instead of creating a new name. Also should those be exported at all. Is X server still an OS? :) -- http://fossarchy.blogspot.com/ pgp2465mlMclE.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 00/11] Xasprintf() and other string-handling cleanups
Twas brillig at 20:57:37 29.11.2010 UTC-08 when alan.coopersm...@oracle.com did gyre and gimble: AC The meat of this series is sandwiched right in the middle - patch AC #6 replaces the nifty, but unique, Xprintf() API with a local AC implementation of the asprintf() family that's becoming widely AC adopted (found in recent versions of the GNU, FreeBSD, NetBSD, AC OpenBSD, Solaris libc's, but not yet in all the versions AC platforms we still support). Is there particular reason why local implementation of asprintf/vasprintf have to have X prefix? Why not define them as plain asprintf/vasprintf from the beginning? (XNF has to stay, sigh). If this issue is resolved (see also additional nitpick in patch 06) Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpV6VmA50iTi.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 06/11] Add X*asprintf() routines to mirror common asprintf() routines
Twas brillig at 20:57:43 29.11.2010 UTC-08 when alan.coopersm...@oracle.com did gyre and gimble: AC +#ifndef XPRINTF_H AC +#define XPRINTF_H AC + AC +#include stdarg.h AC +#include X11/Xfuncproto.h AC + AC +#ifndef _X_RESTRICT_KYWD AC +# if defined(restrict) /* assume autoconf set it correctly */ || \ AC + (defined(__STDC__) (__STDC_VERSION__ - 0 = 199901L)) /* C99 */ AC +# define _X_RESTRICT_KYWD restrict AC +# elif defined(__GNUC__) !defined(__STRICT_ANSI__) /* gcc w/C89+extensions */ AC +# define _X_RESTRICT_KYWD __restrict__ AC +# else AC +# define _X_RESTRICT_KYWD AC +# endif AC +#endif Maybe this is a material for Xfuncproto.h? -- http://fossarchy.blogspot.com/ pgpO1IFN13zDg.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH keyboard] Small cleanup.
Twas brillig at 15:36:36 30.11.2010 UTC+05 when alexandr.shadc...@gmail.com did gyre and gimble: AS Removed unnecessary code: AS case PCCONS: AS break; Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpt3POqPhEKv.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH RESEND app-xdm 0/9] Review xdm configuration - Part 4
Twas brillig at 10:32:10 22.11.2010 UTC-05 when mems...@videotron.ca did gyre and gimble: GN This set reworks selinux, pam, arc4random and dev/random GN consistently using pre-searched system libs in $LIBS. Comment and GN relocate some config fragments. For the series: Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpwHQklLOShP.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Extract LogFinishInit from LogInit
Twas brillig at 20:53:40 08.11.2010 UTC+01 when k...@debian.org did gyre and
gimble:
diff --git a/os/log.c b/os/log.c
[…]
+void
+LogFinishInit(void)
+{
+if (saveBuffer) {
+free(saveBuffer);/* Must be free(), not free() */
CB
CB That probably can go away, see 3f3ff971.
Right, as well as if (saveBuffer).
--
http://fossarchy.blogspot.com/
pgph21dZa7j7n.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: Location of X resource protocol description
Twas brillig at 16:30:06 01.11.2010 UTC+02 when rami.ylim...@vincit.fi did gyre and gimble: RY Is there such thing as X resource extension protocol description RY document anywhere? I'm planning to amend the document with some RY queries for client PIDs and resource sizes. However, I can't find RY the documentation from http://www.x.org/docs/ or RY http://cgit.freedesktop.org/xorg/proto/resourceproto/tree/. I'd RY like to work on top of an existing document if it exists. Looks like there is no existing document. -- http://fossarchy.blogspot.com/ pgpeJUL1PGDw4.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: Delete a bunch of unused stuff in fb
Twas brillig at 22:40:37 01.11.2010 UTC-04 when sandm...@daimi.au.dk did gyre and gimble: SS These patches delete a bunch of stuff in fb that has not been used SS since compositing moved to pixman. Most of it has survived only SS because breaking the server ABI was not allowed at the time. For the series: Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpH5ww0hxZWL.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[OT] Server size (Was: Re: [PATCH 01/15] os: remove superfluous -br option)
Twas brillig at 08:37:38 28.10.2010 UTC-07 when alan.coopersm...@oracle.com did gyre and gimble: AC The cost of removal is simply far far higher than the cost of keeping AC it - all removal buys us is removing 2 lines of code out of a million, ~500 kLOC actually already (It was ~1MLOC in 1.1 -- nice shrinkage, I think). -- http://fossarchy.blogspot.com/ pgp5HyWq6IAiM.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] [RFC] xinerama: attempt to unify the two protocol implementations.
Twas brillig at 16:41:32 27.10.2010 UTC+03 when tiago.vigna...@nokia.com did gyre and gimble: TV well, to have two extensions tied like that doesn't sound like a reasonable TV design... Having two extensions designed like that doesn't sound like a reasonable design, but we're stuck with them. -- http://fossarchy.blogspot.com/ pgpXUBIxnQTjH.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH libXt] remove strcmp
Twas brillig at 13:48:53 26.10.2010 UTC+02 when wha...@bfs.de did gyre and gimble: wh make remainder check like in the rest of code and replace strcmp() wh Signed-off-by: walter harms wha...@bfs.de Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpIKmEghf2dx.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH 2/3] Replace if(buf) realloc(buf, size) else malloc(size) with realloc()
Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net
---
os/log.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/os/log.c b/os/log.c
index 3435da6..94f76aa 100644
--- a/os/log.c
+++ b/os/log.c
@@ -305,10 +305,7 @@ LogVWrite(int verb, const char *f, va_list args)
if (len bufferUnused) {
bufferSize += 1024;
bufferUnused += 1024;
- if (saveBuffer)
- saveBuffer = realloc(saveBuffer, bufferSize);
- else
- saveBuffer = malloc(bufferSize);
+saveBuffer = realloc(saveBuffer, bufferSize);
if (!saveBuffer)
FatalError(realloc() failed while saving log messages\n);
}
--
1.7.1
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH 1/3] Remove now-misleading comment
Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net
---
os/log.c |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/os/log.c b/os/log.c
index ee4b45f..3435da6 100644
--- a/os/log.c
+++ b/os/log.c
@@ -302,10 +302,6 @@ LogVWrite(int verb, const char *f, va_list args)
#endif
}
} else if (needBuffer) {
- /*
-* Note, this code is used before OsInit() has been called, so
-* malloc() and friends can't be used.
-*/
if (len bufferUnused) {
bufferSize += 1024;
bufferUnused += 1024;
--
1.7.1
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH 3/3] Remove now-misleading comment
Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net
---
os/log.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/os/log.c b/os/log.c
index 94f76aa..f5dfdbf 100644
--- a/os/log.c
+++ b/os/log.c
@@ -177,7 +177,6 @@ LogInit(const char *fname, const char *backup)
char *logFileName = NULL;
if (fname *fname) {
- /* malloc() can't be used yet. */
logFileName = malloc(strlen(fname) + strlen(display) + 1);
if (!logFileName)
FatalError(Cannot allocate space for the log file name\n);
--
1.7.1
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] Extract LogFinishInit from LogInit
This change makes logging initialization a bit less obscure.
Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net
---
include/os.h |1 +
os/log.c | 29 +++--
os/osinit.c |8 +---
3 files changed, 21 insertions(+), 17 deletions(-)
diff --git a/include/os.h b/include/os.h
index efa202c..2c63491 100644
--- a/include/os.h
+++ b/include/os.h
@@ -526,6 +526,7 @@ typedef enum {
} MessageType;
extern _X_EXPORT const char *LogInit(const char *fname, const char *backup);
+extern void LogFinishInit(void);
extern _X_EXPORT void LogClose(void);
extern _X_EXPORT Bool LogSetParameter(LogParameter param, int value);
extern _X_EXPORT void LogVWrite(int verb, const char *f, va_list args);
diff --git a/os/log.c b/os/log.c
index f5dfdbf..52bb4aa 100644
--- a/os/log.c
+++ b/os/log.c
@@ -163,9 +163,21 @@ asm (.desc ___crashreporter_info__, 0x10);
#endif
/*
- * LogInit is called to start logging to a file. It is also called (with
- * NULL arguments) when logging to a file is not wanted. It must always be
- * called, otherwise log messages will continue to accumulate in a buffer.
+ * Dicard buffered log messages (if any) and stop further buffering.
+ */
+void
+LogFinishInit(void)
+{
+if (saveBuffer) {
+ free(saveBuffer); /* Must be free(), not free() */
+ saveBuffer = NULL;
+}
+bufferSize = 0;
+needBuffer = FALSE;
+}
+
+/*
+ * LogInit is called to start logging to a file.
*
* %s, if present in the fname or backup strings, is expanded to the display
* string.
@@ -218,17 +230,6 @@ LogInit(const char *fname, const char *backup)
}
}
-/*
- * Unconditionally free the buffer, and flag that the buffer is no longer
- * needed.
- */
-if (saveBuffer bufferSize 0) {
- free(saveBuffer); /* Must be free(), not free() */
- saveBuffer = NULL;
- bufferSize = 0;
-}
-needBuffer = FALSE;
-
return logFileName;
}
diff --git a/os/osinit.c b/os/osinit.c
index c83c32c..0d409e2 100644
--- a/os/osinit.c
+++ b/os/osinit.c
@@ -300,11 +300,13 @@ OsInit(void)
}
TimerInit();
OsVendorInit();
+
/*
- * No log file by default. OsVendorInit() should call LogInit() with the
- * log file name if logging to a file is desired.
+ * This call will disable further buffering of log messages. DDX should
have
+ * initialized logging in OsVendorInit already.
*/
-LogInit(NULL, NULL);
+LogFinishInit();
+
SmartScheduleInit ();
}
--
1.7.1
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xf86-video-trident 1/2] Convert x+m/calloc/free to m/calloc/free.
Twas brillig at 21:04:53 22.10.2010 UTC-04 when twoer...@gmail.com did gyre and
gimble:
TW From: Trevor Woerner twoer...@gmail.com
Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net
TW Signed-off-by: Trevor Woerner twoer...@gmail.com
TW ---
TW src/trident_dga.c|6 +++---
TW src/trident_driver.c | 20 ++--
TW src/trident_video.c | 26 +-
TW 3 files changed, 26 insertions(+), 26 deletions(-)
TW diff --git a/src/trident_dga.c b/src/trident_dga.c
TW index 78fa8f4..dd836a6 100644
TW --- a/src/trident_dga.c
TW +++ b/src/trident_dga.c
TW @@ -83,15 +83,15 @@ TRIDENTDGAInit(ScreenPtr pScreen)
TW while(pMode) {
TW
TW if(0 /*pScrn-displayWidth != pMode-HDisplay*/) {
TW -newmodes = xrealloc(modes, (num + 2) * sizeof(DGAModeRec));
TW +newmodes = realloc(modes, (num + 2) * sizeof(DGAModeRec));
TW oneMore = TRUE;
TW } else {
TW -newmodes = xrealloc(modes, (num + 1) * sizeof(DGAModeRec));
TW +newmodes = realloc(modes, (num + 1) * sizeof(DGAModeRec));
TW oneMore = FALSE;
TW }
TW
TW if(!newmodes) {
TW - xfree(modes);
TW + free(modes);
TW return FALSE;
TW }
TW modes = newmodes;
TW diff --git a/src/trident_driver.c b/src/trident_driver.c
TW index 31cbb83..ecf99f0 100644
TW --- a/src/trident_driver.c
TW +++ b/src/trident_driver.c
TW @@ -560,7 +560,7 @@ TRIDENTFreeRec(ScrnInfoPtr pScrn)
TW {
TW if (pScrn-driverPrivate == NULL)
TW return;
TW -xfree(pScrn-driverPrivate);
TW +free(pScrn-driverPrivate);
TW pScrn-driverPrivate = NULL;
TW }
TW
TW @@ -900,7 +900,7 @@ TRIDENTProbe(DriverPtr drv, int flags)
TW foundScreen = TRUE;
TW }
TW }
TW -xfree(usedChips);
TW +free(usedChips);
TW }
TW }
TW
TW @@ -933,11 +933,11 @@ TRIDENTProbe(DriverPtr drv, int flags)
TW foundScreen = TRUE;
TW }
TW }
TW -xfree(usedChips);
TW +free(usedChips);
TW }
TW #endif
TW
TW -xfree(devSections);
TW +free(devSections);
TW return foundScreen;
TW }
TW
TW @@ -1163,7 +1163,7 @@ TRIDENTPreInit(ScrnInfoPtr pScrn, int flags)
TW xf86CollectOptions(pScrn, NULL);
TW
TW /* Process the options */
TW -if (!(pTrident-Options = xalloc(sizeof(TRIDENTOptions
TW +if (!(pTrident-Options = malloc(sizeof(TRIDENTOptions
TW return FALSE;
TW memcpy(pTrident-Options, TRIDENTOptions, sizeof(TRIDENTOptions));
TW xf86ProcessOptions(pScrn-scrnIndex, pScrn-options,
pTrident-Options);
TW @@ -2868,7 +2868,7 @@ TRIDENTScreenInit(int scrnIndex, ScreenPtr pScreen,
int argc, char **argv)
TW
TW if(pTrident-ShadowFB) {
TW pTrident-ShadowPitch = BitmapBytePad(pScrn-bitsPerPixel *
width);
TW -pTrident-ShadowPtr = xalloc(pTrident-ShadowPitch * height);
TW +pTrident-ShadowPtr = malloc(pTrident-ShadowPitch * height);
TW displayWidth = pTrident-ShadowPitch / (pScrn-bitsPerPixel 3);
TW FBStart = pTrident-ShadowPtr;
TW } else {
TW @@ -2958,7 +2958,7 @@ TRIDENTScreenInit(int scrnIndex, ScreenPtr pScreen,
int argc, char **argv)
TW (miBankProcPtr)TVGA8900SetReadWrite;
TW if (!miInitializeBanking(pScreen, pScrn-virtualX,
pScrn-virtualY,
TW pScrn-displayWidth, pBankInfo)) {
TW -xfree(pBankInfo);
TW +free(pBankInfo);
TW pBankInfo = NULL;
TW if (pTrident-pVbe)
TW vbeFree(pTrident-pVbe);
TW @@ -3238,15 +3238,15 @@ TRIDENTCloseScreen(int scrnIndex, ScreenPtr
pScreen)
TW XAADestroyInfoRec(pTrident-AccelInfoRec);
TW if (pTrident-EXADriverPtr) {
TW exaDriverFini(pScreen);
TW -xfree(pTrident-EXADriverPtr);
TW +free(pTrident-EXADriverPtr);
TW pTrident-EXADriverPtr = NULL;
TW }
TW if (pTrident-CursorInfoRec)
TW xf86DestroyCursorInfoRec(pTrident-CursorInfoRec);
TW if (pTrident-ShadowPtr)
TW -xfree(pTrident-ShadowPtr);
TW +free(pTrident-ShadowPtr);
TW if (pTrident-DGAModes)
TW -xfree(pTrident-DGAModes);
TW +free(pTrident-DGAModes);
TW pScrn-vtSema = FALSE;
TW
TW if(pTrident-BlockHandler)
TW diff --git a/src/trident_video.c b/src/trident_video.c
TW index 0c5497b..1ed7db2 100644
TW --- a/src/trident_video.c
TW +++ b/src/trident_video.c
TW @@ -125,7 +125,7 @@ void TRIDENTInitVideo(ScreenPtr pScreen)
TW adaptors = newAdaptor;
TW } else {
TW newAdaptors = /* need to free this someplace */
TW -xalloc((num_adaptors + 1) * sizeof(XF86VideoAdaptorPtr*));
TW
Re: [PATCH xf86-video-trident 2/2] Update xf86dgastr.h include.
Twas brillig at 21:05:08 22.10.2010 UTC-04 when twoer...@gmail.com did gyre and gimble: TW From: Trevor Woerner twoer...@gmail.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net TW Signed-off-by: Trevor Woerner twoer...@gmail.com TW --- TW src/trident_driver.c |2 +- TW 1 files changed, 1 insertions(+), 1 deletions(-) TW diff --git a/src/trident_driver.c b/src/trident_driver.c TW index ecf99f0..4a03ac6 100644 TW --- a/src/trident_driver.c TW +++ b/src/trident_driver.c TW @@ -63,7 +63,7 @@ TW TW #ifdef XFreeXDGA TW #define _XF86DGA_SERVER_ TW -#include X11/extensions/xf86dgastr.h TW +#include X11/extensions/xf86dgaproto.h TW #endif TW TW #include globals.h TW -- TW 1.7.3.1.127.g1bb28 TW ___ TW xorg-devel@lists.x.org: X.Org development TW Archives: http://lists.x.org/archives/xorg-devel TW Info: http://lists.x.org/mailman/listinfo/xorg-devel -- http://fossarchy.blogspot.com/ pgp4hNXNVBGeh.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xf86-video-xgi] Deprecated code cleanup.
Twas brillig at 15:11:10 21.10.2010 UTC-04 when twoer...@gmail.com did gyre and gimble: TW Replace calls to deprecated dynamic memory wrapper functions TW in driver code. Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgp3RmQtqMJcQ.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 18/19] Xephyr: handle errors in event loop
Twas brillig at 19:12:00 20.10.2010 UTC+02 when jcris...@debian.org did gyre and gimble: JC Signed-off-by: Julien Cristau jcris...@debian.org Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpg1hVKfSgkq.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 19/19] Xephyr: only act on expose events if count is 0
Twas brillig at 19:12:01 20.10.2010 UTC+02 when jcris...@debian.org did gyre and gimble: JC Suggested-by: Peter Harris JC Signed-off-by: Julien Cristau jcris...@debian.org Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgprjpFKy82Le.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] dix: delete logo hack screen saver
Twas brillig at 18:06:31 20.10.2010 UTC-02 when tiago.vigna...@nokia.com did gyre and gimble: TV Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgp1pRXqxWMMn.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xf86-input-joystick 1/2] Deprecated code cleanup.
Twas brillig at 10:07:23 19.10.2010 UTC+02 when wha...@bfs.de did gyre and gimble: wh malloc will return (void *) so there is no need to cast. wh i do not know xmalloc() but i see no check for OOM condition. wh instead of removing xmalloc() it would be more useful to follow wh XtMalloc() that has error handling inside. Sho what's the reasonable error strategy? Shut down the server? xmalloc is just a funny name for malloc nowadays. -- http://fossarchy.blogspot.com/ pgpTyZAU9YhqS.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xf86-input-joystick 1/2] Deprecated code cleanup.
Twas brillig at 12:18:06 19.10.2010 UTC+02 when jcris...@debian.org did gyre and gimble: wh malloc will return (void *) so there is no need to cast. wh i do not know xmalloc() but i see no check for OOM condition. wh instead of removing xmalloc() it would be more useful to follow wh XtMalloc() that has error handling inside. Sho what's the reasonable error strategy? Shut down the server? ^ default JC You could fail preinit for that driver. But I guess if you're OOM JC at preinit time, you're not going to go much further anyway. XtMalloc calls XtErrorMsg if there is no memory available. Not really useful. -- http://fossarchy.blogspot.com/ pgp5lV8PZz4l4.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH RESEND 1/4] xkb: init mapWidth and symsPerKey arrays to 0.
Twas brillig at 12:02:56 15.10.2010 UTC+10 when peter.hutte...@who-t.net did
gyre and gimble:
PH -CARD16 symsPerKey[XkbMaxLegalKeyCode + 1];
PH +CARD8 mapWidths[XkbMaxLegalKeyCode + 1] = {0};
Just a syntax nit - why not = {}?
--
http://fossarchy.blogspot.com/
pgpSCI89wDgbe.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH RESEND 1/4] xkb: init mapWidth and symsPerKey arrays to 0.
Twas brillig at 13:11:34 15.10.2010 UTC-04 when matts...@gmail.com did gyre and
gimble:
PH - CARD16 symsPerKey[XkbMaxLegalKeyCode + 1];
PH + CARD8 mapWidths[XkbMaxLegalKeyCode + 1] = {0};
Just a syntax nit - why not = {}?
--
MT I've always seen {0}. Is {} equivalent?
Yes.
--
http://fossarchy.blogspot.com/
pgpTnsAKJrxjj.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 3/3] xfree86: Add a conservative SIGIO handler path
Twas brillig at 12:49:06 14.10.2010 UTC-04 when a...@redhat.com did gyre and gimble: AJ Instead of actually processing input in the handler, the conservative AJ path just raises enough of a dispatch exception to bomb out of request AJ processing and handle input instead. AJ Signed-off-by: Adam Jackson a...@redhat.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgplkIrljRDih.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [RFC PATCH] randr: crtc cursor confinement
Twas brillig at 14:36:49 12.10.2010 UTC-04 when a...@redhat.com did gyre and
gimble:
AJ +/*
AJ + * This isn't really multiplication, but we don't need it to be. All
AJ + * we need is a boolean for connectivity, not an integer for number of
AJ + * paths. As a result we can scale to gratuitously large n without
AJ + * worrying about integer overflow.
AJ + */
AJ +static Bool
AJ +matrix_pseudomultiply(char *left, const char *right, int n)
AJ +{
AJ +int i, j, k;
AJ +char *res = calloc(1, n * n);
AJ +
AJ +if (!res)
AJ +return FALSE;
AJ +
AJ +for (i = 0; i n; i++)
AJ +for (j = 0; j n; j++)
AJ +for (k = 0; k n; k++)
AJ +res[i*n + j] |= left[i*n + k] right[k*n + j];
AJ +
AJ +memcpy(left, res, n * n);
AJ +
AJ +free(res);
AJ +
AJ +return TRUE;
AJ +}
AJ +
AJ +static void
AJ +RRComputeContiguity (ScreenPtr pScreen)
AJ +{
AJ +rrScrPriv(pScreen);
AJ +Bool discontiguous = TRUE;
AJ +int i, j, n = pScrPriv-numCrtcs;
AJ +RRCrtcPtr a, b;
AJ +char *matrix = NULL, *m = NULL;
AJ +
AJ +matrix = calloc(1, n*n);
AJ +m = calloc(1, n*n);
AJ +if (!matrix || !m)
AJ +goto out;
AJ +
AJ +/* compute adjacency matrix; everything is adjacent with itself */
AJ +for (i = 0; i n; i++) {
AJ +a = pScrPriv-crtcs[i];
AJ +
AJ +if (!a-mode)
AJ +continue;
AJ +
AJ +for (j = 0; j n; j++) {
AJ +b = pScrPriv-crtcs[j];
AJ +
AJ +if (!b-mode)
AJ +continue;
AJ +
AJ +if (a == b || crtcs_adjacent(a, b))
AJ +matrix[i*n + j] = 1;
AJ +}
AJ +}
AJ +
AJ +memcpy(m, matrix, n*n);
AJ +
AJ +/* raise it to the n-1th; finds connected paths */
AJ +for (i = 0; i n-1; i++)
AJ +if (!matrix_pseudomultiply(m, matrix, n))
AJ +goto out;
AJ +
AJ +/* check for connectivity */
AJ +for (i = 0; i n; i++)
AJ +if (pScrPriv-crtcs[i]-mode !m[i])
AJ +goto out;
AJ +
AJ +discontiguous = FALSE;
AJ +
AJ +out:
AJ +free(matrix);
AJ +free(m);
AJ +pScrPriv-discontiguous = discontiguous;
AJ +}
Isn't it too indirect? Just scratched the following (not even
compile-tested). If recursion is a no-no due to systems with numCrtcs
100k, then recursion is easily rewritten to queue.
/* Depth-first search and mark all CRTCs reachable from cur */
static void
dfs (rrScrPrivPtr pScrPriv, int *reachable, int cur)
{
int i;
reachable[cur] = TRUE;
for (i = 0; i pScrPriv-numCrtcs; ++i) {
if (reachable[i])
continue;
if (crtcs_adjacent(pScrPriv-crtcs[cur], pScrPriv-crtcs[i]))
dfs(pScrPriv, reachable, i);
}
}
static void
RRComputeContiguity (ScreenPtr pScreen)
{
rrScrPriv(pScreen);
Bool discontiguous = TRUE;
int i, n = pScrPriv-numCrtcs;
int *reachable = calloc(1, n);
if (!reachable)
goto out;
/* Find first enabled CRTC and start search for reachable CRTCs from it */
for (i = 0; i n; ++i)
if (pScrPriv-crtcs[i]-mode) {
dfs(pScrPriv, reachable, i);
break;
}
/* Check that all enabled CRTCs were marked as reachable */
for (i = 0; i n; ++i)
if (pScrPriv-crtcs[i]-mode !reachable[i])
goto out;
discontiguous = FALSE;
out:
free(reachable);
pScrPriv-discontiguous = discontiguous;
}
--
http://fossarchy.blogspot.com/
pgp1QhN8wGU4i.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [RFC PATCH] randr: crtc cursor confinement
Twas brillig at 23:22:09 12.10.2010 UTC+04 when dotted...@dottedmag.net did
gyre and gimble:
MG /* Depth-first search and mark all CRTCs reachable from cur */
MG static void
MG dfs (rrScrPrivPtr pScrPriv, int *reachable, int cur)
MG {
MG int i;
MG reachable[cur] = TRUE;
MG for (i = 0; i pScrPriv-numCrtcs; ++i) {
MG if (reachable[i])
MG continue;
Should read as
if (reachable[i] || !pScrPriv-crtcs[i]-mode)
continue;
--
http://fossarchy.blogspot.com/
pgpRffKXjfmPw.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xrdb] Get rid of PATHETICCPP macro
Twas brillig at 21:47:05 10.10.2010 UTC+03 when b...@stusta.de did gyre and
gimble:
This macro was undefined since 7.0. Generated by unifdef -UPATHETICCPP
AB Please also manually check the changed code.
Well, I did.
...
if (!filename
-#ifdef PATHETICCPP
-need_real_defines
-#else
(oper == OPLOAD || oper == OPMERGE || oper == OPOVERRIDE)
(whichResources == RALL || whichResources == RSCREENS)
-#endif
) {
...
AB Technically the result is correct, but the resulting code looks
AB weird and should be properly formatted.
I can't think of another way to format this if clause.
--
http://fossarchy.blogspot.com/
pgp9U9dtlF9Zq.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH xrdb] Get rid of PATHETICCPP macro
This macro was undefined since 7.0. Generated by unifdef -UPATHETICCPP
Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net
---
xrdb.c | 105
1 files changed, 0 insertions(+), 105 deletions(-)
diff --git a/xrdb.c b/xrdb.c
index 21005c0..3c15faa 100644
--- a/xrdb.c
+++ b/xrdb.c
@@ -117,13 +117,6 @@ static char *ProgramName;
static Bool quiet = False;
static char tmpname[32];
static char *filename = NULL;
-#ifdef PATHETICCPP
-static Bool need_real_defines = False;
-static char tmpname2[32];
-#ifdef WIN32
-static char tmpname3[32];
-#endif
-#endif
static int oper = OPLOAD;
static char *editFile = NULL;
static const char *cpp_program = NULL;
@@ -373,17 +366,6 @@ ReadFile(Buffer *buffer, FILE *input)
static void
AddDef(String *buff, char *title, char *value)
{
-#ifdef PATHETICCPP
-if (need_real_defines) {
- addstring(buff, \n#define );
- addstring(buff, title);
- if (value (value[0] != '\0')) {
- addstring(buff, );
- addstring(buff, value);
- }
- return;
-}
-#endif
if (buff-used) {
if (oper == OPSYMBOLS)
addstring(buff, \n-D);
@@ -401,11 +383,6 @@ AddDef(String *buff, char *title, char *value)
static void
AddDefQ(String *buff, char *title, char *value)
{
-#ifdef PATHETICCPP
-if (need_real_defines)
- AddDef(buff, title, value);
-else
-#endif
if (value (value[0] != '\0')) {
AddDef(buff, title, \);
addstring(buff, value);
@@ -446,13 +423,6 @@ AddDefTok(String *buff, char *prefix, char *title)
static void
AddUndef(String *buff, char *title)
{
-#ifdef PATHETICCPP
-if (need_real_defines) {
- addstring(buff, \n#undef );
- addstring(buff, title);
- return;
-}
-#endif
if (buff-used) {
if (oper == OPSYMBOLS)
addstring(buff, \n-U);
@@ -901,34 +871,10 @@ main(int argc, char *argv[])
if (whichResources == RALL ScreenCount(dpy) == 1)
whichResources = RGLOBAL;
-#ifdef PATHETICCPP
-if (cpp_program
- (oper == OPLOAD || oper == OPMERGE || oper == OPOVERRIDE)) {
- need_real_defines = True;
-#ifdef WIN32
- strcpy(tmpname2, xrdbD_XX);
- strcpy(tmpname3, \\temp\\xrdbD_XX);
-#else
-#ifdef __UNIXOS2__
- { char *tmpdir=getenv(TMP);
- if (!tmpdir) tmpdir=/;
- sprintf(tmpname2, %s/xrdbD_XX,tmpdir);
- }
-#else
- strcpy(tmpname2, /tmp/xrdbD_XX);
-#endif
-#endif
- (void) mktemp(tmpname2);
-}
-#endif
if (!filename
-#ifdef PATHETICCPP
- need_real_defines
-#else
(oper == OPLOAD || oper == OPMERGE || oper == OPOVERRIDE)
(whichResources == RALL || whichResources == RSCREENS)
-#endif
) {
char inputbuf[1024];
#ifdef WIN32
@@ -1153,45 +1099,6 @@ Process(int scrno, Bool doScreen, Bool execute)
} else {
if (oper == OPMERGE || oper == OPOVERRIDE)
GetEntriesString(newDB, xdefs);
-#ifdef PATHETICCPP
- if (need_real_defines) {
-#ifdef WIN32
- if (!(input = fopen(tmpname2, w)))
- fatal(%s: can't open file '%s'\n, ProgramName, tmpname2);
- fputs(defines.val, input);
- fprintf(input, \n#include \%s\\n, filename);
- fclose(input);
- (void) mktemp(tmpname3);
- if((cmd = (char *)
- malloc(strlen(cpp_program) + strlen(includes.val) +
- 1 + strlen(tmpname2) + 3 + strlen(tmpname3) + 1)) ==
- NULL)
- fatal(%s: Out of memory\n, ProgramName);
- sprintf(cmd, %s%s %s %s, cpp_program, includes.val,
- tmpname2, tmpname3);
- if (system(cmd) 0)
- fatal(%s: cannot run '%s'\n, ProgramName, cmd);
- free(cmd);
- if (!(input = fopen(tmpname3, r)))
- fatal(%s: can't open file '%s'\n, ProgramName, tmpname3);
-#else
- if (!freopen(tmpname2, w+, stdin))
- fatal(%s: can't open file '%s'\n, ProgramName, tmpname2);
- fputs(defines.val, stdin);
- fprintf(stdin, \n#include \%s\\n, filename);
- fflush(stdin);
- fseek(stdin, 0, 0);
- if((cmd = (char *)
- malloc(strlen(cpp_program) + strlen(includes.val) + 1)) ==
- NULL)
- fatal(%s: Out of memory\n, ProgramName);
- sprintf(cmd, %s%s, cpp_program, includes.val);
- if (!(input = popen(cmd, r)))
- fatal(%s: cannot run '%s'\n, ProgramName, cmd);
- free(cmd);
-#endif
- } else {
-#endif
if (filename) {
if (!freopen (filename, r, stdin))
fatal(%s: can't open file '%s'\n, ProgramName, filename);
@@ -1231,9 +1138,6 @@ Process(int scrno, Bool doScreen, Bool execute)
} else {
input = stdin;
}
-#ifdef PATHETICCPP
- }
-#endif
ReadFile(buffer, input
Re: [PATCH xextproto 1/5] XGE: Add xGESendEventReq
Twas brillig at 20:29:39 24.09.2010 UTC+02 when carl...@gnome.org did gyre and gimble: CG Since xSendEventReq has a fixed size, it can't send xGenericEvents CG larger than 32bytes, there is a need for an alternative in Xge that CG is able to deal with variable-size events. The extension version is CG bumped to 1.1 since a new request has been added. Am I right that this patchset works around Xlib implementation limitation by adding otherwise-useless request to GE extension? According to http://cgit.freedesktop.org/xorg/proto/xextproto/tree/specs/geproto.xml#n74 on the wire GE already supports variable-length events. -- http://fossarchy.blogspot.com/ pgpFKt9tdSTBW.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH xextproto 1/5] XGE: Add xGESendEventReq
Twas brillig at 15:22:50 24.09.2010 UTC-04 when phar...@opentext.com did gyre and gimble: PH This is about the SendEvent request, not about the event itself. PH The core protocol only supports 32-byte events in the SendEvent request. Ah, I see. Sorry for the confusion. -- http://fossarchy.blogspot.com/ pgp4ePMMQvDFn.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: dead code in build.sh?
Twas brillig at 16:51:28 22.09.2010 UTC-04 when matts...@gmail.com did gyre and gimble: Makes sense if someone uses it for (well-working) x-jhbuild/jhbuild/build.sh replacement. MT Kconfig is _not_ for determining dependencies. It's for selecting MT optional features. It's not suitable for a project like X.Org. Yes, all drivers and libraries are mandatory for everyone who wants to to build server c to test whether some bug was fixed. MT The kernel also has a person who exclusively maintains MT Kconfig. We're not that lucky. There are lots of projects using Kconfig beside kernel. And please re-read my statement you have quoted. MT This talk about changing build systems is not worthwhile. This is not a talk about changing build systems. -- http://fossarchy.blogspot.com/ pgpFCP7ZR8mer.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 0/4] pciaccess: I/O port API for non-Linux
Twas brillig at 18:29:08 22.09.2010 UTC-04 when macal...@netbsd.org did gyre and gimble: M If I post patches will they be ignored again? Proper term is overlooked. -- http://fossarchy.blogspot.com/ pgpFUDuzFGwaw.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: dead code in build.sh?
Twas brillig at 11:17:51 20.09.2010 UTC-06 when m...@osource.org did gyre and gimble: MD Would I be burned in effigy if I asked about: MD 1) just moving the build system away from autotools to cmake What for? Are there any benefits, beside cool progress bars? BTW, did CMake grow the cross-compilation ability already? -- http://fossarchy.blogspot.com/ pgpLfGRsxKfe7.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH build 2/2] Clean up all conditional statements.
Twas brillig at 07:52:40 15.09.2010 UTC-04 when twoer...@gmail.com did gyre and gimble: TW I have never questioned that one before. I've seen it done so often I TW just assumed there was a good reason for it. But after doodling around TW with a test script for a while I can't seem to see why the string TW delimiters would be necessary. Does anyone know why USE_XCB = NO TW wouldn't be good enough? $ echo $a $ [ zz = $a ] zsh: parse error: condition expected: a $ [ xzz = x$a ] $ -- http://fossarchy.blogspot.com/ pgpSkt6rFwiTn.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH build 2/2] Clean up all conditional statements.
Twas brillig at 08:25:32 15.09.2010 UTC-04 when twoer...@gmail.com did gyre and gimble: TW My git skills aren't quite up-to-speed yet. What would be the best way TW to back out my last commit but preserve the changes so I can make TW additional changes and resubmit the patch? You can add new changes to last commit by a git add'ing them and then doing git commit --amend. OTOH, just git reset 'HEAD^' will do the trick. -- http://fossarchy.blogspot.com/ pgprDOz84Jv8h.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH:libX11 1/2] Make locale data build non-recursive / parallelizable
Twas brillig at 00:44:51 14.09.2010 UTC-07 when alan.coopersm...@oracle.com did gyre and gimble: AC On a 4 core CPU with gmake -j 16 the nls subdir builds in half the time, AC plus this simplifies the next set of changes. Reviwed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgphW2jCtn1Sg.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: Is XAA still supported in recent and future xserver?
Twas brillig at 21:17:52 13.09.2010 UTC+02 when mark.kette...@xs4all.nl did gyre and gimble: so this means we could deprecate XAA from the server, and if one cares about it we recommend to use old servers? MK No. XAA does make a noticable difference on some hardware. deprecate != remove. There are lots of places in server where signs don't use this for new functionality could be quite useful. -- http://fossarchy.blogspot.com/ pgpI94uoauRE7.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH x11proto] Add _X_DEPRECATED_MSG macro
This macro is to be used to point out how to replace deprecated functionality. --- Xfuncproto.h.in |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/Xfuncproto.h.in b/Xfuncproto.h.in index 0177119..96e2b34 100644 --- a/Xfuncproto.h.in +++ b/Xfuncproto.h.in @@ -113,8 +113,10 @@ in this Software without prior written authorization from The Open Group. #if defined(__GNUC__) ((__GNUC__ * 100 + __GNUC_MINOR__) = 301) # define _X_DEPRECATED __attribute__((deprecated)) +# define _X_DEPRECATED_MSG(msg) __attribute__((deprecated, warning(msg))) #else /* not gcc = 3.1 */ # define _X_DEPRECATED +# define _X_DEPRECATED_MSG(msg) #endif #if (defined(__GNUC__) ((__GNUC__ * 100 + __GNUC_MINOR__) = 205)) \ -- 1.7.1 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 2/4] xfree86: fbdevhw: remove unnecessary debug code
Twas brillig at 17:26:51 10.09.2010 UTC+03 when tiago.vigna...@nokia.com did gyre and gimble: TV It very likely no one will want to print all functions of this file for TV debugging purposes. If this is the case, then a mix of ctags + cpp + gdb TV can do the same job. TV Signed-off-by: Tiago Vignatti tiago.vigna...@nokia.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpc5OxMyaDnv.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH mesa] Include search for non pkg-config libtalloc.
Twas brillig at 17:01:25 08.09.2010 UTC-04 when twoer...@gmail.com did gyre and gimble: TW -PKG_CHECK_MODULES([TALLOC], [talloc]) TW +AC_SEARCH_LIBS([talloc_version_major], [talloc], TW +[TALLOC_LIBS=-ltalloc TW +AC_CHECK_HEADERS([talloc.h], [TALLOC_CFLAGS=])], TW +[PKG_CHECK_MODULES([TALLOC], [talloc])]) This patch will break cross-compilation in case there are native talloc development headers installed in build environment. -- http://fossarchy.blogspot.com/ pgpRSYtL1dgax.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH mesa] Include search for non pkg-config libtalloc.
Twas brillig at 00:22:38 09.09.2010 UTC-04 when twoer...@gmail.com did gyre and gimble: TW From: Trevor Woerner twoer...@gmail.com TW Signed-off-by: Trevor Woerner twoer...@gmail.com TW --- TW configure.ac |4 +++- TW 1 files changed, 3 insertions(+), 1 deletions(-) TW diff --git a/configure.ac b/configure.ac TW index a7ee0f5..f4202e9 100644 TW --- a/configure.ac TW +++ b/configure.ac TW @@ -486,7 +486,9 @@ xxlib|xdri|xosmesa) TW ;; TW esac TW TW -PKG_CHECK_MODULES([TALLOC], [talloc]) TW +PKG_CHECK_MODULES([TALLOC], [talloc], [], TW + [AC_SEARCH_LIBS([talloc_version_major],[talloc],[TALLOC_LIBS=-ltalloc TALLOC_CFLAGS=], TW +[AC_MSG_ERROR([Can't find TALLOC])])]) TW AC_SUBST([TALLOC_LIBS]) TW AC_SUBST([TALLOC_CFLAGS]) TW TW -- TW 1.7.1 Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net. -- http://fossarchy.blogspot.com/ pgpkV59rdKfDj.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: Xalloc/Xfree/Xrealloc is deprecated
Twas brillig at 15:11:19 31.08.2010 UTC+08 when frankr.hu...@amd.com did gyre and gimble: HF When compiling the Geode driver with lastest X server(1.9), Some HF warnings are reported: Warning: 'Xalloc/Xfree/Xrealloc' is HF deprecated What are the replacement functions for these deprecated HF functions? malloc, free and realloc. -- http://fossarchy.blogspot.com/ pgpKWDiKfeq9o.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] use CLOCK_MONOTONIC_COARSE posix timer instead of CLOCK_MONOTONIC in Xorg
Twas brillig at 16:45:34 24.08.2010 UTC+08 when yakui.z...@intel.com did gyre and gimble: y What side effect will it bring if we define it explicitly and use it y when it is not defined in system header? Bad side-effect is X.org becoming OS again :) It isn't hard to require newer linux-libc-dev headers for CLOCK_MONOTONIC_COARSE definition. -- http://fossarchy.blogspot.com/ pgpSrFzo1Hd7K.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: lack of standardization on X11
Twas brillig at 20:25:43 18.08.2010 UTC+03 when tiago.vigna...@nokia.com did gyre and gimble: VT But I'm not talking about applications built on the top of VT almost-core X protocol, like redbaron. No one does this today. Get VT real and useful applications like recent compositor managers or a VT browser and come tell me about interoperability with old servers :) Nope. Get real and useful old application which uses lots of extensions and tell me about interoperability with new servers. It works _this_ way. -- http://fossarchy.blogspot.com/ pgplloMNlgMFw.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: lack of standardization on X11
Twas brillig at 20:44:26 18.08.2010 UTC+03 when tiago.vigna...@nokia.com did gyre and gimble: VT I don't think anyone understood... :( I do. You'd love to see core protocol including all the bits necessary for many modern applications. It's called X12. X11 core prototol is inadequate. VT ...to name a few extensions constantly being developed: XKB, Xi, VT Render, DRI2, RandR. Todays applications are built on the top of VT them. Okay? Now try to port an application using these recent VT extensions to some old server. It's impossible! And unnecessary. VT There's no standard - we can freely add and remove extensions VT within X11 implementation and then applications will be loosely VT following some undefined rule, because the strict part to follow - VT the X11 core protocol - is useless anyway. Nobody removes extensions. If old protocol is inadequate (which is major force behind adding extensions), then there is simply no way to have old server to run new shiny apps, as there is no way to implement them. -- http://fossarchy.blogspot.com/ pgpy0fwAQibS8.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: lack of standardization on X11
Twas brillig at 21:00:32 18.08.2010 UTC+03 when tiago.vigna...@nokia.com did gyre and gimble: Nobody removes extensions. If old protocol is inadequate (which is major force behind adding extensions), then there is simply no way to have old server to run new shiny apps, as there is no way to implement them. VT yes, we are constantly removing extensions: LBX, MBE, XTrap, PEX, VT etc... Now try to find single (even old) app that uses'em (and does not fall back to core protocol!). -- http://fossarchy.blogspot.com/ pgpklT5G6lGjJ.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: coding style - whitespace
Twas brillig at 09:13:35 06.08.2010 UTC-04 when twoer...@gmail.com did gyre and gimble: TW So I guess I'm not sure how to format my patch: should I follow what TW the rest of the file is doing (I assume this is what most people would TW want) or should I follow the coding style guide for the project? Working recipie is to 1) use the coding convention from the file modified and 2) fix whitespace in separate patch. Or in reverse order. -- http://fossarchy.blogspot.com/ pgpeeMLJQK3LO.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] loader: when creating sdksyms.c only include shmint.h if MITSHM is enabled. #29109
Twas brillig at 18:14:48 24.07.2010 UTC+02 when r...@gentoo.org did gyre and gimble: Seems we're mixing the MITSHM and HAS_SHM defines a bit also. Perhaps just set an option to disable all shm access is enough for us? Note that currently --disable-shm is a misname; should be --disable-mitshm, or --disable-xmitshm or something like that (concerning the extension only). RC With all the cleanups done these past few months, are there *any* RC supported arches where SHM isn't available? Cygwin/Win32? Just wild guess. -- http://fossarchy.blogspot.com/ pgp0HeZrbyhy7.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] Unwrap no-op CreateScreenResources in RandR
xf86RandRCreateScreenResources is a no-op since 2003 (custom processing is #if
0'ed since that), so just remove it.
Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net
---
hw/xfree86/common/xf86RandR.c | 31 ---
1 files changed, 0 insertions(+), 31 deletions(-)
diff --git a/hw/xfree86/common/xf86RandR.c b/hw/xfree86/common/xf86RandR.c
index d74..54a0742 100644
--- a/hw/xfree86/common/xf86RandR.c
+++ b/hw/xfree86/common/xf86RandR.c
@@ -37,7 +37,6 @@
#include inputstr.h
typedef struct _xf86RandRInfo {
-CreateScreenResourcesProcPtrCreateScreenResources;
CloseScreenProcPtr CloseScreen;
intvirtualX;
intvirtualY;
@@ -320,33 +319,6 @@ xf86RandRSetConfig (ScreenPtr pScreen,
}
/*
- * Wait until the screen is initialized before whacking the
- * sizes around; otherwise the screen pixmap will be allocated
- * at the current mode size rather than the maximum size
- */
-static Bool
-xf86RandRCreateScreenResources (ScreenPtr pScreen)
-{
-XF86RandRInfoPtr randrp = XF86RANDRINFO(pScreen);
-#if 0
-ScrnInfoPtrscrp = XF86SCRNINFO(pScreen);
-DisplayModePtr mode;
-#endif
-
-pScreen-CreateScreenResources = randrp-CreateScreenResources;
-if (!(*pScreen-CreateScreenResources) (pScreen))
- return FALSE;
-
-#if 0
-mode = scrp-currentMode;
-if (mode)
- xf86RandRSetMode (pScreen, mode, TRUE);
-#endif
-
-return TRUE;
-}
-
-/*
* Reset size back to original
*/
static Bool
@@ -447,9 +419,6 @@ xf86RandRInit (ScreenPtrpScreen)
randrp-mmWidth = pScreen-mmWidth;
randrp-mmHeight = pScreen-mmHeight;
-randrp-CreateScreenResources = pScreen-CreateScreenResources;
-pScreen-CreateScreenResources = xf86RandRCreateScreenResources;
-
randrp-CloseScreen = pScreen-CloseScreen;
pScreen-CloseScreen = xf86RandRCloseScreen;
--
1.7.1
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [RFC] porting Xephyr to xcb
Twas brillig at 19:00:32 16.07.2010 UTC+01 when jcris...@debian.org did gyre and gimble: JC The following changes since commit a2c13f0d6548310e3cd115cf486d3e43edf23dcc: JC Bump to version 1.8.99.905 (1.9 RC5) (2010-07-14 12:57:29 -0700) JC are available in the git repository at: JC git://people.freedesktop.org/~jcristau/xserver xephyr-xcb For series: Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgpS8BSR1rQ5D.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH libXfont] Fix build with --disable-builtins
Twas brillig at 17:03:01 09.07.2010 UTC+03 when tiago.vigna...@nokia.com did
gyre and gimble:
TV On Mon, Jul 05, 2010 at 08:25:20PM +0200, ext Mikhail Gusarov wrote:
---
src/util/miscutil.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/util/miscutil.c b/src/util/miscutil.c
index 1e76b4b..b587b3a 100644
--- a/src/util/miscutil.c
+++ b/src/util/miscutil.c
@@ -54,8 +54,12 @@ weak long serverGeneration = 1;
weak void
register_fpe_functions (void)
{
+#ifdef XFONT_BUILTINS
BuiltinRegisterFpeFunctions();
+#endif
+#ifdef XFONT_FONTFILE
FontFileRegisterFpeFunctions();
+#endif
#ifdef XFONT_FC
fs_register_fpe_functions();
#endif
TV humm, interesting. So then you're setting up the server to not use
TV 'fixed' as default font path?
Accidentally. It did not work, but it still worth fixing in library, I
think.
--
http://fossarchy.blogspot.com/
pgphxXV7JyuBp.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH libXfont] Fix build with --disable-builtins
Twas brillig at 16:29:06 09.07.2010 UTC+01 when jcris...@debian.org did gyre and gimble: TV humm, interesting. So then you're setting up the server to not use TV 'fixed' as default font path? Accidentally. It did not work, but it still worth fixing in library, I think. JC Can we kill the disable-builtins option instead, or is there a JC legitimate use case for it? Either way is fine. -- http://fossarchy.blogspot.com/ pgpbk2jvbhVGh.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH libXfont] Fix build with --disable-builtins
Twas brillig at 19:32:48 09.07.2010 UTC+03 when tiago.vigna...@nokia.com did gyre and gimble: VT conceptually (protocol wise) we want builtins, right? Not really. -- http://fossarchy.blogspot.com/ pgpXRPyL8Wzmx.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Remove xcalibrate and tslib support
Twas brillig at 17:06:19 08.07.2010 UTC+02 when a...@embtoolkit.org did gyre and gimble: AWG Please don't do that. I use Kdrive (Xfbdev) with tslib. Old binaries and source code will not magically disappear :) Given amount of changes in Kdrive last couple of years new versions of X server don't bring anything valuable to Xfbdev. AWG Xfbdev + tslib is extremely useful for embedded systems without AWG keyboard, which are driven by a pen. This is the case for many new AWG smart phones for example. Are there new smartphones which don't feature hardware-accelerated graphics? Xfbdev is quite useless for anything except plain old framebuffer. There was CELF project proposal this year targeting optimization of Xfree86 server to match memory consumption of Kdrive, while keeping KMS, newer Xrandr and other features valuable for embedded development. This project was rejected by the CELF board due to lack of funds. If you are worried about the development of X server and somehow connected to smartphones development industry you might want to propose funding of this proposal instead of reviving Kdrive. -- http://fossarchy.blogspot.com/ pgpkXE3iVecbG.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Remove xcalibrate and tslib support
Twas brillig at 20:42:04 08.07.2010 UTC+02 when a...@embtoolkit.org did gyre
and gimble:
AWG Ok if I understand what you said: Stop use of Xfbdev (kdrive) and
AWG all things related to it. So why only delete support of
AWG xcalibrate and tslib?
'cause I invest my time to keep the rest of Xfbdev working (see the
patchlog in hw/kdrive/{linux,src}, until I can switch stuff I develop to
Xorg.
If you want to step in and declare yourself maintainer of tslib
functionality in Kdrive -- go ahead, and let's keep it some time longer,
until better alternative surfaces.
And there is Xephyr as well.
--
http://fossarchy.blogspot.com/
pgpgiIa5ylp9X.pgp
Description: PGP signature
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH libXfont] Fix build with --disable-builtins
---
src/util/miscutil.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/util/miscutil.c b/src/util/miscutil.c
index 1e76b4b..b587b3a 100644
--- a/src/util/miscutil.c
+++ b/src/util/miscutil.c
@@ -54,8 +54,12 @@ weak long serverGeneration = 1;
weak void
register_fpe_functions (void)
{
+#ifdef XFONT_BUILTINS
BuiltinRegisterFpeFunctions();
+#endif
+#ifdef XFONT_FONTFILE
FontFileRegisterFpeFunctions();
+#endif
#ifdef XFONT_FC
fs_register_fpe_functions();
#endif
--
1.7.1
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH:xwininfo 1/2] Handle non-latin-1 window names
Twas brillig at 17:22:01 30.06.2010 UTC+02 when mark.kette...@xs4all.nl did gyre and gimble: Uses _NET_WM_NAME to get UTF-8 encoding, iconv to convert to current locale Warns that COMPOUND_TEXT WM_NAMEs aren't supported if _NET_WM_NAME isn't set Adds local atom caching code to dsimple.c and uses it in all three *.c MK Sorry, but iconv isn't available everywhere; OpenBSD for example MK doesn't have it. Then on OpenBSD xwininfo will have to link with libiconv. -- http://fossarchy.blogspot.com/ pgppvJtTIL8GQ.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [Xcb] [PATCH:xwininfo 1/2] Handle non-latin-1 window names
Twas brillig at 18:02:56 30.06.2010 UTC+02 when mark.kette...@xs4all.nl did gyre and gimble: MK Sorry, but iconv isn't available everywhere; OpenBSD for example MK doesn't have it. Then on OpenBSD xwininfo will have to link with libiconv. MK Which part of OpenBSD doesn't have iconv did you fail to understand? OpenBSD. You did not mention whether it's kenel, basesystem or ports. Anyway, there is separate BSD-licensed libiconv (or was it libbiconv?) which can be compiled anywhere. PS: is it typical OpenBSDish attitude? -- http://fossarchy.blogspot.com/ pgp3VVNW8WREK.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: XTS repo - where to?
Twas brillig at 16:11:04 29.06.2010 UTC+10 when peter.hutte...@who-t.net did gyre and gimble: PH XTS still lives in dan's, aaron's and my $HOME on annarchy. Which is not PH ideal, for obvious reasons. We've had this discussion on IRC a few times, PH with my current preferences being either PH /git/xorg/xts PH or PH /git/xorg/tests/xts There is at least x11perf which may go there as well. -- http://fossarchy.blogspot.com/ pgpAsQnhowGG3.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: Post-RC1 merging criteria
Twas brillig at 20:36:04 22.06.2010 UTC+03 when tiago.vigna...@nokia.com did gyre and gimble: VT - xserver-staging would be a tree for everyone interesting in VT development while upstream are in bugfixing. This tree (well, VT -meego also) stays opened only when the merge window is closed. I like the idea of dumpground, it fixes at least one trouble with patches sitting on devs' trees: all conflicts are resolved in this tree before final pull. The only open question is whether this tree is rebased on top of master periodically or kept as is until master is open for commits again. -- http://fossarchy.blogspot.com/ pgp6huxgXnUsj.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: xserver: Branch 'master' - 12 commits
Twas brillig at 11:48:50 22.06.2010 UTC-07 when kei...@kemper.freedesktop.org did gyre and gimble: KP mi: Remove unused overlay support Whoops, please revert this patch -- overlay is in use in nvidia drivers, and it's too late in release cycle to remove it. I feel really sorry that I kept this patch in my tree. I will submit -- http://fossarchy.blogspot.com/ pgphdIzJUdGOw.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: xserver: Branch 'master' - 12 commits
Twas brillig at 02:00:29 23.06.2010 UTC+07 when dotted...@dottedmag.net did gyre and gimble: KP mi: Remove unused overlay support MG Whoops, please revert this patch -- overlay is in use in nvidia drivers, MG and it's too late in release cycle to remove it. MG I feel really sorry that I kept this patch in my tree. I will submit ... another one, removing only XAA overlay hooks which are not used at all. -- http://fossarchy.blogspot.com/ pgpChrB5yeupQ.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] include: Update stale comment after bzero removal
Twas brillig at 10:16:28 21.06.2010 UTC+10 when peter.hutte...@who-t.net did gyre and gimble: -#include X11/Xfuncs.h /* for bcopy, bzero, and bcmp */ +#include X11/Xfuncs.h /* for no apparent reason */ PH couldn't we just remove this include then? http://lists.x.org/archives/xorg-devel/2010-June/009650.html -- http://fossarchy.blogspot.com/ pgpYXQ2JvTh9E.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] include: Update stale comment after bzero removal
Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net --- include/misc.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/misc.h b/include/misc.h index 62d813e..38b04b7 100644 --- a/include/misc.h +++ b/include/misc.h @@ -108,7 +108,7 @@ typedef struct _CallbackList *CallbackListPtr; /* also in dix.h */ typedef struct _xReq *xReqPtr; #include os.h/* for ALLOCATE_LOCAL and DEALLOCATE_LOCAL */ -#include X11/Xfuncs.h /* for bcopy, bzero, and bcmp */ +#include X11/Xfuncs.h /* for no apparent reason */ #define NullBox ((BoxPtr)0) #define MILLI_PER_MIN (1000 * 60) -- 1.7.1 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
[PATCH] Guard x* macros with _HAVE_XALLOC_DECLS as well to avoid clashes with Xlib
If Xlib headers are included before os.h declaration of Xcalloc clashes with definition of Xcalloc macros from there (e.g. in Xephyr). Signed-off-by: Mikhail Gusarov dotted...@dottedmag.net --- include/os.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/include/os.h b/include/os.h index efa202c..cd21d3c 100644 --- a/include/os.h +++ b/include/os.h @@ -67,6 +67,7 @@ SOFTWARE. typedef struct _FontPathRec *FontPathPtr; typedef struct _NewClientRec *NewClientPtr; +#ifndef _HAVE_XALLOC_DECLS #ifndef xalloc #define xnfalloc(size) XNFalloc((unsigned long)(size)) #define xnfcalloc(_num, _size) XNFcalloc((unsigned long)(_num)*(unsigned long)(_size)) @@ -79,6 +80,7 @@ typedef struct _NewClientRec *NewClientPtr; #define xstrdup(s) Xstrdup(s) #define xnfstrdup(s) XNFstrdup(s) #endif +#endif #include stdio.h #include stdarg.h @@ -213,7 +215,6 @@ extern _X_EXPORT int set_font_authorizations( pointer /* client */); #ifndef _HAVE_XALLOC_DECLS -#define _HAVE_XALLOC_DECLS /* * Use malloc(3) instead. -- 1.7.1 ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Define/use X_ALIGN2() instead of open coding it
Twas brillig at 18:14:31 19.06.2010 UTC-04 when matts...@gmail.com did gyre and gimble: MT Signed-off-by: Matt Turner matts...@gmail.com From the discussion in IRC: - X_ALIGN2 is not clear enough. pad_to_pow_two? - It's not macro, so no need to have it all caps. - misc.h brings too much garbage, better have include/align.h, - So _HAVE_XALLOC_DECLS won't be needed. -- http://fossarchy.blogspot.com/ pgp90je3mvaNW.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH 0/2] startup speed up by removing PCI routines
Twas brillig at 15:22:39 17.06.2010 UTC+03 when tiago.vigna...@nokia.com did gyre and gimble: TV Tiago Vignatti (2): TV xfree86: pci: remove superfluous vendor and card name logging TV xfree86: configure: remove vendor and card name matching rules Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net -- http://fossarchy.blogspot.com/ pgp09ELPAUKQS.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Replace xalloc with malloc
Twas brillig at 20:28:29 16.06.2010 UTC+02 when t...@dbservice.com did gyre and gimble: TC Same for xfree/xrealloc/xcalloc. Also, the return value from TC malloc/realloc/calloc doesn't require a cast, same for the TC argument of free(). Also remove if()'s that check if the TC pointer that is about to be passed to free() is NULL, since TC free(NULL) is allowed. TC Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net TC -#define xcalloc(_num,_size)calloc(_num,_size) At least here xcalloc had two args unlike server. -- http://fossarchy.blogspot.com/ pgpAgf8iyAe1b.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: [PATCH] Replace xalloc with malloc
Twas brillig at 21:19:11 16.06.2010 UTC+02 when t...@dbservice.com did gyre and gimble: TC Same for xfree/xrealloc/xcalloc. Also, yay for Xcalloc() taking only TC one argument. TC Signed-off-by: Tomas Carnecky t...@dbservice.com Reviewed-by: Mikhail Gusarov dotted...@dottedmag.net TC #define_XkbClearElems(a,f,l,t) bzero((a)[f],((l)-(f)+1)*sizeof(t)) memset? -- http://fossarchy.blogspot.com/ pgpdGUOLSY77E.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
Re: libX11 or xproto seem to disable some macros defined by mips toolchain
Twas brillig at 10:08:03 15.06.2010 UTC+02 when a...@embtoolkit.org did gyre and gimble: AWG but the Makefile in libX11-1.3.4/src/util uses the target CFLAGS. It's a bug. AWG Can someone confirms that makekeys is intended to run on the AWG host (not target) in case of cross compilation? Yes. -- http://fossarchy.blogspot.com/ pgpIIbFh0zgsI.pgp Description: PGP signature ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel
