Weird behaviour (most X extensions missing including GLX) in X11 forwarding since xorg-server 1.20 ...

[Stefan Dirsch]

Hi

I'm wondering, whether this happens to everybody using xorg-server 1.20
(1.20.3 in my case).

When using X11 forwarding via ssh

  ssh -X 

(DISPLAY=localhost:10.0)

the list of available extensions when running xdpyinfo is limited to

[...]
number of extensions:2
BIG-REQUESTS
XC-MISC
default screen number:0

When running xdpyinfo local (DISPLAY=:0) it's complete:

[...]
number of extensions:29
BIG-REQUESTS
Composite
DAMAGE
DOUBLE-BUFFER
DPMS
DRI2
DRI3
GLX
Generic Event Extension
MIT-SCREEN-SAVER
MIT-SHM
Present
RANDR
RECORD
RENDER
SECURITY
SHAPE
SYNC
X-Resource
XC-MISC
XFIXES
XFree86-DGA
XFree86-VidModeExtension
XINERAMA
XInputExtension
XKEYBOARD
XTEST
XVideo
XVideo-MotionCompensation
default screen number:0
[...]

This happens even if you ssh to the same local machine. Can anybody reproduce
this? Is this a known issue. Since now GLX extension is missing I can't run
any GL application any longer via ssh ...

This still works with xorg-server 1.19 for me.

Thanks,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 

SUSE Linux GmbH, GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

modesetting: Fix cirrus 24bpp breakage

[Stefan Dirsch]

From: Takashi Iwai 

The recent rewrite of modesetting driver broke the 24bpp support.
As typically found on cirrus KMS, it leads to a blank screen, spewing
the error like:
  failed to add fb -22
  (EE) modeset(0): failed to set mode: Invalid argument

The culript is that the wrong bpp value of the front buffer is passed
to drmModeAddFB().  Fix it by replacing with the back buffer bpp,
drmmode->kbpp.

Signed-off-by: Takashi Iwai 
Tested-by: Stefan Dirsch 

---
 hw/xfree86/drivers/modesetting/drmmode_display.c |2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/hw/xfree86/drivers/modesetting/drmmode_display.c
+++ b/hw/xfree86/drivers/modesetting/drmmode_display.c
@@ -990,7 +990,7 @@ drmmode_bo_import(drmmode_ptr drmmode, d
 }
 #endif
 return drmModeAddFB(drmmode->fd, bo->width, bo->height,
-drmmode->scrn->depth, drmmode->scrn->bitsPerPixel,
+drmmode->scrn->depth, drmmode->kbpp,
 drmmode_bo_get_pitch(bo),
 drmmode_bo_get_handle(bo), fb_id);
 }
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xf86-video-savage] Add check for max[HV]Value to ValidMode hook

[Stefan Dirsch]

On Tue, Jun 26, 2018 at 04:13:01PM +0100, Emil Velikov wrote:
> On 25 June 2018 at 14:55, Stefan Dirsch  wrote:
> > xorg-server 1.20 removed this check, so implement this in the driver
> > itself.
> >
> Quick look shows that Adam, updated most drivers although a few are remaining.
> Namely:
> s3verge
> tseng
> vga
> savage - addressed with this patch.
> 
> > Signed-off-by: Stefan Dirsch 
> Reviewed-by: Emil Velikov 
> 
> I'll push this shortly.

Thanks a lot!

> Although if you'd like to address the other
> drivers, that'll be appreciated.

Looks like building the vga driver is no longer appreciated. ;-)

./configure 
configure: error: 
  **
  This driver is unmaintained and will not receive further
  patches.  Please use the xf86-video-vesa driver instead.
  If you have a need for this driver that cannot be met by the
  vesa driver, please file a bug on http://bugs.freedesktop.org.
  **

I've sent patches for s3virge and tseng driver to the list. BTW,
(open)SUSE no longer ship prehistoric drivers since some time ...

CU,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xf86-video-s3virge] Add check for max[HV]Value to ValidMode hook

[Stefan Dirsch]

xorg-server 1.20 removed this check, so implement this in the driver
itself.

Signed-off-by: Stefan Dirsch 
---
 src/s3v_driver.c | 21 ++---
 1 file changed, 10 insertions(+), 11 deletions(-)

diff --git a/src/s3v_driver.c b/src/s3v_driver.c
index e5dd2e4..b546c4f 100644
--- a/src/s3v_driver.c
+++ b/src/s3v_driver.c
@@ -1203,17 +1203,6 @@ S3VPreInit(ScrnInfoPtr pScrn, int flags)
vga256InfoRec.directMode = XF86DGADirectPresent;
 #endif
 
-/*
- * xf86ValidateModes will check that the mode HTotal and VTotal values
- * don't exceed the chipset's limit if pScrn->maxHValue and
- * pScrn->maxVValue are set.  
- */
-
-/* todo -  The virge limit is 2048 vertical & horizontal */
-/* pixels, not clock register settings. */
-   /* true for all ViRGE? */
-  pScrn->maxHValue = 2048;
-  pScrn->maxVValue = 2048;
 
/* Lower depths default to config file */
   pScrn->virtualX = pScrn->display->virtualX;
@@ -2566,6 +2555,16 @@ S3VValidMode(SCRN_ARG_TYPE arg, DisplayModePtr mode, 
Bool verbose, int flags)
 if ((pScrn->bitsPerPixel + 7)/8 * mode->HDisplay > 4095)
return MODE_VIRTUAL_X;
 
+/* todo -  The virge limit is 2048 vertical & horizontal */
+/* pixels, not clock register settings. */
+/* true for all ViRGE? */
+
+if (mode->HTotal > 2048)
+   return MODE_BAD_HVALUE;
+
+if (mode->VTotal > 2048)
+   return MODE_BAD_VVALUE;
+
 return MODE_OK;
 }
 
-- 
2.16.3

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xf86-video-tseng] Add check for max[HV]Value to ValidMode hook

[Stefan Dirsch]

xorg-server 1.20 removed this check, so implement this in the driver
itself.

Signed-off-by: Stefan Dirsch 
---
 src/tseng_driver.c | 8 ++--
 src/tseng_mode.c   | 8 
 2 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/src/tseng_driver.c b/src/tseng_driver.c
index 0db62e5..8cbd4d9 100644
--- a/src/tseng_driver.c
+++ b/src/tseng_driver.c
@@ -1037,10 +1037,6 @@ TsengPreInit(ScrnInfoPtr pScrn, int flags)
 else
pTseng->Bytesperpixel = 1;  /* this is fake for < 8bpp, but simplifies 
other code */
 
-/* hardware limits */
-pScrn->maxHValue = Tseng_HMAX;
-pScrn->maxVValue = Tseng_VMAX;
-
 /*
  * This must happen after pScrn->display has been set because
  * xf86SetWeight references it.
@@ -1133,8 +1129,8 @@ TsengPreInit(ScrnInfoPtr pScrn, int flags)
 /* Select valid modes from those available */
 i = xf86ValidateModes(pScrn, pScrn->monitor->Modes,
pScrn->display->modes, >clockRange,
-   NULL, 32, pScrn->maxHValue, 8*pTseng->Bytesperpixel, /* H limits */
-   0, pScrn->maxVValue,   /* V limits */
+   NULL, 32, Tseng_HMAX, 8*pTseng->Bytesperpixel, /* H limits */
+   0, Tseng_VMAX,  /* V limits */
pScrn->display->virtualX,
pScrn->display->virtualY,
pTseng->FbMapSize,
diff --git a/src/tseng_mode.c b/src/tseng_mode.c
index c96403e..fda2a44 100644
--- a/src/tseng_mode.c
+++ b/src/tseng_mode.c
@@ -35,6 +35,10 @@
 
 #define VGA_BANK 0x3CB
 
+/* CRTC timing limits */
+#define Tseng_HMAX (4096-8)
+#define Tseng_VMAX (2048-1)
+
 void
 vgaHWWriteBank(vgaHWPtr hwp, CARD8 value)
 {
@@ -1016,9 +1020,6 @@ TsengValidMode(SCRN_ARG_TYPE arg, DisplayModePtr mode, 
Bool verbose, int flags)
 
 PDEBUG("   TsengValidMode\n");
 
-#ifdef FIXME
-  is this needed? xf86ValidMode gets HMAX and VMAX variables, so it could deal 
with this.
-  need to recheck hsize with mode->Htotal*mulFactor/divFactor
 /* Check for CRTC timing bits overflow. */
 if (mode->HTotal > Tseng_HMAX) {
return MODE_BAD_HVALUE;
@@ -1026,7 +1027,6 @@ TsengValidMode(SCRN_ARG_TYPE arg, DisplayModePtr mode, 
Bool verbose, int flags)
 if (mode->VTotal > Tseng_VMAX) {
return MODE_BAD_VVALUE;
 }
-#endif
 
 return MODE_OK;
 }
-- 
2.16.3

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xf86-video-r128] Include in order to declare uint32_t

[Stefan Dirsch]

Apparently this is needed in src/atipcirename.h since xorg-server
1.20 in order to still build this driver.

Signed-off-by: Stefan Dirsch 
---
 src/atipcirename.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/atipcirename.h b/src/atipcirename.h
index e65ae3c..3e7f686 100644
--- a/src/atipcirename.h
+++ b/src/atipcirename.h
@@ -34,6 +34,7 @@ enum region_type {
 REGION_IO 
 };
 
+#include 
 #include "xf86Module.h"
 
 #if GET_ABI_MAJOR(ABI_VIDEODRV_VERSION) >= 12
-- 
2.16.3

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xf86-video-savage] Add check for max[HV]Value to ValidMode hook

[Stefan Dirsch]

xorg-server 1.20 removed this check, so implement this in the driver
itself.

Signed-off-by: Stefan Dirsch 
---
 src/savage_driver.c | 10 --
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/savage_driver.c b/src/savage_driver.c
index 58a294d..3cda923 100644
--- a/src/savage_driver.c
+++ b/src/savage_driver.c
@@ -2034,8 +2034,6 @@ static Bool SavagePreInit(ScrnInfoPtr pScrn, int flags)
 xf86DrvMsg(pScrn->scrnIndex, X_PROBED, "Detected current MCLK value of 
%1.3f MHz\n",
   mclk / 1000.0);
 
-pScrn->maxHValue = 2048 << 3;  /* 11 bits of h_total 8-pixel units */
-pScrn->maxVValue = 2048;   /* 11 bits of v_total */
 pScrn->virtualX = pScrn->display->virtualX;
 pScrn->virtualY = pScrn->display->virtualY;
 
@@ -3637,6 +3635,14 @@ static ModeStatus SavageValidMode(SCRN_ARG_TYPE arg, 
DisplayModePtr pMode,
(pMode->VDisplay > psav->PanelY)))
return MODE_PANEL;
 
+/* 11 bits of h_total 8-pixel units */
+if (pMode->HTotal > (2048 << 3))
+   return MODE_BAD_HVALUE;
+
+/* 11 bits of v_total */
+if (pMode->VTotal > 2048)
+   return MODE_BAD_VVALUE;
+
 if (psav->UseBIOS) {
refresh = SavageGetRefresh(pMode);
 return (SavageMatchBiosMode(pScrn,pMode->HDisplay,
-- 
2.16.3

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH video-mga] xf86-video-mga: Fix-to-always-set-HiPri-for-G200e4

[Stefan Dirsch]

On Mon, Jun 12, 2017 at 04:08:42PM -0400, mathieu.larou...@matrox.com wrote:
> From: Mathieu Larouche <mathieu.larou...@matrox.com>
> 
>   - Changed the HiPri value for G200e4 to always be 0.
>   - Added Bandwith limitation to block resolution above 1920x1200x60Hz
> ---
>  src/mga_driver.c | 43 ++-
>  1 file changed, 26 insertions(+), 17 deletions(-)
> 
> diff --git a/src/mga_driver.c b/src/mga_driver.c
> index 79c6da7..615518a 100644
> --- a/src/mga_driver.c
> +++ b/src/mga_driver.c
> @@ -2969,14 +2969,21 @@ MGAModeInit(ScrnInfoPtr pScrn, DisplayModePtr mode)
>  }
>  
>  
> -ulMemoryBandwidth = (mode->Clock * ulBitsPerPixel) / 1000;
> -
> -if  (ulMemoryBandwidth> 3100)  ucHiPriLvl = 0;
> -else if (ulMemoryBandwidth> 2600)  ucHiPriLvl = 1;
> -else if (ulMemoryBandwidth> 1900)  ucHiPriLvl = 2;
> -else if (ulMemoryBandwidth> 1160)  ucHiPriLvl = 3;
> -else if (ulMemoryBandwidth> 440)   ucHiPriLvl = 4;
> -else ucHiPriLvl = 5;
> +if (pMga->reg_1e24 >= 0x04)
> +{
> +ucHiPriLvl = 0;
> +}
> +else
> +{
> + ulMemoryBandwidth = (mode->Clock * ulBitsPerPixel) / 1000;
> +
> +if  (ulMemoryBandwidth> 3100)  ucHiPriLvl = 0;
> +else if (ulMemoryBandwidth> 2600)  ucHiPriLvl = 1;
> +else if (ulMemoryBandwidth> 1900)  ucHiPriLvl = 2;
> +else if (ulMemoryBandwidth> 1160)  ucHiPriLvl = 3;
> +else if (ulMemoryBandwidth> 440)   ucHiPriLvl = 4;
> +else ucHiPriLvl = 5;
> +}

mga_driver.c:3373: warning: 'ulMemoryBandwidth' may be used uninitialized in
this function

That's because for G200e4 it's no longer initialized, but later still
referenced.

xf86DrvMsg(pScrn->scrnIndex, X_INFO, "MemoryBandwidth == %d\n",
ulMemoryBandwidth);

Either initialize it or no longer reference it on G200e4. ;-)

Thanks,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: Bug in xorg-xserver - missing declaration!

[Stefan Dirsch]

On Wed, Feb 22, 2017 at 11:03:20AM +0100, Stefan Dirsch wrote:
> > Please consider the following patch:
> > 
> > --- glamor/glamor_dash.c.original   2016-03-11 19:43:16.0 +0100
> > +++ glamor/glamor_dash.c2017-02-19 20:00:11.883218927 +0100
> > @@ -32,6 +32,7 @@
> > 
> >  static const char dash_vs_exec[] =
> >  "   dash_offset = primitive.z / dash_length;\n"
> > +"   vec2 pos = vec2(0,0);\n"
> >  GLAMOR_POS(gl_Position, primitive.xy);
> > 
> >  static const char dash_fs_vars[] =
> 
> Thanks! Could you please resend the patch to the list following the guidelines
> on
> 
>   https://www.x.org/wiki/Development/Documentation/SubmittingPatches/
> 
> Otherwise I'm afraid it will be ignored successfully. :-(

Just tested your patch. I could verify, that it fixes the crash when running
tgif with your special .obj file inside of

  Xephyr -glamor

So you have my

  Tested-by: Stefan Dirsch <sndir...@suse.com>

Thanks,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: Bug in xorg-xserver - missing declaration!

[Stefan Dirsch]

On Sun, Feb 19, 2017 at 08:29:22PM +0100, Dr.-Ing. Dieter Jurzitza wrote:
> Dear listmembers,
> I found the problem and I think I fixed it. Please validate & give a feedback
> 
> OS: openSUSE Leap 42.2
> Result: server crash
> 
> Due to the similarity of this problem and the one that had had been found 
> (and 
> fixed!) by Michel Dänzer I was capable to provide a fix that solves the issue 
> (for me...)
> Due to my limited capabilities with regard to C-Programming someone more 
> experienced than I am ought to look over that (and probably improve!)
> 
> Please consider the following patch:
> 
> --- glamor/glamor_dash.c.original   2016-03-11 19:43:16.0 +0100
> +++ glamor/glamor_dash.c2017-02-19 20:00:11.883218927 +0100
> @@ -32,6 +32,7 @@
> 
>  static const char dash_vs_exec[] =
>  "   dash_offset = primitive.z / dash_length;\n"
> +"   vec2 pos = vec2(0,0);\n"
>  GLAMOR_POS(gl_Position, primitive.xy);
> 
>  static const char dash_fs_vars[] =

Thanks! Could you please resend the patch to the list following the guidelines
on

  https://www.x.org/wiki/Development/Documentation/SubmittingPatches/

Otherwise I'm afraid it will be ignored successfully. :-(

CU,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] XDMCP: For IPv6 add IPv6 link local addresses to the end of the list

[Stefan Dirsch]

On Tue, Jun 21, 2016 at 11:46:05AM -0400, Adam Jackson wrote:
> On Fri, 2016-04-29 at 11:22 +0200, Stefan Dirsch wrote:
> > On Fri, Apr 29, 2016 at 09:40:05AM +0200, Julien Cristau wrote:
> > > On Thu, Apr 28, 2016 at 15:21:15 +0200, Stefan Dirsch wrote:
> > > 
> > > > From: Reinhard Max <m...@suse.de>
> > > > 
> > > > For IPv6 add a link local addresses to the end of the list passed to
> > > > the XDMCP servers.
> > > > Reason: for link local addresses the XDMCP server would need to either
> > > > know the interface thru a scope identifier or try all available 
> > > > interfaces.
> > > > If they don't this address will fail in which case the XDMCP server
> > > > could still try the other addresses passed - however some only try
> > > > the first address and then give up.
> > > > Even if this seems to be the wrong place to fix this it seems to be
> > > > easier than fixing all display servers.
> > > 
> > > Commit message says "add to the end of the list", code says "ignore",
> > > which is it?
> > 
> > Good question. Maybe Reinhard still remembers. Meanwhile I found slightly
> > different descriptions for the patch. Seems the patch changed in between.
> > Sigh.
> 
> Ugh. I found this patch in the patchwork backlog and pushed it before
> checking for this thread; reverted.
> 
> The logic in the patch does seem useful; is there a final version
> you're shipping, and does Max remember the details yet?

It is the final version we're shipping - since years. Reinhard is in Cc. He
may reply in case he still remembers the details. Thanks for asking!

CU,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH vmmouse] conf: rename to 70-vmmouse.conf

[Stefan Dirsch]

Bump up the vmmouse driver to 70, so it get's preferred over libinput, which
was dropped down to 60. This is only relevant for older kernels, which do not
yet have the functionality provided by vmmouse driver. On recent kernels
vmmouse driver is no longer loaded at all.

Signed-off-by: Stefan Dirsch <sndir...@suse.de>
---
 tools/{50-vmmouse.conf => 70-vmmouse.conf} | 0
 tools/Makefile.am  | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename tools/{50-vmmouse.conf => 70-vmmouse.conf} (100%)

diff --git a/tools/50-vmmouse.conf b/tools/70-vmmouse.conf
similarity index 100%
rename from tools/50-vmmouse.conf
rename to tools/70-vmmouse.conf
diff --git a/tools/Makefile.am b/tools/Makefile.am
index da0e782..0b4c526 100644
--- a/tools/Makefile.am
+++ b/tools/Makefile.am
@@ -41,7 +41,7 @@ CLEANFILES = hal-probe-vmmouse
 if HAS_XORG_CONF_DIR
 
 confdir=$(XORG_CONF_DIR)
-dist_conf_DATA = 50-vmmouse.conf
+dist_conf_DATA = 70-vmmouse.conf
 
 endif
 
-- 
2.6.6

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH app/sessreg] Use off_t instead of long to make largefile support work

[Stefan Dirsch]

Hi Egbert

you defintely have my

  Reviewed-by: Stefan Dirsch <sndir...@suse.de>

But could you still fix the typo in the changelog (relace -> replace) and
mention the bugreport

  https://bugzilla.opensuse.org/show_bug.cgi?id=981522

as reference? And also add that the issue has been reproduced on 32bit systems
only?

Thanks,
Stefan

On Mon, May 30, 2016 at 12:01:14AM +0200, Egbert Eich wrote:
> From: Egbert Eich <e...@suse.de>
> 
> We already use the AC_SYS_LARGEFILE in configure.ac. This macro will only
> work properly if the correct tyles are used: relace long by off_t when
> calculating file offsets.
> 
> Signed-off-by: Egbert Eich <e...@suse.de>
> Found-by: Herbert Kütz 
> ---
>  sessreg.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sessreg.c b/sessreg.c
> index bdfe8f0..3efd8d9 100644
> --- a/sessreg.c
> +++ b/sessreg.c
> @@ -327,7 +327,7 @@ main (int argc, char **argv)
>  # else
>   utmp = open (utmp_file, O_RDWR);
>   if (utmp != -1) {
> - syserr ((int) lseek (utmp, (long) slot_number * sizeof 
> (struct utmp), 0), "lseek");
> + syserr ((int) lseek (utmp, (off_t) slot_number * sizeof 
> (struct utmp), 0), "lseek");
>   sysnerr (write (utmp, (char *) _entry, sizeof 
> (utmp_entry))
>   == sizeof (utmp_entry), "write utmp 
> entry");
>   close (utmp);
> @@ -362,7 +362,7 @@ main (int argc, char **argv)
>   if (llog != -1) {
>   struct lastlog ll;
>  
> - sysnerr (lseek(llog, (long) (pwd->pw_uid*sizeof(ll)), 0)
> + sysnerr (lseek(llog, (off_t) (pwd->pw_uid*sizeof(ll)), 
> 0)
>   != -1, "seeking lastlog entry");
>   memset(, 0, sizeof(ll));
>   ll.ll_time = current_time;
> @@ -628,7 +628,7 @@ findslot (char *line_name, char *host_name, int addp, int 
> slot)
>* first, try to locate a previous entry for this display
>* also record location of a free slots in case we need a new one
>*/
> - syserr ((int) lseek (utmp, (long) slot * sizeof (struct utmp), 0), 
> "lseek");
> + syserr ((int) lseek (utmp, (off_t) slot * sizeof (struct utmp), 0), 
> "lseek");
>  
>   if (!host_name)
>   host_name = "";
> -- 
> 2.7.0

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH synaptics] conf: rename to 70-synaptics.conf

[Stefan Dirsch]

On Mon, May 23, 2016 at 11:41:00AM +1000, Peter Hutterer wrote:
> On Thu, May 19, 2016 at 05:35:57PM +0200, Stefan Dirsch wrote:
> > Bump up synaptics driver to 70, so it get's perferred over libipnut,
> > which was dropped down to 60. Reason is, that synaptics driver is more
> > of an additional driver, which then should be installed if installed.
> > 
> > Similar to what was done for wacom configuration file.
> > 
> > https://bugzilla.suse.com/show_bug.cgi?id=979554
> > 
> > Signed-off-by: Stefan Dirsch <sndir...@suse.de>
> 
> thanks, for the synaptics driver this makes sense.
> I've changed the commit message a bit though, pushed 
> 
>979fbec..59e5db0  master -> master

Thanks a lot!

> You really want to make sure you got the rpm package dependencies right in
> suse though, having synaptics installed now means that some things don't
> work as well anymore (GNOME is focusing on libinput only now).

For future products we no longer install synaptics driver by default, so we
should be on the safe side. ;-)

CU,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH synaptics] conf: rename to 70-synaptics.conf

[Stefan Dirsch]

On Fri, May 20, 2016 at 12:20:02PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 19-05-16 17:35, Stefan Dirsch wrote:
> >Bump up synaptics driver to 70, so it get's perferred over libipnut,
> >which was dropped down to 60. Reason is, that synaptics driver is more
> >of an additional driver, which then should be installed if installed.
> >
> >Similar to what was done for wacom configuration file.
> >
> >https://bugzilla.suse.com/show_bug.cgi?id=979554
> >
> >Signed-off-by: Stefan Dirsch <sndir...@suse.de>
> 
> The difference is that the wacom driver provides a whole bunch of
> functionality over libinput (*), where as the synaptics driver is mostly
> just an old crufty driver which we want to get rid of.
> 
> So NACK, we really want people to switch to libinput for touchpads.
> 
> If there is any reason why a user cannot switch please ask the user to file a
> bug against libinput directly at bugzilla.freedesktop.org, at a minimum we
> should be able to explain to the user why he cannot have his pony (e.g.
> some weird synaptics specific behavior which we deem undesirable) and in
> many cases users complaints are valid and we've been able to fix them
> by improving libinput's touchpad behavior, without introducing the need
> to tweak a config file to their desire as people have typically been
> doing with synaptics.
> 
> By making libinput's touchpad support just work we can greatly improve
> the touchpad experience under Linux, instead of people having to do
> dark magic in their synaptics-config to get things to work to their
> liking.
> 
> Ugh, just looked at the bug, I see that the user wants circular
> scrolling on a Dell Latitude E6510, which has a perfectly normal
> rectangular touchpad, so I'm afraid this one falls into the
> "cannot have his pony" category, even if we where to ever add
> support for this to libinput (unlikely since round touchpads
> have gone out of fashion a long time ago), we will likely not offer
> it on rectangular touchpads
> 
> So back to the patch, we want libinput to have a higher prio, as
> we want to move existing users over to synaptics, even they do a
> dist-upgrade from a previous distro release which had the synaptics
> driver. We cannot force uninstall the synaptics driver by say adding
> an Obsoletes to the libinput driver .spec file, because we still offer
> the synaptics driver for users who have a special case which is better
> served by synaptics. Given these conflicting desires, we require a
> bit of manual config from the special case users in the form of
> manually adding a config file to enable synaptics with a higher
> priority then libinput.
> 
> Looking at Suse bug I see that you've already made this proposed
> change in the suse pkgs, and also for evdev. What does this mean for
> users who have upgraded from older suse versions rather then done
> a fresh install? Will they somehow get the synaptics and evdev
> drivers uninstalled on upgrade ? If not I would advise you to
> undo this change, because evdev / synaptics support is likely
> to bitrot, both on the xorg side as well as wrt support by
> gnome/kde/xfce mouse/touchpad configuration panels, so IMHO
> you're doing users who are upgrading from one release to the
> next a disservice by keeping them on evdev / synaptics,
> or in some cases likely switching them back from libinput to
> evdev / synaptics when they get the updated packages with the
> higher prio for evdev / synaptics.

edev changes I've reverted (see my response to Peter's mail). I see that my
patch is not appreciated. ;-) I can and need to live with that. No issue. ;-)

My plan for SUSE is to no longer install the synatics driver by default, so
users setting up a new system will get libinput driver. For users updating
their system, synaptics driver won't get uninstalled and as a Linux
distributor I'm not interested in pissing them off by switching to a different
driver with a different feature set, so I need this higher priority for
synaptics. The same applies if somebody explicitely installs the synaptics
driver in addition. In that case he gets what he deserves, the synaptics
driver. ;-)

I agree, that we disagree here. ;-) We may get rid of synaptics driver rather
soon though. I'm going to help you to get there by encouraging users to report
the issues, they still see with libinput on bugs.freedesktop.org!

Thanks,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Nort

Re: [PATCH evdev] conf: rename to 65-evdev.conf

[Stefan Dirsch]

On Fri, May 20, 2016 at 11:47:45AM +1000, Peter Hutterer wrote:
> On Thu, May 19, 2016 at 05:37:59PM +0200, Stefan Dirsch wrote:
> > Bump up evdev driver to 65, so it get's perferred over libipnut,
> > which was dropped down to 60. Reason is, that evdev driver is more
> > of an additional driver, which likely won't be installed by default
> > on a system any longer. But if it is installed it should also be
> > used, i.e. preferred over libinput.
> > 
> > Similar to what was done for wacom configuration file.
> > 
> > https://bugzilla.suse.com/show_bug.cgi?id=979554
> > 
> > Signed-off-by: Stefan Dirsch <sndir...@suse.de>
> 
> nope, can't do this yet. evdev is still more flexible than libinput and
> handles a couple of devices that libinput doesn't handle. so we have to
> assume that for the time being evdev will be installed on most machines.

Thanks, Peter. This sounds reasonable. I'm going to revert my changes for SUSE
therefore, i.e. simply forget about my patch. ;-)

CU,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH evdev] conf: rename to 65-evdev.conf

[Stefan Dirsch]

Bump up evdev driver to 65, so it get's perferred over libipnut,
which was dropped down to 60. Reason is, that evdev driver is more
of an additional driver, which likely won't be installed by default
on a system any longer. But if it is installed it should also be
used, i.e. preferred over libinput.

Similar to what was done for wacom configuration file.

https://bugzilla.suse.com/show_bug.cgi?id=979554

Signed-off-by: Stefan Dirsch <sndir...@suse.de>
---
 10-evdev.conf | 40 
 65-evdev.conf | 40 
 Makefile.am   |  2 +-
 3 files changed, 41 insertions(+), 41 deletions(-)
 delete mode 100644 10-evdev.conf
 create mode 100644 65-evdev.conf

diff --git a/10-evdev.conf b/10-evdev.conf
deleted file mode 100644
index cc83ab2..000
--- a/10-evdev.conf
+++ /dev/null
@@ -1,40 +0,0 @@
-#
-# Catch-all evdev loader for udev-based systems
-# We don't simply match on any device since that also adds accelerometers
-# and other devices that we don't really want to use. The list below
-# matches everything but joysticks.
-
-Section "InputClass"
-Identifier "evdev pointer catchall"
-MatchIsPointer "on"
-MatchDevicePath "/dev/input/event*"
-Driver "evdev"
-EndSection
-
-Section "InputClass"
-Identifier "evdev keyboard catchall"
-MatchIsKeyboard "on"
-MatchDevicePath "/dev/input/event*"
-Driver "evdev"
-EndSection
-
-Section "InputClass"
-Identifier "evdev touchpad catchall"
-MatchIsTouchpad "on"
-MatchDevicePath "/dev/input/event*"
-Driver "evdev"
-EndSection
-
-Section "InputClass"
-Identifier "evdev tablet catchall"
-MatchIsTablet "on"
-MatchDevicePath "/dev/input/event*"
-Driver "evdev"
-EndSection
-
-Section "InputClass"
-Identifier "evdev touchscreen catchall"
-MatchIsTouchscreen "on"
-MatchDevicePath "/dev/input/event*"
-Driver "evdev"
-EndSection
diff --git a/65-evdev.conf b/65-evdev.conf
new file mode 100644
index 000..cc83ab2
--- /dev/null
+++ b/65-evdev.conf
@@ -0,0 +1,40 @@
+#
+# Catch-all evdev loader for udev-based systems
+# We don't simply match on any device since that also adds accelerometers
+# and other devices that we don't really want to use. The list below
+# matches everything but joysticks.
+
+Section "InputClass"
+Identifier "evdev pointer catchall"
+MatchIsPointer "on"
+MatchDevicePath "/dev/input/event*"
+Driver "evdev"
+EndSection
+
+Section "InputClass"
+Identifier "evdev keyboard catchall"
+MatchIsKeyboard "on"
+MatchDevicePath "/dev/input/event*"
+Driver "evdev"
+EndSection
+
+Section "InputClass"
+Identifier "evdev touchpad catchall"
+MatchIsTouchpad "on"
+MatchDevicePath "/dev/input/event*"
+Driver "evdev"
+EndSection
+
+Section "InputClass"
+Identifier "evdev tablet catchall"
+MatchIsTablet "on"
+MatchDevicePath "/dev/input/event*"
+Driver "evdev"
+EndSection
+
+Section "InputClass"
+Identifier "evdev touchscreen catchall"
+MatchIsTouchscreen "on"
+MatchDevicePath "/dev/input/event*"
+Driver "evdev"
+EndSection
diff --git a/Makefile.am b/Makefile.am
index 1cc3ea6..99e3b6c 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -28,7 +28,7 @@ MAINTAINERCLEANFILES = ChangeLog INSTALL
 pkgconfigdir = $(libdir)/pkgconfig
 pkgconfig_DATA = xorg-evdev.pc
 
-dist_xorgconf_DATA = 10-evdev.conf
+dist_xorgconf_DATA = 65-evdev.conf
 
 .PHONY: ChangeLog INSTALL
 
-- 
2.6.6

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH synaptics] conf: rename to 70-synaptics.conf

[Stefan Dirsch]

Bump up synaptics driver to 70, so it get's perferred over libipnut,
which was dropped down to 60. Reason is, that synaptics driver is more
of an additional driver, which then should be installed if installed.

Similar to what was done for wacom configuration file.

https://bugzilla.suse.com/show_bug.cgi?id=979554

Signed-off-by: Stefan Dirsch <sndir...@suse.de>
---
 conf/50-synaptics.conf | 46 --
 conf/70-synaptics.conf | 46 ++
 conf/Makefile.am   |  2 +-
 man/synaptics.man  |  2 +-
 4 files changed, 48 insertions(+), 48 deletions(-)
 delete mode 100644 conf/50-synaptics.conf
 create mode 100644 conf/70-synaptics.conf

diff --git a/conf/50-synaptics.conf b/conf/50-synaptics.conf
deleted file mode 100644
index aa50456..000
--- a/conf/50-synaptics.conf
+++ /dev/null
@@ -1,46 +0,0 @@
-# Example xorg.conf.d snippet that assigns the touchpad driver
-# to all touchpads. See xorg.conf.d(5) for more information on
-# InputClass.
-# DO NOT EDIT THIS FILE, your distribution will likely overwrite
-# it when updating. Copy (and rename) this file into
-# /etc/X11/xorg.conf.d first.
-# Additional options may be added in the form of
-#   Option "OptionName" "value"
-#
-Section "InputClass"
-Identifier "touchpad catchall"
-Driver "synaptics"
-MatchIsTouchpad "on"
-# This option is recommend on all Linux systems using evdev, but cannot be
-# enabled by default. See the following link for details:
-# http://who-t.blogspot.com/2010/11/how-to-ignore-configuration-errors.html
-#   MatchDevicePath "/dev/input/event*"
-EndSection
-
-Section "InputClass"
-Identifier "touchpad ignore duplicates"
-MatchIsTouchpad "on"
-MatchOS "Linux"
-MatchDevicePath "/dev/input/mouse*"
-Option "Ignore" "on"
-EndSection
-
-# This option enables the bottom right corner to be a right button on clickpads
-# and the right and middle top areas to be right / middle buttons on clickpads
-# with a top button area.
-# This option is only interpreted by clickpads.
-Section "InputClass"
-Identifier "Default clickpad buttons"
-MatchDriver "synaptics"
-Option "SoftButtonAreas" "50% 0 82% 0 0 0 0 0"
-Option "SecondarySoftButtonAreas" "58% 0 0 15% 42% 58% 0 15%"
-EndSection
-
-# This option disables software buttons on Apple touchpads.
-# This option is only interpreted by clickpads.
-Section "InputClass"
-Identifier "Disable clickpad buttons on Apple touchpads"
-MatchProduct "Apple|bcm5974"
-MatchDriver "synaptics"
-Option "SoftButtonAreas" "0 0 0 0 0 0 0 0"
-EndSection
diff --git a/conf/70-synaptics.conf b/conf/70-synaptics.conf
new file mode 100644
index 000..aa50456
--- /dev/null
+++ b/conf/70-synaptics.conf
@@ -0,0 +1,46 @@
+# Example xorg.conf.d snippet that assigns the touchpad driver
+# to all touchpads. See xorg.conf.d(5) for more information on
+# InputClass.
+# DO NOT EDIT THIS FILE, your distribution will likely overwrite
+# it when updating. Copy (and rename) this file into
+# /etc/X11/xorg.conf.d first.
+# Additional options may be added in the form of
+#   Option "OptionName" "value"
+#
+Section "InputClass"
+Identifier "touchpad catchall"
+Driver "synaptics"
+MatchIsTouchpad "on"
+# This option is recommend on all Linux systems using evdev, but cannot be
+# enabled by default. See the following link for details:
+# http://who-t.blogspot.com/2010/11/how-to-ignore-configuration-errors.html
+#   MatchDevicePath "/dev/input/event*"
+EndSection
+
+Section "InputClass"
+Identifier "touchpad ignore duplicates"
+MatchIsTouchpad "on"
+MatchOS "Linux"
+MatchDevicePath "/dev/input/mouse*"
+Option "Ignore" "on"
+EndSection
+
+# This option enables the bottom right corner to be a right button on clickpads
+# and the right and middle top areas to be right / middle buttons on clickpads
+# with a top button area.
+# This option is only interpreted by clickpads.
+Section "InputClass"
+Identifier "Default clickpad buttons"
+MatchDriver "synaptics"
+Option "SoftButtonAreas" "50% 0 82% 0 0 0 0 0"
+Option "SecondarySoftButtonAreas" "58% 0 0 15% 42% 58% 0 15%"
+EndSection
+
+# This option disables software buttons on Apple touchpads.
+# This option is only interpreted by clickpads.
+Section "InputClass"
+Identifier "Disable clickpad butt

Re: [PATCH mkfontscale] fix handling of Type1 fonts without /FamilyName and/or /FullName

[Stefan Dirsch]

On Tue, May 10, 2016 at 10:18:59AM -0400, Adam Jackson wrote:
> On Tue, 2016-05-10 at 16:01 +0200, Stefan Dirsch wrote:
> > https://bugzilla.opensuse.org/show_bug.cgi?id=918466
> > 
> > Signed-off-by: Stefan Dirsch <sndir...@suse.de>
> > Reviewed-by: Adam Jackson <a...@redhat.com>
> 
> What I meant by that was "looks good, feel free to push". Your fdo
> account does seem to be in the xorg group, let me know if you need an
> ssh key updated or something.

... app/mkfontscale# git push
Counting objects: 3, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 534 bytes | 0 bytes/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Updating patchwork state for
https://patchwork.freedesktop.org/project/Xorg/list/
remote: I: patch #82710 updated using rev
ecb248d8865df376a97a795c2e4f58a3bf64c3f1.
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/app/mkfontscale
   87d628f..ecb248d  master -> master

Yeah. Seems to have worked. Please let me know in case I messed up anything!

Thanks,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH mkfontscale] fix handling of Type1 fonts without /FamilyName and/or /FullName

[Stefan Dirsch]

https://bugzilla.opensuse.org/show_bug.cgi?id=918466

Signed-off-by: Stefan Dirsch <sndir...@suse.de>
Reviewed-by: Adam Jackson <a...@redhat.com>
---
 mkfontscale.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/mkfontscale.c b/mkfontscale.c
index da93e0c..e9b9488 100644
--- a/mkfontscale.c
+++ b/mkfontscale.c
@@ -579,11 +579,14 @@ makeXLFD(char *filename, FT_Face face, int isBitmap)
 }
 
 if(t1info) {
-if(!family)
+if(!family && t1info->family_name)
 family = strdup(t1info->family_name);
-if(!family)
+if(!family && t1info->full_name)
 family = strdup(t1info->full_name);
-if(!full_name)
+/* Hershey fonts miss /FamilyName */
+if(!family && face->family_name)
+family = strdup(face->family_name);
+if(!full_name && t1info->full_name)
 full_name = strdup(t1info->full_name);
 if(!foundry)
 foundry = notice_foundry(t1info->notice);
-- 
2.6.6

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH mkfontscale] fix handling of Type1 fonts without /FamilyName and/or /FullName

[Stefan Dirsch]

https://bugzilla.opensuse.org/show_bug.cgi?id=918466

Signed-off-by: Stefan Dirsch <sndir...@suse.de>
---
 mkfontscale.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/mkfontscale.c b/mkfontscale.c
index da93e0c..e9b9488 100644
--- a/mkfontscale.c
+++ b/mkfontscale.c
@@ -579,11 +579,14 @@ makeXLFD(char *filename, FT_Face face, int isBitmap)
 }
 
 if(t1info) {
-if(!family)
+if(!family && t1info->family_name)
 family = strdup(t1info->family_name);
-if(!family)
+if(!family && t1info->full_name)
 family = strdup(t1info->full_name);
-if(!full_name)
+/* Hershey fonts miss /FamilyName */
+if(!family && face->family_name)
+family = strdup(face->family_name);
+if(!full_name && t1info->full_name)
 full_name = strdup(t1info->full_name);
 if(!foundry)
 foundry = notice_foundry(t1info->notice);
-- 
2.6.6

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] XDMCP: For IPv6 add IPv6 link local addresses to the end of the list

[Stefan Dirsch]

On Fri, Apr 29, 2016 at 09:40:05AM +0200, Julien Cristau wrote:
> On Thu, Apr 28, 2016 at 15:21:15 +0200, Stefan Dirsch wrote:
> 
> > From: Reinhard Max <m...@suse.de>
> > 
> > For IPv6 add a link local addresses to the end of the list passed to
> > the XDMCP servers.
> > Reason: for link local addresses the XDMCP server would need to either
> > know the interface thru a scope identifier or try all available interfaces.
> > If they don't this address will fail in which case the XDMCP server
> > could still try the other addresses passed - however some only try
> > the first address and then give up.
> > Even if this seems to be the wrong place to fix this it seems to be
> > easier than fixing all display servers.
> 
> Commit message says "add to the end of the list", code says "ignore",
> which is it?

Good question. Maybe Reinhard still remembers. Meanwhile I found slightly
different descriptions for the patch. Seems the patch changed in between.
Sigh.

Thu Aug 19 14:34:02 CEST 2010 - m...@suse.de
- Replaced the previous xdmcp fix with a simpler approach that
  doesn't cause login problems in xdm and kdm.
  bnc#462283, bnc#625598
  https://bugzilla.opensuse.org/show_bug.cgi?id=462283
  https://bugzilla.opensuse.org/show_bug.cgi?id=625598

Wed Jul 28 05:11:59 CEST 2010 - sndir...@suse.de
- Fix some shortcomings in the xdmcp implementation. It used to
  suppress loopback addresses from the list of potential display
  addresses to report to xdm, even when talking to xdm through
  a loopback address. Now only display addresses of the same kind
  as the xdm connection are reported to xdm.

  This most notably helps Xvnc servers contacting the local xdm,
  because they were severely affected by the suppression of
  loopback addresses. (xorg-server-xdmcp.patch, Reinhard Max)

I agree, that it doesn't make sense to accept patches, which are no longer
fully understood by downstream and/or not yet fully understood by
upstream. ;-)

Thanks,
Stefan

> >  os/access.c | 12 +++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/os/access.c b/os/access.c
> > index 58f95a9..f44d93e 100644
> > --- a/os/access.c
> > +++ b/os/access.c
> > @@ -827,7 +827,9 @@ DefineSelf(int fd)
> >  
> >  /*
> >   * ignore 'localhost' entries as they're not useful
> > - * on the other end of the wire
> > + * on the other end of the wire and because on hosts
> > + * with shared home dirs they'll result in conflicting
> > + * entries in ~/.Xauthority
> >   */
> >  if (ifr->ifa_flags & IFF_LOOPBACK)
> >  continue;
> > @@ -848,6 +850,14 @@ DefineSelf(int fd)
> >  else if (family == FamilyInternet6 &&
> >   IN6_IS_ADDR_LOOPBACK((struct in6_addr *) addr))
> >  continue;
> > +
> > +  /* Ignore IPv6 link local addresses (fe80::/10), because
> > +   * they need a scope identifier, which we have no way
> > +   * of telling to the other end.
> > +   */
> > +  if (family == FamilyInternet6 &&
> > + IN6_IS_ADDR_LINKLOCAL((struct in6_addr *)addr))
> > + continue;
> >  #endif
> >  XdmcpRegisterConnection(family, (char *) addr, len);
> >  #if defined(IPv6) && defined(AF_INET6)
> > -- 
> > 2.6.2

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH xserver] ad hoc fix for mmap's truncated offset parameter on 32bit

[Stefan Dirsch]

On Fri, Apr 29, 2016 at 10:24:17AM +0200, Mark Kettenis wrote:
> > Date: Fri, 29 Apr 2016 09:34:08 +0200
> > From: Julien Cristau <jcris...@debian.org>
> > 
> > On Thu, Apr 28, 2016 at 16:10:01 +0200, Mark Kettenis wrote:
> > 
> > > > From: Stefan Dirsch <sndir...@suse.de>
> > > > Date: Thu, 28 Apr 2016 14:35:00 +0200
> > > > 
> > > > Builtin modesetting driver didn't work on 32bit on cirrus KMS. See
> > > > https://bugzilla.suse.com/show_bug.cgi?id=917385 for more details.
> > > 
> > > I think selectively compiling with -D_FILE_OFFSET_BITS=64 is a
> > > seriously bad idea.  Either evrything should be compiled with that
> > > switch, or nothing.  And adding a #define like that after including
> > > some other header files is even worse.
> > > 
> > I think the right fix for the referenced bug was
> > https://cgit.freedesktop.org/xorg/xserver/commit/?id=4962c8c08842d9d3ca66d254b1ce4cacc4fb3756
> > so this patch should not be necessary anyway.
> 
> Yup.  That should do it.  I agree that this patch shouldn't be
> necessary anymore.

I agree. Sorry for the noise. It wasn't too obvious to me, that the issue was
already addressed upstream.

Thanks,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver] XDMCP: For IPv6 add IPv6 link local addresses to the end of the list

[Stefan Dirsch]

From: Reinhard Max 

For IPv6 add a link local addresses to the end of the list passed to
the XDMCP servers.
Reason: for link local addresses the XDMCP server would need to either
know the interface thru a scope identifier or try all available interfaces.
If they don't this address will fail in which case the XDMCP server
could still try the other addresses passed - however some only try
the first address and then give up.
Even if this seems to be the wrong place to fix this it seems to be
easier than fixing all display servers.
---
 os/access.c | 12 +++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/os/access.c b/os/access.c
index 58f95a9..f44d93e 100644
--- a/os/access.c
+++ b/os/access.c
@@ -827,7 +827,9 @@ DefineSelf(int fd)
 
 /*
  * ignore 'localhost' entries as they're not useful
- * on the other end of the wire
+ * on the other end of the wire and because on hosts
+ * with shared home dirs they'll result in conflicting
+ * entries in ~/.Xauthority
  */
 if (ifr->ifa_flags & IFF_LOOPBACK)
 continue;
@@ -848,6 +850,14 @@ DefineSelf(int fd)
 else if (family == FamilyInternet6 &&
  IN6_IS_ADDR_LOOPBACK((struct in6_addr *) addr))
 continue;
+
+  /* Ignore IPv6 link local addresses (fe80::/10), because
+   * they need a scope identifier, which we have no way
+   * of telling to the other end.
+   */
+  if (family == FamilyInternet6 &&
+ IN6_IS_ADDR_LINKLOCAL((struct in6_addr *)addr))
+ continue;
 #endif
 XdmcpRegisterConnection(family, (char *) addr, len);
 #if defined(IPv6) && defined(AF_INET6)
-- 
2.6.2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] uxa: fix missing includes for fstat

[Stefan Dirsch]

On Thu, Apr 28, 2016 at 11:31:51AM +0200, Julien Cristau wrote:
> On Thu, Apr 28, 2016 at 11:06:38 +0200, Stefan Dirsch wrote:
> 
> > On Wed, Apr 27, 2016 at 11:23:10PM +0100, Emil Velikov wrote:
> > > P.S. For xorg-devel patches please set the correct prefix $ git config
> > > --local format.subjectPrefix "PATCH foo". With foo being the
> > > respective project.
> > 
> > Ok. Will do that. Is there a an official policy available for submitting
> > patches to xorg-devel like it exists for Mesa
> > (http://mesa3d.org/devinfo.html#submitting)?
> > 
> http://www.x.org/wiki/Development/Documentation/SubmittingPatches/

Thanks a lot! Very useful indeed!

Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver] Change include order to avoid conflict with system header

[Stefan Dirsch]

From: Andreas Schwab 

R_SP is also defined in  on m68k.
Also remove duplicate definitions.

Signed-off-by: Andreas Schwab 
---
 hw/xfree86/int10/xf86x86emu.c   | 2 +-
 hw/xfree86/x86emu/x86emu/regs.h | 8 
 2 files changed, 1 insertion(+), 9 deletions(-)

diff --git a/hw/xfree86/int10/xf86x86emu.c b/hw/xfree86/int10/xf86x86emu.c
index 4b0a130..1dc695d 100644
--- a/hw/xfree86/int10/xf86x86emu.c
+++ b/hw/xfree86/int10/xf86x86emu.c
@@ -7,13 +7,13 @@
 #include 
 #endif
 
-#include 
 #include "xf86.h"
 #include "xf86_OSproc.h"
 #include "xf86Pci.h"
 #define _INT10_PRIVATE
 #include "xf86int10.h"
 #include "int10Defines.h"
+#include 
 
 #define M _X86EMU_env
 
diff --git a/hw/xfree86/x86emu/x86emu/regs.h b/hw/xfree86/x86emu/x86emu/regs.h
index c040259..3c9469f 100644
--- a/hw/xfree86/x86emu/x86emu/regs.h
+++ b/hw/xfree86/x86emu/x86emu/regs.h
@@ -158,14 +158,6 @@ struct i386_segment_regs {
 #define R_FLG spc.FLAGS
 
 /* special registers */
-#define R_SP  spc.SP.I16_reg.x_reg
-#define R_BP  spc.BP.I16_reg.x_reg
-#define R_SI  spc.SI.I16_reg.x_reg
-#define R_DI  spc.DI.I16_reg.x_reg
-#define R_IP  spc.IP.I16_reg.x_reg
-#define R_FLG spc.FLAGS
-
-/* special registers */
 #define R_ESP  spc.SP.I32_reg.e_reg
 #define R_EBP  spc.BP.I32_reg.e_reg
 #define R_ESI  spc.SI.I32_reg.e_reg
-- 
2.6.2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH xserver] ad hoc fix for mmap's truncated offset parameter on 32bit

[Stefan Dirsch]

Builtin modesetting driver didn't work on 32bit on cirrus KMS. See
https://bugzilla.suse.com/show_bug.cgi?id=917385 for more details.

Signed-off-by: Stefan Dirsch <sndir...@suse.de>
---
 hw/xfree86/drivers/modesetting/dumb_bo.c | 6 ++
 1 file changed, 6 insertions(+)

diff --git a/hw/xfree86/drivers/modesetting/dumb_bo.c 
b/hw/xfree86/drivers/modesetting/dumb_bo.c
index cf13f0a..42abe8b 100644
--- a/hw/xfree86/drivers/modesetting/dumb_bo.c
+++ b/hw/xfree86/drivers/modesetting/dumb_bo.c
@@ -29,6 +29,12 @@
 #include "dix-config.h"
 #endif
 
+/*
+ * ad hoc fix for mmap's truncated offset parameter on 32bit
+ * see also https://bugzilla.suse.com/show_bug.cgi?id=917385
+ */
+#define _FILE_OFFSET_BITS 64
+
 #include "dumb_bo.h"
 
 #include 
-- 
2.6.2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH vesa] Use default refresh by default

[Stefan Dirsch]

This seems to be a feature that isn't tested well. Too many VBE 3.0
BIOSes are incorrectly implemented.

Signed-off-by: Stefan Dirsch <sndir...@suse.de>
---
 src/vesa.c | 8 +---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/vesa.c b/src/vesa.c
index 5b9ccb0..e51effe 100644
--- a/src/vesa.c
+++ b/src/vesa.c
@@ -838,9 +838,11 @@ VESAPreInit(ScrnInfoPtr pScrn, int flags)
 /* Use shadow by default */
 pVesa->shadowFB = xf86ReturnOptValBool(pVesa->Options, OPTION_SHADOW_FB,
TRUE);
-
-if (xf86ReturnOptValBool(pVesa->Options, OPTION_DFLT_REFRESH, FALSE))
-   pVesa->defaultRefresh = TRUE;
+/*  Use default refresh by default. Too many VBE 3.0
+ *   BIOSes are incorrectly implemented.
+ */
+pVesa->defaultRefresh = xf86ReturnOptValBool(pVesa->Options,
+ OPTION_DFLT_REFRESH, TRUE);
 
 pVesa->ModeSetClearScreen =
 xf86ReturnOptValBool(pVesa->Options,
-- 
2.6.2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] uxa: fix missing includes for fstat

[Stefan Dirsch]

On Wed, Apr 27, 2016 at 11:23:10PM +0100, Emil Velikov wrote:
> On 26 April 2016 at 15:07, Stefan Dirsch <sndir...@suse.de> wrote:
> > On Tue, Apr 26, 2016 at 01:51:39PM +0100, Chris Wilson wrote:
> >> On Tue, Apr 26, 2016 at 02:42:52PM +0200, Stefan Dirsch wrote:
> >> > From: Dominique Leuenberger <dims...@opensuse.org>
> >> >
> >> > Without these headers, we can run into build errors like:
> >>
> >> sys/stat.h is already included. Curious.
> >> -Chris
> >
> > I can't see it included by uxa/intel_driver.c. Build still fails for me with
> >
> >   -Werror=implicit-function-declaration
> >
> > being set. Same applies to the patch for sna/intel_driver.c.
> >
> Seems like you've got out of date tree in there.
> 
> commit 369ceec0e4910ba2c37736a59c55c0d6c26433bf
> Author: Chris Wilson <ch...@chris-wilson.co.uk>
> Date:   Tue Feb 24 15:25:40 2015 +
> 
> uxa: udev integration depends on fstat and sys/stat.h
> 
> src/uxa/intel_driver.c: In function 'I830HandleUEvents':
> src/uxa/intel_driver.c:738:14: error: storage size of 's' isn't known
> src/uxa/intel_driver.c:746:2: error: implicit declaration of
> function 'fstat' [-Werror=implicit-function-declaration]
> 
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
> 
> diff --git a/src/uxa/intel_driver.c b/src/uxa/intel_driver.c
> ...

You're right. I must have made something stupid. Probably messed up 2.99.917
and git master. Sorry for the noise!

> P.S. For xorg-devel patches please set the correct prefix $ git config
> --local format.subjectPrefix "PATCH foo". With foo being the
> respective project.

Ok. Will do that. Is there a an official policy available for submitting
patches to xorg-devel like it exists for Mesa
(http://mesa3d.org/devinfo.html#submitting)?

Thanks,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] Disable tiling on SuperSavage by default

[Stefan Dirsch]

On Wed, Apr 27, 2016 at 05:24:53PM -0400, Adam Jackson wrote:
> On Wed, 2016-04-27 at 16:16 +0200, Hans de Goede wrote:
> > Hi,
> > 
> > On 27-04-16 16:02, Stefan Dirsch wrote:
> > > Xserver cannot be started with Tiling enabled on SuperSavage.
> > > https://bugzilla.opensuse.org/show_bug.cgi?id=805380
> > > 
> > > Signed-off-by: Stefan Dirsch <sndir...@suse.de>
> > 
> > Given the age of these chips I believe that this is the best we can do:
> > 
> > Acked-by: Hans de Goede <hdego...@redhat.com>
> 
> remote: I: patch #84023 updated using rev 
> de61497415e58a21fa247faf6db180ca47fb5df0.
> remote: I: 1 patch(es) updated to state Accepted.
> To ssh://git.freedesktop.org/git/xorg/driver/xf86-video-savage
>f8f24e6..de61497  master -> master

Thanks for pushing!

Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] Use 16bpp when running in virt and on XenSource gfx

[Stefan Dirsch]

On Wed, Apr 27, 2016 at 11:59:43AM -0400, Adam Jackson wrote:
> On Tue, 2016-04-26 at 13:57 +0200, Stefan Dirsch wrote:
> > From: Frederic Crozat <fcro...@suse.com>
> > 
> > Due to graphics corruption default to 16bpp in virt instead of 24 (Fedora).
> > Do the same on XenSource gfx, which suffers from the same issue.
> 
> remote: I: patch #83711 updated using rev 
> 82db44fe8a726a4a1192b1b93992b642d0ec17b3.
> remote: I: 1 patch(es) updated to state Accepted.
> To ssh://git.freedesktop.org/git/xorg/driver/xf86-video-cirrus
>23da607..82db44f  master -> master

Nice. Thanks for pushing!

Stefan

Public Key available
------
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] Disable "acceleration" under qemu

[Stefan Dirsch]

On Wed, Apr 27, 2016 at 11:54:49AM -0400, Adam Jackson wrote:
> On Tue, 2016-04-26 at 16:26 +0200, Stefan Dirsch wrote:
> > Disable "acceleration" under qemu, since taking the hypercall trap
> > is really quite expensive and you're better off doing noaccel. Patch
> > is based on the one by "Adam Jackson" <a...@redhat.com>
> 
> ... if that _is_ his real name.
> 
> Apologies for letting this rot, I'd forgotten all about it when we
> switched to the KMS driver.

which happened at SUSE as well. ;-)

> remote: I: patch #83710 updated using rev 
> 23da6073369ef6a99d1789de967e57359d1fe3b0.
> remote: I: 1 patch(es) updated to state Accepted.
> To ssh://git.freedesktop.org/git/xorg/driver/xf86-video-cirrus
>3a2e2d9..23da607  master -> master

Nice. Thanks for pushing!

Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] Disable tiling on SuperSavage by default

[Stefan Dirsch]

Xserver cannot be started with Tiling enabled on SuperSavage.
https://bugzilla.opensuse.org/show_bug.cgi?id=805380

Signed-off-by: Stefan Dirsch <sndir...@suse.de>
---
 src/savage_driver.c | 6 +-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/savage_driver.c b/src/savage_driver.c
index d278345..58a294d 100644
--- a/src/savage_driver.c
+++ b/src/savage_driver.c
@@ -1668,7 +1668,11 @@ static Bool SavagePreInit(ScrnInfoPtr pScrn, int flags)
 #endif
 
 /* we can use Option "DisableTile TRUE" to disable tile mode */
-psav->bDisableTile = FALSE; 
+if (psav->Chipset == S3_SUPERSAVAGE)
+/* apparently broken with these GPUs, see 
https://bugzilla.opensuse.org/show_bug.cgi?id=805380 */
+   psav->bDisableTile = TRUE;
+else
+   psav->bDisableTile = FALSE;
 if (xf86GetOptValBool(psav->Options, 
OPTION_DISABLE_TILE,>bDisableTile)) {
 xf86DrvMsg(pScrn->scrnIndex, X_CONFIG,
"Option: %s Tile Mode and Program it 
\n",(psav->bDisableTile?"Disable":"Enable"));
-- 
2.6.2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] Avoid 10x7 heuristic, handled by server

[Stefan Dirsch]

On Tue, Apr 26, 2016 at 03:49:12PM +0200, Julien Cristau wrote:
> On Tue, Apr 26, 2016 at 14:09:24 +0200, Stefan Dirsch wrote:
> 
> > On Tue, Apr 26, 2016 at 12:58:55PM +0200, Julien Cristau wrote:
> > > On Tue, Apr 26, 2016 at 11:45:15 +0200, Stefan Dirsch wrote:
> > > 
> > > > From: Frederic Crozat <fcro...@suse.com>
> > > > 
> > > > Remove the 10x7 heuristic, since the server has equivalent code now.
> > > > Instead, disable "acceleration" under qemu, since taking the hypercall
> > > > trap is really quite expensive and you're better off doing noaccel.
> > > > (Fedora)
> > > > ---
> > > >  src/alp_driver.c | 7 +++
> > > >  1 file changed, 7 insertions(+)
> > > > 
> > > What does "the 10x7 heuristic" refer to?  Maybe
> > > http://pkgs.fedoraproject.org/cgit/rpms/xorg-x11-drv-cirrus.git/tree/cirrus-1.2.0-qemu.patch?id=b726ffdd66d6aaf49c64f999eb2c004e1d5041fb
> > > which is an earlier version of this patch?
> > 
> > Wow! Thanks for the pointer. Honestly I never understood the comment, since
> > today I've seen the original patch the first time. ;-) LOL!
> > 
> > > (Also, authorship seems wrong, if you took this patch from Fedora, it
> > > should be attributed to ajax afaict:
> > > http://pkgs.fedoraproject.org/cgit/rpms/xorg-x11-drv-cirrus.git/log/cirrus-1.2.0-qemu.patch
> > 
> > Ok. Since the patch we're using is obviously no longer related to Ajax'
> > original one I keep it attributed to Frederic. Unless he or you're vetoing. 
> > I
> > could add "very loosely based on Ajax' patch" though.
> > 
> The patch you're using today seems to be pretty much the same as
> http://pkgs.fedoraproject.org/cgit/rpms/xorg-x11-drv-cirrus.git/tree/cirrus-1.2.0-qemu.patch?id=daccd1c8174623500eddfa297d8ea76a86d3c5d9

Indeed. Apparently Frederic didn't make the changes himself, but instead
updated the patch from Fedora. This is again news for me. Things are getting
more and more embarassing. Sigh.

Be assured I only want to be a good citizen and bring "our" patches upstream.
It hasn't been my intention to attribute the patch to the wrong person. I've
resent the patch to the list making myself the author and added to the commit
message, that the patch is based on the one by Ajax. And added the reference
to it. I'm not sure whether this is any better. Feel free to comment.

Thanks,
Stefan

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] Disable "acceleration" under qemu

[Stefan Dirsch]

Disable "acceleration" under qemu, since taking the hypercall trap
is really quite expensive and you're better off doing noaccel. Patch
is based on the one by "Adam Jackson" 

http://pkgs.fedoraproject.org/cgit/rpms/xorg-x11-drv-cirrus.git/tree/cirrus-1.2.0-qemu.patch?id=daccd1c8174623500eddfa297d8ea76a86d3c5d9
---
 src/alp_driver.c | 10 ++
 1 file changed, 10 insertions(+)

diff --git a/src/alp_driver.c b/src/alp_driver.c
index bd5e52f..ba55247 100644
--- a/src/alp_driver.c
+++ b/src/alp_driver.c
@@ -774,6 +774,16 @@ AlpPreInit(ScrnInfoPtr pScrn, int flags)
  else
xf86SetDDCproperties(pScrn,xf86PrintEDID(
 xf86DoEDID_DDC2(XF86_SCRN_ARG(pScrn),pCir->I2CPtr1)));
+
+#ifdef XSERVER_LIBPCIACCESS
+ #ifndef PCI_CHIP_QEMU
+ #define PCI_CHIP_QEMU 0x1af4
+ #endif
+ if (!pScrn->monitor->DDC &&
+   ((pCir->PciInfo->subvendor_id & 0x) == PCI_CHIP_QEMU)) {
+   pCir->NoAccel = TRUE;
+ }
+#endif
  
  /* Probe the possible LCD display */
  AlpProbeLCD(pScrn);
-- 
2.6.2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] uxa: fix missing includes for fstat

[Stefan Dirsch]

On Tue, Apr 26, 2016 at 01:51:39PM +0100, Chris Wilson wrote:
> On Tue, Apr 26, 2016 at 02:42:52PM +0200, Stefan Dirsch wrote:
> > From: Dominique Leuenberger <dims...@opensuse.org>
> > 
> > Without these headers, we can run into build errors like:
> 
> sys/stat.h is already included. Curious.
> -Chris

I can't see it included by uxa/intel_driver.c. Build still fails for me with

  -Werror=implicit-function-declaration 

being set. Same applies to the patch for sna/intel_driver.c.

Thanks,
Stefan

Public Key available
----------
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] sna: fix missing includes for fstat

[Stefan Dirsch]

From: Dominique Leuenberger 

In order for fstat to be usable, sys/stat.h needs to be included or we
might end up in a build failure like:

sna_driver.c: In function 'sna_handle_uevents':
sna_driver.c:799:6: error: implicit declaration of function 'fstat' 
[-Werror=implicit-function-declaration]
---
 src/sna/sna_driver.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/sna/sna_driver.c b/src/sna/sna_driver.c
index b245594..2852299 100644
--- a/src/sna/sna_driver.c
+++ b/src/sna/sna_driver.c
@@ -67,6 +67,7 @@ USE OR OTHER DEALINGS IN THE SOFTWARE.
 #include 
 #include 
 #include 
+#include 
 #include "i915_drm.h"
 
 #ifdef HAVE_VALGRIND
-- 
2.6.2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] uxa: fix missing includes for fstat

[Stefan Dirsch]

From: Dominique Leuenberger 

Without these headers, we can run into build errors like:

intel_driver.c: In function 'I830HandleUEvents':
intel_driver.c:745:14: error: storage size of 's' isn't known

intel_video.c:104:39: warning: initialization discards 'const' qualifier from 
pointer target type [-Wdiscarded-qualifiers]
{XvSettable | XvGettable, -128, 127, "XV_BRIGHTNESS"},
   ^
intel_driver.c:753:6: error: implicit declaration of function 'fstat' 
[-Werror=implicit-function-declaration]
---
 src/uxa/intel_driver.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/uxa/intel_driver.c b/src/uxa/intel_driver.c
index 8f76b34..2cf5998 100644
--- a/src/uxa/intel_driver.c
+++ b/src/uxa/intel_driver.c
@@ -44,6 +44,8 @@ USE OR OTHER DEALINGS IN THE SOFTWARE.
 #include 
 #include 
 #include 
+#include 
+#include 
 
 #include "xorg-server.h"
 #include "xf86.h"
-- 
2.6.2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] Avoid 10x7 heuristic, handled by server

[Stefan Dirsch]

On Tue, Apr 26, 2016 at 11:57:27AM +0200, Mark Kettenis wrote:
> > From: Stefan Dirsch <sndir...@suse.de>
> > Date: Tue, 26 Apr 2016 11:45:15 +0200
> > 
> > From: Frederic Crozat <fcro...@suse.com>
> > 
> > Remove the 10x7 heuristic, since the server has equivalent code now.
> > Instead, disable "acceleration" under qemu, since taking the hypercall
> > trap is really quite expensive and you're better off doing noaccel.
> > (Fedora)
> 
> Same comment (about magic numbers) applies here.
> 
> A #define for the PCI subvendor is probably self-documenting.

Thanks. Fixed this by trying to keep it independant from the first patch,
which also uses QEMU subvendor ID. Resent a few minutes ago.

Stefan

> > ---
> >  src/alp_driver.c | 7 +++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/src/alp_driver.c b/src/alp_driver.c
> > index bd5e52f..da31321 100644
> > --- a/src/alp_driver.c
> > +++ b/src/alp_driver.c
> > @@ -774,6 +774,13 @@ AlpPreInit(ScrnInfoPtr pScrn, int flags)
> >   else
> > xf86SetDDCproperties(pScrn,xf86PrintEDID(
> >  xf86DoEDID_DDC2(XF86_SCRN_ARG(pScrn),pCir->I2CPtr1)));
> > +
> > +#ifdef XSERVER_LIBPCIACCESS
> > + if (!pScrn->monitor->DDC &&
> > +   ((pCir->PciInfo->subvendor_id & 0x) == 0x1af4)) {
> > +   pCir->NoAccel = TRUE;
> > + }
> > +#endif
> >   
> >   /* Probe the possible LCD display */
> >   AlpProbeLCD(pScrn);
> > -- 
> > 2.6.2

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] Use 16bpp when running in virt and on XenSource gfx

[Stefan Dirsch]

From: Frederic Crozat 

Due to graphics corruption default to 16bpp in virt instead of 24 (Fedora).
Do the same on XenSource gfx, which suffers from the same issue.
---
 src/alp_driver.c | 11 ++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/src/alp_driver.c b/src/alp_driver.c
index da31321..6abb476 100644
--- a/src/alp_driver.c
+++ b/src/alp_driver.c
@@ -466,6 +466,7 @@ AlpPreInit(ScrnInfoPtr pScrn, int flags)
vgaHWPtr hwp;
MessageType from, from1;
int i;
+   int defaultdepth;
int depth_flags;
ClockRangePtr clockRanges;
char *s;
@@ -551,11 +552,19 @@ AlpPreInit(ScrnInfoPtr pScrn, int flags)
depth_flags |= Support32bppFb |
   SupportConvert32to24 |
   PreferConvert32to24;
+
+   /* use 16bpp in virt */
+   if (((pCir->PciInfo->subvendor_id & 0x) == 0x1af4) ||
+   ((pCir->PciInfo->subvendor_id & 0x) == 0x5853))
+   defaultdepth = 16;
+   else
+   defaultdepth = 24;
+
/*
 * The first thing we should figure out is the depth, bpp, etc.
 * We support both 24bpp and 32bpp layouts, so indicate that.
 */
-   if (!xf86SetDepthBpp(pScrn, 0, 0, 24, depth_flags)) {
+   if (!xf86SetDepthBpp(pScrn, 0, 0, defaultdepth, depth_flags)) {
return FALSE;
} else {
/* Check that the returned depth is one we support */
-- 
2.6.2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] Avoid 10x7 heuristic, handled by server

[Stefan Dirsch]

From: Frederic Crozat 

Remove the 10x7 heuristic, since the server has equivalent code now.
Instead, disable "acceleration" under qemu, since taking the hypercall
trap is really quite expensive and you're better off doing noaccel.
(Fedora)
---
 src/alp_driver.c | 7 +++
 1 file changed, 7 insertions(+)

diff --git a/src/alp_driver.c b/src/alp_driver.c
index bd5e52f..da31321 100644
--- a/src/alp_driver.c
+++ b/src/alp_driver.c
@@ -774,6 +774,13 @@ AlpPreInit(ScrnInfoPtr pScrn, int flags)
  else
xf86SetDDCproperties(pScrn,xf86PrintEDID(
 xf86DoEDID_DDC2(XF86_SCRN_ARG(pScrn),pCir->I2CPtr1)));
+
+#ifdef XSERVER_LIBPCIACCESS
+ if (!pScrn->monitor->DDC &&
+   ((pCir->PciInfo->subvendor_id & 0x) == 0x1af4)) {
+   pCir->NoAccel = TRUE;
+ }
+#endif
  
  /* Probe the possible LCD display */
  AlpProbeLCD(pScrn);
-- 
2.6.2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] libpciaccess/vgaarb: add function to get default vga device and it's decodes.

[Stefan Dirsch]

On Sun, Apr 24, 2016 at 05:17:48PM +0200, Julien Cristau wrote:
> On Thu, Apr 21, 2016 at 15:22:36 +0200, Stefan Dirsch wrote:
> 
> > From: Egbert Eich <e...@freedesktop.org>
> > 
> > Reenable default device when shutting down VGA arbitration.
> > https://bugzilla.opensuse.org/show_bug.cgi?id=714677
> > ---
> >  src/common_vgaarb.c | 9 +
> >  1 file changed, 9 insertions(+)
> > 
> I don't understand how the patch description relates to the patch.  This
> doesn't seem to add a function...

Indeed. I believe this patch description was inspired by the changes, which
were needed for xorg-server 1.6.5, which we needed in addition. These are in
meanwhile.

Egbert will respond or resend the patch to the ML once time permits. Sorry for
the noise!

Thanks,
Stefan

> > diff --git a/src/common_vgaarb.c b/src/common_vgaarb.c
> > index 7a7d204..2c0686e 100644
> > --- a/src/common_vgaarb.c
> > +++ b/src/common_vgaarb.c
> > @@ -156,6 +156,11 @@ pci_device_vgaarb_fini(void)
> >  {
> >  if (!pci_sys)
> >  return;
> > +if (pci_device_vgaarb_set_target(NULL) < 0 ||
> > +   pci_device_vgaarb_lock() < 0 ||
> > +   pci_device_vgaarb_unlock() < 0) {
> > +   fprintf(stderr, "VGA Arbitration: Cannot restore default device.\n");
> > +}
> >  
> >  close(pci_sys->vgaarb_fd);
> >  }
> > @@ -334,6 +339,10 @@ pci_device_vgaarb_unlock(void)
> >  int pci_device_vgaarb_get_info(struct pci_device *dev, int *vga_count, int 
> > *rsrc_decodes)
> >  {
> >  *vga_count = pci_sys->vga_count;
> > +if (!rsrc_decodes)
> > +return 0;
> > +if (!dev)
> > +dev = pci_sys->vga_default_dev;
> >  if (!dev)
> >  return 0;
> >  
> > -- 
> > 2.6.2
> > 
> > _______
> > xorg-devel@lists.x.org: X.Org development
> > Archives: http://lists.x.org/archives/xorg-devel
> > Info: https://lists.x.org/mailman/listinfo/xorg-devel

Public Key available
--
Stefan Dirsch (Res. & Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] fix handling of Type1 fonts without /FamilyName and/or /FullName

[Stefan Dirsch]

https://bugzilla.opensuse.org/show_bug.cgi?id=918466

Signed-off-by: Stefan Dirsch <sndir...@suse.de>
---
 mkfontscale.c | 9 ++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/mkfontscale.c b/mkfontscale.c
index da93e0c..e9b9488 100644
--- a/mkfontscale.c
+++ b/mkfontscale.c
@@ -579,11 +579,14 @@ makeXLFD(char *filename, FT_Face face, int isBitmap)
 }
 
 if(t1info) {
-if(!family)
+if(!family && t1info->family_name)
 family = strdup(t1info->family_name);
-if(!family)
+if(!family && t1info->full_name)
 family = strdup(t1info->full_name);
-if(!full_name)
+/* Hershey fonts miss /FamilyName */
+if(!family && face->family_name)
+family = strdup(face->family_name);
+if(!full_name && t1info->full_name)
 full_name = strdup(t1info->full_name);
 if(!foundry)
 foundry = notice_foundry(t1info->notice);
-- 
2.6.2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] libpciaccess/vgaarb: add function to get default vga device and it's decodes.

[Stefan Dirsch]

From: Egbert Eich 

Reenable default device when shutting down VGA arbitration.
https://bugzilla.opensuse.org/show_bug.cgi?id=714677
---
 src/common_vgaarb.c | 9 +
 1 file changed, 9 insertions(+)

diff --git a/src/common_vgaarb.c b/src/common_vgaarb.c
index 7a7d204..2c0686e 100644
--- a/src/common_vgaarb.c
+++ b/src/common_vgaarb.c
@@ -156,6 +156,11 @@ pci_device_vgaarb_fini(void)
 {
 if (!pci_sys)
 return;
+if (pci_device_vgaarb_set_target(NULL) < 0 ||
+   pci_device_vgaarb_lock() < 0 ||
+   pci_device_vgaarb_unlock() < 0) {
+   fprintf(stderr, "VGA Arbitration: Cannot restore default device.\n");
+}
 
 close(pci_sys->vgaarb_fd);
 }
@@ -334,6 +339,10 @@ pci_device_vgaarb_unlock(void)
 int pci_device_vgaarb_get_info(struct pci_device *dev, int *vga_count, int 
*rsrc_decodes)
 {
 *vga_count = pci_sys->vga_count;
+if (!rsrc_decodes)
+return 0;
+if (!dev)
+dev = pci_sys->vga_default_dev;
 if (!dev)
 return 0;
 
-- 
2.6.2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] libpciaccess/vgaarb: add function to get default vga device and it's decodes.

[Stefan Dirsch]

Reenable default device when shutting down VGA arbitration.
https://bugzilla.opensuse.org/show_bug.cgi?id=714677

Patch author: Egbert Eich 

Signed-off-by: Egbert Eich 
---
 src/common_vgaarb.c | 9 +
 1 file changed, 9 insertions(+)

diff --git a/src/common_vgaarb.c b/src/common_vgaarb.c
index 7a7d204..2c0686e 100644
--- a/src/common_vgaarb.c
+++ b/src/common_vgaarb.c
@@ -156,6 +156,11 @@ pci_device_vgaarb_fini(void)
 {
 if (!pci_sys)
 return;
+if (pci_device_vgaarb_set_target(NULL) < 0 ||
+   pci_device_vgaarb_lock() < 0 ||
+   pci_device_vgaarb_unlock() < 0) {
+   fprintf(stderr, "VGA Arbitration: Cannot restore default device.\n");
+}
 
 close(pci_sys->vgaarb_fd);
 }
@@ -334,6 +339,10 @@ pci_device_vgaarb_unlock(void)
 int pci_device_vgaarb_get_info(struct pci_device *dev, int *vga_count, int 
*rsrc_decodes)
 {
 *vga_count = pci_sys->vga_count;
+if (!rsrc_decodes)
+return 0;
+if (!dev)
+dev = pci_sys->vga_default_dev;
 if (!dev)
 return 0;
 
-- 
2.6.2

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] intel-gpu-tools: Fixes-compiler-warnings-about-wrong-function-type

[Stefan Dirsch]

Hi

Find another simple buildfix against current intel-gpu-tools git sources
attached.

Thanks,
Stefan

Public Key available
--
Stefan Dirsch (Res.  Dev.)   SUSE LINUX GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
---
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham
Norton, HRB 21284 (AG Nürnberg)
---
From 89822e4caba0868b397afb141a9f561a254fe92c Mon Sep 17 00:00:00 2001
From: Stefan Dirsch sndir...@suse.de
Date: Fri, 21 Aug 2015 12:40:23 +0200
Subject: [PATCH] Fixes compiler warnings about wrong function type.

Makes definition of function types for gen8_setup_null_render_state
and gen9_setup_null_render_state consistent with the ones from functions
for earlier GPU families like gen6_setup_null_render_state,
gen7_setup_null_render_state, ...

Signed-off-by: Stefan Dirsch sndir...@suse.com
---
 tools/null_state_gen/intel_renderstate_gen8.c | 5 +
 tools/null_state_gen/intel_renderstate_gen9.c | 5 +
 2 files changed, 2 insertions(+), 8 deletions(-)

diff --git a/tools/null_state_gen/intel_renderstate_gen8.c b/tools/null_state_gen/intel_renderstate_gen8.c
index 2d7a4b0..58ba6fa 100644
--- a/tools/null_state_gen/intel_renderstate_gen8.c
+++ b/tools/null_state_gen/intel_renderstate_gen8.c
@@ -322,11 +322,8 @@ static void gen8_emit_primitive(struct intel_batchbuffer *batch)
 OUT_BATCH(0);   /* index buffer offset, ignored */
 }
 
-int gen8_setup_null_render_state(struct intel_batchbuffer *batch)
+void gen8_setup_null_render_state(struct intel_batchbuffer *batch)
 {
-	int ret;
-	int i;
-
 #define GEN8_PIPE_CONTROL_GLOBAL_GTT   (1  24)
 
 	OUT_BATCH(GEN6_PIPE_CONTROL | (6 - 2));
diff --git a/tools/null_state_gen/intel_renderstate_gen9.c b/tools/null_state_gen/intel_renderstate_gen9.c
index 37bc675..08ee7ba 100644
--- a/tools/null_state_gen/intel_renderstate_gen9.c
+++ b/tools/null_state_gen/intel_renderstate_gen9.c
@@ -342,9 +342,8 @@ static void gen9_emit_state_base_address(struct intel_batchbuffer *batch) {
  * Generate the batch buffer commands needed to initialize the 3D engine
  * to its golden state.
  */
-int gen9_setup_null_render_state(struct intel_batchbuffer *batch)
+void gen9_setup_null_render_state(struct intel_batchbuffer *batch)
 {
-	int ret;
 	int i;
 
 #define GEN8_PIPE_CONTROL_GLOBAL_GTT   (1  24)
@@ -477,6 +476,4 @@ int gen9_setup_null_render_state(struct intel_batchbuffer *batch)
 	gen8_emit_primitive(batch);
 
 	OUT_BATCH(MI_BATCH_BUFFER_END);
-
-	return ret;
 }
-- 
1.8.4.5

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] xf86xv.h cannot be included without first including xorg-server.h.

[Stefan Dirsch]

On Tue, Oct 07, 2014 at 11:56:55AM +0100, Daniel Stone wrote:
 Hi,
 
 On 7 October 2014 10:54, Michel Dänzer mic...@daenzer.net wrote:
 
 On 07.10.2014 18:46, Daniel Martin wrote:
 
 On 7 October 2014 11:29, Stefan Dirsch sndir...@suse.de wrote:
 
 Without this the build fails on systems with the latest glibc,
 throwing this error:
 [...]
 
 This is caused by HAVE_STRNDUP not being set (it is set from
 xorg-server.h),
 causing os.h to redefine it.
 
 
 Have a look at this commit in xf86-video-intel:
      http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?
 id=d209b03915e4d12ce445d72ac09bb4fe664ba664
 
 With that HAVE_STRNDUP will be defined in config.h,
 which looks like a better solution to me.
 
 
 I disagree. xorg-server.h must be included before any other headers from
 xorg/, so Stefan's patch is the proper solution.
 
 
 Yes, absolutely. xorg-server.h does things like define _XSERVER64, which
 changes the size of CARD32 and thus the entire server ABI. Not including
 xorg-server.h first is terminally broken; this is just one symptom.
 
 Stefan:
 Reviewed-by: Daniel Stone dani...@collabora.com

Thanks! Anybody, who would like to push it?

CU,
Stefan

Public Key available
--
Stefan Dirsch (Res.  Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
--
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix
Imendörffer, HRB 16746 (AG Nürnberg)
--
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH] xf86xv.h cannot be included without first including xorg-server.h.

[Stefan Dirsch]

On Tue, Oct 14, 2014 at 10:02:13AM +0900, Michel Dänzer wrote:
 On 13.10.2014 21:58, Stefan Dirsch wrote:
 On Tue, Oct 07, 2014 at 11:56:55AM +0100, Daniel Stone wrote:
 Hi,
 
 On 7 October 2014 10:54, Michel Dänzer mic...@daenzer.net wrote:
 
  On 07.10.2014 18:46, Daniel Martin wrote:
 
  On 7 October 2014 11:29, Stefan Dirsch sndir...@suse.de wrote:
 
  Without this the build fails on systems with the latest glibc,
  throwing this error:
  [...]
 
  This is caused by HAVE_STRNDUP not being set (it is set from
  xorg-server.h),
  causing os.h to redefine it.
 
 
  Have a look at this commit in xf86-video-intel:
   
  http://cgit.freedesktop.org/xorg/driver/xf86-video-intel/commit/?
  id=d209b03915e4d12ce445d72ac09bb4fe664ba664
 
  With that HAVE_STRNDUP will be defined in config.h,
  which looks like a better solution to me.
 
 
  I disagree. xorg-server.h must be included before any other headers 
  from
  xorg/, so Stefan's patch is the proper solution.
 
 
 Yes, absolutely. xorg-server.h does things like define _XSERVER64, which
 changes the size of CARD32 and thus the entire server ABI. Not including
 xorg-server.h first is terminally broken; this is just one symptom.
 
 Stefan:
 Reviewed-by: Daniel Stone dani...@collabora.com
 
 Thanks! Anybody, who would like to push it?
 
 Thomas already pushed it. :)

Hmm. Then I don't see it. Latest commit in git I can see is from Sep 22nd.

  vmware/saa: Fix saa_check_poly_fill_rect_noreadback v2

Thanks,
Stefan

Public Key available
--
Stefan Dirsch (Res.  Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
--
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix
Imendörffer, HRB 16746 (AG Nürnberg)
--
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] xf86xv.h cannot be included without first including xorg-server.h.

[Stefan Dirsch]

Without this the build fails on systems with the latest glibc,
throwing this error:

In file included from /usr/include/string.h:634:0,
 from /usr/include/xorg/os.h:53,
 from /usr/include/xorg/misc.h:115,
 from /usr/include/xorg/screenint.h:50,
 from /usr/include/xorg/scrnintstr.h:50,
 from /usr/include/xorg/xvdix.h:55,
 from /usr/include/xorg/xf86xv.h:32,
 from vmwgfx_overlay.c:38:
/usr/include/xorg/os.h:579:1: error: expected identifier or '(' before 
'__extension__'
strndup(const char *str, size_t n);

This is caused by HAVE_STRNDUP not being set (it is set from xorg-server.h),
causing os.h to redefine it.

Signed-off-by: Stefan Dirsch sndir...@suse.de
---
 vmwgfx/vmwgfx_overlay.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/vmwgfx/vmwgfx_overlay.c b/vmwgfx/vmwgfx_overlay.c
index ef1d541..2b05b0e 100644
--- a/vmwgfx/vmwgfx_overlay.c
+++ b/vmwgfx/vmwgfx_overlay.c
@@ -35,6 +35,7 @@
  */
 
 
+#include xorg-server.h
 #include xf86xv.h
 #include fourcc.h
 #define debug_printf(...)
-- 
1.8.4.5

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH] vmmouse_client.h: Include xorg-server.h before xf86_OSproc.h

[Stefan Dirsch]

xf86_OSproc.h cannot be included without first including xorg-server.h.

Without this the build fails on systems with the latest glibc,
throwing this error:

In file included from /usr/include/string.h:634:0,
 from /usr/include/xorg/os.h:53,
 from /usr/include/xorg/misc.h:115,
 from /usr/include/xorg/window.h:50,
 from /usr/include/xorg/globals.h:7,
 from /usr/include/xorg/opaque.h:34,
 from /usr/include/xorg/xf86_OSproc.h:127,
 from vmmouse_client.h:42,
 from vmmouse_client.c:38:
/usr/include/xorg/os.h:579:1: error: expected identifier or '(' before 
'__extension__'
strndup(const char *str, size_t n);

This is caused by HAVE_STRNDUP not being set (it is set from xorg-server.h),
causing os.h to redefine it.

Signed-off-by: Stefan Dirsch sndir...@suse.de
---
 shared/vmmouse_client.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/shared/vmmouse_client.h b/shared/vmmouse_client.h
index b01bf08..1de51e5 100644
--- a/shared/vmmouse_client.h
+++ b/shared/vmmouse_client.h
@@ -39,6 +39,7 @@
 #ifndef _VMMOUSE_CLIENT_H_
 #define _VMMOUSE_CLIENT_H_
 
+#include xorg-server.h
 #include xf86_OSproc.h
 
 /*
-- 
1.8.4.5

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 2/2] Fixed driver name in error message about KMS active.

[Stefan Dirsch]

On Tue, Mar 18, 2014 at 09:51:11AM +1000, Dave Airlie wrote:
 On Tue, Mar 18, 2014 at 9:16 AM, Stefan Dirsch sndir...@suse.de wrote:
  On Tue, Mar 18, 2014 at 07:53:30AM +1000, Dave Airlie wrote:
  On Mon, Mar 17, 2014 at 10:48 PM, Stefan Dirsch sndir...@suse.de wrote:
   Seems some code came from cirrus driver by copy  paste. Fixed
   this in error message about device already in use by KMS module.
  
   Signed-off-by: Stefan Dirsch sndir...@suse.de
 
  Both of these ast patches are
 
  Reviewed-by: Dave Airlie airl...@redhat.com
 
  Thanks.
 
  can you push them?
 
  I just wanted to do this, but meanwhile the kernel module check has been
  removed by the following commit. :-(
 
  commit 7f24775a468066601a79beaffb4efa5a36c5ed59
  Author: Y.C. Chen yc_c...@aspeedtech.com
  Date:   Fri Mar 14 18:23:04 2014 +0800
 
  Support AST2400
 
  I don't understand why.
 
 Can you just revert all the patches in the repo, and add your patches,

done

# git push
[...]
remote: Updating patchwork state for 
http://patchwork.freedesktop.org/project/Xorg/list/
remote: E: failed to find patch for rev 
ef37427b08d33d0a3d9d42ac92d02bf7156f2615.
remote: E: failed to find patch for rev 
99e07e0341bfb44203bbd27a9d357a74999d5af9.
remote: E: failed to find patch for rev 
a40c98a4838bdb5793922a13d980bd370427bd2d.
remote: I: patch #22288 updated using rev 
e54f2fdb7a44ffb40b3b4c2266843c38223c1f07.
remote: I: patch #22289 updated using rev 
f4fa79c12c14854d786dc0427f5a40061e006495.
remote: I: 2 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/xorg/driver/xf86-video-ast
   9c5c9df..f4fa79c  master - master

The failed revisions are the revert revisions, the updated ones my
patches. Hope I didn't break anything in driver git repo with this push.

Thanks,
Stefan

Public Key available
--
Stefan Dirsch (Res.  Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
--
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix
Imendörffer, HRB 16746 (AG Nürnberg)
--
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 1/2] ast: fix falling back after kernel check

[Stefan Dirsch]

if we find a kernel driver the code leave the pci slot claimed which
stops us falling back. unclaim the pci slot. patch inspired by
correspondant patch for cirrus driver by Dave Airlie.

Signed-off-by: Stefan Dirsch sndir...@suse.de
---
 src/ast_driver.c | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/ast_driver.c b/src/ast_driver.c
index e0dd4fa..677c170 100644
--- a/src/ast_driver.c
+++ b/src/ast_driver.c
@@ -291,7 +291,10 @@ ASTProbe(DriverPtr drv, int flags)
   devSections, numDevSections,
   drv, usedChips);
 
-free(devSections);
+if (numUsed = 0) {
+   free(devSections);
+   return FALSE;
+}
 
 if (flags  PROBE_DETECT) {
 if (numUsed  0)
@@ -310,6 +313,8 @@ ASTProbe(DriverPtr drv, int flags)
pPci-device_id, pPci-bus, pPci-domain, 
pPci-dev, pPci-func);
 xf86DrvMsg(0, X_ERROR,
cirrus: This driver cannot operate until it 
has been unloaded.\n);
+xf86UnclaimPciSlot(pPci, devSections[0]);
+free(devSections);
 return FALSE;
 }
 }
@@ -343,6 +348,7 @@ ASTProbe(DriverPtr drv, int flags)
 }  /* end of for-loop */
 } /* end of if flags */
 
+free(devSections);
 free(usedChips);
 
 return foundScreen;
-- 
1.8.4.5

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 2/2] Fixed driver name in error message about KMS active.

[Stefan Dirsch]

Seems some code came from cirrus driver by copy  paste. Fixed
this in error message about device already in use by KMS module.

Signed-off-by: Stefan Dirsch sndir...@suse.de
---
 src/ast_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ast_driver.c b/src/ast_driver.c
index 677c170..3f81558 100644
--- a/src/ast_driver.c
+++ b/src/ast_driver.c
@@ -312,7 +312,7 @@ ASTProbe(DriverPtr drv, int flags)
ast: The PCI device 0x%x at 
%2.2d@%2.2d:%2.2d:%1.1d has a kernel module claiming it.\n,
pPci-device_id, pPci-bus, pPci-domain, 
pPci-dev, pPci-func);
 xf86DrvMsg(0, X_ERROR,
-   cirrus: This driver cannot operate until it 
has been unloaded.\n);
+   ast: This driver cannot operate until it has 
been unloaded.\n);
 xf86UnclaimPciSlot(pPci, devSections[0]);
 free(devSections);
 return FALSE;
-- 
1.8.4.5

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 2/2] Fixed driver name in error message about KMS active.

[Stefan Dirsch]

Seems some code came from cirrus driver by copy  paste. Fixed
this in error message about device already in use by KMS module.

Signed-off-by: Stefan Dirsch sndir...@suse.de
---
 src/ast_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ast_driver.c b/src/ast_driver.c
index 677c170..3f81558 100644
--- a/src/ast_driver.c
+++ b/src/ast_driver.c
@@ -312,7 +312,7 @@ ASTProbe(DriverPtr drv, int flags)
ast: The PCI device 0x%x at 
%2.2d@%2.2d:%2.2d:%1.1d has a kernel module claiming it.\n,
pPci-device_id, pPci-bus, pPci-domain, 
pPci-dev, pPci-func);
 xf86DrvMsg(0, X_ERROR,
-   cirrus: This driver cannot operate until it 
has been unloaded.\n);
+   ast: This driver cannot operate until it has 
been unloaded.\n);
 xf86UnclaimPciSlot(pPci, devSections[0]);
 free(devSections);
 return FALSE;
-- 
1.8.4.5

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

[PATCH 1/2] ast: fix falling back after kernel check

[Stefan Dirsch]

if we find a kernel driver the code leave the pci slot claimed which
stops us falling back. unclaim the pci slot. patch inspired by
correspondant patch for cirrus driver by Dave Airlie.

Signed-off-by: Stefan Dirsch sndir...@suse.de
---
 src/ast_driver.c | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/ast_driver.c b/src/ast_driver.c
index e0dd4fa..677c170 100644
--- a/src/ast_driver.c
+++ b/src/ast_driver.c
@@ -291,7 +291,10 @@ ASTProbe(DriverPtr drv, int flags)
   devSections, numDevSections,
   drv, usedChips);
 
-free(devSections);
+if (numUsed = 0) {
+   free(devSections);
+   return FALSE;
+}
 
 if (flags  PROBE_DETECT) {
 if (numUsed  0)
@@ -310,6 +313,8 @@ ASTProbe(DriverPtr drv, int flags)
pPci-device_id, pPci-bus, pPci-domain, 
pPci-dev, pPci-func);
 xf86DrvMsg(0, X_ERROR,
cirrus: This driver cannot operate until it 
has been unloaded.\n);
+xf86UnclaimPciSlot(pPci, devSections[0]);
+free(devSections);
 return FALSE;
 }
 }
@@ -343,6 +348,7 @@ ASTProbe(DriverPtr drv, int flags)
 }  /* end of for-loop */
 } /* end of if flags */
 
+free(devSections);
 free(usedChips);
 
 return foundScreen;
-- 
1.8.4.5

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [PATCH 2/2] Fixed driver name in error message about KMS active.

[Stefan Dirsch]

On Tue, Mar 18, 2014 at 07:53:30AM +1000, Dave Airlie wrote:
 On Mon, Mar 17, 2014 at 10:48 PM, Stefan Dirsch sndir...@suse.de wrote:
  Seems some code came from cirrus driver by copy  paste. Fixed
  this in error message about device already in use by KMS module.
 
  Signed-off-by: Stefan Dirsch sndir...@suse.de
 
 Both of these ast patches are
 
 Reviewed-by: Dave Airlie airl...@redhat.com

Thanks.

 can you push them?

I just wanted to do this, but meanwhile the kernel module check has been
removed by the following commit. :-(

commit 7f24775a468066601a79beaffb4efa5a36c5ed59
Author: Y.C. Chen yc_c...@aspeedtech.com
Date:   Fri Mar 14 18:23:04 2014 +0800

Support AST2400

I don't understand why.

Best regards,
Stefan

Public Key available
--
Stefan Dirsch (Res.  Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
--
SUSE LINUX Products GmbH, GF: Jeff Hawn, Jennifer Guild, Felix
Imendörffer, HRB 16746 (AG Nürnberg)
--
From 78066bfa6cae9d0a13852a131a8da379378aae5b Mon Sep 17 00:00:00 2001
From: Stefan Dirsch sndir...@suse.de
Date: Thu, 13 Mar 2014 12:31:20 +0100
Subject: [PATCH 1/2] ast: fix falling back after kernel check

if we find a kernel driver the code leave the pci slot claimed which
stops us falling back. unclaim the pci slot. patch inspired by
correspondant patch for cirrus driver by Dave Airlie.

Signed-off-by: Stefan Dirsch sndir...@suse.de
---
 src/ast_driver.c | 8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/src/ast_driver.c b/src/ast_driver.c
index e0dd4fa..677c170 100644
--- a/src/ast_driver.c
+++ b/src/ast_driver.c
@@ -291,7 +291,10 @@ ASTProbe(DriverPtr drv, int flags)
    devSections, numDevSections,
    drv, usedChips);
 
-free(devSections);
+if (numUsed = 0) {
+	free(devSections);
+	return FALSE;
+}
 
 if (flags  PROBE_DETECT) {
 if (numUsed  0)
@@ -310,6 +313,8 @@ ASTProbe(DriverPtr drv, int flags)
pPci-device_id, pPci-bus, pPci-domain, pPci-dev, pPci-func);
 xf86DrvMsg(0, X_ERROR,
cirrus: This driver cannot operate until it has been unloaded.\n);
+xf86UnclaimPciSlot(pPci, devSections[0]);
+free(devSections);
 return FALSE;
 }
 }
@@ -343,6 +348,7 @@ ASTProbe(DriverPtr drv, int flags)
 }  /* end of for-loop */
 } /* end of if flags */
 
+free(devSections);
 free(usedChips);
 
 return foundScreen;
-- 
1.8.4.5

From 8bf2837eb22e0833e435423358387f8a00b5 Mon Sep 17 00:00:00 2001
From: Stefan Dirsch sndir...@suse.de
Date: Fri, 14 Mar 2014 16:00:50 +0100
Subject: [PATCH 2/2] Fixed driver name in error message about KMS active.

Seems some code came from cirrus driver by copy  paste. Fixed
this in error message about device already in use by KMS module.

Signed-off-by: Stefan Dirsch sndir...@suse.de
---
 src/ast_driver.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/ast_driver.c b/src/ast_driver.c
index 677c170..3f81558 100644
--- a/src/ast_driver.c
+++ b/src/ast_driver.c
@@ -312,7 +312,7 @@ ASTProbe(DriverPtr drv, int flags)
ast: The PCI device 0x%x at %2.2d@%2.2d:%2.2d:%1.1d has a kernel module claiming it.\n,
pPci-device_id, pPci-bus, pPci-domain, pPci-dev, pPci-func);
 xf86DrvMsg(0, X_ERROR,
-   cirrus: This driver cannot operate until it has been unloaded.\n);
+   ast: This driver cannot operate until it has been unloaded.\n);
 xf86UnclaimPciSlot(pPci, devSections[0]);
 free(devSections);
 return FALSE;
-- 
1.8.4.5

___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: libxf86config no longer usable

[Stefan Dirsch]

On Tue, Apr 06, 2010 at 07:23:07AM -0700, Dan Nicholson wrote:
 On Tue, Apr 6, 2010 at 6:57 AM, Julien Cristau jcris...@debian.org wrote:
  On Tue, Apr  6, 2010 at 14:09:10 +0200, Stefan Dirsch wrote:
 
  On Tue, Apr 06, 2010 at 11:54:49AM +0200, Julien Cristau wrote:
   On Tue, Apr  6, 2010 at 01:36:20 +0200, Ruediger Oertel wrote:
  
I just can't come up with a clean idea how to solve this ...
   
   kill libxf86config?  with fire?  :)
 
  If you want to kill applications, which use it, this would be the way to go
  ...
 
  I've never been shipping that lib, so probably no apps using it either.
  I didn't know anyone was...
 
 I think yast uses it on suse to write xorg.conf files.

sax2 uses libxf86config. It's no longer used by default during installation by
YaST since openSUSE 11.2, but you still can run it manually if you need a
xorg.conf. Thus I would like to avoid dropping it already with openSUSE 11.3.

Best regards,
Stefan

Public Key available
--
Stefan Dirsch (Res.  Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
-
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [ANNOUNCE] xorg-server 1.7.99.902

[Stefan Dirsch]

On Mon, Mar 22, 2010 at 07:59:18AM -0700, Dan Nicholson wrote:
 2. Make the handling of missing sections from an existing
 configuration behave more like the full autoconfig. In other words, if
 there's a missing Screen section, generate multiple Screen/Device
 pairs with fallbacks. I think this is the correct fix, but I'm not
 that familiar with the autoconfig code so I don't think I could whip
 up a patch that fast.

I've now attached a patch to

  https://bugs.freedesktop.org/show_bug.cgi?id=27229

which does that. It works fine for us.

Stefan

Public Key available
--
Stefan Dirsch (Res.  Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
-
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [ANNOUNCE] xorg-server 1.7.99.902

[Stefan Dirsch]

On Sun, Mar 21, 2010 at 10:45:26PM -0700, Keith Packard wrote:
 
 According to the published schedule, we're supposed to be closing in on
 the release within the next couple of weeks. I'm pretty satisfied with
 the current state of the code, but I'd love to hear about regressions
 that people are finding so that we can clean things up before the
 release.

One serious regression compared to xorg-server 1.7.6 I've found during the
weekend is that video driver autodetection no longer works with xorg.conf.d in
place.

For instance I'm using the following snippet to allow preferring fglrx and
radeonhd driver if installed.

--- hw/xfree86/common/xf86AutoConfig.c
+++ hw/xfree86/common/xf86AutoConfig.c
@@ -176,7 +176,11 @@
case 0x1142:driverList[0] = apm; break;
case 0xedd8:driverList[0] = ark; break;
case 0x1a03:driverList[0] = ast; break;
-   case 0x1002:driverList[0] = ati; break;
+   case 0x1002:
+   driverList[0] = fglrx;
+   driverList[1] = radeonhd;
+   driverList[2] = ati;
+   break;
case 0x102c:driverList[0] = chips; break;
case 0x1013:driverList[0] = cirrus; break;
case 0x3d3d:driverList[0] = glint; break;

This no longer works. If fglrx driver is not installed the Xserver just
gives up, i.e. no longer tries to use radeonhd, then ati/radeon. There is
no xorg.conf in place (I'm aware that this mechanism never worked with
xorg.conf in place), but xorg.conf.d is. After removing xorg.conf.d the
mechanism works again.

If there is a way to specify priorities for video drivers in xorg.conf.d
(matching vendor IDs) to replace that mechanism please let me know.

Best regards,
Stefan

Public Key available
--
Stefan Dirsch (Res.  Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
-
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: [ANNOUNCE] xorg-server 1.7.99.902

[Stefan Dirsch]

On Mon, Mar 22, 2010 at 07:59:18AM -0700, Dan Nicholson wrote:
  No, once you have an empty xorg.conf you're lost, an empty xorg.conf.d
  directory is still ok though.
 
 That makes sense. There are two ways to handle this.
 
 1. Make the full autoconfig kick in when only xorg.conf is missing. I
 don't think this is ideal since you could have a perfectly valid
 configuration with only .conf files in xorg.conf.d. However, it might
 work as a stopgap. Below diff would make this happen (gmail will hose
 the formatting).
 
 diff --git a/hw/xfree86/common/xf86Config.c b/hw/xfree86/common/xf86Config.c
 index 132e8bc..78eba05 100644
 --- a/hw/xfree86/common/xf86Config.c
 +++ b/hw/xfree86/common/xf86Config.c
 @@ -2480,7 +2480,7 @@ xf86HandleConfigFile(Bool autoconfig)
 Unable to locate/open config directory: \%s\\n,
 xf86ConfigDir);
 }
 -   if (!filename  !dirname)
 +   if (!filename)
 return CONFIG_NOFILE;
  }

Thanks, but that's not an option. We definitely want to make use of
xorg.conf.d. :-)

 2. Make the handling of missing sections from an existing
 configuration behave more like the full autoconfig. In other words, if
 there's a missing Screen section, generate multiple Screen/Device
 pairs with fallbacks. I think this is the correct fix, but I'm not
 that familiar with the autoconfig code so I don't think I could whip
 up a patch that fast.

Thanks. For now one could generate Screen/Device/Serverlayout snippets in
xorg.conf.d depending on the available hardware, e.g. for ATI:

/etc/X11/xorg.conf.d/99-devices.conf

Section Device
Identifier  Builtin Default fglrx Device 0
Driver  fglrx
EndSection
Section Screen
Identifier  Builtin Default fglrx Screen 0
Device  Builtin Default fglrx Device 0
EndSection
Section Device
Identifier  Builtin Default radeonhd Device 0
Driver  radeonhd
EndSection
Section Screen
Identifier  Builtin Default radeonhd Screen 0
Device  Builtin Default radeonhd Device 0
EndSection
Section Device
Identifier  Builtin Default ati Device 0
Driver  ati
EndSection
Section Screen
Identifier  Builtin Default ati Screen 0
Device  Builtin Default ati Device 0
EndSection
Section Device
Identifier  Builtin Default fbdev Device 0
Driver  fbdev
EndSection
Section Screen
Identifier  Builtin Default fbdev Screen 0
Device  Builtin Default fbdev Device 0
EndSection
Section Device
Identifier  Builtin Default vesa Device 0
Driver  vesa
EndSection
Section Screen
Identifier  Builtin Default vesa Screen 0
Device  Builtin Default vesa Device 0
EndSection
Section ServerLayout
Identifier  Builtin Default Layout
Screen  Builtin Default fglrx Screen 0
Screen  Builtin Default radeonhd Screen 0
Screen  Builtin Default ati Screen 0
Screen  Builtin Default fbdev Screen 0
Screen  Builtin Default vesa Screen 0
EndSection

Best regards,
Stefan

Public Key available
--
Stefan Dirsch (Res.  Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
-
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
___
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

Re: Please revert Xorg decision to disable Ctrl-Alt-Backspace

[Stefan Dirsch]

On Tue, Mar 31, 2009 at 01:13:39AM -0400, Gerry Reno wrote:
 The solution used by OpenSUSE as I understand it, calls for a default of  
 enabled but requires the user to press Ctrl-Alt-Backspace twice within  
 two seconds and the first press emits a tone and you must press the  
 sequence a second time while the tone sounds.  This would at least keep  
 the key stroke available by default, would work with present tools which  
 have Ctrl-Alt-Backspace on their menues, and would prevent any of these  
 accidental pressings of Ctrl-Alt-Backspace.

Yes, that's correct.

 And yet, we hear nothing about this solution from Xorg. 

Obviously it's not appreciated, but maybe you can convince some more
distributors to apply it. Seems to be more promising than to discuss
it with X.Org developers here.

Best regards,
Stefan

Public Key available
--
Stefan Dirsch (Res.  Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
-
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
___
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-devel

Re: Please revert Xorg decision to disable Ctrl-Alt-Backspace

[Stefan Dirsch]

On Sat, Mar 28, 2009 at 02:00:29PM +1100, Daniel Stone wrote:
  And all the votes in the thread were NO for changing the behavior.   
  Only the poller favored making any change.  So why did all these NO's  
  end up as a change in default behavior?
 
 Because we discussed it before (about ten times, actually), and came to
 a sensible conclusion which is not going to be changed, no matter how
 many individuals come forward claiming to represent the universal view
 of the entire Linux userbase.

Well, I would have preferred to apply Luc's patch for ZapWarning

  https://bugs.freedesktop.org/show_bug.cgi?id=18076

and let the distributor decide whether to enable it by default via
xorg.conf. SUSE enables it by default since some time now, although at
the beginning the user acceptance for this change was actually *very*
low. We also needed to add this change in behaviour to our release
notes. Therefore I was *very* surprised to see upstream X.Org making
DontZap the default.

Best regards,
Stefan

Public Key available
--
Stefan Dirsch (Res.  Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
-
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
___
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-devel

Re: RandR 1.3, final release?

[Stefan Dirsch]

On Wed, Mar 04, 2009 at 07:43:11PM +0100, Matthias Hopf wrote:
 If nobody objects, I will bump randrproto, libXrandr, and xrandr to 1.3
 tomorrow. I don't think any additional functionality will be added soon,
 as nothing breathtaking has happened here for a couple of days.

Please go ahead.

 Especially with libXrandr this is important - with 1.2.99.4 xrandr will
 often fail due to a broken GetOutputPrimary.

s/often/always ? I'm not aware of any machine, where xrandr currently
works with the released versions of randrproto, libXrandr, xrandr. :-(

Stefan

Public Key available
--
Stefan Dirsch (Res.  Dev.)   SUSE LINUX Products GmbH
Tel: 0911-740 53 0Maxfeldstraße 5
FAX: 0911-740 53 479  D-90409 Nürnberg
http://www.suse.deGermany 
-
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
___
xorg-devel mailing list
xorg-devel@lists.x.org
http://lists.x.org/mailman/listinfo/xorg-devel