[jira] [Updated] (YARN-8057) Inadequate information for handling catch clauses

2018-03-21 Thread Zhenhao Li (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-8057?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhenhao Li updated YARN-8057:
-
Description: 
Their are some situations that different exception types are caught, but the 
handling of those exceptions can not show the differences of those types. Here 
are the code snippets we found which have this problem:

*org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java*

[https://github.com/apache/hadoop/blob/c02d2ba50db8a355ea03081c3984b2ea0c375a3f/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java]

At Line *125* and Line *129.* We can see that two exception types are caught, 
but the logging statements here can not show the exception type at all. It may 
cause confusions to the person who is reading the log, the person can not know 
what exception happened here.

 

Maybe adding stack trace information to these two logging statements is a 
simple way to improve it.

 

  was:
Their are some situations that different exception types are caught, but the 
handling of those exceptions can not show the differences of those types. Here 
are the code snippet we found which have this problem:

*org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java*

[https://github.com/apache/hadoop/blob/c02d2ba50db8a355ea03081c3984b2ea0c375a3f/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java]

At Line *125* and Line *129.* We can see that two exception types are caught, 
but the logging statements here can not show the exception type at all. It may 
cause confusions to the person who are reading the log, the person can not know 
what exception happened here.

 

Maybe adding stack trace information to these two logging statements is a 
simple way to improve it.

 


> Inadequate information for handling catch clauses
> -
>
> Key: YARN-8057
> URL: https://issues.apache.org/jira/browse/YARN-8057
> Project: Hadoop YARN
>  Issue Type: Improvement
>  Components: api, yarn
>Affects Versions: 3.0.0
>Reporter: Zhenhao Li
>Priority: Major
>  Labels: easyfix
>
> Their are some situations that different exception types are caught, but the 
> handling of those exceptions can not show the differences of those types. 
> Here are the code snippets we found which have this problem:
> *org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java*
> [https://github.com/apache/hadoop/blob/c02d2ba50db8a355ea03081c3984b2ea0c375a3f/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java]
> At Line *125* and Line *129.* We can see that two exception types are caught, 
> but the logging statements here can not show the exception type at all. It 
> may cause confusions to the person who is reading the log, the person can not 
> know what exception happened here.
>  
> Maybe adding stack trace information to these two logging statements is a 
> simple way to improve it.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Created] (YARN-8057) Inadequate information for handling catch clauses

2018-03-21 Thread Zhenhao Li (JIRA)
Zhenhao Li created YARN-8057:


 Summary: Inadequate information for handling catch clauses
 Key: YARN-8057
 URL: https://issues.apache.org/jira/browse/YARN-8057
 Project: Hadoop YARN
  Issue Type: Improvement
  Components: api, yarn
Affects Versions: 3.0.0
Reporter: Zhenhao Li


Their are some situations that different exception types are caught, but the 
handling of those exceptions can not show the differences of those types. Here 
are the code snippet we found which have this problem:

*org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java*

[https://github.com/apache/hadoop/blob/c02d2ba50db8a355ea03081c3984b2ea0c375a3f/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/NMClientImpl.java]

At Line *125* and Line *129.* We can see that two exception types are caught, 
but the logging statements here can not show the exception type at all. It may 
cause confusions to the person who are reading the log, the person can not know 
what exception happened here.

 

Maybe adding stack trace information to these two logging statements is a 
simple way to improve it.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Updated] (YARN-7969) Confusing log messages that do not match with the method name

2018-02-25 Thread Zhenhao Li (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-7969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhenhao Li updated YARN-7969:
-
Description: 
Our *previous issue (YARN-7926)* found that there are some possible copy and 
paste errors in the log messages which may cause some confusion when operators 
are reading the log messages. After a further check, we found some more similar 
problems. And we will propose a pull request to fix those problems.

 

Here is a list of the problems we found:

*1.*

_org.apache.hadoop.yarn.server.MockResourceManagerFacade._*_forceKillApplication_*_,_

_and_

_org.apache.hadoop.yarn.server.router.webapp.MockDefaultRequestInterceptorREST._*_updateAppState_*

 

The log messages in *both methods* are:

_LOG.info("_*_Force killing application:_* _" + appId);_

_and they also throw an exception:_

_throw new ApplicationNotFoundException( "_*_Trying to kill an absent 
application:_* _" + appId);_

_However after checking the code we found that 
MockDefaultRequestInterceptorREST._*_updateAppState()_* has no relation to 
killing an application; it just updates the status of an application. So maybe 
the log message of it should be changed.

 

*2.* 

_org.apache.hadoop.yarn.server.timeline.security.TimelineV1DelegationTokenSecretManagerService._*_removeStoredToken_*_,_

_org.apache.hadoop.yarn.server.timeline.security.TimelineV1DelegationTokenSecretManagerService._*_storeNewToken_*

 

The log messages in *both methods* are:

_LOG.debug("Storing token " + tokenId.getSequenceNumber());_

 

Since one method is storing token and one method is removing token, we believe 
that the log messages are incorrectly copied and should be changed. Maybe just 
simply change the log in *removeStoredToken()* to *“Removing token”*

 

*3.* 

_org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_getClusterMetricsInfo_*_,_

_org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_getNodes_*

 

The log messages in *both methods* are:

_LOG.warn("Failed to get nodes report ", e);_

 

However  the function of the first method is getting cluster metrics info, so 
maybe the log message of it should changed to *“Failed to get Cluster Metrics”*

  was:
Our *previous issue (YARN-7926)* found that there are some possible copy and 
paste errors in the log messages which may cause some confusion when operators 
are reading the log messages. After a further check, we found some more similar 
problems. And we will propose a pull request to fix those problems.

 

Here is a list of the problems we found:

*1.*

_org.apache.hadoop.yarn.server.MockResourceManagerFacade._*_forceKillApplication_*_,_

_and_

_org.apache.hadoop.yarn.server.router.webapp.MockDefaultRequestInterceptorREST._*_updateAppState_*

 

The log messages in *both methods* are:

_LOG.info("_*_Force killing application:_* _" + appId);_

_and they also throw an exception:_

_throw new ApplicationNotFoundException( "_*_Trying to kill an absent 
application:_* _" + appId);_

_However after checking the code we found that 
MockDefaultRequestInterceptorREST._*_updateAppState()_* has no relation to 
killing an application; it just updates the status of an application. So maybe 
the log message of it should be changed.

 

*2.* 

_org.apache.hadoop.yarn.server.timeline.security.TimelineV1DelegationTokenSecretManagerService._*_removeStoredToken_*_,_

_org.apache.hadoop.yarn.server.timeline.security.TimelineV1DelegationTokenSecretManagerService._*_storeNewToken_*

 

The log messages in *both methods* are:

_LOG.debug("Storing token " + tokenId.getSequenceNumber());_

 

Since one method is storing token and one method is removing token, we believe 
that the log messages are incorrectly copied and should be changed. Maybe just 
simply change the log in *removeStoredToken()* to “Removing token”

 

*3.* 

_org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_getClusterMetricsInfo_*_,_

_org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_getNodes_*

 

The log messages in *both methods* are:

_LOG.warn("Failed to get nodes report ", e);_

 

However  the function of the first method is getting cluster metrics info, so 
maybe the log message of it should changed to *“Failed to get Cluster Metrics”*


> Confusing log messages that do not match with the method name
> -
>
> Key: YARN-7969
> URL: https://issues.apache.org/jira/browse/YARN-7969
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Zhenhao Li
>Priority: Minor
>  Labels: easyfix
>
> Our *previous issue (YARN-7926)* found that there are some possible copy and 
> paste errors in the log messages which may cause some confusion when 
> operators are reading the log messages. After a further 

[jira] [Created] (YARN-7969) Confusing log messages that do not match with the method name

2018-02-25 Thread Zhenhao Li (JIRA)
Zhenhao Li created YARN-7969:


 Summary: Confusing log messages that do not match with the method 
name
 Key: YARN-7969
 URL: https://issues.apache.org/jira/browse/YARN-7969
 Project: Hadoop YARN
  Issue Type: Bug
Affects Versions: 3.0.0
Reporter: Zhenhao Li


Our *previous issue (YARN-7926)* found that there are some possible copy and 
paste errors in the log messages which may cause some confusion when operators 
are reading the log messages. After a further check, we found some more similar 
problems. And we will propose a pull request to fix those problems.

 

Here is a list of the problems we found:

*1.*

_org.apache.hadoop.yarn.server.MockResourceManagerFacade._*_forceKillApplication_*_,_

_and_

_org.apache.hadoop.yarn.server.router.webapp.MockDefaultRequestInterceptorREST._*_updateAppState_*

 

The log messages in *both methods* are:

_LOG.info("_*_Force killing application:_* _" + appId);_

_and they also throw an exception:_

_throw new ApplicationNotFoundException( "_*_Trying to kill an absent 
application:_* _" + appId);_

_However after checking the code we found that 
MockDefaultRequestInterceptorREST._*_updateAppState()_* has no relation to 
killing an application; it just updates the status of an application. So maybe 
the log message of it should be changed.

 

*2.* 

_org.apache.hadoop.yarn.server.timeline.security.TimelineV1DelegationTokenSecretManagerService._*_removeStoredToken_*_,_

_org.apache.hadoop.yarn.server.timeline.security.TimelineV1DelegationTokenSecretManagerService._*_storeNewToken_*

 

The log messages in *both methods* are:

_LOG.debug("Storing token " + tokenId.getSequenceNumber());_

 

Since one method is storing token and one method is removing token, we believe 
that the log messages are incorrectly copied and should be changed. Maybe just 
simply change the log in *removeStoredToken()* to “Removing token”

 

*3.* 

_org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_getClusterMetricsInfo_*_,_

_org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_getNodes_*

 

The log messages in *both methods* are:

_LOG.warn("Failed to get nodes report ", e);_

 

However  the function of the first method is getting cluster metrics info, so 
maybe the log message of it should changed to *“Failed to get Cluster Metrics”*



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Updated] (YARN-7926) Copy and paste errors in log messages

2018-02-25 Thread Zhenhao Li (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhenhao Li updated YARN-7926:
-
Description: 
We found that there are some possible copy and paste errors in the log 
messages, and we think it may cause some confusion when operators are reading 
the log messages.

 

The problem is found in the following two methods:

_org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_createNewApplication()_*
 

and 
 
_org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor._*_getNewApplication()_*

These are two very similar methods (possibly code clones) in different classes.

The log messages in *both methods* are:

_LOG.warn("Unable to_ *_create a new ApplicationId_* _in SubCluster " …);_

_LOG.debug(“_*getNewApplication* try # + … );

Since one method is getting new application and one method is creating new 
application, we believe that the log messages are incorrectly copied and should 
be changed.

Please let us know if there is anything that we can further provide you with 
fixing the problem.

  was:
We are a group of researchers from Canada and we are studying refactoring in 
log messages. We found that there are some possible copy and paste errors in 
the log messages, and we think it may cause some confusion when operators are 
reading the log messages.

 

The problem is found in the following two methods:

_org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_createNewApplication()_*
 

and 
 
_org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor._*_getNewApplication()_*

These are two very similar methods (possibly code clones) in different classes.

The log messages in *both methods* are:

_LOG.warn("Unable to_ *_create a new ApplicationId_* _in SubCluster " …);_

_LOG.debug(“_*getNewApplication* try # + … );

Since one method is getting new application and one method is creating new 
application, we believe that the log messages are incorrectly copied and should 
be changed.

Please let us know if there is anything that we can further provide you with 
fixing the problem.


> Copy and paste errors in log messages
> -
>
> Key: YARN-7926
> URL: https://issues.apache.org/jira/browse/YARN-7926
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Zhenhao Li
>Priority: Minor
>  Labels: easyfix
>
> We found that there are some possible copy and paste errors in the log 
> messages, and we think it may cause some confusion when operators are reading 
> the log messages.
>  
> The problem is found in the following two methods:
> _org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_createNewApplication()_*
>  
> and 
>  
> _org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor._*_getNewApplication()_*
> These are two very similar methods (possibly code clones) in different 
> classes.
> The log messages in *both methods* are:
> _LOG.warn("Unable to_ *_create a new ApplicationId_* _in SubCluster " …);_
> _LOG.debug(“_*getNewApplication* try # + … );
> Since one method is getting new application and one method is creating new 
> application, we believe that the log messages are incorrectly copied and 
> should be changed.
> Please let us know if there is anything that we can further provide you with 
> fixing the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Updated] (YARN-7926) Copy and paste errors in log messages

2018-02-13 Thread Zhenhao Li (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhenhao Li updated YARN-7926:
-
Description: 
We are a group of researchers from Canada and we are studying refactoring in 
log messages. We found that there are some possible copy and paste errors in 
the log messages, and we think it may cause some confusion when operators are 
reading the log messages.

 

The problem is found in the following two methods:

_org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_createNewApplication()_*
 

and 
 
_org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor._*_getNewApplication()_*

These are two very similar methods (possibly code clones) in different classes.

The log messages in *both methods* are:

_LOG.warn("Unable to_ *_create a new ApplicationId_* _in SubCluster " …);_

_LOG.debug(“_*getNewApplication* try # + … );

Since one method is getting new application and one method is creating new 
application, we believe that the log messages are incorrectly copied and should 
be changed.

Please let us know if there is anything that we can further provide you with 
fixing the problem.

  was:
We are a group of researchers from Canada and we are studying refactoring in 
log messages. We found that there are some possible copy and paste errors in 
the log messages, and we think it may cause some confusion when operators are 
reading the log messages. 

 

The problem is found in the following two methods:

_org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_createNewApplication()_*
 

and 
_org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor._*_getNewApplication()_*

These are two very similar methods (possibly code clones) in different classes. 

The log messages in *both methods* are:
 _LOG.warn("Unable to_ *_create a new ApplicationId_* _in SubCluster " …);__
_ _LOG.debug(“_*getNewApplication* try # + … );

Since one method is getting new application and one method is creating new 
application, we believe that the log messages are incorrectly copied and should 
be changed. 



Please let us know if there is anything that we can further provide you with 
fixing the problem.


> Copy and paste errors in log messages
> -
>
> Key: YARN-7926
> URL: https://issues.apache.org/jira/browse/YARN-7926
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Zhenhao Li
>Priority: Minor
>  Labels: easyfix
>
> We are a group of researchers from Canada and we are studying refactoring in 
> log messages. We found that there are some possible copy and paste errors in 
> the log messages, and we think it may cause some confusion when operators are 
> reading the log messages.
>  
> The problem is found in the following two methods:
> _org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_createNewApplication()_*
>  
> and 
>  
> _org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor._*_getNewApplication()_*
> These are two very similar methods (possibly code clones) in different 
> classes.
> The log messages in *both methods* are:
> _LOG.warn("Unable to_ *_create a new ApplicationId_* _in SubCluster " …);_
> _LOG.debug(“_*getNewApplication* try # + … );
> Since one method is getting new application and one method is creating new 
> application, we believe that the log messages are incorrectly copied and 
> should be changed.
> Please let us know if there is anything that we can further provide you with 
> fixing the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Updated] (YARN-7926) Copy and paste errors in log messages

2018-02-13 Thread Zhenhao Li (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhenhao Li updated YARN-7926:
-
Description: 
We are a group of researchers from Canada and we are studying refactoring in 
log messages. We found that there are some possible copy and paste errors in 
the log messages, and we think it may cause some confusion when operators are 
reading the log messages. 

 

The problem is found in the following two methods:

_org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_createNewApplication()_*
 

and 
_org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor._*_getNewApplication()_*

These are two very similar methods (possibly code clones) in different classes. 

The log messages in *both methods* are:
 _LOG.warn("Unable to_ *_create a new ApplicationId_* _in SubCluster " …);__
_ _LOG.debug(“_*getNewApplication* try # + … );

Since one method is getting new application and one method is creating new 
application, we believe that the log messages are incorrectly copied and should 
be changed. 



Please let us know if there is anything that we can further provide you with 
fixing the problem.

  was:
We are a group of researchers from Canada and we are studying refactoring in 
log messages. We found that there are some possible copy and paste errors in 
the log messages, and we think it may cause some confusion when operators are 
reading the log messages. 

The problem is found in the following two methods:

_org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_createNewApplication()_*
 

and 
_org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor._*_getNewApplication()_*

These are two very similar methods (possibly code clones) in different classes. 

The log messages in *both methods* are:
 _LOG.warn("Unable to_ *_create a new ApplicationId_* _in SubCluster " …);__
_ _LOG.debug(“_*getNewApplication* try # + … );

Since one method is getting new application and one method is creating new 
application, we believe that the log messages are incorrectly copied and should 
be changed. 



Please let us know if there is anything that we can further provide you with 
fixing the problem.


> Copy and paste errors in log messages
> -
>
> Key: YARN-7926
> URL: https://issues.apache.org/jira/browse/YARN-7926
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Zhenhao Li
>Priority: Minor
>  Labels: easyfix
>
> We are a group of researchers from Canada and we are studying refactoring in 
> log messages. We found that there are some possible copy and paste errors in 
> the log messages, and we think it may cause some confusion when operators are 
> reading the log messages. 
>  
> The problem is found in the following two methods:
> _org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_createNewApplication()_*
>  
> and 
> _org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor._*_getNewApplication()_*
> These are two very similar methods (possibly code clones) in different 
> classes. 
> The log messages in *both methods* are:
>  _LOG.warn("Unable to_ *_create a new ApplicationId_* _in SubCluster " …);__
> _ _LOG.debug(“_*getNewApplication* try # + … );
> Since one method is getting new application and one method is creating new 
> application, we believe that the log messages are incorrectly copied and 
> should be changed. 
> Please let us know if there is anything that we can further provide you with 
> fixing the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Updated] (YARN-7926) Copy and paste errors in log messages

2018-02-13 Thread Zhenhao Li (JIRA)

 [ 
https://issues.apache.org/jira/browse/YARN-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhenhao Li updated YARN-7926:
-
Affects Version/s: 3.0.0

> Copy and paste errors in log messages
> -
>
> Key: YARN-7926
> URL: https://issues.apache.org/jira/browse/YARN-7926
> Project: Hadoop YARN
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Zhenhao Li
>Priority: Minor
>  Labels: easyfix
>
> We are a group of researchers from Canada and we are studying refactoring in 
> log messages. We found that there are some possible copy and paste errors in 
> the log messages, and we think it may cause some confusion when operators are 
> reading the log messages. 
> The problem is found in the following two methods:
> _org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_createNewApplication()_*
>  
> and 
> _org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor._*_getNewApplication()_*
> These are two very similar methods (possibly code clones) in different 
> classes. 
> The log messages in *both methods* are:
>  _LOG.warn("Unable to_ *_create a new ApplicationId_* _in SubCluster " …);__
> _ _LOG.debug(“_*getNewApplication* try # + … );
> Since one method is getting new application and one method is creating new 
> application, we believe that the log messages are incorrectly copied and 
> should be changed. 
> Please let us know if there is anything that we can further provide you with 
> fixing the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Created] (YARN-7926) Copy and paste errors in log messages

2018-02-13 Thread Zhenhao Li (JIRA)
Zhenhao Li created YARN-7926:


 Summary: Copy and paste errors in log messages
 Key: YARN-7926
 URL: https://issues.apache.org/jira/browse/YARN-7926
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Zhenhao Li


We are a group of researchers from Canada and we are studying refactoring in 
log messages. We found that there are some possible copy and paste errors in 
the log messages, and we think it may cause some confusion when operators are 
reading the log messages. 

The problem is found in the following two methods:

_org.apache.hadoop.yarn.server.router.webapp.FederationInterceptorREST._*_createNewApplication()_*
 

and 
_org.apache.hadoop.yarn.server.router.clientrm.FederationClientInterceptor._*_getNewApplication()_*

These are two very similar methods (possibly code clones) in different classes. 

The log messages in *both methods* are:
 _LOG.warn("Unable to_ *_create a new ApplicationId_* _in SubCluster " …);__
_ _LOG.debug(“_*getNewApplication* try # + … );

Since one method is getting new application and one method is creating new 
application, we believe that the log messages are incorrectly copied and should 
be changed. 



Please let us know if there is anything that we can further provide you with 
fixing the problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org