[jira] Updated: (ZOOKEEPER-410) address all findbugs warnings in client/server classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-410: --- Status: Patch Available (was: Open) address all findbugs warnings in client/server classes -- Key: ZOOKEEPER-410 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-410 Project: Zookeeper Issue Type: Sub-task Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.2.0 Attachments: ZOOKEEPER-410.patch trunk/src/java/main/org/apache/zookeeper/ClientCnxn.java trunk/src/java/main/org/apache/zookeeper/ZooKeeperMain.java trunk/src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java trunk/src/java/main/org/apache/zookeeper/server/SyncRequestProcessor.java trunk/src/java/main/org/apache/zookeeper/server/NIOServerCnxn.java trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java trunk/src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build failed in Hudson: ZooKeeper-trunk #313
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/313/
--
[...truncated 1222 lines...]
[javadoc] Building index for all classes...
write-null:
api-xml:
[javadoc] Generating Javadoc
[javadoc] Javadoc execution
[javadoc] Loading source files for package org.apache.zookeeper...
[javadoc] Constructing Javadoc information...
[javadoc] javadoc: warning - Multiple sources of package comments found for
package org.apache.zookeeper.server
[javadoc] javadoc: warning - Multiple sources of package comments found for
package org.apache.jute
[javadoc] JDiff: doclet started ...
[javadoc] JDiff: writing the API to file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/jdiff/zookeeper_3.2.0.xml'...
[javadoc]
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/main/org/apache/zookeeper/ClientWatchManager.java
:38: warning - @return tag has no arguments.
[javadoc] JDiff: finished (took 0s, not including scanning the source files).
[javadoc] 3 warnings
api-report:
[mkdir] Created dir:
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff
[javadoc] Generating Javadoc
[javadoc] Javadoc execution
[javadoc] Loading source file
http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/Null.java...
[javadoc] Loading source files for package org.apache.jute.compiler...
[javadoc] Loading source files for package
org.apache.jute.compiler.generated...
[javadoc] Loading source files for package org.apache.zookeeper...
[javadoc] Loading source files for package org.apache.zookeeper.common...
[javadoc] Loading source files for package org.apache.zookeeper.jmx...
[javadoc] Loading source files for package org.apache.zookeeper.server...
[javadoc] Loading source files for package org.apache.zookeeper.server.auth...
[javadoc] Loading source files for package
org.apache.zookeeper.server.persistence...
[javadoc] Loading source files for package
org.apache.zookeeper.server.quorum...
[javadoc] Loading source files for package
org.apache.zookeeper.server.quorum.flexible...
[javadoc] Loading source files for package
org.apache.zookeeper.server.upgrade...
[javadoc] Loading source files for package org.apache.zookeeper.server.util...
[javadoc] Loading source files for package
org.apache.zookeeper.version.util...
[javadoc] Constructing Javadoc information...
[javadoc] javadoc: warning - Multiple sources of package comments found for
package org.apache.jute.compiler
[javadoc] javadoc: warning - Multiple sources of package comments found for
package org.apache.jute.compiler.generated
[javadoc] javadoc: warning - Multiple sources of package comments found for
package org.apache.zookeeper.server
[javadoc] javadoc: warning - Multiple sources of package comments found for
package org.apache.jute
[javadoc] JDiff: doclet started ...
[javadoc] JDiff: reading the old API in from file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/jdiff/zookeeper_3.1.1.xml'...Warning
: incorrectly formatted @link in text: API errors.
[javadoc] This is never thrown by the server, it shouldn't be used other than
[javadoc] to indicate a range. Specifically error codes greater than this
[javadoc] value are API errors (while values less than this indicate a
[javadoc] {...@link #SYSTEMERROR}).
[javadoc] finished
[javadoc] JDiff: reading the new API in from file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/src/java/lib/jdiff/zookeeper_3.2.0.xml'...Warning
: incorrectly formatted @link in text: API errors.
[javadoc] This is never thrown by the server, it shouldn't be used other than
[javadoc] to indicate a range. Specifically error codes greater than this
[javadoc] value are API errors (while values less than this indicate a
[javadoc] {...@link #SYSTEMERROR}).
[javadoc] finished
[javadoc] JDiff: comparing the old and new APIs ...
[javadoc] Approximately 1% difference between the APIs
[javadoc] JDiff: reading the comments in from file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff/user_comments_for_zookeeper_3.1.1_to_zookeeper_3.2.0.xml'...
[javadoc] (this will be created)
[javadoc] JDiff: generating HTML report into the file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff/changes.html'
and the subdirectory
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff/changes'
[javadoc] Note: all the comments have been newly generated
[javadoc] JDiff: writing the comments out to file
'http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/docs/jdiff/user_comments_for_zookeeper_3.1.1_to_zookeeper_3.2.0.xml'...
[javadoc] JDiff: finished (took 0s).
[javadoc] 4 warnings
test-classpath:
[jira] Updated: (ZOOKEEPER-407) address all findbugs warnings in org.apache.zookeeper.server.quorum.** packages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-407: - Attachment: ZOOKEEPER-407.patch Addressing problems pointed by findbugs. Some of them are not trivial, so I would appreciate a thorough review of this patch. address all findbugs warnings in org.apache.zookeeper.server.quorum.** packages --- Key: ZOOKEEPER-407 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-407 Project: Zookeeper Issue Type: Sub-task Components: server Reporter: Patrick Hunt Assignee: Flavio Paiva Junqueira Fix For: 3.2.0 Attachments: ZOOKEEPER-407.patch Flavio please address the findbugs warnings in quorum and sub packages. See http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/308/violations/ for a list of issues or use ant's findbugs (or eclipse) to identify the issues. In general we should try to fix these, but ignoring the warning (annotation) is ok if it includes comments to effect why, also has to be reviewed/approved. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-407) address all findbugs warnings in org.apache.zookeeper.server.quorum.** packages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-407: - Attachment: ZOOKEEPER-407.patch I'm not 100% sure of what to do with the System.exit calls sprinkled all over the code. I'm including some modifications in this patch, but I'm afraid they won't replicate the behavior we have currently. In some cases, we might consider throwing an exception and let some method higher up in the call path decide the appropriate measure. In other cases, like the one of LeaderElection, I'm not sure it is really necessary to exit if we can't open the socket. I understand it won't work, but perhaps throwing an exception again or simply logging a message might do the job. In any case, I have marked the occurrences for this package with a TODO. I would appreciate some comments on this matter. address all findbugs warnings in org.apache.zookeeper.server.quorum.** packages --- Key: ZOOKEEPER-407 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-407 Project: Zookeeper Issue Type: Sub-task Components: server Reporter: Patrick Hunt Assignee: Flavio Paiva Junqueira Fix For: 3.2.0 Attachments: ZOOKEEPER-407.patch, ZOOKEEPER-407.patch Flavio please address the findbugs warnings in quorum and sub packages. See http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/308/violations/ for a list of issues or use ant's findbugs (or eclipse) to identify the issues. In general we should try to fix these, but ignoring the warning (annotation) is ok if it includes comments to effect why, also has to be reviewed/approved. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-407) address all findbugs warnings in org.apache.zookeeper.server.quorum.** packages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12710787#action_12710787 ] Patrick Hunt commented on ZOOKEEPER-407: Take a look at what I did in ZOOKEEPER-410, I basically allowed a couple of exceptions where I thought: 1) big impact if we didn't allow (potential instability/incorrectness in particular) 2) I thought it was ok to exit if we; clearly documented and esp logged as FATAL the cause 3) command line driver code (ie main()) is ok to use exit it's not clear to me that in server code (vs library) exit should be entirely disallowed. I'm a follower of the fail fast approach - I'd rather see us exit with useful feedback than linger. In library code obv you don't want to exit as this may not be what all clients want to do - but for servers I think it's ok, esp if we review/approve each exception (which we already do). address all findbugs warnings in org.apache.zookeeper.server.quorum.** packages --- Key: ZOOKEEPER-407 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-407 Project: Zookeeper Issue Type: Sub-task Components: server Reporter: Patrick Hunt Assignee: Flavio Paiva Junqueira Fix For: 3.2.0 Attachments: ZOOKEEPER-407.patch, ZOOKEEPER-407.patch Flavio please address the findbugs warnings in quorum and sub packages. See http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/308/violations/ for a list of issues or use ant's findbugs (or eclipse) to identify the issues. In general we should try to fix these, but ignoring the warning (annotation) is ok if it includes comments to effect why, also has to be reviewed/approved. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-345) the CLIs should allow addAuth to be invoked
[ https://issues.apache.org/jira/browse/ZOOKEEPER-345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-345: -- Assignee: Henry Robinson Thanks Henry, would it be possible for you to provide a patch for the C CLI as well? the CLIs should allow addAuth to be invoked --- Key: ZOOKEEPER-345 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-345 Project: Zookeeper Issue Type: Improvement Components: c client, java client Reporter: Patrick Hunt Assignee: Henry Robinson Fix For: 3.2.0 Attachments: ZOOKEEPER-345.patch Not sure about the c client but the java CLI ZooKeeperMain does not allow addAuth to be called, it should have a command for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-407) address all findbugs warnings in org.apache.zookeeper.server.quorum.** packages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-407?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12710794#action_12710794 ] Flavio Paiva Junqueira commented on ZOOKEEPER-407: -- For this patch I'm certainly not proposing that we fix any problem with exit calls. All modifications I have suggested are to get rid of the findbugs warnings. In fact, my preference is to leave the exit calls as they are and perhaps deal with them in a separate jira if there is any need to do so. address all findbugs warnings in org.apache.zookeeper.server.quorum.** packages --- Key: ZOOKEEPER-407 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-407 Project: Zookeeper Issue Type: Sub-task Components: server Reporter: Patrick Hunt Assignee: Flavio Paiva Junqueira Fix For: 3.2.0 Attachments: ZOOKEEPER-407.patch, ZOOKEEPER-407.patch Flavio please address the findbugs warnings in quorum and sub packages. See http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/308/violations/ for a list of issues or use ant's findbugs (or eclipse) to identify the issues. In general we should try to fix these, but ignoring the warning (annotation) is ok if it includes comments to effect why, also has to be reviewed/approved. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-345) the CLIs should allow addAuth to be invoked
[ https://issues.apache.org/jira/browse/ZOOKEEPER-345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12710797#action_12710797 ] Henry Robinson commented on ZOOKEEPER-345: -- Yes, I'll get on it. the CLIs should allow addAuth to be invoked --- Key: ZOOKEEPER-345 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-345 Project: Zookeeper Issue Type: Improvement Components: c client, java client Reporter: Patrick Hunt Assignee: Henry Robinson Fix For: 3.2.0 Attachments: ZOOKEEPER-345.patch Not sure about the c client but the java CLI ZooKeeperMain does not allow addAuth to be called, it should have a command for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-405) nullpointer exception in zookeeper java shell.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-405: Status: Patch Available (was: Open) nullpointer exception in zookeeper java shell. -- Key: ZOOKEEPER-405 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-405 Project: Zookeeper Issue Type: Bug Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-405.patch The java client shell does not handle null return data and throws out null pointer exception. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-404) nightly build failed on hudson.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-404: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. Thanks henry and pat... we'll have to re submit all the PA's so trigger hudson. nightly build failed on hudson. --- Key: ZOOKEEPER-404 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-404 Project: Zookeeper Issue Type: Bug Affects Versions: 3.2.0 Reporter: Mahadev konar Assignee: Henry Robinson Priority: Critical Fix For: 3.2.0 Attachments: ZOOKEEPER-404.patch, ZOOKEEPER-404.patch the nightly build failed with the following error compile: [echo] contrib: zkpython BUILD FAILED /home/hudson/hudson-slave/workspace/ZooKeeper-trunk/trunk/build.xml:444: The following error occurred while executing this line: /home/hudson/hudson-slave/workspace/ZooKeeper-trunk/trunk/src/contrib/build.xml:39: The following error occurred while executing this line: /home/hudson/hudson-slave/workspace/ZooKeeper-trunk/trunk/src/contrib/build-contrib.xml:79: srcdir /home/hudson/hudson-slave/workspace/ZooKeeper-trunk/trunk/src/contrib/zkpython/src/java does not exist! Total time: 32 seconds Publishing Javadoc Recording test results Recording fingerprints Publishing Clover coverage report... Sending e-mails to: zookeeper-dev@hadoop.apache.org finished: FAILURE -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-407) address all findbugs warnings in org.apache.zookeeper.server.quorum.** packages
[ https://issues.apache.org/jira/browse/ZOOKEEPER-407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Flavio Paiva Junqueira updated ZOOKEEPER-407: - Attachment: ZOOKEEPER-407.patch Added System.exit exceptions to exclude file. address all findbugs warnings in org.apache.zookeeper.server.quorum.** packages --- Key: ZOOKEEPER-407 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-407 Project: Zookeeper Issue Type: Sub-task Components: server Reporter: Patrick Hunt Assignee: Flavio Paiva Junqueira Fix For: 3.2.0 Attachments: ZOOKEEPER-407.patch, ZOOKEEPER-407.patch, ZOOKEEPER-407.patch Flavio please address the findbugs warnings in quorum and sub packages. See http://hudson.zones.apache.org/hudson/view/ZooKeeper/job/ZooKeeper-trunk/308/violations/ for a list of issues or use ant's findbugs (or eclipse) to identify the issues. In general we should try to fix these, but ignoring the warning (annotation) is ok if it includes comments to effect why, also has to be reviewed/approved. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
Build failed in Hudson: ZooKeeper-trunk #314
See http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/314/changes Changes: [mahadev] ZOOKEEPER-404. nightly build failed on hudson. (henry robinson and pat via mahadev) -- [...truncated 1332 lines...] [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper [copy] Copying 1 file to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper package: [copy] Copying 1 file to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper/test [copy] Copying 6 files to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper/test [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper/benchmark [copy] Copying 2 files to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper/benchmark [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper/src [copy] Copying 29 files to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/bookkeeper/src checkMainCompiled: versionedjarname: unversionedjarname: setjarname: check-contrib: init: [echo] contrib: fatjar [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/fatjar [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/fatjar/classes [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/fatjar/test init-contrib: compile: [echo] contrib: fatjar [javac] Compiling 1 source file to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/fatjar/classes jar: [echo] contrib: fatjar [jar] Building jar: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/fatjar/zookeeper-3.2.0-fatjar.jar zookeeperbuildcontrib.package: [echo] contrib: fatjar [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/fatjar [copy] Copying 1 file to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/fatjar package: [copy] Copying 1 file to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/fatjar [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/fatjar/conf [copy] Copying 1 file to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/fatjar/conf [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/fatjar/src [copy] Copying 1 file to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/fatjar/src checkMainCompiled: versionedjarname: unversionedjarname: setjarname: check-contrib: init: [echo] contrib: rest [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/rest [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/rest/classes [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/rest/test init-contrib: compile: [echo] contrib: rest [javac] Compiling 12 source files to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/rest/classes jar: [echo] contrib: rest [jar] Building jar: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/rest/zookeeper-3.2.0-rest.jar package: [echo] contrib: rest [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/rest [copy] Copying 1 file to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/zookeeper-3.2.0/contrib/rest check-contrib: init: [echo] contrib: zkfuse [mkdir] Created dir: http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/zkfuse init-contrib: compile: [echo] contrib: zkfuse [copy] Copying 18 files to http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/ws/trunk/build/contrib/zkfuse package: [echo] contrib: zkfuse [mkdir] Created dir:
[jira] Updated: (ZOOKEEPER-394) Converting JUnit tests into TestNG controlled environment
[ https://issues.apache.org/jira/browse/ZOOKEEPER-394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-394: --- Fix Version/s: (was: 3.2.0) 3.3.0 not a blocker for 3.2, moving to 3.3 Converting JUnit tests into TestNG controlled environment - Key: ZOOKEEPER-394 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-394 Project: Zookeeper Issue Type: Test Components: tests Affects Versions: 3.1.1 Reporter: Konstantin Boudnik Assignee: Konstantin Boudnik Fix For: 3.3.0 TestNG is a powerful test harness, which provides a lot of useful features like parallel test execution, test parametrization, and such. ZooKeeper uses JUnit (v.4.4) environment instead which certainly should help to ease the conversion I'd suggest to convert ZooKeeper's Junit based test infrastructure into TestNG controller environment, which will allow to achieve higher level of test execution control in the long run. The same conversion has been already performed for Avro project (see https://issues.apache.org/jira/browse/AVRO-26) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-388) Add readline support to the c shell
[ https://issues.apache.org/jira/browse/ZOOKEEPER-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-388: --- Fix Version/s: (was: 3.2.0) 3.3.0 not a blocker for 3.2, moving to 3.3 Add readline support to the c shell --- Key: ZOOKEEPER-388 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-388 Project: Zookeeper Issue Type: Improvement Components: c client Reporter: Patrick Hunt Priority: Minor Fix For: 3.3.0 Add readline support to the c shell autotools should detect readline libs and enable this by default if present (should also support turning off). -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-397) mainline tests conversion
[ https://issues.apache.org/jira/browse/ZOOKEEPER-397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-397: --- Fix Version/s: (was: 3.2.0) 3.3.0 not a blocker for 3.2, moving to 3.3 mainline tests conversion - Key: ZOOKEEPER-397 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-397 Project: Zookeeper Issue Type: Sub-task Components: tests Reporter: Konstantin Boudnik Assignee: Konstantin Boudnik Fix For: 3.3.0 Attachments: testng-5.9-jdk15.jar, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch, ZOOKEEPER-397.patch In this stage main set (src/java/test) of ZK tests will be converted to TestNG -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-405) nullpointer exception in zookeeper java shell.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-405: Comment: was deleted (was: this patch fixes the issue so that NULL data is compatible in both c and java. Added a test in c. ) nullpointer exception in zookeeper java shell. -- Key: ZOOKEEPER-405 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-405 Project: Zookeeper Issue Type: Bug Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-405.patch The java client shell does not handle null return data and throws out null pointer exception. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-405) nullpointer exception in zookeeper java shell.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-405: Attachment: (was: ZOOKEEPER-405.patch) nullpointer exception in zookeeper java shell. -- Key: ZOOKEEPER-405 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-405 Project: Zookeeper Issue Type: Bug Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-405.patch The java client shell does not handle null return data and throws out null pointer exception. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-405) nullpointer exception in zookeeper java shell.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-405: Attachment: ZOOKEEPER-405.patch this patch fixes the issue so that NULL data is compatible in both c and java. Added a test in c. nullpointer exception in zookeeper java shell. -- Key: ZOOKEEPER-405 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-405 Project: Zookeeper Issue Type: Bug Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-405.patch The java client shell does not handle null return data and throws out null pointer exception. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-364) command line interface for zookeeper.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-364: --- Fix Version/s: (was: 3.2.0) 3.3.0 not a blocker for 3.2, moving to 3.3 command line interface for zookeeper. - Key: ZOOKEEPER-364 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-364 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Mahadev konar Assignee: Patrick Hunt Fix For: 3.3.0 currently we have a shell based interface for zookeeper (which again isnt well published). we should have a well published cli based interface for zookeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-369) remove multiple configs in server/quorums.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-369: --- Fix Version/s: (was: 3.2.0) 3.3.0 not a blocker for 3.2, moving to 3.3 remove multiple configs in server/quorums. -- Key: ZOOKEEPER-369 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-369 Project: Zookeeper Issue Type: Improvement Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Mahadev konar Fix For: 3.3.0 currently we have mutliple configs serverconfig and quorumpeerconfig for server and quorums. We can throw away one of these and just keep one of them with some methods returning default values like -1 or null for options that are not available. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on data for a node in zookeeper being null.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-402: Attachment: ZOOKEEPER-402.patch this patch fixes the issue with NULL being compatible in both java and c. Added a test in c as well... zookeeper c library segfaults on data for a node in zookeeper being null. - Key: ZOOKEEPER-402 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.0, 3.1.1 Reporter: Mahadev konar Assignee: Mahadev konar Priority: Critical Fix For: 3.2.0 Attachments: ZOOKEEPER-402.patch the zookeeper c client library seg faults on data being null for a zoo node. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-402) zookeeper c library segfaults on data for a node in zookeeper being null.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-402: Status: Patch Available (was: Open) zookeeper c library segfaults on data for a node in zookeeper being null. - Key: ZOOKEEPER-402 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-402 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.1, 3.1.0 Reporter: Mahadev konar Assignee: Mahadev konar Priority: Critical Fix For: 3.2.0 Attachments: ZOOKEEPER-402.patch the zookeeper c client library seg faults on data being null for a zoo node. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-329) document how to integrate 3rd party authentication into ZK server ACLs
[ https://issues.apache.org/jira/browse/ZOOKEEPER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt reassigned ZOOKEEPER-329: -- Assignee: Benjamin Reed document how to integrate 3rd party authentication into ZK server ACLs -- Key: ZOOKEEPER-329 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-329 Project: Zookeeper Issue Type: Improvement Components: documentation Reporter: Patrick Hunt Assignee: Benjamin Reed Priority: Minor Fix For: 3.2.0 the docs mention that zk supports pluggable auth schemes but doesn't detail the API/examples. We should add this to the docs. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-312) AUTH_FAILED state is unused
[ https://issues.apache.org/jira/browse/ZOOKEEPER-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-312: --- Fix Version/s: (was: 3.2.0) 3.3.0 not a blocker for 3.2, moving to 3.3 AUTH_FAILED state is unused --- Key: ZOOKEEPER-312 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-312 Project: Zookeeper Issue Type: Improvement Reporter: Tom White Fix For: 3.3.0 Either the AUTH_FAILED state should be removed, or an AuthFailedException should cause the ZooKeeper client to transition to the AUTH_FAILED state. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-339) Prevent from running ZK nodes with the same node ID
[ https://issues.apache.org/jira/browse/ZOOKEEPER-339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-339: --- Fix Version/s: (was: 3.2.0) 3.3.0 not a blocker for 3.2, moving to 3.3 Prevent from running ZK nodes with the same node ID Key: ZOOKEEPER-339 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-339 Project: Zookeeper Issue Type: Improvement Components: server Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Mahadev konar Fix For: 3.3.0 ZK server should catch a misconfiguration of nodes that use the same ID in myid file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-322) move examples out of docs into contrib/examples
[ https://issues.apache.org/jira/browse/ZOOKEEPER-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-322: --- Fix Version/s: (was: 3.2.0) 3.3.0 not a blocker for 3.2, moving to 3.3 move examples out of docs into contrib/examples - Key: ZOOKEEPER-322 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-322 Project: Zookeeper Issue Type: Improvement Components: documentation Reporter: Mahadev konar Fix For: 3.3.0 move examples out of docs into contrib/examples -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-307) Log exception stack traces
[ https://issues.apache.org/jira/browse/ZOOKEEPER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-307. Resolution: Invalid already addressed in separate jiras for 3.2 Log exception stack traces -- Key: ZOOKEEPER-307 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-307 Project: Zookeeper Issue Type: Improvement Affects Versions: 3.1.0 Reporter: Flavio Paiva Junqueira Fix For: 3.2.0 For some exceptions, both on ZooKeeper and BookKeeper, we are calling printStackTrace explicitly instead of making a call to the logger. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-304) factor out common methods from zookeeper.java
[ https://issues.apache.org/jira/browse/ZOOKEEPER-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-304: --- Fix Version/s: (was: 3.2.0) 3.3.0 not a blocker for 3.2, moving to 3.3 factor out common methods from zookeeper.java - Key: ZOOKEEPER-304 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-304 Project: Zookeeper Issue Type: Improvement Components: java client, server Affects Versions: 3.1.0 Reporter: Mahadev konar Fix For: 3.3.0 we need to factor out common methods from zookeeper.java to a commons directory for zookeeper so that it can be used both in client and server without each of them depending on each other. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-298) some excecutables (scripts typ.) are not marked as such in tar generated by ant tar
[ https://issues.apache.org/jira/browse/ZOOKEEPER-298?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-298. Resolution: Invalid addressed in a separate patch in 3.2 some excecutables (scripts typ.) are not marked as such in tar generated by ant tar - Key: ZOOKEEPER-298 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-298 Project: Zookeeper Issue Type: Bug Components: build Affects Versions: 3.1.0 Reporter: Patrick Hunt Fix For: 3.2.0 The configure scripts in src/c, the zkServer.sh in src/c/test, and some of the other scripts are not marked as executable when running ant tar. The build.xml should be updated to mark appropriately. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-287) high cpu utilization caused by nioserver factory thread
[ https://issues.apache.org/jira/browse/ZOOKEEPER-287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-287: --- Fix Version/s: (was: 3.2.0) 3.3.0 not reproduceable - not a blocker for 3.2, moving to 3.3 high cpu utilization caused by nioserver factory thread --- Key: ZOOKEEPER-287 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-287 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.0.1 Environment: Linux 2.6.9-67.ELsmp #1 SMP Wed Nov 7 13:58:04 EST 2007 i686 i686 i386 GNU/Linux the servers were running in vmware vms java version 1.6.0_06 Java(TM) SE Runtime Environment (build 1.6.0_06-b02) Java HotSpot(TM) Client VM (build 10.0-b22, mixed mode) Reporter: Patrick Hunt Priority: Critical Fix For: 3.3.0 a user reported that a long running server, part of a 2 server ensemble, started using 100%cpu (1 server of the ensemble, the other was fine). mahadev tracked it down to a thread in the server running epoll in a tight loop - the thread was the nio server factory thread that selects on client fds. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-262) unnecesssarily complex reentrant zookeeper_close() logic
[ https://issues.apache.org/jira/browse/ZOOKEEPER-262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-262: --- Fix Version/s: (was: 3.2.0) 3.3.0 not a blocker for 3.2, moving to 3.3 unnecesssarily complex reentrant zookeeper_close() logic Key: ZOOKEEPER-262 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-262 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.2.0, 4.0.0 Reporter: Chris Darroch Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-262.patch, ZOOKEEPER-262.patch, zookeeper-close.patch While working on a wrapper for the C API I puzzled over the problem of how to determine when the multi-threaded adaptor's IO and completion threads had exited. Looking at the code in api_epilog() and adaptor_finish() it seemed clear that any thread could be the last one out the door, and whichever was last would turn out the lights by calling zookeeper_close(). However, on further examination I found that in fact, the close_requested flag guards entry to zookeeper_close() in api_epilog(), and close_requested can only be set non-zero within zookeeper_close(). Thus, only the user's main thread can invoke zookeeper_close() and kick off the shutdown process. When that happens, zookeeper_close() then invokes adaptor_finish() and returns ZOK immediately afterward. Since adaptor_finish() is only called in this one context, it means all the code in that function to check pthread_self() and call pthread_detach() if the current thread is the IO or completion thread is redundant. The adaptor_finish() function always signals and then waits to join with the IO and completion threads because it can only be called by the user's main thread. After joining with the two internal threads, adaptor_finish() calls api_epilog(), which might seem like a trivial final action. However, this is actually where all the work gets done, because in this one case, api_epilog() sees a non-zero close_requested flag value and invokes zookeeper_close(). Note that zookeeper_close() is already on the stack; this is a re-entrant invocation. This time around, zookeeper_close() skips the call to adaptor_finish() -- assuming the reference count has been properly decremented to zero! -- and does the actual final cleanup steps, including deallocating the zh structure. Fortunately, none of the callers on the stack (api_epilog(), adaptor_finish(), and the first zookeeper_close()) touches zh after this. This all works OK, and in particular, the fact that I can be certain that the IO and completion threads have exited after zookeeper_close() returns is great. So too is the fact that those threads can't invoke zookeeper_close() without my knowing about it. However, the actual mechanics of the shutdown seem unnecessarily complex. I'd be worried a bit about a new maintainer looking at adaptor_finish() and reasonably concluding that it can be called by any thread, including the IO and completion ones. Or thinking that the zh handle can still be used after that innocuous-looking call to adaptor_finish() in zookeeper_close() -- the one that actually causes all the work to be done and the handle to be deallocated! I'll attach a patch which I think simplifies the code a bit and makes the shutdown mechanics a little more clear, and might prevent unintentional errors in the future. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-270) remove NoSyncConnected in KeeperState - it's not used anywhere in the codebase.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-270: --- Fix Version/s: (was: 3.2.0) 3.3.0 not a blocker for 3.2, moving to 3.3 remove NoSyncConnected in KeeperState - it's not used anywhere in the codebase. Key: ZOOKEEPER-270 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-270 Project: Zookeeper Issue Type: Bug Components: java client, server Reporter: Mahadev konar Fix For: 3.3.0 ZOOKEEPER-265 makes some constants deprecated. We should remove the deprecated stuff int the next release. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-271) Better command line parsing in ZookeeperMain.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-271: --- Fix Version/s: (was: 3.2.0) 3.3.0 not a blocker for 3.2, moving to 3.3 Better command line parsing in ZookeeperMain. - Key: ZOOKEEPER-271 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-271 Project: Zookeeper Issue Type: Improvement Components: java client Affects Versions: 3.0.0, 3.0.1 Reporter: Mahadev konar Priority: Minor Fix For: 3.3.0 The command line parsing in zookeepermain is very basic.We should use some kind of cli parsing (commons-cli?) or something else that is standard and improve our command line parsing. This will remove the scattered code that we have in zookeepermain and we will have much better command line parsing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-244) AsyncOpsTest fails when running consecutively
[ https://issues.apache.org/jira/browse/ZOOKEEPER-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt resolved ZOOKEEPER-244. Resolution: Cannot Reproduce AsyncOpsTest fails when running consecutively - Key: ZOOKEEPER-244 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-244 Project: Zookeeper Issue Type: Bug Components: tests Affects Versions: 3.0.1 Environment: MacOS X 10.5.5, Java 1.6.0_05 Reporter: Flavio Paiva Junqueira Priority: Minor Fix For: 3.2.0 Attachments: TEST-org.apache.zookeeper.test.AsyncOpsTest.txt Attaching output log file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-74) Cleaning/restructuring up Zookeeper server code
[ https://issues.apache.org/jira/browse/ZOOKEEPER-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-74: -- Fix Version/s: (was: 3.2.0) 3.3.0 Release Note: not a blocker for 3.2, moving to 3.3 Cleaning/restructuring up Zookeeper server code --- Key: ZOOKEEPER-74 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-74 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.3.0 I have been thinking this for a while and find that the zookeeper server code needs some cleaning up. The server code is a little tricky/confusing to read sometimes gievn that there is no clearity on ownership of objects. I will put down a proposal for restructuring/cleaning the code up with javadocs so that the code is easier to understand and develop on. comments on what you find confusing are welcome on this jira. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-216) Improve logging in C client
[ https://issues.apache.org/jira/browse/ZOOKEEPER-216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-216: --- Fix Version/s: (was: 3.2.0) 3.3.0 Release Note: not a blocker for 3.2, moving to 3.3 Improve logging in C client --- Key: ZOOKEEPER-216 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-216 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.0.0 Reporter: Patrick Hunt Fix For: 3.3.0 While debugging a client issue we saw multiple areas for improvement in C logging. It might be a good idea to also move to log4c. Anyone have experience with this? multithread an issue? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-65) Log information on connection properties
[ https://issues.apache.org/jira/browse/ZOOKEEPER-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-65: -- Fix Version/s: (was: 3.2.0) 3.3.0 Release Note: not a blocker for 3.2, moving to 3.3 Log information on connection properties Key: ZOOKEEPER-65 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-65 Project: Zookeeper Issue Type: Improvement Components: c client, java client, server Reporter: Patrick Hunt Fix For: 3.3.0 We should log information on the connection to enable better field issue debugging. In particular if we logged the connection latency (time for req-resp) during session establishment this would give some information about the connection. We should log the initial reading at INFO level, then log subsequent information at trace level. Would be nice to log trace events for client/server pings for example. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-34) Optimize string deserialization
[ https://issues.apache.org/jira/browse/ZOOKEEPER-34?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-34: -- Fix Version/s: (was: 3.2.0) 3.3.0 Release Note: not a blocker for 3.2, moving to 3.3 Optimize string deserialization --- Key: ZOOKEEPER-34 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-34 Project: Zookeeper Issue Type: New Feature Components: server Reporter: Patrick Hunt Fix For: 3.3.0 Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1952497group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-233) Create a slimer jar for clients to reduce thier disk footprint.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-233: --- Fix Version/s: (was: 3.2.0) 3.3.0 Release Note: not a blocker for 3.2, moving to 3.3 Create a slimer jar for clients to reduce thier disk footprint. --- Key: ZOOKEEPER-233 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-233 Project: Zookeeper Issue Type: New Feature Components: build, java client Reporter: Hiram Chirino Priority: Trivial Fix For: 3.3.0 Patrick request I open up this in issue in this [email thread|http://n2.nabble.com/ActiveMQ-is-now-using-ZooKeeper-td1573272.html] -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-62) Generally improve logging to enable debuggability in the field.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-62?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-62: -- Fix Version/s: (was: 3.2.0) 3.3.0 Release Note: not a blocker for 3.2, moving to 3.3 Generally improve logging to enable debuggability in the field. --- Key: ZOOKEEPER-62 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-62 Project: Zookeeper Issue Type: Improvement Components: c client, java client, server Reporter: Patrick Hunt Assignee: Flavio Paiva Junqueira Fix For: 3.3.0 Attachments: zoo-log.tgz We need to improve our logging to enable debugging of field issues. Flavio, assigning to you as you are currently looking at some client/server issues that could benefit from better logging. Please attach patches if you see potential areas for improvement. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-146) Allow clients to retrieve the list of hosts/servers from a URL
[ https://issues.apache.org/jira/browse/ZOOKEEPER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-146: --- Fix Version/s: (was: 3.2.0) 3.3.0 Release Note: not a blocker for 3.2, moving to 3.3 Allow clients to retrieve the list of hosts/servers from a URL -- Key: ZOOKEEPER-146 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-146 Project: Zookeeper Issue Type: Improvement Components: java client Affects Versions: 3.0.0 Reporter: Jakob Homan Fix For: 3.3.0 Attachments: ZOOKEEPER-146.patch As I suggested in ZOOKEEPER-107, it would be nice to allow clients to specify their hosts strings via a URL so that this can change dynamically. For instance, obtain the current list of hosts from a webpage or a file on disk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-195) Configuration information is spread across too many docs. Consolidate into one
[ https://issues.apache.org/jira/browse/ZOOKEEPER-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-195: --- Fix Version/s: (was: 3.2.0) 3.3.0 Release Note: not a blocker for 3.2, moving to 3.3 Configuration information is spread across too many docs. Consolidate into one -- Key: ZOOKEEPER-195 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-195 Project: Zookeeper Issue Type: Improvement Components: documentation Affects Versions: 3.0.0 Reporter: Robbie Scott Priority: Minor Fix For: 3.3.0 Attachments: ZOOKEEPER-195.patch Original Estimate: 1h Remaining Estimate: 1h There are definition lists of the configuration parameters in both the getting started guide and in the admin guide. It should probably only exist in the administration guide in the configuration parameters section. Note that in the getting started guide, definitions of config params can be found in both - Installing and Running ZooKeeper in Single Server Mode - Running Replicated ZooKeeper -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-396) race condition in zookeeper client library between zookeeper_close and zoo_synchronous api
[ https://issues.apache.org/jira/browse/ZOOKEEPER-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-396: Fix Version/s: 3.2.0 race condition in zookeeper client library between zookeeper_close and zoo_synchronous api -- Key: ZOOKEEPER-396 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-396 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.1.1 Reporter: Mahadev konar Assignee: Mahadev konar Priority: Critical Fix For: 3.2.0 There is a race condition in zoopkeeper client library wherein if the application calls zookeeper_close() and zoo_anysynchronouscall simultaneously, sometimes the zoo_sync api call gets hung waiting for a notification whcih will never come. We might want to create another bugfix release for this. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-207) All the threads should have names so that its easier to see throguh a stack trace.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-207?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick Hunt updated ZOOKEEPER-207: --- Fix Version/s: (was: 3.2.0) 3.3.0 Release Note: not a blocker for 3.2, moving to 3.3 All the threads should have names so that its easier to see throguh a stack trace. -- Key: ZOOKEEPER-207 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-207 Project: Zookeeper Issue Type: Improvement Components: server Affects Versions: 3.0.0 Reporter: Mahadev konar Assignee: Mahadev konar Priority: Minor Fix For: 3.3.0 the threads should have names so that its easier to look through the stack trace. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-59) Synchronized block in NIOServerCnxn
[
https://issues.apache.org/jira/browse/ZOOKEEPER-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-59:
--
Fix Version/s: (was: 3.2.0)
3.3.0
Release Note: not a blocker for 3.2, moving to 3.3
Synchronized block in NIOServerCnxn
---
Key: ZOOKEEPER-59
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-59
Project: Zookeeper
Issue Type: Bug
Components: server
Reporter: Flavio Paiva Junqueira
Assignee: Flavio Paiva Junqueira
Fix For: 3.3.0
Attachments: ZOOKEEPER-59.patch
There are two synchronized blocks locking on different objects, and to me
they should be guarded by the same object. Here are the parts of the code I'm
talking about:
{noformat}
nioservercnxn.readrequ...@444
...
synchronized (this) {
outstandingRequests++;
// check throttling
if (zk.getInProcess() factory.outstandingLimit) {
disableRecv();
// following lines should not be needed since we are
already
// reading
// } else {
// enableRecv();
}
}
{noformat}
{noformat}
nioservercnxn.sendrespo...@740
...
synchronized (this.factory) {
outstandingRequests--;
// check throttling
if (zk.getInProcess() factory.outstandingLimit
|| outstandingRequests 1) {
sk.selector().wakeup();
enableRecv();
}
}
{noformat}
I think the second one is correct, and the first synchronized block should be
guarded by this.factory.
This could be related to issue ZOOKEEPER-57, but I have no concrete
indication that this is the case so far.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-411) Building zookeeper fails on RHEL 5 64 bit during test-cppunit
Building zookeeper fails on RHEL 5 64 bit during test-cppunit - Key: ZOOKEEPER-411 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-411 Project: Zookeeper Issue Type: Bug Environment: RHEL5, 64bit Reporter: Lee Tucker Fix For: 3.2.0 [exec] Zookeeper_simpleSystem::testAsyncWatcherAutoReset : assertion [exec] [exec] /grid/0/gs/gridre/hudson/workspace/zootestbuild/trunk/src/c/tests/TestClient.cc:499: Assertion: assertion failed [Expression: ctx.waitForDisconnected(zk)] [exec] Failures !!! [exec] Run: 32 Failure total: 1 Failures: 1 Errors: 0 [exec] make: *** [run-check] Error 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
