[jira] Commented: (ZOOKEEPER-343) add tests that specifically verify the zkmain and qpmain classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696552#action_12696552 ] Hudson commented on ZOOKEEPER-343: -- Integrated in ZooKeeper-trunk #274 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/274/]) . add tests that specifically verify the zkmain and qpmain classes. (phunt via mahadev) > add tests that specifically verify the zkmain and qpmain classes > > > Key: ZOOKEEPER-343 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-343 > Project: Zookeeper > Issue Type: Improvement > Components: tests >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-343.patch, ZOOKEEPER-343.patch > > > We are missing tests for these two main() routines. > Add tests that verify standalone and quorum (2 servers is probably enough) by > starting and connecting a client. > Use on-disk configuration files to configure these. > (ie verify starting with actual config files) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-343) add tests that specifically verify the zkmain and qpmain classes
[
https://issues.apache.org/jira/browse/ZOOKEEPER-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12696251#action_12696251
]
Mahadev konar commented on ZOOKEEPER-343:
-
i am really glad that you removed this
{code}
runStandalone(new ZooKeeperServer.Factory()
{code}
That zookeeperserver factory used to annoy me a lot.
I have one question though --
- you have removed the QuorumpeerConfig inheting from ServerConfig...
I actually liked that and would like to keep it. Imagine we just passed around
configs in our server code inside al lthe processors. I would like to have one
common interface to pass around all the config stuff that can be used by all
the code on the server side.
> add tests that specifically verify the zkmain and qpmain classes
>
>
> Key: ZOOKEEPER-343
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-343
> Project: Zookeeper
> Issue Type: Improvement
> Components: tests
>Reporter: Patrick Hunt
>Assignee: Patrick Hunt
> Fix For: 3.2.0
>
> Attachments: ZOOKEEPER-343.patch, ZOOKEEPER-343.patch
>
>
> We are missing tests for these two main() routines.
> Add tests that verify standalone and quorum (2 servers is probably enough) by
> starting and connecting a client.
> Use on-disk configuration files to configure these.
> (ie verify starting with actual config files)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-343) add tests that specifically verify the zkmain and qpmain classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694882#action_12694882 ] Hadoop QA commented on ZOOKEEPER-343: - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12404414/ZOOKEEPER-343.patch against trunk revision 761126. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/9/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/9/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/9/console This message is automatically generated. > add tests that specifically verify the zkmain and qpmain classes > > > Key: ZOOKEEPER-343 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-343 > Project: Zookeeper > Issue Type: Improvement > Components: tests >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-343.patch, ZOOKEEPER-343.patch > > > We are missing tests for these two main() routines. > Add tests that verify standalone and quorum (2 servers is probably enough) by > starting and connecting a client. > Use on-disk configuration files to configure these. > (ie verify starting with actual config files) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-343) add tests that specifically verify the zkmain and qpmain classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694791#action_12694791 ] Hadoop QA commented on ZOOKEEPER-343: - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12402861/ZOOKEEPER-343.patch against trunk revision 761077. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 4 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 1 new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/6/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/6/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/6/console This message is automatically generated. > add tests that specifically verify the zkmain and qpmain classes > > > Key: ZOOKEEPER-343 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-343 > Project: Zookeeper > Issue Type: Improvement > Components: tests >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-343.patch > > > We are missing tests for these two main() routines. > Add tests that verify standalone and quorum (2 servers is probably enough) by > starting and connecting a client. > Use on-disk configuration files to configure these. > (ie verify starting with actual config files) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-343) add tests that specifically verify the zkmain and qpmain classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688367#action_12688367 ] Patrick Hunt commented on ZOOKEEPER-343: Yea, I didn't notice that regress either, it was only a few days later that I noticed it, only luck that it was before rc0 became official. Figured this was a good way to ensure we don't break it again. ;-) Also working on another issue that I wanted to verify that need to run quorum using config... good to have in general. > add tests that specifically verify the zkmain and qpmain classes > > > Key: ZOOKEEPER-343 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-343 > Project: Zookeeper > Issue Type: Improvement > Components: tests >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-343.patch > > > We are missing tests for these two main() routines. > Add tests that verify standalone and quorum (2 servers is probably enough) by > starting and connecting a client. > Use on-disk configuration files to configure these. > (ie verify starting with actual config files) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-343) add tests that specifically verify the zkmain and qpmain classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12685414#action_12685414 ] Chris Darroch commented on ZOOKEEPER-343: - Great patch; thank you -- this would have helped me avoid the regression from ZOOKEEPER-326/330/341. I ran the unit tests after ZOOKEEPER-330 and everything looked good; there was one non-reproducible error which I went away after the first test run and which I chalked up to my ancient CPU's slow speed. A classic case of PEBKAC where the computer knew better than I did that there really was a problem. > add tests that specifically verify the zkmain and qpmain classes > > > Key: ZOOKEEPER-343 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-343 > Project: Zookeeper > Issue Type: Improvement > Components: tests >Reporter: Patrick Hunt >Assignee: Patrick Hunt > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-343.patch > > > We are missing tests for these two main() routines. > Add tests that verify standalone and quorum (2 servers is probably enough) by > starting and connecting a client. > Use on-disk configuration files to configure these. > (ie verify starting with actual config files) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
