[jira] Updated: (ZOOKEEPER-303) Bin scripts don't work on Mac
[
https://issues.apache.org/jira/browse/ZOOKEEPER-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-303:
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this to trunk. thanks tom.
Bin scripts don't work on Mac
-
Key: ZOOKEEPER-303
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-303
Project: Zookeeper
Issue Type: Bug
Components: scripts
Environment: Mac OS X
Reporter: Tom White
Assignee: Tom White
Attachments: zookeeper-303.patch
Macs don't support the -f option in readlink
{noformat}
$ bin/zkServer.sh start
JMX enabled by default
readlink: illegal option -- f
usage: readlink [-n] [file ...]
{noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-309) core dump using zoo_get_acl()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12672446#action_12672446 ] Mahadev konar commented on ZOOKEEPER-309: - can we include a test case for this so that we do not get embarrased again? core dump using zoo_get_acl() -- Key: ZOOKEEPER-309 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.1 Reporter: Chris Darroch Fix For: 3.1.0, 3.2.0 Attachments: zookeeper.c.patch The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request. The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer. The attached patch removes this call. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-314) add wiki docs for bookeeper.
add wiki docs for bookeeper. Key: ZOOKEEPER-314 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-314 Project: Zookeeper Issue Type: Improvement Affects Versions: 3.1.0 Reporter: Mahadev konar Fix For: 3.2.0 we should have a wiki page for bookeeper for users to take a cursory look at what it is. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-316) configure option --without-cppunit does not work
configure option --without-cppunit does not work Key: ZOOKEEPER-316 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-316 Project: Zookeeper Issue Type: Bug Reporter: Mahadev konar configure option --without-cppunit does not work. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-316) configure option --without-cppunit does not work
[ https://issues.apache.org/jira/browse/ZOOKEEPER-316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-316: Affects Version/s: 3.1.0 configure option --without-cppunit does not work Key: ZOOKEEPER-316 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-316 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.0 Reporter: Mahadev konar configure option --without-cppunit does not work. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-273) Zookeeper c client build should not depend on CPPUNIT
[ https://issues.apache.org/jira/browse/ZOOKEEPER-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12674304#action_12674304 ] Mahadev konar commented on ZOOKEEPER-273: - thanks for pointing it out chris. I have created a new jira to fix the problem - ZOOKEEPER-316 Zookeeper c client build should not depend on CPPUNIT - Key: ZOOKEEPER-273 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-273 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.1.0 Reporter: Runping Qi Assignee: Patrick Hunt Fix For: 3.2.0 Attachments: patch_zookeeper_273.txt, ZOOKEEPER-273.patch, ZOOKEEPER-273.patch One should be able to build Zookeeper C client libs on a machine without CPPUNIT installation. A simple fix is to remove from configure.ac the following line: M_PATH_CPPUNIT(1.10.2) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-317) avoid exporting functions which may be static
[ https://issues.apache.org/jira/browse/ZOOKEEPER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12674330#action_12674330 ] Mahadev konar commented on ZOOKEEPER-317: - I agree with ben. I think it should be ok with making them static in 3.2. avoid exporting functions which may be static - Key: ZOOKEEPER-317 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-317 Project: Zookeeper Issue Type: Improvement Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1, 3.2.0 Reporter: Chris Darroch Priority: Minor Fix For: 4.0.0 A number of functions in the 3.x.x C API such as add_to_list() and getImpl() from zk_hashtable.c and data_result_checker() and child_result_checker() from zookeeper.c could be marked static and removed from the set of exported functions. Since this change would remove functions from the API, it should wait for 4.0.0. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-316) configure option --without-cppunit does not work
[ https://issues.apache.org/jira/browse/ZOOKEEPER-316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12674407#action_12674407 ] Mahadev konar commented on ZOOKEEPER-316: - ./configure --without-cppunit make ... aclocal:configure.ac:36: warning: macro `AM_PATH_CPPUNIT' not found in library ... Makefile.am:68: wildcard tests/*.cc: non-POSIX variable name Makefile.am:68: (probably a GNU make extension) Makefile.am:68: wildcard tests/*.h: non-POSIX variable name Makefile.am:68: (probably a GNU make extension) Makefile.am:77: shell cat tests/wrappers.opt: non-POSIX variable name Makefile.am:77: (probably a GNU make extension) Makefile.am:90: shell cat tests/wrappers-mt.opt: non-POSIX variable name Makefile.am:90: (probably a GNU make extension) ... configure.ac:36: error: possibly undefined macro: AM_PATH_CPPUNIT If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. make: *** [configure] Error 1 here is the trace provided by chris. configure option --without-cppunit does not work Key: ZOOKEEPER-316 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-316 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.0 Reporter: Mahadev konar configure option --without-cppunit does not work. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-322) move examples out of docs into contrib/examples
move examples out of docs into contrib/examples - Key: ZOOKEEPER-322 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-322 Project: Zookeeper Issue Type: Improvement Reporter: Mahadev konar move examples out of docs into contrib/examples -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-321) optmize session tracking in zookeeper.
optmize session tracking in zookeeper. -- Key: ZOOKEEPER-321 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-321 Project: Zookeeper Issue Type: New Feature Reporter: Mahadev konar sometimes a lot of zookeeper clients are read only. For such clients we do not need the session tracking in zookeeper. Getting rid of session tracking for such clients will help us sclae much better. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-325) FLENewEpoch test fails.
FLENewEpoch test fails. --- Key: ZOOKEEPER-325 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-325 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.0 Environment: linux 2.6.9-5.ELsmp Reporter: Mahadev konar Fix For: 3.2.0 Attachments: TEST-org.apache.zookeeper.test.FLENewEpochTest.txt FLENewEpochTest fails quite frequently on my machine. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-308) improve the atomic broadcast performance 3x
[ https://issues.apache.org/jira/browse/ZOOKEEPER-308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-308: Attachment: ZOOKEEPER-308.patch this patch has a minor indentation change. improve the atomic broadcast performance 3x --- Key: ZOOKEEPER-308 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-308 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Benjamin Reed Assignee: Benjamin Reed Attachments: dat.png, ZOOKEEPER-308.patch, ZOOKEEPER-308.patch, ZOOKEEPER-308.patch We need a benchmark for zab, the atomic broadcast protocol of zookeeper. we can also do some small tweaks to make zab go much faster. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-78: --- Attachment: ZOOKEEPER-78.patch it would be great ot have this jira in 3.2. this patch removes the zookeeper facade, and makes it work with the current trunk. I have to still go through all the corner cases and see if they have been handled. Also, I need to implement the lock interface in writelock. comments are welcome... added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation --- Key: ZOOKEEPER-78 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.0.0 Reporter: james strachan Assignee: james strachan Fix For: 3.2.0 Attachments: patch_with_including_Benjamin's_fix.patch, using_zookeeper_facade.patch, ZOOKEEPER-78.patch Here's a patch which adds a little WriteLock helper class for performing leader elections or creating exclusive locks in some directory znode. Note its an early cut; am sure we can improve it over time. The aim is to avoid folks having to use the low level ZK stuff but provide a simpler high level abstraction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-78: --- Attachment: ZOOKEEPER-78.patch an updated patch. - added acls to writelock - removed ZookeeperTestSupport, used ClientBase insted of this new class - made the package name org.apache.zookepeer.protocols.lock so that each protocol has its own direcotry - moved the docs.html to pakcage.html it still does not impleement the lock interface of java. Ill add it in the next patch. added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation --- Key: ZOOKEEPER-78 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.0.0 Reporter: james strachan Assignee: james strachan Fix For: 3.2.0 Attachments: patch_with_including_Benjamin's_fix.patch, using_zookeeper_facade.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch Here's a patch which adds a little WriteLock helper class for performing leader elections or creating exclusive locks in some directory znode. Note its an early cut; am sure we can improve it over time. The aim is to avoid folks having to use the low level ZK stuff but provide a simpler high level abstraction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-326) standalone server ignores tickTime configuration
[ https://issues.apache.org/jira/browse/ZOOKEEPER-326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar reassigned ZOOKEEPER-326: --- Assignee: Chris Darroch +1 for the patch. standalone server ignores tickTime configuration Key: ZOOKEEPER-326 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-326 Project: Zookeeper Issue Type: Bug Components: server Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Assignee: Chris Darroch Priority: Minor Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-326.patch When using the ZooKeeper server in standalone mode, it ignores the tickTime setting in the configuration file and uses the DEFAULT_TICK_TIME of 3000 coded into ZooKeeperServer.java. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-330) zookeeper standalone server does not startup with just a port and datadir.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-330: Attachment: ZOOKEEPER-330.patch this patch fixes the issue. ZOOKEEPER-326 made the ZookeeperServerMain args to take just a config file rather than its initial semantics of taking a clientport and datadir. The ZookeeperServerMain class now takes the same arguments that it did earlier with an additional optional argument of ticktime. so the command will look like ZooKeeperServerMain port datadir [ticktime] ticktime being optional. If users want to use a config file for a standalone server they can use QuorumPeerMain configfile zookeeper standalone server does not startup with just a port and datadir. -- Key: ZOOKEEPER-330 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.1, 3.2.0 Reporter: Mahadev konar Assignee: Mahadev konar Priority: Blocker Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-330.patch ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the starting of zookeeperserver with just the port and datadir. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-330) zookeeper standalone server does not startup with just a port and datadir.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-330: Status: Patch Available (was: Open) zookeeper standalone server does not startup with just a port and datadir. -- Key: ZOOKEEPER-330 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.1, 3.2.0 Reporter: Mahadev konar Assignee: Mahadev konar Priority: Blocker Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-330.patch ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the starting of zookeeperserver with just the port and datadir. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-330) zookeeper standalone server does not startup with just a port and datadir.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12676482#action_12676482 ] Mahadev konar commented on ZOOKEEPER-330: - also the c tests fail to run right now since the api for ZookeeperServerMain changed. Now it passes again with the patch. zookeeper standalone server does not startup with just a port and datadir. -- Key: ZOOKEEPER-330 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.1, 3.2.0 Reporter: Mahadev konar Assignee: Mahadev konar Priority: Blocker Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-330.patch ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the starting of zookeeperserver with just the port and datadir. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-318) remove locking in zk_hashtable.c or add locking in collect_keys()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12676782#action_12676782 ] Mahadev konar commented on ZOOKEEPER-318: - i looked thorugh the code and what you suggest looks right to me. Thoguh, did you see any performance impact from using the lcoks? if not, I would proabably leave the locks their, since it prevents against future changes (say we have two threads accessing the methods in zk_hashtable.c).. what do you think? remove locking in zk_hashtable.c or add locking in collect_keys() - Key: ZOOKEEPER-318 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-318 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Fix For: 3.2.0, 4.0.0 Attachments: ZOOKEEPER-318.patch From a review of zk_hashtable.c it appears to me that all functions which manipulate the hashtables are called from the IO thread, and therefore any need for locking is obviated. If I'm wrong about that, then I think at a minimum collect_keys() should acquire a lock in the same manner as collect_session_watchers(). Both iterate over hashtable contents (in the latter case using copy_table()). However, from what I can see, the only function (besides the init/destroy functions used when creating a zhandle_t) called from the completion thread is deliverWatchers(), which simply iterates over a delivery list created from the hashtables by collectWatchers(). The activateWatcher() function contains comments which describe it being called by the completion thread, but in fact it is called by the IO thread in zookeeper_process(). I believe all calls to collectWatchers(), activateWatcher(), and collect_keys() are made by the IO thread in zookeeper_interest(), zookeeper_process(), check_events(), send_set_watches(), and handle_error(). Note that queue_session_event() is aliased as PROCESS_SESSION_EVENT, but appears only in handle_error() and check_events(). Also note that handle_error() is called only in zookeeper_process() and handle_socket_error_msg(), which is used only by the IO thread, so far as I can see. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12676802#action_12676802 ] Mahadev konar commented on ZOOKEEPER-78: sorry for my late response tom.. i havent had a real close look at the interfaces and methods in this patch myself, so thanks for reviewing.. I was mainly looking at the handling of zookeeper events. 1) I think you are rught that we should probably have call back methods with lockacruired and lockreleeased methods. The current implementation is too restrictive. 2) I am with you on this one as well... I hadn't implemented the lock interface just because I had the same reservations as you.. I think for now we should just leave it as it is without implementing the lock interface and see what our users have to say.. 3) agreed.. added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation --- Key: ZOOKEEPER-78 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.0.0 Reporter: james strachan Assignee: james strachan Fix For: 3.2.0 Attachments: patch_with_including_Benjamin's_fix.patch, using_zookeeper_facade.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch Here's a patch which adds a little WriteLock helper class for performing leader elections or creating exclusive locks in some directory znode. Note its an early cut; am sure we can improve it over time. The aim is to avoid folks having to use the low level ZK stuff but provide a simpler high level abstraction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-319) add locking around auth info in zhandle_t
[
https://issues.apache.org/jira/browse/ZOOKEEPER-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-319:
Attachment: ZOOKEEPER-319.patch
just a minor modification. my compiler fails on compiliing
consta char* auth_data without initialization.
+1 to the patch.
one minor nit --
- we have some logging in auth_completion_func() in zookeeper.c
{noformat}
zoo_lock_auth(zh);
if(rc!=0){
LOG_ERROR((Authentication scheme %s failed. Connection closed.,
zh-auth.scheme));
zh-state=ZOO_AUTH_FAILED_STATE;
}else{
zh-auth.state=1; // active
LOG_INFO((Authentication scheme %s succeeded, zh-auth.scheme));
}
if (zh-auth.completion) {
auth_completion = zh-auth.completion;
auth_data = zh-auth.data;
zh-auth.completion=0;
}
zoo_unlock_auth(zh);
{noformat}
Should we get rid of logging within the lock?
add locking around auth info in zhandle_t
-
Key: ZOOKEEPER-319
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-319
Project: Zookeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.0.0, 3.0.1, 3.1.0
Reporter: Chris Darroch
Fix For: 3.1.1, 3.2.0
Attachments: ZOOKEEPER-319.patch, ZOOKEEPER-319.patch
Looking over the zookeeper.c code it appears to me that the zoo_add_auth()
function may be called at any time by the user in their main thread. This
function alters the elements of the auth_info structure in the zhandle_t
structure.
Meanwhile, the IO thread may read those elements at any time in such
functions as send_auth_info() and auth_completion_func(). It seems
important, then, to add a lock which prevents data being read by the IO
thread while only partially changed by the user's thread. The attached patch
add such a lock.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-320) call auth completion in free_completions()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12676825#action_12676825 ] Mahadev konar commented on ZOOKEEPER-320: - +1 for the second patch. call auth completion in free_completions() -- Key: ZOOKEEPER-320 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-320 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-320-319.patch, ZOOKEEPER-320.patch If a client calls zoo_add_auth() with an invalid scheme (e.g., foo) the ZooKeeper server will mark their session expired and close the connection. However, the C client has returned immediately after queuing the new auth data to be sent with a ZOK return code. If the client then waits for their auth completion function to be called, they can wait forever, as no session event is ever delivered to that completion function. All other completion functions are notified of session events by free_completions(), which is called by cleanup_bufs() in handle_error() in handle_socket_error_msg(). In actual fact, what can happen (about 50% of the time, for me) is that the next call by the IO thread to flush_send_queue() calls send() from within send_buffer(), and receives a SIGPIPE signal during this send() call. Because the ZooKeeper C API is a library, it properly does not catch that signal. If the user's code is not catching that signal either, they experience an abort caused by an untrapped signal. If they are ignoring the signal -- which is common in context I'm working in, the Apache httpd server -- then flush_send_queue()'s error return code is EPIPE, which is logged by handle_socket_error_msg(), and all non-auth completion functions are notified of a session event. However, if the caller is waiting for their auth completion function, they wait forever while the IO thread tries repeatedly to reconnect and is rejected by the server as having an expired session. So, first of all, it would be useful to document in the C API portion of the programmer's guide that trapping or ignoring SIGPIPE is important, as this signal may be generated by the C API. Next, the two attached patches call the auth completion function, if any, in free_completions(), which fixes this problem for me. The second attached patch includes auth lock/unlock function, as per ZOOKEEPER-319. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-320) call auth completion in free_completions()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar reassigned ZOOKEEPER-320: --- Assignee: Chris Darroch call auth completion in free_completions() -- Key: ZOOKEEPER-320 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-320 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Assignee: Chris Darroch Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-320-319.patch, ZOOKEEPER-320.patch If a client calls zoo_add_auth() with an invalid scheme (e.g., foo) the ZooKeeper server will mark their session expired and close the connection. However, the C client has returned immediately after queuing the new auth data to be sent with a ZOK return code. If the client then waits for their auth completion function to be called, they can wait forever, as no session event is ever delivered to that completion function. All other completion functions are notified of session events by free_completions(), which is called by cleanup_bufs() in handle_error() in handle_socket_error_msg(). In actual fact, what can happen (about 50% of the time, for me) is that the next call by the IO thread to flush_send_queue() calls send() from within send_buffer(), and receives a SIGPIPE signal during this send() call. Because the ZooKeeper C API is a library, it properly does not catch that signal. If the user's code is not catching that signal either, they experience an abort caused by an untrapped signal. If they are ignoring the signal -- which is common in context I'm working in, the Apache httpd server -- then flush_send_queue()'s error return code is EPIPE, which is logged by handle_socket_error_msg(), and all non-auth completion functions are notified of a session event. However, if the caller is waiting for their auth completion function, they wait forever while the IO thread tries repeatedly to reconnect and is rejected by the server as having an expired session. So, first of all, it would be useful to document in the C API portion of the programmer's guide that trapping or ignoring SIGPIPE is important, as this signal may be generated by the C API. Next, the two attached patches call the auth completion function, if any, in free_completions(), which fixes this problem for me. The second attached patch includes auth lock/unlock function, as per ZOOKEEPER-319. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-320) call auth completion in free_completions()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677169#action_12677169 ] Mahadev konar commented on ZOOKEEPER-320: - my compiler is gcc 3.4.4 call auth completion in free_completions() -- Key: ZOOKEEPER-320 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-320 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Assignee: Chris Darroch Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-320-319.patch, ZOOKEEPER-320-319.patch, ZOOKEEPER-320.patch If a client calls zoo_add_auth() with an invalid scheme (e.g., foo) the ZooKeeper server will mark their session expired and close the connection. However, the C client has returned immediately after queuing the new auth data to be sent with a ZOK return code. If the client then waits for their auth completion function to be called, they can wait forever, as no session event is ever delivered to that completion function. All other completion functions are notified of session events by free_completions(), which is called by cleanup_bufs() in handle_error() in handle_socket_error_msg(). In actual fact, what can happen (about 50% of the time, for me) is that the next call by the IO thread to flush_send_queue() calls send() from within send_buffer(), and receives a SIGPIPE signal during this send() call. Because the ZooKeeper C API is a library, it properly does not catch that signal. If the user's code is not catching that signal either, they experience an abort caused by an untrapped signal. If they are ignoring the signal -- which is common in context I'm working in, the Apache httpd server -- then flush_send_queue()'s error return code is EPIPE, which is logged by handle_socket_error_msg(), and all non-auth completion functions are notified of a session event. However, if the caller is waiting for their auth completion function, they wait forever while the IO thread tries repeatedly to reconnect and is rejected by the server as having an expired session. So, first of all, it would be useful to document in the C API portion of the programmer's guide that trapping or ignoring SIGPIPE is important, as this signal may be generated by the C API. Next, the two attached patches call the auth completion function, if any, in free_completions(), which fixes this problem for me. The second attached patch includes auth lock/unlock function, as per ZOOKEEPER-319. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-330) zookeeper standalone server does not startup with just a port and datadir.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677250#action_12677250 ] Mahadev konar commented on ZOOKEEPER-330: - +1 for the aptch good changes chris... zookeeper standalone server does not startup with just a port and datadir. -- Key: ZOOKEEPER-330 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.1, 3.2.0 Reporter: Mahadev konar Assignee: Mahadev konar Priority: Blocker Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-330.patch, ZOOKEEPER-330.patch ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the starting of zookeeperserver with just the port and datadir. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-330) zookeeper standalone server does not startup with just a port and datadir.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-330: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. Thanks chris. zookeeper standalone server does not startup with just a port and datadir. -- Key: ZOOKEEPER-330 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-330 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.1, 3.2.0 Reporter: Mahadev konar Assignee: Mahadev konar Priority: Blocker Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-330.patch, ZOOKEEPER-330.patch ZOOKEEPER-326 made a change to zookeeperservermain.java that broke the starting of zookeeperserver with just the port and datadir. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-319) add locking around auth info in zhandle_t
[ https://issues.apache.org/jira/browse/ZOOKEEPER-319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-319: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. thanks chris. add locking around auth info in zhandle_t - Key: ZOOKEEPER-319 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-319 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Assignee: Chris Darroch Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-319.patch, ZOOKEEPER-319.patch, ZOOKEEPER-319.patch Looking over the zookeeper.c code it appears to me that the zoo_add_auth() function may be called at any time by the user in their main thread. This function alters the elements of the auth_info structure in the zhandle_t structure. Meanwhile, the IO thread may read those elements at any time in such functions as send_auth_info() and auth_completion_func(). It seems important, then, to add a lock which prevents data being read by the IO thread while only partially changed by the user's thread. The attached patch add such a lock. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-320) call auth completion in free_completions()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-320: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. Thanks chris. call auth completion in free_completions() -- Key: ZOOKEEPER-320 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-320 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Assignee: Chris Darroch Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-320-319.patch, ZOOKEEPER-320-319.patch, ZOOKEEPER-320.patch If a client calls zoo_add_auth() with an invalid scheme (e.g., foo) the ZooKeeper server will mark their session expired and close the connection. However, the C client has returned immediately after queuing the new auth data to be sent with a ZOK return code. If the client then waits for their auth completion function to be called, they can wait forever, as no session event is ever delivered to that completion function. All other completion functions are notified of session events by free_completions(), which is called by cleanup_bufs() in handle_error() in handle_socket_error_msg(). In actual fact, what can happen (about 50% of the time, for me) is that the next call by the IO thread to flush_send_queue() calls send() from within send_buffer(), and receives a SIGPIPE signal during this send() call. Because the ZooKeeper C API is a library, it properly does not catch that signal. If the user's code is not catching that signal either, they experience an abort caused by an untrapped signal. If they are ignoring the signal -- which is common in context I'm working in, the Apache httpd server -- then flush_send_queue()'s error return code is EPIPE, which is logged by handle_socket_error_msg(), and all non-auth completion functions are notified of a session event. However, if the caller is waiting for their auth completion function, they wait forever while the IO thread tries repeatedly to reconnect and is rejected by the server as having an expired session. So, first of all, it would be useful to document in the C API portion of the programmer's guide that trapping or ignoring SIGPIPE is important, as this signal may be generated by the C API. Next, the two attached patches call the auth completion function, if any, in free_completions(), which fixes this problem for me. The second attached patch includes auth lock/unlock function, as per ZOOKEEPER-319. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-318) remove locking in zk_hashtable.c or add locking in collect_keys()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12677592#action_12677592 ] Mahadev konar commented on ZOOKEEPER-318: - your 2 cents are well received :) .. ill just explain where I come from. From my perspective, a multithreaded c code is the most difficult to debug (after ofcourse assembly language :) ) ... So, I get really uncomfortable removing locks from the c code (maybe i am a little paranoid). I would rather add locks and make it MT safe and be future problem resilient. But ofcourse thats my stand on it. I am not too biased on my opinion and would not like to reject any contributions on my own personal opinion. If you do want to contribute the patch as it is, Ill go ahead with that. remove locking in zk_hashtable.c or add locking in collect_keys() - Key: ZOOKEEPER-318 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-318 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Assignee: Chris Darroch Fix For: 3.2.0, 4.0.0 Attachments: ZOOKEEPER-318.patch From a review of zk_hashtable.c it appears to me that all functions which manipulate the hashtables are called from the IO thread, and therefore any need for locking is obviated. If I'm wrong about that, then I think at a minimum collect_keys() should acquire a lock in the same manner as collect_session_watchers(). Both iterate over hashtable contents (in the latter case using copy_table()). However, from what I can see, the only function (besides the init/destroy functions used when creating a zhandle_t) called from the completion thread is deliverWatchers(), which simply iterates over a delivery list created from the hashtables by collectWatchers(). The activateWatcher() function contains comments which describe it being called by the completion thread, but in fact it is called by the IO thread in zookeeper_process(). I believe all calls to collectWatchers(), activateWatcher(), and collect_keys() are made by the IO thread in zookeeper_interest(), zookeeper_process(), check_events(), send_set_watches(), and handle_error(). Note that queue_session_event() is aliased as PROCESS_SESSION_EVENT, but appears only in handle_error() and check_events(). Also note that handle_error() is called only in zookeeper_process() and handle_socket_error_msg(), which is used only by the IO thread, so far as I can see. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-334) bookkeeper benchmark (testclient.java) has compiling errros.
bookkeeper benchmark (testclient.java) has compiling errros. Key: ZOOKEEPER-334 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-334 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Affects Versions: 3.1.0 Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.2.0 bookkeeper benchmark (testclient.java) has compiling errors. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-334) bookkeeper benchmark (testclient.java) has compiling errros.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-334: Attachment: ZOOKEEPER-334.patch this patch fixes the complitaion errors. bookkeeper benchmark (testclient.java) has compiling errros. Key: ZOOKEEPER-334 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-334 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Affects Versions: 3.1.0 Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-334.patch bookkeeper benchmark (testclient.java) has compiling errors. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-334) bookkeeper benchmark (testclient.java) has compiling errros.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-334: Status: Patch Available (was: Open) bookkeeper benchmark (testclient.java) has compiling errros. Key: ZOOKEEPER-334 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-334 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Affects Versions: 3.1.0 Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-334.patch bookkeeper benchmark (testclient.java) has compiling errors. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-333) helgrind thread issues identified in mt c client code
[
https://issues.apache.org/jira/browse/ZOOKEEPER-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-333:
Attachment: helgrind_mt.out
i found some more while running helgrind... attacching the filtered output.
helgrind thread issues identified in mt c client code
-
Key: ZOOKEEPER-333
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-333
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Patrick Hunt
Priority: Critical
Fix For: 3.1.1, 3.2.0
Attachments: helgrind_mt.out
helgrind generated a number of issues, I pulled a bunch of them. Most are
related to the test, some are really issues with the mt zk client code though:
valgrind --tool=helgrind --log-file=helgrind_mt.out ./zktest-mt
==31294== Thread #2: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80ABCF6: notify_thread_ready (mt_adaptor.c:136)
==31294==by 0x80ABE90: do_io (mt_adaptor.c:277)
==31294== Possible data race during write of size 4 at 0x42E9A58
==31294==at 0x8050D83: terminateZookeeperThreads(_zhandle*)
(ZKMocks.cc:518)
==31294==by 0x805543B: DeliverWatchersWrapper::call(_zhandle*, int, int,
char const*, watcher_object_list**) (ZKMocks.cc:261)
==31294==by 0x80520F7: __wrap_deliverWatchers (ZKMocks.cc:220)
==31294==by 0x80A287B: process_completions (zookeeper.c:1393)
==31294==by 0x80ABDAA: do_completion (mt_adaptor.c:332)
==31294== Possible data race during write of size 4 at 0xBEFF5F30
==31294==at 0x80589AF:
Zookeeper_watchers::ConnectionWatcher::~ConnectionWatcher()
(TestWatchers.cc:54)
==31294==by 0x805D062: Zookeeper_watchers::testDefaultSessionWatcher1()
(TestWatchers.cc:438)
==31294==by 0x805608C: CppUnit::TestCallerZookeeper_watchers::runTest()
(TestCaller.h:166)
==31294== Possible data race during write of size 4 at 0x42EB104
==31294==at 0x80A03EE: queue_completion (zookeeper.c:1776)
==31294==by 0x80A3A44: zookeeper_process (zookeeper.c:1598)
==31294==by 0x80AC00B: do_io (mt_adaptor.c:309)
==31294== Thread #29: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80AB9B3: wait_sync_completion (mt_adaptor.c:82)
==31294==by 0x80A1E82: zoo_wget (zookeeper.c:2517)
==31294==by 0x80A1F13: zoo_get (zookeeper.c:2497)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-334) bookkeeper benchmark (testclient.java) has compiling errros.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-334: Attachment: ZOOKEEPER-334.patch the last patch did not compile. I just made some minor changes for it to compile. bookkeeper benchmark (testclient.java) has compiling errros. Key: ZOOKEEPER-334 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-334 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Affects Versions: 3.1.0 Reporter: Mahadev konar Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-334.patch, ZOOKEEPER-334.patch, ZOOKEEPER-334.patch bookkeeper benchmark (testclient.java) has compiling errors. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-332) c client issues (memory leaks) reported by valgrind
[ https://issues.apache.org/jira/browse/ZOOKEEPER-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12678517#action_12678517 ] Mahadev konar commented on ZOOKEEPER-332: - I agree with chris. also for the create_completion_entry( zookeeper.c:1830 in zktest-st) ( the line number is different in the latest code after a few checkins)... has a matcing free() in process_completions. I think we can close this jira for now. c client issues (memory leaks) reported by valgrind --- Key: ZOOKEEPER-332 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-332 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.1.0 Reporter: Patrick Hunt Priority: Blocker Fix For: 3.1.1, 3.2.0 Attachments: valgrind_mt.out, valgrind_st.out Attaching valgrind log files. 1) getpwuid_r doesn't seem like it's due to us 2) the rest seem to be valid -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-332) c client issues (memory leaks) reported by valgrind
[ https://issues.apache.org/jira/browse/ZOOKEEPER-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12678817#action_12678817 ] Mahadev konar commented on ZOOKEEPER-332: - i dont think their is anything like passing known exceptions to valgrind. Also, the exceptions are line number based, which would be difficult to track with code changes in the c code. I would just close this jira for now and revisit it again if someone opens another jira for this. On the other hand, it would be good to have hudson scream if the number of excpetions increase... c client issues (memory leaks) reported by valgrind --- Key: ZOOKEEPER-332 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-332 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.1.0 Reporter: Patrick Hunt Priority: Blocker Fix For: 3.1.1, 3.2.0 Attachments: valgrind_mt.out, valgrind_st.out Attaching valgrind log files. 1) getpwuid_r doesn't seem like it's due to us 2) the rest seem to be valid -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-335) zookeeper servers should commit the new leader txn to their logs.
zookeeper servers should commit the new leader txn to their logs. - Key: ZOOKEEPER-335 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-335 Project: Zookeeper Issue Type: Bug Reporter: Mahadev konar currently the zookeeper followers do not commit the new leader election. This will cause problems in a failure scenarios with a follower acking to the same leader txn id twice, which might be two different intermittent leaders and allowing them to propose two different txn's of the same zxid. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-281) autoreconf fails for /zookeeper-3.0.1/src/c/
[ https://issues.apache.org/jira/browse/ZOOKEEPER-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679393#action_12679393 ] Mahadev konar commented on ZOOKEEPER-281: - +1 for the patch... autoreconf fails for /zookeeper-3.0.1/src/c/ Key: ZOOKEEPER-281 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-281 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.1 Environment: Linux dememax-laptop 2.6.27-gentoo-r8 #2 SMP Fri Jan 23 13:42:35 MSK 2009 i686 Intel(R) Core(TM)2 CPU T5600 @ 1.83GHz GenuineIntel GNU/Linux autoconf (GNU Autoconf) 2.63 automake (GNU automake) 1.10.2 m4 (GNU M4) 1.4.11 aclocal (GNU automake) 1.10.2 ltmain.sh (GNU libtool) 1.5.26 (1.1220.2.493 2008/02/01 16:58:18) basename (GNU coreutils) 6.10 gettext (GNU gettext-runtime) 0.17 GNU ld (GNU Binutils) 2.18 Reporter: Maxim P. Dementiev Assignee: Patrick Hunt Fix For: 3.2.0 Attachments: autoreconf.log, configure-autoreconf-2.63.gz, configure.gz, ZOOKEEPER-281.patch autoreconf -i -f -v autoreconf-2.63: Entering directory `.' autoreconf-2.63: configure.ac: not using Gettext autoreconf-2.63: running: aclocal --force configure.ac:21: error: AC_SUBST: `DX_FLAG_[]DX_CURRENT_FEATURE' is not a valid shell variable name acinclude.m4:77: DX_REQUIRE_PROG is expanded from... acinclude.m4:117: DX_ARG_ABLE is expanded from... acinclude.m4:178: DX_INIT_DOXYGEN is expanded from... configure.ac:21: the top level autom4te-2.63: /usr/bin/m4 failed with exit status: 1 aclocal-1.10: autom4te failed with exit status: 1 autoreconf-2.63: aclocal failed with exit status: 1 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-318) remove locking in zk_hashtable.c or add locking in collect_keys()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-318: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. Thnaks chris. remove locking in zk_hashtable.c or add locking in collect_keys() - Key: ZOOKEEPER-318 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-318 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Assignee: Chris Darroch Fix For: 3.2.0 Attachments: ZOOKEEPER-318.patch From a review of zk_hashtable.c it appears to me that all functions which manipulate the hashtables are called from the IO thread, and therefore any need for locking is obviated. If I'm wrong about that, then I think at a minimum collect_keys() should acquire a lock in the same manner as collect_session_watchers(). Both iterate over hashtable contents (in the latter case using copy_table()). However, from what I can see, the only function (besides the init/destroy functions used when creating a zhandle_t) called from the completion thread is deliverWatchers(), which simply iterates over a delivery list created from the hashtables by collectWatchers(). The activateWatcher() function contains comments which describe it being called by the completion thread, but in fact it is called by the IO thread in zookeeper_process(). I believe all calls to collectWatchers(), activateWatcher(), and collect_keys() are made by the IO thread in zookeeper_interest(), zookeeper_process(), check_events(), send_set_watches(), and handle_error(). Note that queue_session_event() is aliased as PROCESS_SESSION_EVENT, but appears only in handle_error() and check_events(). Also note that handle_error() is called only in zookeeper_process() and handle_socket_error_msg(), which is used only by the IO thread, so far as I can see. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-333) helgrind thread issues identified in mt c client code
[
https://issues.apache.org/jira/browse/ZOOKEEPER-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679667#action_12679667
]
Mahadev konar commented on ZOOKEEPER-333:
-
chris,
the run was from the trunk. I dont have a revision number but i think their
hasnt been any code change to the files mentioned after I uploaded the file. So
the line numbers should match.
helgrind thread issues identified in mt c client code
-
Key: ZOOKEEPER-333
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-333
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Patrick Hunt
Assignee: Mahadev konar
Priority: Critical
Fix For: 3.1.1, 3.2.0
Attachments: helgrind_mt.out
helgrind generated a number of issues, I pulled a bunch of them. Most are
related to the test, some are really issues with the mt zk client code though:
valgrind --tool=helgrind --log-file=helgrind_mt.out ./zktest-mt
==31294== Thread #2: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80ABCF6: notify_thread_ready (mt_adaptor.c:136)
==31294==by 0x80ABE90: do_io (mt_adaptor.c:277)
==31294== Possible data race during write of size 4 at 0x42E9A58
==31294==at 0x8050D83: terminateZookeeperThreads(_zhandle*)
(ZKMocks.cc:518)
==31294==by 0x805543B: DeliverWatchersWrapper::call(_zhandle*, int, int,
char const*, watcher_object_list**) (ZKMocks.cc:261)
==31294==by 0x80520F7: __wrap_deliverWatchers (ZKMocks.cc:220)
==31294==by 0x80A287B: process_completions (zookeeper.c:1393)
==31294==by 0x80ABDAA: do_completion (mt_adaptor.c:332)
==31294== Possible data race during write of size 4 at 0xBEFF5F30
==31294==at 0x80589AF:
Zookeeper_watchers::ConnectionWatcher::~ConnectionWatcher()
(TestWatchers.cc:54)
==31294==by 0x805D062: Zookeeper_watchers::testDefaultSessionWatcher1()
(TestWatchers.cc:438)
==31294==by 0x805608C: CppUnit::TestCallerZookeeper_watchers::runTest()
(TestCaller.h:166)
==31294== Possible data race during write of size 4 at 0x42EB104
==31294==at 0x80A03EE: queue_completion (zookeeper.c:1776)
==31294==by 0x80A3A44: zookeeper_process (zookeeper.c:1598)
==31294==by 0x80AC00B: do_io (mt_adaptor.c:309)
==31294== Thread #29: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80AB9B3: wait_sync_completion (mt_adaptor.c:82)
==31294==by 0x80A1E82: zoo_wget (zookeeper.c:2517)
==31294==by 0x80A1F13: zoo_get (zookeeper.c:2497)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-333) helgrind thread issues identified in mt c client code
[
https://issues.apache.org/jira/browse/ZOOKEEPER-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679667#action_12679667
]
mahadev edited comment on ZOOKEEPER-333 at 3/6/09 9:50 AM:
-
chris,
the run was from the trunk. I dont have a revision number but i think their
hasnt been any code change to the source files after I uploaded the traces. So
the line numbers should match.
was (Author: mahadev):
chris,
the run was from the trunk. I dont have a revision number but i think their
hasnt been any code change to the files mentioned after I uploaded the file. So
the line numbers should match.
helgrind thread issues identified in mt c client code
-
Key: ZOOKEEPER-333
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-333
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Patrick Hunt
Assignee: Mahadev konar
Priority: Critical
Fix For: 3.1.1, 3.2.0
Attachments: helgrind_mt.out
helgrind generated a number of issues, I pulled a bunch of them. Most are
related to the test, some are really issues with the mt zk client code though:
valgrind --tool=helgrind --log-file=helgrind_mt.out ./zktest-mt
==31294== Thread #2: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80ABCF6: notify_thread_ready (mt_adaptor.c:136)
==31294==by 0x80ABE90: do_io (mt_adaptor.c:277)
==31294== Possible data race during write of size 4 at 0x42E9A58
==31294==at 0x8050D83: terminateZookeeperThreads(_zhandle*)
(ZKMocks.cc:518)
==31294==by 0x805543B: DeliverWatchersWrapper::call(_zhandle*, int, int,
char const*, watcher_object_list**) (ZKMocks.cc:261)
==31294==by 0x80520F7: __wrap_deliverWatchers (ZKMocks.cc:220)
==31294==by 0x80A287B: process_completions (zookeeper.c:1393)
==31294==by 0x80ABDAA: do_completion (mt_adaptor.c:332)
==31294== Possible data race during write of size 4 at 0xBEFF5F30
==31294==at 0x80589AF:
Zookeeper_watchers::ConnectionWatcher::~ConnectionWatcher()
(TestWatchers.cc:54)
==31294==by 0x805D062: Zookeeper_watchers::testDefaultSessionWatcher1()
(TestWatchers.cc:438)
==31294==by 0x805608C: CppUnit::TestCallerZookeeper_watchers::runTest()
(TestCaller.h:166)
==31294== Possible data race during write of size 4 at 0x42EB104
==31294==at 0x80A03EE: queue_completion (zookeeper.c:1776)
==31294==by 0x80A3A44: zookeeper_process (zookeeper.c:1598)
==31294==by 0x80AC00B: do_io (mt_adaptor.c:309)
==31294== Thread #29: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80AB9B3: wait_sync_completion (mt_adaptor.c:82)
==31294==by 0x80A1E82: zoo_wget (zookeeper.c:2517)
==31294==by 0x80A1F13: zoo_get (zookeeper.c:2497)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-333) helgrind thread issues identified in mt c client code
[
https://issues.apache.org/jira/browse/ZOOKEEPER-333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12679682#action_12679682
]
Mahadev konar commented on ZOOKEEPER-333:
-
Helgrind: Fatal internal error -- cannot continue.
Helgrind: mk_SHVAL_ShR(tset=8192,lset=1): FAILED
Helgrind: max allowed tset=8191, lset=131071
Helgrind: program has too many thread sets or lock sets to track.
this is the error generated by helgrind when it hangs with the tests and is not
able to run all of the tests.
helgrind thread issues identified in mt c client code
-
Key: ZOOKEEPER-333
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-333
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Patrick Hunt
Assignee: Mahadev konar
Priority: Critical
Fix For: 3.1.1, 3.2.0
Attachments: helgrind_mt.out, helgrind_mt.out.gz
helgrind generated a number of issues, I pulled a bunch of them. Most are
related to the test, some are really issues with the mt zk client code though:
valgrind --tool=helgrind --log-file=helgrind_mt.out ./zktest-mt
==31294== Thread #2: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80ABCF6: notify_thread_ready (mt_adaptor.c:136)
==31294==by 0x80ABE90: do_io (mt_adaptor.c:277)
==31294== Possible data race during write of size 4 at 0x42E9A58
==31294==at 0x8050D83: terminateZookeeperThreads(_zhandle*)
(ZKMocks.cc:518)
==31294==by 0x805543B: DeliverWatchersWrapper::call(_zhandle*, int, int,
char const*, watcher_object_list**) (ZKMocks.cc:261)
==31294==by 0x80520F7: __wrap_deliverWatchers (ZKMocks.cc:220)
==31294==by 0x80A287B: process_completions (zookeeper.c:1393)
==31294==by 0x80ABDAA: do_completion (mt_adaptor.c:332)
==31294== Possible data race during write of size 4 at 0xBEFF5F30
==31294==at 0x80589AF:
Zookeeper_watchers::ConnectionWatcher::~ConnectionWatcher()
(TestWatchers.cc:54)
==31294==by 0x805D062: Zookeeper_watchers::testDefaultSessionWatcher1()
(TestWatchers.cc:438)
==31294==by 0x805608C: CppUnit::TestCallerZookeeper_watchers::runTest()
(TestCaller.h:166)
==31294== Possible data race during write of size 4 at 0x42EB104
==31294==at 0x80A03EE: queue_completion (zookeeper.c:1776)
==31294==by 0x80A3A44: zookeeper_process (zookeeper.c:1598)
==31294==by 0x80AC00B: do_io (mt_adaptor.c:309)
==31294== Thread #29: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80AB9B3: wait_sync_completion (mt_adaptor.c:82)
==31294==by 0x80A1E82: zoo_wget (zookeeper.c:2517)
==31294==by 0x80A1F13: zoo_get (zookeeper.c:2497)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-309) core dump using zoo_get_acl()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar reassigned ZOOKEEPER-309: --- Assignee: Mahadev konar core dump using zoo_get_acl() -- Key: ZOOKEEPER-309 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Assignee: Mahadev konar Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-309.patch The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request. The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer. The attached patch removes this call. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-309) core dump using zoo_get_acl()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar reassigned ZOOKEEPER-309: --- Assignee: (was: Mahadev konar) core dump using zoo_get_acl() -- Key: ZOOKEEPER-309 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-309.patch The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request. The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer. The attached patch removes this call. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-333) helgrind thread issues identified in mt c client code
[
https://issues.apache.org/jira/browse/ZOOKEEPER-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-333:
Attachment: ZOOKEEPER-333.patch
most of the traces in the helgrind output seem harmless to me. This patch has
some minor changes (declaring the head pointers of lists as volatile, which we
keep checking in different threads without locking), which might cause some
problems. the others I think is fine.
helgrind thread issues identified in mt c client code
-
Key: ZOOKEEPER-333
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-333
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Patrick Hunt
Assignee: Mahadev konar
Priority: Critical
Fix For: 3.1.1, 3.2.0
Attachments: helgrind_mt.out, helgrind_mt.out.gz, ZOOKEEPER-333.patch
helgrind generated a number of issues, I pulled a bunch of them. Most are
related to the test, some are really issues with the mt zk client code though:
valgrind --tool=helgrind --log-file=helgrind_mt.out ./zktest-mt
==31294== Thread #2: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80ABCF6: notify_thread_ready (mt_adaptor.c:136)
==31294==by 0x80ABE90: do_io (mt_adaptor.c:277)
==31294== Possible data race during write of size 4 at 0x42E9A58
==31294==at 0x8050D83: terminateZookeeperThreads(_zhandle*)
(ZKMocks.cc:518)
==31294==by 0x805543B: DeliverWatchersWrapper::call(_zhandle*, int, int,
char const*, watcher_object_list**) (ZKMocks.cc:261)
==31294==by 0x80520F7: __wrap_deliverWatchers (ZKMocks.cc:220)
==31294==by 0x80A287B: process_completions (zookeeper.c:1393)
==31294==by 0x80ABDAA: do_completion (mt_adaptor.c:332)
==31294== Possible data race during write of size 4 at 0xBEFF5F30
==31294==at 0x80589AF:
Zookeeper_watchers::ConnectionWatcher::~ConnectionWatcher()
(TestWatchers.cc:54)
==31294==by 0x805D062: Zookeeper_watchers::testDefaultSessionWatcher1()
(TestWatchers.cc:438)
==31294==by 0x805608C: CppUnit::TestCallerZookeeper_watchers::runTest()
(TestCaller.h:166)
==31294== Possible data race during write of size 4 at 0x42EB104
==31294==at 0x80A03EE: queue_completion (zookeeper.c:1776)
==31294==by 0x80A3A44: zookeeper_process (zookeeper.c:1598)
==31294==by 0x80AC00B: do_io (mt_adaptor.c:309)
==31294== Thread #29: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80AB9B3: wait_sync_completion (mt_adaptor.c:82)
==31294==by 0x80A1E82: zoo_wget (zookeeper.c:2517)
==31294==by 0x80A1F13: zoo_get (zookeeper.c:2497)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-333) helgrind thread issues identified in mt c client code
[
https://issues.apache.org/jira/browse/ZOOKEEPER-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-333:
Status: Patch Available (was: Open)
helgrind thread issues identified in mt c client code
-
Key: ZOOKEEPER-333
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-333
Project: Zookeeper
Issue Type: Bug
Components: c client
Reporter: Patrick Hunt
Assignee: Mahadev konar
Priority: Critical
Fix For: 3.1.1, 3.2.0
Attachments: helgrind_mt.out, helgrind_mt.out.gz, ZOOKEEPER-333.patch
helgrind generated a number of issues, I pulled a bunch of them. Most are
related to the test, some are really issues with the mt zk client code though:
valgrind --tool=helgrind --log-file=helgrind_mt.out ./zktest-mt
==31294== Thread #2: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80ABCF6: notify_thread_ready (mt_adaptor.c:136)
==31294==by 0x80ABE90: do_io (mt_adaptor.c:277)
==31294== Possible data race during write of size 4 at 0x42E9A58
==31294==at 0x8050D83: terminateZookeeperThreads(_zhandle*)
(ZKMocks.cc:518)
==31294==by 0x805543B: DeliverWatchersWrapper::call(_zhandle*, int, int,
char const*, watcher_object_list**) (ZKMocks.cc:261)
==31294==by 0x80520F7: __wrap_deliverWatchers (ZKMocks.cc:220)
==31294==by 0x80A287B: process_completions (zookeeper.c:1393)
==31294==by 0x80ABDAA: do_completion (mt_adaptor.c:332)
==31294== Possible data race during write of size 4 at 0xBEFF5F30
==31294==at 0x80589AF:
Zookeeper_watchers::ConnectionWatcher::~ConnectionWatcher()
(TestWatchers.cc:54)
==31294==by 0x805D062: Zookeeper_watchers::testDefaultSessionWatcher1()
(TestWatchers.cc:438)
==31294==by 0x805608C: CppUnit::TestCallerZookeeper_watchers::runTest()
(TestCaller.h:166)
==31294== Possible data race during write of size 4 at 0x42EB104
==31294==at 0x80A03EE: queue_completion (zookeeper.c:1776)
==31294==by 0x80A3A44: zookeeper_process (zookeeper.c:1598)
==31294==by 0x80AC00B: do_io (mt_adaptor.c:309)
==31294== Thread #29: pthread_cond_{timed}wait called with un-held mutex
==31294==at 0x4027F8F: pthread_cond_w...@* (hg_intercepts.c:560)
==31294==by 0x404D881: pthread_cond_w...@glibc_2.0 (in
/lib/tls/i686/cmov/libpthread-2.8.90.so)
==31294==by 0x4028037: pthread_cond_w...@* (hg_intercepts.c:574)
==31294==by 0x809EBB7: pthread_cond_wait (PthreadMocks.cc:54)
==31294==by 0x80AB9B3: wait_sync_completion (mt_adaptor.c:82)
==31294==by 0x80A1E82: zoo_wget (zookeeper.c:2517)
==31294==by 0x80A1F13: zoo_get (zookeeper.c:2497)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
[
https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-78:
---
Attachment: ZOOKEEPER-78.patch
a new patch. I have changed the directory structure in this
the code now is in
{{root}}/src/recipes/lock/src/java/org/apache/zookepeer/recipes/lock/
also the tests are in
{{root}}/src/recipes/lock/test/org/apache/zookeeper/recipes/lock/
the new directory structure allows us to have both the java and c implemention
in the same parent directory strucure.
src/recipes/lock/
also -
- added a new interface Locklistener
- removed runnable to be a locklistener interface whose methods lockAcqured and
lockReleased are called on a lock acquired and relase of a lock
- refactored some code
- deleted not required public methods.
- added build files for the recipes directory
- changed the tests to work with new api's
i am implementing the recipes in c. Will have an updated patch up soon.
comments are welcome.
added a high level protocol/feature - for easy Leader Election or exclusive
Write Lock creation
---
Key: ZOOKEEPER-78
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78
Project: Zookeeper
Issue Type: New Feature
Components: java client
Affects Versions: 3.0.0
Reporter: james strachan
Assignee: james strachan
Fix For: 3.2.0
Attachments: patch_with_including_Benjamin's_fix.patch,
using_zookeeper_facade.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch,
ZOOKEEPER-78.patch
Here's a patch which adds a little WriteLock helper class for performing
leader elections or creating exclusive locks in some directory znode. Note
its an early cut; am sure we can improve it over time. The aim is to avoid
folks having to use the low level ZK stuff but provide a simpler high level
abstraction.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12680933#action_12680933 ] Mahadev konar commented on ZOOKEEPER-78: dont know.. the jira says just talks abt the recipe, so is adequate for both java and c :). .. I would like to have both in one jira so that everyone who wants to contribute to such zookeeeper recipes is encouraged to have both the java and c implementation, but I am open to creating a new jira for c. added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation --- Key: ZOOKEEPER-78 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.0.0 Reporter: james strachan Assignee: james strachan Fix For: 3.2.0 Attachments: patch_with_including_Benjamin's_fix.patch, using_zookeeper_facade.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch Here's a patch which adds a little WriteLock helper class for performing leader elections or creating exclusive locks in some directory znode. Note its an early cut; am sure we can improve it over time. The aim is to avoid folks having to use the low level ZK stuff but provide a simpler high level abstraction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-309) core dump using zoo_get_acl()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar reassigned ZOOKEEPER-309: --- Assignee: Mahadev konar core dump using zoo_get_acl() -- Key: ZOOKEEPER-309 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Assignee: Mahadev konar Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-309.patch, ZOOKEEPER-309.patch The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request. The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer. The attached patch removes this call. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-309) core dump using zoo_get_acl()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-309: Status: Patch Available (was: Open) core dump using zoo_get_acl() -- Key: ZOOKEEPER-309 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.1.0, 3.0.1, 3.0.0 Reporter: Chris Darroch Assignee: Mahadev konar Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-309.patch, ZOOKEEPER-309.patch The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request. The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer. The attached patch removes this call. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-309) core dump using zoo_get_acl()
[ https://issues.apache.org/jira/browse/ZOOKEEPER-309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12681110#action_12681110 ] Mahadev konar commented on ZOOKEEPER-309: - also forgot to mention that the tests fail with segmenetation fault without chris's patch and pass with the patch.. core dump using zoo_get_acl() -- Key: ZOOKEEPER-309 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-309 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Chris Darroch Assignee: Mahadev konar Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-309.patch, ZOOKEEPER-309.patch The zookeeper_process() function incorrectly calls the c.acl_result member of the completion_list_t structure when handling the completion from a synchronous zoo_get_acl() request. The c.acl_result member is set to SYNCHRONOUS_MARKER, which is a null pointer. The attached patch removes this call. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-340) binaryinputarchive throws out runtimeexceptions for unreasonable length datastructures.
binaryinputarchive throws out runtimeexceptions for unreasonable length datastructures. --- Key: ZOOKEEPER-340 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-340 Project: Zookeeper Issue Type: Bug Reporter: Mahadev konar binaryinputarchive throws out runtimeexceptions for unreasonable length datastructures. We should change that to be IOExceptions so that we can handle partial writes to logs,, machine powerdown better. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-341) regression in QuorumPeerMain, tickTime from config is lost, cannot start quorum
[ https://issues.apache.org/jira/browse/ZOOKEEPER-341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar resolved ZOOKEEPER-341. - Resolution: Fixed Assignee: Patrick Hunt Hadoop Flags: [Reviewed] +1 ... I just committed this. thanks pat. regression in QuorumPeerMain, tickTime from config is lost, cannot start quorum --- Key: ZOOKEEPER-341 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-341 Project: Zookeeper Issue Type: Bug Components: quorum, server Reporter: Patrick Hunt Assignee: Patrick Hunt Priority: Blocker Fix For: 3.1.1, 3.2.0 Attachments: ZOOKEEPER-341.patch ZOOKEEPER 330/336 caused a regression in QuorumPeerMain -- cannot reliably start a cluster due to missing tickTime. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-344) doIO in NioServerCnxn: Exception causing close of session : cause is read error
[
https://issues.apache.org/jira/browse/ZOOKEEPER-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12683158#action_12683158
]
Mahadev konar edited comment on ZOOKEEPER-344 at 3/18/09 2:16 PM:
--
{noformat}
ERROR [main-EventThread]
com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400)
2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change.
New state: Expired :
zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1160/locknode
ERROR [main-EventThread]
com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400)
2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change.
New state: Expired :
zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1356/locknode
{noformat}
can you post corresponding session id's with these ?
and also the logs related to their session closing with the timestamps.
was (Author: mahadev):
{noformat}
ERROR [main-EventThread]
com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400)
2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change.
New state: Expired :
zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1160/locknode
ERROR [main-EventThread]
com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400)
2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change.
New state: Expired :
zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1356/locknode
{noformat}
can you post corresponding session id's with these?
doIO in NioServerCnxn: Exception causing close of session : cause is read
error
-
Key: ZOOKEEPER-344
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-344
Project: Zookeeper
Issue Type: Bug
Components: java client
Affects Versions: 3.1.0
Environment: jdk1.6.0_07
Linux blade2 2.6.27.7-134.fc10.x86_64 #1 SMP Mon Dec 1 22:21:35 EST 2008
x86_64 x86_64 x86_64 GNU/Linux
Reporter: bryan thompson
I have been having a problem with zookeeper 3.0.1 and now with 3.1.0 where I
see a lot of expired sessions. I am using a 16 node cluster which is all on
the same local network. There is a single zookeeper instance (these are
benchmarking runs).
The problem appears to be correlated with either run time or system load.\
Personally I think that it is system load because I have session session
expired events under a Windows platform running zookeeper and the application
(i.e., everthing is local) when the application load suddenly spikes. To me
this suggests that the client is not able to renew (ping) the zookeeper
service in a timely manner and is expired. But the log messages below with
the read error suggest that maybe there is something else going on?
Zookeeper Configuration
#Wed Mar 18 12:41:05 GMT-05:00 2009
clientPort=2181
dataDir=/var/bigdata/benchmark/zookeeper/1
syncLimit=2
dataLogDir=/var/bigdata/benchmark/zookeeper/1
tickTime=2000
Some representative log messages are below.
Client side messages (from our app)
ERROR [main-EventThread]
com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400)
2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change.
New state: Expired :
zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1160/locknode
ERROR [main-EventThread]
com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400)
2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change.
New state: Expired :
zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1356/locknode
Server side messages:
WARN [NIOServerCxn.Factory:2181]
org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:417)
2009-03-18 13:06:57,252 - Exception causing close of session
0x1201aac14300022 due to java.io.IOException: Read error
WARN [NIOServerCxn.Factory:2181]
org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:417)
2009-03-18 13:06:58,198 - Exception causing close of session
0x1201aac143f due to java.io.IOException: Read error
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-344) doIO in NioServerCnxn: Exception causing close of session : cause is read error
[
https://issues.apache.org/jira/browse/ZOOKEEPER-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12683158#action_12683158
]
Mahadev konar edited comment on ZOOKEEPER-344 at 3/18/09 2:17 PM:
--
{noformat}
ERROR [main-EventThread]
com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400)
2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change.
New state: Expired :
zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1160/locknode
ERROR [main-EventThread]
com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400)
2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change.
New state: Expired :
zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1356/locknode
{noformat}
can you post corresponding session id's with these ?
and also the logs related to their session closing with the timestamps (on the
server side).
was (Author: mahadev):
{noformat}
ERROR [main-EventThread]
com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400)
2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change.
New state: Expired :
zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1160/locknode
ERROR [main-EventThread]
com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400)
2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change.
New state: Expired :
zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1356/locknode
{noformat}
can you post corresponding session id's with these ?
and also the logs related to their session closing with the timestamps.
doIO in NioServerCnxn: Exception causing close of session : cause is read
error
-
Key: ZOOKEEPER-344
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-344
Project: Zookeeper
Issue Type: Bug
Components: java client
Affects Versions: 3.1.0
Environment: jdk1.6.0_07
Linux blade2 2.6.27.7-134.fc10.x86_64 #1 SMP Mon Dec 1 22:21:35 EST 2008
x86_64 x86_64 x86_64 GNU/Linux
Reporter: bryan thompson
I have been having a problem with zookeeper 3.0.1 and now with 3.1.0 where I
see a lot of expired sessions. I am using a 16 node cluster which is all on
the same local network. There is a single zookeeper instance (these are
benchmarking runs).
The problem appears to be correlated with either run time or system load.\
Personally I think that it is system load because I have session session
expired events under a Windows platform running zookeeper and the application
(i.e., everthing is local) when the application load suddenly spikes. To me
this suggests that the client is not able to renew (ping) the zookeeper
service in a timely manner and is expired. But the log messages below with
the read error suggest that maybe there is something else going on?
Zookeeper Configuration
#Wed Mar 18 12:41:05 GMT-05:00 2009
clientPort=2181
dataDir=/var/bigdata/benchmark/zookeeper/1
syncLimit=2
dataLogDir=/var/bigdata/benchmark/zookeeper/1
tickTime=2000
Some representative log messages are below.
Client side messages (from our app)
ERROR [main-EventThread]
com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400)
2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change.
New state: Expired :
zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1160/locknode
ERROR [main-EventThread]
com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400)
2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change.
New state: Expired :
zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1356/locknode
Server side messages:
WARN [NIOServerCxn.Factory:2181]
org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:417)
2009-03-18 13:06:57,252 - Exception causing close of session
0x1201aac14300022 due to java.io.IOException: Read error
WARN [NIOServerCxn.Factory:2181]
org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:417)
2009-03-18 13:06:58,198 - Exception causing close of session
0x1201aac143f due to java.io.IOException: Read error
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-346) remove the kill command fro mthe client port.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-346: Fix Version/s: 3.2.0 remove the kill command fro mthe client port. - Key: ZOOKEEPER-346 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-346 Project: Zookeeper Issue Type: Bug Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Mahadev konar Fix For: 3.2.0 we should just remove the kill command from the client port. Its a security risk (though we do not have nay security right now) to be able to kill the server from a tcp port without any authentication... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-346) remove the kill command fro mthe client port.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-346: Description: we should just remove the kill command from the client port. Its a security risk (though we do not have much security right now) to be able to kill the server from a tcp port without any authentication... (was: we should just remove the kill command from the client port. Its a security risk (though we do not have nay security right now) to be able to kill the server from a tcp port without any authentication... ) remove the kill command fro mthe client port. - Key: ZOOKEEPER-346 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-346 Project: Zookeeper Issue Type: Bug Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Mahadev konar Fix For: 3.2.0 we should just remove the kill command from the client port. Its a security risk (though we do not have much security right now) to be able to kill the server from a tcp port without any authentication... -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-60) Get cppunit tests running as part of Hudson CI
[ https://issues.apache.org/jira/browse/ZOOKEEPER-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12689000#action_12689000 ] Mahadev konar commented on ZOOKEEPER-60: does make run-check in the c directory still working with these changes? Get cppunit tests running as part of Hudson CI -- Key: ZOOKEEPER-60 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-60 Project: Zookeeper Issue Type: Improvement Components: build Reporter: Patrick Hunt Assignee: Giridharan Kesavan Attachments: ZK-60.patch Investigate if it is possible to run cppunit tests as part of Hudson. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-348) Creating node with path ending in / with sequence flag set
[ https://issues.apache.org/jira/browse/ZOOKEEPER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12689741#action_12689741 ] Mahadev konar commented on ZOOKEEPER-348: - it just came to my mind that we put validating path at the client side in ZOOKEEPER-16. can you try using 3.1* versions? you should get errors in both the cases in 3.1* versions. Creating node with path ending in / with sequence flag set Key: ZOOKEEPER-348 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-348 Project: Zookeeper Issue Type: Bug Components: c client Affects Versions: 3.1.1 Reporter: Jeff Terrace Priority: Minor Fix For: 3.2.0 In 3.0.1, I could create a sequence node like this: /nodes/001 like this: string path = /nodes/; string value = data; int rc = zoo_acreate(zh, path.c_str(), value.c_str(), value.length(), ZOO_OPEN_ACL_UNSAFE, ZOO_EPHEMERAL | ZOO_SEQUENCE, czoo_created, where); In 3.1.1, this fails with error -8 (ZBADARGUMENTS). Adding something after the / in the path makes the code work fine: string path = /nodes/n; I assume something is checking if the path ends in / but not checking the sequence flag. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-351) to run checkstyle
[ https://issues.apache.org/jira/browse/ZOOKEEPER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-351: Affects Version/s: 3.0.0 3.0.1 3.1.0 to run checkstyle - Key: ZOOKEEPER-351 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-351 Project: Zookeeper Issue Type: Sub-task Components: build Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: ZK-351.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-351) to run checkstyle
[ https://issues.apache.org/jira/browse/ZOOKEEPER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-351: Resolution: Fixed Fix Version/s: 3.2.0 Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) +1... I just committed this. thanks giri. to run checkstyle - Key: ZOOKEEPER-351 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-351 Project: Zookeeper Issue Type: Sub-task Components: build Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: ZK-351.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-350) to run rats for releaseaudit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-350: Resolution: Fixed Fix Version/s: 3.2.0 Release Note: run rats for release audits. Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) +1 for the patch... i just committed this. to run rats for releaseaudit - Key: ZOOKEEPER-350 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-350 Project: Zookeeper Issue Type: Sub-task Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: ZK-350.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-350) to run rats for releaseaudit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-350: Affects Version/s: 3.0.0 3.0.1 3.1.0 to run rats for releaseaudit - Key: ZOOKEEPER-350 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-350 Project: Zookeeper Issue Type: Sub-task Affects Versions: 3.0.0, 3.0.1, 3.1.0 Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: ZK-350.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-350) to run rats for releaseaudit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-350: Affects Version/s: 3.1.1 to run rats for releaseaudit - Key: ZOOKEEPER-350 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-350 Project: Zookeeper Issue Type: Sub-task Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: ZK-350.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-352) to add standard ant targets required by test-patch.sh script
[ https://issues.apache.org/jira/browse/ZOOKEEPER-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-352: Resolution: Fixed Fix Version/s: 3.2.0 Release Note: add standard test targets required by test-patch. Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) +1 for the patch. I just committed this. thanks giri. to add standard ant targets required by test-patch.sh script Key: ZOOKEEPER-352 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-352 Project: Zookeeper Issue Type: Sub-task Components: build Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: ZK-352.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-352) to add standard ant targets required by test-patch.sh script
[ https://issues.apache.org/jira/browse/ZOOKEEPER-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-352: Affects Version/s: 3.1.1 3.0.0 3.0.1 3.1.0 to add standard ant targets required by test-patch.sh script Key: ZOOKEEPER-352 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-352 Project: Zookeeper Issue Type: Sub-task Components: build Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: ZK-352.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-353) javadoc warnings needs to be fixed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-353:
Component/s: build
javadoc warnings needs to be fixed
---
Key: ZOOKEEPER-353
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-353
Project: Zookeeper
Issue Type: Sub-task
Components: build
Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
Reporter: Giridharan Kesavan
Assignee: Giridharan Kesavan
Fix For: 3.2.0
Attachments: ZK-353.patch, ZK-353.patch
[javadoc]
/.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:46:
cannot find symbol
[javadoc] symbol : class OutputArchive
[javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
[javadoc] public void serialize(OutputArchive a_, String tag) throws
java.io.IOException {
[javadoc] ^
[javadoc]
/.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:63:
cannot find symbol
[javadoc] symbol : class InputArchive
[javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
[javadoc] public void deserialize(InputArchive a_, String tag) throws
java.io.IOException {
[javadoc] ^
[javadoc] Building index for all the packages and classes...
[javadoc] Building index for all classes...
[javadoc] Generating /.../SOMETHING/trunk/build/docs/api/stylesheet.css...
[javadoc] 4 errors
[javadoc] 124 warnings
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-353) javadoc warnings needs to be fixed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-353:
Resolution: Fixed
Fix Version/s: 3.2.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1 to the patch. i just committed this (thanks giri).
javadoc warnings needs to be fixed
---
Key: ZOOKEEPER-353
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-353
Project: Zookeeper
Issue Type: Sub-task
Components: build
Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
Reporter: Giridharan Kesavan
Assignee: Giridharan Kesavan
Fix For: 3.2.0
Attachments: ZK-353.patch, ZK-353.patch
[javadoc]
/.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:46:
cannot find symbol
[javadoc] symbol : class OutputArchive
[javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
[javadoc] public void serialize(OutputArchive a_, String tag) throws
java.io.IOException {
[javadoc] ^
[javadoc]
/.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:63:
cannot find symbol
[javadoc] symbol : class InputArchive
[javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
[javadoc] public void deserialize(InputArchive a_, String tag) throws
java.io.IOException {
[javadoc] ^
[javadoc] Building index for all the packages and classes...
[javadoc] Building index for all classes...
[javadoc] Generating /.../SOMETHING/trunk/build/docs/api/stylesheet.css...
[javadoc] 4 errors
[javadoc] 124 warnings
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-353) javadoc warnings needs to be fixed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-353:
Affects Version/s: 3.1.1
3.0.0
3.0.1
3.1.0
javadoc warnings needs to be fixed
---
Key: ZOOKEEPER-353
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-353
Project: Zookeeper
Issue Type: Sub-task
Components: build
Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1
Reporter: Giridharan Kesavan
Assignee: Giridharan Kesavan
Fix For: 3.2.0
Attachments: ZK-353.patch, ZK-353.patch
[javadoc]
/.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:46:
cannot find symbol
[javadoc] symbol : class OutputArchive
[javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
[javadoc] public void serialize(OutputArchive a_, String tag) throws
java.io.IOException {
[javadoc] ^
[javadoc]
/.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:63:
cannot find symbol
[javadoc] symbol : class InputArchive
[javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
[javadoc] public void deserialize(InputArchive a_, String tag) throws
java.io.IOException {
[javadoc] ^
[javadoc] Building index for all the packages and classes...
[javadoc] Building index for all classes...
[javadoc] Generating /.../SOMETHING/trunk/build/docs/api/stylesheet.css...
[javadoc] 4 errors
[javadoc] 124 warnings
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-350) to run rats for releaseaudit
[ https://issues.apache.org/jira/browse/ZOOKEEPER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-350: Component/s: build to run rats for releaseaudit - Key: ZOOKEEPER-350 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-350 Project: Zookeeper Issue Type: Sub-task Components: build Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: ZK-350.patch -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-353) javadoc warnings needs to be fixed
[
https://issues.apache.org/jira/browse/ZOOKEEPER-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mahadev konar updated ZOOKEEPER-353:
Attachment: ZK-353.patch
the patch did not apply cleanly. it had some stubs that had been already
committed. an updated patch.
javadoc warnings needs to be fixed
---
Key: ZOOKEEPER-353
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-353
Project: Zookeeper
Issue Type: Sub-task
Reporter: Giridharan Kesavan
Assignee: Giridharan Kesavan
Attachments: ZK-353.patch, ZK-353.patch
[javadoc]
/.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:46:
cannot find symbol
[javadoc] symbol : class OutputArchive
[javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
[javadoc] public void serialize(OutputArchive a_, String tag) throws
java.io.IOException {
[javadoc] ^
[javadoc]
/.../SOMETHING/trunk/src/java/generated/org/apache/zookeeper/server/quorum/QuorumPacket.java:63:
cannot find symbol
[javadoc] symbol : class InputArchive
[javadoc] location: class org.apache.zookeeper.server.quorum.QuorumPacket
[javadoc] public void deserialize(InputArchive a_, String tag) throws
java.io.IOException {
[javadoc] ^
[javadoc] Building index for all the packages and classes...
[javadoc] Building index for all classes...
[javadoc] Generating /.../SOMETHING/trunk/build/docs/api/stylesheet.css...
[javadoc] 4 errors
[javadoc] 124 warnings
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-354) to fix javadoc warning in the source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-354: Component/s: documentation Description: [javadoc] trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see:illegal character: 60 in #create(String, byte[], ListACL, CreateMode) [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see:illegal character: 62 in #create(String, byte[], ListACL, CreateMode) [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see: can't find create(String, byte[], ListACL, CreateMode) in org.apache.zookeeper.ZooKeeper [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:499: warning - @param argument flags is not a parameter name. [javadoc] Building index for all the packages and classes... [javadoc] Building index for all classes... [javadoc] Generating trunk/build/docs/api/stylesheet.css... [javadoc] 24 warnings was: [javadoc] trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see:illegal character: 60 in #create(String, byte[], ListACL, CreateMode) [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see:illegal character: 62 in #create(String, byte[], ListACL, CreateMode) [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see: can't find create(String, byte[], ListACL, CreateMode) in org.apache.zookeeper.ZooKeeper [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:499: warning - @param argument flags is not a parameter name. [javadoc] Building index for all the packages and classes... [javadoc] Building index for all classes... [javadoc] Generating trunk/build/docs/api/stylesheet.css... [javadoc] 24 warnings Affects Version/s: 3.1.1 3.0.0 3.0.1 3.1.0 Fix Version/s: 3.2.0 to fix javadoc warning in the source files -- Key: ZOOKEEPER-354 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-354 Project: Zookeeper Issue Type: Sub-task Components: documentation Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Giridharan Kesavan Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-354.patch [javadoc] trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see:illegal character: 60 in #create(String, byte[], ListACL, CreateMode) [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see:illegal character: 62 in #create(String, byte[], ListACL, CreateMode) [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see: can't find create(String, byte[], ListACL, CreateMode) in org.apache.zookeeper.ZooKeeper [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:499: warning - @param argument flags is not a parameter name. [javadoc] Building index for all the packages and classes... [javadoc] Building index for all classes... [javadoc] Generating trunk/build/docs/api/stylesheet.css... [javadoc] 24 warnings -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-354) to fix javadoc warning in the source files
[ https://issues.apache.org/jira/browse/ZOOKEEPER-354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-354: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) I just committed this. to fix javadoc warning in the source files -- Key: ZOOKEEPER-354 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-354 Project: Zookeeper Issue Type: Sub-task Components: documentation Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Giridharan Kesavan Assignee: Mahadev konar Fix For: 3.2.0 Attachments: ZOOKEEPER-354.patch [javadoc] trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see:illegal character: 60 in #create(String, byte[], ListACL, CreateMode) [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see:illegal character: 62 in #create(String, byte[], ListACL, CreateMode) [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:597: warning - Tag @see: can't find create(String, byte[], ListACL, CreateMode) in org.apache.zookeeper.ZooKeeper [javadoc]trunk/src/java/main/org/apache/zookeeper/ZooKeeper.java:499: warning - @param argument flags is not a parameter name. [javadoc] Building index for all the packages and classes... [javadoc] Building index for all classes... [javadoc] Generating trunk/build/docs/api/stylesheet.css... [javadoc] 24 warnings -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ZOOKEEPER-349) to automate patch testing
[ https://issues.apache.org/jira/browse/ZOOKEEPER-349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar resolved ZOOKEEPER-349. - Resolution: Fixed Fix Version/s: 3.2.0 Hadoop Flags: [Reviewed] +1, i just committed this. to automate patch testing -- Key: ZOOKEEPER-349 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-349 Project: Zookeeper Issue Type: Improvement Components: build Reporter: Giridharan Kesavan Assignee: Giridharan Kesavan Fix For: 3.2.0 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-78: --- Attachment: ZOOKEEPER-78.patch this patch has the c library in it as well. Now I think of it, I probably should have done it in a seperate jira with subtasks as java and c libraries. - added the c library with auto * files to create teh library - added cpp unit testing for the c library - similar to java interface, the c interface also allows a callback method to be called in case of lock being avquired and released. - i will be cleaning up the patch (with some more docs and rmeocing unneccasry printf's and unused code). comments are welcome... added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation --- Key: ZOOKEEPER-78 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.0.0 Reporter: james strachan Assignee: james strachan Fix For: 3.2.0 Attachments: patch_with_including_Benjamin's_fix.patch, using_zookeeper_facade.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch Here's a patch which adds a little WriteLock helper class for performing leader elections or creating exclusive locks in some directory znode. Note its an early cut; am sure we can improve it over time. The aim is to avoid folks having to use the low level ZK stuff but provide a simpler high level abstraction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-78: --- Attachment: (was: ZOOKEEPER-78.patch) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation --- Key: ZOOKEEPER-78 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.0.0 Reporter: james strachan Assignee: james strachan Fix For: 3.2.0 Attachments: patch_with_including_Benjamin's_fix.patch, using_zookeeper_facade.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch Here's a patch which adds a little WriteLock helper class for performing leader elections or creating exclusive locks in some directory znode. Note its an early cut; am sure we can improve it over time. The aim is to avoid folks having to use the low level ZK stuff but provide a simpler high level abstraction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12694348#action_12694348 ] Mahadev konar commented on ZOOKEEPER-78: make sure that you download the patch adn then view it. I tried opening up the patch in the browser and it fails. It thinks that the file is xml (not sure why.. ) and tried opening it as an xml file... added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation --- Key: ZOOKEEPER-78 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.0.0 Reporter: james strachan Assignee: james strachan Fix For: 3.2.0 Attachments: patch_with_including_Benjamin's_fix.patch, using_zookeeper_facade.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch Here's a patch which adds a little WriteLock helper class for performing leader elections or creating exclusive locks in some directory znode. Note its an early cut; am sure we can improve it over time. The aim is to avoid folks having to use the low level ZK stuff but provide a simpler high level abstraction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-357) ZooKeeper cannot actually take care of a Zoo
[ https://issues.apache.org/jira/browse/ZOOKEEPER-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12694401#action_12694401 ] Mahadev konar commented on ZOOKEEPER-357: - ben, is this is an april fool's joke? ZooKeeper cannot actually take care of a Zoo Key: ZOOKEEPER-357 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-357 Project: Zookeeper Issue Type: Bug Reporter: Benjamin Reed Priority: Critical Last week I setup an unattended ZooKeeper cluster that I expected to be able to take care of things while I was on vacation. I used 7 dedicated servers with two disks. I had done extensive burn in testing of the servers, so I fully expected the system to work problem free for the entire week. Indeed, when I returned yesterday none of the 7 servers had any hardware or software problem the entire time nor had there been any network problems. On the other hand the Zoo was in complete chaos. Even though there were no errors in the ZooKeeper log most of the animals were near starvation, except for the lions who had gotten loose and eaten some of the pigs. I'll not even go into the stench from the dirty cages! Either the documentation needs to more clearly explain how to configure the server properly in the Zoo environment, or it should clearly state that ZooKeeper cannot take care of the Zoo out of the box! -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-344) doIO in NioServerCnxn: Exception causing close of session : cause is read error
[ https://issues.apache.org/jira/browse/ZOOKEEPER-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12694660#action_12694660 ] Mahadev konar commented on ZOOKEEPER-344: - for the first trace, closed != expired is true. it seems like the client reconnected to the server and didnt expire in the first case. in the second case it did expire. You are on a windows machine right? and also its a single server ensemble? I dont usually use a windows box but I did notice once that creating a log file with size of 64MB initially took a lot of time (5-15 seconds and was repeatable) on my windows box with no other load . Just to give you background, zookeeper takes snaphots and has transaction logs. The transaction logs are created with an initialize size of 64MB so that we do not have to update the size of the file repeatedly. This operation did take a lot of time on my windows machine and this did cause huge latencies in my zookeeper clients and lots of timeouts and session expired. Ill take another look at your logs to see if i can find something that might explain the frequent session timeouts. doIO in NioServerCnxn: Exception causing close of session : cause is read error - Key: ZOOKEEPER-344 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-344 Project: Zookeeper Issue Type: Bug Components: java client, server Affects Versions: 3.1.0 Environment: jdk1.6.0_07 Linux blade2 2.6.27.7-134.fc10.x86_64 #1 SMP Mon Dec 1 22:21:35 EST 2008 x86_64 x86_64 x86_64 GNU/Linux Reporter: bryan thompson Fix For: 3.2.0 I have been having a problem with zookeeper 3.0.1 and now with 3.1.0 where I see a lot of expired sessions. I am using a 16 node cluster which is all on the same local network. There is a single zookeeper instance (these are benchmarking runs). The problem appears to be correlated with either run time or system load.\ Personally I think that it is system load because I have session session expired events under a Windows platform running zookeeper and the application (i.e., everthing is local) when the application load suddenly spikes. To me this suggests that the client is not able to renew (ping) the zookeeper service in a timely manner and is expired. But the log messages below with the read error suggest that maybe there is something else going on? Zookeeper Configuration #Wed Mar 18 12:41:05 GMT-05:00 2009 clientPort=2181 dataDir=/var/bigdata/benchmark/zookeeper/1 syncLimit=2 dataLogDir=/var/bigdata/benchmark/zookeeper/1 tickTime=2000 Some representative log messages are below. Client side messages (from our app) ERROR [main-EventThread] com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400) 2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change. New state: Expired : zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1160/locknode ERROR [main-EventThread] com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400) 2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change. New state: Expired : zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1356/locknode Server side messages: WARN [NIOServerCxn.Factory:2181] org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:417) 2009-03-18 13:06:57,252 - Exception causing close of session 0x1201aac14300022 due to java.io.IOException: Read error WARN [NIOServerCxn.Factory:2181] org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:417) 2009-03-18 13:06:58,198 - Exception causing close of session 0x1201aac143f due to java.io.IOException: Read error -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-343) add tests that specifically verify the zkmain and qpmain classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-343: Status: Patch Available (was: Open) making it run through hudson. add tests that specifically verify the zkmain and qpmain classes Key: ZOOKEEPER-343 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-343 Project: Zookeeper Issue Type: Improvement Components: tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.2.0 Attachments: ZOOKEEPER-343.patch We are missing tests for these two main() routines. Add tests that verify standalone and quorum (2 servers is probably enough) by starting and connecting a client. Use on-disk configuration files to configure these. (ie verify starting with actual config files) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-305) Replace timers with semaphores in FLENewEpochTest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-305: Status: Open (was: Patch Available) Replace timers with semaphores in FLENewEpochTest - Key: ZOOKEEPER-305 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-305 Project: Zookeeper Issue Type: Improvement Components: tests Affects Versions: 3.1.0 Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Priority: Minor Fix For: 3.2.0 Attachments: ZOOKEEPER-305.patch, ZOOKEEPER-305.patch This patch replaces timers in the test with semaphores. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-305) Replace timers with semaphores in FLENewEpochTest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-305: Status: Patch Available (was: Open) making it run through hudson. Replace timers with semaphores in FLENewEpochTest - Key: ZOOKEEPER-305 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-305 Project: Zookeeper Issue Type: Improvement Components: tests Affects Versions: 3.1.0 Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Priority: Minor Fix For: 3.2.0 Attachments: ZOOKEEPER-305.patch, ZOOKEEPER-305.patch This patch replaces timers in the test with semaphores. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-78) added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation
[ https://issues.apache.org/jira/browse/ZOOKEEPER-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12694841#action_12694841 ] Mahadev konar commented on ZOOKEEPER-78: thanks for your comments chris. You are right, the c version needs to do a better job on handling error cases. I still need to clean it up for that. Will update the patch. I probably think i spent most of the time fighting/learning auto*/libtools rather than coding the c api :) ... added a high level protocol/feature - for easy Leader Election or exclusive Write Lock creation --- Key: ZOOKEEPER-78 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-78 Project: Zookeeper Issue Type: New Feature Components: java client Affects Versions: 3.0.0 Reporter: james strachan Assignee: james strachan Fix For: 3.2.0 Attachments: patch_with_including_Benjamin's_fix.patch, using_zookeeper_facade.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch, ZOOKEEPER-78.patch Here's a patch which adds a little WriteLock helper class for performing leader elections or creating exclusive locks in some directory znode. Note its an early cut; am sure we can improve it over time. The aim is to avoid folks having to use the low level ZK stuff but provide a simpler high level abstraction. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-60) Get cppunit tests running as part of Hudson CI
[ https://issues.apache.org/jira/browse/ZOOKEEPER-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-60: --- Affects Version/s: 3.0.0 3.0.1 3.1.0 3.1.1 Fix Version/s: 3.2.0 Get cppunit tests running as part of Hudson CI -- Key: ZOOKEEPER-60 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-60 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Patrick Hunt Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: ZK-60.patch, ZK-60.patch, ZK-60.patch Investigate if it is possible to run cppunit tests as part of Hudson. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-60) Get cppunit tests running as part of Hudson CI
[ https://issues.apache.org/jira/browse/ZOOKEEPER-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-60: --- Attachment: ZOOKEEPER-60.patch the last patch had a nbug. it does nto work with make run-check in the c directory. I changed the tests/zkserver.sh sothat it now works with make run-check. Get cppunit tests running as part of Hudson CI -- Key: ZOOKEEPER-60 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-60 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Patrick Hunt Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: ZK-60.patch, ZK-60.patch, ZK-60.patch, ZOOKEEPER-60.patch Investigate if it is possible to run cppunit tests as part of Hudson. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-60) Get cppunit tests running as part of Hudson CI
[ https://issues.apache.org/jira/browse/ZOOKEEPER-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12694861#action_12694861 ] Mahadev konar commented on ZOOKEEPER-60: also the command to run cpp tests via ant is ant create-cppunit-configure test-cppunit -Dcppunit=true and not create-configure-cppunit as mentioned above. Get cppunit tests running as part of Hudson CI -- Key: ZOOKEEPER-60 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-60 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Patrick Hunt Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: ZK-60.patch, ZK-60.patch, ZK-60.patch, ZOOKEEPER-60.patch Investigate if it is possible to run cppunit tests as part of Hudson. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-361) integrate cppunit testing as part of hudson patch process.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-361: Component/s: build integrate cppunit testing as part of hudson patch process. -- Key: ZOOKEEPER-361 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-361 Project: Zookeeper Issue Type: New Feature Components: build Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Mahadev konar Assignee: Giridharan Kesavan we need to test the c tests as part of our hudson patch testing process. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-60) Get cppunit tests running as part of Hudson CI
[ https://issues.apache.org/jira/browse/ZOOKEEPER-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12695142#action_12695142 ] Mahadev konar commented on ZOOKEEPER-60: I opened another jira for intergrating this patch into the hudson patch testing for all the patches ZOOKEEPER-361. Get cppunit tests running as part of Hudson CI -- Key: ZOOKEEPER-60 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-60 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Patrick Hunt Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: ZK-60.patch, ZK-60.patch, ZK-60.patch, ZOOKEEPER-60.patch Investigate if it is possible to run cppunit tests as part of Hudson. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-60) Get cppunit tests running as part of Hudson CI
[ https://issues.apache.org/jira/browse/ZOOKEEPER-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-60: --- Resolution: Fixed Release Note: Get cppunit tests running from ant. Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) +1 for the patch ... I just committed this. thanks giri. Get cppunit tests running as part of Hudson CI -- Key: ZOOKEEPER-60 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-60 Project: Zookeeper Issue Type: Improvement Components: build Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Patrick Hunt Assignee: Giridharan Kesavan Fix For: 3.2.0 Attachments: ZK-60.patch, ZK-60.patch, ZK-60.patch, ZOOKEEPER-60.patch Investigate if it is possible to run cppunit tests as part of Hudson. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-344) doIO in NioServerCnxn: Exception causing close of session : cause is read error
[ https://issues.apache.org/jira/browse/ZOOKEEPER-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12695148#action_12695148 ] Mahadev konar commented on ZOOKEEPER-344: - brayn, the one thing you can do is run with tracefile option in the config. Please take a look at http://hadoop.apache.org/zookeeper/docs/r3.1.1/zookeeperAdmin.html to see how to set up a tracefile. The tracefile has logs of all the transactions that go though the server and all the components of the server and helps in debugging problems such as these, where you can point out which transaction got delayed and at what time and sometimes can point out the reason why... doIO in NioServerCnxn: Exception causing close of session : cause is read error - Key: ZOOKEEPER-344 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-344 Project: Zookeeper Issue Type: Bug Components: java client, server Affects Versions: 3.1.0 Environment: jdk1.6.0_07 Linux blade2 2.6.27.7-134.fc10.x86_64 #1 SMP Mon Dec 1 22:21:35 EST 2008 x86_64 x86_64 x86_64 GNU/Linux Reporter: bryan thompson Fix For: 3.2.0 I have been having a problem with zookeeper 3.0.1 and now with 3.1.0 where I see a lot of expired sessions. I am using a 16 node cluster which is all on the same local network. There is a single zookeeper instance (these are benchmarking runs). The problem appears to be correlated with either run time or system load.\ Personally I think that it is system load because I have session session expired events under a Windows platform running zookeeper and the application (i.e., everthing is local) when the application load suddenly spikes. To me this suggests that the client is not able to renew (ping) the zookeeper service in a timely manner and is expired. But the log messages below with the read error suggest that maybe there is something else going on? Zookeeper Configuration #Wed Mar 18 12:41:05 GMT-05:00 2009 clientPort=2181 dataDir=/var/bigdata/benchmark/zookeeper/1 syncLimit=2 dataLogDir=/var/bigdata/benchmark/zookeeper/1 tickTime=2000 Some representative log messages are below. Client side messages (from our app) ERROR [main-EventThread] com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400) 2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change. New state: Expired : zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1160/locknode ERROR [main-EventThread] com.bigdata.zookeeper.ZLockImpl$ZLockWatcher.process(ZLockImpl.java:400) 2009-03-18 13:35:40,335 - Session expired: WatchedEvent: Server state change. New state: Expired : zpath=/benchmark/jobs/com.bigdata.service.jini.benchmark.ThroughputMaster/test_1/client1356/locknode Server side messages: WARN [NIOServerCxn.Factory:2181] org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:417) 2009-03-18 13:06:57,252 - Exception causing close of session 0x1201aac14300022 due to java.io.IOException: Read error WARN [NIOServerCxn.Factory:2181] org.apache.zookeeper.server.NIOServerCnxn.doIO(NIOServerCnxn.java:417) 2009-03-18 13:06:58,198 - Exception causing close of session 0x1201aac143f due to java.io.IOException: Read error -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-361) integrate cppunit testing as part of hudson patch process.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12695493#action_12695493 ] Mahadev konar commented on ZOOKEEPER-361: - i dont have access to vesta... can you grant me access, so that I can run the tests on the hudson machines? integrate cppunit testing as part of hudson patch process. -- Key: ZOOKEEPER-361 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-361 Project: Zookeeper Issue Type: New Feature Components: build Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Mahadev konar Assignee: Giridharan Kesavan Attachments: zk-361.patch we need to test the c tests as part of our hudson patch testing process. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-364) command line interface for zookeeper.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-364: Description: currently we have a shell based interface for zookeeper (which again isnt well published). we should have a well published cli based interface for zookeeper. (was: currently we have a shell based interface for zookeeper (which again isnt well published). we should have a wee published cli based interface for zookeeper.) command line interface for zookeeper. - Key: ZOOKEEPER-364 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-364 Project: Zookeeper Issue Type: New Feature Affects Versions: 3.0.0, 3.0.1, 3.1.0, 3.1.1 Reporter: Mahadev konar Fix For: 3.2.0 currently we have a shell based interface for zookeeper (which again isnt well published). we should have a well published cli based interface for zookeeper. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-360) WeakHashMap in Bookie.java causes NPE
[ https://issues.apache.org/jira/browse/ZOOKEEPER-360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-360: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) WeakHashMap in Bookie.java causes NPE - Key: ZOOKEEPER-360 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-360 Project: Zookeeper Issue Type: Bug Components: contrib-bookkeeper Affects Versions: 3.1.1 Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.2.0 Attachments: ZOOKEEPER-BOOKKEEPER-360.patch We need a strong reference to prevent a key in masterKeys on Bookie.java to be garbage collected. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-362) Issues with FLENewEpochTest
[ https://issues.apache.org/jira/browse/ZOOKEEPER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-362: Resolution: Fixed Status: Resolved (was: Patch Available) +1 to the patch. i just committed this. thanks flavio. Issues with FLENewEpochTest --- Key: ZOOKEEPER-362 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-362 Project: Zookeeper Issue Type: Bug Affects Versions: 3.1.1 Reporter: Flavio Paiva Junqueira Assignee: Flavio Paiva Junqueira Fix For: 3.2.0 Attachments: ZOOKEEPER-362.patch, ZOOKEEPER-362.patch I have been able to identify two reasons that cause FLENewEpochTest to fail: 1- There is a race condition that is triggered when two peers try to establish a connection to each other for leader election. Basically, if they start roughly at the same time, the server with highest id will try to open two connections. The two competing connections will lead to one notification message to be lost. This message happens to be critical for this two process scenario; 2- The code to shut down a peer is not working well with the unit tests. For this particular unit test, we need to be able to shut down a peer completely to check the situation the test tries to reproduce. However, it seems that in some runs timing causes the other peers to believe it is still alive, and end up electing it. This peer, however, eventually shuts down and leader election fails. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-30) Hooks for atomic broadcast protocol
[ https://issues.apache.org/jira/browse/ZOOKEEPER-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12695631#action_12695631 ] Mahadev konar commented on ZOOKEEPER-30: i andrew, as pat pointed out that we would not be able to merge an external branch without a code grant as we have in patch submissions. would it be possible for you guys to break up the patch like - 1) patch for changes in persistence 2) patch for changes in quorum something liek that? if not creating a single patch is fine... We would like to include your changes in Zookeeper but it would be difficult for us to find bandwidth to review an external repository. Also it would be great if you can include the list of changes (concretely) you have made for Zas on this jira. Also, we should be able to meet with you later in may.. we can discuss that outside of this jira... Hooks for atomic broadcast protocol --- Key: ZOOKEEPER-30 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-30 Project: Zookeeper Issue Type: New Feature Components: quorum Reporter: Patrick Hunt Assignee: Mahadev konar Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1938788group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (ZOOKEEPER-30) Hooks for atomic broadcast protocol
[ https://issues.apache.org/jira/browse/ZOOKEEPER-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12695631#action_12695631 ] Mahadev konar edited comment on ZOOKEEPER-30 at 4/3/09 3:53 PM: hi andrew, as pat pointed out that we would not be able to merge an external branch without a code grant as we have in patch submissions. would it be possible for you guys to break up the patch like - 1) patch for changes in persistence 2) patch for changes in quorum something liek that? if not creating a single patch is fine... We would like to include your changes in Zookeeper but it would be difficult for us to find bandwidth to review an external repository. Also it would be great if you can include the list of changes (concretely) you have made for Zas on this jira. Also, we should be able to meet with you later in may.. we can discuss that outside of this jira... was (Author: mahadev): i andrew, as pat pointed out that we would not be able to merge an external branch without a code grant as we have in patch submissions. would it be possible for you guys to break up the patch like - 1) patch for changes in persistence 2) patch for changes in quorum something liek that? if not creating a single patch is fine... We would like to include your changes in Zookeeper but it would be difficult for us to find bandwidth to review an external repository. Also it would be great if you can include the list of changes (concretely) you have made for Zas on this jira. Also, we should be able to meet with you later in may.. we can discuss that outside of this jira... Hooks for atomic broadcast protocol --- Key: ZOOKEEPER-30 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-30 Project: Zookeeper Issue Type: New Feature Components: quorum Reporter: Patrick Hunt Assignee: Mahadev konar Moved from SourceForge to Apache. http://sourceforge.net/tracker/index.php?func=detailaid=1938788group_id=209147atid=1008547 -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-343) add tests that specifically verify the zkmain and qpmain classes
[
https://issues.apache.org/jira/browse/ZOOKEEPER-343?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12696251#action_12696251
]
Mahadev konar commented on ZOOKEEPER-343:
-
i am really glad that you removed this
{code}
runStandalone(new ZooKeeperServer.Factory()
{code}
That zookeeperserver factory used to annoy me a lot.
I have one question though --
- you have removed the QuorumpeerConfig inheting from ServerConfig...
I actually liked that and would like to keep it. Imagine we just passed around
configs in our server code inside al lthe processors. I would like to have one
common interface to pass around all the config stuff that can be used by all
the code on the server side.
add tests that specifically verify the zkmain and qpmain classes
Key: ZOOKEEPER-343
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-343
Project: Zookeeper
Issue Type: Improvement
Components: tests
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Fix For: 3.2.0
Attachments: ZOOKEEPER-343.patch, ZOOKEEPER-343.patch
We are missing tests for these two main() routines.
Add tests that verify standalone and quorum (2 servers is probably enough) by
starting and connecting a client.
Use on-disk configuration files to configure these.
(ie verify starting with actual config files)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Created: (ZOOKEEPER-369) remove multiple configs in server/quorums.
remove multiple configs in server/quorums. -- Key: ZOOKEEPER-369 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-369 Project: Zookeeper Issue Type: Improvement Affects Versions: 3.1.1, 3.1.0, 3.0.1, 3.0.0 Reporter: Mahadev konar Fix For: 3.2.0 currently we have mutliple configs serverconfig and quorumpeerconfig for server and quorums. We can throw away one of these and just keep one of them with some methods returning default values like -1 or null for options that are not available. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-343) add tests that specifically verify the zkmain and qpmain classes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-343: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) i have opened another jira ZOOKEEPER-369 for keepeing just one config (serverconfig) and remove the other one. I have committed this. thanks pat. add tests that specifically verify the zkmain and qpmain classes Key: ZOOKEEPER-343 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-343 Project: Zookeeper Issue Type: Improvement Components: tests Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.2.0 Attachments: ZOOKEEPER-343.patch, ZOOKEEPER-343.patch We are missing tests for these two main() routines. Add tests that verify standalone and quorum (2 servers is probably enough) by starting and connecting a client. Use on-disk configuration files to configure these. (ie verify starting with actual config files) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-342) improve configuration code - remove static config and use java properties
[ https://issues.apache.org/jira/browse/ZOOKEEPER-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahadev konar updated ZOOKEEPER-342: Resolution: Fixed Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) resolving this as ZOOKEEPER-343 was committed. improve configuration code - remove static config and use java properties - Key: ZOOKEEPER-342 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-342 Project: Zookeeper Issue Type: Improvement Components: server Reporter: Patrick Hunt Assignee: Patrick Hunt Fix For: 3.2.0 The current server/quorum config classes are essentially global variables. Need to fix configuration parsing, remove use of essentially global vars (static) and also cleanup the code generally. Add tests specific to configurtion parsing. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.
