Re: [Zope] FSZSQLMethod.py refactory
Jens Vagelpohl wrote:
I did a refactory in the FSZSQLMethod.py module of CMFCore from SVN.
I want to use my ZSQLs from the filesystem and I improved the module
to better support to this feature.
First of all, CMF-related items are better discussed on the zope-
[EMAIL PROTECTED] list.
Sorry!
Can you explain how your changes better support ZSQL methods on the
file system? They work perfectly fine the way they are.
The actual implemantation parsing a code with
dtml-comment/dtml-comment tags in its body, with the arguments list.
I think it's ugly.
# parse parameters
parameters={}
start = data.find('dtml-comment')
end = data.find('/dtml-comment')
if start==-1 or end==-1 or startend:
raise ValueError,'Could not find parameter block'
block = data[start+14:end]
So, the entire data information is submited in template, or either, the
body of zsql method receives dtml-comment tags and the arguments list
too. I don't know how can it work!?
self.manage_edit(title, connection_id, arguments, template=data)
In the top of template has a comment:
(not yet) Customizable ZSQL methods that come from the filesystem.
I think (not yet) means this module is not working yet, and it is my
impression after my tests and analisys the code!
Oh, and what exactly is not working about the CMF Subversion repository?
I am using Plone 2.1, following the instruction:
http://plone.org/development/info/participation
It worked fine 2 days ago, but now it give me a timeout exception.
Forgives myself for trying to help the community!
--
Jean Ferri
TcheZope.org
___
Zope maillist - Zope@zope.org
http://mail.zope.org/mailman/listinfo/zope
** No cross posts or HTML encoding! **
(Related lists -
http://mail.zope.org/mailman/listinfo/zope-announce
http://mail.zope.org/mailman/listinfo/zope-dev )
Re: [Zope] FSZSQLMethod.py refactory
Jens Vagelpohl wrote: It does work. How? Give me an example! The comment is wrong. If you find something that does *not* work I'll be glad to look at it, but so far you have not given any specific information about breakages like tracebacks or steps to follow to produce an error. I can't give this information because it doesn't raise exceptions. It works (not raise errors), but not properly. I never saw an example of ZSQL Methods running from file system in CMF, can you give me this? My intention is just contribute, however, solving a real problem I have. -- Jean Ferri TcheZope.org ___ Zope maillist - Zope@zope.org http://mail.zope.org/mailman/listinfo/zope ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope-dev )
Re: [Zope] FSZSQLMethod.py refactory
On 22 Jul 2005, at 17:17, Jean Rodrigo Ferri wrote: Jens Vagelpohl wrote: It does work. How? Give me an example! Take a look at the unit tests which exercise the FSZSQL code, there is a sample one that is part of the fake skins directory used by the CMFCore unit tests: http://svn.zope.org/CMF/trunk/CMFCore/tests/fake_skins/fake_skin/ testsql.zsql?rev=37165view=markup I can't give this information because it doesn't raise exceptions. It works (not raise errors), but not properly. I never saw an example of ZSQL Methods running from file system in CMF, can you give me this? My intention is just contribute, however, solving a real problem I have. You're still giving no clue about what exactly it is that works not properly. jens ___ Zope maillist - Zope@zope.org http://mail.zope.org/mailman/listinfo/zope ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope-dev )
Re: [Zope] FSZSQLMethod.py refactory
Jens Vagelpohl wrote: [...] You're still giving no clue about what exactly it is that works not properly. I looked at your example and I understood the correct sintax, now it make sence, the dtml-comment comments the attributes in the body of ZSQLMethod. But in my refactory of parser I used a more elegant sintax to the file like Script Python, and does not leave the trash (dtml-comment arguments /dtml-comment) in the body of the method. I only wait that someone test my reimplementation of parser and says me it's really insignificant. I would like at least not to have that trash (dtml-comment...) in the body of the method. Regards! -- Jean Ferri ___ Zope maillist - Zope@zope.org http://mail.zope.org/mailman/listinfo/zope ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope-dev )
Re: [Zope] FSZSQLMethod.py refactory
I only wait that someone test my reimplementation of parser and says me it's really insignificant. I would like at least not to have that trash (dtml-comment...) in the body of the method. As far as the CMF goes, IMHO it doesn't make much sense to put code into the repository just because one person doesn't like the way arguments are handed to these ZSQL methods. They work perfectly as is. I fail to see how several lines of double-hash-escaped lines is any less trash than the comment-tagged version that is there right now. jens ___ Zope maillist - Zope@zope.org http://mail.zope.org/mailman/listinfo/zope ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope-dev )
Re: [Zope] FSZSQLMethod.py refactory
I did a refactory in the FSZSQLMethod.py module of CMFCore from SVN. I want to use my ZSQLs from the filesystem and I improved the module to better support to this feature. First of all, CMF-related items are better discussed on the zope- [EMAIL PROTECTED] list. Can you explain how your changes better support ZSQL methods on the file system? They work perfectly fine the way they are. Oh, and what exactly is not working about the CMF Subversion repository? jens ___ Zope maillist - Zope@zope.org http://mail.zope.org/mailman/listinfo/zope ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope-dev )
