Re: [OpenJDK 2D-Dev] [9] RFR JDK-6357887: selected printertray is ignored under linux

On 8/19/2016 3:36 AM, Philip Race wrote: Oh .. right under the covers the map is just a HashMap and the key to the map is the class so just decides if these are equal class objects. Hmm .. I don't know anymore if that was the original intent but we probably should not mess with it right now ju

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163258 : Getting NullPointerException from ImageIO.getReaderWriterInfo due to failure to check for null

Looks good to me. Regards Prasanta On 8/18/2016 9:34 PM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-8163258 Webrev : http://cr.openjdk.java.net/~jdv/8163258/webrev.00/

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6574279: validatePage from PrinterJob returns argument under linux

PS as I just mentioned in another review thread, I have a suspicion that the Media and MPA for CUPS are never matched to "standard" (pre-defined in API) ones. I don't know how much this matters - A4 when sent to printing should (he says) get matched on size to the right media but you should chec

Re: [OpenJDK 2D-Dev] [9] Review Request: 8164104 Cleanup of javaclient related mapfiles

On 8/17/16, 6:33 AM, Sergey Bylokhov wrote: Tested on solarisX64/solarisSparc/linuxX64 no issues were found(SwingSet2/Java2Demo). Sounds good. +1 But I wonder why the text on solarissparc filled by yellow shadow(Is it a known issue)? Yes there is an open bug. I believe it is a SPARC (or mor

Re: [OpenJDK 2D-Dev] [9] RFR JDK-6357887: selected printertray is ignored under linux

Oh .. right under the covers the map is just a HashMap and the key to the map is the class so just decides if these are equal class objects. Hmm .. I don't know anymore if that was the original intent but we probably should not mess with it right now just for the optimisation. But now I am wonde

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is disabled for SERVICE_FORMATTED docflavor in linux

+1 -phil On 8/18/16, 9:12 AM, Jayathirth D V wrote: Hi Prasanta, Changes are working fine. Thanks, Jay *From:*Prasanta Sadhukhan *Sent:* Thursday, August 18, 2016 5:30 PM *To:* Jayathirth D V; Philip Race; 2d-dev *Subject:* Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is disabl

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163258 : Getting NullPointerException from ImageIO.getReaderWriterInfo due to failure to check for null

+1 -phil On 8/18/16, 9:04 AM, Jayathirth D V wrote: Hi, Please review the following fix in JDK9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-8163258 Webrev : http://cr.openjdk.java.net/~jdv/8163258/webrev.00/ I

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is disabled for SERVICE_FORMATTED docflavor in linux

Hi Prasanta,   Changes are working fine.   Thanks, Jay   From: Prasanta Sadhukhan Sent: Thursday, August 18, 2016 5:30 PM To: Jayathirth D V; Philip Race; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is disabled for SERVICE_FORMATTED docflavor in linux   Ok. I

[OpenJDK 2D-Dev] [9] RFR JDK-8163258 : Getting NullPointerException from ImageIO.getReaderWriterInfo due to failure to check for null

Hi, Please review the following fix in JDK9 at your convenience: Bug : https://bugs.openjdk.java.net/browse/JDK-8163258 Webrev : http://cr.openjdk.java.net/~jdv/8163258/webrev.00/ Issue : When we call ImageIO.getReaderMIMETypes() or ImageIO. getFileSuffixes() with MIMEType or Fil

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is disabled for SERVICE_FORMATTED docflavor in linux

Ok. I have extended the testcase to check both the non SERVICE_FORMATTED and SERVICE_FORMATTED cases by showing 2 print dialogs. Please have a look. http://cr.openjdk.java.net/~psadhukhan/8163922/webrev.01/ Regards Prasanta On 8/18/2016 4:37 PM, Jayathirth D V wrote: Hi Prasanta, Can you plea

Re: [OpenJDK 2D-Dev] [9] RFR JDK-8163922: Print-to-file is disabled for SERVICE_FORMATTED docflavor in linux

Hi Prasanta,   Can you please verify whether we have any test case already present which actually checks this basic behavior of visible Print-to-File option enabled in SERVICE_FORMATTED DocFlavor.   If not, we need to add test case which checks this behavior specifically, so that it can be p

Re: [OpenJDK 2D-Dev] Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWindows/TranslucentPerPixelTranslucentGradient.java fails

Added "2d-dev" team for review Regards, Prem From: Alexandr Scherbatiy Sent: Thursday, August 18, 2016 2:57 PM To: Prem Balakrishnan; Rajeev Chamyal; awt-...@openjdk.java.net; Sergey Bylokhov Subject: Re: Review Request: JDK-8144735 [hidpi] javax/swing/JWindow/ShapedAndTranslucentWind