Re: [OpenJDK 2D-Dev] [12] RFR JDK-8139178: Wrong fontMetrics when printing in Landscape

od to me. Just some nits. >> >> Can we split the long lines like this ? :- >> >> #define contextAwareMetricsX(vx, vy) \ >>(FTFixedToFloat(context->transform.xx) * (vx) - \ >> FTFixedToFloat(context->transform.xy) * (vy)) >> >> and why

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8139178: Wrong fontMetrics when printing in Landscape

:- > > #define contextAwareMetricsX(vx, vy) \ > (FTFixedToFloat(context->transform.xx) * (vx) - \ > FTFixedToFloat(context->transform.xy) * (vy)) > > and why "vx" and "vy", not just x and y ? > > -phil. > > On 11/10/18 8:53 AM, Andr

[OpenJDK 2D-Dev] [12] RFR JDK-8139178: Wrong fontMetrics when printing in Landscape

Hello, could you please review a fix for JDK-8139178. Bug: https://bugs.openjdk.java.net/browse/JDK-8139178 Webrev: http://cr.openjdk.java.net/~bae/8139178/webrev.00/ The freetype scaler calculates font metrics with a transform applied to the scaler context. We have to revert this transform

Re: [OpenJDK 2D-Dev] RFR: 8203485: [freetype] text rotated on 180 degrees is too narrow

gt; Actually I am unclear why you need to use deriveFont and can't > test this with the constructor taking int of 12. > > -phil > > On 5/22/18, 8:50 AM, Andrew Brygin wrote: >> Webrev: http://cr.openjdk.java.net/~bae/8203485/webrev.00/ >> >> Bug: >> http

[OpenJDK 2D-Dev] RFR: 8203485: [freetype] text rotated on 180 degrees is too narrow

Webrev: http://cr.openjdk.java.net/~bae/8203485/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8203485 With freetype, text rotated on 180 or 270 degrees is too narrow. Attached test case and screenshots demonstrate the problem. The problem is caused by the rounding applied to the

Re: [OpenJDK 2D-Dev] RFR: 8047931: Remove unused medialib code

Hello Vadim, the change looks fine to me. Probably, there is more room for optimization: we actually use only mlib images with types MLIB_BYTE, and MLIB_SHORT (see allocateArray() and allocateReasterArray()) so routines for other types likely can be eliminated. Thanks, Andrew > On May 4,

Re: [OpenJDK 2D-Dev] CFV: New 2D Group Member: Sergey Bylokhov

Vote: yes. Thanks, Andrew. On Dec 7, 2015, at 11:29 PM, Phil Race > wrote: I hereby nominate Sergey Bylokhov to membership in the 2D group. Sergey has been a de facto member of the group for a long time and has contributed numerous

Re: [OpenJDK 2D-Dev] CFV: New 2D Group Member: Sergey Bylokhov

Vote: yes. Thanks, Andrew. On Dec 7, 2015, at 11:29 PM, Phil Race > wrote: I hereby nominate Sergey Bylokhov to membership in the 2D group. Sergey has been a de facto member of the group for a long time and has contributed numerous

Re: [OpenJDK 2D-Dev] [9] request for review: 8078382: Wrong glyph is displayed for a derived font

the cases when GDI and JDK disagree on the actual font and remap the glyph id. -phil. On 7/15/15 4:12 AM, Andrew Brygin wrote: Hello, could you please review a fix for 8078382? bug: https://bugs.openjdk.java.net/browse/JDK-8078382 webrev: http://cr.openjdk.java.net/~bae/8078382/9/webrev.00

Re: [OpenJDK 2D-Dev] RFR: 8130737: AffineTransformOp can't handle child raster with non-zero x-offset

Hello Phil, the fix looks fine to me. Thanks, Andrew On 7/15/2015 1:37 AM, Phil Race wrote: If a child raster is created with a non-zero x-offset then subsequently in the code that validates the raster for imaging operations we may incorrectly calculate that the image exceeds the data

[OpenJDK 2D-Dev] [9] request for review: 8078382: Wrong glyph is displayed for a derived font

Hello, could you please review a fix for 8078382? bug: https://bugs.openjdk.java.net/browse/JDK-8078382 webrev: http://cr.openjdk.java.net/~bae/8078382/9/webrev.00/ The problem is caused by following peculiarity of the Code New Roman font: this font provides plain, italic and bold variants.

[OpenJDK 2D-Dev] [9] request for review: 8098853: [PIT] Fonts look much darker than before in the PIT build for b68

Hello, could you please review a fix for 8098853? bug: https://bugs.openjdk.java.net/browse/JDK-8098853 webrev: http://cr.openjdk.java.net/~bae/8098853/9/webrev.00/ By default, we use 140 as lcd contrast value. However, on macosx this value causes significant discrepancy with results of

Re: [OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

/8087201/9/webrev.01/ What do you think? Thanks, Andrew On 6/25/2015 8:08 PM, Phil Race wrote: On 06/25/2015 03:33 AM, Andrew Brygin wrote: Given that it is a unified driver it sounds like we may be want to disable this code path when on windows at least for NV but I guess we may also want

Re: [OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

%) | | *** | On 19.06.15 15:54, Andrew Brygin wrote: Hello Sergey, the only part of the fix affects the performance of AA case: the cache cell size. In a case of retina

Re: [OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

24/06/15 21:40, Phil Race wrote: On 6/24/15 8:18 AM, Andrew Brygin wrote: Hello Phil, please see my comments inline. 23/06/15 21:29, Phil Race wrote: Hi Andrew, Overall the fix looks good. A few questions. 1. Regarding translucent surfaces, do you know when Swing has a translucent

Re: [OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

, Andrew -phil. On 06/18/2015 07:40 AM, Andrew Brygin wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8087201 Webrev: http://cr.openjdk.java.net/~bae/8087201/9/webrev.00/ Thanks, Andrew 18/06/15 17:39, Andrew Brygin пишет: Hello, could you please review a fix for 8087201? The root

Re: [OpenJDK 2D-Dev] Review Request for bug (JDK-8080287): The image of BufferedImage.TYPE_INT_ARGB and BufferedImage.TYPE_INT_ARGB_PRE is blank

Hello Prasanta, I have couple comments regarding the fix. * lines 408 - 420 and lines 438 - 444. Here you are obtaining the source and destination rasters for all bands (colors + alpha). However, it is already done on the lines 391 and 392. Could you please clarify a purpose of

Re: [OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

this information can be useful as a comments in the code. On 18.06.15 17:39, Andrew Brygin wrote: Hello, could you please review a fix for 8087201? The root of the problem is that we have to supply a content of destination surface to lcd shader to compose the lcd glyph correctly. In order to do

Re: [OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

rendering btw, except for some text rendered double, but I think that's a netbeans issue; https://bugzilla-attachments-216655.netbeans.org/bugzilla/attachment.cgi?id=153905 On 19 June 2015 at 00:40, Andrew Brygin andrew.bry...@oracle.com wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8087201

Re: [OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

Bug: https://bugs.openjdk.java.net/browse/JDK-8087201 Webrev: http://cr.openjdk.java.net/~bae/8087201/9/webrev.00/ Thanks, Andrew 18/06/15 17:39, Andrew Brygin пишет: Hello, could you please review a fix for 8087201? The root of the problem is that we have to supply a content

[OpenJDK 2D-Dev] [9] request for review: 8087201: OGL: rendering of lcd text is slow

Hello, could you please review a fix for 8087201? The root of the problem is that we have to supply a content of destination surface to lcd shader to compose the lcd glyph correctly. In order to do this, we have to copy a sub-image from destination buffer to an intermediate texture using

Re: [OpenJDK 2D-Dev] AWT Dev [9] Review Request: 8080993 Compilation errors with recent clang in awt_parseImage.c and splashscreen_sys.m

Hi Sergey, the fix looks fine to me. Thanks, Andrew On 6/17/2015 1:16 AM, Sergey Bylokhov wrote: Hello, Any volunteers to review the fix? On 08.06.15 19:52, Sergey Bylokhov wrote: Hello. Please review the small fix for jdk9. Two simple warnings were fixed. The fix contributed by Staffan

Re: [OpenJDK 2D-Dev] review backport fix of 8081756 to 8u-dev

Hello Phil, the backport looks fine to me. Thanks, Andrew On 6/10/2015 11:25 PM, Phil Race wrote: Andrew/Sergey, Could one of you please be a 'sanity check' backport reviewer on this backport of a missing check for NULL in LittleCMS code. It is identical to the JDK 9 changeset : -

[OpenJDK 2D-Dev] [9] request for review: 8085910: OGL text renderer: gamma lut cleanup

Hello Sergey, and Phil, could you please review a fix for CR 8085910? Bug: https://bugs.openjdk.java.net/browse/JDK-8085910 Webrev: http://cr.openjdk.java.net/~bae/8085910/9/webrev.00/ This fix just removes the code related to gamma LUTs from ogl text renderer. This code is not needed

Re: [OpenJDK 2D-Dev] RFR: 8u-dev backport: 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

: This is fine by me. -phil. On 05/30/2015 10:21 AM, Andrew Brygin wrote: Hello Sergey, and Phil, could you please review a backport of the fix for 8023794 to 8u-dev? The change is exactly same, except a declaration of the loop counter 'i' in getReverseGammaLut() routine (CGGlyphImages.m, lines 206

[OpenJDK 2D-Dev] RFR: 8u-dev backport: 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

Hello Sergey, and Phil, could you please review a backport of the fix for 8023794 to 8u-dev? The change is exactly same, except a declaration of the loop counter 'i' in getReverseGammaLut() routine (CGGlyphImages.m, lines 206-217): it has to be moved in order to meet XCode 4.x

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

other apps produce ? -phil. On 04/30/2015 06:21 AM, Andrew Brygin wrote: Hello Phil, please take a look to updated version of the fix: http://cr.openjdk.java.net/~bae/8023794/9/webrev.09/ The main difference is in glyph generation. I have implemented 'reverse gamma correction' approach

Re: [OpenJDK 2D-Dev] RFR: 8078331: Upgrade JDK to use LittleCMS 2.7

8 files against the 9 files and they are all identical So the end result is that we will have exactly LCMS 2.7 FCS/GA in both JDK 8u60 and JDK 9 I am also running a full JPRT job to make sure there are no build surprises. -phil. On 04/28/2015 09:39 PM, Andrew Brygin wrote: Hello Phil

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

/24/2015 7:33 PM, Andrew Brygin wrote: Hello Phil, please see my comments inline. On 4/23/2015 11:15 PM, Phil Race wrote: 373 fontHints.put(RenderingHints.KEY_ANTIALIASING, RenderingHints.VALUE_ANTIALIAS_ON); Why do we need this ? Historically in the (non-OSX) code this would slow

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

. translucent destination support (as a part of JDK-8078516)? Thanks, Andrew -phil. On 03/27/2015 07:50 AM, Andrew Brygin wrote: There is a minor update in the fix: it does not worth to blend black-on-white and white-on-black glyphs for the case of AA glyphs, because it makes no difference

Re: [OpenJDK 2D-Dev] RFR: 7145508: java.awt.GraphicsDevice.get/setDisplayMode behavior is incorrect when no display is present

Hello Phil, the change looks fine to me. Thanks, Andrew On 4/18/2015 12:19 AM, Phil Race wrote: http://cr.openjdk.java.net/~prr/7145508/ https://bugs.openjdk.java.net/browse/JDK-7145508 If you physically disconnect the monitor and run headful, then on X, the XRR extension will return

Re: [OpenJDK 2D-Dev] RFR: Backport :8073699: Memory leak in jdk/src/java/desktop/share/native/libjavajpeg/imageioJPEG.c

Hi Phil, it looks fine to me. Thanks, Andrew 20/04/15 21:49, Phil Race пишет: Andrew Sergey, Please review this identical 8u60 backport (diff below) of the JDK 9 fix : http://hg.openjdk.java.net/jdk9/hs/jdk/rev/b7e402c9b183 hg diff imageioJPEG.c diff --git

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

, Andrew Brygin wrote: Hi Chris, thank you for the comments and explanation. I have updated the OGLContext_IsLCDShaderSupportAvailable() and comments in OGLTextRenderer.c accordingly: http://cr.openjdk.java.net/~bae/8023794/9/webrev.07/ Good to know that you keep an eye on the OGL pipeline

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

Number of losses: 1 Thanks, Andrew On 12/12/2014 8:11 PM, Andrew Brygin wrote: Hello Phil, at the moment, I failed to get acceptable results for rendering to translucent destination. I am playing with an idea to fall back to grayscale AA on non-opaque pixels (or pixels with opacity less

[OpenJDK 2D-Dev] [9] request for review: 8074954: ImageInputStreamImpl.readShort/readInt do not behave correctly at EOF

Hello, could you please review a fix for CR 8074954? Bug: https://bugs.openjdk.java.net/browse/JDK-8074954 Webrev: http://cr.openjdk.java.net/~bae/8074954/9/webrev.00/ The problem happens if an input stream does not contain enough data to read a multi-byte type (as 4-bytes integer or

Re: [OpenJDK 2D-Dev] [9] Review Request: 4958064 JPGWriter does not throw UnsupportedException when canWriteSequence retuns false

Hello Sergey, the fix looks fine to me. Thanks, Andrew On 2/9/2015 4:30 PM, Sergey Bylokhov wrote: Hello. Please review a small fix for jdk 9. The API Doc for ImageWriter.PrepareWriteSequence() claims that this method will throw UnsupportedOperationException when canWriteSequence() returns

Re: [OpenJDK 2D-Dev] Review Request: 4952954 abort flag is not cleared for every write operation for JPEG ImageWriter

Hello Sergey, the change looks fine to me. Thanks, Andrew On 1/29/2015 1:51 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. After the fix a jpeg plugin will clear abort flag and reset the native state when the write method will be called after abort. Bug:

Re: [OpenJDK 2D-Dev] RFR: 8064833 : [macosx] Native font lookup uses family+style, not full name/postscript name

Hello Phil, could you please clarify why do we need to register italic variant twice: CFontManager.java: 280registerGenericFont(plain.createItalicVariant(), true); 281CFont f = plain.createItalicVariant(); 282registerGenericFont(f, true);

Re: [OpenJDK 2D-Dev] Printing to Postscript doesn't support dieresis

Hello Mario, the change looks fine to me. Thanks, Andrew - Original Message - From: neug...@redhat.com To: philip.r...@oracle.com Cc: 2d-dev@openjdk.java.net Sent: Friday, December 19, 2014 7:34:06 PM GMT +04:00 Abu Dhabi / Muscat Subject: Re: [OpenJDK 2D-Dev] Printing to Postscript

Re: [OpenJDK 2D-Dev] [9] Review Request: 8065373 [macosx] jdk8, jdk7u60 Regression in Graphics2D drawing of derived Fonts

Hello Sergey, the change looks fine to me. Thanks, Andrew. On 12/12/2014 12:57 AM, Sergey Bylokhov wrote: Hi, Phil. - philip.r...@oracle.com wrote: Consistent treatment of concatenating sInverseTx seems right although I am not sure of the overall picture here. Quartz uses y

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

consider to use two different programs: one for opaque paint (in order to preserve performance), and another (like published now) for the case of alpha paint. Please take a look. Thanks, Andrew On 10/25/2014 12:03 AM, Phil Race wrote: On 10/24/2014 10:56 AM, Andrew Brygin wrote: Hello

Re: [OpenJDK 2D-Dev] [9] Review Request: 8059944 [OGL] Metrics for a method choice copying of texture should be improved

Hello Sergey, the change looks fine to me. Thanks, Andrew On 11/24/2014 9:00 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. This fix initially was sent as a fix for JDK-8029253 [1], but was postponed because another issue became a bottleneck [2] Description: We have

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

paint. This behavior is common for all cases (software loops, OGL, and D3D), so it seems to deserve a separate bug if we want to handle this case. Thanks, Andrew On 10/14/2014 3:39 AM, Phil Race wrote: On 10/13/2014 05:41 AM, Andrew Brygin wrote: Hello Phil, please see my

Re: [OpenJDK 2D-Dev] [9] Review Request: 8059941 [D3D] The fix for JDK-8029253 should be ported to d3d pipeline

Hello Sergey, the change looks fine to me. Thanks, Andrew On 10/15/2014 10:43 PM, Sergey Bylokhov wrote: Hello. After a few attempts I am able to run 2dbench on my laptop in d3d mode: Config file: http://cr.openjdk.java.net/~serb/8059941/nvidia-d3d-win/drawimage Results:

Re: [OpenJDK 2D-Dev] [9] Review Request: 8061456 [OGL] Incorrect clip is used during sw-surface blit in xor mode

Hello Sergey, the change is fine to me. Thanks, Andrew On 10/21/2014 7:09 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. In the OGLAnyCompositeBlit the clip for the primary destination is used as the clip for the temporal buffer. Bug:

Re: [OpenJDK 2D-Dev] RFR: 8061392: PrinterJob NPE when drawing translucent image with null user clip

Hello Phil, the change looks fine to me. Thanks, Andrew On 10/18/2014 1:19 AM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8061392/ https://bugs.openjdk.java.net/browse/JDK-8061392 A check for null was missing This was partly to blame for a JavaFX printing bug. -phil.

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

-phil. On 10/10/14 2:13 PM, Andrew Brygin wrote: Hello Phil, please see my comments inline. On 10/11/2014 12:49 AM, Phil Race wrote: On 10/10/14 11:05 AM, Andrew Brygin wrote: Hello Phil, changes in SunGraphics2D and SurfaceData were made in order to implement an approach 'LCD instead

Re: [OpenJDK 2D-Dev] RFR: 8058969 : Test closed/sun/java2d/cmm/StubCMMShellTest.sh fails

Hello Phil, the fix looks fine to me. Thanks, Andrew On 10/14/2014 3:27 AM, Phil Race wrote: https://bugs.openjdk.java.net/browse/JDK-8058969 http://cr.openjdk.java.net/~prr/8058969/ This is a missing doprivileged in code updated to support jigsaw -phil.

Re: [OpenJDK 2D-Dev] RFR: 8055705: Rename UnixPrintServiceLookup and Win32PrintServiceLookup as a platform neutral class name

Hello Phil, the change looks fine to me. Thanks, Andrew On 10/9/2014 11:09 PM, Phil Race wrote: Apparently jigsaw finds it inconvenient that the service provider class names are different for Windows vs the rest of the platforms, so this fix basically just renames both classes to

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

lcdTextRenderer from SurfaceData.getTextPipe() Of course it is a brute force approach, but it allows producing a legible text in case of offscreen rendering. Thank you, Denis. On 29 Sep 2014, at 19:30, Andrew Brygin andrew.bry...@oracle.com mailto:andrew.bry...@oracle.com wrote: Hello

Re: [OpenJDK 2D-Dev] RFR: 8059848 Test java/awt/GraphicsDevice/CloneConfigsTest.java causes JVM crash in OEL 7.0

Hello Phil, the fix looks fine to me. Thanks, Andrew On 10/10/2014 8:20 PM, Phil Race wrote: This looks like its a driver bug. We use a scratch surface of size 1x1 when iterating through testing all the gl capable visuals and some of them get a SIGFPE: FPE_INTDIV when as we try to make the

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

//return aaTextRenderer; ... that looks like the case where the application code has *explicitly* specified greyscale (ON==greyscale) so I don't see why you need to go check the fontinfo in this case ? -phil. On 10/10/2014 07:34 AM, Andrew Brygin wrote: Hello Denis, could you please

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

Hello Phil, please see my comments inline. On 10/11/2014 12:49 AM, Phil Race wrote: On 10/10/14 11:05 AM, Andrew Brygin wrote: Hello Phil, changes in SunGraphics2D and SurfaceData were made in order to implement an approach 'LCD instead of greyscale AA if possible'. Without this part

Re: [OpenJDK 2D-Dev] RFR: 8059219 : JDK, JDK-8059219, , javax.print.PrintServiceLookup allows to register null service

Hello Phil, the fix looks fine. Thanks, Andrew On 10/3/2014 11:22 PM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8059219/ https://bugs.openjdk.java.net/browse/JDK-8059219 Straightforward fix for a very old bug .. -phil.

Re: [OpenJDK 2D-Dev] [9] Review request for 8023794: [macosx] LCD Rendering hints seems not working without FRACTIONALMETRICS=ON

Hello Denis, I am not sure whether we should use 'apple.awt.graphics.UseQuartz' property. Probably we have to change the text antialiasing defaults for macosx instead. I am working on the issue with software loops. I will update the thread with my findings. Thanks, Andrew On 9/3/2014

Re: [OpenJDK 2D-Dev] JDK-8038998: buttons/checkboxes/menus etc have disapearing text or fail to repaint properly

Hello Hendrik, the bug report mentions that the problem is reproducible on 1.8.0-b132. Is the problem reproducible with 8u20? Also, according to comments in the bug, it looks like D3D pipeline was activated on Intel video board: [I] Description : Intel(R) HD Graphics 4000 [I]

Re: [OpenJDK 2D-Dev] [9] request for review: 8041465: BMPImageReader read error using ImageReadParam with set sourceRectangle

the bug can be fixed in the readHeader itself? Because currently it call iis.skipBytes(bitmapOffset) at the end only for the first time. On 03.09.2014 16:23, Andrew Brygin wrote: Hello, could you please review a fix for CR 8041465? Bug: https://bugs.openjdk.java.net/browse/JDK-8041465 Webrev: http

[OpenJDK 2D-Dev] [9] request for review: 8041465: BMPImageReader read error using ImageReadParam with set sourceRectangle

Hello, could you please review a fix for CR 8041465? Bug: https://bugs.openjdk.java.net/browse/JDK-8041465 Webrev: http://cr.openjdk.java.net/~bae/8041465/9/webrev.00/ The problem happens if we perform multiple read operations from a source which is set only once. For instance, we can try

Re: [OpenJDK 2D-Dev] Review request for JDK-8054638 xrender: text drawn after setColor(Color.white) is actually black

Hello Clemens, the fix and the test look fine to me. The test probably can be simplified a bit with using getSnapshot() method of VolatileImage class, but it does not matter much here. Thanks, Andrew On 8/26/2014 11:35 PM, Phil Race wrote: Andrew or Jennifer : can you add your review 2c

Re: [OpenJDK 2D-Dev] RFR: 8056122: Upgrade JDK to use LittleCMS 2.6

Hello Phil, the change looks fine to me. Thanks, Andrew On 8/27/2014 2:26 AM, Phil Race wrote: Andrew (and at least one other brave soul), please review :- http://cr.openjdk.java.net/~prr/8056122/ -phil.

[OpenJDK 2D-Dev] [9] request for review: 8040617: macosx : Large JTable cell results in a OutOfMemoryException

Hello, could you please review a fix for CR 8040617? Bug: https://bugs.openjdk.java.net/browse/JDK-8040617 Webrev: http://cr.openjdk.java.net/~bae/8040617/9/ The problem happens when we are trying to create an accelerated copy for a buffered image with dimension exceeded

Re: [OpenJDK 2D-Dev] [9] request for review: 8040617: macosx : Large JTable cell results in a OutOfMemoryException

: Hi, Andrew. It seems to me that the same bug exists on other platforms as well. Probably we can move this check to the upper level(in the same way as d3d in case of InvalidPipeException?)? On 22.08.2014 18:34, Andrew Brygin wrote: Hello, could you please review a fix for CR 8040617? Bug

Re: [OpenJDK 2D-Dev] [9] Review Request: 8042199 The build of J2DBench via makefile is broken after the JDK-8005402

back them out. If it uses JDK 1.5 APIs then maybe Jim had to handle something similar and has an idea ? -phil. On 4/30/2014 4:13 AM, Andrew Brygin wrote: Hello Sergey, the change looks fine to me. Thanks, Andrew On 4/30/2014 3:12 PM, Sergey Bylokhov wrote: Hello. Please review the small

Re: [OpenJDK 2D-Dev] [9] Review Request: 8026497 Font2DTest demo: unused resource files

Hello Sergey, the change looks fine to me. Thanks, Andrew On 8/1/2014 2:25 PM, Sergey Bylokhov wrote: Hello. Please review a small fix for jdk9. Unused property files were removed. Bug: https://bugs.openjdk.java.net/browse/JDK-8026497 Webrev can be found at:

Re: [OpenJDK 2D-Dev] RFR 8u-dev backport of 8043508: JVM core dumps with very long text in tooltip

Hello Phil, the backport looks fine. Thanks, Andrew On 7/23/2014 9:24 PM, Phil Race wrote: Please OK this back port, It is identical to the 9 fix http://cr.openjdk.java.net/~prr/8043508.8u/ http://hg.openjdk.java.net/jdk9/client/jdk/rev/8a7fdbaea99b

Re: [OpenJDK 2D-Dev] RFR: 8048583: CustomMediaSizeName class matching to standard media is too loose

the updated fix looks fine to me. Thanks, Andrew On 7/11/2014 10:24 PM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8048583.1/ updated version to fix the incorrect usage of w and h instead of dw and dh spotted by Andrew. -phil. On 06/27/2014 01:40 PM, Phil Race wrote: Bug :

Re: [OpenJDK 2D-Dev] [9] Review request for 8041460, PNGImageWriter creates metadata with incorrect bitDepth

://bugs.openjdk.java.net/browse/JDK-4991647 Always remember to look for duplicates ! So I have closed 8041460 and you should push under 4991647 - once the code is fixed and reviewed. I have assigned 4991647 to you. -phil. On 6/23/2014 6:09 AM, Andrew Brygin wrote: Hello Mikhail, the fix looks fine

Re: [OpenJDK 2D-Dev] [9] Review request for 8041460, PNGImageWriter creates metadata with incorrect bitDepth

Hello Mikhail, the fix looks fine to me. Thanks, Andrew On 6/9/2014 10:32 PM, mikhail cherkasov wrote: Hi all, please review the fix: http://cr.openjdk.java.net/~mcherkas/8041460/webrev.02/ for the following bug: https://bugs.openjdk.java.net/browse/JDK-8041460 The problem is that during

Re: [OpenJDK 2D-Dev] [9] Review request for 8047066: Test test/sun/awt/image/bug8038000.java fails with ClassCastException

Hello Anton, the fix looks fine. Thanks, Andrew On 6/18/2014 6:54 PM, anton nashatyrev wrote: Hello, could you please review the following fix: fix: http://cr.openjdk.java.net/~anashaty/8047066/9/webrev.00/ http://cr.openjdk.java.net/%7Eanashaty/8047066/9/webrev.00/ bug:

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 and 8017626

Hello Sergey, the fix looks fine to me. Thanks, Andrew On 5/13/2014 5:00 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. This a second iteration of the fix for 8041129, because it was changed to cover 8017626 as well. Description of the problem: 8041129: [OGL]

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041644 [OGL] clip is ignored during surface-sw blit

Hello Sergey, the fix for ogl looks fine to me. Could you please update the test, and submit a separate bug against d3d? Thanks, Andrew On 5/20/2014 9:31 PM, Sergey Bylokhov wrote: On 5/20/14 9:17 PM, Phil Race wrote: On 5/20/2014 10:03 AM, Sergey Bylokhov wrote: On 5/20/14 8:52 PM, Phil

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041439: Clipping doesn't work on JPanel after setXORMode method call.

Hello Mikhail, could you please provide a bit more detailed explanation for your fix? Thanks, Andrew On 5/29/2014 3:35 PM, mikhail cherkasov wrote: Hello, Please review the fix for jdk 9: http://cr.openjdk.java.net/~mcherkas/8041439/9/webrev.00/ the bug:

Re: [OpenJDK 2D-Dev] 8038876: Remove use of ServiceLoader in locating sun.java2d.cmm.CMMServiceProvider

Hello Phil, the change looks fine to me. Thanks, Andrew On 5/10/2014 2:41 AM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8038876/ https://bugs.openjdk.java.net/browse/JDK-8038876 Another one to help the job of jigsaw .. -phil.

[OpenJDK 2D-Dev] [9] request for review: 6945174: IndexOutOfBoundsException calling ImageIO.read() on malformed PNG

Hello, could you please review a fix for CR 6945174? Bug: https://bugs.openjdk.java.net/browse/JDK-6945174 Webrev: http://cr.openjdk.java.net/~bae/6945174/9/webrev.00/ PNG image reader validates the length of chunk's data when reads image metadata. However, if metadata is ignored, the length

Re: [OpenJDK 2D-Dev] [9] request for review: 6945174: IndexOutOfBoundsException calling ImageIO.read() on malformed PNG

Hello Phil, I have corrected both occurrences of the typo: http://cr.openjdk.java.net/~bae/6945174/9/webrev.01/ Thanks, Andrew On 5/9/2014 2:04 AM, Phil Race wrote: Looks OK but please fix the typo in the exception string .. lenght - length -phil. On 5/8/14 11:43 AM, Andrew Brygin wrote

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface-sw blit is extremely slow

On 4/25/2014 4:52 PM, Sergey Bylokhov wrote: On 4/25/14 4:35 PM, Andrew Brygin wrote: Hello Sergey, the fix looks fine to me. The tests do not force the OGL pipeline, so they will verify the change only on macosx. Is it done for purpose? Yes, I assume that the jdk know better, when

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface-sw blit is extremely slow

Hello Sergey, the fast path skips j2d_glPixelStorei(GL_PACK_SKIP_ROWS, dsty). Could you please clarify why? I think that initial value of dsty (dstInfo.bounds.y1) can be non-zero, and this operation seem to be required... Thanks, Andrew On 4/21/2014 6:17 PM, Sergey Bylokhov wrote: Hello.

Re: [OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

at least one scanline. Below is the updated fix. I've also added explicit check for implicit (minY - sampleModelTranslateY = 0) constraint. http://cr.openjdk.java.net/%7Eanashaty/8038000/webrev.02/ Thank you! Anton. On 11.04.2014 15:06, Andrew Brygin wrote: Hello Anton, we probably should use

Re: [OpenJDK 2D-Dev] [9] Review Request: 8039774 [OGL] Image painting is broken if 'sun.java2d.accthreshold' is set to 0

Hello Sergey, the fix looks fine. Thanks, Andrew On 4/10/2014 3:45 PM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. The bug occurs, when we try to call drawImageBg with scale and 'sun.java2d.accthreshold' is set to 0. The bug exists in the DrawImage.renderImageXform().

Re: [OpenJDK 2D-Dev] [9] Review request for 8038000: java.awt.image.RasterFormatException: Incorrect scanline stride

Hello Anton, we probably should use '(minY + height) 1' as a condition for the scanstride test, should not we? Otherwise, we are not taking into account the case when minY is greater than 0, and too big scanstride may be potentially dangerous. Thanks, Andrew On 4/10/2014 11:26 PM, anton

Re: [OpenJDK 2D-Dev] [9] Review Request: 8039418 [macosx] Calling JNI functions in the scope of Get/ReleasePrimitiveArrayCritical

Hello Sergey, the fix looks fine to me. Thanks, Andrew On 4/9/2014 1:21 AM, Sergey Bylokhov wrote: Hello. Please review the fix for jdk 9. The method [1] is called between Get/ReleasePrimitiveArrayCritical. In the fix it was moved above GetPrimitiveArrayCritical call. [1]: JNIEXPORT void

Re: [OpenJDK 2D-Dev] RFR: JDK8u20 backport of 8031095: warning from jdk/src/solaris/native/sun/awt/awt_Font.c: memory leak

Hello Phil, the backport looks fine. Thanks, Andrew On 4/4/2014 10:29 PM, Phil Race wrote: Jennifer Andrew, Please check the identical JDK8u20 backport of the fix for the (theoretical) memory leak in awt_Font.c that you approved for JDK9 Bug link:

Re: [OpenJDK 2D-Dev] [9] RFR 8029628: Many graphic artifacts

Hello Vadim, the fix looks fine to me. Thanks, Andrew On 3/28/2014 2:18 PM, Vadim Pakhnushev wrote: Hi, Please review this direct forward port for JDK 9. The patch is identical so I use old JDK 8 webrev: http://cr.openjdk.java.net/~vadim/8029628/webrev.00/

Re: [OpenJDK 2D-Dev] [9] request for review: 8036022: D3D: rendering with XOR composite causes InternalError.

... ...jim On 3/17/14 2:22 AM, Andrew Brygin wrote: Hello Jim, I have completely changed the fix while trying to answer your questions :) I agree that the check for composite type is incorrect: in fact we have to check whether the gdi surface data can be used as a destination for rendering

Re: [OpenJDK 2D-Dev] [9] request for review: 8036022: D3D: rendering with XOR composite causes InternalError.

and we remain XOR, does this force us to fetch the loops on every validate? I forget the strategy for the loops variable, was it supposed to be set to null to force a refetch somewhere, but some invalidation case missed setting the loops=null for XOR? ...jim On 3/13/14 4:54 AM, Andrew

Re: [OpenJDK 2D-Dev] JDK 9: RFR: 8033716: Fix raw and unchecked lint warnings in com.sun.imageio

Hello Henry, please see my comments regrading the fallthrough warnings inline. On 2/20/2014 12:05 PM, Henry Jen wrote: On 02/19/2014 02:59 PM, Henry Jen wrote: On 02/19/2014 01:46 PM, Phil Race wrote: W.r.t the following change ...

Re: [OpenJDK 2D-Dev] JDK 9: RFR[2]: 8033716: Fix raw and unchecked lint warnings in com.sun.imageio

Hello Henry, the fix looks fine to me. Thanks, Andrew On 2/21/2014 1:01 AM, Henry Jen wrote: Hi, Please review the latest update, I think this should address the issues raised, http://cr.openjdk.java.net/~henryjen/jdk9/8033716/2/webrev/ - revert the clone method changes so that return

Re: [OpenJDK 2D-Dev] [9] Review request for 8023990: regression : postscript file size increase from 6u17

Hello Anton, now the fix looks fine to me. Thanks, Andrew On 1/29/2014 5:23 PM, anton nashatyrev wrote: Hello, Andrew, thanks for review in offline! Here is the corrected fix: http://cr.openjdk.java.net/~anashaty/8023990/webrev.01/

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8033223: Fix serial lint warnings in sun.{font, java2d[.*]}

Hello Joe, the fix published in the webrev (that contains two more classes comparing to the attached patch) looks fine to me. Thanks, Andrew On 1/30/2014 10:10 AM, Joe Darcy wrote: Hello, As another installment of addressing the serial warnings in the client libraries, please review my

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8032733: Fix cast lint warnings in client libraries

Hello Joe, the 'javax.imageio' part of the fix looks fine to me. Thanks, Andrew On 1/25/2014 11:10 PM, Joe Darcy wrote: Hello, Please review my large, but largely straightforward, changes to fix JDK-8032733: Fix cast lint warnings in client libraries

Re: [OpenJDK 2D-Dev] RFR: 8029628: Large amount of graphic artifacts

Hi Vadim, the change looks fine to me. Thanks, Andrew On 12/6/2013 11:24 AM, Vadim Pakhnushev wrote: Hello, Please review a fix for the https://bugs.openjdk.java.net/browse/JDK-8029628 http://cr.openjdk.java.net/~vadim/8029628/webrev.00/ Intel HD Graphics 2000/3000 seems to be not usable

Re: [OpenJDK 2D-Dev] [8] Review request for 8023990: regression : postscript file size increase from 6u17

Looks fine. Thanks, Andrew On 11/22/2013 7:24 PM, anton nashatyrev wrote: Hello, this is a duplicate request: could you please review the following fix: fix: http://cr.openjdk.java.net/~alitvinov/8023990/webrev.00 http://cr.openjdk.java.net/%7Ealitvinov/8023990/webrev.00 bug:

[OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8024767: [TEST] need test to cover JDK-7189452

Changeset: 76171168e894 Author:bae Date: 2013-11-27 15:15 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/76171168e894 8024767: [TEST] need test to cover JDK-7189452 Reviewed-by: ceisserer, bae Contributed-by: alexander.v.stepa...@oracle.com +

Re: [OpenJDK 2D-Dev] Please review JDK-8028584

Hello Jennifer, the fix looks fine to me. Thanks, Andrew On 11/26/2013 12:43 AM, Jennifer Godinez wrote: http://cr.openjdk.java.net/~jgodinez/8028584/webrev.00/ ClassCastException occurs when device uri is a file. Added a check for file and additional safeguard against cast exception.

Re: [OpenJDK 2D-Dev] request for review: JDK-8028722: XRender: Drawing strings with exactly 254 glyphs causes hangs

Hello Clemens, the fix looks fine to me. Thanks, Andrew On 11/20/2013 7:38 PM, Clemens Eisserer wrote: Hi, Please review my fix for JDK-8028722: XRender: Drawing strings with exactly 254 glyphs causes hangs available at http://cr.openjdk.java.net/~ceisserer/8028722/webrev.00/ A test is

Re: [OpenJDK 2D-Dev] RFR: Fix for 8027541: Fully transparent jframe becomes black.

Hello Phil, the change looks fine to me. Thanks, Andrew On 11/9/2013 2:29 AM, Phil Race wrote: http://cr.openjdk.java.net/~prr/8027541/ In the case where there is an alpha color on the window, the X11 pipeline looks at the color model of the GraphicsConfiguration and upgrades the surface to

Re: [OpenJDK 2D-Dev] Review request for 8024767: [TEST] need test to cover JDK-7189452

, Andrew Brygin wrote: Hi Alexander, the test looks fine to me. Thanks, Andrew On 9/13/2013 1:20 PM, alexander stepanov wrote: Hello, could you please review the fix for the following [TEST] bug: https://bugs.openjdk.java.net/browse/JDK-8024767 (sorry, the bug info isn't available at bugs.sun.com

Re: [OpenJDK 2D-Dev] Request for review: Additional fix for JDK-7159455

Hello Clemens, the change in XRPMBlitLoops.java looks good to me. The part of the fix in XRUtils.java should probably be ignored now. Thanks, Andrew On 10/18/2013 3:45 PM, Clemens Eisserer wrote: Another revision was required, available at:

[OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8026780: Crash on PPC and PPC v2 for Java_awt test suit

Changeset: 923f39485651 Author:bae Date: 2013-10-22 13:28 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/923f39485651 8026780: Crash on PPC and PPC v2 for Java_awt test suit Reviewed-by: prr, jchen ! src/share/native/sun/java2d/cmm/lcms/LCMS.c

Re: [OpenJDK 2D-Dev] request for review: xrender pipeline ignores center-coordinates of RadialGradient

Hello Clemens, I have played with the tests, and Java2D demo, and the fix looks fine to me. Thanks, Andrew On 10/20/2013 9:55 PM, Clemens Eisserer wrote: Hi, Ok, this starts to become embarrassing ... sorry for the review request spam recently. I was stressed that my changes would be

  1   2   3   >