Re: [OpenJDK 2D-Dev] RFR : 8249725 : testbug: ZeroWithStringBoundsTest.java needs update to copyright header.

+1. Thanks, Jay > On 20-Jul-2020, at 12:50 AM, Philip Race wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8249725 > > The copyright header is missing "All Rights Reserved". > This causes a failure in validation builds so we need to fix ASAP. > > diff > diff --git

Re: [OpenJDK 2D-Dev] RFR JDK-8246742: ServiceUI.printDialog does not support properties dialog

Hi Prasanta, I tested the fix in Mac and Windows and it works as mentioned. In http://hg.openjdk.java.net/jdk/client/file/754ec520eb4a/src/java.desktop/windows/classes/sun/print/Win32PrintService.java#l1688

Re: [OpenJDK 2D-Dev] RFR : 8248802: Add log helper methods to FontUtilities.java

Looks good to me. Thanks, Jay > On 06-Jul-2020, at 12:43 PM, Baesken, Matthias > wrote: > > Hello, please review this small change to font related logging . > > We have a lot of font logging calls in java.desktop that look similar to this > coding : > > if

Re: [OpenJDK 2D-Dev] RFR [XS]: 8248468: java/awt/font/DefaultFontTest/DefaultFontTest.java fails in SunFontManager.findFont2D

Looks good to me. Thanks, Jay > On 01-Jul-2020, at 12:10 PM, Baesken, Matthias > wrote: > > Ping … would be nice to get a review … > > From: Baesken, Matthias > Sent: Montag, 29. Juni 2020 10:06 > To: 2d-dev@openjdk.java.net > Subject: RFR [XS]: 8248468:

Re: [OpenJDK 2D-Dev] RFR: 8166038 BufferedImage methods getTileGridXOffset() and getTileGridYOffset() return a non 0 value for sub images

Hi Martin, There was no need for creating separate test case to override BufferedImage and see what happens but its good that we know the behaviour now. I had already approved webrev.01 and still +1 for webrev.01. And I think we should conclude the thread with Phil’s question about just

Re: [OpenJDK 2D-Dev] RFR [JDK15] : 8244818 : Java2D Queue Flusher crash while moving application window to external monitor

+1. Thanks, Jay > On 20-Jun-2020, at 7:55 AM, Sergey Bylokhov > wrote: > > +1 > > On 6/19/20 3:32 pm, Kevin Rushforth wrote: >> Looks good. >> +1 >> -- Kevin >> On 6/19/2020 3:23 PM, Philip Race wrote: >>> Bug : https://bugs.openjdk.java.net/browse/JDK-8244818 >>> Webrev :

Re: [OpenJDK 2D-Dev] RFR: 8240654 : ZGC can cause severe UI application repaint issues

;>> >>>>>> Can I get clarification here. >>>>>> >>>>>> > I do, and had to run with "-Dsun.java2d.uiScale=1" in order to see the >>>>>> > failure with LargeWindowPaintTest. >>>>

Re: [OpenJDK 2D-Dev] RFR: 8240654 : ZGC can cause severe UI application repaint issues

you needed the above >> property. >> If so we could just be looking at a similar anomaly as I saw with printing >> which uses a very large >> image - it reported failure but actually worked ! >> >> Also - for both of you - with the fix and without fo

Re: [OpenJDK 2D-Dev] RFR: 8240654 : ZGC can cause severe UI application repaint issues

> On 11-Jun-2020, at 8:03 PM, Philip Race wrote: > > > > On 6/11/20, 1:57 AM, Jayathirth D v wrote: >> >> Hi Phil, >> >> I tried tested the fix in my Windows 10 machine with Intel integrated UHD >> Graphics 620. >> >> LargeW

Re: [OpenJDK 2D-Dev] RFR: 8240654 : ZGC can cause severe UI application repaint issues

you print before > saying whether it passes or not. FWIW, I verified that the printing test on > my system was hitting the fallback code with the patch, but it seemed to > print correctly even without the patch. > > -- Kevin > > > On 6/11/2020 1:58 AM, Jayathi

Re: [OpenJDK 2D-Dev] RFR: 8240654 : ZGC can cause severe UI application repaint issues

Hi Phil, I tried tested the fix in my Windows 10 machine with Intel integrated UHD Graphics 620. LargeWindowPaintTest.java passes with/without fix in my machine. AlphaPrintTest.java without fix just opens up blank frame without any instructions and with fix it shows instructions for the test.

Re: [OpenJDK 2D-Dev] RFR: 8240654 : ZGC can cause severe UI application repaint issues

Typo : I tried tested -> I tried testing > On 11-Jun-2020, at 2:27 PM, Jayathirth D v wrote: > > Hi Phil, > > I tried tested the fix in my Windows 10 machine with Intel integrated UHD > Graphics 620. > > LargeWindowPaintTest.java passes with/without fix in my mac

Re: [OpenJDK 2D-Dev] RFR: 6949753 java/awt/print/PageFormat/PDialogTest.java needs update by removing a infinite loop

+1. Thanks, Jay > On 18-May-2020, at 10:46 AM, Philip Race wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-6949753 > > webrev : http://cr.openjdk.java.net/~prr/6949753/ > > > Buggy, manual

Re: [OpenJDK 2D-Dev] RFR: 8166038 BufferedImage methods getTileGridXOffset() and getTileGridYOffset() return a non 0 value for sub images

. Thanks, Jay > On 24-Apr-2020, at 6:38 PM, Martin Desruisseaux > wrote: > > Hello Jayathirth > > Le 24/04/2020 à 14:32, Jayathirth D v a écrit : > >> Then its better if we can include scenarios in test case(like using >> RenderedImage) to actually verify thi

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8242557: Add length limit for strings in PNGImageWriter

ngth = chunkLength - keyword.length() - 2; > if (compressedProfileLength <= 0) { > throw new IIOException("iCCP chunk length is not proper"); > } > > so chunkLength can be say, 100, keyWord.lenth = 79 so compressedProfileLength > = 100-79-2=19 so we will no

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8242557: Add length limit for strings in PNGImageWriter

tes from the chunk..It should also > limit it's reading to 1st 79 bytes (if the chunks we get from non-oracle > non-standard PNG writer is more than 79bytes) as per spec, no? > > Regards > Prasanta > On 30-Apr-20 2:01 PM, Jayathirth D v wrote: >> Hi Prasanta, >> >>

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8242557: Add length limit for strings in PNGImageWriter

ssume the same max length of 80 for the language tag for iTxt. >> The spec. doesn't specify a limit but I think 80 is more than generous here. >> >> +1 >> >> -phil. >> >> On 4/27/20, 9:59 AM, Jayathirth D v wrote: >>> >>> Hello All, >

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8242557: Add length limit for strings in PNGImageWriter

Update: “no limit on language tag” ---> “80 character limit on language tag”. > On 27-Apr-2020, at 11:15 PM, Jayathirth D v wrote: > > Hi Phil, > > Thanks for your approval. > I also noticed no limit on language tag in reader for iTXt and raised > JDK-8243674 <ht

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8242557: Add length limit for strings in PNGImageWriter

80 chars > there. > > I note we assume the same max length of 80 for the language tag for iTxt. > The spec. doesn't specify a limit but I think 80 is more than generous here. > > +1 > > -phil. > > On 4/27/20, 9:59 AM, Jayathirth D v wrote: >> >> Hello

[OpenJDK 2D-Dev] [15] RFR JDK-8242557: Add length limit for strings in PNGImageWriter

Hello All, Please review the following fix for JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-8242557 Webrev : http://cr.openjdk.java.net/~jdv/8242557/webrev.00/ Issue : PNG

Re: [OpenJDK 2D-Dev] RFR: 8197797: Test java/awt/Graphics2D/DrawString/RotTransText.java fails

+1. Thanks, Jay > On 27-Apr-2020, at 5:29 AM, Philip Race wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8197797 > webrev : http://cr.openjdk.java.net/~prr/8197797/ > > I can't reproduce this anywhere despite trying hard. > The closest is I saw 8u221 on mac 10.13.6 show *slight*

Re: [OpenJDK 2D-Dev] RFR: 8166038 BufferedImage methods getTileGridXOffset() and getTileGridYOffset() return a non 0 value for sub images

gt; > Le 17/04/2020 à 12:58, Jayathirth D v a écrit : > >> I have a question regarding test case. Why test has to check whether we are >> getting negative value or not and then calculate whether the tileGridOffset >> is 0. From different function

Re: [OpenJDK 2D-Dev] RFR: 8166038 BufferedImage methods getTileGridXOffset() and getTileGridYOffset() return a non 0 value for sub images

Hi, Change looks good to me. I have a question regarding test case. Why test has to check whether we are getting negative value or not and then calculate whether the tileGridOffset is 0. From different function's specification in BufferedImage I see that there are no multiple tiles support. I

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

Thanks for clarification. +1 for http://cr.openjdk.java.net/~prr/8242004.1/ <http://cr.openjdk.java.net/%7Eprr/8242004.1/> Regards, Jay > On 17-Apr-2020, at 4:35 AM, Philip Race wrote: > > > > On 4/12/20, 11:03 PM, Jayathirth D v wrote: >> >> Hi Phil, &g

Re: [OpenJDK 2D-Dev] RFR: 8233006: freetype incorrectly adjusts advances when emboldening rotated glyphs

Thanks for the clarification. Change looks good to me. Regards, Jay > On 17-Apr-2020, at 4:04 AM, Philip Race wrote: > > > > On 4/15/20, 10:32 PM, Jayathirth D v wrote: >> Hi Phil, >> >> Thanks for the detailed evaluation in bug and here. >> Change lo

Re: [OpenJDK 2D-Dev] [15] RFR JDK-8195841: PNGImageReader.readNullTerminatedString() doesnt check for non-null terminated strings with length equal to maxLen

browse/JDK-8195841 > <https://bugs.openjdk.java.net/browse/JDK-8195841> > > -phil. > > On 4/13/20, 2:40 AM, Jayathirth D v wrote: >> >> Hello All, >> >> Please review the following fix for JDK 15: >> >> Bug : https://bugs.openjdk.java.n

Re: [OpenJDK 2D-Dev] RFR: 8196181 sun/java2d/GdiRendering/InsetClipping.java fails

Looks good to me. Thanks, Jay > On 13-Apr-2020, at 6:57 PM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for jdk/client. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8196181 > Fix: http://cr.openjdk.java.net/~serb/8196181/webrev.01 > > The test tries to take a color of

Re: [OpenJDK 2D-Dev] RFR: 8233006: freetype incorrectly adjusts advances when emboldening rotated glyphs

Hi Phil, Thanks for the detailed evaluation in bug and here. Change looks good to me. Newly added file has copyright year 2018. Please update it before pushing. I ran smaller set of rotate tests for font and they all pass with this change. Does this new change handle non-bold use cases also as

[OpenJDK 2D-Dev] [15] RFR JDK-8195841: PNGImageReader.readNullTerminatedString() doesnt check for non-null terminated strings with length equal to maxLen

Hello All, Please review the following fix for JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-8195841 Webrev : http://cr.openjdk.java.net/~jdv/8195841/ Issue : PNGImageReader doesn’t check

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

Typo : It's good that we have removed *unused* inverseTx code. > On 13-Apr-2020, at 11:33 AM, Jayathirth D v wrote: > > Hi Phil, > > Thanks for the clarification. > It's good that we have removed used inverseTx code. > > Since we don’t have inverseTx check now, do we n

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

t; > Updated webrev : http://cr.openjdk.java.net/~prr/8242004.1/ > <http://cr.openjdk.java.net/~prr/8242004.1/> > > -phil. > > On 4/10/20, 8:41 AM, Jayathirth D v wrote: >> >> Hi Phil, >> >> I see your point of allowing queries on text layout witho

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

//cr.openjdk.java.net/%7Eprr/8242004/> > > -phil. > > > On 4/9/20, 7:00 PM, Jayathirth D v wrote: >> >> Hi Phil, >> >> Please share webrev link, you have added JBS link for webrev. >> I went to path where you usually share webrev's and found >&g

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

Hi Phil, Please share webrev link, you have added JBS link for webrev. I went to path where you usually share webrev's and found http://cr.openjdk.java.net/~prr/8242004/ Thanks, Jay > On 10-Apr-2020, at 12:49 AM, Philip Race wrote: > > Any takers

Re: [OpenJDK 2D-Dev] RFR: 8223935: PIT: java/awt/font/WindowsIndicFonts.java fails on windows10

Looks good to me. Thanks, Jay > On 17-Mar-2020, at 10:04 PM, Philip Race wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8223935 > Webrev: http://cr.openjdk.java.net/~prr/8223935/ > > WindowsIndicFonts has been failing randomly depending on > whether a test system has the Indic fonts

Re: [OpenJDK 2D-Dev] [15] RFR JDK-6532025: GIF reader throws misleading exception with truncated images

} catch (IIOException e) { > 52 // do nothing we expect IIOException but we should not > 53 // throw IndexOutOfBoundsException > 54 System.out.println(e.toString()); > 55 System.out.println("Caught IIOException ignore it&quo

Re: [OpenJDK 2D-Dev] [15] RFR JDK-6532025: GIF reader throws misleading exception with truncated images

t; >> On Mar 5, 2020, at 9:18 AM, Jayathirth D v > <mailto:jayathirth@oracle.com>> wrote: >> >> Hello Brian, >> >> Thanks for the review. GIF stream in regression test case would match >> warn.gif stream behaviour that’s why it going into GIFImageRe

Re: [OpenJDK 2D-Dev] [15] RFR JDK-6532025: GIF reader throws misleading exception with truncated images

Mar-2020, at 10:20 PM, Brian Burkhalter > wrote: > > Hello Jay, > > The source fix looks OK to me. I get the same exception as in the bug > description when I run the test against my unpatched local JDK 15 build. > > Thanks, > > Brian > >>

[OpenJDK 2D-Dev] [15] RFR JDK-6532025: GIF reader throws misleading exception with truncated images

Hello All, Please review the following fix for JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-6532025 Webrev : http://cr.openjdk.java.net/~jdv/6532025/webrev.00/ Root cause : When

Re: [OpenJDK 2D-Dev] RFR: 8219578 No associated icon for the leaf node of Jtree

Change looks good to me. Thanks, Jay -Original Message- From: Philip Race Sent: Thursday, March 5, 2020 7:26 AM To: Sergey Bylokhov Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>; swing-...@openjdk.java.net Subject: Re: RFR: 8219578 No associated icon for the leaf

Re: [OpenJDK 2D-Dev] [14] RFR JDK-8235147: Release HDC from passiveDCList sooner

Hi Alexey, Change looks good to me. I think this change should be in awt-dev, so I have added the same for future reference. Thanks, Jay > On 24-Feb-2020, at 7:15 PM, Alexey Ivanov wrote: > > I'm still waiting for a second reviewer. > > Anyone? > Thank you in advance! > > > On 17/02/2020

Re: [OpenJDK 2D-Dev] RFR: 8238942: Rendering artifacts with LCD text and fractional metrics

Change looks good to me. And we have good amount of time to notice any pixel accuracy issues. Thanks, Jay > On 12-Feb-2020, at 9:45 AM, Philip Race wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8238942 > webrev: http://cr.openjdk.java.net/~prr/8238942/ > > As discussed in the bug,

Re: [OpenJDK 2D-Dev] [15] Review Request: 5085520 Inconsistency in spec for RenderingHints.entrySet()

Change looks fine. Thanks, Jay > On 22-Jan-2020, at 10:49 PM, Phil Race wrote: > > Looks fine. You could have added that the Set is unmodifiable but it is not > critical. > > -phil. > > On 1/20/20 9:02 PM, Sergey Bylokhov wrote: >> Hello. >> Please review the fix for JDK 15. >> >> Bug:

Re: [OpenJDK 2D-Dev] [14] Review Request: 8235520 [macosx] Delete NSView based direct rendering mechanism

Changes are fine. Thanks, Jay > On 07-Dec-2019, at 5:53 AM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for JDK 14. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8235520 > Fix: http://cr.openjdk.java.net/~serb/8235520/webrev.00 > > This is a part of the effort to clean

Re: [OpenJDK 2D-Dev] [14] Review Request: 8235547 Video memory leak in the OGL pipeline on macOS

+1. Thanks, Jay > On 10-Dec-2019, at 12:48 AM, Philip Race wrote: > > OK, +1 > > -phil. > > On 12/9/19, 11:15 AM, Sergey Bylokhov wrote: >> On 12/9/19 10:23 am, Phil Race wrote: >>> How did this get found ? Is it a regression caused by some other bug fix ? >> >> I had run the test for the

Re: [OpenJDK 2D-Dev] [13] RFR JDK-8224824:ProblemList java/awt/Color/AlphaColorTest failure in linux_x64

Changes are fine. Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Monday, May 27, 2019 3:03 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] [13] RFR JDK-8224824:ProblemList java/awt/Color/AlphaColorTest failure in linux_x64 Hi All, AlphaColorTest is failing in mach5 linux

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

Hi, I was also looking into this test case under https://bugs.openjdk.java.net/browse/JDK-8224969 I will close it as duplicate of this bug. I saw that in case of Ubuntu and Mac we are throwing "java.awt.print.PrinterException: No print service found. " but I in case of Windows test just

Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links in ImageInputStream.java & ImageOutputStream.java

Hi Alexey, Thanks for the review. I will add space before pushing the change. Regards, Jay -Original Message- From: Alexey Ivanov Sent: Thursday, December 06, 2018 12:45 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links

[OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214876: Add "intermittent" key for imageio/stream/StreamCloserLeak/run_test.sh

Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8214876 Webrev : http://cr.openjdk.java.net/~jdv/8214876/webrev.00/ I have not added JBS bug id under @bug since it is a trivial test change. Thanks, Jay

[OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links in ImageInputStream.java & ImageOutputStream.java

Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8214817 Webrev : http://cr.openjdk.java.net/~jdv/8214817/webrev.00/ Thanks, Jay

[OpenJDK 2D-Dev] [12] RFR JDK-8213050: simpleTagLabel before is not getting generated properly

Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8213050 Webrev : http://cr.openjdk.java.net/~jdv/8213050/webrev.00/ Issue : Markup corrector tidy is throwing issues in files bmp_metadata.html, wbmp_metadata.html &

Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond

Hi Sergey, Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8212875/webrev.02/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, November 27, 2018 1:29 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp

Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond

for review: http://cr.openjdk.java.net/~jdv/8212875/webrev.01/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Thursday, November 22, 2018 6:21 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond Hi

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt CRC for IEND chunk throws IIOException

viewer) also work this way and they are not worried about CRC for IEND chunk. Thanks, Jay -Original Message- From: Krishna Addepalli Sent: Tuesday, November 20, 2018 2:32 PM To: Jayathirth D V; 2d-dev@openjdk.java.net Subject: RE: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

Thanks Sergey for the review. I need one more review. Please review the latest webrev: http://cr.openjdk.java.net/~jdv/8211795/webrev.01/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Saturday, November 17, 2018 3:35 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D

[OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond

Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8212875 Webrev : http://cr.openjdk.java.net/~jdv/8212875/webrev.00/ TIFF Technical Note #2 link is broken at many places in our code. I tried finding replacement for broken link,

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

e made change to use inputBands data for creation and use of scale array. Ran complete imageio jtreg and JCK tests there are no failures. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8211795/webrev.01/ Thanks, Jay -Original Message----- From: Jayathirth D V Sent: We

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt CRC for IEND chunk throws IIOException

Thanks Sergey for the approval. Need one more review. Please review the webrev : http://cr.openjdk.java.net/~jdv/8211422/webrev.01/ Regards, Jay -Original Message- From: Sergey Bylokhov Sent: Thursday, November 15, 2018 10:58 PM To: Jayathirth D V; 2d-dev@openjdk.java.net Subject: Re

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt CRC for IEND chunk throws IIOException

of chunkCRC will not be used anywhere in the logic. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8211422/webrev.01/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Wednesday, November 14, 2018 4:31 AM To: Jayathirth D V; 2d-dev@openjdk.java.net Subject: Re

[OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8211795 Webrev: http://cr.openjdk.java.net/~jdv/8211795/webrev.00/ Issue : When we read PNG image having tRNS chunk and it needs bitDepth adjustment then we throw

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file

Hello All, Gentle reminder for review. Thanks, Jay From: Jayathirth D V Sent: Tuesday, October 16, 2018 6:37 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file Hello All, Ple

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt CRC for IEND chunk throws IIOException

Hello All, Gentle reminder for review. Thanks, Jay From: Jayathirth Rao Sent: Tuesday, October 23, 2018 7:09 PM To: 2d-dev@openjdk.java.net Subject: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt CRC for IEND chunk throws IIOException Hello All, Please

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

n or throw something like UnsupportedOperationException we can do it in separate bug. Please let me know I will raise separate bug for the same. Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Friday, November 09, 2018 12:41 AM To: Jayathirth D V; Philip Race; Bria

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

Hello All, I am replying to the last mail in this thread. >From the test case we can see that it is not strict about pixel data which was >transferred during DnD. It is just making sure we are able to do DnD for all >native image formats. In test case ImageTransferer.

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

Hello All, Forgot to update ProblemList. Please find updated webrev with ProblemList change also : http://cr.openjdk.java.net/~jdv/8176556/webrev.01/ Thanks, Jay From: Jayathirth D V Sent: Wednesday, November 07, 2018 3:42 PM To: 2d-dev; awt-...@openjdk.java.net Subject

[OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

Hello All, Please review the following fix in JDK12 : Bug : https://bugs.openjdk.java.net/browse/JDK-8176556 Webrev : http://cr.openjdk.java.net/~jdv/8176556/webrev.00/ Issue : When we run java/awt/dnd/ImageTransferTest/ImageTransferTest.java if fails to get ImageWriter(Service

Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails

Hi Fairoz, @requires tag usage in jtreg : https://openjdk.java.net/jtreg/tag-spec.html#requires_names I think jtreg tag doesn’t support mentioning input file. Also I don’t know why it was mentioned as "@requires BMP8BPPLoadTest.PNG" when input file in code was "new

[OpenJDK 2D-Dev] [12] RFR JDK-8213130: Update ProblemList after verification of jtreg tests in Win 7

Hello All, Please review the following fix in JDK 12: Bug : https://bugs.openjdk.java.net/browse/JDK-8213130 Webrev : http://cr.openjdk.java.net/~jdv/8213130/webrev.00/ These are the test failures/errors which happen when they are run individually. All the failures/erros are

[OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file

Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8212116 Webrev: http://cr.openjdk.java.net/~jdv/8212116/webrev.00/ Issue : When we try to read PNG image with no text in tEXt chunk we throw IIOException. Root cause : While

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212040: Compilation error due to wrong usage of NSPrintJobDispositionValue in mac10.12

Hi Prasanta,   Changes are fine.   Thanks, Jay   From: Prasanta Sadhukhan Sent: Thursday, October 11, 2018 1:40 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] [12] RFR JDK-8212040: Compilation error due to wrong usage of NSPrintJobDispositionValue in mac10.12   Hi All, Please review a build

Re: [OpenJDK 2D-Dev] RFR: 8208466: Fix potential memory leak in harfbuzz shaping

Hi Phil, Changes are fine. Thanks, Jay -Original Message- From: Philip Race Sent: Saturday, July 28, 2018 11:38 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] RFR: 8208466: Fix potential memory leak in harfbuzz shaping bug: https://bugs.openjdk.java.net/browse/JDK-8208466 webrev:

Re: [OpenJDK 2D-Dev] RFR: 8204391: Colors with alpha are painted incorrectly on Linux

Hi Phil, Thanks for fixing the regression introduced by https://bugs.openjdk.java.net/browse/JDK-8176795 . I went through the changes present in http://cr.openjdk.java.net/~prr/8204931/ and it looks fine. I have added detail review summary in the bug itself. We can also ask Clemens to take a

Re: [OpenJDK 2D-Dev] [11] Review Request: 8203027 Open source tests for "java.awt.geom"

Hi Sergey, +1. In NotConvexPieTest.java please add space between words for "String failText" before pushing. No need for another webrev. Thanks, Jay -Original Message- From: Phil Race Sent: Thursday, May 17, 2018 3:46 AM To: Sergey Bylokhov; 2d-dev; Jayathirth D v Subjec

Re: [OpenJDK 2D-Dev] [11] Review Request: 8202301 Add tests related to JDK-8196572 to the ProblemList

+1 -Original Message- From: Sergey Bylokhov Sent: Thursday, April 26, 2018 11:02 AM To: 2d-dev Subject: [OpenJDK 2D-Dev] [11] Review Request: 8202301 Add tests related to JDK-8196572 to the ProblemList Hello. Please review small update for jdk11. Bug:

Re: [OpenJDK 2D-Dev] [11] RFR JDK-5109146: PNGMetadata Background color initialization from standard metadata is incomplete

Hello All, Since changes related to JDK-6574555 is pushed. Please find new webrev which captures test case changes over JDK-6574555. http://cr.openjdk.java.net/~jdv/5109146/webrev.01/ Thanks, Jay From: Jayathirth D V Sent: Tuesday, April 17, 2018 3:34 PM To: 2d-dev Subject

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

Hi Prahalad, Thanks for the review. I have updated the test case to dispose the image reader. Please find updated webrev: http://cr.openjdk.java.net/~jdv/6574555/webrev.02/ Regards, Jay From: Prahalad Kumar Narayanan Sent: Tuesday, April 17, 2018 11:50 AM To: Jayathirth D V

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

Hi Phil, Thanks for your inputs. I have modified the test case to use ByteArrayOutput/InputStream. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/6574555/webrev.01/ Regards, Jay From: Phil Race Sent: Wednesday, April 11, 2018 10:40 PM To: Jayathirth D V

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

: Phil Race Sent: Wednesday, April 11, 2018 10:23 PM To: Jayathirth D V; Prahalad Kumar Narayanan; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images http://cr.openjdk.java.net/~jdv/6788458/webrev.07/src/java.desktop

[OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

Hello All, Please review the following fix in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-6574555 Webrev : http://cr.openjdk.java.net/~jdv/6574555/webrev.00/ Issue: PNGImageWriter. write_bKGD() function sets incorrect R, G, B value when IHDR colortype and bKGD colortype

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

http://cr.openjdk.java.net/~jdv/6788458/webrev.07/ Thanks, Jay -Original Message- From: Prahalad Kumar Narayanan Sent: Monday, April 09, 2018 2:23 PM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

rev.06/ Thanks, Jay -Original Message- From: Prahalad Kumar Narayanan Sent: Friday, April 06, 2018 1:42 PM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images Hello Jay Good day to y

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

an Sent: Monday, April 02, 2018 12:03 PM To: Krishna Addepalli; Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images Hello Jay Good day to you. I looked into the latest code changes. Please find my review obs

Re: [OpenJDK 2D-Dev] [11] JDK-8200526 Test sun/java2d/marlin/ClipShapeTest.java times out

Hi Laurent,   I ran the updated test case in my Windows 7 machine and it passes without any time out. +1.   Please update copyright year content to “2017, 2018” before pushing, no need for another webrev.   Thanks, Jay   From: Laurent Bourgès [mailto:bourges.laur...@gmail.com] Sent:

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

ough them and update accordingly later. Thanks, Jay From: Krishna Addepalli Sent: Monday, April 02, 2018 11:40 AM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images Hmmm, th

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

value. The initialization of tRNS_colorType change can be considered as newly added check. Thanks, Jay From: Krishna Addepalli Sent: Monday, April 02, 2018 9:56 AM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

ednesday, March 28, 2018 11:52 AM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images Hi Jay, I have some points as below: 1. I suggest to rename considerTransparentPixel as isAlph

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

From: Jayathirth D V Sent: Wednesday, March 28, 2018 8:28 AM To: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images Hello All, I just realized that the test case Read16BitPNGWithTRNSChunk.java is creating

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

Read16BitPNGWithTRNSChunk.java to reflect this small change. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/6788458/webrev.01/ Thanks, Jay From: Jayathirth D V Sent: Tuesday, March 27, 2018 6:51 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader

[OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

Hello All, Please review the following solution in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-6788458 Webrev : http://cr.openjdk.java.net/~jdv/6788458/webrev.00/ Issue: When we try to read non-indexed RGB PNG image having transparent pixel information in tRNS chunk,

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 when passing null values

can take that in separate bug. Thanks, Jay -Original Message- From: Philip Race Sent: Tuesday, March 27, 2018 2:39 AM To: Jayathirth D V Cc: Prahalad Kumar Narayanan; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 whe

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 when passing null values

Hi Prahalad, Change looks fine. Test case works properly before and after the code change. Since we are touching getNumThumbnailsSupported() function and it is only overridden in JPEGImageWriter we can add override annotation for the same. Thanks, Jay -Original Message- From: Prahalad

Re: [OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not supported in BMPImageReader

--- From: Prahalad Kumar Narayanan Sent: Wednesday, March 21, 2018 2:33 PM To: Philip Race; Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not supported in BMPImageReader Hello Jay Good day to yo

Re: [OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not supported in BMPImageReader

DER & BITMAPV3INFOHEADER also. Please let us know your inputs. Thanks, Jay From: Phil Race Sent: Monday, March 19, 2018 11:07 PM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not suppo

Re: [OpenJDK 2D-Dev] [11] RFR [JDK-6686236] GIF native IIOMetadata assumes characterCellWidth/Height as 2bytes

Hi Prahalad, Verified the code changes with test case. Change looks fine. Thanks, Jay -Original Message- From: Phil Race Sent: Friday, March 16, 2018 9:21 PM To: Prahalad Kumar Narayanan; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR [JDK-6686236] GIF native IIOMetadata assumes

[OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not supported in BMPImageReader

Hello All, Please review the following solution in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-7031957 Webrev : http://cr.openjdk.java.net/~jdv/7031957/webrev.00/ Issue: If we try to read any BMP image of DIB header type BITMAPV2INFOHEADER/ BITMAPV3INFOHEADER, we get

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-8198613] Test cases result in failure or timeout when run with OpenGL backend

Hi Prahalad, I ran all the test cases after change in my Windows 7 intel i5 machine. All the test cases pass, also it looks like we have changes in 3 manual test cases. 1) java/awt/image/VolatileImage/CustomCompositeTest.java didn't fail in my machine, may be some specific configuration leads

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

Hi Clemens, Forked repo for all the latest client changes is : http://hg.openjdk.java.net/jdk/client Thanks, Jay -Original Message- From: Clemens Eisserer [mailto:linuxhi...@gmail.com] Sent: Tuesday, February 20, 2018 7:04 PM To: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [10] RFR

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

Hi Sergey & Prahalad, Thanks for your inputs. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8191023/webrev.02/ Regards, Jay -Original Message- From: Prahalad Kumar Narayanan Sent: Thursday, January 25, 2018 3:23 PM To: Sergey Bylokhov; Jayathirth D V; 2d

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

inal Message- From: Prahalad Kumar Narayanan Sent: Tuesday, January 23, 2018 8:24 AM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size Hello Jay I looked into the bug and the fix. The

[OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

Hello All, Please review the following fix in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-8191023 Webrev : http://cr.openjdk.java.net/~jdv/8191023/webrev.00/ Note : Submitter has raised 3 bugs JDK-8191023 , JDK-8191076 , JDK-8191109 with similar issue but in 3 different

[OpenJDK 2D-Dev] [11] RFR JDK-8195131: Dead code removal for changes present in JDK-8176795

Hello All, Please review the following fix in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-8195131 Webrev : http://cr.openjdk.java.net/~jdv/8195131/webrev.00/ Issue: After changes present in https://bugs.openjdk.java.net/browse/JDK-8176795 the Non-Premultiplied alpha

<    1   2   3   4   5   >