[OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel

Hi, I have updated the changes to select proper Buffer Image type based on source transparency and not just using ARGB directly. Please find the updated webrev for review: http://cr.openjdk.java.net/~jdv/8139183/webrev.01/ Thanks, Jay From: Jayathirth D V Sent: Wednesday

[OpenJDK 2D-Dev] Review Request for JDK-8139183 : drawImage misses background's alpha channel

Hi, Please review the following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8139183 Webrev : http://cr.openjdk.java.net/~jdv/8139183/webrev.00/ Issue : When we scale any buffered image using drawImage() API which takes scale coordinates we are losing alpha

Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel colour when converting images to TYPE_BYTE_INDEXED

Hi Jim, Gentle reminder. Please let me your inputs after testing. Thanks, Jay -Original Message- From: Jayathirth D V Sent: Tuesday, February 16, 2016 10:03 PM To: Jim Graham Cc: 2d-dev@openjdk.java.net; Philip Race; Prasanta Sadhukhan Subject: RE: [OpenJDK 2D-Dev] Review Request

Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel colour when converting images to TYPE_BYTE_INDEXED

: Friday, February 12, 2016 4:05 AM To: Jayathirth D V; 2d-dev@openjdk.java.net; Philip Race; Prasanta Sadhukhan Subject: Re: [OpenJDK 2D-Dev] Review Request for JDK-7116979 : Unexpected pixel colour when converting images to TYPE_BYTE_INDEXED Hi Jayathirth, Did you do any performance analysis

Re: [OpenJDK 2D-Dev] Review request for JDK-8147413 : api/java_awt/Image/MultiResolutionImage/index.html\#MultiResolutionRenderingHints[test_VALUE_RESOLUTION_VARIANT_BASE] started to fail

approval? Thanks, Jay -Original Message- From: Alexander Scherbatiy Sent: Friday, January 22, 2016 5:05 PM To: Jim Graham; Phil Race; Jayathirth D V Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review request for JDK-8147413 : api/java_awt/Image/MultiResolutionImage/index.html

[OpenJDK 2D-Dev] Review request for JDK - 8146972 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hi, This is backport of fix from JDK 9 bug : https://bugs.openjdk.java.net/browse/JDK-8041501 to JDK 8u. Changes in JDK9 are already checked in. Please review the fix: Bug : https://bugs.openjdk.java.net/browse/JDK-8146972 Webrev :

[OpenJDK 2D-Dev] Review request for JDK-8144744 : ImageWriter.replacePixels() specification is incorrect regarding null ImageWriteParam

Hi, Please review a simple fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8144744 Webrev : http://cr.openjdk.java.net/~jdv/8144744/webrev.00/ Issue : Specification of ImageWriter.replacePixels() mentions that Illegal argument exception will be thrown if argument

Re: [OpenJDK 2D-Dev] Review request for JDK-8143562: JPEG reader returns null for getRawImageType()

Thanks for the review Phil. Can I get one more review for new webrev : HYPERLINK "http://cr.openjdk.java.net/%7Ejdv/8143562/webrev.01/"http://cr.openjdk.java.net/~jdv/8143562/webrev.01/ Regards, Jay From: Phil Race Sent: Wednesday, December 16, 2015 12:00 AM To: Jayathirth

Re: [OpenJDK 2D-Dev] [9] RFR: Test closed/javax/print/attribute/Services_getDocFl.java fails with NullpointerException (8040139)

Fix looks good to me.   From: prasanta sadhukhan Sent: Thursday, December 10, 2015 1:40 PM To: Philip Race; Sergey Bylokhov Cc: 2d-dev@openjdk.java.net; Rajeev Chamyal Subject: Re: [OpenJDK 2D-Dev] [9] RFR: Test closed/javax/print/attribute/Services_getDocFl.java fails with

Re: [OpenJDK 2D-Dev] [9] RFR: Test closed/javax/print/attribute/Services_getDocFl.java fails with NullpointerException (8040139)

one Doc Flavor).   By doing this we will avoid NPE. Also having user to select another printer from dialog(if selected printer is not available) is better than throwing NPE. Present changes are fine.   Thanks, Jay   From: Jayathirth D V Sent: Thursday, December 10, 2015 5:10 PM To: Prasanta

[OpenJDK 2D-Dev] Review request for JDK-6967419 : IndexOutOfBoundsException when drawing PNGs

- From: Sergey Bylokhov Sent: Wednesday, December 02, 2015 12:43 AM To: Jayathirth D V; Philip Race Cc: 2d-dev@openjdk.java.net Subject: Re: [OpenJDK 2D-Dev] Review request for JDK-6967419 : IndexOutOfBoundsException when drawing PNGs Hi, Jay. Can you please check other writers and confirm

[OpenJDK 2D-Dev] Review request for JDK-8143562: JPEG reader returns null for getRawImageType()

Hi, Please review following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8143562 Webrev : http://cr.openjdk.java.net/~jdv/8143562/webrev.00/ Issue : We are getting null for ImageTypeSpecifier when we use getRawImageType() API for YCbCr Image. Root cause : When

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

: Tuesday, November 24, 2015 2:08 AM To: Jayathirth D V Cc: Prasanta Sadhukhan; 2d-dev@openjdk.java.net Subject: Re: Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header Rather than adding a comment block, it seems you need to edit the preceding one

[OpenJDK 2D-Dev] Review request for JDK-8074967: JPEGImageReader incorrectly identifies YCbCr JPEGs as RGB in standard metadata

/8074967/webrev.01/ Please review. Thanks, Jay From: Jayathirth D V Sent: Thursday, November 19, 2015 3:19 PM To: Philip Race; Prasanta Sadhukhan; 2d-dev@openjdk.java.net Subject: Review request for JDK-8074967: JPEGImageReader incorrectly identifies YCbCr JPEGs as RGB in standard

[OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hello All, Please review following fix in JDK9: Bug : https://bugs.openjdk.java.net/browse/JDK-8041501 Webrev : http://cr.openjdk.java.net/~jdv/8041501/webrev.00/ Issue : Pink discoloration when we read JPEG images without JFIF & EXIF header and having no subsampling. Root

Re: [OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hi Prasanta, Thanks for suggestion. I have made related changes and updated the Webrev. Webrev : http://cr.openjdk.java.net/~jdv/8041501/webrev.01/ Please review. Thanks, Jay From: prasanta sadhukhan Sent: Monday, November 23, 2015 4:43 PM To: Jayathirth D V; 2d-dev

[OpenJDK 2D-Dev] Review request for JDK - 8041501 : ImageIO reader is not capable of reading JPEGs without JFIF header

Hi Prasanta, Removed repeated usage of getWidth() and getHeight(). Please review. http://cr.openjdk.java.net/~jdv/8041501/webrev.02/ Thanks, Jay From: prasanta sadhukhan Sent: Monday, November 23, 2015 5:15 PM To: Jayathirth D V Cc: Philip Race; 2d-dev@openjdk.java.net Subject

[OpenJDK 2D-Dev] Review request for JDK-8074967: JPEGImageReader incorrectly identifies YCbCr JPEGs as RGB in standard metadata

Hi Phil/Prasanta, Please review following fix in jdk9: Bug : https://bugs.openjdk.java.net/browse/JDK-8074967 Webrev : http://cr.openjdk.java.net/~rchamyal/jay/8074967/webrev.00/ Bug : JPEGImageReader incorrectly identifies YCbCr JPEGs as RGB in standard metadata Root cause :

Re: [OpenJDK 2D-Dev] Review request for JDK-6967419 : IndexOutOfBoundsException when drawing PNGs

alue, will not result in IndexOutOfBoundsException and ios.close() will be performed properly. Please let us know your inputs. Thanks, Jay From: Phil Race Sent: Tuesday, November 17, 2015 3:22 AM To: Jayathirth D V Cc: Prasanta Sadhukhan; 2d-dev@openjdk.java.net Subject: Re: Review req

[OpenJDK 2D-Dev] Review request for JDK-6967419 : IndexOutOfBoundsException when drawing PNGs

Hi Phil, I have added public evaluation in bug. Please review. Thanks, Jay From: Philip Race Sent: Friday, November 13, 2015 12:11 AM To: Jayathirth D V Cc: Prasanta Sadhukhan; 2d-dev@openjdk.java.net Subject: Re: Review request for JDK-6967419 : IndexOutOfBoundsException when

Re: [OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

regarding the typo in "spacing". Please find updated Webrev : http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.06/ Please review so that we can push the change. Thanks, Jay -Original Message- From: Vadim Pakhnushev Sent: Monday, October 19, 2015 4:03 PM To: Jayathirth D

Re: [OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

Hi Vadim, Thanks for the review. I have made suggested changes. Updated Webrev : http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.05/ Please review. Thanks, Jay -Original Message- From: Vadim Pakhnushev Sent: Friday, October 16, 2015 8:15 PM To: Jayathirth D V; Sergey Bylokhov

Re: [OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

rchamyal/jay/7182758/webrev.07/ Please review. Thanks, Jay -Original Message- From: Vadim Pakhnushev Sent: Monday, October 19, 2015 4:50 PM To: Jayathirth D V; Sergey Bylokhov; 2d-dev@openjdk.java.net; Philip Race Subject: Re: [OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata

Re: [OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

Hello All, Can I get one more review please. Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Thursday, October 15, 2015 6:05 PM To: Jayathirth D V; 2d-dev@openjdk.java.net; Philip Race Subject: Re: Review request for JDK-7182758: BMPMetadata returns invalid

[OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

Hi Sergey, I have made suggested changes. Please find updated Webrev link: http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.03/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, October 13, 2015 9:06 PM To: Jayathirth D V; 2d-dev@openjdk.java.net; Philip Race

[OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

Hello All, Removed Trailing whitespace present in code. Please find updated webrev link: http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.02/ Thanks, Jay From: Jayathirth D V Sent: Monday, October 12, 2015 2:15 PM To: 2d-dev@openjdk.java.net; Philip Race; Sergey

[OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

Hello All, Made small change on how we need to represent floating point constant in Java(1000.0 -> 1000.0F). Please find updated Webrev link: Webrev : http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.01/ Please review. Thanks, Jay From: Jayathirth D V S

[OpenJDK 2D-Dev] Review request for JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing

Hello All, Please review following fix in jdk9: Bug : https://bugs.openjdk.java.net/browse/JDK-7182758 Webrev : http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.00/ Bug : BMPMetadata returns invalid PhysicalPixelSpacing Root cause : Whenever XPixelsPerMter or

Re: [OpenJDK 2D-Dev] Review request for JDK-8066904: NullPointerExcpetion when calling ImageIO.read() with corrupt BMP

Hello All, Gentle Reminder. Please review the changes. Thanks, Jay On 10/6/2015 12:57 PM, Jayathirth D v wrote: Hello All, We noticed that jtreg tag "@run" was not matching main class name for test file. So made relevant change only in comment's section of test file. Please fi

Re: [OpenJDK 2D-Dev] Review request for JDK-8066904: NullPointerExcpetion when calling ImageIO.read() with corrupt BMP

15 9:51 AM, Jayathirth D v wrote: Hi Sergey, Thanks for review. Hello All, I need one more review for this patch. Please review. Thanks, Jay On 10/5/2015 7:01 PM, Sergey Bylokhov wrote: Hi, Jay. The fix looks fine to me. On 05.10.15 13:17, Jayathirth D v wrote: Hello All, _Please review fol

Re: [OpenJDK 2D-Dev] Review request for JDK-8066904: NullPointerExcpetion when calling ImageIO.read() with corrupt BMP

Hi Sergey, Thanks for review. Hello All, I need one more review for this patch. Please review. Thanks, Jay On 10/5/2015 7:01 PM, Sergey Bylokhov wrote: Hi, Jay. The fix looks fine to me. On 05.10.15 13:17, Jayathirth D v wrote: Hello All, _Please review following fix in jdk9:_ _Bug

[OpenJDK 2D-Dev] Review request for JDK-8066904: NullPointerExcpetion when calling ImageIO.read() with corrupt BMP

Hello All, _Please review following fix in jdk9:_ _Bug:_ https://bugs.openjdk.java.net/browse/JDK-8066904/ _Webrev:_ http://cr.openjdk.java.net/~rchamyal/jay/8066904/webrev.00/ _Bug:_ NullPointerException when calling

<    1   2   3   4   5