Re: [OpenJDK 2D-Dev] RFR: 8230672: Spec. for FontMetrics.getMaxAdvance is too prescriptive.

oosen up the spec. a lot to reflect reality. > > I considered deprecating the method but there isn't any easy replacement, > so it would just be annoying to old code. > > This will clearly need a CSR which I will draft once we agree on the > text here. > > -phil. > -- Ma

Re: [OpenJDK 2D-Dev] 8214481 is actually a regression?

hat was used to > render each case. Yes, because they all render the same, but for clarity they are in order from the bottom to the top 8, 11, 11 patched. Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH <https://www.redhat.com> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898

[OpenJDK 2D-Dev] 8214481 is actually a regression?

that is derived from all the various test cases floating around 8214481: https://bugs.openjdk.java.net/browse/JDK-8242285 Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH <https://www.redhat.com> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898

Re: [OpenJDK 2D-Dev] RFR: 8221741 ClassCastException happen when fontconfig.properties was used

se I'm aware of a few people getting the weird error when all it meant was a misconfiguration (I think this hits more because the closed JDK does come with some fonts if I remember correctly while OpenJDK requires fonts to be installed on the system), but I was afraid the new "NULL FONT HANDLE&

Re: [OpenJDK 2D-Dev] RFR: 8221741 ClassCastException happen when fontconfig.properties was used

t can > then still be resolved, even if our font configuration contains less fonts > (no true type fonts). What happens now when there are no fonts at all on the system? (which is a case of misconfiguration). Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH <

Re: [OpenJDK 2D-Dev] RFR: 8221741 ClassCastException happen when fontconfig.properties was used

gt; Hi Ichiroh, > > > > this is great, thanks for doing this. We regularly see this and > > just > > stumbled over it the other day where the fontconfig of our test > > user > > was corrupted somehow. > > > > As for the test, I would reduce the amount of reflection a little > > bit. > > It should not be necessary to access SunFontManager via > > Class.forName, > > you already exported it to the test via the @modules statement. > > You > > can probably use this coding (please try as I didn't test it): > > > >SunFontManager sfm = SunFontManager.getInstance(); > >Field defaultFontName_fid = > > SunFontManager.class.getDeclaredField("defaultFontName"); > >defaultFontName_fid.setAccessible(true); > >defaultFontName_fid.set(sfm, "Dialog"); > >Method loadFonts_mid = > > SunFontManager.class.getDeclaredMethod("loadFonts"); > >loadFonts_mid.setAccessible(true); > >loadFonts_mid.invoke(sfm); > >PhysicalFont physicalFont = sfm.getDefaultPhysicalFont(); > >System.out.println(physicalFont); > > > > If you want, I can run your (updated) patch through our test > > system. > > > > Thanks > > Christoph > > > > > > -Original Message- > > From: 2d-dev<2d-dev-boun...@openjdk.java.net> > <2d-dev-boun...@openjdk.java.net> On Behalf > > Of > > Ichiroh > > Takiguchi > > Sent: Montag, 7. Oktober 2019 09:33 > > To: 2d-dev@openjdk.java.net > > Subject: [OpenJDK 2D-Dev] RFR: 8221741 ClassCastException > > happen > > when > > fontconfig.properties was used > > > > Hello. > > > > Could you review the fix ? > > > > Bug:https://bugs.openjdk.java.net/browse/JDK-8221741 > > Change: > > https://cr.openjdk.java.net/~itakiguchi/8221741/webrev.04/ > > JTreg testcase and results are including JDK-8221741 [1]. > > > > [1] https://bugs.openjdk.java.net/browse/JDK-8221741 > > > > Thanks, > > Ichiroh Takiguchi > > IBM Japan, Ltd. > > > > > > > -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH <https://www.redhat.com> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898

Re: [OpenJDK 2D-Dev] Fix for 8235904 "Infinite loop when rendering huge lines"

Thanks! Cheers, Mario On Tue 14. Jan 2020 at 22:58, Alexander Zuev wrote: > Hi Phil, Clemens, > >both code change and test looks fine to me. > > /Alex > > On 1/14/20 12:33, Phil Race wrote: > > Here's your webrev with a jtreg compliant test added : > >

Re: [OpenJDK 2D-Dev] Fix for 8235904 "Infinite loop when rendering huge lines"

the issue. > The code was ported to java back then to avoid JNI overhead. > > A big thanks to Mario Torre for analyzing the issue in detail and > bringing it to my attention. > > Thanks, Clemens > -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH <https

Re: [OpenJDK 2D-Dev] RFR: 8217731: Font rendering and glyph spacing changed from jdk-8 to jdk-11

D rendering > > it manifests as subtle adjustments in the spacing between glyphs. > > There isn't an easy regression test for this, and it is subjective > > as to how bad it was before and how much this improves it, > > even if you were to accept that 8 is "better" .. and not j

Re: [OpenJDK 2D-Dev] "java.lang.Error: Probable fatal error:No fontsfound" does notshow on 11

Il giorno lun 4 mar 2019 alle ore 20:41 Bernd Eckenfels ha scritto: > > Hello, > > > > Philip Race wrote: > > > This is getting into "why doesn't my app run if I remove > > things it needs to run ?" territory. > > > > Yes and no, the errors are caused by missing dependency declarations in >

Re: [OpenJDK 2D-Dev] Request for re-reviewl: Backport of JDK-8150954: Taking screenshots on x11 composite desktop produce wrong result

it is indeed more logical. Thanks for spotting this as I completely missed it (good that we have reviews for backports too!). It's fixed in this new webrev: http://cr.openjdk.java.net/~neugens/8150954/webrev-jdk8u.01/jdk.patch Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH <https://www.redhat.com> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898

[OpenJDK 2D-Dev] Request for re-reviewl: Backport of JDK-8150954: Taking screenshots on x11 composite desktop produce wrong result

variant without the necessary libraries. Cheers, Mario -- Mario Torre Associate Manager, Software Engineering Red Hat GmbH <https://www.redhat.com> 9704 A60C B4BE A8B8 0F30 9205 5D7E 4952 3F65 7898

Re: [OpenJDK 2D-Dev] RFC: Fix for JDK-8188030

gt; we'd handle that part separately. > > -phil. > > > On 11/15/2017 09:07 AM, Mario Torre wrote: >> >> On Wed, Nov 15, 2017 at 5:46 PM, Phil Race wrote: >>> >>> Mario, >>> >>> Can you please request 8 backport approval for this version (whi

Re: [OpenJDK 2D-Dev] RFC: Fix for JDK-8188030

On Wed, Nov 15, 2017 at 6:20 PM, Phil Race wrote: > Sorry .. but there may be more work needed on 8 that I forgot about. > But its for Oracle JDK to account for the fact that CFF fonts are still > being excluded there. > > In a nutshell .. if we end up with zero fonts as a

Re: [OpenJDK 2D-Dev] RFC: Fix for JDK-8188030

On Wed, Nov 15, 2017 at 5:46 PM, Phil Race wrote: > Mario, > > Can you please request 8 backport approval for this version (which I have > approved as below) > > I know some internal folks who like to see it in 8 as well and I had to tell > them you already have a fix for

Re: [OpenJDK 2D-Dev] RFC: Fix for JDK-8188030

2017-09-27 15:52 GMT+02:00 Mario Torre <neug...@redhat.com>: > Hi all, > > I would like to propose a fix for > https://bugs.openjdk.java.net/browse/JDK-8188030. > > The issue is basically that CFF fonts are considered better match than > Type 1, but are discar

Re: [OpenJDK 2D-Dev] RFC: Fix for JDK-8188030

On Mon, Oct 23, 2017 at 9:28 PM, Phil Race wrote: > Yes, that would work .. ie preserve the status quo .. not needed in 10 > though, this would be 8-only. > > Are you going to push the 10 version of the fix any time soon ? I would like to push it today, however I'm not

Re: [OpenJDK 2D-Dev] RFC: Fix for JDK-8188030

On Thu, Sep 28, 2017 at 6:23 PM, Philip Race wrote: > I think for JDK 8 you can pass down a flag to decide whether to include or > exclude CFF. > This flag would be the value of FontUtilities.isOpenJDK() and that should > tell us what we need. > That would preserve the

Re: [OpenJDK 2D-Dev] RFC: Fix for JDK-8188030

re - for > Oracle JDK, not OpenJDK. > > Although it won't matter for openjdk7 .. since Oracle isn't using that > forest any more > > But it will be an issue for 8. Not sure how to handle that but > it should not be backported without a resolution there. > > -phil. > >

[OpenJDK 2D-Dev] RFC: Fix for JDK-8188030

Hi all, I would like to propose a fix for https://bugs.openjdk.java.net/browse/JDK-8188030. The issue is basically that CFF fonts are considered better match than Type 1, but are discarded, leaving the font array with no elements. The fix is here:

Re: [OpenJDK 2D-Dev] Font bug with minimal fonts installed

Any ideas or suggestion? Mario On Thu, Aug 31, 2017 at 1:54 PM, Mario Torre <neug...@redhat.com> wrote: > I have a weird issue with fonts in RHEL (and that means likely means > all derivative, like CentOS and Oracle Linux), although it appears > that the same issue can be replica

[OpenJDK 2D-Dev] Font bug with minimal fonts installed

I have a weird issue with fonts in RHEL (and that means likely means all derivative, like CentOS and Oracle Linux), although it appears that the same issue can be replicated on a Fedora 26. The issue is this one, in case you want to see more details:

Re: [OpenJDK 2D-Dev] Obtaining an Author status

Hello Dmitry, Quoting from: http://openjdk.java.net/projects/#project-author """ Becoming an Author Any Contributor may request the Author role by contacting the relevant Project Lead. References to at least two sponsored contributions to the Project are required. [...] Project Leads are

Re: [OpenJDK 2D-Dev] Proposed fix for JDK-807558 [JDK9]

!). Cheers, Mario 2015-06-05 21:58 GMT+02:00 Sergey Bylokhov sergey.bylok...@oracle.com: Hi, Mario. The fix looks good. On 05.06.15 18:51, Phil Race wrote: Not sure I count since I proposed the change but +1 anyway :-) -phil. On 06/04/2015 02:55 AM, Mario Torre wrote: Hello all

[OpenJDK 2D-Dev] Proposed fix for JDK-807558 [JDK9]

Hello all, This patch should fix the issue mentioned in the bug report: http://cr.openjdk.java.net/~neugens/JDK-8075584/webrev/ I believe this is all that needs to be done here, but I would like another pair of eyes nevertheless :) Cheers, Mario

Re: [OpenJDK 2D-Dev] Won't fix https://bugs.openjdk.java.net/browse/JDK-8069312 ??

On Tue, 2015-03-24 at 10:48 -0700, Phil Race wrote: On 3/24/2015 10:34 AM, Mario Torre wrote: On Tue, 2015-03-24 at 10:28 -0700, Phil Race wrote: i.e is it still JBS but there is some other target release value that should be being used ? It seems that question has been answered

Re: [OpenJDK 2D-Dev] Won't fix https://bugs.openjdk.java.net/browse/JDK-8069312 ??

On Tue, 2015-03-24 at 10:28 -0700, Phil Race wrote: i.e is it still JBS but there is some other target release value that should be being used ? It seems that question has been answered in the link Dalibor sent : its openjdk7u for the release. Yes, this makes totally sense, however the

Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

/~lbourges/ yet? ...jim On 2/26/15 2:41 AM, Mario Torre wrote: Hi Laurent, Let's move the process forward so that you can become an Author, at that point you'll be able to file bug reports and create webrevs: http://openjdk.java.net/projects/#project-author I

Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

Hi Laurent, Linking to external servers means the nice Oracle folks that are reviewing your patches can't access them for legal reason. We should get you an account on cr.openjdk.java.net so you could upload that there. I'm not entirely sure what it takes for that, I believe author status is

Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

2015-02-20 1:08 GMT+01:00 Phil Race philip.r...@oracle.com: If there was initially zero impact on any production code I can see that being more acceptable but I don't understand why its a problem to demonstrate this by putting it in an OpenJDK Project sandbox and thereby be something we can

Re: [OpenJDK 2D-Dev] Openjdk java2d rasterizer JEP for pisces (marlin) enhancements ?

2015-02-19 15:25 GMT+01:00 dalibor topic dalibor.to...@oracle.com: On 19.02.2015 13:50, Mario Torre wrote: The code is part of an OpenJDK project, though, it's already the existing Java rasterizer. It's not part of an OpenJDK Project - Project with an upper case 'P'. See http

Re: [OpenJDK 2D-Dev] [PATCH] Refactor X11FontManager

Indeed, for quite some time now I believe we don't *really* need this fallback. While we're refactoring this, it would be nice to see this gone too. I'm sure Phil has better knowledge here to know for sure though. Cheers, Mario 2015-02-05 17:52 GMT+01:00 Sergey Bylokhov

Re: [OpenJDK 2D-Dev] Printing to Postscript doesn't support dieresis

Thanks! I'm about to push the fix with this commit message: 8067364: Printing to Postscript doesn't support dieresis Summary: Fix regression caused by fix for 8023990 Reviewed-by: bae, prr Contributed-by: neug...@redhat.com, philip.r...@oracle.com I added the Contributed-by tag because I only

Re: [OpenJDK 2D-Dev] Printing to Postscript doesn't support dieresis

On Fri, 2014-12-12 at 11:06 -0800, Phil Race wrote: Correct. jtreg doesn't like System.exit() but I also understand that shell tests are now highly frowned upon. So either 1) Run using othervm where calling System.exit() should be fine - I think !? 2) Don't worry about it, assuming jtreg

Re: [OpenJDK 2D-Dev] Printing to Postscript doesn't support dieresis

On Fri, 2014-11-07 at 17:36 +0100, Mario Torre wrote: Hi all, I've been working on a strange issue recently, this seems to affect all recent version of OpenJDK as well as Oracle JDK. The issue appears to be related to this change: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev

[OpenJDK 2D-Dev] Printing to Postscript doesn't support dieresis

Hi all, I've been working on a strange issue recently, this seems to affect all recent version of OpenJDK as well as Oracle JDK. The issue appears to be related to this change: http://hg.openjdk.java.net/jdk7u/jdk7u/jdk/rev/fbe9320339ea The issue as I could find by debugging OpenJDK is a mix

Re: [OpenJDK 2D-Dev] [9] Review Request: 8041129 [OGL] surface-sw blit is extremely slow

In not a reviewer, but the fix looks good to me. I think it would be interesting to see how often you hit the slow path, I guess it may be fairly frequent on embedded devices? Cheers, Mario Il 21/apr/2014 16:18 Sergey Bylokhov sergey.bylok...@oracle.com ha scritto: Hello. Please review the

Re: [OpenJDK 2D-Dev] Resurrecting Lauren'ts work on speeding up Pisces

Hello Andrea, Unfortunately this is a known problem, and is especially difficult in your case because you're tweaking an area that doesn't have many experts around that can offer a careful review. The idea to go on with a separate project pluggable in OpenJDK is good, perhaps you could consider

Re: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8020983: OutOfMemoryError caused by non garbage collected JPEGImageWriter Instances

On Wed, 2013-07-31 at 09:13 +, andrew.bry...@oracle.com wrote: Changeset: 7f0e569c5a66 Author:bae Date: 2013-07-31 13:11 +0400 URL: http://hg.openjdk.java.net/jdk8/2d/jdk/rev/7f0e569c5a66 8020983: OutOfMemoryError caused by non garbage collected JPEGImageWriter

Re: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 8020983: OutOfMemoryError caused by non garbage collected JPEGImageWriter Instances

On Wed, 2013-07-31 at 13:24 +0400, Andrew Brygin wrote: Hi Mario, I know that the problem affects all releases, and I am working on the backport right now. Thanks! Mario

Re: [OpenJDK 2D-Dev] [8] request for review: 8020983: OutOfMemoryError caused by non garbage collected JPEGImageWriter Instances

On Mon, 2013-07-29 at 14:58 +0400, Andrew Brygin wrote: Hello, could you please review a fix for CR 8020983? Bug: http://bugs.sun.com/view_bug.do?bug_id=8020983 Webrev: http://cr.openjdk.java.net/~bae/8020983/8/webrev.00/ This fix replaces the strong reference in the streamBuffer

Re: [OpenJDK 2D-Dev] [8] request for review: 8020983: OutOfMemoryError caused by non garbage collected JPEGImageWriter Instances

On Mon, 2013-07-29 at 19:05 +0400, Andrew Brygin wrote: Hi Mario, thanks for the comments! I agree that 'stream' and 'streamRef' are not appropriate names now, because these entities point to instances of writer/reader. However, these entities use the writer/reader only as a

Re: [OpenJDK 2D-Dev] JPEGImageWriter memory leak, regression due to fix for 800791

On Mon, 2013-07-22 at 16:30 +0400, Andrew Brygin wrote: Hello Mario, Hi Andrew, Thanks for the reply :) This problem is now tracked as a bug 8020983: http://bugs.sun.com/view_bug.do?bug_id=8020983 This problem can be avoided by an explicit call for reset() or dispose() on an

Re: [OpenJDK 2D-Dev] JPEGImageWriter memory leak, regression due to fix for 800791

Hi Phil, everybody, This request is one month old now, can somebody please comment on that? The silence is starting to be a bit embarrassing to be honest. Cheers, Mario Il giorno 11/lug/2013 13:03, Mario Torre neug...@redhat.com ha scritto: On Fri, 2013-07-05 at 15:17 +0200, Mario Torre wrote

Re: [OpenJDK 2D-Dev] [PATCH FOR REVIEW] fix for fontmanager when no fonts are installed - RHBZ#862355,

this as an option, defaulting on the old behaviour, and at the same time giving a better error message. Also, like you suggest, ship a fallback in jre/lib/fonts sound a better idea in most cases. Cheers, Mario On 11/12/2012 12:29 PM, Mario Torre wrote: Hi Phil, I believe

Re: [OpenJDK 2D-Dev] Please review patch for 7150134

Hi Clemens, The patch looks good to me. Just wondering what is the impact of those two checks: +if (compClip.contains(transX1, transY1) + compClip.contains(transX2, transY2)) { for the most common cases? Cheers, Mario 2012/4/5 Clemens Eisserer linuxhi...@gmail.com:

Re: [OpenJDK 2D-Dev] Merge CacioWeb

Il giorno 13/gen/2012, alle ore 17:42, Richard Bair ha scritto: On Jan 5, 2012, at 12:20 PM, Roman Kennke ro...@kennke.org wrote: Hi all, Thanks Mario for bringing this up. First of all let me explain what is Cacio and why we think it's useful. In essence, it is an (somewhat) abstract

[OpenJDK 2D-Dev] Merge CacioWeb

Hello all, I would like to ask a question about the future directions for Caciocavallo, and CacioWeb. As you may already know, Cacio is a project we started for the OpenJDK Innovators Challenge and was aimed at refactoring the graphics code in OpenJDK to allow custom peers (and hence easy the

Re: [OpenJDK 2D-Dev] OpenJDK Warning hackathon :) - patch 1

2011/12/2 Jim Graham james.gra...@oracle.com: For GraphicsPrimitive, can't we determine a decent specific type for the traceMap to avoid having to suppress the warnings? And looking through the rest of the changes, I think I'd support an SG2D.* static import in any of the pipelines and loops

Re: [OpenJDK 2D-Dev] OpenJDK Warning hackathon :) - patch 1

Il giorno 03/dic/2011, alle ore 01:02, Jim Graham ha scritto: Phil described my take on it pretty well, but I do see your point about hiding where they come from. If I had to do it over again I might put them into an interface that SG2D, the SD's and other pipeline objects could all

Re: [OpenJDK 2D-Dev] hg: jdk8/2d/jdk: 51 new changesets

2011/8/18 lana.ste...@oracle.com: Changeset: 34fdcdb70d20 Author:    rupashka Date:      2011-07-28 18:13 +0400 URL:       http://hg.openjdk.java.net/jdk8/2d/jdk/rev/34fdcdb70d20 6995769: occasion NPE thrown from SwingUtilities.computeIntersection() Reviewed-by: alexp !

Re: [OpenJDK 2D-Dev] Turn on Xrender by default in JDK 8

This sounds like a good idea. And if my memory is correct, some of them find their way though native code, so we should probably normalize those values as well for native code after they first got detected, so a common functions would be a nice thing to have. Cheers, Mario 2011/8/16 Jim Graham

Re: [OpenJDK 2D-Dev] Turn on Xrender by default in JDK 8

Il giorno mer, 10/08/2011 alle 12.03 -0700, Phil Race ha scritto: Clemens, I think we should turn on Xrender by default in these early days in JDK 8 http://cr.openjdk.java.net/~prr/7077423/ The change itself is simple .. any concerns ? -phil. Cool patch! I think the only problems may

Re: [OpenJDK 2D-Dev] Fwd: Re: Small patch for multi-catch :)

2011/7/26 Phil Race philip.r...@oracle.com: Yes that's fine. I didn't know myself about ReflectiveOperationException  as its new in JDK 7. -phil. Hi Phil, Yeah, same for me :) Now, to commit, I need to grab the java2d branch, I need the bug id and the commit message, is this one ok? (sorry,

Re: [OpenJDK 2D-Dev] Fwd: Re: Small patch for multi-catch :)

2011/7/26 Mario Torre neugens.limasoftw...@gmail.com: 2011/7/26 Phil Race philip.r...@oracle.com: Yes that's fine. I didn't know myself about ReflectiveOperationException  as its new in JDK 7. -phil. Hi Phil, Yeah, same for me :) Now, to commit, I need to grab the java2d branch, I need

Re: [OpenJDK 2D-Dev] Fwd: Re: Small patch for multi-catch :)

Il giorno mar, 26/07/2011 alle 11.30 -0700, Phil Race ha scritto: Yes. -phil. Hi Phil, I've committed, Thanks, Mario

Re: [OpenJDK 2D-Dev] Fwd: Re: Small patch for multi-catch :)

2011/7/24 Ulf Zibis ulf.zi...@gmx.de: In build b104 it's part of OpenJDK distribution. Just try it in your build. ;-) -Ulf Well, not really, Ductus is not part of the Free Software verision AFAIK, and this is what happens when I try to include it:

Re: [OpenJDK 2D-Dev] Small patch for multi-catch :)

2011/7/23 Phil Race philip.r...@oracle.com: Looks OK .. you'll need to generate yourself a bug id. -phil. Hello Phil, Thanks for the quick answer. I filed a new bug report, the ID is 100195: https://bugs.openjdk.java.net/show_bug.cgi?id=100195 I could not set the target release as JDK8,

Re: [OpenJDK 2D-Dev] Small patch for multi-catch :)

2011/7/23 Phil Race philip.r...@oracle.com: I forwarded on the lack of JDk 8 but this is so trivial I'd really just meant to file a bug at bugs.sun.com so you can get a bugster bug ID which is what is needed to push. If you mark it as subcat classes_2d you should get  a bugster ID right away

Re: [OpenJDK 2D-Dev] FontConfig fails when optional system library is missing

Il giorno mar, 19/07/2011 alle 21.12 +0200, Roman Kennke ha scritto: IIRC, libfontconfig is also fairly standalone and portable, so when it's not there, it shouldn't be too hard to compile it. A while ago I contemplated and started to implement fontconfig in pure Java, which is not rocket

[OpenJDK 2D-Dev] OpenGL Pipeline

Hello All! I was doing some test for a new swing theme I'm creating, and I decided to give a shot at the Java2D OGL pipeline to see the performances. With my great surprise, nothing but a gray screen comes up! I enabled logging and tracing but I don't get much useful output, the only thing is

Re: [OpenJDK 2D-Dev] OpenGL Pipeline

Il giorno dom, 05/06/2011 alle 15.28 +0200, rom1dep ha scritto: Not sure but for what I remember, the OpenGL pipeline is broken for years now on the Linux platform. :( Try the fast and famous Xrender pipeline instead :) Yeah, I think I know the guy that wrote this one :) but I understood

Re: [OpenJDK 2D-Dev] Font rendering issue

Il giorno mer, 16/06/2010 alle 18.52 +0200, Mario Torre ha scritto: Il giorno mer, 16/06/2010 alle 09.37 -0700, Phil Race ha scritto: 6961732: FontMetrics.getLeading() may be negative in freetype-based OpenJDK builds -phil. Hi Phil, I need to fill the reviewer field, what is your

Re: [OpenJDK 2D-Dev] Font rendering issue

Il giorno mer, 16/06/2010 alle 19.40 +0200, Mario Torre ha scritto: Il giorno mer, 16/06/2010 alle 18.52 +0200, Mario Torre ha scritto: Il giorno mer, 16/06/2010 alle 09.37 -0700, Phil Race ha scritto: 6961732: FontMetrics.getLeading() may be negative in freetype-based OpenJDK builds

Re: [OpenJDK 2D-Dev] Font rendering issue

Il giorno gio, 10/06/2010 alle 14.28 -0700, Phil Race ha scritto: I've root-caused this although its still not clear what's the ideal answer, the simplest and safest may be Mario's proposed fix here from 5/5/2010 : Hi Phil! Thanks for the long explanation, everything makes perfect sense

Re: [OpenJDK 2D-Dev] Font rendering issue

Il giorno ven, 28/05/2010 alle 20.25 +0200, Mario Torre ha scritto: Ok, I tried to send once, but the message is moderated as it's too big. I've uploaded the package here: http://www.limasoftware.net/neugens/downloads/stuff/font2dbug/FontTest.tar.gz Hi all, Is there still any interest

Re: [OpenJDK 2D-Dev] Font rendering issue

Il giorno ven, 28/05/2010 alle 19.11 +0200, Roman Kennke ha scritto: Hi Mario, You could bundle a specific font with the testcase and use it, so it's no more system specific. /Roman Ok, I tried to send once, but the message is moderated as it's too big. I've uploaded the package here:

Re: [OpenJDK 2D-Dev] Font rendering issue

Il giorno mar, 18/05/2010 alle 15.06 -0700, Jim Graham ha scritto: The thing that bothers me about this fix is that the value being returned here is the raw computed value. All of the values in this routine are being returned in floating point sub-pixel maximum accuracy. I don't see why

Re: [OpenJDK 2D-Dev] Font rendering issue

Il giorno mar, 18/05/2010 alle 21.07 +0200, Roman Kennke ha scritto: Hi Mario, ly = (jfloat) ROUND(FT26Dot6ToFloat( scalerInfo-face-size-metrics.height + bmodifier) + ay - dy); To be honest, I don't like that. It's (yet another) workaround for

Re: [OpenJDK 2D-Dev] Font rendering issue

Il giorno gio, 06/05/2010 alle 00.18 +0200, Mario Torre ha scritto: Hi all, Crossposting, because this is related to what Roman just reported on the Swing-dev mailing list, the original thread was on 2d-dev with the same subject as this mail. When printing the values, the thing that came

Re: [OpenJDK 2D-Dev] Font rendering issue

Il giorno dom, 09/05/2010 alle 12.14 +0200, Mario Torre ha scritto: ly = (jfloat) ROUND(FT26Dot6ToFloat( scalerInfo-face-size-metrics.height + bmodifier) + ay - dy); And here is the proposed webrev: http://cr.openjdk.java.net/~neugens/100134/webrev.02/ As noted

Re: [OpenJDK 2D-Dev] Font rendering issue

the whole world, I would like some feedback. What do you think? :) Cheers, Mario -- Mario Torre, Software Developer, http://www.jroller.com/neugens/ aicas GmbH, Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-0 USt-Id: DE216375633, Handelsregister HRB

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

Il 29/10/2009 13:58, Mario Torre ha scritto: Il 28/10/2009 19:43, Jennifer Godinez ha scritto: Hi Mario, Please use the sun bug ID 6896068 when pushing the change. Make sure that you push it in 2D repository. If you need help, let me know. Thank you. Jennifer Hi Jennifer! I'll try to do

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

solution than patching the build. It should be fixed when b75 is pulled in to the 2d tree. Good Andrew, Thanks a lot, Mario -- Mario Torre, Software Developer, http://www.jroller.com/neugens/ aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Straße 18 * D-76131 Karlsruhe

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

Il 30/10/2009 15:54, Mario Torre ha scritto: Il 30/10/2009 15:53, Andrew John Hughes ha scritto: http://mail.openjdk.java.net/pipermail/build-dev/2009-October/002447.html Simple solution is to build with ALT_JDK_IMPORT_PATH set to the same as what you set ALT_BOOTDIR to for now. You shouldn't

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

and support everybody! Cheers, Mario -- Mario Torre, Software Developer, http://www.jroller.com/neugens/ aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-44 pgp key: http://subkeys.pgp.net

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

Il 19/10/2009 22:04, Jim Graham ha scritto: Hi Mario, That's just what I was trying to describe, thanks! Looks good to go... ...jim Hi Jim! Super cool! What's the next step now? :) Cheers, Mario -- Mario Torre, Software Developer, http://www.jroller.com/neugens/ aicas Allerton Interworks

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

in case that assumption changes in the future. Does that make sense? Not sure if this is what you mean: http://cr.openjdk.java.net/~neugens/100068/webrev.09 Looks like it doesn't break stuff, I did the usual test with Java2D demo. Cheers, Mario -- Mario Torre, Software Developer, http

[OpenJDK 2D-Dev] OGLGraphicsConfig

to use sun.java2d? Cheers, Mario -- Mario Torre, Software Developer, http://www.jroller.com/neugens/ aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-44 pgp key: http://subkeys.pgp.net/ PGP

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

Il 17/09/2009 22:27, Jim Graham ha scritto: http://cr.openjdk.java.net/~neugens/100068/webrev.08/ :) Mario -- Mario Torre, Software Developer, http://www.jroller.com/neugens/ aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany http

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

Il 05/08/2009 10:37, Mario Torre ha scritto: I'll send you an update shortly based on the latest OpenJDK checkout even. So, shortly turned out to be more than one month. I'm so sorry, I had quite few problems at work and some personal stuff as well that kept me quite busy on other stuff

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

Il 17/09/2009 15:22, Mario Torre ha scritto: Il 05/08/2009 10:37, Mario Torre ha scritto: I'll send you an update shortly based on the latest OpenJDK checkout even. So, shortly turned out to be more than one month. I'm so sorry, I had quite few problems at work and some personal stuff

Re: [OpenJDK 2D-Dev] [PATCH] FontManager refactoring, rev7

Il 07/08/2009 22:01, Clemens Eisserer ha scritto: Ok now to push in? Yes. Cool - congratulations :) - Clemens Finally Cheers, Mario

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

even. Cheers, Mario -- Mario Torre, Software Developer, http://www.jroller.com/neugens/ aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-44 pgp key: http://subkeys.pgp.net/ PGP Key ID

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

/~neugens/100068/webrev.06/ Please, ignore the .hgignore changes in the patch. Cheers, Mario -- Mario Torre, Software Developer, http://www.jroller.com/neugens/ aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany http://www.aicas.com

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

the other approaches? I hardly see how a method call can be faster than an instanceof, but maybe I miss something obvious. If you want, I can try to setup a machine at work to run a full 72 hour test, but this will take some time ( 72*2 hours :). Cheers, Mario -- Mario Torre, Software Developer

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

with some real app too, like NetBeans :). The Java2D demo isn't really the fastest thing on Earth with any *JDK version I tried, so it may not be the best use case to spot for performance issues. Cheers, Mario -- Mario Torre, Software Developer, http://www.jroller.com/neugens/ aicas Allerton

Re: [OpenJDK 2D-Dev] AWT Dev _LITTLE_ENDIAN

remember it? Roman, maybe we should introduce some big macro instead ;) In any case, I agree this is my problem, there is nothing wrong in the JDK code, I just think it would be more portable with this refactored a bit. Cheers, Mario -- Mario Torre, Software Developer, http://www.jroller.com

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

(of course if the proposed fix is evaluated as complete). Cheers, Mario -- Mario Torre, Software Developer, http://www.jroller.com/neugens/ aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-44 pgp

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

Il giorno gio, 18/06/2009 alle 00.34 +0200, Mario Torre ha scritto: But I'll debafterug it a little further and send you some updates asap. Cheers, Mario Hello! The pipelines that use a loops after being invalidated without checking if it's valid or not (null) are those so far

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

no extra dependencies anymore, but from what I see the loops are always the same from a practical point of view (but I'll check this a bit better just in case). I like both this and the first approach proposed by Jim, so is up to you to decide what to do :) Cheers, Mario -- Mario Torre, Software

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

we have. But I would never come right out and say something like that since it serves as a good make sure even kooky things continue to work telltale... [goes back to looking nonchalant] Ugh... don't tell me I'm debugging with a wrong test case... :S Cheers, Mario -- Mario Torre, Software

Re: [OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

cases or doesn't add overhead, so who knows the code better has the last word on that, of course. Cheers, Mario -- Mario Torre, Software Developer, http://www.jroller.com/neugens/ aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany http

Re: [OpenJDK 2D-Dev] Thoughts about font implementation

as an interface. Maybe we should provide you with the whole picture first and then try to review each small patch individually? Cheers, Mario -- Mario Torre, Software Developer, http://www.jroller.com/neugens/ aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Straße 18 * D-76131

Re: [OpenJDK 2D-Dev] FINAL PROJECT: Portable GUI backends

Il giorno mar, 05/08/2008 alle 12.25 -0700, Dmitri Trembovetski ha scritto: Yeah, I knew you'll like Phil's changes to that code =) eh... I'll try to sync asap. I think we should define a better interface for the Font code, what we did was just a wild refactor, while it would be nice to

Re: [OpenJDK 2D-Dev] FINAL PROJECT: Portable GUI backends

I would put little more of myself into this. Ciao! Mario -- Mario Torre, Software Developer, http://www.jroller.com/neugens/ aicas Allerton Interworks Computer Automated Systems GmbH Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany http://www.aicas.com * Tel: +49-721-663 968-53 pgp key

Re: [OpenJDK 2D-Dev] FINAL PROJECT: Portable GUI backends

for doing the changes!!! haha Seriously, I hope we can work out something! Cheers! Mario P.S. I'm sorry if anyone gets the mail 6 times, it seems that I have few problems with the correct address I'm subscribed to each list :) -- Mario Torre, Software Developer, http://www.jroller.com/neugens

[OpenJDK 2D-Dev] FINAL PROJECT: Portable GUI backends

is published under the SCA of Roman Kennke, Mario Torre and aicas GmbH. This includes the code published under these repositories: http://hg.openjdk.java.net/caciocavallo/caciocavallo/ http://kennke.org/~hg/hgwebdir.cgi/caciocavallo/ http://kennke.org/~hg/hgwebdir.cgi/caciocavallo-ng/ The latter two

[OpenJDK 2D-Dev] FINAL PROJECT: Portable GUI backends

is published under the SCA of Roman Kennke, Mario Torre and aicas GmbH. This includes the code published under these repositories: http://hg.openjdk.java.net/caciocavallo/caciocavallo/ http://kennke.org/~hg/hgwebdir.cgi/caciocavallo/ http://kennke.org/~hg/hgwebdir.cgi/caciocavallo-ng/ The latter two

[OpenJDK 2D-Dev] FINAL PROJECT: Portable GUI backends

is published under the SCA of Roman Kennke, Mario Torre and aicas GmbH. This includes the code published under these repositories: http://hg.openjdk.java.net/caciocavallo/caciocavallo/ http://kennke.org/~hg/hgwebdir.cgi/caciocavallo/ http://kennke.org/~hg/hgwebdir.cgi/caciocavallo-ng/ The latter two

  1   2   >