Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Hi Phil, Thank you a lot for your review and your time on this long & complex review. 2018-03-26 22:50 GMT+02:00 Philip Race : > Hi Laurent, > > It took me I at least 5 tries to get all the way through this. > > I agree it was a complex patch (clipping) with many other

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Hi Laurent, It took me I at least 5 tries to get all the way through this. I don't have any substantial comments, just a few clean up questions. What is this in Curve.java + DCurve.java ? +if (false) { +dax = 0.0d; +day = 0.0d; +dbx = 0.0d; +

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Hi, Sorry to insist but I would like to get feedback on this Marlin patch soon before going forward on tile-size tuning in java2d accelerated pipelines. Laurent 2018-03-21 22:56 GMT+01:00 Laurent Bourgès : > Hi, > > Here is the updated webrev: >

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Hi, Here is the updated webrev: http://cr.openjdk.java.net/~lbourges/marlin/marlin-091.1/ Changes in MarlinProperties only: - getTileSize_Log2() & getTileWidth_Log2(); 32x32 tiles ie default = 5 (log2) I hope it is good for now as tile settings are the same as in jdk9/10. Regards, Laurent

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Sergey, Le mer. 14 mars 2018 à 17:14, Sergey Bylokhov a écrit : > On 13/03/2018 17:04, Sergey Bylokhov wrote: > >> I have started to look to this review, will run some closed tests and >> send a feedback soon. >> > > No issues found so far, +1. Thanks for your

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

On 13/03/2018 17:04, Sergey Bylokhov wrote: I have started to look to this review, will run some closed tests and send a feedback soon. No issues found so far, +1. -- Best regards, Sergey.

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Hi, Laurent. On 09/03/2018 00:28, Laurent Bourgès wrote: Hi Sergey & Phil, Could you review the submitted marlin webrev soon ? I have started to look to this review, will run some closed tests and send a feedback soon. -- Best regards, Sergey.

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Hi Sergey & Phil, Could you review the submitted marlin webrev soon ? I will revert the tile size change in MarlinProperties (6,7 => 5,5) to avoid any problem for now: 2 lines fix. As proposed before, supporting larger tiles in 2d pipelines needs many small tuning and can be done in follow-up

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

On 08/03/2018 14:02, Laurent Bourgès wrote: I suppose the queue is drained too quickly on my fast gpu and is too small to feed the gpu... maybe I am wron Profiling will help here. on macOS you can user Instruments which can profile cpu and gpu. Definitely it is more related to awt... and

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Sergey, Le 8 mars 2018 21:21, "Sergey Bylokhov" a écrit : On 06/03/2018 00:38, Laurent Bourgès wrote: > Yes d3d/ogl are defered rendering so using RenderQueue buffering has costs > (1 extra mask copy + command arguments). I wonder how to improve such > buffer queue

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

On 06/03/2018 00:38, Laurent Bourgès wrote: Yes d3d/ogl are defered rendering so using RenderQueue buffering has costs (1 extra mask copy + command arguments). I wonder how to improve such buffer queue to have less synchronization overhead induced by flushNow(), and why increasing the buffer

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Hi Sergey, Good to get feedback from java2d team ! I am investing a lot of my own time on improving java2d with the Marlin renderer & other optimizations (like these ones) so I expect more involvement from the openjdk 2d community ... to help me testing, commenting, reviewing patches and I

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

HI, > As previously mentioned, I increased the RenderQueue buffer (see patchs at > the end) to 4M (instead of 32K) and d3d & opengl get boosted. It is great to see the tile-size improvements reach the other backends too :) In case of the buffer size - I wonder is 4M really needed or was it an

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Hi, Laurent. On 05/03/2018 14:19, Laurent Bourgès wrote: First Marlin 0.9.1 patch works well: no crash or bug with larger tiles 128x64 even if d3d / opengl uses internally 32x32 texture caches. Moreover xrender pipeline is the fastest compared to D3D (40% slower) or opengl (>250% slower) !

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Phil, As promised, I made Marlin 0.9.1 benchmarks on windows & linux to compare d3d, opengl & xrender backends on the same machine: I5 + nvidia 1070. (I will test on mac OS X soon, if needed) First Marlin 0.9.1 patch works well: no crash or bug with larger tiles 128x64 even if d3d / opengl uses

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Hi, I have created the corresponding JBS rfe/bug: https://bugs.openjdk.java.net/browse/JDK-8198885 Jtreg: ok Tested on linux 64 with both xrender & opengl pipelines. I will make tests on macOS & windows soon to ensure larger tiles are well supported. News: - I modified opengl queue buffer

Re: [OpenJDK 2D-Dev] [11] Upgrade to Marlin renderer 0.9.1

Phil, Will you have some time soon to have a look ? It fixes dashing performance definitively and dash error accumulation too. Laurent Le 15 févr. 2018 6:30 PM, "Laurent Bourgès" a écrit : > Hi, > > Please review this large patch providing Marlin 0.9.1 for JDK 11: >