Re: [OpenJDK 2D-Dev] JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

2014-05-19 Thread Alan Bateman
On 19/05/2014 07:53, Paul Sandoz wrote: If i don't have permission to push to the client repo (which might be likely) i will need to hand over the patch to yourself or Sergey to commit. And i presume this will have to be a separate issue. If you do decide to split this then it will require crea

Re: [OpenJDK 2D-Dev] [9] Review request for 8029339 Custom MultiResolution image support on HiDPI displays

2014-05-19 Thread Alexander Scherbatiy
Hi Phil, On 5/16/2014 9:12 PM, Phil Race wrote: I think Jim was looking at this. I am not sure if you yet answered all his questions/concerns. There's a lot of API here and it will take more time than I have right now just to get my head around it so do not expect a quick answer. 1. Why

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042864 : Fix raw and unchecked warnings in javax.print

2014-05-19 Thread Joe Darcy
*ping* Any other comments? Thanks, -Joe On 05/15/2014 06:06 PM, Joe Darcy wrote: Hi Henry, On 05/15/2014 03:46 PM, Henry Jen wrote: On 05/15/2014 12:07 PM, Joe Darcy wrote: Hello, Please review these change to fix JDK-8042864 : Fix raw and unchecked warnings in javax.print http

Re: [OpenJDK 2D-Dev] JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

2014-05-19 Thread Phil Race
On 5/19/2014 12:50 AM, Alan Bateman wrote: On 19/05/2014 07:53, Paul Sandoz wrote: If i don't have permission to push to the client repo (which might be likely) i will need to hand over the patch to yourself or Sergey to commit. And i presume this will have to be a separate issue. If you do dec

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042864 : Fix raw and unchecked warnings in javax.print

2014-05-19 Thread Jennifer Godinez
Looks good. - Jennifer On 5/19/2014 9:35 AM, Joe Darcy wrote: *ping* Any other comments? Thanks, -Joe On 05/15/2014 06:06 PM, Joe Darcy wrote: Hi Henry, On 05/15/2014 03:46 PM, Henry Jen wrote: On 05/15/2014 12:07 PM, Joe Darcy wrote: Hello, Please review these change to fix JDK-8

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042864 : Fix raw and unchecked warnings in javax.print

2014-05-19 Thread Phil Race
Some of these seem to need a CCC eg .. In AttributeException public Class[] getUnsupportedAttributes(); and ... http://cr.openjdk.java.net/~darcy/8042864.0/src/share/classes/javax/print/MimeType.java.sdiff.html public Map getParameterMap() { http://cr.openjdk.java.net/~darcy/8042864.0/src/

Re: [OpenJDK 2D-Dev] RFR: Allow using the system libjpeg

2014-05-19 Thread Anthony Petrov
Hi Omair, common/autoconf/libraries.m4 624 [use libjpeg from build system or OpenJDK source (system, bundled) @<:bundled@:>@])]) "@<:bundled@:>@" should read "@<:@bundled@:>@" - note the missing @. make/lib/Awt2dLibraries.gmk 1236 LIBJPEG_CFLAGS := $(JDK_TOPDIR)/src/share/native

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042864 : Fix raw and unchecked warnings in javax.print

2014-05-19 Thread Joe Darcy
Hi Phil, On 05/19/2014 11:36 AM, Phil Race wrote: Some of these seem to need a CCC eg .. In AttributeException public Class[] getUnsupportedAttributes(); and ... http://cr.openjdk.java.net/~darcy/8042864.0/src/share/classes/javax/print/MimeType.java.sdiff.html public Map getParameterMap() {

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042864 : Fix raw and unchecked warnings in javax.print

2014-05-19 Thread Phil Race
On 5/19/2014 11:54 AM, Joe Darcy wrote: http://cr.openjdk.java.net/~darcy/8042864.0/src/share/classes/javax/print/attribute/standard/DialogTypeSelection.java.sdiff.html < 113 public final Class getCategory() { > 113 public final Class getCategory() { getCategory() is a super-class method ..

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042864 : Fix raw and unchecked warnings in javax.print

2014-05-19 Thread Joe Darcy
Revised webev at http://cr.openjdk.java.net/~darcy/8042864.2 Comments below. On 05/19/2014 12:14 PM, Phil Race wrote: On 5/19/2014 11:54 AM, Joe Darcy wrote: http://cr.openjdk.java.net/~darcy/8042864.0/src/share/classes/javax/print/attribute/standard/DialogTypeSelection.java.sdiff.html

Re: [OpenJDK 2D-Dev] JDK 9 RFR of JDK-8042864 : Fix raw and unchecked warnings in javax.print

2014-05-19 Thread Phil Race
OK now. I wouldn't necessarily agree the generification was poor, and it was a choice made by someone else .. -phil. On 5/19/2014 12:49 PM, Joe Darcy wrote: Revised webev at http://cr.openjdk.java.net/~darcy/8042864.2 Comments below. On 05/19/2014 12:14 PM, Phil Race wrote: On 5/19/201

Re: [OpenJDK 2D-Dev] Review request for 8034218: AIX: Provide a better fontconfig.properties file

2014-05-19 Thread Jonathan Lu
Hi Volker, I've updated the patch by dropping the those fonts configurations from $JRE_LIB_FONTS directory. The change is based on the SAP version, current change is primarily adding support for CJK fonts, pls review. http://cr.openjdk.java.net/~luchsh/JDK-8034218.v2/ Thanks Jonathan On Tue, M

Re: [OpenJDK 2D-Dev] JDK-8041679 Replace uses of StringBuffer with StringBuilder within the JDK

2014-05-19 Thread Paul Sandoz
On May 19, 2014, at 6:18 PM, Phil Race wrote: > On 5/19/2014 12:50 AM, Alan Bateman wrote: >> On 19/05/2014 07:53, Paul Sandoz wrote: >>> If i don't have permission to push to the client repo (which might be >>> likely) i will need to hand over the patch to yourself or Sergey to commit. >>> An