Re: [OpenJDK 2D-Dev] RFR: 8220528: [AIX] Fix basic Xinerama and Xrender functionality

On Mon, Mar 25, 2019 at 7:50 PM Thomas Stüfe wrote: > > > > On Mon 25. Mar 2019 at 19:42, Volker Simonis wrote: >> >> Hi Thomas, Christoph, >> >> thanks for looking into my fix. I hope I've addressed all your >> concerns with my new webrev: >> >

Re: [OpenJDK 2D-Dev] RFR: 8220528: [AIX] Fix basic Xinerama and Xrender functionality

You want > to make sure dlerror() is not stale at the point where you call it, since it > would return NULL. > > Cheers, Thomas > > > > On Mon, Mar 18, 2019 at 3:17 PM Volker Simonis > wrote: >> >> Ping... >> >> Can I please also get a revi

Re: [OpenJDK 2D-Dev] RFR: 8220528: [AIX] Fix basic Xinerama and Xrender functionality

Ping... Can I please also get a review from the awt/2d group? Thanks, Volker On Wed, Mar 13, 2019 at 11:09 AM Volker Simonis wrote: > > Hi, > > can I please have a review for the following change which fixes > Xinerama and Xrender support on AIX: > > http://cr.openjdk.java

[OpenJDK 2D-Dev] RFR: 8220528: [AIX] Fix basic Xinerama and Xrender functionality

Hi, can I please have a review for the following change which fixes Xinerama and Xrender support on AIX: http://cr.openjdk.java.net/~simonis/webrevs/2019/8220528/ https://bugs.openjdk.java.net/browse/JDK-8220528 The change basically fixes the way how the corresponding libraries (libXext and

Re: [OpenJDK 2D-Dev] RFR(S): 8214343: Handle the absence of Xrandr more generically

On Tue, Mar 12, 2019 at 5:38 AM Sergey Bylokhov wrote: > > Hi, Volker. > > On 27/11/2018 05:52, Volker Simonis wrote: > > Change JDK-8213944 fixed the build on AIX (which has no Xrandr) by > > conditionally excluding the relevant parts on AIX with the help of

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file

Hi, I've just downported the fix for JDK-8212116 to 11u. A downport to 11.0.2 has been requested as well by adding the ("CPU19_01-critical-request") label to the JBS issue but it is beyond my powers if this will be approved. Regards, Volker On Thu, Dec 6, 2018 at 4:40 PM Philip Race wrote: > >

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file"

[Resending, because my first mail to2d-dev was blocked with "550 Denied by policy"] Hi Phil, I've increased the priority of the issue to P2, because it is a serious regression which breaks many applications. And I've requested a backport to 11u as described in the OpenJDK Updates Project push

[OpenJDK 2D-Dev] RFR(S): 8214343: Handle the absence of Xrandr more generically

Hi, can I please have a review for the following trivial change which handles the absence of Xrandr more generically: http://cr.openjdk.java.net/~simonis/webrevs/2018/8214343/ https://bugs.openjdk.java.net/browse/JDK-8214343 Change JDK-8213944 fixed the build on AIX (which has no Xrandr) by

Re: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

ources > and deferred that, but XRANDR ??? I think this is an AIX "bug" which should > be reported to IBM. > I have reported it, but in the end AIX, HP-UX, Solaris, etc. are all zombie operating systems :( > -phil. > > > On 11/20/18 10:13 AM, Volker Simonis wrote

Re: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

asks Results Summary UNABLE_TO_RUN: 0 FAILED: 0 EXECUTED_WITH_FAILURE: 1 KILLED: 0 PASSED: 75 NA: 0 Thank you and best regards, Volker On Tue, Nov 20, 2018 at 12:05 PM Magnus Ihse Bursie wrote: > > > > On 2018-11-19 18:56, Volker Simonis wrote: > > Hi Phil, > > > > I'd li

Re: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

for me, but that would actually negate the initial purpose of "8210863: Remove Xrandr include files") Do you have a better proposal? Thank you and best regards, Volker On Fri, Nov 16, 2018 at 11:22 AM Volker Simonis wrote: > > On Thu, Nov 15, 2018 at 6:01 PM Philip Race wrote:

Re: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

again in an AIX-specific directory :) Thank you and best regards, Volker > -phil. > > On 11/15/18, 8:55 AM, Philip Race wrote: > > Hmm. I don't like the ifdefs. > > > > Xrandr is a requirement for the build. If its not there at runtime > > that's OK. > >

Re: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

On Thu, Nov 15, 2018 at 5:31 PM Aleksey Shipilev wrote: > > On 11/15/2018 05:06 PM, Volker Simonis wrote: > > can I please have a review for the following small change: > > > > http://cr.openjdk.java.net/~simonis/webrevs/2018/8213944/ > > *) I tested it on platform w

Re: [OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

e at runtime > that's OK. > > -phil. > > On 11/15/18, 8:06 AM, Volker Simonis wrote: > > Hi, > > > > can I please have a review for the following small change: > > > > http://cr.openjdk.java.net/~simonis/webrevs/2018/8213944/ > > https://bugs.openjdk

Re: [OpenJDK 2D-Dev] RFR: 8210863: Remove Xrandr include files from JDK sources

Sorry, I'm a little late to the game, but this change broke the AIX build. It also misses a configure check for Xrandr which now became a build dependency. I've opened "8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it" and sent around a RFR on this [1] list

[OpenJDK 2D-Dev] RFR(XS): 8213944: Fix AIX build after the removal of Xrandr.h and add a configure check for it

Hi, can I please have a review for the following small change: http://cr.openjdk.java.net/~simonis/webrevs/2018/8213944/ https://bugs.openjdk.java.net/browse/JDK-8213944 Change JDK-8210863 removed the Xrandr.h/randr.h headers from the OpenJDK sources but forgot to add a configure check for the

Re: [OpenJDK 2D-Dev] RFR: 8206106: [solaris sparc] jck tests api/javax_print/PrintService failing

t;> #ifdef __SUNPRO_C >> ... >> >> https://docs.oracle.com/cd/E19205-01/820-4155/c++_faq.html#Vers6 >> >> -phil. >> >> On 07/06/2018 01:24 AM, Volker Simonis wrote: >>> >>> Hi Phil, >>> >>> I've actually thought ab

Re: [OpenJDK 2D-Dev] RFR: 8206106: [solaris sparc] jck tests api/javax_print/PrintService failing

Hi Phil, I've actually thought about the same trick yesterday in the evening and just wanted to try it out when I saw your mail. It indeed works quite nicely and I can confirm that it solves the problem on our side as well. I've also opened an issue in the CUPS bug tracker:

Re: [OpenJDK 2D-Dev] RFR(XS): 8201524: [AIX] Don't link libfontmanager against libawt_headless

already fine without this, > but a jdk-submit would be prudent .. > I did start Solaris and AIX builds before I left the office. I can certainly also submit a job to JDK-submit, but at least hs-submit wasn’t working at all (i.e. didn’t return any results). > -phil. > > On 04/13/2018 09:22 A

Re: [OpenJDK 2D-Dev] RFR : 8193515 : AIX : new Harfbuzz 1.7.1 version fails to compile

FYI: my patch has been accepted and pushed upstream into Harfbuzz: Closed #655 https://github.com/harfbuzz/harfbuzz/issues/655 via #656 https://github.com/harfbuzz/harfbuzz/pull/656 On Tue, Dec 19, 2017 at 11:43 AM, Volker Simonis <volker.simo...@gmail.com> wrote: > Thanks Phil! >

Re: [OpenJDK 2D-Dev] RFR : 8193515 : AIX : new Harfbuzz 1.7.1 version fails to compile

/issues/655 [2] https://github.com/harfbuzz/harfbuzz/pull/656 On Mon, Dec 18, 2017 at 6:24 PM, Philip Race <philip.r...@oracle.com> wrote: > +1 from me .. > > yes push to jdk/jdk10. > > -phil. > > > On 12/18/17, 1:51 AM, Volker Simonis wrote: >> >> Hi Matth

Re: [OpenJDK 2D-Dev] RFR : 8193515 : AIX : new Harfbuzz 1.7.1 version fails to compile

Hi Matthias, thanks for addressing this issue! I'm pretty sure that his is a compiler bug and I have a short reproducer which I'll send to IBM. The problem is that xlC can't distinguish a static member function (which uses an ordinary function call) from a non-static member function (which uses

Re: [OpenJDK 2D-Dev] RFR 8171456: Upgrade harfbuzz in JDK 9 to v1.4.1

Hi Sergey, thanks for caring for our AIX changes :) They've been committed up-stream in December 2015 already so that shouldn't be a problem any more. I've also checked that the changes for JDK-8171248 which we've done directly up-stream are present in this upgrade. So thumbs up from me! Volker

Re: [OpenJDK 2D-Dev] RFR(S): 8171248: Minor HarfBuzz fixes to pacify Coverity code scan

n't indeed that critical, so I'll close this issue as duplicate of your new bug and put in an appropriate comment. Best regards, Volker > -phil. > > > On 12/19/2016 12:31 AM, Volker Simonis wrote: >> >> Thanks Behdad! >> >> @Phil: what do you think, can I push

Re: [OpenJDK 2D-Dev] RFR(S): 8171248: Minor HarfBuzz fixes to pacify Coverity code scan

On Sun, Dec 18, 2016 at 8:23 AM, Behdad Esfahbod <beh...@google.com> wrote: > Thanks Volker. Fixed upstream. I'll make a release in the next couple of > days. > > On Wed, Dec 14, 2016 at 1:15 PM, Volker Simonis <volker.simo...@gmail.com> > wrote: >> >&g

Re: [OpenJDK 2D-Dev] Font rendering quality in Linux

On Thu, Dec 15, 2016 at 2:30 PM, Artur Rataj wrote: > Hello, I discussed the problem on dev-build > > http://mail.openjdk.java.net/pipermail/build-dev/2016-December/018353.html > > but have been redirected here, thanks Eric! > > I would like to ask why OpenJDK on Linux has

[OpenJDK 2D-Dev] RFR(S): 8171248: Minor HarfBuzz fixes to pacify Coverity code scan

Hi, can I please have a review for the following small changes which fix some Coverity code scan issues in the Harfbuzz library: https://bugs.openjdk.java.net/browse/JDK-8171248 http://cr.openjdk.java.net/~simonis/webrevs/2016/8171248/ These changes only make sense if they are also accepted in

Re: [OpenJDK 2D-Dev] RFR(XS): 8163177: Fix for 8152971 breaks builds with VS2010

Hi Christoph, the change looks good. Thanks for fixing it. Regards, Volker On Thu, Aug 4, 2016 at 1:49 PM, Langer, Christoph wrote: > Hi, > > > > please review this little fix: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8163177 > > Webrev:

Re: [OpenJDK 2D-Dev] RFR(L): 8160974: [TESTBUG] Mark more headful tests with @key headful.

Hi Götz, your change looks good. Thanks a lot for cleaning up all these tests! I only found one problem which you should fix: test/java/awt/Frame/MiscUndecorated/RepaintTest.java @@ -1,6 +1,6 @@ -/* +\/* Seems like there's an extra backslash at the beginning of the first line. You may also

Re: [OpenJDK 2D-Dev] RFR(XS): 8160721: Avoid deoptimizations in Font.equals.

Hi Goetz, it would be really interesting to see the use case where this has been a performance issue. But even without that I agree with your comments in the bug. Phil's fear that you introduce an extra 'instanceof' check for the positive case is unfounded. I've attached a small example program

Re: [OpenJDK 2D-Dev] RFR(S): 8155236: AIX: fix detection of Xrender extension

I've checked that it really works :) Thanks, Volker On Wed, Apr 27, 2016 at 6:35 PM, Philip Race <philip.r...@oracle.com> wrote: > Whilst the syntax is all new to me, since it is contained > entirely in #if defined(_AIX) I am OK with this fix. > > phil. > > > On 4/27/

[OpenJDK 2D-Dev] RFR(S): 8155236: AIX: fix detection of Xrender extension

Hi, can somebody please review this AIX-only fix which I've found in one of my old patch queues :) http://cr.openjdk.java.net/~simonis/webrevs/2016/8155236/ https://bugs.openjdk.java.net/browse/JDK-8155236 On AIX we have to use a special syntax for the dlopen() string argument because the

Re: [OpenJDK 2D-Dev] RFR(S): 8145077: AIX: fix harfbuzz support

. I've added noreg-other to the bug. > Is there an "aix" label in use ? > > -phil. > > > On 12/10/2015 09:38 AM, Volker Simonis wrote: >> >> Hi, >> >> here's a slightly updated version of my webrev which is now identical >> to the version whi

Re: [OpenJDK 2D-Dev] Question regarding the integration of harfbuzz (JEP 258)

nuestro iPhone. > > El dic 10, 2015, a las 8:12 AM, Volker Simonis <volker.simo...@gmail.com> > escribió: > > Behdad, > > you're really great!!! > > I've forked HarfBuzz today because I wanted to submit a pull request with > the change. Unfortunately I was not able to

[OpenJDK 2D-Dev] RFR(S): 8145077: AIX: fix harfbuzz support

Hi, could somebody please review this AIX-only fix which adds the harfbuzz atomic primitives for AIX: http://cr.openjdk.java.net/~simonis/webrevs/2015/8145077/ https://bugs.openjdk.java.net/browse/JDK-8145077 I plan to also submit this patch upstream to the harfbuzz project to minimize the

Re: [OpenJDK 2D-Dev] Question regarding the integration of harfbuzz (JEP 258)

ICU are moving to harfbuzz so I'd be somewhat astonished > if they haven't yet tried it on AIX. Did you try just getting a copy > of the full hotspot library and running its configure on AIX to see if > harfbuzz can work out which options it wants there ? Obviously > I did not try that since

Re: [OpenJDK 2D-Dev] RFR(S): 8145077: AIX: fix harfbuzz support

is that the AIX atomic intrinsics are now additionally guarded by a compiler check which ensures that they only get compiled with IBM's xlC compiler. Regards, Volker On Thu, Dec 10, 2015 at 2:13 PM, Volker Simonis <volker.simo...@gmail.com> wrote: > Hi, > > could somebody please

Re: [OpenJDK 2D-Dev] Question regarding the integration of harfbuzz (JEP 258)

from multiple threads, even though it doesn't uses >> threads itself. >> >> Does AIX use pthread for threading? I can definitely add a threading >> stress-test to HarfBuzz. I definitely should. Filed here: >> >> https://github.com/behdad/harfbuzz/issues/1

Re: [OpenJDK 2D-Dev] Question regarding the integration of harfbuzz (JEP 258)

ich would be sad :( So it would be definitely interesting to hear the actual internals from Steven :) That said, I've now implemented the three atomics myself by using the same compiler intrinsics like in the hotspot. I'll post a webrev tomorrow... Regards, Volker > > -phil. >

[OpenJDK 2D-Dev] Question regarding the integration of harfbuzz (JEP 258)

Hi, the integration of harfbuzz broke our AIX build because there's no implementation available for the hb_atomic macros in hb-atomic-private.hh. I've fixed that locally but still get a crash when running a simple AWT program (even with -Dsun.font.layoutengine=icu). I'm curretnly debugging the

Re: [OpenJDK 2D-Dev] [9]: RFR JDK-8139803, , Fix for 8132985 breaks OpenJDK build on windows

Looks good. Regards, Volker On Mon, Oct 26, 2015 at 9:21 AM, prasanta sadhukhan wrote: > Hi All, > > Please review a small fix for jdk9 > > Bug: https://bugs.openjdk.java.net/browse/JDK-8139803 > webrev: http://cr.openjdk.java.net/~psadhukhan/8139803/webrev/ > >

Re: [OpenJDK 2D-Dev] RFR: [9] JDK-8132985, , Crash in freetypescaler.c due to double free

ine with the change. You can count me as a reviewer if that helps. Regards, Volker > If someone wants to create such a font - from scratch - not derived > from any other work, and contribute under OCA that would be a solution. > > -phil. > > > On 09/30/2015 07:42 AM, Volker Simo

Re: [OpenJDK 2D-Dev] RFR(XS): 8132408 : Check os.name before os.version in SunGraphicsEnvironment constructor

follow-up work, but your patch will make things consistent. -phil. On 07/28/2015 11:43 AM, Volker Simonis wrote: Hi Phil, thanks for looking at this change. Please find my comments inline: On Tue, Jul 28, 2015 at 7:12 PM, Phil Race philip.r...@oracle.com wrote: The idea behind the check

[OpenJDK 2D-Dev] RFR(XS): 8132408 : Check os.name before os.version in SunGraphicsEnvironment constructor

Hi, could you please review the following small change: http://cr.openjdk.java.net/~simonis/webrevs/2015/8132408/ https://bugs.openjdk.java.net/browse/JDK-8132408 In the constructor of SunGraphicsEnvironment there's a check for os.version 5.10. If this check is true, /etc/release is opened to

Re: [OpenJDK 2D-Dev] RFR(XS): 8132408 : Check os.name before os.version in SunGraphicsEnvironment constructor

just always use fontconfig like we do on Linux nowadays ? I'm by no means an OpenSolaris expert (and I don't have a machine to check) but I will be happy to add whatever additional change you propose. Regards, Volker -phil. On 07/28/2015 09:00 AM, Volker Simonis wrote: Hi, could you

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

On Thu, May 28, 2015 at 9:24 AM, Alan Bateman alan.bate...@oracle.com wrote: On 27/05/2015 18:14, Phil Race wrote: Hi Volker, Sorry for breaking AIX but I think it may be more related to these bugs https://bugs.openjdk.java.net/browse/JDK-8073152

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

On Thu, May 28, 2015 at 11:27 AM, Alan Bateman alan.bate...@oracle.com wrote: On 28/05/2015 10:10, Volker Simonis wrote: : Yes, but as I wrote, there is a hard dependency from some of the sun.font classes to some non-standard charsets: sun.font.X11GB2312 - sun.nio.cs.EUC_CN sun.font.X11GBK

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

advantage of these but did not create/update the per-platform configuration. I think the variance is in part about putting into base only what has to be there to support boot-strapping and known dependencies whilst otherwise keeping base as small as possible. -phil. On 05/27/2015 10:01 AM, Volker

Re: [OpenJDK 2D-Dev] RFR: 8035302: Eliminate dependency on sun.nio.cs from AWT and Motif code

Hi everybody, sorry, but as usually, I'm a little late to the game:) This change, along with change 8073152: Update Standard/ExtendedCharsets to work with module system causes build failures on AIX. It took me some time to dig trough the build system, but I think that I at least have a weak

Re: [OpenJDK 2D-Dev] [PATCH] Refactor X11FontManager

We usually don't have fontconfig on AIX and it would be nice if AWT would still work even without fontconfig. There are also other ancient operating systems without fontconfig like for example HP UX which are not currently supported by OpenJDK but by commercial licensees of the OpenJDK source

Re: [OpenJDK 2D-Dev] [PATCH] Refactor X11FontManager

FcFontManage, and thus require fontconfig. Regards, Roman Am 20.02.2015 14:49 schrieb Volker Simonis volker.simo...@gmail.com: We usually don't have fontconfig on AIX and it would be nice if AWT would still work even without fontconfig. There are also other ancient operating systems without

Re: [OpenJDK 2D-Dev] RFR(XXS): 8057934: Upgrade to LittleCMS 2.6 breaks AIX build

Thanks a lot Phil and Sergey! I've just pushed the change. Regards, Volker On Tue, Sep 9, 2014 at 8:37 PM, Sergey Bylokhov sergey.bylok...@oracle.com wrote: The fix looks fine to me too. On 09.09.2014 22:18, Phil Race wrote: Approved -phil. On 09/09/2014 11:11 AM, Volker Simonis

[OpenJDK 2D-Dev] RFR(XXS): 8057934: Upgrade to LittleCMS 2.6 breaks AIX build

Hi, could you please review the following tiny fix for an AIX build problem intruduced by 8056122: Upgrade JDK to LittleCMS 2.6: http://cr.openjdk.java.net/~simonis/webrevs/8057934/ https://bugs.openjdk.java.net/browse/JDK-8057934 The problem is that the new version of LittleCMS now includes

Re: [OpenJDK 2D-Dev] RFR(XXS): 8057934: Upgrade to LittleCMS 2.6 breaks AIX build

and best regards, Volker PS: and I've verified that SUNDEFINED isn't defined on AIX... On Tue, Sep 9, 2014 at 3:51 PM, Volker Simonis volker.simo...@gmail.com wrote: Hi, could you please review the following tiny fix for an AIX build problem intruduced by 8056122: Upgrade JDK to LittleCMS 2.6

Re: [OpenJDK 2D-Dev] AWT Dev Review request for 8034218: AIX: Provide a better fontconfig.properties file

Hi Jonathan, any progress on this change? With the changes proposed by me in my last mail below I'm fine with the change (and I'm a reviewer now:) Thank you and best regards, Volker On Thu, Jun 5, 2014 at 8:45 PM, Volker Simonis volker.simo...@gmail.com wrote: Hi Jonathan, sorry

Re: [OpenJDK 2D-Dev] AWT Dev Review request for 8034218: AIX: Provide a better fontconfig.properties file

. http://cr.openjdk.java.net/~luchsh/JDK-8034218.v2/ Thanks Jonathan On Tue, May 13, 2014 at 5:25 PM, Volker Simonis volker.simo...@gmail.com wrote: Hi Jonathan, from all fontconfig files in make/data/fontconfig, solaris.fontconfig.properties is the only file which contains a single

Re: [OpenJDK 2D-Dev] AWT Dev Request for review: 8026385: [macosx] (awt) setjmp/longjmp changes the process signal mask on OS X

Hi everybody, I've analyzed this issue on AIX (and HPUX) and came to the conclusion that it is not a problem on these platforms. Just to make sure I got everything right, I'll summarize my understanding of the problem here: On MacOS, setjmp() saves the signal mask of the current thread BUT

Re: [OpenJDK 2D-Dev] AWT Dev Request for review: 8026385: [macosx] (awt) setjmp/longjmp changes the process signal mask on OS X

Wow, sometimes it really makes sense to read apparently unrelated email-threads on Friday afternoon:) It seems that AIX/HPUX have exactly the same problem like MacOS X. From the AIX setjmp man-page: The setjmp and longjmp subroutines save and restore the signal mask sigmask (2), while _setjmp

Re: [OpenJDK 2D-Dev] AWT Dev Review request for 8034218: AIX: Provide a better fontconfig.properties file

sub-cat. -phil. On 05/12/2014 09:06 AM, Volker Simonis wrote: Hi Jonathan, thanks for submitting this patch. Overall it looks good, but I don't think we should reference the fonts under $JRE_LIB_FONTS/ in the OpenJDK version of fontconfig.properties (at least not until IBM will not also

Re: [OpenJDK 2D-Dev] RFR(XS): 8042090: Fix invalid variable names in sun/java2d/loops/ProcessPath.c

is against 9/dev). Also label the bug 'noreg-cleanup' else SQE will be asking for a regression test ... thanks, -phil. On 4/29/2014 10:06 AM, Volker Simonis wrote: Hi, could you please review this tiny fix which merely renames some variable names to make them C/C++ standard conformant

[OpenJDK 2D-Dev] RFR(XS): 8042090: Fix invalid variable names in sun/java2d/loops/ProcessPath.c

Hi, could you please review this tiny fix which merely renames some variable names to make them C/C++ standard conformant and prevent a name clash with a macro defined in in /usr/include/iso/ctype_iso.h on Solaris: http://cr.openjdk.java.net/~simonis/webrevs/8042090/

Re: [OpenJDK 2D-Dev] RFR(S): JDK-8031134 : PPC64: implement printing on AIX

/8031134_2/ Is this now ready for pushing into ppc-aix-port/stage-9? Thank you and best regards, Volker -phil. On 1/16/14 12:08 AM, Volker Simonis wrote: Resending one more time to 2d-dev upon request: Hi, could somebody please review the following small change: http://cr.openjdk.java.net

[OpenJDK 2D-Dev] RFR(S): JDK-8031134 : PPC64: implement printing on AIX

Resending one more time to 2d-dev upon request: Hi, could somebody please review the following small change: http://cr.openjdk.java.net/~simonis/webrevs/8031134/ It's the straight forward implementation of the basic printing infrastructure on AIX and shouldn't have any impact on the existing

Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

is already in place. I'll prepare and test a finaly webrev with all the changes from this review round today. Thanks a lot, Volker -phil. On 11/20/2013 10:26 AM, Volker Simonis wrote: Hi, this is the second review round for 8024854: Basic changes and files to build the class library

Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

()' as suggested by Alan. The changes to src/solaris/native/com/sun/ management/UnixOperatingSystem_md.c are now in src/solaris/native/sun/management/OperatingSystemImpl.c because that file was moved by an upstream change. On Wed, Nov 20, 2013 at 7:26 PM, Volker Simonis volker.simo...@gmail.comwrote

Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

PM, Volker Simonis wrote: Hi, this is the second review round for 8024854: Basic changes and files to build the class library on AIX https://bugs.openjdk.java.net/browse/JDK-8024854. The previous reviews can be found at the end of this mail in the references section. I've tried to address

Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

/20/2013 01:26 PM, Volker Simonis wrote: Hi, this is the second review round for 8024854: Basic changes and files to build the class library on AIXhttps://bugs.openjdk.java.net/browse/JDK-8024854. The previous reviews can be found at the end of this mail in the references section. I've

Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

/OperatingSystemImpl.c. Fortunately, my changes to UnixOperatingSystem_md.c described in the webrev apply cleanly to the new file (I've tested this locally). I'll update the webrev accordingly once I've collected some more feedback. Thank you and best regards, Volker On Wed, Nov 20, 2013 at 7:26 PM, Volker Simonis

Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

reviewed the 'core-lib'/'net' parts right? That would mean that I'll still need a review from the AWT/2D and the Security group - any volunteers:). Once again thanks a lot for your help, Volker On Fri, Nov 22, 2013 at 2:24 PM, Alan Bateman alan.bate...@oracle.com wrote: On 21/11/2013 15:54, Volker

Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

Hi Alan, thanks a lot for the fast review and your valuable comments. Please find my answers inline: On Thu, Nov 21, 2013 at 1:01 PM, Alan Bateman alan.bate...@oracle.comwrote: On 20/11/2013 18:26, Volker Simonis wrote: Hi, this is the second review round for 8024854: Basic changes

[OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

Hi, this is the second review round for 8024854: Basic changes and files to build the class library on AIXhttps://bugs.openjdk.java.net/browse/JDK-8024854. The previous reviews can be found at the end of this mail in the references section. I've tried to address all the comments and suggestions

Re: [OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

. -phil. On 9/16/2013 12:30 PM, Volker Simonis wrote: Resending this to more lists as requested by Alan Bateman with the kind request to anybody to review the parts for which he feels responsible:) For those not up to date, this change is part of the ongoing PowerPC/AIX Porting Project

[OpenJDK 2D-Dev] RFR(L): 8024854: Basic changes and files to build the class library on AIX

://wiki.openjdk.java.net/display/PPCAIXPort http://openjdk.java.net/jeps/175 Please send reviews to all currently included recipients. Thank you and best regards, Volker -- Forwarded message -- From: *Volker Simonis* Date: Monday, September 16, 2013 Subject: RFR(L): 8024854: Basic changes

Re: [OpenJDK 2D-Dev] NPE in X11FontManager.getDefaultPlatformFont

On Tuesday, June 11, 2013, Phil Race wrote: On 6/11/13 3:59 AM, Jiri Vanek wrote: I'm quite curious why OpenJDK can not have its fall-back font. And probably because nobody has taken care until now. I think it would be great if we could find a set of basic fonts which could be checked into

Re: [OpenJDK 2D-Dev] NPE in X11FontManager.getDefaultPlatformFont

Hi, I remember we had similar problems with a missing libfontconfig library an AIX and Neil Richards fixed that issue: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7068471 As far as I remember it was still reasonable in that context to continue even without libfontfonfig so please avoid

Re: [OpenJDK 2D-Dev] Request for review [XS]: The XRender backend fails to render any glyphs on 64-bit Big-endian architectures

Hughes gnu.and...@redhat.comwrote: - Original Message - On 5/6/2013 5:25 AM, Volker Simonis wrote: On Wed, May 1, 2013 at 9:30 PM, Phil Race philip.r...@oracle.com wrote: Volker .. thanks for the patch looks good although I ask that you break the source code lines at no more

Re: [OpenJDK 2D-Dev] Request for review [XS]: The XRender backend fails to render any glyphs on 64-bit Big-endian architectures

mentioned. But that's a totally different discussion :) Regards, Volker -phil. On 4/26/2013 7:02 AM, Volker Simonis wrote: Hi, I've found and fixed a problem of the XRender pipeline on 64-bit Big-endian architectures which leads to the effect that all AWT/Swing applications will run

Re: [OpenJDK 2D-Dev] YourKit Java Profiler Open Source License Request

Oprofile supports Java (see: http://oprofile.sourceforge.net/doc/setup-jit.html) or at least it did some years ago when I used it for the last time. However, depending on your Linux distro, it may be tricky to set up Oprofile (as far as I know, current version of Ubuntu =12 don't support Oprofile

[OpenJDK 2D-Dev] Request for review [XS]: The XRender backend fails to render any glyphs on 64-bit Big-endian architectures

Hi, I've found and fixed a problem of the XRender pipeline on 64-bit Big-endian architectures which leads to the effect that all AWT/Swing applications will run as expected but won't actually display any character glyphs at all! This seems to be a day-one bug which still exists in both, JDK7 and