On Mon, 23 Aug 2021 22:05:13 GMT, Daniel Gredler
wrote:
> During the recent JEP 381 removal of Solaris code, a few Solaris-specific
> constants and private methods were left behind in
> sun.font.TrueTypeGlyphMapper. This PR removes these unused odds and ends.
I do not have any objection to
On Mon, 23 Aug 2021 22:05:13 GMT, Daniel Gredler
wrote:
> During the recent JEP 381 removal of Solaris code, a few Solaris-specific
> constants and private methods were left behind in
> sun.font.TrueTypeGlyphMapper. This PR removes these unused odds and ends.
As per JEP 381, comments
On Tue, 17 Aug 2021 06:09:51 GMT, Alexander Zuev wrote:
>> Initial implementation and a test case.
>>
>> The problem is that Aqua LaF shows the focused component with the glow on
>> the border, hence when the border is not painted the foxus is not displayed.
>> The idea is to paint the
On Tue, 17 Aug 2021 06:04:39 GMT, Alexander Zuev wrote:
>> You can trace the usage of graphics.getColor() for example in
>> AquaMenuItemUI/WindowsMenuUI/BevelBorder/etc to check that the old color
>> property is usually saved and then restored.
>
>> You can trace the usage of
On Fri, 13 Aug 2021 06:18:49 GMT, Alexander Zuev wrote:
>> Initial implementation and a test case.
>>
>> The problem is that Aqua LaF shows the focused component with the glow on
>> the border, hence when the border is not painted the foxus is not displayed.
>> The idea is to paint the
On Thu, 12 Aug 2021 19:16:55 GMT, Phil Race wrote:
>> Applet support was removed already but the .html file was left as well as
>> docs on applet issues
>> and a parameter only relevant to applets.
>
> Phil Race has updated the pull request with a new target base due to a merge
> or a rebase.
On Wed, 11 Aug 2021 11:22:50 GMT, Alexander Zuev wrote:
> Initial implementation and a test case.
>
> The problem is that Aqua LaF shows the focused component with the glow on the
> border, hence when the border is not painted the foxus is not displayed. The
> idea is to paint the glowing
On Mon, 19 Jul 2021 20:50:14 GMT, Phil Race wrote:
> Applet support was removed already but the .html file was left as well as
> docs on applet issues
> and a parameter only relevant to applets.
src/demo/share/jfc/Font2DTest/Font2DTest.java line 272:
> 270: fileMenu.addSeparator();
>
On Mon, 19 Jul 2021 04:46:59 GMT, Prasanta Sadhukhan
wrote:
> This test fails to follow the test instruction which says ""On Top" print
> dialogs should stay behind the "Owner Window"
> but it seems to be the behaviour right from jdk11b18 where DialogOwner c
This test fails to follow the test instruction which says ""On Top" print
dialogs should stay behind the "Owner Window"
but it seems to be the behaviour right from jdk11b18 where DialogOwner class
and this test was inducted via JDK-8203796 not only in mac but in windows too
ie,
"On Top" print
On Tue, 8 Jun 2021 07:22:48 GMT, Ajit Ghaisas wrote:
>> This PR fixes an issue exclusively seen on Apple M1 systems when SwingSet2
>> demo is run with uiScale=1.0.
>>
>> **Issue :**
>> SwingSet2 Demo - As reported in JBS description
>> J2DDemo - As reported in a comment on JBS
>>
>> **Root
On Mon, 7 Jun 2021 12:03:35 GMT, Ajit Ghaisas wrote:
>> This PR fixes an issue exclusively seen on Apple M1 systems when SwingSet2
>> demo is run with uiScale=1.0.
>>
>> **Issue :**
>> SwingSet2 Demo - As reported in JBS description
>> J2DDemo - As reported in a comment on JBS
>>
>> **Root
On Wed, 5 May 2021 14:11:16 GMT, Matthias Baesken wrote:
>> In java/awt/font/TextJustifier.java justify-method there is a potential code
>> path where divison by zero might happen , see also the Sonar finding
>>
On Tue, 4 May 2021 15:00:29 GMT, Matthias Baesken wrote:
>> I meant that since we are dividing by weight and absorbweight
>> ` weightedDelta = delta / weight;`
>> and
>> weightedAbsorb = (delta - gslimit) / absorbweight;
>> where both weight and absorbweight uses += gi.weight values so if one
On Thu, 29 Apr 2021 07:57:17 GMT, Prasanta Sadhukhan
wrote:
> It seems the newly deproblemlisted test
> DrawRotatedStringUsingRotatedFont.java which is paasing in windows,linux-x64
> and macos-x64 is failing in newly added linux-aarch64 systems.
> Problemlisting the test for now a
It seems the newly deproblemlisted test DrawRotatedStringUsingRotatedFont.java
which is paasing in windows,linux-x64 and macos-x64 is failing in newly added
linux-aarch64 systems.
Problemlisting the test for now as it is font layout issue which might need
some upgrade in harfbuzz library in
.java.net> on behalf of Alexey Ivanov
Sent: Wednesday, April 7, 2021 4:22:29 PM
To: 2d-dev@openjdk.java.net <2d-dev@openjdk.java.net>
Subject: Re: [OpenJDK 2D-Dev] RFR: 8263984: Invalidate printServices when there
are no printers [v3]
On Wed, 7 Apr 2021 04:12:55 GMT, Prasanta Sadhukhan
On Tue, 6 Apr 2021 20:39:04 GMT, Alexey Ivanov wrote:
>> I added a blank line between the condition and the body.
>> Does it look good? @mrserb, @jayathirthrao
>
> [Code Conventions for
> Java](https://www.oracle.com/java/technologies/javase/codeconventions-indentation.html#248)
> say, “Line
On Thu, 1 Apr 2021 14:15:37 GMT, Jayathirth D V wrote:
>> In MTLBlitLoops.copyArea() we use standalone encoder which has no clip state
>> information because of which we ignore clip parameters set in rect clip and
>> shape clip. We need to query and use encoders from EncoderManager to honour
On Thu, 1 Apr 2021 05:49:51 GMT, Jayathirth D V wrote:
>> In MTLBlitLoops.copyArea() we use standalone encoder which has no clip state
>> information because of which we ignore clip parameters set in rect clip and
>> shape clip. We need to query and use encoders from EncoderManager to honour
On Wed, 24 Mar 2021 09:25:56 GMT, Alexey Ivanov wrote:
>> src/java.desktop/windows/classes/sun/print/PrintServiceLookupProvider.java
>> line 120:
>>
>>> 118: // don't get the default.
>>> 119: invalidateServices();
>>> 120: printServices = new
On Tue, 23 Mar 2021 13:45:33 GMT, Alexey Ivanov wrote:
> When `getAllPrinterNames()` returns null, the list of `printServices` is
> assigned a new empty array without invalidating old services which were in
> the array before.
>
> The old print services should be invalidated.
On Thu, 18 Mar 2021 12:29:01 GMT, Alexander Scherbatiy
wrote:
>> Printing text using GlyphVector outline has bad quality on printers with low
>> DPI on Windows.
>> The GDI system used for text printing on Windows accepts only integer path
>> coordinates.
>> Rounding GlyphVector outline
On Thu, 18 Mar 2021 22:59:57 GMT, Phil Race wrote:
> This removes a long time un-used code path.
Maybe we should put noreg-cleanup in JBS.
-
Marked as reviewed by psadhukhan (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/3083
On Wed, 10 Mar 2021 15:38:27 GMT, Alexey Ivanov wrote:
> [JDK-8153732](https://bugs.openjdk.java.net/browse/JDK-8153732) implemented
> polling for remote printers.
> That bug description also mentions watching the registry for changes and
> links to the article which describes the method yet
On Fri, 12 Mar 2021 12:30:13 GMT, Alexey Ivanov wrote:
>> I can understand that as a user, you cannot /shouldn't change the name of a
>> remote network printer but a network admin can change the name, so shouldn't
>> we get notification on that name change when this method gets called after
On Fri, 12 Mar 2021 11:29:17 GMT, Alexey Ivanov wrote:
>> Is this only about addition/removal? What about printer name change?
>> Shouldn't we get notified in that case as trying to print on printer with
>> old name will not find the printer!!
>> If yes, in that regard I guess
On Thu, 11 Mar 2021 18:00:15 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal
On Thu, 11 Mar 2021 18:00:15 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal
On Thu, 11 Mar 2021 14:59:55 GMT, Alexey Ivanov wrote:
>> [JDK-8153732](https://bugs.openjdk.java.net/browse/JDK-8153732) implemented
>> polling for remote printers.
>> That bug description also mentions watching the registry for changes and
>> links to the article which describes the method
On Thu, 11 Mar 2021 14:49:59 GMT, Alexey Ivanov wrote:
>> I also am not sure on this. But I think since this is for remote printer,
>> sometimes network availability issue might be there so it may fail more
>> compared to local printer so I guess we should give this method a fair
>> chance,
On Fri, 12 Mar 2021 00:48:58 GMT, Sergey Bylokhov wrote:
>> Ajit Ghaisas has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 47 additional
>>
On Thu, 11 Mar 2021 10:54:12 GMT, Alexey Ivanov wrote:
>> src/java.desktop/windows/native/libawt/windows/WPrinterJob.cpp line 259:
>>
>>> 257: NULL,
>>> 258: FALSE);
>>> 259:
On Wed, 10 Mar 2021 15:38:27 GMT, Alexey Ivanov wrote:
> [JDK-8153732](https://bugs.openjdk.java.net/browse/JDK-8153732) implemented
> polling for remote printers.
> That bug description also mentions watching the registry for changes and
> links to the article which describes the method yet
On Thu, 11 Mar 2021 06:45:05 GMT, Matthias Baesken wrote:
>> By that same logic, then shouldn't absorbweight also be checked as != 0
>> instead of > 0 as that also uses += gi.weight
>
> Hi, I am not sure about the absorbweight check; but currently the
> calculated value weightedAbsorb is
On Wed, 10 Mar 2021 18:48:50 GMT, Phil Race wrote:
>> Hi, I am not sure about the weight > 0 check ; weight is initialized with
>> 0: weight = 0; and later some values are potentially added up to weight:
>> weight += gi.weight;
>> I am not sure about those gi.weight values, maybe they
On Wed, 10 Mar 2021 12:31:31 GMT, Matthias Baesken wrote:
> In java/awt/font/TextJustifier.java justify-method there is a potential code
> path where divison by zero might happen , see also the Sonar finding
>
On Fri, 26 Feb 2021 19:40:22 GMT, Alexander Scherbatiy
wrote:
> Printing text using GlyphVector outline has bad quality on printers with low
> DPI on Windows.
> The GDI system used for text printing on Windows accepts only integer path
> coordinates.
> Rounding GlyphVector outline coordinates
On Fri, 26 Feb 2021 19:40:22 GMT, Alexander Scherbatiy
wrote:
> Printing text using GlyphVector outline has bad quality on printers with low
> DPI on Windows.
> The GDI system used for text printing on Windows accepts only integer path
> coordinates.
> Rounding GlyphVector outline coordinates
On Thu, 4 Mar 2021 21:37:33 GMT, Alexey Ivanov wrote:
> **Root cause:**
> `getPrinterNames()` has two calls to
> [`::EnumPrinters`](https://docs.microsoft.com/en-us/windows/win32/printdocs/enumprinters).
> The first call is to get the required buffer size to contain the structures
> and any
On Fri, 5 Mar 2021 03:42:29 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/windows/native/libawt/windows/WPrinterJob.cpp line 136:
>>
>>> 134:
>>> 135: try {
>>> 136: ::EnumPrinters(flags, NULL, 4, NULL,
>>
>> Don't we nee
On Fri, 5 Mar 2021 01:27:47 GMT, Sergey Bylokhov wrote:
>> **Root cause:**
>> `getPrinterNames()` has two calls to
>> [`::EnumPrinters`](https://docs.microsoft.com/en-us/windows/win32/printdocs/enumprinters).
>> The first call is to get the required buffer size to contain the structures
>>
On Wed, 24 Feb 2021 18:34:31 GMT, Phil Race wrote:
> This upgrades JDK (Java2D) from using freetype 2.10.2 to 2.10.4.
> A minor upgrade but there's been some refactoring of include files so most
> files are touched.
> Testing looks good.
Marked as reviewed by psadhukhan (Reviewer).
On Mon, 21 Dec 2020 07:54:17 GMT, Andrey Turbanov
wrote:
> Cleanup code to use new handy methods in
> `java.io.InputStream`/`java.nio.file.Files` instead of manual stream copy:
> 1. java.io.InputStream#readAllBytes
> 2. java.io.InputStream#transferTo
> 3. java.nio.file.Files#copy
>
> Similar
On Tue, 9 Feb 2021 11:57:44 GMT, Prasanta Sadhukhan
wrote:
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
On Wed, 17 Feb 2021 03:21:03 GMT, Prasanta Sadhukhan
wrote:
> This test was timing out in windows in mach5 nightly testing. Investigation
> reveals that 70% of the time, it is failing due to printer being chosen was
> Microsoft Print to PDF which opens up a File Save Dialog
gain gets
> focus and obscure pagedialog so PageDialog did not get dismissed.
> Updated test to ignore "Print To PDF", "OneNote" and "XPS Document
> Writer"(which again opens filedialog like PDF printer) and run it for several
> iteration in mach5 platforms wh
On Thu, 18 Feb 2021 03:40:24 GMT, Prasanta Sadhukhan
wrote:
>>> Maybe @key printer is not being taken seriously during system setup which
>>> is why no real printer is being used.
>>
>> That should be irrelevant. jtreg should only be invoking tests which do NO
On Wed, 17 Feb 2021 18:50:11 GMT, Phil Race wrote:
> That should be irrelevant. jtreg should only be invoking tests which do NOT
> have the printer keyword since the test job has this : keywords=headful &
> !printer which are handed directly to jtreg. In other words it is not
> filtering on
On Wed, 17 Feb 2021 18:50:11 GMT, Phil Race wrote:
>> Maybe @key printer is not being taken seriously during system setup which is
>> why no real printer is being used.
>
>> Maybe @key printer is not being taken seriously during system setup which is
>> why no real printer is being used.
>
>
On Wed, 17 Feb 2021 18:02:49 GMT, Phil Race wrote:
>> This test was timing out in windows in mach5 nightly testing. Investigation
>> reveals that 70% of the time, it is failing due to printer being chosen was
>> Microsoft Print to PDF which opens up a File Save Dialog when "OK" was
>> clicked
On Wed, 17 Feb 2021 18:05:41 GMT, Prasanta Sadhukhan
wrote:
>> The problem I have with this is that it does not scale.
>> It is a maintenance nightmare every possible "file printer" on Windows to
>> every test.
>> and back porting it too ?
>> remov
On Wed, 17 Feb 2021 17:34:22 GMT, Alexander Zuev wrote:
>> This test was timing out in windows in mach5 nightly testing. Investigation
>> reveals that 70% of the time, it is failing due to printer being chosen was
>> Microsoft Print to PDF which opens up a File Save Dialog when "OK" was
>>
On Wed, 17 Feb 2021 15:55:04 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> javadoc change
>
> Marked as reviewed by aivanov (Reviewer).
Thanks @aivan
ception when it encounters a
> null argument.
> Updated spec to rectify this.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
javadoc change
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2476/fi
ception when it encounters a
> null argument.
> Updated spec to rectify this.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
javadoc change
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2476/fi
On Wed, 17 Feb 2021 15:25:35 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> javadoc change
>
> src/java.desktop/share/classes/java/awt/Graphic
ception when it encounters a
> null argument.
> Updated spec to rectify this.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
javadoc change
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2476/fi
On Wed, 17 Feb 2021 14:20:47 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> javdoc tag for NPE
>
> src/java.desktop/share/classes/java/awt/Graphic
ception when it encounters a
> null argument.
> Updated spec to rectify this.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
javadoc change
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2476/fi
On Mon, 15 Feb 2021 12:44:28 GMT, Prasanta Sadhukhan
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() an
This test was timing out in windows in mach5 nightly testing. Investigation
reveals that 70% of the time, it is failing due to printer being chosen was
Microsoft Print to PDF which opens up a File Save Dialog when "OK" was clicked
in printer pagedialog. Since no user intervention is done to
On Fri, 12 Feb 2021 14:42:30 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment fix. Test updated
>
> src/java.desktop/share/classes/java
On Tue, 9 Feb 2021 11:57:44 GMT, Prasanta Sadhukhan
wrote:
> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
> would actually clear the existing clipping area, which is incorrect.
> This statement is applicable only to G2D.setClip() and not for the clip()
ception when it encounters a
> null argument.
> Updated spec to rectify this.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
javdoc tag for NPE
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2476/fi
On Thu, 11 Feb 2021 18:42:30 GMT, Phil Race wrote:
> The various CF*Copy* functions called here need a matching CFRelease
src/java.desktop/macosx/native/libawt_lwawt/font/AWTFont.m line 578:
> 576: (*env)->CallBooleanMethod(env, arrayListOfString, addMID,
> jFontName);
> 577:
On Thu, 11 Feb 2021 18:42:30 GMT, Phil Race wrote:
> The various CF*Copy* functions called here need a matching CFRelease
src/java.desktop/macosx/native/libawt_lwawt/font/AWTFont.m line 575:
> 573: #endif
> 574: jstring jFontName = (jstring)NSStringToJavaString(env, fontname);
> 575:
On Fri, 12 Feb 2021 04:42:34 GMT, Prasanta Sadhukhan
wrote:
>> The various CF*Copy* functions called here need a matching CFRelease
>
> src/java.desktop/macosx/native/libawt_lwawt/font/AWTFont.m line 575:
>
>> 573: #endif
>> 574: jstring jFontName = (jstri
ception when it encounters a
> null argument.
> Updated spec to rectify this.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Review comment fix. Test updated
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/
ception when it encounters a
> null argument.
> Updated spec to rectify this.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Fix as per Phil's comment
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2476/fi
On Wed, 10 Feb 2021 13:10:15 GMT, Prasanta Sadhukhan
wrote:
> Fix a typo in Rectangle2D.add(double, double) and add(Point2D pt). It has
> already been fixed in Rectangle.add(int, int)
> https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/Rectangle.
Fix a typo in Rectangle2D.add(double, double) and add(Point2D pt). It has
already been fixed in Rectangle.add(int, int)
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/java/awt/Rectangle.java#L921
-
Commit messages:
- 4841153:
On Tue, 9 Feb 2021 12:29:52 GMT, Ajit Ghaisas wrote:
>> **Description :**
>> This is the implementation of [JEP 382 : New macOS Rendering
>> Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361)
>> It implements a Java 2D internal rendering pipeline for macOS using the
>> Apple Metal
On Mon, 8 Feb 2021 09:30:02 GMT, Prasanta Sadhukhan
wrote:
> Constructor AreaAveragingScaleFilter(int, int) for
> java.awt.image.AreaAveragingScaleFilter class throws IllegalArgumentException
> when 0 is passed for width,height but it's not specified in the spec.
> Updated spec t
On Wed, 3 Feb 2021 12:11:40 GMT, Prasanta Sadhukhan
wrote:
> Method createStrokedShape(Shape) for java.awt.BasicStroke class throws
> NullPointerException when passed a null object reference for a input
> parameter but it's not specified in the spec.
> Updated spec t
ception when it encounters a
> null argument.
> Updated spec to rectify this.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Fix
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2476/fi
ception when it encounters a
> null argument.
> Updated spec to rectify this.
Prasanta Sadhukhan has updated the pull request incrementally with three
additional commits since the last revision:
- Fix
- Document setClip(null) behaviour too
- Document setClip(null) behaviour too
-
On Wed, 10 Feb 2021 04:47:05 GMT, Sergey Bylokhov wrote:
>> I am not sure if it's implementation bug. As Jim Graham has mentioned in
>> thebug,
>>
>>> clip(null) is not legal.
>>>
>>> It is *setClip*(null) that clears the clip.
>> I could rephrase the doc to specify NPE willbe thrrown for
On Tue, 9 Feb 2021 18:10:44 GMT, Sergey Bylokhov wrote:
>>> Also, if there is no clip set, then the spec statement " If s is null, this
>>> method clears the current Clip" does not carry any meaning, so in both
>>> regard, setClip() should be there, I presume.
>>
>> The old javadoc is
On Tue, 9 Feb 2021 12:52:55 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/java/awt/Graphics2D.java line 1206:
>>
>>> 1204: * @param s the {@code Shape} to be intersected with the current
>>> 1205: * {@code C
On Tue, 9 Feb 2021 12:48:44 GMT, Alexander Zvegintsev
wrote:
>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument
>> would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip()
>>
The API doc for Graphics2D.clip(shape s) claims that passing a null argument
would actually clear the existing clipping area, which is incorrect.
This statement is applicable only to G2D.setClip() and not for the clip()
method. G2D.clip() would throw a NullPointerException when it encounters a
> Method createStrokedShape(Shape) for java.awt.BasicStroke class throws
> NullPointerException when passed a null object reference for a input
> parameter but it's not specified in the spec.
> Updated spec to illustrate this.
Prasanta Sadhukhan has updated the pull request i
Constructor AreaAveragingScaleFilter(int, int) for
java.awt.image.AreaAveragingScaleFilter class throws IllegalArgumentException
when 0 is passed for width,height but it's not specified in the spec.
Updated spec to illustrate this.
-
Commit messages:
- Fix
- Fix
- 6211242:
> Method createStrokedShape(Shape) for java.awt.BasicStroke class throws
> NullPointerException when passed a null object reference for a input
> parameter but it's not specified in the spec.
> Updated spec to illustrate this.
Prasanta Sadhukhan has updated the pull request i
On Wed, 3 Feb 2021 23:34:01 GMT, Sergey Bylokhov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Doc change to @throws
>
> src/java.desktop/share/classes/java/awt/BasicS
On Thu, 4 Feb 2021 01:56:57 GMT, Sergey Bylokhov wrote:
> Some broken data in the InputStream may cause the wrong exception to be
> thrown - ArrayIndexOutOfBoundsException instead of IllegalArgumentException,
> if the data is too small and we try to validate it.
Marked as reviewed by
On Wed, 3 Feb 2021 07:04:22 GMT, Prasanta Sadhukhan
wrote:
> Document setting null setColor similar to way setFont(null) is documented.
This pull request has now been integrated.
Changeset: 60f440de
Author: Prasanta Sadhukhan
URL: https://git.openjdk.java.net/jdk/commit/60f44
> Method createStrokedShape(Shape) for java.awt.BasicStroke class throws
> NullPointerException when passed a null object reference for a input
> parameter but it's not specified in the spec.
> Updated spec to illustrate this.
Prasanta Sadhukhan has updated the pull request i
Method createStrokedShape(Shape) for java.awt.BasicStroke class throws
NullPointerException when passed a null object reference for a input parameter
but it's not specified in the spec.
Updated spec to illustrate this.
-
Commit messages:
- 6211257:
> Document setting null setColor similar to way setFont(null) is documented.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the last revision:
Add test
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2371/files
-
On Wed, 3 Feb 2021 07:57:17 GMT, Sergey Bylokhov wrote:
>>>
>>>
>>> @mrserb has indicated that a [compatibility and
>>> specification](https://wiki.openjdk.java.net/display/csr/Main) (CSR)
>>> request is needed for this pull request.
>>> @prsadhuk please create a CSR request and add link to
On Wed, 3 Feb 2021 07:38:02 GMT, Pankaj Bansal wrote:
>> Document setting null setColor similar to way setFont(null) is documented.
>
> Marked as reviewed by pbansal (Reviewer).
>
>
> @mrserb has indicated that a [compatibility and
>
Document setting null setColor similar to way setFont(null) is documented.
-
Commit messages:
- 6436374: Graphics.setColor(null) is not documented
Changes: https://git.openjdk.java.net/jdk/pull/2371/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk=2371=00
Issue:
On Wed, 3 Feb 2021 05:41:23 GMT, Prasanta Sadhukhan
wrote:
> This test require a printer to test its objective, so printer existence check
> is added.
This pull request has now been integrated.
Changeset: cb127a4b
Author:Prasanta Sadhukhan
URL: https://git.openjdk.java.n
This test require a printer to test its objective, so printer existence check
is added.
-
Commit messages:
- 8198343: Test java/awt/print/PrinterJob/TestPgfmtSetMPA.java may fail w/o
printer
- 8198343: Test java/awt/print/PrinterJob/TestPgfmtSetMPA.java may fail w/o
printer
On Wed, 3 Feb 2021 04:01:51 GMT, Sergey Bylokhov wrote:
> Trivial cleanup, the "default" license header is removed in a few components.
Marked as reviewed by psadhukhan (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2368
On Fri, 29 Jan 2021 23:46:14 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Toolkit.h line 478:
>>
>>> 476: BOOL m_breakOnError;
>>> 477:
>>> 478: volatile BOOL m_breakMessageLoop;
>>
>> Does this volatile modifier resolve the now-removed infinite
> This test was failing in our nightly mach5 testing. Appropriate stability
> code in form of waitForIdle and delay is added.
> mach5 job running for several iterations on all platforms is ok. Link in JBS.
Prasanta Sadhukhan has updated the pull request incrementally with one
addition
On Thu, 28 Jan 2021 19:50:56 GMT, Sergey Bylokhov wrote:
>>>
>>> My point is that this is not a test bug, so the test should not be changed.
>>
>> The test never dispose of the frame. Why is it expected to shut down the
>> toolkit? Shall the frame be disposed of when the main thread in the
1 - 100 of 537 matches
Mail list logo
