Re: [OpenJDK 2D-Dev] [8] request for review JDK-8000176

2012-10-05 Thread Vadim Pakhnushev
Phil, I've added these 2 lines to the test, Andrew will push updated version. Thanks, Vadim On 05.10.2012 0:08, Phil Race wrote: I'm OK with it too although since xrender isn't applicable to Windows, either True or false is actually testing the default (hopefully d3d) pipeline there. If you

Re: [OpenJDK 2D-Dev] [8] request for review JDK-8000176

2012-10-04 Thread Phil Race
I'm OK with it too although since xrender isn't applicable to Windows, either True or false is actually testing the default (hopefully d3d) pipeline there. If you wanted to thoroughly test , including windows as well you could add 2 more lines @run main/othervm -Dsun.java2d.d3d=false

Re: [OpenJDK 2D-Dev] [8] request for review JDK-8000176

2012-10-03 Thread Vadim Pakhnushev
Hello, I've made changes according to Andrew Brygin's feedback: Created unified drawTestImage method so reference and tested images are rendered from one place. Simplified renderImage method to eliminate nested while loop. webrev: http://cr.openjdk.java.net/~bae/8000176/webrev.01/ Thanks,

Re: [OpenJDK 2D-Dev] [8] request for review JDK-8000176

2012-10-03 Thread Andrew Brygin
Hello Vadim, the test looks fine to me. Thanks, Andrew On 03.10.2012 17:41, Vadim Pakhnushev wrote: Hello, I've made changes according to Andrew Brygin's feedback: Created unified drawTestImage method so reference and tested images are rendered from one place. Simplified renderImage method

[OpenJDK 2D-Dev] [8] request for review JDK-8000176

2012-09-28 Thread Vadim Pakhnushev
Hello, Please review automated test which checks that accelerated pipelines correctly use interpolation rendering hints. Discussion of the bug for which the test was created: http://mail.openjdk.java.net/pipermail/2d-dev/2012-September/002767.html webrev: