ober 19, 2015 4:03 PM
To: Jayathirth D V; Sergey Bylokhov; 2d-dev@openjdk.java.net; Philip
Race
Subject: Re: [OpenJDK 2D-Dev] Review request for
JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing
Hi Jay,
I'm sorry, actually the usage of Float.compare was perfectly fine in your case,
g
: [OpenJDK 2D-Dev] Review request for JDK-7182758:
BMPMetadata returns invalid PhysicalPixelSpacing
+1
On 20.10.2015 8:31, Jayathirth D V wrote:
Hi Vadim,
Thanks for throwing light on performance aspect of Boxing & Unboxing in Java.
I have made changes, so that we use Float.com
et; Philip Race
Subject: Re: [OpenJDK 2D-Dev] Review request for JDK-7182758:
BMPMetadata returns invalid PhysicalPixelSpacing
Hi Jay,
I'm sorry, actually the usage of Float.compare was perfectly fine in your case,
given that you were comparing floats (not Floats).
The thing which caught my eye w
V; Sergey Bylokhov; 2d-dev@openjdk.java.net; Philip Race
Subject: Re: [OpenJDK 2D-Dev] Review request for JDK-7182758:
BMPMetadata returns invalid PhysicalPixelSpacing
Hi Jay,
I'm sorry, actually the usage of Float.compare was perfectly fine in your case,
given that you were comparing floats (
; Sergey Bylokhov; 2d-dev@openjdk.java.net; Philip Race
Subject: Re: [OpenJDK 2D-Dev] Review request for JDK-7182758:
BMPMetadata returns invalid PhysicalPixelSpacing
Hi Jay,
What's the point of using Float.compare in the test?
Why not just check if
(horizontalNodeValue.equals(expectedHorizontalValue
; 2d-dev@openjdk.java.net; Philip Race
Subject: Re: [OpenJDK 2D-Dev] Review request for JDK-7182758:
BMPMetadata returns invalid PhysicalPixelSpacing
Hi Jay,
What's the point of using Float.compare in the test?
Why not just check if
(horizontalNodeValue.equals(expectedHorizontalValue)) ?
Also
ebrev.02/
Thanks,
Jay
*From:* Jayathirth D V
*Sent:* Monday, October 12, 2015 2:15 PM
*To:* 2d-dev@openjdk.java.net; Philip Race; Sergey Bylokhov
*Subject:* [OpenJDK 2D-Dev] Review request for
JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing
Hello All,
Made small change on how
sage-
> From: Vadim Pakhnushev
> Sent: Monday, October 19, 2015 4:03 PM
> To: Jayathirth D V; Sergey Bylokhov; 2d-dev@openjdk.java.net; Philip
> Race
> Subject: Re: [OpenJDK 2D-Dev] Review request for
> JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing
>
> Hi Jay,
&g
;> On 13.10.15 11:12, Jayathirth D V wrote:
>>> Hello All,
>>>
>>> Removed Trailing whitespace present in code.
>>>
>>> Please find updated webrev link:
>>>
>>> http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.02/
>>>
>>>
m:* Jayathirth D V
*Sent:* Monday, October 12, 2015 2:15 PM
*To:* 2d-dev@openjdk.java.net; Philip Race; Sergey Bylokhov
*Subject:* [OpenJDK 2D-Dev] Review request for
JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing
Hello All,
Made small change on how we need to represent floating point c
; Thanks,
>
> Jay
>
> *From:* Jayathirth D V
> *Sent:* Monday, October 12, 2015 2:15 PM
> *To:* 2d-dev@openjdk.java.net; Philip Race; Sergey Bylokhov
> *Subject:* [OpenJDK 2D-Dev] Review request for
> JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing
>
> Hel
,
Jay
*From:* Jayathirth D V
*Sent:* Thursday, October 08, 2015 2:20 PM
*To:* 2d-dev@openjdk.java.net <mailto:2d-dev@openjdk.java.net>; Philip
Race; Sergey Bylokhov
*Subject:* [OpenJDK 2D-Dev] Review request for
JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing
Hello All,
Plea
Bylokhov
Subject: [OpenJDK 2D-Dev] Review request for JDK-7182758:
BMPMetadata returns invalid PhysicalPixelSpacing
Hello All,
Made small change on how we need to represent floating point constant in
Java(1000.0 -> 1000.0F).
Please find updated Webrev link:
Webrev : h
*Subject:* [OpenJDK 2D-Dev] Review request for
JDK-7182758: BMPMetadata returns invalid PhysicalPixelSpacing
Hello All,
Made small change on how we need to represent floating point constant in
Java(1000.0 -> 1000.0F).
Please find updated Webrev link:
Webrev : http://cr.openjdk.java.
ent: Thursday, October 08, 2015 2:20 PM
To: 2d-dev@openjdk.java.net; Philip Race; Sergey Bylokhov
Subject: [OpenJDK 2D-Dev] Review request for JDK-7182758:
BMPMetadata returns invalid PhysicalPixelSpacing
Hello All,
Please review following fix in jdk9:
Bug : https://bugs.openjdk.java.
Hello All,
Please review following fix in jdk9:
Bug : https://bugs.openjdk.java.net/browse/JDK-7182758
Webrev : http://cr.openjdk.java.net/~rchamyal/jay/7182758/webrev.00/
Bug : BMPMetadata returns invalid PhysicalPixelSpacing
Root cause : Whenever XPixelsPerMter or
16 matches
Mail list logo
