Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

2013-11-21 Thread Alan Bateman
On 20/11/2013 18:26, Volker Simonis wrote: Hi, this is the second review round for 8024854: Basic changes and files to build the class library on AIX https://bugs.openjdk.java.net/browse/JDK-8024854. The previous reviews can be found at the end of this mail in the references section. I've

Re: [OpenJDK 2D-Dev] JDK-7107175 - Paper tray handling

2013-11-21 Thread Phil Race
What would be the correct solution for this problem? Which problem ? 7107175 sounds like a bug in the parameters we pass to lpr The other problem you mention is largely if not entirely because IPP lumped trays along with papers as being Media. See

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-21 Thread Jim Graham
Hi Alexander, I just noticed that the new interface was created in com.sun. I also note that you discuss a number of issues below that relate to a developer creating one of their own Multi-Resolution images. We should not be exporting an interface at this point for a developer to do any of

Re: [OpenJDK 2D-Dev] JDK-7107175 - Paper tray handling

2013-11-21 Thread Patrick Reinhart
Hi Phil, Am 21.11.2013 um 23:08 schrieb Phil Race philip.r...@oracle.com: What would be the correct solution for this problem? Which problem ? 7107175 sounds like a bug in the parameters we pass to lpr The other problem you mention is largely if not entirely because IPP lumped trays

Re: [OpenJDK 2D-Dev] request for review: JDK-8028722: XRender: Drawing strings with exactly 254 glyphs causes hangs

2013-11-21 Thread Clemens Eisserer
Hi Phil, Thanks for the review. Not that it impacts us now but I think the tricky question is can we ever remove the workaround? ie how will we ever know when we are using a fixed xrender lib. I'd like to see core Xrender add a GetVersion() API so we can figure this stuff out at runtime.

Re: [OpenJDK 2D-Dev] JDK-7107175 - Paper tray handling

2013-11-21 Thread Phil Race
On 11/21/2013 2:52 PM, Patrick Reinhart wrote: Hi Phil, Am 21.11.2013 um 23:08 schrieb Phil Race philip.r...@oracle.com: What would be the correct solution for this problem? Which problem ? 7107175 sounds like a bug in the parameters we pass to lpr The other problem you mention is largely

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-21 Thread Alexander Scherbatiy
Could you review the updated fix: http://cr.openjdk.java.net/~alexsch/8011059/webrev.09/ On 11/20/2013 3:55 AM, Jim Graham wrote: Hi Alexander: SunHints: ON - Always use resolution-specific variants of images OFF - Use only the standard resolution of an image DEFAULT - Choose image

[OpenJDK 2D-Dev] JDK-7107175 - Paper tray handling

2013-11-21 Thread Patrick Reinhart
Hi everybody, I would like to look into this defect as one of our customer has reported the same problem. I also have seen that there is no way to specify a media size name and a output tray neither thru the PrintRequestAttributeSet nor the DocAttributeSet even-though it's possible to do so

Re: [OpenJDK 2D-Dev] [2d dev] [8] Review request for JDK-8028272 : Tidy warnings cleanup for javax.print package

2013-11-21 Thread Sergey Lugovoy
Sergey, you are right, in some cases (i.e. at the end of package-summary.html) the closing tag /p works exactly like br. I can submit another change; note however, that /p is not mandatory for p; br works exactly like /p here; and line break was the intention of the author. Should I make new

Re: [OpenJDK 2D-Dev] RFR(L) - 2nd round: 8024854: Basic changes and files to build the class library on AIX

2013-11-21 Thread Volker Simonis
Hi Alan, thanks a lot for the fast review and your valuable comments. Please find my answers inline: On Thu, Nov 21, 2013 at 1:01 PM, Alan Bateman alan.bate...@oracle.comwrote: On 20/11/2013 18:26, Volker Simonis wrote: Hi, this is the second review round for 8024854: Basic changes and

Re: [OpenJDK 2D-Dev] [2d dev] [8] Review request for JDK-8028272 : Tidy warnings cleanup for javax.print package

2013-11-21 Thread Sergey Lugovoy
Hi Joe. In most cases the author used this stray p as a line break. A line break is necessary indeed but if it is followed by a block element, it is considered erroneous by tidy. So adding br does, in fact, better correspond to the author original idea. On Wednesday, November 20, 2013

Re: [OpenJDK 2D-Dev] AWT Dev [8] Review request for 8011059 [macosx] Make JDK demos look perfect on retina displays

2013-11-21 Thread Alexander Scherbatiy
On 11/20/2013 3:17 PM, Jim Graham wrote: In looking through the ToolkitImage code some more it occurs to me that it was already designed (moreso in a previous life) to hold onto multiple representations of the image anyway. In a prior life in 1.0 and 1.1 it held separate ImageRepresentation