I don't see that this changes the spec. in a way that needs a CSR.
So I'll review it but it is possible that you may be told it can be
withdrawn as unnecessary.
FYI I reviewed this mostly by reading the specdiff so I wasn't looking
directly at source only changes like line length.
I'm not sure
Hello.
CSR is created:
https://bugs.openjdk.java.net/browse/JDK-8186753
On 21.08.17 20:03, Sergey Bylokhov wrote:
On 13.08.2017 23:23, Prasanta Sadhukhan wrote:
In that case, will this be required to have 2nd part?
43 * {@link DocFlavor DocFlavor}
There are manyof them in other files too like
On 13.08.2017 23:23, Prasanta Sadhukhan wrote:
In that case, will this be required to have 2nd part?
43 * {@link DocFlavor DocFlavor}
There are manyof them in other files too like DocFlavor.java
1206 * stream ({@link java.io.Reader java.io.Reader} Other than that, it
looks ok to me (btw, I have
Hi Sergey,
On 8/12/2017 5:38 AM, Sergey Bylokhov wrote:
Hi, Prasanta.
Thank you for review!
The new version:
http://cr.openjdk.java.net/~serb/8184435/webrev.08/
webrev diff v07 vs v08:
http://cr.openjdk.java.net/~serb/8184435/webrev.08/v7_v8.diff
See comments inline.
On 07.08.2017 3:29, Pras
Hi, Prasanta.
Thank you for review!
The new version:
http://cr.openjdk.java.net/~serb/8184435/webrev.08/
webrev diff v07 vs v08:
http://cr.openjdk.java.net/~serb/8184435/webrev.08/v7_v8.diff
See comments inline.
On 07.08.2017 3:29, Prasanta Sadhukhan wrote:
Hi Sergey, javax/print/Doc.java 52 *
Hi Sergey, javax/print/Doc.java 52 * {@link javax.print.attribute}
should be {@link javax.print.attribute javax.print.attribute}, I guess
83 * interface Doc should be interface {@code Doc}
javax/print/DocFlavor.java
347 * {@link java.awt.datatransfer.DataFlavor}. should be {@link
java.awt.da
Any volunteers? =)
On 16.07.2017 16:42, Sergey Bylokhov wrote:
Hello,
Please review the fix for jdk10.
The cleanup was done in the same way as for datatransfer, sound and
accessibility packages(see links in the CR).
I suggest to check the specdiff first, because for some methods the
specific
