Re: [f2fs-dev] [PATCH] f2fs: introduce device aliasing file

2024-09-19 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/14 5:28, Daeho Jeong wrote: From: Daeho Jeong F2FS should understand how the device aliasing file works and support deleting the file after use. A device aliasing file can be created by mkfs.f2fs tool and it can map the whole device with an extrent, not using node blocks. The file spa

Re: [f2fs-dev] [PATCH v2 2/2] mkfs.f2fs: add device aliasing feature

2024-09-19 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/17 3:20, Daeho Jeong wrote: From: Daeho Jeong We can add a device aliasing file which can map the whole device with an extent, not using node blocks. This mapped area should be pinned and normally used for read-only usages. After finished using it, we can deallocate the whole area and

Re: [f2fs-dev] [PATCH v2 2/2] f2fs: introduce get_section_mtime

2024-09-18 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/19 10:23, Zhiguo Niu wrote: Chao Yu via Linux-f2fs-devel 于2024年9月18日周三 14:45写道: On 2024/9/12 14:40, liuder...@oppo.com wrote: From: liuderong When segs_per_sec is larger than 1, section may contain free segments, mtime should be the mean value of each valid segments, so introduce

Re: [f2fs-dev] [PATCH v3 2/2] f2fs: introduce f2fs_get_section_mtime

2024-09-18 Thread Chao Yu via Linux-f2fs-devel
. Signed-off-by: liuderong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2 1/2] mkfs.f2fs: change -c option description

2024-09-18 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/17 3:20, Daeho Jeong wrote: From: Daeho Jeong Current description confuses users like they can add addtional devices with one -c option using commas(,) at the same time. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks

Re: [f2fs-dev] [PATCH] f2fs: allow F2FS_IPU_NOCACHE for pinned file

2024-09-18 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/15 11:22, Jaegeuk Kim via Linux-f2fs-devel wrote: This patch allows f2fs to submit bios of in-place writes on pinned file. Signed-off-by: Jaegeuk Kim Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2 2/2] f2fs: introduce get_section_mtime

2024-09-17 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/12 14:40, liuder...@oppo.com wrote: From: liuderong When segs_per_sec is larger than 1, section may contain free segments, mtime should be the mean value of each valid segments, so introduce get_section_mtime to exclude free segments in a section. Signed-off-by: liuderong --- fs/f

Re: [f2fs-dev] [PATCH v5] f2fs: zone: don't block IO if there is remained open zone

2024-09-17 Thread Chao Yu via Linux-f2fs-devel
Ping. On 2024/4/22 14:29, Chao Yu wrote: max open zone may be larger than log header number of f2fs, for such case, it doesn't need to wait last IO in previous zone, let's introduce available_open_zone semaphore, and reduce it once we submit first write IO in a zone, and increas

Re: [f2fs-dev] [PATCH v2 1/2] f2fs: use per-log target_bitmap to improve lookup performace of ssr allocation

2024-09-17 Thread Chao Yu via Linux-f2fs-devel
On 2024/5/31 9:10, Chao Yu wrote: On 2024/5/31 7:39, Jaegeuk Kim wrote: On 05/29, Chao Yu wrote: Ping, Jaegeuk, Chao, sorry, I might need some time to take a look at the change cautiously. No problem, I've done some tests on this patch, though, I will keeping this in my queue, a

Re: [f2fs-dev] [linus:master] [f2fs] 5c8764f867: xfstests.generic.091.fail

2024-09-12 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/12 21:50, kernel test robot wrote: Hello, kernel test robot noticed "xfstests.generic.091.fail" on: commit: 5c8764f8679e659c5cb295af7d32279002d13735 ("f2fs: fix to force buffered IO on inline_data inode") https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master Can

Re: [f2fs-dev] [PATCH v2] f2fs: forcibly migrate to secure space for zoned device file pinning

2024-09-12 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/13 0:59, Daeho Jeong wrote: From: Daeho Jeong We need to migrate data blocks even though it is full to secure space for zoned device file pinning. Signed-off-by: Daeho Jeong Fixes: 9703d69d9d15 ("f2fs: support file pinning for zoned devices") Reviewed-by: Chao Y

Re: [PATCH] erofs: allocate more short-lived pages from reserved pool first

2024-09-12 Thread Chao Yu via Linux-erofs
pressure from erofs. [1] For additional details on the multi-app launch benchmarks, please refer to commit 0f6273ab4637 ("erofs: add a reserved buffer pool for lz4 decompression"). Signed-off-by: Chunhai Guo Reviewed-by: Chao Yu Thanks,

Re: [PATCH] erofs: sunset unneeded NOFAILs

2024-09-12 Thread Chao Yu via Linux-erofs
act as placeholders to avoid in-place pages. They will be parsed just before decompression and then pass back to `.read_folio()`. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH] erofs: reject inodes with negative i_size

2024-09-12 Thread Chao Yu via Linux-erofs
): H4sICCmk4mYAA3Rlc3QuaW1nAGNgGAWjYBSMVPDo4dcH3jP2aTED2TwMKgxMUHHNJY/SQDQX LxcDIw3tZwXit44MDNpQ/n8gQJZ/vxjijosPuSyZ0DUDgQqcZoKzVYFsDShbHeh6PT29ktTi Eqz2g/y2pBFiLxDMh4lhs5+W4TAKRsEoGAWjYBSMglEwCkYBPQAAS2DbowAQAAA= Mark as bad inodes for such corrupted inodes explicitly. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH] erofs: restrict pcluster size limitations

2024-09-12 Thread Chao Yu via Linux-erofs
archival purposes), but there may be performance penalties in low-memory scenarios compared to smaller pclusters. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [PATCH v2 00/13] f2fs: introduce inline tail

2024-09-12 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/11 11:57, Wu Bo wrote: The inode in F2FS occupies an entire 4k block. For many small files, this means they consume much more space than their actual size. Therefore, there is significant potential to better utilize the inode block space. Currently, F2FS has two features to make use of

Re: [f2fs-dev] [PATCH 0/9] f2fs: new mount API conversion

2024-09-11 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/11 10:04, Hongbo Li wrote: Is the subject of the email required to be [f2fs-dev][PATCH]? Hongbo, "[f2fs-dev]" prefix is added by f2fs mailing list when it forwards your patch to someone who subscribes the list, if you receive a patch w/o f2fs-dev prefix, it is because you Sent/Cced p

Re: [f2fs-dev] [PATCH v1 2/2] f2fs: introduce get_section_mtime

2024-09-11 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/11 10:40, liuder...@oppo.com wrote: From: liuderong When segs_per_sec is larger than 1, section may contain free segments, mtime should be the mean value of each valid segments, so introduce get_section_mtime to exclude free segments in a section. Signed-off-by: liuderong --- fs/f

Re: [f2fs-dev] [PATCH v1 1/2] f2fs: remove unused parameters

2024-09-11 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/11 10:40, liuder...@oppo.com wrote: From: liuderong Remove unused parameter segno from f2fs_usable_segs_in_sec. Signed-off-by: liuderong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel

Re: [f2fs-dev] [RFC PATCH] f2fs: don't set SBI_QUOTA_NEED_REPAIR flag if receive SIGKILL

2024-09-11 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/4 11:49, Chao Yu via Linux-f2fs-devel wrote: On 2024/9/3 14:06, wangzijie wrote: From: Chao Yu via Linux-f2fs-devel On 2024/8/27 14:22, wangzijie wrote: Thread A -dquot_initialize   -dqget    -f2fs_dquot_acquire     -v2_read_dquot -qtree_read_dquot   -find_tree_dqentry

Re: [f2fs-dev] [PATCH] f2fs: fix to tag STATX_DIOALIGN only if inode support dio

2024-09-10 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/11 1:06, Eric Biggers wrote: On Tue, Sep 10, 2024 at 08:57:53PM +0800, Chao Yu via Linux-f2fs-devel wrote: After commit 5c8764f8679e ("f2fs: fix to force buffered IO on inline_data inode"), f2fs starts to force using buffered IO on inline_data inode. And also, it

Re: [f2fs-dev] [PATCH v2 7/7] f2fs: add valid block ratio not to do excessive GC for one time GC

2024-09-10 Thread Chao Yu via Linux-f2fs-devel
. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2 6/7] f2fs: create gc_no_zoned_gc_percent and gc_boost_zoned_gc_percent

2024-09-10 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/10 6:19, Daeho Jeong wrote: From: Daeho Jeong Added control knobs for gc_no_zoned_gc_percent and gc_boost_zoned_gc_percent. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2 5/7] f2fs: do FG_GC when GC boosting is required for zoned devices

2024-09-10 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/10 6:19, Daeho Jeong wrote: From: Daeho Jeong Under low free section count, we need to use FG_GC instead of BG_GC to recover free sections. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list

Re: [f2fs-dev] [PATCH v2 4/7] f2fs: increase BG GC migration window granularity when boosted for zoned devices

2024-09-10 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/10 6:19, Daeho Jeong wrote: From: Daeho Jeong Need bigger BG GC migration window granularity when free section is running low. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs

Re: [f2fs-dev] [PATCH v2 3/7] f2fs: add reserved_segments sysfs node

2024-09-10 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/10 6:19, Daeho Jeong wrote: From: Daeho Jeong For the fine tuning of GC behavior, add reserved_segments sysfs node. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2 2/7] f2fs: introduce migration_window_granularity

2024-09-10 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/10 6:19, Daeho Jeong wrote: From: Daeho Jeong We can control the scanning window granularity for GC migration. For more frequent scanning and GC on zoned devices, we need a fine grained control knob for it. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks

Re: [f2fs-dev] [PATCH v2 1/7] f2fs: make BG GC more aggressive for zoned devices

2024-09-10 Thread Chao Yu via Linux-f2fs-devel
this patchset? if there is no change when version updates. Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH] fsck.f2fs: remove redundant i_ext.len set to zero

2024-09-10 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/10 0:45, Daeho Jeong wrote: From: Daeho Jeong Removed a redundant code to set i_ext.len to zero. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https

Re: [f2fs-dev] [syzbot] [f2fs?] WARNING in rcu_sync_dtor

2024-09-10 Thread Chao Yu via Linux-f2fs-devel
#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip On 2024/7/26 15:54, syzbot wrote: Hello, syzbot found the following issue on: HEAD commit:1722389b0d86 Merge tag 'net-6.11-rc1' of git://git.kernel... git tree: upstream console+strace: https://syzkaller.ap

[f2fs-dev] [PATCH] f2fs: fix to tag STATX_DIOALIGN only if inode support dio

2024-09-10 Thread Chao Yu via Linux-f2fs-devel
ount under some circumstances)." We should not set STATX_DIOALIGN flag in kstat.stx_mask if inode does not support DIO, so that it can indicate related fields contain dummy value, and avoid following incorrect use of them. Fixes: c8c02272a9f7 ("f2fs: support STATX_DIOALIGN&qu

[f2fs-dev] [PATCH] f2fs: fix to don't set SB_RDONLY in f2fs_handle_critical_error()

2024-09-09 Thread Chao Yu via Linux-f2fs-devel
Cc: Christian Brauner Signed-off-by: Chao Yu --- fs/f2fs/super.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c index e774bdf875b2..acfd000c6bb0 100644 --- a/fs/f2fs/super.c +++ b/fs/f2fs/super.c @@ -4207,12 +4207,14 @@ void f2fs_

[f2fs-dev] [PATCH] f2fs: fix to don't panic system for no free segment fault injection

2024-09-09 Thread Chao Yu via Linux-f2fs-devel
rted-by: syzbot+341e5f32ebafbb46b...@syzkaller.appspotmail.com Closes: https://lore.kernel.org/linux-f2fs-devel/f0ee5b0621ab6...@google.com Signed-off-by: Chao Yu --- fs/f2fs/segment.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c ind

Re: [f2fs-dev] [syzbot] [f2fs?] kernel BUG in new_curseg

2024-09-09 Thread Chao Yu via Linux-f2fs-devel
#syz test git://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip On 2024/9/9 16:19, syzbot wrote: Hello, syzbot found the following issue on: HEAD commit:89f5e14d05b4 Merge tag 'timers_urgent_for_v6.11_rc7' of gi.. git tree: upstream console output: https://syzkaller.appspo

Re: [f2fs-dev] [PATCH 7/7] f2fs: add valid block ratio not to do excessive GC for one time GC

2024-09-09 Thread Chao Yu via Linux-f2fs-devel
On 2024/8/30 5:52, Daeho Jeong wrote: From: Daeho Jeong We need to introduce a valid block ratio threshold not to trigger excessive GC for zoned deivces. The initial value of it is 95%. So, F2FS will stop the thread from intiating GC for sections having valid blocks exceeding the ratio. Signed

Re: [f2fs-dev] [RFC PATCH] f2fs: don't set SBI_QUOTA_NEED_REPAIR flag if receive SIGKILL

2024-09-09 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/9 12:06, wangzijie wrote: On 2024/9/8 12:12, wangzijie wrote: From: Chao Yu via Linux-f2fs-devel On 2024/8/27 14:22, wangzijie wrote: Thread A -dquot_initialize   -dqget    -f2fs_dquot_acquire     -v2_read_dquot -qtree_read_dquot   -find_tree_dqentry

Re: [f2fs-dev] [PATCH 2/7] f2fs: read summary blocks with the correct amount for migration_granularity

2024-09-09 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/7 4:23, Daeho Jeong wrote: On Thu, Sep 5, 2024 at 7:56 PM Chao Yu wrote: On 2024/8/30 5:52, Daeho Jeong wrote: From: Daeho Jeong Now we do readahead for a full section by not considering migration_granularity and it triggers unnecessary read. So, make it read with the correct

Re: [PATCH v3] erofs: fix error handling in z_erofs_init_decompressor

2024-09-08 Thread Chao Yu via Linux-erofs
{init,exit}_subsystem()") Reported-by: liujinbao1 Signed-off-by: Sandeep Dhavale Reviewed-by: Chao Yu Thanks,

Re: [PATCH] erofs: simplify erofs_map_blocks_flatmode()

2024-09-08 Thread Chao Yu via Linux-erofs
On 2024/9/5 11:03, Hongzhen Luo wrote: Get rid of redundant variables (nblocks, offset) and a dead branch (!tailendpacking). Signed-off-by: Hongzhen Luo Reviewed-by: Chao Yu Thanks,

Re: [PATCH V4 2/2] erofs: refactor read_inode calling convention

2024-09-08 Thread Chao Yu via Linux-erofs
c int erofs_fill_inode(struct inode *inode) { struct erofs_inode *vi = EROFS_I(inode); - int err = 0; + int err; trace_erofs_fill_inode(inode); Reviewed-by: Chao Yu Thanks,

Re: [PATCH V4 1/2] erofs: use kmemdup_nul in erofs_fill_symlink

2024-09-08 Thread Chao Yu via Linux-erofs
Yiyang Wu Link: https://lore.kernel.org/r/20240902083147.450558-2-toolm...@tlmp.cc Reviewed-by: Gao Xiang Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [RFC PATCH] f2fs: don't set SBI_QUOTA_NEED_REPAIR flag if receive SIGKILL

2024-09-08 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/8 12:12, wangzijie wrote: From: Chao Yu via Linux-f2fs-devel On 2024/8/27 14:22, wangzijie wrote: Thread A -dquot_initialize   -dqget    -f2fs_dquot_acquire     -v2_read_dquot -qtree_read_dquot   -find_tree_dqentry    -f2fs_quota_read

Re: [f2fs-dev] [PATCH] Revert "f2fs: stop allocating pinned sections if EAGAIN happens"

2024-09-06 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/6 16:31, Wu Bo wrote: On Tue, Feb 20, 2024 at 02:50:11PM +0800, Chao Yu wrote: On 2024/2/8 16:11, Wu Bo wrote: On 2024/2/5 11:54, Chao Yu wrote: How about calling f2fs_balance_fs() to double check and make sure there is enough free space for following allocation.     if

Re: [f2fs-dev] [PATCH 6/7] f2fs: create gc_no_zoned_gc_percent and gc_boost_zoned_gc_percent

2024-09-05 Thread Chao Yu via Linux-f2fs-devel
On 2024/8/30 5:52, Daeho Jeong wrote: From: Daeho Jeong Added control knobs for gc_no_zoned_gc_percent and gc_boost_zoned_gc_percent. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel

Re: [f2fs-dev] [PATCH 5/7] f2fs: do FG_GC when GC boosting is required for zoned devices

2024-09-05 Thread Chao Yu via Linux-f2fs-devel
On 2024/8/30 5:52, Daeho Jeong wrote: From: Daeho Jeong Under low free section count, we need to use FG_GC instead of BG_GC to recover free sections. Signed-off-by: Daeho Jeong --- fs/f2fs/f2fs.h | 1 + fs/f2fs/gc.c | 24 +--- 2 files changed, 18 insertions(+), 7 de

[f2fs-dev] [PATCH] f2fs: get rid of online repaire on corrupted directory

2024-09-05 Thread Chao Yu via Linux-f2fs-devel
rk to fsck.f2fs. Fixes: 510022a85839 ("f2fs: add F2FS_INLINE_DOTS to recover missing dot dentries") Reported-by: syzbot+ebea2790904673d7c...@syzkaller.appspotmail.com Closes: https://lore.kernel.org/all/a7b20f061ff2d...@google.com Signed-off-by: Chao Yu --- fs/f2fs/f2fs.

Re: [f2fs-dev] [PATCH 4/7] f2fs: increase BG GC migration granularity when boosted for zoned devices

2024-09-05 Thread Chao Yu via Linux-f2fs-devel
On 2024/8/30 5:52, Daeho Jeong wrote: From: Daeho Jeong Need bigger BG GC migration granularity when free section is running low. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel

Re: [f2fs-dev] [PATCH 3/7] f2fs: add reserved_segments sysfs node

2024-09-05 Thread Chao Yu via Linux-f2fs-devel
On 2024/8/30 5:52, Daeho Jeong wrote: From: Daeho Jeong For the fine tuning of GC behavior, add reserved_segments sysfs node. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel

Re: [f2fs-dev] [PATCH 2/7] f2fs: read summary blocks with the correct amount for migration_granularity

2024-09-05 Thread Chao Yu via Linux-f2fs-devel
On 2024/8/30 5:52, Daeho Jeong wrote: From: Daeho Jeong Now we do readahead for a full section by not considering migration_granularity and it triggers unnecessary read. So, make it read with the correct amount. Signed-off-by: Daeho Jeong --- fs/f2fs/gc.c | 33 --

Re: [f2fs-dev] [PATCH 1/7] f2fs: make BG GC more aggressive for zoned devices

2024-09-05 Thread Chao Yu via Linux-f2fs-devel
On 2024/8/30 5:52, Daeho Jeong wrote: From: Daeho Jeong Since we don't have any GC on device side for zoned devices, need more aggressive BG GC. So, tune the parameters for that. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu T

Re: [f2fs-dev] [PATCH] f2fs-tools: fix wrong endian conversion related to i_flags

2024-09-05 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/6 5:20, Daeho Jeong wrote: From: Daeho Jeong Fixed wrong endian conversions related to i_flags. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https

Re: [PATCH v2 3/4] erofs: support compressed inodes for fileio

2024-09-05 Thread Chao Yu via Linux-erofs
On 2024/8/30 11:28, Gao Xiang wrote: Use pseudo bios just like the previous fscache approach since merged bio_vecs can be filled properly with unique interfaces. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH v3 2/4] erofs: support unencoded inodes for fileio

2024-09-05 Thread Chao Yu via Linux-erofs
On 2024/9/5 17:30, Gao Xiang wrote: Since EROFS only needs to handle read requests in simple contexts, Just directly use vfs_iocb_iter_read() for data I/Os. Reviewed-by: Sandeep Dhavale Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH v2 4/4] erofs: mark experimental fscache backend deprecated

2024-09-05 Thread Chao Yu via Linux-erofs
cache" proposed (2021) since EROFS is entirely a disk filesystem and the dependency is redundant. Mark it deprecated and it will be removed after "fanotify pre-content hooks" lands, which will provide the same functionality for EROFS. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH v2 3/4] erofs: support compressed inodes for fileio

2024-09-05 Thread Chao Yu via Linux-erofs
On 2024/8/30 11:28, Gao Xiang wrote: Use pseudo bios just like the previous fscache approach since merged bio_vecs can be filled properly with unique interfaces. Signed-off-by: Gao Xiang --- fs/erofs/fileio.c | 25 + fs/erofs/inode.c| 6 -- fs/erofs/intern

Re: [PATCH v2 2/4] erofs: support unencoded inodes for fileio

2024-09-05 Thread Chao Yu via Linux-erofs
On 2024/8/30 11:28, Gao Xiang wrote: Since EROFS only needs to handle read requests in simple contexts, Just directly use vfs_iocb_iter_read() for data I/Os. Signed-off-by: Gao Xiang --- v2: - fix redundant refcount which cause hanging on chunked inodes. fs/erofs/Makefile | 1 + fs/er

Re: [PATCH v2 1/4] erofs: add file-backed mount support

2024-09-05 Thread Chao Yu via Linux-erofs
ttps://docs.kernel.org/filesystems/caching/fscache.html [4] https://lore.kernel.org/r/cover.1723670362.git.jo...@toxicpanda.com Closes: https://github.com/containers/composefs/issues/144 Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [PATCH] erofs: clean up erofs_register_sysfs()

2024-09-04 Thread Chao Yu via Linux-erofs
On 2024/8/28 17:52, Gao Xiang wrote: After commit 684b290abc77 ("erofs: add support for FS_IOC_GETFSSYSFSPATH"), `sb->s_sysfs_name` is now valid. Just use it to get rid of duplicated logic. Signed-off-by: Gao Xiang Reviewed-by: Chao Yu Thanks,

Re: [f2fs-dev] [PATCH v2] f2fs: avoid unused block when dio write in LFS mode

2024-09-04 Thread Chao Yu via Linux-f2fs-devel
: Daejun Park Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

Re: [f2fs-dev] [PATCH v2] f2fs-tools: add write hint support

2024-09-04 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/4 9:12, Daejun Park wrote: This patch enables support for write hints by segment type. Signed-off-by: Daejun Park Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https

Re: [f2fs-dev] [syzbot] [f2fs?] possible deadlock in f2fs_release_file (2)

2024-09-04 Thread Chao Yu via Linux-f2fs-devel
#syz invalid Becuase commit "f2fs: atomic: fix to not allow GC to pollute atomic_file" has been dropped from linux-next git repo. On 2024/8/16 17:16, syzbot wrote: Hello, syzbot found the following issue on: HEAD commit:9e6869691724 Add linux-next specific files for 20240812 git tree:

Re: [f2fs-dev] [syzbot] [f2fs?] WARNING: lock held when returning to user space in f2fs_commit_atomic_write

2024-09-04 Thread Chao Yu via Linux-f2fs-devel
o: commit 7566a155c666dd23b413a002a50cd9ae7b95f053 Author: Chao Yu Date: Tue Jun 25 03:13:49 2024 + f2fs: atomic: fix to not allow GC to pollute atomic_file bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1255068d98 final oops: https://syzkaller.appspot.com/x/re

Re: [f2fs-dev] [syzbot] [f2fs?] WARNING: lock held when returning to user space in f2fs_ioc_start_atomic_write

2024-09-04 Thread Chao Yu via Linux-f2fs-devel
kernel image: https://storage.googleapis.com/syzbot-assets/e63ba9cce98a/bzImage-9e686969.xz mounted in repro: https://storage.googleapis.com/syzbot-assets/08b48c782593/mount_0.gz The issue was bisected to: commit 374a8881ce4ccf787f5381a39f825cb17a3f6b14 Author: Chao Yu Date: Tue Jun 25 03:13

Re: [f2fs-dev] [syzbot] [f2fs?] WARNING: lock held when returning

2024-09-04 Thread Chao Yu via Linux-f2fs-devel
o: commit 7566a155c666dd23b413a002a50cd9ae7b95f053 Author: Chao Yu Date: Tue Jun 25 03:13:49 2024 + f2fs: atomic: fix to not allow GC to pollute atomic_file bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1416b18398 final oops: https://syzkaller.appspot.com/x/report.txt?x=1616b18398 console out

Re: [f2fs-dev] [PATCH] mkfs.f2fs: use correct endian conversion for writing lpf inode

2024-09-04 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/4 1:31, Daeho Jeong wrote: From: Daeho Jeong The conversion between cpu and little endian is incorrect. Signed-off-by: Daeho Jeong Reviewed-by: Chao Yu Thanks, ___ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net

Re: [f2fs-dev] [PATCH] f2fs: prevent atomic file from being dirtied before commit

2024-09-04 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/4 22:56, Daeho Jeong wrote: On Tue, Sep 3, 2024 at 8:35 PM Chao Yu wrote: On 2024/9/4 10:52, Daeho Jeong wrote: On Tue, Sep 3, 2024 at 7:26 PM Chao Yu wrote: On 2024/9/4 1:07, Daeho Jeong wrote: On Mon, Sep 2, 2024 at 3:08 AM Chao Yu wrote: On 2024/8/27 4:23, Daeho Jeong

Re: [f2fs-dev] [PATCH v2] f2fs: Do not check the FI_DIRTY_INODE flag when umounting a ro fs.

2024-09-04 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/4 5:20, Jaegeuk Kim wrote: On 09/03, Chao Yu wrote: On 2024/9/2 21:01, Julian Sun wrote: On Mon, 2024-09-02 at 16:13 +0800, Chao Yu wrote: On 2024/8/29 0:54, Julian Sun wrote: Hi, all. Recently syzbot reported a bug as following: kernel BUG at fs/f2fs/inode.c:896! CPU: 1 UID: 0

Re: [f2fs-dev] [RFC PATCH] f2fs: don't set SBI_QUOTA_NEED_REPAIR flag if receive SIGKILL

2024-09-03 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/3 14:06, wangzijie wrote: From: Chao Yu via Linux-f2fs-devel On 2024/8/27 14:22, wangzijie wrote: Thread A -dquot_initialize   -dqget    -f2fs_dquot_acquire     -v2_read_dquot -qtree_read_dquot   -find_tree_dqentry    -f2fs_quota_read     -read_cache_page_gfp

Re: [f2fs-dev] [PATCH] f2fs: prevent atomic file from being dirtied before commit

2024-09-03 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/4 10:52, Daeho Jeong wrote: On Tue, Sep 3, 2024 at 7:26 PM Chao Yu wrote: On 2024/9/4 1:07, Daeho Jeong wrote: On Mon, Sep 2, 2024 at 3:08 AM Chao Yu wrote: On 2024/8/27 4:23, Daeho Jeong wrote: From: Daeho Jeong Keep atomic file clean while updating and make it dirtied

[f2fs-dev] [PATCH] f2fs: fix to check atomic_file in f2fs ioctl interfaces

2024-09-03 Thread Chao Yu via Linux-f2fs-devel
Some f2fs ioctl interfaces like f2fs_ioc_set_pin_file(), f2fs_move_file_range(), and f2fs_defragment_range() missed to check atomic_write status, which may cause potential race issue, fix it. Cc: sta...@vger.kernel.org Signed-off-by: Chao Yu --- fs/f2fs/file.c | 13 - 1 file changed

[f2fs-dev] [PATCH 2/2] fsck.f2fs: support to add missing '.' or '..' dirent

2024-09-03 Thread Chao Yu via Linux-f2fs-devel
do repaires directly. Reviewed-by: Sheng Yong Signed-off-by: Chao Yu --- fsck/fsck.c | 45 - fsck/main.c | 4 +++- 2 files changed, 43 insertions(+), 6 deletions(-) diff --git a/fsck/fsck.c b/fsck/fsck.c index 54ddc11..f8ea7f0 100644 --- a/fsck/fsck

[f2fs-dev] [PATCH 1/2] fsck.f2fs: fix to detect double '.' or '..'

2024-09-03 Thread Chao Yu via Linux-f2fs-devel
If there are double '.' or '..' dirents in directory, fsck.f2fs won't detect and repaire the issue correctly, fix it. Reviewed-by: Sheng Yong Signed-off-by: Chao Yu --- fsck/fsck.c | 55 +++ fsck/fsck.h | 3 ++

Re: [f2fs-dev] [PATCH] f2fs: prevent atomic file from being dirtied before commit

2024-09-03 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/4 1:07, Daeho Jeong wrote: On Mon, Sep 2, 2024 at 3:08 AM Chao Yu wrote: On 2024/8/27 4:23, Daeho Jeong wrote: From: Daeho Jeong Keep atomic file clean while updating and make it dirtied during commit in order to avoid unnecessary and excessive inode updates in the previous fix

Re: [f2fs-dev] [syzbot] [f2fs?] kernel BUG in f2fs_evict_inode (3)

2024-09-03 Thread Chao Yu via Linux-f2fs-devel
#syz test git://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git wip On 2024/8/22 23:38, syzbot wrote: syzbot has found a reproducer for the following issue on: HEAD commit:872cf28b8df9 Merge tag 'platform-drivers-x86-v6.11-4' of g.. git tree: upstream console+strace: https://sy

Re: [f2fs-dev] [PATCH v2] f2fs: Do not check the FI_DIRTY_INODE flag when umounting a ro fs.

2024-09-03 Thread Chao Yu via Linux-f2fs-devel
On 2024/9/2 21:01, Julian Sun wrote: On Mon, 2024-09-02 at 16:13 +0800, Chao Yu wrote: On 2024/8/29 0:54, Julian Sun wrote: Hi, all. Recently syzbot reported a bug as following: kernel BUG at fs/f2fs/inode.c:896! CPU: 1 UID: 0 PID: 5217 Comm: syz-executor605 Not tainted 6.11.0-rc4-syzkaller

[f2fs-dev] [PATCH] f2fs/003: add missing _fixed_by_kernel_commit line

2024-09-02 Thread Chao Yu via Linux-f2fs-devel
The bug related to this regression testcase has been fixed by commit b40a2b003709 ("f2fs: use meta inode for GC of atomic file"), let's add missing _fixed_by_kernel_commit line for this testcase. Cc: Jaegeuk Kim Cc: Daeho Jeong Signed-off-by: Chao Yu --- tests/f2fs/003 | 3 +++

Re: [f2fs-dev] [PATCH] f2fs: prevent atomic file from being dirtied before commit

2024-09-02 Thread Chao Yu via Linux-f2fs-devel
On 2024/8/27 4:23, Daeho Jeong wrote: From: Daeho Jeong Keep atomic file clean while updating and make it dirtied during commit in order to avoid unnecessary and excessive inode updates in the previous fix. Fixes: 4bf78322346f ("f2fs: mark inode dirty for FI_ATOMIC_COMMITTED flag") Signed-off-

Re: [f2fs-dev] [PATCH v2] f2fs: Do not check the FI_DIRTY_INODE flag when umounting a ro fs.

2024-09-02 Thread Chao Yu via Linux-f2fs-devel
On 2024/8/29 0:54, Julian Sun wrote: Hi, all. Recently syzbot reported a bug as following: kernel BUG at fs/f2fs/inode.c:896! CPU: 1 UID: 0 PID: 5217 Comm: syz-executor605 Not tainted 6.11.0-rc4-syzkaller-00033-g872cf28b8df9 #0 RIP: 0010:f2fs_evict_inode+0x1598/0x15c0 fs/f2fs/inode.c:896 Call

Re: [f2fs-dev] [RFC PATCH] f2fs: don't set SBI_QUOTA_NEED_REPAIR flag if receive SIGKILL

2024-09-02 Thread Chao Yu via Linux-f2fs-devel
On 2024/8/27 14:22, wangzijie wrote: Thread A -dquot_initialize -dqget -f2fs_dquot_acquire -v2_read_dquot -qtree_read_dquot -find_tree_dqentry -f2fs_quota_read -read_cache_page_gfp -do_read_cache_folio -fiemap_read_folio -folio_wait

Re: [f2fs-dev] [PATCH v2 2/4] f2fs: atomic: fix to not allow GC to pollute atomic_file

2024-09-01 Thread Chao Yu via Linux-f2fs-devel
On 2024/8/28 23:27, Jaegeuk Kim wrote: On 08/14, Chao Yu wrote: SQLite App GC Thread Shrinker - f2fs_ioc_start_atomic_write - f2fs_ioc_commit_atomic_write - f2fs_commit_atomic_write - filemap_write_and_wait_range : write atomic_file's data to cow_

Re: [f2fs-dev] [PATCH v2 2/4] f2fs: atomic: fix to not allow GC to pollute atomic_file

2024-09-01 Thread Chao Yu via Linux-f2fs-devel
On 2024/8/20 10:44, Sunmin Jeong wrote: Hello Chao Yu, SQLite App GC Thread Shrinker - f2fs_ioc_start_atomic_write - f2fs_ioc_commit_atomic_write - f2fs_commit_atomic_write - filemap_write_and_wait_range : write atomic_file's data to cow_

Re: [PATCH] blktrace: Add 'P' identifier to mark I/O with REQ_POLLED flag

2024-08-26 Thread Chao Yu
On 2024/8/23 15:25, Yongpeng Yang wrote: blk_fill_rwbs function currently does not recognize REQ_POLLED I/O, it's not convenient to trace the I/O handling process on the HCTX_TYPE_POLL type hardware queue. Add a 'P' identifier to 'rwbs' to mark such I/O for tracing. Signed-off-by: Yongpeng Yang

Re: [f2fs-dev] [PATCH v2 1/8] f2fs: convert f2fs_write_begin() to use folio

2024-08-21 Thread Chao Yu via Linux-f2fs-devel
On 2024/8/20 14:58, Chao Yu wrote: On 2024/8/20 12:38, Li Zetao wrote: I want to apply your patch set for testing, but there is a conflict on the master branch of linux-next. Maybe it depends on a certain pre-patch. Please let me know, thank you.    Applying: f2fs: convert f2fs_write_begin

[f2fs-dev] [PATCH v3 3/9] f2fs: convert f2fs_write_end() to use folio

2024-08-20 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/data.c | 13 ++

[f2fs-dev] [PATCH v3 9/9] f2fs: get rid of page->index

2024-08-20 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/compress.c | 2 +-

[f2fs-dev] [PATCH v3 1/9] f2fs: convert f2fs_submit_page_read() to use folio

2024-08-20 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/data.c | 12 ++--

[f2fs-dev] [PATCH v3 8/9] f2fs: convert read_node_page() to use folio

2024-08-20 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/node.c | 9 +

[f2fs-dev] [PATCH v3 7/9] f2fs: convert __write_node_page() to use folio

2024-08-20 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/node.c | 19

[f2fs-dev] [PATCH v3 5/9] f2fs: convert f2fs_do_write_data_page() to use folio

2024-08-20 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/data.c | 26 ++

[f2fs-dev] [PATCH v3 2/9] f2fs: convert f2fs_write_begin() to use folio

2024-08-20 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu -

[f2fs-dev] [PATCH v3 4/9] f2fs: convert f2fs_set_compressed_page() to use folio

2024-08-20 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/compress.c | 8

[f2fs-dev] [PATCH v3 6/9] f2fs: convert f2fs_write_data_page() to use folio

2024-08-20 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/data.c | 9 +

Re: [f2fs-dev] [PATCH v2 1/8] f2fs: convert f2fs_write_begin() to use folio

2024-08-19 Thread Chao Yu
On 2024/8/20 12:38, Li Zetao wrote: I want to apply your patch set for testing, but there is a conflict on the master branch of linux-next. Maybe it depends on a certain pre-patch. Please let me know, thank you.   Applying: f2fs: convert f2fs_write_begin() to use folio   error: patch failed:

[f2fs-dev] [PATCH v2 6/8] f2fs: convert __write_node_page() to use folio

2024-08-19 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/node.c | 19

[f2fs-dev] [PATCH v2 8/8] f2fs: get rid of page->index

2024-08-19 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/compress.c | 2 +-

[f2fs-dev] [PATCH v2 5/8] f2fs: convert f2fs_write_data_page() to use folio

2024-08-19 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/data.c | 9 +

[f2fs-dev] [PATCH v2 7/8] f2fs: convert read_node_page() to use folio

2024-08-19 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/node.c | 9 +

[f2fs-dev] [PATCH v2 1/8] f2fs: convert f2fs_write_begin() to use folio

2024-08-19 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- v2: - fix compile erro

[f2fs-dev] [PATCH v2 4/8] f2fs: convert f2fs_do_write_data_page() to use folio

2024-08-19 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- fs/f2fs/data.c | 26 ++

[f2fs-dev] [PATCH v2 2/8] f2fs: convert f2fs_write_end() to use folio

2024-08-19 Thread Chao Yu
Convert to use folio, so that we can get rid of 'page->index' to prepare for removal of 'index' field in structure page [1]. [1] https://lore.kernel.org/all/zp8fgusibgq1t...@casper.infradead.org/ Cc: Matthew Wilcox Signed-off-by: Chao Yu --- v2: - fix compile erro

  1   2   3   4   5   6   7   8   9   10   >