Re: [PATCH v5 09/13] osdep: move O_DSYNC and O_DIRECT defines from file-posix

2024-05-23 Thread Daniel P . Berrangé
On Thu, May 23, 2024 at 04:55:18PM +0200, Stefano Garzarella wrote: > These defines are also useful for vhost-user-blk when it is compiled > in some POSIX systems that do not define them, so let's move them to > “qemu/osdep.h”. > > Suggested-by: Philippe Mathieu-Daudé > Signed-off-by: Stefano

Re: [PATCH v5 09/13] osdep: move O_DSYNC and O_DIRECT defines from file-posix

2024-05-23 Thread Daniel P . Berrangé
On Thu, May 23, 2024 at 04:55:18PM +0200, Stefano Garzarella wrote: > These defines are also useful for vhost-user-blk when it is compiled > in some POSIX systems that do not define them, so let's move them to > “qemu/osdep.h”. > > Suggested-by: Philippe Mathieu-Daudé > Signed-off-by: Stefano

Re: [PATCH] meson.build: add -mcx16 flag

2024-05-23 Thread Daniel P . Berrangé
On Thu, May 23, 2024 at 09:52:35AM +0100, Peter Maydell wrote: > On Thu, 23 May 2024 at 09:04, Daniel P. Berrangé wrote: > > > > On Wed, May 22, 2024 at 10:30:16PM +0300, Artyom Kunakovsky wrote: > > > fix linker error if the project was configured by the './config

Re: [PATCH v2] meson.build: add -mcx16 flag for x86_64 host

2024-05-23 Thread Daniel P . Berrangé
On Thu, May 23, 2024 at 08:11:18AM +0300, Artyom Kunakovsky wrote: > Fix linker error if the project was configured by the './configure > --cpu=unknown --target-list=riscv64-softmmu' command As with v1, why are you intentionally passing a bogus CPU target name to the --cpu arg ? QEMU already

Re: [PATCH] meson.build: add -mcx16 flag

2024-05-23 Thread Daniel P . Berrangé
On Wed, May 22, 2024 at 10:30:16PM +0300, Artyom Kunakovsky wrote: > fix linker error if the project was configured by the './configure > --cpu=unknown --target-list=riscv64-softmmu' command Isn't this simply user error, with the right answer being to pass a valid CPU target to --cpu, rather

Re: [PATCH] qga: Add an interactive mode to guest-exec via VSOCK for Linux

2024-05-23 Thread Daniel P . Berrangé
On Thu, May 23, 2024 at 09:12:51AM +0200, Denis V. Lunev wrote: > On 5/22/24 18:10, Daniel P. Berrangé wrote: > > On Wed, May 22, 2024 at 05:06:57PM +0200, Alexander Ivanov wrote: > > > Add an interactive mode to the guest-exec command in the QEMU Guest Agent > > > us

Re: [PATCH] qga: Add an interactive mode to guest-exec via VSOCK for Linux

2024-05-22 Thread Daniel P . Berrangé
On Wed, May 22, 2024 at 05:06:57PM +0200, Alexander Ivanov wrote: > Add an interactive mode to the guest-exec command in the QEMU Guest Agent > using the VSOCK communication mechanism. It enables interactive sessions > with the executed command in the guest, allowing real-time input/output. > >

Re: [PATCH v1 1/2] machine/microvm: support for loading EIF image

2024-05-22 Thread Daniel P . Berrangé
On Sat, May 18, 2024 at 02:07:52PM +0600, Dorjoy Chowdhury wrote: > An EIF (Enclave Image Format)[1] image is used to boot an AWS nitro > enclave[2] virtual machine. The EIF file contains the necessary > kernel, cmdline, ramdisk(s) sections to boot. > > This commit adds support for loading EIF

Re: [PATCH v5 26/30] network: prefer the nftables backend over iptables

2024-05-22 Thread Daniel P . Berrangé
ses a problem for a user, > they can work around the failure by adding " to > the guest element. > > Signed-off-by: Laine Stump > --- > meson_options.txt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: ht

Re: [PATCH v5 24/30] network: add an nftables backend for network driver's firewall construction

2024-05-22 Thread Daniel P . Berrangé
| 1 + > po/POTFILES | 1 + > src/network/bridge_driver_conf.c | 11 +- > src/network/bridge_driver_linux.c | 17 +- > src/network/meson.build | 1 + > src/network/network.conf.in | 21 +- > src/network/network_nftables.c|

Re: [PATCH v5 24/30] network: add an nftables backend for network driver's firewall construction

2024-05-22 Thread Daniel P . Berrangé
On Tue, May 21, 2024 at 03:40:54PM -0400, Laine Stump wrote: > On 5/17/24 1:30 PM, Laine Stump wrote: > > +virFirewallAddCmd(fw, layer, "insert", "rule", > > + nftablesLayerTypeToString(layer), > > + VIR_NFTABLES_PRIVATE_TABLE, > > +

Re: [PATCH v5 19/30] util: new functions virFirewallParseXML() and virFirewallFormat()

2024-05-22 Thread Daniel P . Berrangé
by: Laine Stump > --- > src/libvirt_private.syms | 2 + > src/util/virfirewall.c | 219 +++ > src/util/virfirewall.h | 9 ++ > 3 files changed, 230 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://

Re: [PATCH v5 18/30] util: new function virFirewallNewFromRollback()

2024-05-22 Thread Daniel P . Berrangé
; 3 files changed, 61 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [PATCH v5 17/30] util: add name attribute to virFirewall

2024-05-22 Thread Daniel P . Berrangé
src/util/virfirewall.c | 20 +++- > src/util/virfirewall.h | 2 ++ > 3 files changed, 23 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://lib

Re: [PATCH v5 12/30] network: support setting firewallBackend from network.conf

2024-05-22 Thread Daniel P . Berrangé
On Mon, May 20, 2024 at 12:14:26PM -0400, Laine Stump wrote: > On 5/20/24 6:14 AM, Daniel P. Berrangé wrote: > > On Fri, May 17, 2024 at 01:29:49PM -0400, Laine Stump wrote: > > > It still can have only one useful value ("iptables"), but once a 2nd > > > valu

Re: [PATCH v3 1/3] qemu-keymap: Free xkb allocations

2024-05-22 Thread Daniel P . Berrangé
Free'ing is the more maintainable strategy, as IME, supression files get outdated over time. So as long as the free'ing action is not unreasonably expensive, we should just do its, so from my POV I'd Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-

Re: [PATCH] gitlab-ci: Replace Docker with Kaniko

2024-05-22 Thread Daniel P . Berrangé
On Mon, May 20, 2024 at 05:56:46PM +0100, Camilla Conte wrote: > On Fri, May 17, 2024 at 9:14 AM Daniel P. Berrangé > wrote: > > > > On Thu, May 16, 2024 at 07:24:04PM +0100, Daniel P. Berrangé wrote: > > > On Thu, May 16, 2024 at 05:52:43PM +0100, Camilla Conte wro

Re: [PATCH] src: Fix return types of .stateInitialize callbacks

2024-05-22 Thread Daniel P . Berrangé
g flag we could potentially turn on that would diagnose such a mis-match ? Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :|

Re: [PATCH V1 20/26] migration: cpr-exec mode

2024-05-21 Thread Daniel P . Berrangé
On Mon, Apr 29, 2024 at 08:55:29AM -0700, Steve Sistare wrote: > Add the cpr-exec migration mode. Usage: > qemu-system-$arch -machine memfd-alloc=on ... > migrate_set_parameter mode cpr-exec > migrate_set_parameter cpr-exec-args \ > ... -incoming > migrate -d > > The migrate

Re: [PATCH V1 18/26] migration: cpr-exec-args parameter

2024-05-21 Thread Daniel P . Berrangé
On Mon, Apr 29, 2024 at 08:55:27AM -0700, Steve Sistare wrote: > Create the cpr-exec-args migration parameter, defined as a list of > strings. It will be used for cpr-exec migration mode in a subsequent > patch. > > No functional change, except that cpr-exec-args is shown by the > 'info migrate'

Re: [PATCH V1 26/26] migration: only-migratable-modes

2024-05-21 Thread Daniel P . Berrangé
On Mon, Apr 29, 2024 at 08:55:35AM -0700, Steve Sistare wrote: > Add the only-migratable-modes option as a generalization of only-migratable. > Only devices that support all requested modes are allowed. > > Signed-off-by: Steve Sistare > --- > include/migration/misc.h | 3 +++ >

Re: [PATCH V1 24/26] seccomp: cpr-exec blocker

2024-05-21 Thread Daniel P . Berrangé
On Mon, May 13, 2024 at 03:29:48PM -0400, Steven Sistare wrote: > On 5/10/2024 3:54 AM, Daniel P. Berrangé wrote: > > On Mon, Apr 29, 2024 at 08:55:33AM -0700, Steve Sistare wrote: > > > cpr-exec mode needs permission to exec. Block it if permission is denied. > > >

Re: [PATCH v5 12/30] network: support setting firewallBackend from network.conf

2024-05-20 Thread Daniel P . Berrangé
On Fri, May 17, 2024 at 01:29:49PM -0400, Laine Stump wrote: > It still can have only one useful value ("iptables"), but once a 2nd > value is supported, it will be selectable by setting > "firewall_backend=nftables" in /etc/libvirt/network.conf. > > If firewall_backend isn't set in network.conf,

Re: [PATCH v5 00/30] native support for nftables in virtual network driver

2024-05-20 Thread Daniel P . Berrangé
On Fri, May 17, 2024 at 01:29:37PM -0400, Laine Stump wrote: > V4: > https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/HX3RDEIQYJ6IOS2TDQANFKCKAXJMKCJN/#HX3RDEIQYJ6IOS2TDQANFKCKAXJMKCJN > V3: >

Re: [PATCH v2 2/2] iotests: test NBD+TLS+iothread

2024-05-20 Thread Daniel P . Berrangé
On Fri, May 17, 2024 at 10:08:08PM -0500, Eric Blake wrote: > Adding a bit of self-review (in case you want to amend this before > pushing, instead of waiting for me to get back online), > > On Fri, May 17, 2024 at 09:50:15PM GMT, Eric Blake wrote: > > Prevent regressions when using NBD with TLS

Re: [PATCH v2 2/2] iotests: test NBD+TLS+iothread

2024-05-20 Thread Daniel P . Berrangé
On Fri, May 17, 2024 at 10:08:08PM -0500, Eric Blake wrote: > Adding a bit of self-review (in case you want to amend this before > pushing, instead of waiting for me to get back online), > > On Fri, May 17, 2024 at 09:50:15PM GMT, Eric Blake wrote: > > Prevent regressions when using NBD with TLS

Re: [PATCH 8/9] migration: Add support for fdset with multifd + file

2024-05-18 Thread Daniel P . Berrangé
On Fri, May 17, 2024 at 07:43:35PM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > > > The only caller of monitor_fdset_dup_fd_add is qemu_open_internal > > and that has a "Error **errp" parameter. We should rewrite > > monitor_fdset_

[PATCH] rpc: avoid leak of GSource in use for interrupting main loop

2024-05-17 Thread Daniel P . Berrangé
to the main context, which will gradually slow down execution of the loop, as several operations are O(N) for the number of attached GSource objects. Signed-off-by: Daniel P. Berrangé --- src/rpc/virnetclient.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/rpc/virnetclient.c

Re: [PATCH v2 1/3] docs: introduce dedicated page about code provenance / sign-off

2024-05-17 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 01:33:01PM -0400, Michael S. Tsirkin wrote: > On Thu, May 16, 2024 at 05:22:28PM +0100, Daniel P. Berrangé wrote: > > Currently we have a short paragraph saying that patches must include > > a Signed-off-by line, and merely link to the kernel documentation.

Re: [PATCH v2 3/3] docs: define policy forbidding use of AI code generators

2024-05-17 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 01:11:26PM -0400, Michael S. Tsirkin wrote: > On Thu, May 16, 2024 at 05:22:30PM +0100, Daniel P. Berrangé wrote: > > There has been an explosion of interest in so called AI code generators > > in the past year or two. Thus far though, this is has n

Re: [PATCH v2 2/3] docs: define policy limiting the inclusion of generated files

2024-05-17 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 01:04:42PM -0400, Michael S. Tsirkin wrote: > On Thu, May 16, 2024 at 05:22:29PM +0100, Daniel P. Berrangé wrote: > > Files contributed to QEMU are generally expected to be provided in the > > preferred format for manipulation. IOW, we generally don't exp

Re: [PATCH] ui/sdl2: Allow host to power down screen

2024-05-17 Thread Daniel P . Berrangé
Cc stable - candidate for backport perhaps. On Sun, May 12, 2024 at 11:59:45AM +0200, Bernhard Beschow wrote: > By default, SDL disables the screen saver which prevents the host from > powering > down the screen even if the screen is locked. This results in draining the > battery needlessly when

Re: [PATCH v2 1/3] docs: introduce dedicated page about code provenance / sign-off

2024-05-17 Thread Daniel P . Berrangé
On Fri, May 17, 2024 at 07:05:05AM +0200, Thomas Huth wrote: > On 16/05/2024 19.43, Peter Maydell wrote: > > On Thu, 16 May 2024 at 18:34, Michael S. Tsirkin wrote: > > > > > > On Thu, May 16, 2024 at 06:29:39PM +0100, Peter Maydell wrote: > > > > On Thu, 1

Re: [PATCH] qio: Inherit follow_coroutine_ctx across TLS

2024-05-17 Thread Daniel P . Berrangé
in nbd/server.c, > it is more generic if all qio channels that wrap other channels > inherit the follow status, in the same way that they inherit feature > bits. > > CC: Stefan Hajnoczi > CC: Daniel P. Berrangé > CC: qemu-sta...@nongnu.org > Fixes: https://issues.redhat.c

Re: [PATCH v2 3/3] crypto: Allow building with GnuTLS but without Libtasn1

2024-05-17 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 11:56:42AM +0200, Philippe Mathieu-Daudé wrote: > We only use Libtasn1 in unit tests. As noted in commit d47b83b118 > ("tests: add migration tests of TLS with x509 credentials"), having > GnuTLS without Libtasn1 is a valid configuration, so do not require > Libtasn1, to

Re: [PATCH v2 3/3] crypto: Allow building with GnuTLS but without Libtasn1

2024-05-17 Thread Daniel P . Berrangé
re, meson: convert libtasn1 detection to meson") > Signed-off-by: Philippe Mathieu-Daudé > --- > meson.build | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/phot

Re: [PATCH v2 2/3] crypto: Restrict pkix_asn1_tab[] to crypto-tls-x509-helpers.c

2024-05-17 Thread Daniel P . Berrangé
| 6 +++--- > 5 files changed, 10 insertions(+), 13 deletions(-) > rename tests/unit/{pkix_asn1_tab.c => pkix_asn1_tab.c.inc} (99%) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https:

Re: [PATCH v2 1/3] crypto: Remove 'crypto-tls-x509-helpers.h' from crypto-tls-psk-helpers.c

2024-05-17 Thread Daniel P . Berrangé
TLS Pre-Shared Keys (PSK).") > Suggested-by: Daniel P. Berrangé > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/unit/crypto-tls-psk-helpers.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berra

Re: [PATCH] gitlab-ci: Replace Docker with Kaniko

2024-05-17 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 07:24:04PM +0100, Daniel P. Berrangé wrote: > On Thu, May 16, 2024 at 05:52:43PM +0100, Camilla Conte wrote: > > Enables caching from the qemu-project repository. > > > > Uses a dedicated "$NAME-cache" tag for caching, to address limitat

Re: New Fedora Planet

2024-05-17 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 05:16:17PM -0300, Pedro Moura wrote: > Hi everyone, > > We are moving Fedora Planet from the old (python2) software running on > fedorapeople.org to a new application that is running in OpenShift. > This new application uses information from the Fedora Account System to >

Re: [PATCH] gitlab-ci: Replace Docker with Kaniko

2024-05-17 Thread Daniel P . Berrangé
On Fri, May 17, 2024 at 08:24:44AM +0200, Thomas Huth wrote: > On 16/05/2024 20.24, Daniel P. Berrangé wrote: > > On Thu, May 16, 2024 at 05:52:43PM +0100, Camilla Conte wrote: > > > Enables caching from the qemu-project repository. > > > > > > Uses a ded

Re: [PATCH 1/9] monitor: Honor QMP request for fd removal immediately

2024-05-17 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 07:00:11PM -0300, Fabiano Rosas wrote: > Daniel P. Berrangé writes: > > > On Fri, Apr 26, 2024 at 11:20:34AM -0300, Fabiano Rosas wrote: > >> We're enabling using the fdset interface to pass file descriptors for > >> use in the migration cod

Re: [PATCH] gitlab-ci: Replace Docker with Kaniko

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 05:52:43PM +0100, Camilla Conte wrote: > Enables caching from the qemu-project repository. > > Uses a dedicated "$NAME-cache" tag for caching, to address limitations. > See issue "when using --cache=true, kaniko fail to push cache layer [...]": >

[PATCH v2 2/3] docs: define policy limiting the inclusion of generated files

2024-05-16 Thread Daniel P . Berrangé
on of some mundane piece of code for example. Signed-off-by: Daniel P. Berrangé --- docs/devel/code-provenance.rst | 55 ++ 1 file changed, 55 insertions(+) diff --git a/docs/devel/code-provenance.rst b/docs/devel/code-provenance.rst index 7c42fae571..eabb3e7c08 100644

[PATCH v2 3/3] docs: define policy forbidding use of AI code generators

2024-05-16 Thread Daniel P . Berrangé
requests for exceptions can also be considered on a case by case basis. Signed-off-by: Daniel P. Berrangé --- docs/devel/code-provenance.rst | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/docs/devel/code-provenance.rst b/docs/devel/code

[PATCH v2 0/3] docs: define policy forbidding use of "AI" / LLM code generators

2024-05-16 Thread Daniel P . Berrangé
egal clarity improves * Add note that exceptions can be requested on case-by-case basis if contributor thinks they can demonstrate a credible copyright and licensing status Daniel P. Berrangé (3): docs: introduce dedicated page about code provenance / sign-off docs: define policy limiting the in

[PATCH v2 1/3] docs: introduce dedicated page about code provenance / sign-off

2024-05-16 Thread Daniel P . Berrangé
'code-provenance' page in QEMU talking about why we require sign-off, explaining the other tags we commonly use, and what to do in some edge cases. Signed-off-by: Daniel P. Berrangé --- docs/devel/code-provenance.rst| 212 ++ docs/devel/index-process.rst | 1

[Fedora-legal-list] Re: GlobalProtect-openconnect - License violation or not?

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 04:31:14PM +0200, Jakub Kadlcik wrote: > Hello Fedora Legal, > a piece of software was recently discovered in Fedora Copr and it is now > causing a contention about whether it should be allowed to be there or not. > I am kindly asking for your ruling. > > The project in

Re: [RFC/PATCH v2 03/12] hw/arm/virt: confidential guest support

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 02:33:47PM +, Srivatsa Vaddagiri wrote: > This adds support to launch hypervisor-assisted confidential guests, > where guest's memory is protected from a potentially untrusted host. > Hypervisor can setup host's page-tables so that it loses access to guest > memory. >

Re: [PATCH 2/4] MAINTAINERS: drop usb maintainership

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 02:11:52PM +0100, Peter Maydell wrote: > On Thu, 16 May 2024 at 13:04, Gerd Hoffmann wrote: > > > > Remove myself from usb entries. > > Flip status to "Orphan" for entries which have nobody else listed. > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index

[Libguestfs] Re: [PATCH nbdkit 1/3] server/uri.c: Append tls-certificates or tls-psk-key parameter to $uri

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 11:28:06AM +0100, Richard W.M. Jones wrote: > On Thu, May 16, 2024 at 11:12:55AM +0100, Daniel P. Berrangé wrote: > > I don't believe QEMU complains about unknown URI query > > parameters, though I might make the argument that it should > > complain a

[Libguestfs] Re: [PATCH nbdkit 1/3] server/uri.c: Append tls-certificates or tls-psk-key parameter to $uri

2024-05-16 Thread Daniel P . Berrangé
On Tue, May 14, 2024 at 04:28:28PM +0100, Richard W.M. Jones wrote: > If TLS is required (--tls=require), when either --run or --print-uri > is used, include extra query parameters ?tls-certificates=... or > ?tls-psk-key=... in the URI. > > These are simply copied from the corresponding

Re: [PATCH 4/4] rpm: Drop with_ssh_proxy define

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 02:23:13AM -0700, Andrea Bolognani wrote: > On Thu, May 16, 2024 at 10:03:02AM GMT, Daniel P. Berrangé wrote: > > On Thu, May 16, 2024 at 10:24:22AM +0200, Andrea Bolognani wrote: > > > As a general rule, we use defines for features that can onl

Re: [PATCH 4/4] rpm: Drop with_ssh_proxy define

2024-05-16 Thread Daniel P . Berrangé
is indeed redundant > > Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 15 +-- > 1 file changed, 1 insertion(+), 14 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos

Re: [PATCH 1/4] rpm: Drop weak dependency on ssh-proxy from client

2024-05-16 Thread Daniel P . Berrangé
t and selected individual RPMs, without libvirt-ssh-proxy, then we should not be pulling it in anyway with the client. Reviewed-by: Daniel P. Berrangé > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index f7c128d809..5cb19fa433 100644 > --- a/libvirt.spec.in > +++ b/li

Re: [PATCH v2 5/5] tests/docker/dockerfiles: Update container files with "lcitool-refresh"

2024-05-16 Thread Daniel P . Berrangé
u2204.docker | 4 > 17 files changed, 1 insertion(+), 64 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :| |: https://entangle-photo.org-o-https://www.instagram.com/dberrange :|

Re: [PATCH v2 4/5] tests/lcitool/projects/qemu.yml: Sort entries alphabetically again

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 10:40:58AM +0200, Thomas Huth wrote: > Let's try to keep the entries in alphabetical order here! > > Signed-off-by: Thomas Huth > --- > tests/lcitool/projects/qemu.yml | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) Rev

Re: [PATCH v2 3/5] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

2024-05-16 Thread Daniel P . Berrangé
tests/lcitool/projects/qemu.yml | 1 - > tests/lcitool/refresh | 1 + > 4 files changed, 5 insertions(+), 2 deletions(-) > create mode 100644 tests/lcitool/projects/qemu-win-installer.yml Reviewed-by: Daniel P. Berrangé With regards, Daniel --

Re: [PATCH v2 2/5] tests/lcitool: Remove 'xfsprogs' from QEMU

2024-05-16 Thread Daniel P . Berrangé
thieu-Daudé > [thuth: Adjusted the patch from the lcitools repo to QEMU's repo] > Signed-off-by: Thomas Huth > --- > tests/lcitool/projects/qemu.yml | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com

Re: [PATCH v2 1/5] tests/lcitool/refresh: Treat the output of lcitool as text, not as bytes

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 10:40:55AM +0200, Thomas Huth wrote: > In case lcitool fails (e.g. with a python backtrace), this makes > the output of lcitool much more readable. > > Suggested-by: Daniel P. Berrangé > Signed-off-by: Thomas Huth > --- > tests/lcitool/refre

Re: [PATCH 3/4] rpm: Move dependency on ssh-proxy to QEMU driver

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 10:24:21AM +0200, Andrea Bolognani wrote: > This way we can avoid repeating it twice. > > Signed-off-by: Andrea Bolognani > --- > libvirt.spec.in | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) This shouldn't be done. It will pull in the SSH proxy on

Re: [PATCH 2/4] rpm: Only Recommend ssh-proxy

2024-05-16 Thread Daniel P . Berrangé
On Thu, May 16, 2024 at 10:24:20AM +0200, Andrea Bolognani wrote: > The way things are implemented, installing the package not > only makes the feature available but also enables it. > > Some admins might not want that to happen, so let's make the > dependency a weak one to offer them a way out.

Re: [PATCH v3 5/5] virtio-gpu: fix v2 migration

2024-05-15 Thread Daniel P . Berrangé
On Wed, May 15, 2024 at 11:03:27AM -0600, Peter Xu wrote: > On Wed, May 15, 2024 at 05:03:44PM +0100, Daniel P. Berrangé wrote: > > Above all, I'm failing to see why there's a compelling reason > > for virtio_gpu to diverge from our long standing practice of > > adding

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-15 Thread Daniel P . Berrangé
On Tue, May 14, 2024 at 11:49:40AM +0800, Zhao Liu wrote: > > I'm failing to see what real world technical problems QEMU faces > > with a parameter being set to '1' by a mgmt app, when QEMU itself > > treats all omitted values as being '1' anyway. > > > > If we're trying to faithfully model the

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-15 Thread Daniel P . Berrangé
On Tue, May 14, 2024 at 11:49:40AM +0800, Zhao Liu wrote: > > I'm failing to see what real world technical problems QEMU faces > > with a parameter being set to '1' by a mgmt app, when QEMU itself > > treats all omitted values as being '1' anyway. > > > > If we're trying to faithfully model the

Re: [PATCH v9] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-05-15 Thread Daniel P . Berrangé
On Mon, May 13, 2024 at 02:52:14PM +0800, Zhao Liu wrote: > Hi Daniel, > > > Please describe it in terms of a QAPI definition, as that's what we're > > striving for with all QEMU public interfaces. Once the QAPI design is > > agreed, then the -object mapping is trivial, as -object's JSON format >

Re: [PATCH v3 0/5] Fix "virtio-gpu: fix scanout migration post-load"

2024-05-15 Thread Daniel P . Berrangé
On Wed, May 15, 2024 at 10:07:31AM -0600, Peter Xu wrote: > On Wed, May 15, 2024 at 06:15:51PM +0400, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > Hi, > > > > The aforementioned patch breaks virtio-gpu device migrations for versions > > pre-9.0/9.0, both forwards and

Re: [PATCH v3 5/5] virtio-gpu: fix v2 migration

2024-05-15 Thread Daniel P . Berrangé
On Wed, May 15, 2024 at 06:15:56PM +0400, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Commit dfcf74fa ("virtio-gpu: fix scanout migration post-load") broke > forward/backward version migration. Versioning of nested VMSD structures > is not straightforward, as the wire format

Re: [PULL 00/11] gitlab CI fix and glib update

2024-05-15 Thread Daniel P . Berrangé
lib version and use URI code from the newer glib > * Fix error message from "configure" when C compiler is not working > > > Daniel P. Berrangé (3): > dockerfiles: add 'MAKE' env variable to remaining

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2024 at 10:22:22PM +0800, Zhao Liu wrote: > Cc Paolo for x86 topology part > > Hi Daniel, > > On Mon, May 13, 2024 at 01:33:57PM +0100, Daniel P. Berrangé wrote: > > Date: Mon, 13 May 2024 13:33:57 +0100 > > From: "Daniel P. Berrangé" &g

Re: [PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2024 at 10:22:22PM +0800, Zhao Liu wrote: > Cc Paolo for x86 topology part > > Hi Daniel, > > On Mon, May 13, 2024 at 01:33:57PM +0100, Daniel P. Berrangé wrote: > > Date: Mon, 13 May 2024 13:33:57 +0100 > > From: "Daniel P. Berrangé" &g

Re: [PATCH 2/4] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

2024-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2024 at 04:22:00PM +0200, Thomas Huth wrote: > On 13/05/2024 14.11, Daniel P. Berrangé wrote: > > On Mon, May 13, 2024 at 02:05:16PM +0200, Thomas Huth wrote: > > > On 13/05/2024 12.28, Daniel P. Berrangé wrote: > > > > A better way to handle this

[PATCH 2/2] tests: add testing of parameter=1 for SMP topology

2024-05-13 Thread Daniel P . Berrangé
Validate that it is possible to pass 'parameter=1' for any SMP topology parameter, since unsupported parameters are implicitly considered to always have a value of 1. Signed-off-by: Daniel P. Berrangé --- tests/unit/test-smp-parse.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-13 Thread Daniel P . Berrangé
t functional benefit to deleting this deprecated behaviour from QEMU, and it creates problems for consumers of QEMU, remove this deprecation. Signed-off-by: Daniel P. Berrangé --- docs/about/deprecated.rst | 14 --- hw/core/machine-smp.c | 82 - t

[PATCH 0/2] hw/core: revert deprecation of 'parameter=1' for SMP topology

2024-05-13 Thread Daniel P . Berrangé
Since QEMU 9.0, users are complaining that depecation messages are shown for every VM libvirt starts. This is due to the newly introduced deprecation of 'parameter=1' for -smp. This proposes reverting that, see the 1st patch for further commentary. Daniel P. Berrangé (2): hw/core: allow

[PATCH 2/2] tests: add testing of parameter=1 for SMP topology

2024-05-13 Thread Daniel P . Berrangé
Validate that it is possible to pass 'parameter=1' for any SMP topology parameter, since unsupported parameters are implicitly considered to always have a value of 1. Signed-off-by: Daniel P. Berrangé --- tests/unit/test-smp-parse.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 1/2] hw/core: allow parameter=1 for SMP topology on any machine

2024-05-13 Thread Daniel P . Berrangé
t functional benefit to deleting this deprecated behaviour from QEMU, and it creates problems for consumers of QEMU, remove this deprecation. Signed-off-by: Daniel P. Berrangé --- docs/about/deprecated.rst | 14 --- hw/core/machine-smp.c | 82 - t

[PATCH 0/2] hw/core: revert deprecation of 'parameter=1' for SMP topology

2024-05-13 Thread Daniel P . Berrangé
Since QEMU 9.0, users are complaining that depecation messages are shown for every VM libvirt starts. This is due to the newly introduced deprecation of 'parameter=1' for -smp. This proposes reverting that, see the 1st patch for further commentary. Daniel P. Berrangé (2): hw/core: allow

Re: [PATCH 2/4] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

2024-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2024 at 02:05:16PM +0200, Thomas Huth wrote: > On 13/05/2024 12.28, Daniel P. Berrangé wrote: > > On Mon, May 13, 2024 at 12:22:50PM +0200, Thomas Huth wrote: > > > We don't need C++ for the normal QEMU builds anymore, so installing > > > g++ in eac

Re: [PATCH 3/3] gitlab: use 'setarch -R' to workaround tsan bug

2024-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2024 at 12:15:51PM +0100, Daniel P. Berrangé wrote: > The TSAN job started failing when gitlab rolled out their latest > release. The root cause is a change in the Google COS version used > on shared runners. This brings a kernel running with > > vm.mmap_rnd_bits

[PATCH 0/3] gitlab: fix failing TSAN job in CI

2024-05-13 Thread Daniel P . Berrangé
See patch 3 commit message for the key details about the problem. Daniel P. Berrangé (3): dockerfiles: add 'MAKE' env variable to remaining containers gitlab: use $MAKE instead of 'make' gitlab: use 'setarch -R' to workaround tsan bug .gitlab-ci.d/buildtest-template.yml

[PATCH 2/3] gitlab: use $MAKE instead of 'make'

2024-05-13 Thread Daniel P . Berrangé
The lcitool generated containers have '$MAKE' set to the path of the right 'make' binary. Using the env variable makes it possible to override the choice per job. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/buildtest-template.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions

[PATCH 3/3] gitlab: use 'setarch -R' to workaround tsan bug

2024-05-13 Thread Daniel P . Berrangé
can support upto '30', and failing that will re-exec itself to turn off VA randomization. Our LLVM is too old for now, but we can run with 'setarch -R make ..' to turn off VA randomization ourselves. Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/buildtest.yml | 3 +++ 1 file changed

[PATCH 1/3] dockerfiles: add 'MAKE' env variable to remaining containers

2024-05-13 Thread Daniel P . Berrangé
All the lcitool generated containers define a "MAKE" env. It will be convenient for later patches if all containers do this. Signed-off-by: Daniel P. Berrangé --- tests/docker/dockerfiles/debian-all-test-cross.docker| 1 + tests/docker/dockerfiles/debian-hexagon-cross.dock

Re: GIMP 3.0 in F41?

2024-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2024 at 12:38:06PM +0200, Fabio Valentini wrote: > On Mon, May 13, 2024, 12:34 Daniel P. Berrangé wrote: > > > On Mon, May 13, 2024 at 12:14:14PM +0200, Fabio Valentini wrote: > > > On Mon, May 13, 2024, 11:50 Dominik 'Rathann' Mierzejewski < > > &

Re: GIMP 3.0 in F41?

2024-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2024 at 12:14:14PM +0200, Fabio Valentini wrote: > On Mon, May 13, 2024, 11:50 Dominik 'Rathann' Mierzejewski < > domi...@greysector.net> wrote: > > > On Monday, 13 May 2024 at 01:00, Neal Gompa wrote: > > > On Sun, May 12, 2024 at 4:59 PM Sérgio Basto wrote: > > > > > > > > > >

Re: [PATCH 2/4] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

2024-05-13 Thread Daniel P . Berrangé
On Mon, May 13, 2024 at 12:22:50PM +0200, Thomas Huth wrote: > We don't need C++ for the normal QEMU builds anymore, so installing > g++ in each and every container seems to be a waste of time and disk > space. The only container that still needs it is the Fedora MinGW > container that builds the

Re: Enabling RPM based sysuser handling

2024-05-13 Thread Daniel P . Berrangé
On Fri, May 10, 2024 at 01:28:07PM +0200, Florian Festi wrote: > Hi everyone! > > RPM 4.19 added automatic sysuser handling [1]. In Fedora 39 this feature > was not enabled right away [2] as it requires some care to properly > transition to it. Also going back to 4.18 was technically still the >

Re: [PATCH v3] target/i386: Fix CPUID encoding of Fn8000001E_ECX

2024-05-10 Thread Daniel P . Berrangé
On Fri, May 10, 2024 at 11:05:44AM +0300, Michael Tokarev wrote: > 09.05.2024 17:11, Daniel P. Berrangé wrote: > > On Thu, May 09, 2024 at 04:54:16PM +0300, Michael Tokarev wrote: > > > 03.05.2024 20:46, Babu Moger wrote: > > > > > diff --git a/hw/i386/pc.c b/hw/i

Re: [PATCH V1 24/26] seccomp: cpr-exec blocker

2024-05-10 Thread Daniel P . Berrangé
On Mon, Apr 29, 2024 at 08:55:33AM -0700, Steve Sistare wrote: > cpr-exec mode needs permission to exec. Block it if permission is denied. > > Signed-off-by: Steve Sistare > --- > include/sysemu/seccomp.h | 1 + > system/qemu-seccomp.c| 10 -- > system/vl.c | 6

Re: [PATCH v3 2/5] qemu: Introduce shared_filesystems configuration option

2024-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2024 at 04:47:48PM +, Andrea Bolognani wrote: > On Thu, May 09, 2024 at 05:10:50PM GMT, Peter Krempa wrote: > > Now things I see as problem in case when NFS not supporting xattr is > > used. This means that the remote VM can set XATTRs and must use > > 'virt_use_nfs' sebool. >

Re: Spec file using github repo - not tarball

2024-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2024 at 11:21:11AM -0400, Nico Kadel-Garcia wrote: > On Wed, May 8, 2024 at 4:36 PM Kenneth Goldman wrote: > > > > Is it possible for a .spec file to clone a github.com repo rather than > > download a tarball? Can someone link to a working example? > > Git clones are bulky, with

Re: [PATCH 08/14] include/hw: add macros for deprecation & removal of versioned machines

2024-05-09 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 12:59:05PM +0200, Thomas Huth wrote: > On 01/05/2024 20.27, Daniel P. Berrangé wrote: > > Versioned machines live for a long time to provide back compat for > > incoming migration and restore of saved images. To guide users away from > > usage of old

Re: [PATCH 01/14] include/hw: add helpers for defining versioned machine types

2024-05-09 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 09:57:21AM -0500, Eric Blake wrote: > On Wed, May 01, 2024 at 07:27:46PM +0100, Daniel P. Berrangé wrote: > > The various targets which define versioned machine types have > > a bunch of obfuscated macro code for defining unique function > > and variab

Re: [PATCH 01/14] include/hw: add helpers for defining versioned machine types

2024-05-09 Thread Daniel P . Berrangé
On Thu, May 02, 2024 at 12:34:49PM +0200, Thomas Huth wrote: > On 01/05/2024 20.27, Daniel P. Berrangé wrote: > > The various targets which define versioned machine types have > > a bunch of obfuscated macro code for defining unique function > > and variable names using

Re: [PATCH] network: Register dnsmasq with resolved only when really requested

2024-05-09 Thread Daniel P . Berrangé
ould disable the registration. > > Reported-by: Daniel P. Berrangé > Signed-off-by: Jiri Denemark > --- > src/network/bridge_driver.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-

Re: [PATCH v3] target/i386: Fix CPUID encoding of Fn8000001E_ECX

2024-05-09 Thread Daniel P . Berrangé
On Thu, May 09, 2024 at 04:54:16PM +0300, Michael Tokarev wrote: > 03.05.2024 20:46, Babu Moger wrote: > > Observed the following failure while booting the SEV-SNP guest and the > > guest fails to boot with the smp parameters: > > "-smp 192,sockets=1,dies=12,cores=8,threads=2". > > > >

Re: [PATCH v9] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2024-05-09 Thread Daniel P . Berrangé
oth ARM and x86, I'd like to discuss my API > thinking with you. ;-) > > On Mon, Apr 15, 2024 at 06:29:25PM +0100, Daniel P. Berrangé wrote: > > Date: Mon, 15 Apr 2024 18:29:25 +0100 > > From: "Daniel P. Berrangé" > > Subject: Re: [PATCH v9] arm/kvm: Enable suppo

Re: [PATCH 8/9] migration: Add support for fdset with multifd + file

2024-05-09 Thread Daniel P . Berrangé
On Wed, May 08, 2024 at 05:39:53PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Wed, May 08, 2024 at 09:53:48AM +0100, Daniel P. Berrangé wrote: > >> On Fri, Apr 26, 2024 at 11:20:41AM -0300, Fabiano Rosas wrote: > >> > Allow multifd to use

[PATCH v2] docs: ensure HTML/images are built before running reference tests

2024-05-08 Thread Daniel P . Berrangé
compile' time. Signed-off-by: Daniel P. Berrangé --- docs/images/meson.build | 3 ++- docs/logos/meson.build | 3 ++- docs/meson.build| 1 + 3 files changed, 5 insertions(+), 2 deletions(-) This is the only remaining unpushed patch from my previous v1 series, now I figured out how to make

  1   2   3   4   5   6   7   8   9   10   >