libssh + dropbear problem ?

2024-09-04 Thread Walter Harms
Hello list, We have found a strage issue with dropbear 2022.83 and libssh2 1.11. after the dropbear update we notice that processes got stuck. It turned out that libssh2 got stuck in channel_free(), fun fact the other things seem to work normaly. Did anyone see this before ? WH

AW: Re busybox tar hidden filename exploit

2024-07-02 Thread Walter Harms
erstag, 27. Juni 2024 20:31:24 An: Walter Harms; busybox@busybox.net Betreff: Re: Re busybox tar hidden filename exploit Looking at header_list() and header_verbose_list(). Fixing it _properly_ would include some awareness of the current charset and terminal type I think. At the very least I gu

AW: Re busybox tar hidden filename exploit

2024-06-24 Thread Walter Harms
Hi Ian, thx for the report. yes, i did not notice (and yes i check tars with -vt before installing). what do you expect now ? Do you have patch ? Do you want to start a discussion about possible solution ? (I use a strict ASCII-only policy in my projects to catch other traps also). What does gnut

AW: Changing HOME ENV-Variable

2024-05-06 Thread Walter Harms
Hello, i am not sure that i understand what problem you want to solve but HOME is usualy set with login and depends on /etc/passwd. NTL it is a "normal" env-var and can be overwritten before you start the install. (if that is your problem.) hope that helps ___

AW: "Modern C" and the X.Org software

2023-12-13 Thread Walter Harms
Hi Alan, just for my understanding. You compiled everything and only these few thinks showed up. Or is more like an iceberg only the tip is there and we should do something ? CU Von: xorg-devel im Auftrag von Alan Coopersmith Gesendet: Montag, 11. Dezemb

AW: Hitting X limit in launching maximum number of vkcube instances

2023-08-24 Thread Walter Harms
Hi Anuj, i did not follow the diskussion in detail, so maybe this was already purposed: Some years ago in an unrelated project i also hit the max file pointer limit. The reason seemed obvious but in the end it turned out the be something different. Did you check you hit the expected limit when re

AW: Overexposed desktop

2023-07-12 Thread Walter Harms
The reduce the number of components involved: when you are at your console and you start X :2 does anything change ? - yes i am forced to use this crappy mail frontend ... Von: xorg im Auftrag von Igor Rylov Gesendet: Mittwoch, 12. Jul

AW: Only do connection if I already know the destination?

2023-02-10 Thread Walter Harms
would it be possible to add an option to add an non-interactive mode ? Getting yes/no questions (or else) in a script is clearly not helpful. re, wh Von: Dropbear im Auftrag von Matt Johnston Gesendet: Montag, 21. November 2022 16:20:25 An: M Rubon Cc

AW: PATCH libX11 2/2] ChkIfEv.c: fix wrong handling of dpy->in_ifevent

2023-01-27 Thread Walter Harms
maybe i missed a point, is it possible that dpy->in_ifevent will underflow ? re, wh Von: xorg-devel im Auftrag von Ulrich Sibiller Gesendet: Mittwoch, 30. November 2022 23:47 An: xorg-devel@lists.x.org Betreff: PATCH libX11 2/2] ChkIfEv.c: fix wrong ha

AW: [PATCH v2 8/9] loop:refactor: extract subfunction set_loop_dev()

2022-11-18 Thread Walter Harms
i am wondering, maybe question for the maintainer. would it hurt to open it O_RDONLY in the first place ? cm2c Von: busybox im Auftrag von Xiaoming Ni Gesendet: Freitag, 18. November 2022 13:14:47 An: busybox@busybox.net; vda.li...@googlemail.com; c...@

AW: [PATCH v2 7/9] loop:refactor: Extract subfunction do_stat_and_mknod()

2022-11-18 Thread Walter Harms
again try to safe indent level if (stat(dev, &statbuf) == 0 && S_ISBLK(statbuf.st_mode)) return 0; jm2c Von: busybox im Auftrag von Xiaoming Ni Gesendet: Freitag, 18. November 2022 13:14:46 An: busybox@busybox.net; vda.li...@googlemail.com; c...@gmx

AW: [PATCH v2 5/9] loop:refactor: extract subfunction set_loop_configure()

2022-11-18 Thread Walter Harms
A little tweak make it more readable (i hope) putting if (rc) direkt behind rc = ioctl(lfd, BB_LOOP_SET_STATUS, &loopinfo); if (rc == 0) return lfd; // no need to check rc again if ( (loopinfo.lo_flags & BB_LO_FLAGS_AUTOCLEAR)) { // try again without BB_LO_FLAGS_AUTOCLEAR // does

AW: [PATCH v2 4/9] loop:refactor: extract subfunction set_loop_info()

2022-11-18 Thread Walter Harms
on other minor if (rc && errno == ENXIO) turn it on its head safes one indent level if ( !rc || errno != ENXIO ) return -1; // failed to get loopinfo jm2c Von: busybox im Auftrag von Xiaoming Ni Gesendet: Freitag, 18. November 2022 13:14:43 An:

AW: [PATCH 2/9] loop:refactor: extract subfunction get_next_free_loop()

2022-11-18 Thread Walter Harms
hi, just a minor comment. do not use i as name for return value, most ppl use it as loop counter, triggers the wrong circuits in the brain. (rule of least surprise). just name it err or what you like, and please untangle the if() if (err>=0) return if (err==-2) return return -1 just my 2

AW: Yet another leak in Xlib

2022-10-18 Thread Walter Harms
will sombody close the hole in the documentation ? Von: xorg-devel im Auftrag von Po Lu Gesendet: Dienstag, 4. Oktober 2022 04:38 An: Thomas Dickey Cc: xorg-devel@lists.x.org Betreff: Re: Yet another leak in Xlib Thomas Dickey writes: > looks okay read

AW: Motif/Xt: Dynamically resize the visible item count of an XmList

2022-03-21 Thread Walter Harms
Hello, for my understand of Widget programming it is a question of the widget itself. It has some code inside to handle the resize event and in this moment there seems no update of the visible_item_count. Von: xorg im Auftrag von Holger Sebert Gesendet:

AW: BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM

2021-07-08 Thread Walter Harms
Hi, you are sending to the wrong list, please send to buildroot. re, wh Von: busybox im Auftrag von Ivan Riabtsov Gesendet: Donnerstag, 8. Juli 2021 13:55:21 An: busybox@busybox.net Betreff: BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM WARNUNG: Diese E-Mail k

AW: [git commit] taskset: implement -a

2021-06-20 Thread Walter Harms
Would using xasprintf() an option here ? I did not try, but the dn[]+sprintf combo requires that both strings are always the same ... jm2c, re, wh ___ Von: busybox im Auftrag von Bernhard Reutner-Fischer Gesendet: Sonntag, 20. Juni 2021 10:18 An: busybox@b

AW: [PATCH] xrdb: Add actual querying capabilities to -query

2021-06-20 Thread Walter Harms
Hi, thx for the patch. NTL it is better for the general look if you use a name for sign-off that is more easy to pronounce. for a starter: yes, i think we can drop support for solaris 4 :) IMHO, the idea is good. I am struggling a bit with reusing the query option but thats not a showstopper. L

Add filter to restrict access

2021-06-06 Thread Walter Harms
lately there was a discussion who to restrict access to a dropbear server. The result were some solutions outside dropbear. I have attached a patch to show how this could be done. It uses fnmatch() what means the patch is small and the pattern is simple. (Try -D 192.168.1.*) re, wh --- svr-run

AW: restrict access

2021-05-25 Thread Walter Harms
: Steffen Nurpmeso Gesendet: Dienstag, 25. Mai 2021 02:40:50 An: Walter Harms Cc: dropbear@ucc.asn.au Betreff: Re: restrict access WARNUNG: Diese E-Mail kam von außerhalb der Organisation. Klicken Sie nicht auf Links oder öffnen Sie keine Anhänge, es sei denn, Sie kennen den/die Absender*in und wissen

AW: restrict access

2021-05-24 Thread Walter Harms
Hans > > > On Thu, May 20, 2021 at 5:05 PM Sebastian Gottschall > wrote: >> what about a feature like blocking a client for N minutes if more than N >> times of failed logins. its relativily easy to implement and lows down >> brute force attacks >> >> Am 20.0

AW: restrict access

2021-05-20 Thread Walter Harms
that be acceptable ? re, wh Von: Dropbear im Auftrag von Sebastian Gottschall Gesendet: Donnerstag, 20. Mai 2021 15:53 An: dropbear@ucc.asn.au Betreff: Re: restrict access isnt that a job for netfilter? Am 20.05.2021 um 15:23 schrieb Walter Harms

restrict access

2021-05-20 Thread Walter Harms
Hello List, actually i expected this would be a FAQ but i can not find an answer: How can i restrict the hosts that are allowed to access the dropbear server ? re, wh

AW: [Xlib] Ignoring BadAccess errors

2021-04-21 Thread Walter Harms
since no one feels the need to answer is will try: Having those exceptions is obviously a hack to allow clients to continue on "minor" errors. e.g. BadAccess can be generated by xgrab*() and may work in a second attempt. NTL this should be documented in the doc. regarding you original question:

AW: New libxcvt library

2021-04-16 Thread Walter Harms
Hi, i think it is a good idea. Can you give a hint how big that lib is ? Even when the idea is good it is not really helpful to have to many different libs hanging around. I read Keith Packard was already considering putting that into xrandr, if its not to big i would say it would be a good idea

AW: Cannot build busybox for Android (Android ndk (x86-64))

2021-03-23 Thread Walter Harms
the version 2.24 seems old, there are several comparable bug reports. Current version seems 2.35 http://metadata.ftp-master.debian.org/changelogs/main/b/binutils/unstable_changelog Von: busybox im Auftrag von Xabier Oneca -- xOneca Gesendet: Dienstag, 2

bug#47324: AW: bug#47324: Missing information in documentation

2021-03-23 Thread Walter Harms via GNU coreutils Bug Reports
: Bernhard Voelker Gesendet: Montag, 22. März 2021 23:21 An: Walter Harms; 47324-d...@debbugs.gnu.org Betreff: Re: bug#47324: Missing information in documentation WARNUNG: Diese E-Mail kam von außerhalb der Organisation. Klicken Sie nicht auf Links oder öffnen Sie keine Anhänge, es sei denn, Sie kenn

bug#47324: Missing information in documentation

2021-03-22 Thread Walter Harms via GNU coreutils Bug Reports
hi list, in the documentation (man page) a nice feature is mssing when a fs is mounted on a directory ls marks that with a dot behing the permission mask (see example) drwxr-xr-x. 2 1003 users 4096 Mar 22 17:53 vendor ^^ notice the dot here I found nothing mentioned

AW: USB-Treiber (War: Technik: Scannen mit sane kyocera FS-1320MFP)

2021-03-22 Thread Walter Harms
Was Treiber angeht, habe ich keine Probleme mehr seit dem ich ausschließlich Postscript verwende. Multifunktionsgeräte sind halt per definitionem ein Problem, da ausschließlich der Hersteller weiß wie man zwischen den internen Geräten auswählen kann. Was nicht heißt, das es nicht lösbar wäre, a

AW: [PATCH 1/1] libbb: fix parse_duration_str with LOCALE_SUPPORT

2021-03-22 Thread Walter Harms
hi, does setlocale("") reset to the last used locale ? I would expect something like: old=getlocale() setlocale("C") strtod() setlocale(old); note: i had the same problems years ago and used strtod_l() with a static stored locale_t. re, wh Von: busybo

AW: [RFC v3 04/17] arch_prctl.2: SYNOPSIS: Remove unused includes

2021-03-15 Thread Walter Harms
I have learned the other way around: #include Is a general system header to use that may include the asm/prctrl.h what should never be included by userspace programms. jm2c, re, wh Von: Alejandro Colomar Gesendet: Samstag, 13. März 2021 20:25:14 An: mtk.

AW: Error in Xmanager

2021-03-12 Thread Walter Harms
Hi Qiu Guotao, your are on the X11 mailing list, we are concerned with the inner workings of X11. xmanager seens to be a commerical program: https://www.netsarang.com/en/xmanager/ The side has a technical support on the top/right. Mots likely they can help better. re, wh _

AW: [PATCH] mi: sprite: SaveUnderCursor2

2021-03-09 Thread Walter Harms
hi Madhurkiran Harikrishnan, my experience is that readability reduced rapidly with indent-level. I would suggest: if ( ! DevHasCursor(pDev) continue; pCursorInfo = GetSprite(pDev); if (!pCursorInfo) continue; // just to shrink the if () // no braces needed if ( pCursorInfo->isUp &&

AW: [PATCH] staging: gasket: Fix sizeof() in gasket_handle_ioctl()

2021-03-09 Thread Walter Harms
why not mark it as "Deprecated" and remove it with the next version ? Maybe soneone will wakeup ? re, wh Von: Greg Kroah-Hartman Gesendet: Dienstag, 9. März 2021 14:26:55 An: Dan Carpenter Cc: Rob Springer; de...@driverdev.osuosl.org; kernel-janit...@vge

AW: [PATCH 1/2] libbb: add xopen_fd() helper

2021-03-01 Thread Walter Harms
nice observation, but IMHO the name is a bit misleading, i6 should be more generic like: xopen_as() ym2c, re, wh Von: busybox im Auftrag von Rasmus Villemoes Gesendet: Montag, 1. März 2021 17:03:56 An: busybox@busybox.net Betreff: [PATCH 1/2] libbb: ad

AW: Xorg core dump Device or resource busy

2021-02-25 Thread Walter Harms
this sounds like a reproduceable bug in the I/o handling. I hope someone on the list is reading and can fix that, as i am not an expoert on these io-things. re, wh Von: Mykola Sokolov Gesendet: Donnerstag, 25. Februar 2021 16:40:27 An: Walter Harms Cc

AW: Xorg core dump Device or resource busy

2021-02-25 Thread Walter Harms
Gesendet: Donnerstag, 25. Februar 2021 11:57:45 An: Walter Harms Cc: xorg@lists.x.org Betreff: Re: Xorg core dump Device or resource busy Hi Walter, I don't think that this is a new issue. I think it got worse after replacing mouses and keyboards. What do you mean by manual start? If I

AW: Xorg core dump Device or resource busy

2021-02-25 Thread Walter Harms
Hi, some minor questions: 1. Is this a new issue ? (e.g. after a recent update ?) 2. Does this happen also with a manual start ? re, wh Von: xorg im Auftrag von Mykola Sokolov Gesendet: Donnerstag, 25. Februar 2021 10:10:12 An: xorg@lists.x.org Betreff:

AW: [PATCH][next] iommu/mediatek: Fix unsigned domid comparison with less than zero

2021-02-09 Thread Walter Harms
I second that ... Having i unsigned violates the rule of "least surprise". If you need it unsigned make it clearly visible, also adding a simple comment may help. jm2c, wh Von: Dan Carpenter Gesendet: Dienstag, 9. Februar 2021 10:19:23 An: Will Deacon Cc

AW: [PATCH][next] iommu/mediatek: Fix unsigned domid comparison with less than zero

2021-02-09 Thread Walter Harms
I second that ... Having i unsigned violates the rule of "least surprise". If you need it unsigned make it clearly visible, also adding a simple comment may help. jm2c, wh Von: Dan Carpenter Gesendet: Dienstag, 9. Februar 2021 10:19:23 An: Will Deacon Cc

AW: [PATCH] drm/amdgpu: fix potential integer overflow on shift of a int

2021-02-08 Thread Walter Harms
thx for info Von: Christian König Gesendet: Montag, 8. Februar 2021 13:14:49 An: Walter Harms; Colin King; Alex Deucher; David Airlie; Daniel Vetter; Huang Rui; Junwei Zhang; amd-...@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: kernel-janit

AW: [PATCH] drm/amdgpu: fix potential integer overflow on shift of a int

2021-02-08 Thread Walter Harms
thx for info Von: Christian König Gesendet: Montag, 8. Februar 2021 13:14:49 An: Walter Harms; Colin King; Alex Deucher; David Airlie; Daniel Vetter; Huang Rui; Junwei Zhang; amd-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org Cc: kernel-janit

AW: [PATCH] drm/amdgpu: fix potential integer overflow on shift of a int

2021-02-08 Thread Walter Harms
thx for info Von: Christian König Gesendet: Montag, 8. Februar 2021 13:14:49 An: Walter Harms; Colin King; Alex Deucher; David Airlie; Daniel Vetter; Huang Rui; Junwei Zhang; amd-...@lists.freedesktop.org; dri-devel@lists.freedesktop.org Cc: kernel-janit

AW: AW: Cyrillic support in busybox-ash

2021-02-08 Thread Walter Harms
, wh Von: Björn Bidar Gesendet: Montag, 8. Februar 2021 14:27:04 An: busybox@busybox.net; Walter Harms Cc: Simonas Leleiva Betreff: Re: AW: Cyrillic support in busybox-ash Hey Walter, >it is a question of the output device. >How do you access ? via

AW: [PATCH] drm/amdgpu: fix potential integer overflow on shift of a int

2021-02-08 Thread Walter Harms
i am curious: what is the win to have a unsigned 64 bit integer in the first place ? re, wh Von: Christian König Gesendet: Montag, 8. Februar 2021 10:17:42 An: Colin King; Alex Deucher; David Airlie; Daniel Vetter; Huang Rui; Junwei Zhang; amd-gfx@lists.

AW: [PATCH] drm/amdgpu: fix potential integer overflow on shift of a int

2021-02-08 Thread Walter Harms
i am curious: what is the win to have a unsigned 64 bit integer in the first place ? re, wh Von: Christian König Gesendet: Montag, 8. Februar 2021 10:17:42 An: Colin King; Alex Deucher; David Airlie; Daniel Vetter; Huang Rui; Junwei Zhang; amd-...@lists.

AW: [PATCH] drm/amdgpu: fix potential integer overflow on shift of a int

2021-02-08 Thread Walter Harms
i am curious: what is the win to have a unsigned 64 bit integer in the first place ? re, wh Von: Christian König Gesendet: Montag, 8. Februar 2021 10:17:42 An: Colin King; Alex Deucher; David Airlie; Daniel Vetter; Huang Rui; Junwei Zhang; amd-...@lists.

publicModey PublicCode

2021-02-06 Thread Walter Harms
Hallo Liste, nach dem hier doch zu diesem Thema viel geschrieben wurde, zeigte diese kleine Meldung von Heise doch nett wie die Wirklichkeit aussieht; und die Reden nur von Cloulddiensten, wo Amazon*) bisher Marktführer ist ... https://www.heise.de/news/Bund-Microsoft-Kosten-seit-2015-fast-verv

AW: Question on udhcpc script

2021-02-06 Thread Walter Harms
aeh, yes ... important question: did someone fix (and tested) this issue ? re, wh Von: Bernhard Reutner-Fischer Gesendet: Samstag, 6. Februar 2021 11:26:42 An: busybox@busybox.net; Walter Harms; Bhattiprolu RaviKumar; busybox@busybox.net Betreff: Re

AW: PublicMoneyPublicCode Kampagnenmaterial auf Deutsch

2021-02-04 Thread Walter Harms
Weil es ein schwieriges Thema ist fällt es immer unter den Tisch, Open-Source-Hardware, ich habe in dem Entwurf jetzt nichts gefunden (zugegeben er betraf Software) aber ein oder zwei Sätze zum Thema in der Einleitung wäre sicher Hilfreich. zumal die Staaten auch große Mengen Hardware entwickeln l

AW: X Logical Font Description and HiDPI

2021-02-04 Thread Walter Harms
Hi Andrey, not being an expert on X11 fonts i would like to condense your question a bit; when you use a scaleable font: > -monotype-courier new-medium-r-normal--*-120-*-*-m-*-iso10646-1 > -monotype-courier new-medium-r-normal--0-120-0-0-m-0-iso10646-1 you expect a font depending on you DPI setti

AW: Cyrillic support in busybox-ash

2021-02-01 Thread Walter Harms
hi Björn, it is a question of the output device. How do you access ? via xterm+ssh or do you have vt100 attached via serial ? Von: busybox im Auftrag von Björn Bidar Gesendet: Montag, 1. Februar 2021 13:51:21 An: busybox@busybox.net Cc: Simonas Leleiva Be

AW: Question on udhcpc script

2021-02-01 Thread Walter Harms
hello, indeed that looks wrong: it would be easy to invert but i have no setup to test. can you do that ? just change: if [ -z "$(ip -6 route list | grep default)" ]; then into if ! [ -z "$(ip -6 route list | grep default)" ]; then (note the ! here) re, wh

AW: AW: Why doesn't "cat a b > foo" work?

2021-01-20 Thread Walter Harms
oo" work? On 2021-01-20, Walter Harms wrote: > can you give a hint what kernel version is problematic? NB: prior to 2.6.33, sendfile() could only be used with a socket as the destination. I'm seeing the failure with 2.6.33.7 In 2.6.33.7, when used with a normal file as the output,

AW: Why doesn't "cat a b > foo" work?

2021-01-20 Thread Walter Harms
can you give a hint what kernel version is problematic ? Von: busybox im Auftrag von Grant Edwards Gesendet: Mittwoch, 20. Januar 2021 15:43:38 An: busybox@busybox.net Betreff: Re: Why doesn't "cat a b > foo" work? On 2021-01-20, Christophe Leroy wrote:

AW: Why doesn't "cat a b > foo" work?

2021-01-20 Thread Walter Harms
i have test with BusyBox v1.31.1 $cat test.sh echo abcdefghijk > a echo 12345 > b cat a b cat a b > bar cat bar /bin/ash test.sh abcdefghijk 12345 abcdefghijk 12345 same when done manually, hope that helps Von: busybox im Auftrag von Christophe Leroy

AW: xdm login window blinks

2021-01-19 Thread Walter Harms
Hi Intmail, How do you use XDM ? X -query or otherwise ? Von: xorg im Auftrag von intmai...@gmail.com Gesendet: Dienstag, 19. Januar 2021 15:56:21 An: xorg@lists.x.org Betreff: xdm login window blinks Hello, I am using server with remote terminal . Bo

AW: [bug] dd piped input truncates ~1% of values to %4096 on multi-core systems

2020-11-30 Thread Walter Harms
start (and easy done). re, wh Von: John Thomson Gesendet: Montag, 30. November 2020 10:00 An: Walter Harms; busybox@busybox.net Betreff: Re: [bug] dd piped input truncates ~1% of values to %4096 on multi-core systems On Mon, 30 Nov 2020, at 08:39, Walter H

AW: [bug] dd piped input truncates ~1% of values to %4096 on multi-core systems

2020-11-30 Thread Walter Harms
Hi, did you play with the buffering (man stdbuf) ? I suspect the kernel has a more aggressive buffering these days. In one project i had to add fflush() to make sure that i really get all data. I never found a good explanation. Von: busybox im Auftrag von

AW: [PATCH 7/8] mdev: add SIGHUP handler to reload configuration

2020-11-23 Thread Walter Harms
Maybe it is bloat, NTL it es expected behavior as other unix daemons do it this way. IMHO this could be a made into an optional feature. Von: busybox im Auftrag von Denys Vlasenko Gesendet: Sonntag, 22. November 2020 16:24:38 An: Jan Klötzke Cc: busybox

AW: AW: AW: Preparing for libX11 1.7.0

2020-11-20 Thread Walter Harms
nobody expects this to become bug free. The point was to raise awareness that the same class (heap-use-after-free) are still reported. Von: Alan Coopersmith Gesendet: Donnerstag, 19. November 2020 18:07 An: Walter Harms; Keith Packard; Matthieu Herrb

AW: AW: Preparing for libX11 1.7.0

2020-11-19 Thread Walter Harms
XQueryExtension Von: Keith Packard Gesendet: Dienstag, 17. November 2020 03:11 An: Alan Coopersmith; Walter Harms; Matthieu Herrb; xorg-de...@lists.freedesktop.org Cc: Vittorio Zecca Betreff: Re: AW: Preparing for libX11 1.7.0 Alan Coopersmith writes: > ht

AW: AW: Preparing for libX11 1.7.0

2020-11-18 Thread Walter Harms
to close this thread: the problem reported by Vittorio Zecca seems to have vanished with the git version. It does no show up anymore. Vittorio can not reproduce the problem, also. re, wh Von: xorg-devel im Auftrag von Walter Harms Gesendet

AW: AW: Preparing for libX11 1.7.0

2020-11-17 Thread Walter Harms
-devel im Auftrag von Keith Packard Gesendet: Dienstag, 17. November 2020 08:33 An: Vittorio Zecca Cc: xorg-de...@lists.freedesktop.org; Walter Harms Betreff: Re: AW: Preparing for libX11 1.7.0 Vittorio Zecca writes: > Even easier to reproduce running /usr/bin/wish if you have tk installed.

AW: Preparing for libX11 1.7.0

2020-11-16 Thread Walter Harms
before the actions start, i would like to point out that Vittorio Zecca reported a use-after-free in LibX11. It is reproduceable and it is found with libtk. jm2c wh Von: xorg-devel im Auftrag von Matthieu Herrb Gesendet: Montag, 16. November 2020 07:30

test , please ignore

2020-11-13 Thread Walter Harms
test ___ xorg-devel@lists.x.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: https://lists.x.org/mailman/listinfo/xorg-devel

AW: Unable to get GROFF_ENCODING to seep through to sourced subfiles

2020-11-11 Thread Walter Harms
If that does not work try (assuming bash): export GROFF_ENCODING=utf8 groff_pipeline rationale: doing GROFF_ENCODING=utf8 groff_pipeline is setting GROFF_ENCODING for the first element only, if anything later in the pipe needs that also it is lost. Using export means that subshell also have this

AW: sanitized version of libX11 crashes on heap-use-after-free in _XimUnRegisterIMInstantiateCallback

2020-11-10 Thread Walter Harms
Hello, i would like to try an fix it. But i need the reproduce first, can you provide a minimal example.c for me ? wh Von: xorg im Auftrag von Vittorio Zecca Gesendet: Montag, 9. November 2020 07:56:43 An: xorg@lists.x.org Betreff: sanitized version of l

AW: [PATCH] ash: Load $ENV file also if $SSH_CLIENT/SSH2_CLIENT is preset in env, reformat

2020-11-02 Thread Walter Harms
i am sorry i am not an expert in bash booting behavior. Would you mind to drop a few words what bash does in such cases ? Von: busybox im Auftrag von Björn Bidar Gesendet: Montag, 2. November 2020 11:16:32 An: busybox@busybox.net Betreff: [PATCH] ash: Loa

AW: [PATCH][next] SFH: fix error return check for -ERESTARTSYS

2020-10-30 Thread Walter Harms
nit picking: i would without "else" to improve readability: if (ret == -ERESTARTSYS) return -ERESTARTSYS; if (ret < 0) return -ETIMEDOUT; return 0; jm2c wh Von: Colin King Gesendet: Freitag, 30.

AW: Enableing Debug symbols in busybox

2020-10-30 Thread Walter Harms
i do not think that this is intended. Last time i used it i had to remove -Os to make it debugable. Mixing Optimization and debugging is generally a bad idea. Von: busybox im Auftrag von Björn Bidar Gesendet: Donnerstag, 29. Oktober 2020 14:58:32 An: b

AW: [PATCH] x86/unwind: remove unneeded initialization

2020-10-29 Thread Walter Harms
this looks like a reimplementation of bsearch() perhaps the maintainer can add a comment why the kernel implementation is not suitable here ? jm2c wh Von: Lukas Bulwahn [lukas.bulw...@gmail.com] Gesendet: Mittwoch, 28. Oktober 2020 13:21 An: Thomas Gleix

AW: OpenWRT Dropbear v2020.80: Exit before auth: No matching algo kex

2020-10-23 Thread Walter Harms
This is caused by changes in ssh_config. You can try: ssh -oKexAlgorithms=+diffie-hellman-group1-sha1 USER@TARGET or persistent in ssh_config KexAlgorithms=+diffie-hellman-group1-sha1 your mileage may vary etc. re, wh Von: Dropbear [dropbear-boun...

AW: [PATCH] sched/fair: check for idle core

2020-10-22 Thread Walter Harms
To avoid this #ifdef jungle .. I guess it would be save to search for a governor even ones that are not enabled. and a second thing: can we change the subject please ? jm2c wh Von: Peter Zijlstra [pet...@infradead.org] Gesendet: Donnerstag, 22. Oktobe

AW: [PATCH] tools: net: traceevent: Fix 'snprintf' return value check in 'tep_filter_strerror'

2020-10-15 Thread Walter Harms
i guess the whole thing can be made more simple we have len and buflen len=strlen(filter->error_buffer); if (len >= buflen ) return -1; strcpy(buf, filter->error_buffer); jm2c, Von: Fedor Tokarev [ftoka...@gmail.com] Gesendet: Donnerstag, 15. Oktobe

AW: [PATCH] net: sunrpc: Fix 'snprintf' return value check in 'do_xprt_debugfs'

2020-10-15 Thread Walter Harms
if xprt->debugfs->d_name.name can be what ever long it is more clever to use kasprintf() the some for link (no idea how many xprt als possible) jm2c wh Von: Fedor Tokarev [ftoka...@gmail.com] Gesendet: Donnerstag, 15. Oktober 2020 15:59 An: bfie...@field

AW: [PATCH] net: sunrpc: Fix 'snprintf' return value check in 'do_xprt_debugfs'

2020-10-15 Thread Walter Harms
if xprt->debugfs->d_name.name can be what ever long it is more clever to use kasprintf() the some for link (no idea how many xprt als possible) jm2c wh Von: Fedor Tokarev [ftoka...@gmail.com] Gesendet: Donnerstag, 15. Oktober 2020 15:59 An: bfie...@field

AW: XDMCP on TCP

2020-09-17 Thread Walter Harms
everybody is welcome to send patches. re, wh Von: xorg [xorg-boun...@lists.x.org] im Auftrag von Mubarak Qahtani [mubarak.qaht...@outlook.sa] Gesendet: Donnerstag, 17. September 2020 03:12 An: xorg@lists.x.org Betreff: XDMCP on TCP Hi All, Is there an

AW: AW: [PATCH 12/24] getgrent_r.3: Use sizeof() to get buffer size (instead of hardcoding macro name)

2020-09-14 Thread Walter Harms
move BUFLEN Von: Alejandro Colomar [colomar.6@gmail.com] Gesendet: Freitag, 11. September 2020 21:17 An: Walter Harms; mtk.manpa...@gmail.com Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org Betreff: Re: AW: [PATCH 12/24] getgrent_r.3: Use sizeof() to get

AW: [PATCH 04/24] eventfd.2: Use 'PRIxN' macros when printing C99 fixed-width integer types

2020-09-11 Thread Walter Harms
I do not think that this is a good idea. An example should be clear and easy to understand. (e.g. with reduced error handling) These C99 macros are over the top for me. jm2c wh Von: linux-man-ow...@vger.kernel.org [linux-man-ow...@vger.kernel.org] im Auf

AW: [PATCH 22/24] membarrier.2: Note that glibc does not provide a wrapper

2020-09-11 Thread Walter Harms
the groff commands are ducument in man 7 groff .nf No filling or adjusting of output-lines. .fi Fill output lines (for me) a typical use is like this: .nf struct timeval { time_t tv_sec; /* seconds */ suseconds_t tv_usec;/* microseconds */ }; .fi In the top secti

AW: [PATCH 17/24] get_phys_pages.3: Write 'long' instead of 'long int'

2020-09-11 Thread Walter Harms
sys/sysinfo.h:extern long int get_phys_pages (void) for the real world i would say that long int == long but for the same reason i would say what the include says and stay away from discussions. jm2c, wh Von: linux-man-ow...@vger.kernel.org [linux-man-

AW: [PATCH 12/24] getgrent_r.3: Use sizeof() to get buffer size (instead of hardcoding macro name)

2020-09-11 Thread Walter Harms
BUFLEN should be remove completely or stay jm2c wh Von: linux-man-ow...@vger.kernel.org [linux-man-ow...@vger.kernel.org] im Auftrag von Alejandro Colomar [colomar.6@gmail.com] Gesendet: Donnerstag, 10. September 2020 23:13 An: mtk.manpa...@gmail.com

AW: [PATCHv2] hwclock: use settimeofday syscall directly

2020-08-31 Thread Walter Harms
maybe its a bit late but ... doing syscall() is always last resort, IMHO it would be better to separate this into a bb_set_tod() and put all the strings here ... and replace it when the libc guys have a single standard. jm2c, re, wh Von: busybox [busybox

AW: [PATCH 2/4] httpd: Don't add Date header to response

2020-08-31 Thread Walter Harms
> Why wasn't ntp available for them? How often does this happen in the wild? this can happen when you have a remote station with temporally no reception. E.G. our station have a sanity check for the time and will not start if the date is not set manually. jm2c ___

AW: [PATCH v2] HID: roccat: add bounds checking in kone_sysfs_write_settings()

2020-08-25 Thread Walter Harms
lets hope the maintainer picks that up. re, wh Von: Dan Carpenter [dan.carpen...@oracle.com] Gesendet: Dienstag, 25. August 2020 09:29 An: Walter Harms Cc: Stefan Achatz; Jiri Kosina; Benjamin Tissoires; linux-in...@vger.kernel.org; linux-kernel

AW: [PATCH v2] HID: roccat: add bounds checking in kone_sysfs_write_settings()

2020-08-24 Thread Walter Harms
hello Dan, i notice that you can shorten the line to: (line above checks for count==sizeof(struct kone_settings)) difference = memcmp(settings, &kone->settings, count); nothing special just to shorten the line and make use of count. and just to save one indent level and because its readabel n

AW: AW: [PATCH 5/5] Add manpage for fsconfig(2)

2020-08-07 Thread Walter Harms
found it, next i will look for version not varsion Von: David Howells [dhowe...@redhat.com] Gesendet: Freitag, 7. August 2020 18:27 An: Walter Harms Cc: dhowe...@redhat.com; mtk.manpa...@gmail.com; linux-fsde...@vger.kernel.org; christian.brau

AW: [PATCH 5/5] Add manpage for fsconfig(2)

2020-08-07 Thread Walter Harms
hi, thx for you efford, maybe it is obvious but i did not see it .. starting with what kernel version are these features available ? re, wh Von: linux-man-ow...@vger.kernel.org [linux-man-ow...@vger.kernel.org] im Auftrag von David Howells [dhowe...@redha

AW: [PATCH] coresight: cti: Fix error handling in probe

2020-06-12 Thread Walter Harms
Hi Dan, nit picking in cti_pm_release() IMHO this should be done in 2 steps: if (--nr_cti_cpu == 0) -> --nr_cti_cpu ; if ( nr_cti_cpu == 0) the decrement is easy to miss (what i did first). yes, i noticed that it is also in the original code and it is not that important but while you a

AW: BusyBox 1.30.1 fstrim did not take effect

2020-06-09 Thread Walter Harms
fstrim check first with mount (or df or ..) what the mountpoints in your system are. Von: busybox im Auftrag von Tang Jiye Gesendet: Dienstag, 9. Juni 2020 04:40:24 An: busybox@busybox.net Betreff: BusyBox 1.30.1 fstrim did not take effect Hi, I am us

AW: Update the keyboard layouts

2020-06-06 Thread Walter Harms
hi, you are mixing two things; 1. acceptance of patches upsteam (e.g. here with xorg) here you find everything in git. 2. packaging the code for users, normally you see the binary code only. this is done by the package maintainer. the binaries are distributed as deb (in case of debian

AW: AW: Implementing PseudoColor support on TrueColor screens

2020-06-02 Thread Walter Harms
a assume this is intentional backwards ? for (int x = width-1; x >= 0; x--) { if st2d_8to24table contains no rubbish the colors should be ok now, are they ? what means "squashed image" ? a scaling problem ? To make things more easy to debug, can you save image->data where you know what who that

AW: Implementing PseudoColor support on TrueColor screens

2020-06-02 Thread Walter Harms
the correct way to do is use XPutPixel(). color these days if pretty easy color=0/r/g/b You need a lookuptable for 256 colors (=st2d_8to24table[i] ?) and that should it be. re, wh Von: xorg im Auftrag von Sleep Gesendet: Dienstag, 2. Juni 2020 08:28:

AW: XInput2 raw events only for root window

2020-05-29 Thread Walter Harms
It would be helpful if you would be a bit more verbose. Your are using X11 ? Xlib ? Qt ? Most people are aware of a whole plethora of libs and need to know so exactly as possible what you are doing, a small pseudo code or real code is also a good idea. jm2c, wh ___

AW: [PATCH 1/2 v3] net: ethernet: ti: fix some return value check of cpsw_ale_create()

2020-05-20 Thread Walter Harms
just a notice: from my casual observation i noticed that most people expect a function to return NULL on error (as seen here). So i would suggest to return NULL and (if needed) the error code otherwise. jm2c, re wh Von: kernel-janitors-ow...@vger.kernel.o

AW: How to use function lbb_main of the libbusybox.so to a C program

2020-05-17 Thread Walter Harms
Hello, i am not sure that i understand your idea. you think to use libbusybox as a kind of compiler ? note: under normal condition this is not very effective as it is cheaper to write a simple c programm that does exactly what you want. Von: busybox im Auf

AW: [PATCH] rtlwifi: rtl8192ee: remove redundant for-loop

2020-05-15 Thread Walter Harms
if someone has same spare time, this driver need a bit more love ... SO far i can see in rtl92ee_phy_iq_calibrate: * IQK_MATRIX_REG_NUM should be used instead 8 hardcoded. * the for-loop in the beginning is obfuscating that it sets simply final_candidate this can be cleaned: reg_e94 = res

AW: [PATCH] rtlwifi: rtl8192ee: remove redundant for-loop

2020-05-15 Thread Walter Harms
if someone has same spare time, this driver need a bit more love ... SO far i can see in rtl92ee_phy_iq_calibrate: * IQK_MATRIX_REG_NUM should be used instead 8 hardcoded. * the for-loop in the beginning is obfuscating that it sets simply final_candidate this can be cleaned: reg_e94 = res

  1   2   3   4   5   6   7   8   9   10   >