Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21745#discussion_r202236189
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -2387,4 +2387,25 @@ class DataFrameSuite extends QueryTest with
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20795
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20795#discussion_r202231590
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1204,16 +1207,46 @@ class Analyzer(
* only
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21753#discussion_r202211733
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -586,12 +581,17 @@ class Analyzer
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21753
LGTM
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21751
Please follow the style suggestions in the future.
LGTM
Thanks! Merged to master
---
-
To unsubscribe, e
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21751#discussion_r202191341
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -557,4 +558,21 @@ class AnalysisSuite extends
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21751#discussion_r202191261
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -557,4 +558,21 @@ class AnalysisSuite extends
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20208
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20208
@dongjoon-hyun This PR is to improve the test coverage. LGTM.
When the schema do not match with the schemas of underlying data source,
the current error messages might be weird. This is
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21742
LGTM
Thanks! Merged to master.
@gengliangwang Please submit the follow-up PRs to resolve the sub tasks and
the good comment in the PR review
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20795#discussion_r202175343
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/LookupFunctionsSuite.scala
---
@@ -0,0 +1,107 @@
+/*
+ * Licensed
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21753#discussion_r202107542
--- Diff: sql/core/src/test/resources/sql-tests/results/pivot.sql.out ---
@@ -192,3 +192,33 @@ struct<>
-- !query 12
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21753#discussion_r202105958
--- Diff: sql/core/src/test/resources/sql-tests/results/pivot.sql.out ---
@@ -192,3 +192,33 @@ struct<>
-- !query 12
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21745
We might need to get rid of AnalysisBarrier in the next release. This
already caused at least three regressions in 2.3
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21589
cc @jiangxb1987
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21751#discussion_r201879749
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/AnalysisSuite.scala
---
@@ -557,4 +558,21 @@ class AnalysisSuite extends
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21736
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21753#discussion_r201870662
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -586,12 +581,16 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21184#discussion_r201769371
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -2265,4 +2266,15 @@ class DataFrameSuite extends QueryTest with
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21737
@mgaido91 Since 2.3.2 release will be out soon, I merge this fix to 2.3
branch. Regarding the comments of the test cases, could you submit a follow-up
PR
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21737#discussion_r201762849
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/GroupedDatasetSuite.scala ---
@@ -93,4 +93,16 @@ class GroupedDatasetSuite extends QueryTest with
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21737#discussion_r201761976
--- Diff: python/pyspark/sql/tests.py ---
@@ -5925,6 +5925,22 @@ def test_invalid_args(self):
'mixture.*aggregate fun
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21737
LGTM
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21737#discussion_r201758572
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -738,6 +738,10 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20795#discussion_r201757597
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/LookupFunctionsSuite.scala
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20795#discussion_r201757391
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/LookupFunctionsSuite.scala
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21745
Which PR caused this regression?
CC @jerryshao We need to block 2.3.2 release before addressing this issue
---
-
To
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21742#discussion_r201569743
--- Diff: dev/sparktestsupport/modules.py ---
@@ -170,6 +170,16 @@ def __hash__(self):
]
)
+avro = Module(
--- End diff
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20208#discussion_r201506731
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/ReadSchemaTest.scala
---
@@ -0,0 +1,493 @@
+/*
+ * Licensed to the
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21321
`catalogString ` is preferred in error messages.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21321
@HyukjinKwon The whole PR is doing the wrong things. That is why I reverted
it. I do not want the others to follow this PR. For the other PRs whose main
objective are not to use `simpleString
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21722#discussion_r201181931
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Metadata.scala ---
@@ -215,6 +215,8 @@ object Metadata {
x
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21722#discussion_r201180956
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/types/Metadata.scala ---
@@ -215,6 +215,8 @@ object Metadata {
x
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21657#discussion_r201172532
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/UnivocityParser.scala
---
@@ -38,24 +38,28 @@ class UnivocityParser
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/20208#discussion_r201170482
--- Diff: docs/sql-programming-guide.md ---
@@ -815,6 +815,54 @@ should start with, they can set `basePath` in the data
source options. For examp
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21582
> ORC-344 Support for using Decimal64ColumnVector
This can achieve better perf number? Could you share the perf g
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21156
cc @maryannxue
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21737#discussion_r201164293
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -738,6 +738,10 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21737#discussion_r201163844
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -738,6 +738,10 @@ class Analyzer
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21728
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18544#discussion_r201157527
--- Diff:
sql/hive/src/test/java/org/apache/spark/sql/hive/execution/UDAFEmpty.java ---
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18544
cc @stanzhai Could you address my above comments? Thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18544#discussion_r201157378
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveSessionCatalog.scala ---
@@ -129,14 +129,14 @@ private[sql] class HiveSessionCatalog
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18544
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20795
ping @kevinyu98 @dilipbiswal
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21321
Let me revert the changes. Please re-submit the fix.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21321
I think the fix is wrong. We should not use simpleString but catalogString,
because simpleString will do the truncation
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21360
sorry, just updated the comment. We can add a JDBC connector option. Users
can have two JDBC sources for a single JDBC table. One is with predicate
pushdown; another without predicate pushdown
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21360
@TomaszGaweda @maryannxue Let us reduce the complexity and introduce a new
JDBC option for controlling the predicate pushdown.
```Scala
val JDBC_FILTER_PUSHDOWN_ENABLED =
buildConf
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21682
ping @wangyum
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21728
cc @cloud-fan @hvanhovell
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21728
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21720#discussion_r200830672
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -515,13 +515,33 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21720#discussion_r200831720
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -559,8 +574,8 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21720#discussion_r200829969
--- Diff: sql/core/src/test/resources/sql-tests/results/pivot.sql.out ---
@@ -144,51 +155,162 @@ PIVOT (
sum(earnings * s)
FOR course IN
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21720#discussion_r200831568
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -515,13 +515,33 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21720#discussion_r200831755
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -515,13 +515,33 @@ class Analyzer
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21720#discussion_r200830835
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -515,13 +515,33 @@ class Analyzer
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/21728
[SPARK-24759] [SQL] No reordering keys for broadcast hash join
## What changes were proposed in this pull request?
As the implementation of the broadcast hash join is independent of the
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21608#discussion_r200704192
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala
---
@@ -47,15 +48,26 @@ object CommandUtils extends Logging
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21720#discussion_r200518399
--- Diff: sql/core/src/test/resources/sql-tests/inputs/pivot.sql ---
@@ -88,12 +93,12 @@ PIVOT (
);
-- pivot with aliases and projection
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21620#discussion_r200514583
--- Diff:
sql/core/src/test/resources/sql-tests/results/typeCoercion/native/arrayJoin.sql.out
---
@@ -0,0 +1,90 @@
+-- Automatically generated by
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21693
@maropu @HyukjinKwon @zzcclp @tmnd1991 Could any of you submit a follow-up
PR for PySpark?
---
-
To unsubscribe, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21693#discussion_r200419437
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/functions.scala ---
@@ -2934,6 +2934,17 @@ object functions {
FromUTCTimestamp(ts.expr
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21655
LGTM
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21712
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21608#discussion_r200207191
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/CommandUtils.scala
---
@@ -47,22 +47,34 @@ object CommandUtils extends Logging
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21608
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/21716
[SPARK-17213][FOLLOW-UP] Improve the test of SPARK-17213
## What changes were proposed in this pull request?
This is a minor improvement for the test of SPARK-17213
## How was this
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21655#discussion_r199963152
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -619,6 +619,7 @@ class SessionCatalog
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21705#discussion_r199935428
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala
---
@@ -66,6 +66,12 @@ object StaticSQLConf
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21705#discussion_r199936887
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/StaticSQLConf.scala
---
@@ -66,6 +66,12 @@ object StaticSQLConf
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21596
What is the conclusion of this perf comparison? A regression?
If we do not have a strong reason, we should avoid the upgrade. Jackson is
pretty important for our JSON sources
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21668#discussion_r199552405
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -375,16 +375,16 @@ case class CatalogStatistics
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21668#discussion_r199552346
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -375,16 +375,16 @@ case class CatalogStatistics
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/19757#discussion_r199550269
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
---
@@ -366,10 +366,16 @@ case class CatalogStatistics
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21682
It is a regression that was introduced in Spark 1.2. Almost 4 years ago.
https://issues.apache.org/jira/browse/SPARK-4453
Thus, I think no need to document it. The pushdown can be
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21682
@maropu We accidentally dropped the pushdown of these data types when we
refactored the file formats. You can check the change history and find the PR
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21682
cc @gengliangwang
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21682#discussion_r199390298
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilters.scala
---
@@ -42,6 +42,14 @@ private[parquet] class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21320#discussion_r199389588
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetRowConverter.scala
---
@@ -182,18 +182,20 @@ private
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21320#discussion_r199368095
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
---
@@ -47,16 +47,25 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21320#discussion_r199364935
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
---
@@ -71,9 +80,22 @@ private[parquet
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21320#discussion_r199389252
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
---
@@ -71,9 +80,22 @@ private[parquet
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21320#discussion_r199356283
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
---
@@ -47,16 +47,25 @@ import
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21320#discussion_r199354841
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFileFormat.scala
---
@@ -417,11 +417,12 @@ class
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21320#discussion_r199365004
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetReadSupport.scala
---
@@ -47,16 +47,25 @@ import
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21688
ok to test
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21674
Thanks! Merged to master/2.3
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21674#discussion_r199315202
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/dsl/package.scala ---
@@ -149,6 +149,7 @@ package object dsl
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/21674#discussion_r199314983
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala
---
@@ -2792,4 +2792,25 @@ class SQLQuerySuite extends QueryTest with
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21613
cc @liufengdb
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21600
Thanks! Merged to master
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21389
Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21602
This is also a regression. Backported to 2.3 branch too.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18900
LGTM Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21389
LGTM
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21389
retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/21553
LGTM Thanks! Merged to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
1101 - 1200 of 14069 matches
Mail list logo
