[I] Configuration overview page has link to table section which does not exist on that page. [accumulo-website]

2024-09-23 Thread via GitHub
DomGarguilo opened a new issue, #446: URL: https://github.com/apache/accumulo-website/issues/446 On this page: https://accumulo.apache.org/docs/2.x/configuration/overview The ordered list in the Server Configuration section has links to other sections on that page. All of the links wo

Re: [I] IPC not respecting not preserving dict ID [arrow-rs]

2024-09-23 Thread via GitHub
brancz commented on issue #6443: URL: https://github.com/apache/arrow-rs/issues/6443#issuecomment-2368905461 This confused me at first as well, but #5971 actually only solved it for IPC via flight, because it pre-processes the schema. This is about IPC without flight. I opened #6444

Re: [PR] incubator-kie-issues#1483: Create a common Kie Flyway initializer for Kie Modules [incubator-kie-kogito-examples]

2024-09-23 Thread via GitHub
pefernan commented on PR #2014: URL: https://github.com/apache/incubator-kie-kogito-examples/pull/2014#issuecomment-2368905263 In this PR I tried addressing the examples that use flyway to consume the new initializer, however a lot of the examples are still using the old images. So I'll le

Re: [PR] MINOR; Replace gt and lt char with html encoding [kafka]

2024-09-23 Thread via GitHub
jsancio commented on PR #17235: URL: https://github.com/apache/kafka/pull/17235#issuecomment-2368903179 Thanks @chia7712 . I fixed those encoding issues. > https://github.com/apache/kafka/blob/trunk/docs/ops.html#L4249 I couldn't find anything wrong with that line. Did you mean to l

Re: [PR] [HUDI-8203] Make record merge mode the primary merging config [hudi]

2024-09-23 Thread via GitHub
hudi-bot commented on PR #11943: URL: https://github.com/apache/hudi/pull/11943#issuecomment-2368903524 ## CI report: * aac457a9a8fb37ce058cb53cbd313a196f3969d2 UNKNOWN * 63c9a0008303f89c1d2e8e868ac28add20b69229 UNKNOWN * 5d466c3f3c6dfaf91e579a483081911f63d32ec6 UNKNOWN *

Re: [PR] Disable shading when pinot-fastdev profile is enabled [pinot]

2024-09-23 Thread via GitHub
rfscholte commented on code in PR #13956: URL: https://github.com/apache/pinot/pull/13956#discussion_r1771816878 ## pinot-connectors/pinot-spark-2-connector/pom.xml: ## @@ -35,6 +35,45 @@ + + build-shaded-jar + Review Comment: I think you want to use

Re: [I] Any plan to support JSON or JSONB? [datafusion]

2024-09-23 Thread via GitHub
alamb commented on issue #7845: URL: https://github.com/apache/datafusion/issues/7845#issuecomment-2368900548 > somehow get filter pushdown / late materialization to work based on the result of a UDF so some columns aren't decompressed (or even aren't fetched) unless they're needed T

[PR] Simple auth manager documentation - Airflow only [airflow]

2024-09-23 Thread via GitHub
vincbeck opened a new pull request, #42418: URL: https://github.com/apache/airflow/pull/42418 Seems like making modifications in documentation of Airflow core and providers at the same time can lead to some doc generation issues. Scope down #42390 to only Airflow core

Re: [PR] HBASE-28830 when a procedure on a table executed as a child procedure… [hbase]

2024-09-23 Thread via GitHub
chandrasekhar-188k commented on PR #6247: URL: https://github.com/apache/hbase/pull/6247#issuecomment-2368900254 > See #6279 with this implementation the problem with the child table procedure can be solved. i will pull this change and check if there are any other problems with this

Re: [PR] Fix: check ambiguous column reference [datafusion]

2024-09-23 Thread via GitHub
eejbyfeldt commented on code in PR #12467: URL: https://github.com/apache/datafusion/pull/12467#discussion_r1771820737 ## datafusion/sqllogictest/test_files/join.slt: ## @@ -1209,3 +1209,20 @@ drop table t1; statement ok drop table t2; + +# Test SQLancer issue: https://githu

Re: [I] After upgrade to v3.13, all data sources and other chart properties are missing [superset]

2024-09-23 Thread via GitHub
rusackas closed issue #30329: After upgrade to v3.13, all data sources and other chart properties are missing URL: https://github.com/apache/superset/issues/30329 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] Issues with Language Settings in Superset: Configuration Not Saved, Partial Translations, and Redirects [superset]

2024-09-23 Thread via GitHub
rusackas commented on issue #30334: URL: https://github.com/apache/superset/issues/30334#issuecomment-2368898932 I haven't looked much at the other two issues, but the second one sounds legit, and maybe you can set a cookie or use localstorage to resolve this. The third, I believe, is a dup

Re: [I] Virtual Thread Support: replace synchronized with ReentrantGuard [pekko]

2024-09-23 Thread via GitHub
pjfanning commented on issue #1089: URL: https://github.com/apache/pekko/issues/1089#issuecomment-2368898531 @KrnSaurabh I don't think we want this change at the moment. ReentrantGuards are slower than synchronized blocks. -- This is an automated message from the Apache Git Service. T

Re: [PR] [HUDI-8203] Make record merge mode the primary merging config [hudi]

2024-09-23 Thread via GitHub
hudi-bot commented on PR #11943: URL: https://github.com/apache/hudi/pull/11943#issuecomment-2368897778 ## CI report: * aac457a9a8fb37ce058cb53cbd313a196f3969d2 UNKNOWN * 63c9a0008303f89c1d2e8e868ac28add20b69229 UNKNOWN * 5d466c3f3c6dfaf91e579a483081911f63d32ec6 UNKNOWN *

Re: [PR] Backport "HBASE-28868 Add missing permission check for updateRSGroupConfig in branch-2" to branch-2.6 [hbase]

2024-09-23 Thread via GitHub
Apache-HBase commented on PR #6281: URL: https://github.com/apache/hbase/pull/6281#issuecomment-2368897687 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] Make Custom Config Optional [pinot]

2024-09-23 Thread via GitHub
Jackie-Jiang commented on code in PR #14014: URL: https://github.com/apache/pinot/pull/14014#discussion_r1771816298 ## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TableConfig.java: ## @@ -77,14 +77,13 @@ public class TableConfig extends BaseJsonConfig { private

Re: [I] [Bug] Spring cloud gateway project logback cannot print TraceID [skywalking]

2024-09-23 Thread via GitHub
chenbihao commented on issue #10509: URL: https://github.com/apache/skywalking/issues/10509#issuecomment-2368896793 As far as I know, the corresponding plugin is not maintained by anyone, so gateway 4 is not supported -- This is an automated message from the Apache Git Service. To

Re: [PR] Standardize shell command loggers [accumulo]

2024-09-23 Thread via GitHub
keith-turner commented on code in PR #4899: URL: https://github.com/apache/accumulo/pull/4899#discussion_r1771818422 ## assemble/conf/log4j2.properties: ## @@ -33,6 +33,9 @@ appender.console.layout.pattern = %style{%d{ISO8601}}{dim,cyan} %style{[}{red}%s logger.shellaudit.name

Re: [PR] Standardize shell command loggers [accumulo]

2024-09-23 Thread via GitHub
keith-turner commented on code in PR #4899: URL: https://github.com/apache/accumulo/pull/4899#discussion_r1771818422 ## assemble/conf/log4j2.properties: ## @@ -33,6 +33,9 @@ appender.console.layout.pattern = %style{%d{ISO8601}}{dim,cyan} %style{[}{red}%s logger.shellaudit.name

Re: [PR] Backport "HBASE-28868 Add missing permission check for updateRSGroupConfig in branch-2" to branch-2.6 [hbase]

2024-09-23 Thread via GitHub
Apache-HBase commented on PR #6281: URL: https://github.com/apache/hbase/pull/6281#issuecomment-2368895726 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] [HUDI-6780] Introduce enums instead of classnames in table properties [hudi]

2024-09-23 Thread via GitHub
codope commented on code in PR #9590: URL: https://github.com/apache/hudi/pull/9590#discussion_r1771817705 ## hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java: ## @@ -1031,6 +1050,9 @@ public PropertyBuilder fromProperties(Properties properties)

Re: [PR] Rate limiter [polaris]

2024-09-23 Thread via GitHub
andrew4699 commented on code in PR #278: URL: https://github.com/apache/polaris/pull/278#discussion_r1771817948 ## polaris-service/src/main/java/org/apache/polaris/service/ratelimiter/DefaultRateLimiterFactory.java: ## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Fou

Re: [PR] Backport "HBASE-27903 Skip submitting Split/Merge procedure when split/merge is disabled at table level" to branch-2 [hbase]

2024-09-23 Thread via GitHub
NihalJain merged PR #6186: URL: https://github.com/apache/hbase/pull/6186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apach

Re: [I] IPC not respecting not preserving dict ID [arrow-rs]

2024-09-23 Thread via GitHub
tustvold commented on issue #6443: URL: https://github.com/apache/arrow-rs/issues/6443#issuecomment-2368894859 Tagging @thinkharderdev who implemented this functionality in https://github.com/apache/arrow-rs/pull/5971 -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Rate limiter [polaris]

2024-09-23 Thread via GitHub
andrew4699 commented on code in PR #278: URL: https://github.com/apache/polaris/pull/278#discussion_r1771817363 ## polaris-service/src/main/java/org/apache/polaris/service/ratelimiter/RateLimiterFilter.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation

[I] Error when printing rdf-star to RDF/XML [jena]

2024-09-23 Thread via GitHub
william-vw opened a new issue, #2733: URL: https://github.com/apache/jena/issues/2733 ### Version 5.1.0 ### What happened? Reading rdf-star code into a `Model` and subsequently writing it to an output stream using the default format (`RDF/XML`) causes an error. It does n

Re: [PR] feat: Implement read support for String/Binary View types [arrow-nanoarrow]

2024-09-23 Thread via GitHub
paleolimbot commented on code in PR #596: URL: https://github.com/apache/arrow-nanoarrow/pull/596#discussion_r1771817566 ## src/nanoarrow/common/inline_array.h: ## @@ -467,52 +468,136 @@ static inline ArrowErrorCode ArrowArrayAppendDouble(struct ArrowArray* array, return NAN

Re: [PR] Require `Debug` for `AnalyzerRule`, `FunctionRewriter`, and `OptimizerRule` [datafusion]

2024-09-23 Thread via GitHub
alamb merged PR #12556: URL: https://github.com/apache/datafusion/pull/12556 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] fix: Correct results for grouping sets when columns contain nulls [datafusion]

2024-09-23 Thread via GitHub
alamb commented on PR #12571: URL: https://github.com/apache/datafusion/pull/12571#issuecomment-2368891896 Thank you @eejbyfeldt cc @thinkharderdev as I think you / your team implemented the `GROUPING SETS` implementation originally -- This is an automated message from the Apache

Re: [PR] Require `Debug` for `AnalyzerRule`, `FunctionRewriter`, and `OptimizerRule` [datafusion]

2024-09-23 Thread via GitHub
alamb commented on PR #12556: URL: https://github.com/apache/datafusion/pull/12556#issuecomment-2368892765 🚀 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

Re: [I] Issues with Language Settings in Superset: Configuration Not Saved, Partial Translations, and Redirects [superset]

2024-09-23 Thread via GitHub
rusackas commented on issue #30334: URL: https://github.com/apache/superset/issues/30334#issuecomment-2368892102 Partial translations are not considered bugs, as we'll be chasing that down approximately forever. If you'd like to contribute or fix translations, we encourage you to edit the `

Re: [PR] Warn instead of error for unused imports [datafusion]

2024-09-23 Thread via GitHub
alamb merged PR #12588: URL: https://github.com/apache/datafusion/pull/12588 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] Rate limiter [polaris]

2024-09-23 Thread via GitHub
andrew4699 commented on code in PR #278: URL: https://github.com/apache/polaris/pull/278#discussion_r1771815627 ## polaris-service/src/main/java/org/apache/polaris/service/ratelimiter/RateLimiterFilter.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Backport "HBASE-28868 Add missing permission check for updateRSGroupConfig in branch-2" to branch-2.5 [hbase]

2024-09-23 Thread via GitHub
Apache-HBase commented on PR #6282: URL: https://github.com/apache/hbase/pull/6282#issuecomment-2368890103 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] feat: expose HTTP/2 max frame size in `object_store` [arrow-rs]

2024-09-23 Thread via GitHub
tustvold merged PR #6442: URL: https://github.com/apache/arrow-rs/pull/6442 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apa

Re: [I] Superset CSRF Token missing error [superset]

2024-09-23 Thread via GitHub
rusackas closed issue #22873: Superset CSRF Token missing error URL: https://github.com/apache/superset/issues/22873 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Rate limiter [polaris]

2024-09-23 Thread via GitHub
andrew4699 commented on code in PR #278: URL: https://github.com/apache/polaris/pull/278#discussion_r1771813868 ## polaris-service/src/main/java/org/apache/polaris/service/ratelimiter/TokenBucketRateLimiter.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Founda

Re: [I] Superset CSRF Token missing error [superset]

2024-09-23 Thread via GitHub
rusackas commented on issue #22873: URL: https://github.com/apache/superset/issues/22873#issuecomment-236936 @Davidkramer1999 what you're looking at is the API docs, not the Superset UI. Are you accessing this via the documentation website, or via your own Superset instance, e.g. http:/

Re: [PR] Backport "HBASE-28868 Add missing permission check for updateRSGroupConfig in branch-2" to branch-2.5 [hbase]

2024-09-23 Thread via GitHub
Apache-HBase commented on PR #6282: URL: https://github.com/apache/hbase/pull/6282#issuecomment-2368887215 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] Rate limiter [polaris]

2024-09-23 Thread via GitHub
andrew4699 commented on code in PR #278: URL: https://github.com/apache/polaris/pull/278#discussion_r1771813868 ## polaris-service/src/main/java/org/apache/polaris/service/ratelimiter/TokenBucketRateLimiter.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Backport "HBASE-28868 Add missing permission check for updateRSGroupConfig in branch-2" to branch-2.6 [hbase]

2024-09-23 Thread via GitHub
Apache-HBase commented on PR #6281: URL: https://github.com/apache/hbase/pull/6281#issuecomment-2368887478 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Logfile | Comment | |::|--:|:|::|:---:| | +0 :ok: | reexe

Re: [PR] [fix] Key_Shared mode comsumption latency when low traffic [pulsar]

2024-09-23 Thread via GitHub
lhotari commented on PR #23340: URL: https://github.com/apache/pulsar/pull/23340#issuecomment-2368885444 One additional detail here is that another merged PR contains a small change to eliminate the extra latency when Key_Shared is reading ahead when keys are blocked: https://github.com/ap

Re: [PR] Rate limiter [polaris]

2024-09-23 Thread via GitHub
andrew4699 commented on code in PR #278: URL: https://github.com/apache/polaris/pull/278#discussion_r1771811983 ## polaris-service/src/main/java/org/apache/polaris/service/ratelimiter/TokenBucketRateLimiter.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] HBASE-28382 Support building hbase-connectors with JDK17 [hbase-connectors]

2024-09-23 Thread via GitHub
ndimiduk commented on PR #132: URL: https://github.com/apache/hbase-connectors/pull/132#issuecomment-2368883966 Ah okay. Sorry, I only looked at the PR, not Jira. Yes, I think it would be nice if it all happened together because then the new pre-commit checker will verify the code bef

Re: [I] making `LexRequirement` an actual struct [datafusion]

2024-09-23 Thread via GitHub
alamb closed issue #12255: making `LexRequirement` an actual struct URL: https://github.com/apache/datafusion/issues/12255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] LexRequirement as a struct, instead of a type [datafusion]

2024-09-23 Thread via GitHub
alamb merged PR #12583: URL: https://github.com/apache/datafusion/pull/12583 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] LexRequirement as a struct, instead of a type [datafusion]

2024-09-23 Thread via GitHub
alamb commented on code in PR #12583: URL: https://github.com/apache/datafusion/pull/12583#discussion_r1771810535 ## datafusion/physical-expr-common/src/sort_expr.rs: ## @@ -264,9 +267,55 @@ pub type LexOrdering = Vec; /// a reference to a lexicographical ordering. pub type Le

Re: [PR] fix: window function range offset should be long instead of int [datafusion-comet]

2024-09-23 Thread via GitHub
huaxingao commented on code in PR #733: URL: https://github.com/apache/datafusion-comet/pull/733#discussion_r1771810211 ## native/core/src/execution/datafusion/planner.rs: ## @@ -1692,16 +1692,33 @@ impl PhysicalPlanner { .and_then(|inner| inner.lower_frame_bound_st

Re: [PR] [fix] Key_Shared mode comsumption latency when low traffic [pulsar]

2024-09-23 Thread via GitHub
lhotari commented on code in PR #23340: URL: https://github.com/apache/pulsar/pull/23340#discussion_r1771809739 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java: ## @@ -1231,14 +1231,14 @@ The max allowed delay for delayed delivery (in mi

Re: [PR] fix: Update JDK, deps and use "release" [myfaces-tobago]

2024-09-23 Thread via GitHub
lofwyr14 merged PR #5483: URL: https://github.com/apache/myfaces-tobago/pull/5483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myface

[PR] HBASE-28867 Backport "HBASE-20653 Add missing observer hooks for region server group to MasterObserver" to branch-2 [hbase]

2024-09-23 Thread via GitHub
NihalJain opened a new pull request, #6284: URL: https://github.com/apache/hbase/pull/6284 - Backports #6276 to branch-2.5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[PR] Main file upload [myfaces-tobago]

2024-09-23 Thread via GitHub
lofwyr14 opened a new pull request, #5484: URL: https://github.com/apache/myfaces-tobago/pull/5484 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

Re: [PR] Update introduction.md [datafusion]

2024-09-23 Thread via GitHub
alamb commented on PR #12577: URL: https://github.com/apache/datafusion/pull/12577#issuecomment-2368877930 Marking as draft as I think this PR is no longer waiting on feedback. Please mark it as ready for review when it is ready for another look -- This is an automated message from the A

Re: [PR] PHOENIX-7382 Eliminating index building and treating max lookback as … [phoenix]

2024-09-23 Thread via GitHub
kadirozde commented on code in PR #1964: URL: https://github.com/apache/phoenix/pull/1964#discussion_r1771808083 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCQueryIT.java: ## @@ -701,8 +698,14 @@ public void testCDCIndexBuildAndVerification() throws Exception {

Re: [PR] Improve documentation and add `Display` impl to `EquivalenceProperties` [datafusion]

2024-09-23 Thread via GitHub
alamb commented on PR #12590: URL: https://github.com/apache/datafusion/pull/12590#issuecomment-2368876359 FWY @wiedld -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To u

Re: [PR] fix: python schema repr does not truncate output [arrow-nanoarrow]

2024-09-23 Thread via GitHub
danepitkin commented on PR #628: URL: https://github.com/apache/arrow-nanoarrow/pull/628#issuecomment-2368875672 Thanks for the review! I suppose we could have a really high limit like 1000 chars in that case. Although, if a user prints out a schema, I assume they are in some sort of intera

Re: [PR] Add Docs and Examples and helper methods to `PhysicalSortExpr` [datafusion]

2024-09-23 Thread via GitHub
alamb merged PR #12589: URL: https://github.com/apache/datafusion/pull/12589 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusi

Re: [PR] fix(sqllab): access issue:#28596 [superset]

2024-09-23 Thread via GitHub
villebro commented on PR #29311: URL: https://github.com/apache/superset/pull/29311#issuecomment-2368875120 Echoing @john-bodley's comment here - we really do need to do template processing here, in case there's jinja logic in the query. @leoguo1024 @Hen0k can you check if this issue is sti

[PR] Bump org.codehaus.mojo:extra-enforcer-rules from 1.8.0 to 1.9.0 [directory-scimple]

2024-09-23 Thread via GitHub
dependabot[bot] opened a new pull request, #681: URL: https://github.com/apache/directory-scimple/pull/681 Bumps [org.codehaus.mojo:extra-enforcer-rules](https://github.com/mojohaus/extra-enforcer-rules) from 1.8.0 to 1.9.0. Release notes Sourced from https://github.com/mojohaus/e

Re: [PR] Add Docs and Examples and helper methods to `PhysicalSortExpr` [datafusion]

2024-09-23 Thread via GitHub
alamb commented on PR #12589: URL: https://github.com/apache/datafusion/pull/12589#issuecomment-2368873660 Thanks for the quick review @comphead -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] deprecates lru block cache and makes TinyLfu the new default [accumulo]

2024-09-23 Thread via GitHub
keith-turner commented on PR #4920: URL: https://github.com/apache/accumulo/pull/4920#issuecomment-2368873842 Ran `mvn verify -Psunny` successfully with these changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[PR] CASSANDRA-19938 Ensure that RFP queries potentially stale replicas even with only key columns in the row filter [cassandra]

2024-09-23 Thread via GitHub
maedhroz opened a new pull request, #3561: URL: https://github.com/apache/cassandra/pull/3561 patch by Caleb Rackliffe; reviewed by Stefan Miklosovic for CASSANDRA-19938 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-17581: AsyncKafkaConsumer can't unsubscribe invalid topics [kafka]

2024-09-23 Thread via GitHub
lianetm commented on code in PR #17244: URL: https://github.com/apache/kafka/pull/17244#discussion_r1771804938 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1471,6 +1487,7 @@ public void unsubscribe() { fetchBuf

Re: [PR] [FLINK-36292][Connectors/Common]: remove timeout to avoid timeout exception [flink]

2024-09-23 Thread via GitHub
becketqin commented on code in PR #25371: URL: https://github.com/apache/flink/pull/25371#discussion_r1771805652 ## flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java: ## @@ -71,7 +71,7 @@ public

[PR] HBASE-28867 Backport "HBASE-20653 Add missing observer hooks for region server group to MasterObserver" to branch-2" [hbase]

2024-09-23 Thread via GitHub
NihalJain opened a new pull request, #6283: URL: https://github.com/apache/hbase/pull/6283 Backport #6276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] KAFKA-17581: AsyncKafkaConsumer can't unsubscribe invalid topics [kafka]

2024-09-23 Thread via GitHub
lianetm commented on code in PR #17244: URL: https://github.com/apache/kafka/pull/17244#discussion_r1771804938 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1471,6 +1487,7 @@ public void unsubscribe() { fetchBuf

Re: [I] Support create table `PRIMARY KEY` column via Spark sql? [iceberg]

2024-09-23 Thread via GitHub
anuragmantri commented on issue #5069: URL: https://github.com/apache/iceberg/issues/5069#issuecomment-2368871238 There is a very old JIRA in Spark to add unenforced referential integrity constraints in Spark [SPARK-19842](https://issues.apache.org/jira/browse/SPARK-19842). This change is

Re: [I] Incorrect positions might be recorded after ORC-1711 [orc]

2024-09-23 Thread via GitHub
nickitat commented on issue #2037: URL: https://github.com/apache/orc/issues/2037#issuecomment-2368868027 cc @luffy-zh @ffacs @wgtmac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Tobago 2.x jdk and release [myfaces-tobago]

2024-09-23 Thread via GitHub
lofwyr14 merged PR #5482: URL: https://github.com/apache/myfaces-tobago/pull/5482 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@myface

Re: [PR] [fix] Key_Shared mode comsumption latency when low traffic [pulsar]

2024-09-23 Thread via GitHub
lhotari commented on code in PR #23340: URL: https://github.com/apache/pulsar/pull/23340#discussion_r1771802698 ## pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java: ## @@ -1231,14 +1231,14 @@ The max allowed delay for delayed delivery (in mi

Re: [PR] chore: Update python_tests.sh to generate an HTML report of code coverage [superset]

2024-09-23 Thread via GitHub
rusackas commented on PR #23665: URL: https://github.com/apache/superset/pull/23665#issuecomment-2368866603 @PasunuriSrinidhi are you negotiable on the randomizing part? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] [DOCS] Update mkdocs.yml with code copying feature for website [sedona]

2024-09-23 Thread via GitHub
jiayuasu merged PR #1599: URL: https://github.com/apache/sedona/pull/1599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@sedona.apache.

Re: [I] Implement fast min/max accumulator for binary / strings (now it uses the slower path) [datafusion]

2024-09-23 Thread via GitHub
alamb commented on issue #6906: URL: https://github.com/apache/datafusion/issues/6906#issuecomment-2368855897 > I think what @alamb means is that just simply using Vec to store the states will be at least not worse than StringArray + GroupsAccumulatorAdapter, and it is easy to start from.

Re: [PR] feat: Implement read support for String/Binary View types [arrow-nanoarrow]

2024-09-23 Thread via GitHub
bkietz commented on code in PR #596: URL: https://github.com/apache/arrow-nanoarrow/pull/596#discussion_r1771796038 ## src/nanoarrow/common/array_test.cc: ## @@ -895,6 +895,144 @@ TEST(ArrayTest, ArrayTestAppendToLargeStringArray) { ArrowArrayRelease(&array); } +TEST(Array

Re: [PR] Introduce `Scalar` type for ColumnarValue [datafusion]

2024-09-23 Thread via GitHub
findepi commented on code in PR #12536: URL: https://github.com/apache/datafusion/pull/12536#discussion_r1771799372 ## datafusion/expr-common/src/columnar_value.rs: ## @@ -89,7 +91,7 @@ pub enum ColumnarValue { /// Array of values Array(ArrayRef), /// A single val

Re: [I] packageDaffodilBin needs warning if ignored because packageDaffodilBinInfos is not defined [daffodil-sbt]

2024-09-23 Thread via GitHub
stevedlawrence commented on issue #56: URL: https://github.com/apache/daffodil-sbt/issues/56#issuecomment-2368855209 That's fair. I think we could make it so that if `root` is defined but `name` is `None` then we just default to using root as the name, maybe with QName prefixes stripped off

Re: [PR] Use local build artifacts for docker build [polaris]

2024-09-23 Thread via GitHub
dimas-b closed pull request #268: Use local build artifacts for docker build URL: https://github.com/apache/polaris/pull/268 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] HttpShardHandler: Fix extension hook transformResponse [solr]

2024-09-23 Thread via GitHub
fsparv commented on PR #2661: URL: https://github.com/apache/solr/pull/2661#issuecomment-2368855403 If users have implemented a custom handler (as is clearly implied via the doc on the method, and it's no-op default implementation) their code would need to be updated and rebuilt. Seems like

Re: [PR] [SPARK-49754] Support HPA for `SparkCluster` [spark-kubernetes-operator]

2024-09-23 Thread via GitHub
dongjoon-hyun commented on PR #135: URL: https://github.com/apache/spark-kubernetes-operator/pull/135#issuecomment-2368849694 Merged to main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Deprecate DAG.run method [airflow]

2024-09-23 Thread via GitHub
vincbeck commented on PR #42417: URL: https://github.com/apache/airflow/pull/42417#issuecomment-2368849287 That works too :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [SPARK-49754] Support HPA for `SparkCluster` [spark-kubernetes-operator]

2024-09-23 Thread via GitHub
dongjoon-hyun closed pull request #135: [SPARK-49754] Support HPA for `SparkCluster` URL: https://github.com/apache/spark-kubernetes-operator/pull/135 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Rate limiter [polaris]

2024-09-23 Thread via GitHub
andrew4699 commented on code in PR #278: URL: https://github.com/apache/polaris/pull/278#discussion_r1771796721 ## polaris-service/src/main/java/org/apache/polaris/service/ratelimiter/TokenBucketRateLimiter.java: ## @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] [SPARK-49754] Support HPA for `SparkCluster` [spark-kubernetes-operator]

2024-09-23 Thread via GitHub
viirya commented on code in PR #135: URL: https://github.com/apache/spark-kubernetes-operator/pull/135#discussion_r1771796527 ## examples/cluster-with-hpa.yaml: ## @@ -0,0 +1,45 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agre

Re: [PR] PHOENIX-7382 Eliminating index building and treating max lookback as … [phoenix]

2024-09-23 Thread via GitHub
kadirozde commented on code in PR #1964: URL: https://github.com/apache/phoenix/pull/1964#discussion_r1771795786 ## phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java: ## @@ -273,11 +278,31 @@ public GlobalIndexRegionScanner(final Regi

Re: [PR] Deprecate DAG.run method [airflow]

2024-09-23 Thread via GitHub
dstandish commented on PR #42417: URL: https://github.com/apache/airflow/pull/42417#issuecomment-2368847078 I think that the practice is, add to main first, then cherry pick. But I could be wrong. -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] [SPARK-49754] Support HPA for `SparkCluster` [spark-kubernetes-operator]

2024-09-23 Thread via GitHub
viirya commented on code in PR #135: URL: https://github.com/apache/spark-kubernetes-operator/pull/135#discussion_r1771795002 ## spark-submission-worker/src/main/java/org/apache/spark/k8s/operator/SparkClusterResourceSpec.java: ## @@ -271,4 +277,55 @@ private static StatefulSet

Re: [PR] [SPARK-49754] Support HPA for `SparkCluster` [spark-kubernetes-operator]

2024-09-23 Thread via GitHub
dongjoon-hyun commented on PR #135: URL: https://github.com/apache/spark-kubernetes-operator/pull/135#issuecomment-2368846387 Thank you, @viirya ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump org.apache.maven.plugins:maven-shade-plugin from 3.5.0 to 3.6.0 [camel-quarkus]

2024-09-23 Thread via GitHub
jamesnetherton merged PR #6527: URL: https://github.com/apache/camel-quarkus/pull/6527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

Re: [PR] Bump quarkiverse-cxf.version from 3.15.0 to 3.15.1 [camel-quarkus]

2024-09-23 Thread via GitHub
jamesnetherton merged PR #6526: URL: https://github.com/apache/camel-quarkus/pull/6526 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

Re: [PR] Bump org.amqphub.quarkus:quarkus-qpid-jms-bom from 2.7.0 to 2.7.1 [camel-quarkus]

2024-09-23 Thread via GitHub
jamesnetherton merged PR #6525: URL: https://github.com/apache/camel-quarkus/pull/6525 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

Re: [PR] Bump org.apache.maven.plugins:maven-gpg-plugin from 3.1.0 to 3.2.6 [camel-quarkus]

2024-09-23 Thread via GitHub
jamesnetherton merged PR #6524: URL: https://github.com/apache/camel-quarkus/pull/6524 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr.

Re: [I] What is the highest compression level in gzip? [arrow-rs]

2024-09-23 Thread via GitHub
ByteBaker commented on issue #6282: URL: https://github.com/apache/arrow-rs/issues/6282#issuecomment-2368839224 @JakkuSakura After discussing with `flate2` maintainers, I've confirmed that it's actually a documentation issue, but there's a slight caveat as well. `flate2` supports both `mini

[I] [Task]: Make the 'log' object private in the BaseTransformMeta (hop)

2024-09-23 Thread via GitHub
nadment opened a new issue, #4348: URL: https://github.com/apache/hop/issues/4348 ### What needs to happen? When I see the fix to issue #4347, we should make the 'log' object private in the BaseTransformMeta class because it's not always initialized) and to force use the getLog() or

Re: [PR] [SPARK-49754] Support HPA for `SparkCluster` [spark-kubernetes-operator]

2024-09-23 Thread via GitHub
dongjoon-hyun commented on PR #135: URL: https://github.com/apache/spark-kubernetes-operator/pull/135#issuecomment-2368837261 > Should we also update the documentation to mention this support? Not yet~ CPU-based HPA is just for illustrating the simplest integration. Eventually, we wi

Re: [PR] incubator-kie-issues#1483: Create a common Kie Flyway initializer for Kie Modules [incubator-kie-kogito-apps]

2024-09-23 Thread via GitHub
tiagobento commented on PR #2102: URL: https://github.com/apache/incubator-kie-kogito-apps/pull/2102#issuecomment-2368836858 Hi @pefernan, great addition, thanks for this. Can we change the directory of our `kie-flyway` scripts from `src/main/resources/db` to `src/main/resources/kie-flyway

Re: [PR] HBASE-28867 Backport "HBASE-20653 Add missing observer hooks for regi… [hbase]

2024-09-23 Thread via GitHub
NihalJain commented on PR #6276: URL: https://github.com/apache/hbase/pull/6276#issuecomment-2368836853 Failures are random. There were build for hadoop2 and hadoop3 where all tests passed with no code change. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Deprecate DAG.run method [airflow]

2024-09-23 Thread via GitHub
vincbeck commented on PR #42417: URL: https://github.com/apache/airflow/pull/42417#issuecomment-2368836112 Should it be done in `v2-test` branch? In main we want to remove it I guess? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] HBASE-28867 Backport "HBASE-20653 Add missing observer hooks for regi… [hbase]

2024-09-23 Thread via GitHub
NihalJain merged PR #6276: URL: https://github.com/apache/hbase/pull/6276 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apach

Re: [PR] changed weakFilter logic, so line charts will not disappear, while zoom [echarts]

2024-09-23 Thread via GitHub
Skuperday commented on PR #18202: URL: https://github.com/apache/echarts/pull/18202#issuecomment-2368835023 > > Thanks alot to mr. @nick-true-dev, i update the PR and add following changes to my code, so this work fine and i'm ready to merge! please @Ovilia review my changes and make lot of

Re: [PR] KAFKA-16959: ConfigCommand should allow to define both `entity-default` and `entity-name` [kafka]

2024-09-23 Thread via GitHub
m1a2st commented on PR #16381: URL: https://github.com/apache/kafka/pull/16381#issuecomment-2368834415 rebase on the trunk, and fix the conflict -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

<    2   3   4   5   6   7   8   9   10   11   >