becketqin commented on code in PR #25371:
URL: https://github.com/apache/flink/pull/25371#discussion_r1771805652


##########
flink-connectors/flink-connector-base/src/test/java/org/apache/flink/connector/base/source/reader/fetcher/SplitFetcherManagerTest.java:
##########
@@ -71,7 +71,7 @@ public void testCloseFetcherWithException() throws Exception {
                 .hasRootCauseMessage("Artificial exception on closing the 
split reader.");
     }
 
-    @Test(timeout = 30000)
+    @Test

Review Comment:
   We should also set the timeout to `Long.MAX_VALUE`. Otherwise the `close()` 
call may log a warning but the test may still pass.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to