[Lldb-commits] [lldb] r306633 - Change the ABI class to have a weak pointer to its Process;

Author: jmolenda Date: Wed Jun 28 19:57:03 2017 New Revision: 306633 URL: http://llvm.org/viewvc/llvm-project?rev=306633=rev Log: Change the ABI class to have a weak pointer to its Process; some methods in the ABI need a Process to do their work. Instead of passing it in as a one-off argument to

[Lldb-commits] [lldb] r305547 - Change the code I added to LocateDSYMInVincinityOfExecutable to use

Author: jmolenda Date: Thu Jun 15 23:19:36 2017 New Revision: 305547 URL: http://llvm.org/viewvc/llvm-project?rev=305547=rev Log: Change the code I added to LocateDSYMInVincinityOfExecutable to use the FileSpec methods for adding/removing file path components instead of using std::strings;

[Lldb-commits] [lldb] r305441 - Change how LocateDSYMInVincinityOfExecutable strips off path

Author: jmolenda Date: Wed Jun 14 20:42:48 2017 New Revision: 305441 URL: http://llvm.org/viewvc/llvm-project?rev=305441=rev Log: Change how LocateDSYMInVincinityOfExecutable strips off path components to not depend on "." characters in the fileanme (e.g. "Foundation.framework") but instead to

[Lldb-commits] [lldb] r304520 - Move the code to find a binary in a bundle in the target.exec-search-paths

Author: jmolenda Date: Fri Jun 2 00:17:19 2017 New Revision: 304520 URL: http://llvm.org/viewvc/llvm-project?rev=304520=rev Log: Move the code to find a binary in a bundle in the target.exec-search-paths from PlatformRemoteDarwinDevice into PlatformDarwin, and have both

[Lldb-commits] [lldb] r303465 - Don't override the SDKs and force the use of /System/Library/Frameworks to

Author: jmolenda Date: Fri May 19 18:00:42 2017 New Revision: 303465 URL: http://llvm.org/viewvc/llvm-project?rev=303465=rev Log: Don't override the SDKs and force the use of /System/Library/Frameworks to find the python headers when buiding crashinfo.c Modified:

[Lldb-commits] [lldb] r301034 - Correct the names of some target conditional defines in debugserver.

Author: jmolenda Date: Fri Apr 21 15:19:28 2017 New Revision: 301034 URL: http://llvm.org/viewvc/llvm-project?rev=301034=rev Log: Correct the names of some target conditional defines in debugserver. Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp Modified:

[Lldb-commits] [lldb] r300810 - Add extra logging for when lldb is looking for kernels and kexts.

Author: jmolenda Date: Wed Apr 19 21:02:25 2017 New Revision: 300810 URL: http://llvm.org/viewvc/llvm-project?rev=300810=rev Log: Add extra logging for when lldb is looking for kernels and kexts. Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformDarwinKernel.cpp Modified:

[Lldb-commits] [lldb] r300162 - Don't use uuid_clear(), non-darwin platforms include

Author: jmolenda Date: Wed Apr 12 21:12:32 2017 New Revision: 300162 URL: http://llvm.org/viewvc/llvm-project?rev=300162=rev Log: Don't use uuid_clear(), non-darwin platforms include Utility/UuidCompatibility.h which gets you a definiton of uuid_t but none of the functions that operate on it.

Re: [Lldb-commits] [lldb] r297585 - Make file / directory completion work properly on Windows.

I noticed that the llvm.org sources crash when you do filename completion with a file in the current working directory: % build/Debug/lldb (lldb) file aaa[TAB]Assertion failed: (!SearchDir.empty()), function DiskFilesOrDirectories, file

[Lldb-commits] [lldb] r299807 - Mark this test as XFAIL on all platforms, it's happening everywhere.

Author: jmolenda Date: Fri Apr 7 18:20:22 2017 New Revision: 299807 URL: http://llvm.org/viewvc/llvm-project?rev=299807=rev Log: Mark this test as XFAIL on all platforms, it's happening everywhere. llvm.org/pr32553 and are tracking this. Modified:

[Lldb-commits] [lldb] r299613 - Update unittests/Host/SocketTest.cpp to also use the new

Author: jmolenda Date: Wed Apr 5 22:16:44 2017 New Revision: 299613 URL: http://llvm.org/viewvc/llvm-project?rev=299613=rev Log: Update unittests/Host/SocketTest.cpp to also use the new one-socket API. Modified: lldb/trunk/unittests/Host/SocketTest.cpp Modified:

[Lldb-commits] [lldb] r299612 - Some old mach-o core files have an LC_IDENT load command

Author: jmolenda Date: Wed Apr 5 20:50:11 2017 New Revision: 299612 URL: http://llvm.org/viewvc/llvm-project?rev=299612=rev Log: Some old mach-o core files have an LC_IDENT load command and there's a string in there that can be helpful in locating the kernel binary. Use it. Modified:

[Lldb-commits] [lldb] r299608 - Change how UDP sockets are set up -- use the same one socket for

Author: jmolenda Date: Wed Apr 5 20:21:44 2017 New Revision: 299608 URL: http://llvm.org/viewvc/llvm-project?rev=299608=rev Log: Change how UDP sockets are set up -- use the same one socket for both sending and receiving information, instead of using one socket to send and another to receive.

[Lldb-commits] [lldb] r299408 - Skip three test cases that are asserting on macosx as of r299199. A quick

Author: jmolenda Date: Mon Apr 3 20:09:20 2017 New Revision: 299408 URL: http://llvm.org/viewvc/llvm-project?rev=299408=rev Log: Skip three test cases that are asserting on macosx as of r299199. A quick look showed that the target's arch has no core / byte order and so when AuxVector::AuxVector

[Lldb-commits] [lldb] r299394 - The LIBLLDB_LOG_TEMPORARY channel got lost at some point where

Author: jmolenda Date: Mon Apr 3 17:23:01 2017 New Revision: 299394 URL: http://llvm.org/viewvc/llvm-project?rev=299394=rev Log: The LIBLLDB_LOG_TEMPORARY channel got lost at some point where Logging.cpp was being changed in the past. Re-add it. Modified:

[Lldb-commits] [lldb] r299345 - Back out temporary masking of EXC_SYSCALL mach exceptions.

Author: jmolenda Date: Sun Apr 2 19:59:47 2017 New Revision: 299345 URL: http://llvm.org/viewvc/llvm-project?rev=299345=rev Log: Back out temporary masking of EXC_SYSCALL mach exceptions. Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachException.cpp Modified:

[Lldb-commits] [lldb] r299040 - Mask out EXC_SYSCALL exceptions as well.

Author: jmolenda Date: Wed Mar 29 19:23:46 2017 New Revision: 299040 URL: http://llvm.org/viewvc/llvm-project?rev=299040=rev Log: Mask out EXC_SYSCALL exceptions as well. Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachException.cpp Modified:

[Lldb-commits] [lldb] r298694 - The expression text in AppleObjCRuntimeV1::CreateObjectChecker

Author: jmolenda Date: Fri Mar 24 03:01:16 2017 New Revision: 298694 URL: http://llvm.org/viewvc/llvm-project?rev=298694=rev Log: The expression text in AppleObjCRuntimeV1::CreateObjectChecker was formatted into a string inside an assert() expression. Which is elided when lldb is built with

[Lldb-commits] [lldb] r298338 - Revert r298334 until Zachary has a chance to fix the buildbot failure

Author: jmolenda Date: Mon Mar 20 23:45:10 2017 New Revision: 298338 URL: http://llvm.org/viewvc/llvm-project?rev=298338=rev Log: Revert r298334 until Zachary has a chance to fix the buildbot failure on macosx. Modified: lldb/trunk/include/lldb/Host/FileSystem.h

[Lldb-commits] [lldb] r298337 - Fix two places where an arm instruction emulation method

Author: jmolenda Date: Mon Mar 20 23:34:17 2017 New Revision: 298337 URL: http://llvm.org/viewvc/llvm-project?rev=298337=rev Log: Fix two places where an arm instruction emulation method can dereference misaligned memory. , Modified:

[Lldb-commits] [lldb] r298333 - Initialize m_allow_cxx, m_allow_objc. These ivars in the base class are not

Author: jmolenda Date: Mon Mar 20 21:59:15 2017 New Revision: 298333 URL: http://llvm.org/viewvc/llvm-project?rev=298333=rev Log: Initialize m_allow_cxx, m_allow_objc. These ivars in the base class are not initialized in the ctor and they're only initialized to 'true' in

[Lldb-commits] [lldb] r297701 - update.

Author: jmolenda Date: Mon Mar 13 22:28:27 2017 New Revision: 297701 URL: http://llvm.org/viewvc/llvm-project?rev=297701=rev Log: update. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r297496 - Simplify & correct the patch I wrote in r297441, after thinking

Author: jmolenda Date: Fri Mar 10 13:31:54 2017 New Revision: 297496 URL: http://llvm.org/viewvc/llvm-project?rev=297496=rev Log: Simplify & correct the patch I wrote in r297441, after thinking about this more I realized I could make the change isolated to whether we decide an empty accelerator

[Lldb-commits] [lldb] r297441 - Add a distinction in an apple accelerator table between IsValid and

Author: jmolenda Date: Fri Mar 10 00:38:19 2017 New Revision: 297441 URL: http://llvm.org/viewvc/llvm-project?rev=297441=rev Log: Add a distinction in an apple accelerator table between IsValid and HasContent. If we have a valid accelerator table which has no content, we want to depend on that

[Lldb-commits] [lldb] r297440 - Mark this as skipped for now. There is a race condition with

Author: jmolenda Date: Thu Mar 9 23:33:27 2017 New Revision: 297440 URL: http://llvm.org/viewvc/llvm-project?rev=297440=rev Log: Mark this as skipped for now. There is a race condition with SectionLoadList exposed by this test. Greg tried to chase it down & got pretty far but the isn't correct

[Lldb-commits] [lldb] r297259 - Back to xfailing this. For some reason on our buildbots

Author: jmolenda Date: Wed Mar 8 00:45:34 2017 New Revision: 297259 URL: http://llvm.org/viewvc/llvm-project?rev=297259=rev Log: Back to xfailing this. For some reason on our buildbots it fails, but it works on the local workstations. I'll need to figure out what the difference is between

[Lldb-commits] [lldb] r297258 - TestQueues should be passing again, remove the expected fail.

Author: jmolenda Date: Tue Mar 7 23:51:00 2017 New Revision: 297258 URL: http://llvm.org/viewvc/llvm-project?rev=297258=rev Log: TestQueues should be passing again, remove the expected fail. Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/queues/TestQueues.py Modified:

[Lldb-commits] [lldb] r297104 - cleanup.

Author: jmolenda Date: Mon Mar 6 18:00:35 2017 New Revision: 297104 URL: http://llvm.org/viewvc/llvm-project?rev=297104=rev Log: cleanup. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r296733 - x86AssemblyInspectionEngine::AugmentUnwindPlanFromCallSite could access

Author: jmolenda Date: Wed Mar 1 23:08:10 2017 New Revision: 296733 URL: http://llvm.org/viewvc/llvm-project?rev=296733=rev Log: x86AssemblyInspectionEngine::AugmentUnwindPlanFromCallSite could access the byte past the end of the buffer it had been given. ASAN catch. Modified:

[Lldb-commits] [lldb] r296548 - Greg Clayton is no longer working at Apple, he will continue to

Author: jmolenda Date: Tue Feb 28 18:00:45 2017 New Revision: 296548 URL: http://llvm.org/viewvc/llvm-project?rev=296548=rev Log: Greg Clayton is no longer working at Apple, he will continue to review patches etc from his clayborg email address. Modified: lldb/trunk/CODE_OWNERS.txt

Re: [Lldb-commits] [lldb] r296495 - Fix incorrect logic in StackFrame::Disassemble.

It makes me uncomfortable to have these whole-project-ranging change sets going into the source, one example being const char * -> StringRef) for such small benefit. Yes there were a few methods where we were doing string parsing and tokenizing which became much smaller and easier to

Re: [Lldb-commits] [lldb] r296495 - Fix incorrect logic in StackFrame::Disassemble.

Writing SB API tests for the disassembler is easy, as Jim notes there is an SBFrame::Disassemble() method that maps directly on to this call. I've written unit tests that create a disassembler -- I do it for the unwind tests. It's easy when you have an array of bytes to feed directly into the

[Lldb-commits] [lldb] r296531 - Add additional areas I'm responsible for in the lldb codebase.

Author: jmolenda Date: Tue Feb 28 16:31:18 2017 New Revision: 296531 URL: http://llvm.org/viewvc/llvm-project?rev=296531=rev Log: Add additional areas I'm responsible for in the lldb codebase. Modified: lldb/trunk/CODE_OWNERS.txt Modified: lldb/trunk/CODE_OWNERS.txt URL:

[Lldb-commits] [lldb] r296412 - Ah, this was an early exit to leave built products around, it wasn't meant to

Author: jmolenda Date: Mon Feb 27 17:31:29 2017 New Revision: 296412 URL: http://llvm.org/viewvc/llvm-project?rev=296412=rev Log: Ah, this was an early exit to leave built products around, it wasn't meant to be checked in. Modified:

[Lldb-commits] [lldb] r296243 - Three LoadLibCxxFormatters formatters were given a regex string to

Author: jmolenda Date: Fri Feb 24 23:43:51 2017 New Revision: 296243 URL: http://llvm.org/viewvc/llvm-project?rev=296243=rev Log: Three LoadLibCxxFormatters formatters were given a regex string to match but the 'is_regex' argument was not passed as true. Not sure this is causing a bug, but

[Lldb-commits] [lldb] r296238 - DataBufferMemoryMap.cpp out, DataBufferLLVM.cpp in. Unbreak the build.

Author: jmolenda Date: Fri Feb 24 22:06:09 2017 New Revision: 296238 URL: http://llvm.org/viewvc/llvm-project?rev=296238=rev Log: DataBufferMemoryMap.cpp out, DataBufferLLVM.cpp in. Unbreak the build. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified:

[Lldb-commits] [lldb] r296084 - Fix a race condition in FuncUnwinders where the mutex was being

Author: jmolenda Date: Thu Feb 23 21:35:46 2017 New Revision: 296084 URL: http://llvm.org/viewvc/llvm-project?rev=296084=rev Log: Fix a race condition in FuncUnwinders where the mutex was being acquired only after checking if the ivar shared pointer was already filled in. But when I assign an

[Lldb-commits] [lldb] r295804 - Mark TestDarwinLogBasic.py as an xfail because the logging is

Author: jmolenda Date: Tue Feb 21 20:10:00 2017 New Revision: 295804 URL: http://llvm.org/viewvc/llvm-project?rev=295804=rev Log: Mark TestDarwinLogBasic.py as an xfail because the logging is not being picked up; filed to track the work to investigate this. Modified:

[Lldb-commits] [lldb] r295694 - Fix spelling mistake.

Author: jmolenda Date: Mon Feb 20 23:09:26 2017 New Revision: 295694 URL: http://llvm.org/viewvc/llvm-project?rev=295694=rev Log: Fix spelling mistake. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp Modified:

[Lldb-commits] [lldb] r295530 - Update the location of ModuleCacheTest.cpp from

Author: jmolenda Date: Fri Feb 17 19:51:11 2017 New Revision: 295530 URL: http://llvm.org/viewvc/llvm-project?rev=295530=rev Log: Update the location of ModuleCacheTest.cpp from unittest/Utility to unittest/Target so the unit tests can be run from xcode again. The diff is enormous - I think

[Lldb-commits] [lldb] r295271 - Fix a bug introduced in r235737 where code with important side

Author: jmolenda Date: Wed Feb 15 20:08:33 2017 New Revision: 295271 URL: http://llvm.org/viewvc/llvm-project?rev=295271=rev Log: Fix a bug introduced in r235737 where code with important side effects was passed as an expression to assert() calls. If lldb is built without asserts, the expression

[Lldb-commits] [lldb] r295025 - Before returning a pc value for a stack frame,

Author: jmolenda Date: Mon Feb 13 22:55:03 2017 New Revision: 295025 URL: http://llvm.org/viewvc/llvm-project?rev=295025=rev Log: Before returning a pc value for a stack frame, run it through the ABI's FixCodeAddress method. Modified:

[Lldb-commits] [lldb] r293858 - Add logging to SBThread::GetInfoItemByPathAsString to

Author: jmolenda Date: Wed Feb 1 21:02:51 2017 New Revision: 293858 URL: http://llvm.org/viewvc/llvm-project?rev=293858=rev Log: Add logging to SBThread::GetInfoItemByPathAsString to print the path being requested. Change the GetInfoItemByPathAsString docuemtnation in the .i file to use

Re: [Lldb-commits] [PATCH] D29427: Move some classes from Core -> Utility

You need some break;s. -const char *lldb_private::GetVoteAsCString(Vote vote) { - switch (vote) { - case eVoteNo: -return "no"; - case eVoteNoOpinion: -return "no opinion"; - case eVoteYes: -return "yes"; - } - return "invalid"; -} +template <> struct format_provider { +

[Lldb-commits] [lldb] r293742 - When I added the use of the new compression framework (present in

Author: jmolenda Date: Tue Jan 31 22:23:15 2017 New Revision: 293742 URL: http://llvm.org/viewvc/llvm-project?rev=293742=rev Log: When I added the use of the new compression framework (present in Mac OS X 10.11, El Capitan, released c. Oct 2015) I conditionalized the use of the framework on "if

[Lldb-commits] [lldb] r293366 - One of the changes Jim made in r286288 (cleaning up the stop print

Author: jmolenda Date: Fri Jan 27 20:54:10 2017 New Revision: 293366 URL: http://llvm.org/viewvc/llvm-project?rev=293366=rev Log: One of the changes Jim made in r286288 (cleaning up the stop print header line, backtrace output) was to remove the current pc value from frames where we have source

[Lldb-commits] [lldb] r293140 - Add Foundation to the debugserver-mini dependencies;

Author: jmolenda Date: Wed Jan 25 20:27:35 2017 New Revision: 293140 URL: http://llvm.org/viewvc/llvm-project?rev=293140=rev Log: Add Foundation to the debugserver-mini dependencies; debugserver-mini can use Foundation. Modified:

[Lldb-commits] [lldb] r293135 - Instead of weak-linking against LoggingSupport framework (which

Author: jmolenda Date: Wed Jan 25 20:13:43 2017 New Revision: 293135 URL: http://llvm.org/viewvc/llvm-project?rev=293135=rev Log: Instead of weak-linking against LoggingSupport framework (which requires that this private framework be available - and it is not available earlier than macOS 10.12 -

[Lldb-commits] [lldb] r293002 - Jim unintentionally had the gdb-format specifiers falling through

Author: jmolenda Date: Tue Jan 24 19:41:48 2017 New Revision: 293002 URL: http://llvm.org/viewvc/llvm-project?rev=293002=rev Log: Jim unintentionally had the gdb-format specifiers falling through after r276132 so that 'x/4b' would print out a series of 4 8-byte quantities. Fix that, add a test

[Lldb-commits] [lldb] r292890 - Fix the last commit; compression was being enabled on mac native

Author: jmolenda Date: Tue Jan 24 00:09:06 2017 New Revision: 292890 URL: http://llvm.org/viewvc/llvm-project?rev=292890=rev Log: Fix the last commit; compression was being enabled on mac native which led to ERROR: test_auxv_chunked_reads_work_debugserver

[Lldb-commits] [lldb] r292884 - Prefer lzfse if it is an available compression method (this was

Author: jmolenda Date: Mon Jan 23 23:06:14 2017 New Revision: 292884 URL: http://llvm.org/viewvc/llvm-project?rev=292884=rev Log: Prefer lzfse if it is an available compression method (this was defaulting to zlib previously). Modified:

[Lldb-commits] [lldb] r292882 - Enable compression capability in debugserver for all of ios/watchos/tvos

Author: jmolenda Date: Mon Jan 23 22:43:40 2017 New Revision: 292882 URL: http://llvm.org/viewvc/llvm-project?rev=292882=rev Log: Enable compression capability in debugserver for all of ios/watchos/tvos environments. Modified: lldb/trunk/tools/debugserver/source/RNBRemote.cpp Modified:

[Lldb-commits] [lldb] r292880 - weak-link debugserver against the LoggingSupport framework;

Author: jmolenda Date: Mon Jan 23 22:16:03 2017 New Revision: 292880 URL: http://llvm.org/viewvc/llvm-project?rev=292880=rev Log: weak-link debugserver against the LoggingSupport framework; systems without this framework will not get a link error. Modified:

[Lldb-commits] [lldb] r292696 - Add a catch-all line for detecting dyld in the inferior process

Author: jmolenda Date: Fri Jan 20 19:17:36 2017 New Revision: 292696 URL: http://llvm.org/viewvc/llvm-project?rev=292696=rev Log: Add a catch-all line for detecting dyld in the inferior process shlibs so we don't miss dyld. Modified:

[Lldb-commits] [lldb] r292454 - Fix a problem with the new dyld interface code -- when a new process

Author: jmolenda Date: Wed Jan 18 18:20:29 2017 New Revision: 292454 URL: http://llvm.org/viewvc/llvm-project?rev=292454=rev Log: Fix a problem with the new dyld interface code -- when a new process starts up, we need to clear the target's image list and only add the binaries into the target that

[Lldb-commits] [lldb] r290917 - Remove SymbolFilePDBTests.cpp from the list of tests to include in the

Author: jmolenda Date: Tue Jan 3 18:01:25 2017 New Revision: 290917 URL: http://llvm.org/viewvc/llvm-project?rev=290917=rev Log: Remove SymbolFilePDBTests.cpp from the list of tests to include in the lldb-gtest binary that xcode builds for -scheme lldb-gtest; these tests won't run on macosx

[Lldb-commits] [lldb] r290163 - Change the timeout in CallBoardSystemServiceOpenApplication to

Author: jmolenda Date: Mon Dec 19 22:54:04 2016 New Revision: 290163 URL: http://llvm.org/viewvc/llvm-project?rev=290163=rev Log: Change the timeout in CallBoardSystemServiceOpenApplication to 30 seconds to match the old springboard timeout; the launcher should time out before that and we will

[Lldb-commits] [lldb] r289913 - Fix a bug when using a StructuredData darwin-log plugin

Author: jmolenda Date: Thu Dec 15 20:48:39 2016 New Revision: 289913 URL: http://llvm.org/viewvc/llvm-project?rev=289913=rev Log: Fix a bug when using a StructuredData darwin-log plugin where we would insert a breakpoint into a system library but never remove it, so the second time we ran the

[Lldb-commits] [lldb] r289520 - Small tweaks to the markup in StructuredDataPlugins.

Author: jmolenda Date: Mon Dec 12 23:59:24 2016 New Revision: 289520 URL: http://llvm.org/viewvc/llvm-project?rev=289520=rev Log: Small tweaks to the markup in StructuredDataPlugins. Modified: lldb/trunk/docs/structured_data/StructuredDataPlugins.md Modified:

[Lldb-commits] [lldb] r289518 - Touch-up the markup of the DarwinLog.md documentation.

Author: jmolenda Date: Mon Dec 12 23:54:17 2016 New Revision: 289518 URL: http://llvm.org/viewvc/llvm-project?rev=289518=rev Log: Touch-up the markup of the DarwinLog.md documentation. Modified: lldb/trunk/docs/structured_data/DarwinLog.md Modified:

[Lldb-commits] [lldb] r289155 - Clean up the new TestInterruptThreadNames test a bit.

Author: jmolenda Date: Thu Dec 8 17:34:56 2016 New Revision: 289155 URL: http://llvm.org/viewvc/llvm-project?rev=289155=rev Log: Clean up the new TestInterruptThreadNames test a bit. Modified: lldb/trunk/packages/Python/lldbsuite/test/macosx/thread-names/TestInterruptThreadNames.py

[Lldb-commits] [lldb] r289026 - When we interrupt a process, it was possible or the thread names

Author: jmolenda Date: Thu Dec 8 00:27:29 2016 New Revision: 289026 URL: http://llvm.org/viewvc/llvm-project?rev=289026=rev Log: When we interrupt a process, it was possible or the thread names to not be set by Process::WillPublicStop() so the driver won't get access to them. The fix is

[Lldb-commits] [lldb] r289023 - Increase timeout for Frontboard app launch request from 9 to 20 seconds

Author: jmolenda Date: Wed Dec 7 23:12:45 2016 New Revision: 289023 URL: http://llvm.org/viewvc/llvm-project?rev=289023=rev Log: Increase timeout for Frontboard app launch request from 9 to 20 seconds to match other timeouts. Modified:

[Lldb-commits] [lldb] r289016 - Set the address size based on the target's arch instead

Author: jmolenda Date: Wed Dec 7 20:02:45 2016 New Revision: 289016 URL: http://llvm.org/viewvc/llvm-project?rev=289016=rev Log: Set the address size based on the target's arch instead of using the address of the all_image_infos struct. Modified:

[Lldb-commits] [lldb] r288284 - Add another address to look for the kernel load addr in

Author: jmolenda Date: Wed Nov 30 17:00:52 2016 New Revision: 288284 URL: http://llvm.org/viewvc/llvm-project?rev=288284=rev Log: Add another address to look for the kernel load addr in DynamicLoaderDarwinKernel::SearchForKernelWithDebugHints on 32-bit devices. Modified:

[Lldb-commits] [lldb] r286926 - Change the kernel searching code to not go through the

Author: jmolenda Date: Mon Nov 14 19:41:27 2016 New Revision: 286926 URL: http://llvm.org/viewvc/llvm-project?rev=286926=rev Log: Change the kernel searching code to not go through the memory cache subsystem so we're reading only the 4 bytes needed to check for the magic word at the start of a

[Lldb-commits] [lldb] r286335 - When deciding whether to use the source remapping dictionary from

Author: jmolenda Date: Tue Nov 8 21:42:12 2016 New Revision: 286335 URL: http://llvm.org/viewvc/llvm-project?rev=286335=rev Log: When deciding whether to use the source remapping dictionary from a dSYM per-uuid plist, only use it when the DBGVersion key has a value of 2 or greater.

[Lldb-commits] [PATCH] D26338: [lldb] Don't build unit tests for unsupported targets

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Thanks Vedant, we always build armv7/arm64/x86 llvm targets with the xcode style lldb/llvm builds so I hadn't seen this problem. Please commit. https://reviews.llvm.org/D26338

[Lldb-commits] [PATCH] D26295: Change UnwindAssemblyInstEmulation to remove a register location instead of marking it as IsSame()

jasonmolenda added a comment. Ah, interesting point, I didn't think of that. However, this touches on another thing I've been thinking about as I look at the assembly inspection unwind plan generators. In the x86 unwind inspector, I've hardcoded the SysV-x86_64 ABI and the unwind plan

[Lldb-commits] [PATCH] D26295: Change UnwindAssemblyInstEmulation to remove a register location instead of marking it as IsSame()

jasonmolenda created this revision. jasonmolenda added reviewers: labath, tberghammer. jasonmolenda added a subscriber: lldb-commits. jasonmolenda set the repository for this revision to rL LLVM. This is a minor change and maybe more of a personal preference, but UnwindAssemblyInstEmulation

[Lldb-commits] GDBRemoteCommunicationClientTest.TestPacketSpeedJSON unit test hanging for anyone else?

Is anyone else seeing a hang in GDBRemoteCommunicationClientTest.TestPacketSpeedJSON when running the unit tests? It was a new test added in r285602, it always hangs for me on my system, a macOS 10.12.something machine. Attaching to it with lldb, it's waiting to get a packet down in thread

[Lldb-commits] [PATCH] D26260: Fix typo which broke debugging on older OSX systems after r285172.

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yes it was, thanks for catching that! Please commit. Repository: rL LLVM https://reviews.llvm.org/D26260 ___ lldb-commits

Re: [Lldb-commits] [PATCH] D25864: Fix arm64 floating point register spill recording in UnwindPlan analysis

> On Oct 31, 2016, at 9:35 AM, Tamas Berghammer wrote: > > tberghammer accepted this revision. > tberghammer added a comment. > This revision is now accepted and ready to land. > > The patch generally looks good to me. I added a few high level thought about > register

[Lldb-commits] [PATCH] D25864: Fix arm64 floating point register spill recording in UnwindPlan analysis

jasonmolenda closed this revision. jasonmolenda added a comment. Committed in r285662. Repository: rL LLVM https://reviews.llvm.org/D25864 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r285662 - Fix a bug where the EmulateInstructionARM64 handling of STP/LDP instructions

Author: jmolenda Date: Mon Oct 31 20:26:54 2016 New Revision: 285662 URL: http://llvm.org/viewvc/llvm-project?rev=285662=rev Log: Fix a bug where the EmulateInstructionARM64 handling of STP/LDP instructions for floating point registers was not recording them correctly. I needed to change the

[Lldb-commits] [lldb] r285369 - Check that we got back an object from MakeFunctionCaller

Author: jmolenda Date: Thu Oct 27 18:52:46 2016 New Revision: 285369 URL: http://llvm.org/viewvc/llvm-project?rev=285369=rev Log: Check that we got back an object from MakeFunctionCaller before we call through it. Modified:

[Lldb-commits] [PATCH] D25864: Fix arm64 floating point register spill recording in UnwindPlan analysis

jasonmolenda updated this revision to Diff 75977. jasonmolenda added a comment. I believe this rewrite of the original patch addresses Tamas' feedback (thanks Tamas!) I dropped a lot of the changes in the original; I switch EmulateInstructionARM64 from using DWARF register numbering to use

[Lldb-commits] [lldb] r285172 - Enable the use of the new dyld SPI on the current

Author: jmolenda Date: Tue Oct 25 23:48:41 2016 New Revision: 285172 URL: http://llvm.org/viewvc/llvm-project?rev=285172=rev Log: Enable the use of the new dyld SPI on the current generation macosx/ios/tvos/watchos. Modified:

[Lldb-commits] [PATCH] D25864: Fix arm64 floating point register spill recording in UnwindPlan analysis

jasonmolenda added a comment. Hi Tamas, sorry for not replying earlier, something urgent came up that I needed to look at. Thanks for the review. I agree with using your existing arm64 register enums in lldb-arm64-register-enums.h. I'd like to remove the enums in RegisterInfos_arm64.h

[Lldb-commits] [lldb] r284900 - Add some additional logging to

Author: jmolenda Date: Fri Oct 21 18:45:07 2016 New Revision: 284900 URL: http://llvm.org/viewvc/llvm-project?rev=284900=rev Log: Add some additional logging to DynamicLoaderDarwinKernel::CheckForKernelImageAtAddress to debug corefiles that may not be correctly formed. Modified:

[Lldb-commits] [lldb] r284799 - Guard GetEscapedHostname against a nullptr hostname.

Author: jmolenda Date: Thu Oct 20 21:32:08 2016 New Revision: 284799 URL: http://llvm.org/viewvc/llvm-project?rev=284799=rev Log: Guard GetEscapedHostname against a nullptr hostname. This can happen if you debug an iOS corefile on a mac, where PlatformPOSIX::GetHostname ends up not providing a

[Lldb-commits] [lldb] r284666 - Add lldb register definitions for w0-w28, s0-s31, and d0-d31 to

Author: jmolenda Date: Wed Oct 19 18:38:38 2016 New Revision: 284666 URL: http://llvm.org/viewvc/llvm-project?rev=284666=rev Log: Add lldb register definitions for w0-w28, s0-s31, and d0-d31 to RegisterInfos_arm64.h. These register definitions include the offset into the register context, which

Re: [Lldb-commits] Instruction emulation of arm64 'stp d8, d9, [sp, #-0x70]!' style instruction

But if I attach to an arm64 core file, where lldb is using it's own register definitions, then lldb has no idea what s0 is. My concern about defining these subset registers in RegisterInfos_arm64.h is that the offsets are in a target-endian register context buffer. My example below was

Re: [Lldb-commits] Instruction emulation of arm64 'stp d8, d9, [sp, #-0x70]!' style instruction

Yeah, it's incorrectly grabbing the stack pointer reg number (31) from the Rn bits and using that as the register # being saved, instead of the Rt and Rt2 register numbers, and saying that v31 is being pushed twice. It's an easy bug in EmulateInstructionARM64::EmulateLDPSTP but fixing that

Re: [Lldb-commits] Instruction emulation of arm64 'stp d8, d9, [sp, #-0x70]!' style instruction

Hi Tamas, sorry for that last email being a mess, I was doing something else while writing it and only saw how unclear it was after I sent it. You understood everything I was trying to say. I looked at the AAPCS64 again. It says v8-v15 are callee saved, but says, "Additionally, only the

[Lldb-commits] [lldb] r283969 - Add an arm64 unit test where the function saves x20 in the

Author: jmolenda Date: Tue Oct 11 22:53:01 2016 New Revision: 283969 URL: http://llvm.org/viewvc/llvm-project?rev=283969=rev Log: Add an arm64 unit test where the function saves x20 in the prologue, then loads & stores x20 on the stack from a different location in the middle of the function, and

[Lldb-commits] Instruction emulation of arm64 'stp d8, d9, [sp, #-0x70]!' style instruction

Hi Tamas, I'm writing some unit tests for the unwind source generators - x86 last week, arm64 this week, and I noticed with this prologue: JavaScriptCore`JSC::B3::reduceDoubleToFloat: 0x192b45c0c <+0>: 0x6db923e9 stpd9, d8, [sp, #-0x70]! 0x192b45c10 <+4>: 0xa9016ffc stpx28,

[Lldb-commits] [lldb] r283849 - Add a second, more complicated, arm64 example program to

Author: jmolenda Date: Mon Oct 10 22:44:48 2016 New Revision: 283849 URL: http://llvm.org/viewvc/llvm-project?rev=283849=rev Log: Add a second, more complicated, arm64 example program to the arm64 assembly unwind tests. Modified:

[Lldb-commits] [lldb] r283847 - Add a first unit test for the arm64 instruction profiled unwind

Author: jmolenda Date: Mon Oct 10 21:24:00 2016 New Revision: 283847 URL: http://llvm.org/viewvc/llvm-project?rev=283847=rev Log: Add a first unit test for the arm64 instruction profiled unwind plan generator. Fix a small bug in EmulateInstructionARM64::GetFramePointerRegister which was

[Lldb-commits] [lldb] r283404 - Add i386/x86_64 tests of the eh_frame augmentation code in the x86

Author: jmolenda Date: Wed Oct 5 17:37:01 2016 New Revision: 283404 URL: http://llvm.org/viewvc/llvm-project?rev=283404=rev Log: Add i386/x86_64 tests of the eh_frame augmentation code in the x86 insturction profiling. Add a test that verifies that we reject a 32-bit only instruction in 64-bit

[Lldb-commits] [lldb] r283295 - Change Platform::GetRemoteSharedModule so if it's given a ModuleSpec

Author: jmolenda Date: Tue Oct 4 21:29:13 2016 New Revision: 283295 URL: http://llvm.org/viewvc/llvm-project?rev=283295=rev Log: Change Platform::GetRemoteSharedModule so if it's given a ModuleSpec which specifies a file path and UUID but not an architecture, open the file at that path and try

[Lldb-commits] [lldb] r283186 - Finish adding the individual instruction tests to the x86 unwinder

Author: jmolenda Date: Tue Oct 4 00:10:06 2016 New Revision: 283186 URL: http://llvm.org/viewvc/llvm-project?rev=283186=rev Log: Finish adding the individual instruction tests to the x86 unwinder unittests. If I have time, I'd like to see if I can write some tests of the eh_frame augmentation

[Lldb-commits] [lldb] r283010 - Add unit tests for specific instruction patterns that the x86

Author: jmolenda Date: Fri Sep 30 23:50:25 2016 New Revision: 283010 URL: http://llvm.org/viewvc/llvm-project?rev=283010=rev Log: Add unit tests for specific instruction patterns that the x86 assembly inspection class is designed to detect. This is only about half of the instructions that it

[Lldb-commits] [lldb] r282991 - Add support for some extended push instructions in i386/x86_64 like

Author: jmolenda Date: Fri Sep 30 19:19:26 2016 New Revision: 282991 URL: http://llvm.org/viewvc/llvm-project?rev=282991=rev Log: Add support for some extended push instructions in i386/x86_64 like 'push 0x20(%esp)' which clang can generate when emitting -fomit-frame-pointer code for 32-bit. Add

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

; as a result. > > Session logs for test failures/errors/unexpected successes will go into > directory '2016-09-29-15_09_05' > Command invoked: ./dotest.py -C gcc-4.8 -A i386 --executable > /home/jmolenda/build/bin/lldb testcases/python_api/sbdata > compilers=['gcc-4.8'] > >

[Lldb-commits] [lldb] r282825 - Add unit tests for simple frameless i386 and x86_64 function

Author: jmolenda Date: Thu Sep 29 19:41:15 2016 New Revision: 282825 URL: http://llvm.org/viewvc/llvm-project?rev=282825=rev Log: Add unit tests for simple frameless i386 and x86_64 function instruction inspection to UnwindPlans. Modified:

[Lldb-commits] [lldb] r282811 - Switch to using TEST_EQ, TEST_FALSE where appropriate.

Author: jmolenda Date: Thu Sep 29 18:57:33 2016 New Revision: 282811 URL: http://llvm.org/viewvc/llvm-project?rev=282811=rev Log: Switch to using TEST_EQ, TEST_FALSE where appropriate. Modified: lldb/trunk/unittests/UnwindAssembly/x86/Testx86AssemblyInspectionEngine.cpp Modified:

[Lldb-commits] [lldb] r282790 - Add a quick note about how to build lldb with debug info using

Author: jmolenda Date: Thu Sep 29 16:47:15 2016 New Revision: 282790 URL: http://llvm.org/viewvc/llvm-project?rev=282790=rev Log: Add a quick note about how to build lldb with debug info using cmake/ninja on linux/bsd systems. Modified: lldb/trunk/www/build.html Modified:

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

http://lab.llvm.org:8011/builders/lldb-x86_64-ubuntu-14.04-cmake/builds/20099 > > Dimitar > > > On Thu, Sep 29, 2016 at 5:30 AM, Jason Molenda via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > Good suggestions, thanks. I'll fix those when I commit the 32-bit v

Re: [Lldb-commits] [lldb] r282683 - Add a unit test for an x86_64 assembly inspection of

Good suggestions, thanks. I'll fix those when I commit the 32-bit version of the same test. J > On Sep 28, 2016, at 9:28 PM, Zachary Turner <ztur...@google.com> wrote: > > > > On Wed, Sep 28, 2016 at 9:10 PM Jason Molenda via lldb-commits > <lldb-co

<    5   6   7   8   9   10   11   12   >