Re: [edk2-devel] Synchronous Exception at ArmGicDxe

2024-04-24 Thread Andrew Fish via groups.io
The fault address is 0x0004AC14. Is that in the address range of the GIC for this platform? What does that Physical address map to you on the STM32MP25? Thanks, Andrew Fish > On Apr 21, 2024, at 10:07 PM, Ba Gia Bao Phan > wrote: > > Hi Everyone, > > I'm wo

Re: [edk2-devel] Is there a way to create filesystem in UEFI Shell ?

2024-04-17 Thread Andrew Fish via groups.io
FYI you can have much larger files in the newer version of the filesystem. See EFI_COMMON_SECTION_HEADER2 https://uefi.org/specs/PI/1.8A/V3_Code_Definitions.html#firmware-file-system https://uefi.org/specs/PI/1.8A/V3_Code_Definitions.html#firmware-file-section Thanks, Andrew Fish > On Ap

Re: [edk2-devel] bootloader build error

2024-04-05 Thread Andrew Fish via groups.io
1.pe32' Thanks, Andrew Fish PS FYI Python 2.7 is no longer supported as of January 1st, 2020. > On Apr 4, 2024, at 5:13 AM, Bill Shih 施炫全 via groups.io > wrote: > > Hi Sir > > I have problem when building android bootloader. > > The log suggested I could mail you f

Re: [edk2-devel] Is there a way to create filesystem in UEFI Shell ?

2024-04-01 Thread Andrew Fish via groups.io
> On Mar 31, 2024, at 8:39 PM, John Chew wrote: > > On Sat, Mar 30, 2024 at 06:10 AM, Andrew Fish wrote: > You can make a ReadOnly file system out of contents on an FV (Firmware > Volume): > https://github.com/tianocore/edk2/tree/master/MdeModulePkg/Universal/FvSimple

Re: [edk2-devel] Is there a way to create filesystem in UEFI Shell ?

2024-03-29 Thread Andrew Fish via groups.io
/MdeModulePkg/Universal/FvSimpleFileSystemDxe FV is defined in the PI Spec as a layout for flash that contains files, but no directories. Thanks, Andrew Fish > On Mar 29, 2024, at 1:21 AM, John Chew wrote: > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to t

Re: [edk2-devel] test message - my messages aren't showing up?

2024-03-28 Thread Andrew Fish via groups.io
David, You have to be subscribed to the list for the mails to got directly to the list. I think you just subscribed so I had to clear you as OK to post. Basically your posts were going to moderation and a human had to approve them. Thanks, Andrew Fish > On Mar 28, 2024, at 9:48 AM, Davi

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Andrew Fish via groups.io
e could probably define a HOB to define the bits to use given the code constructing the page tables for DXE needs to know all the rules here. Thanks, Andrew Fish > The > > From: Andrew (EFI) Fish > Sent: Friday, January 12, 2024 10:57 AM > To: edk2-devel-groups-io ; Ki

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Andrew Fish via groups.io
000+ handles. The hot path was CoreValidateHandle(). I think the number of calls to CoreValidateHandle() explodes if you have more handles so it is not just the raw performance of CoreValidateHandle(), but also how many times it gets called. Thanks, Andrew Fish > Mike > > >> -Origina

Re: [edk2-devel] Memory Attribute for depex section

2024-01-12 Thread Andrew Fish via groups.io
ARMv8.3 defines pointer authentication and on a Mac arm64e is an ABI with pointer authentication enabled. Given call return rules are different and you have to initialize signed pointers it is a different ABI, but never say never that a signed pointer ABI could get added to UEFI. Thanks, Andrew

Re: [edk2-devel] Memory Attribute for depex section

2024-01-11 Thread Andrew Fish via groups.io
its own problem? 3) The issue is patching the grammar in place, why can’t we just make a copy for the dispatcher grammer, and operate on the copy. Maybe via a copy on 1st update strategy? Thanks, Andrew Fish > On Jan 10, 2024, at 5:45 AM, Laszlo Ersek wrote: > > (+ Andrew) >

Re: [edk2-devel] UDK2022 stable202211 - GCC compiler for Windows for building X64 EFI

2023-09-27 Thread Andrew Fish via groups.io
There is info about toolchains checked in here:edk2/BaseTools/Conf/tools_def.template at master · tianocore/edk2github.comOn Sep 27, 2023, at 8:10 PM, Daniel Samuelraj wrote:We tried GCC at https://sourceforge.net/projects/gcc-win64/And then we tried GCC ver5.4We are getting the following

Re: [edk2-devel] Maybe it is time to update code style?

2023-09-25 Thread Andrew Fish via groups.io
on their team printer….. Thanks, Andrew Fish > On Sep 25, 2023, at 2:03 AM, Marcin Juszkiewicz > wrote: > > I feel sick each time I have to edit EDK2 code. > > All those INF, DEC, DSC, FDF, XYZ files are something I do not even try > to understand, just got minimal knowledge what

Re: [edk2-devel] [PATCH v1] EmulatorPkg: Fix Source Level Debug on Windows

2023-09-23 Thread Andrew Fish via groups.io
Very cool. Thank You! Thanks, Andrew Fish > On Sep 22, 2023, at 3:49 PM, Nate DeSimone > wrote: > > The Visual Studio Windows debugger will only load symbols for PE/COFF images > that Windows is aware of. Therefore, to enable source level debugging, all > PEI/DXE modules

Re: [edk2-devel] How i can fix this build error VariableRuntimeDxe.inf

2023-09-11 Thread Andrew Fish via groups.io
VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf # Happy hacking…. Thanks, Andrew Fish > On Sep 11, 2023, at 4:17 AM, Im from ohio wrote: > &g

Re: [edk2-devel] VT100 terminal for UEFI shell

2023-09-07 Thread Andrew Fish via groups.io
o find someone who know why it is that way. > > Feel free to ask I’ll probably be 24 years into at some point soon or maybe already I kind of forgot when I started. I was around for most of the big picture stuff so that is one of the reasons I answer these general questions on the list. Thanks

Re: [edk2-devel] VT100 terminal for UEFI shell

2023-09-07 Thread Andrew Fish via groups.io
/tianocore/edk2/blob/master/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.h#L129 [4] https://uefi.org/specs/UEFI/2.10/03_Boot_Manager.html#globally-defined-variables Thanks, Andrew Fish > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group.

Re: [edk2-devel] [PATCH] Use C99 flexible arrays

2023-08-22 Thread Andrew Fish via groups.io
long term to move to valid C99, but we should verify we did not break anything. Thanks, Andrew Fish > On Aug 21, 2023, at 9:56 AM, ehaouas wrote: > > ‌ > Hi, > > No, I didn't. > > De : "Yao, Jiewen" > A : "devel@edk2.groups.io" ,"eha

Re: [edk2-devel] About EDK2 supports Self Modifying Code

2023-08-17 Thread Andrew Fish via groups.io
the arch spec does not say something like mm0 - mm7 it seems to imply mm0 - mmN (N is implementation defined). Some of these resources seemed to be debug registers and performance counters, so things that make a lot of sense to have a variable number defined by the implementation? Th

Re: [edk2-devel] Error F001: Module SmmLockBox.inf NOT found

2023-08-17 Thread Andrew Fish via groups.io
I think I may have botched this message in moderation…. Andrew, Did you update the submodule? git submodule update —init See Submodules under this section of the ReadMe.rst: https://github.com/tianocore/edk2 What were you trying to build? Thanks, Andrew Fish > Subject: Error F001: Mod

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAG?

2023-08-17 Thread Andrew Fish via groups.io
      *Interface = Prot->Interface;   Thanks,   Andrew Fish On Aug 16, 2023, at 10:02 AM, Michael

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAG?

2023-08-16 Thread Andrew Fish via groups.io
ERT (Prot != NULL); > // > // EFI_ALREADY_STARTED is not an error for bus driver. > // Return the corresponding protocol interface. > // > *Interface = Prot->Interface; Thanks, Andrew Fish > On Aug 16, 2023, at 10:02 AM, Michael D Kinney >

Re: [edk2-devel] About EDK2 supports Self Modifying Code

2023-08-15 Thread Andrew Fish via groups.io
> On Aug 15, 2023, at 11:48 AM, Ard Biesheuvel wrote: > > On Tue, 15 Aug 2023 at 18:31, Andrew Fish via groups.io <http://groups.io/> > mailto:afish=apple@groups.io>> wrote: >> >> >> >>> On Aug 15, 2023, at 8:39 AM, Pedro Falcato wro

Re: [edk2-devel] About EDK2 supports Self Modifying Code

2023-08-15 Thread Andrew Fish via groups.io
> On Aug 15, 2023, at 8:39 AM, Pedro Falcato wrote: > > On Tue, Aug 15, 2023 at 4:05 PM Andrew Fish via groups.io > wrote: >> >> Chao, >> >> From a quick google it looks like CSR* is used to access banks of registers >> that relate to

Re: [edk2-devel] About EDK2 supports Self Modifying Code

2023-08-15 Thread Andrew Fish via groups.io
rs of assembler. I know the Apple assembler has a unique take on this. Thanks, Andrew Fish > On Aug 15, 2023, at 1:54 AM, Chao Li wrote: > > Hi Ard, > > Ok, I see, thanks for you suggestion. > > > Thanks, > Chao > 在 2023/8/15 16:28, Ard Biesheuvel

Re: [edk2-devel] About EDK2 supports Self Modifying Code

2023-08-14 Thread Andrew Fish via groups.io
Modifying Code is kind of like saying you need to write it in assembler since the C compiler is not smart enough, and most of the times people think that they are wrong. Thanks, Andrew Fish > On Aug 14, 2023, at 8:06 PM, Chao Li wrote: > > Hi Liming, Bob and Yuwei > >

Re: [edk2-devel] [PATCH v1 0/7] Add DebugMacroCheck

2023-08-14 Thread Andrew Fish via groups.io
> On Aug 14, 2023, at 5:26 PM, Michael Kubacki > wrote: > > On 8/14/2023 8:23 PM, Andrew Fish via groups.io wrote: >>> On Aug 14, 2023, at 3:51 PM, Pedro Falcato wrote: >>> >>> On Mon, Aug 14, 2023 at 9:49 PM Michael Kubacki >>> mailto:mikub

Re: [edk2-devel] [PATCH v1 0/7] Add DebugMacroCheck

2023-08-14 Thread Andrew Fish via groups.io
wledge of > printf-like functions. > Have you explored that option for future code? See e.g > https://godbolt.org/z/4e8d3WToT (I don't know what MSVC uses, if > anything). > I have a dream that we add an eft_print as an attribute format archetype and then do what you recommend. Afte

Re: [edk2-devel] Can RELEASE target disable -Werror CC_FLAG?

2023-08-10 Thread Andrew Fish via groups.io
’ve actually done that for power on before. If your compiler supports LTO you are not required to set MDEPKG_NDEBUG on RELEASE builds, and you can used a PCD to configure your debug level, per build type. Maybe we should just have the error checks in all paths? Thanks, Andrew Fish > On Aug 10

Re: [edk2-devel] Runtime Page Granularity on ARM64

2023-08-09 Thread Andrew Fish via groups.io
that is the difference. [1] https://developer.arm.com/documentation/101811/0103/Translation-granule Thanks, Andrew Fish > On Aug 9, 2023, at 5:35 PM, Oliver Smith-Denny > wrote: > > Hi Ard, > > I just sent out a patch (MdeModulePkg: HeapGuard: Don't Assume Pool Head > Allocated

Re: [edk2-devel] [edk2-test]

2023-07-18 Thread Andrew Fish via groups.io
John, The UEFI Forum (https://uefi.org/) is the industry trade group that owns the UEFI and ACPI specifications. It also hosts the SCTs: https://uefi.org/testtools Thanks, Andrew Fish > On Jul 17, 2023, at 9:31 AM, Sellock, John via groups.io > wrote: > > Hello, > >

Re: [edk2-devel] Managing boot order dependencies with ResetNotification Protocol

2023-07-11 Thread Andrew Fish via groups.io
/MdeModulePkg/Core/Dxe/DxeMain/DxeProtocolNotify.c#L80 Thanks, Andrew FIsh > On Jun 28, 2023, at 5:23 PM, Ajay Iyengar (QUIC) > wrote: > > Hello, > > This is a comment and query on the Reset Notification Protocol defined by the > UEFI specification. > > The spe

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-19 Thread Andrew Fish via groups.io
%2BjGNOHT2Mkb4NBe7jeKsOcNkEogpKFe0NnEy1YkFMkzFk0VxUUpB8CoKh1KyvsMukLKR1y/MEHVSdMdhqgCD2dg5WITHsmJhRcfx/YNTOi6rt4SjqTwOGNmbNsQduhimJYtiOK4hMFA2Dn7uQR6pBel65KhqUZTlPNFUu5VKLVbJ5IleUODMcjrtVSHtRmOYkxMtJ4iAA Thanks, Andrew Fish PS I’m still not 100% sure it is a compiler bug. Some times things like this are due to the order the compiler

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
Mike, Sorry static was just to scope the name to the file since it is a lib, not to make it work. That is a cool site. I learned about it complaining about stuff to the compiler team on our internal clang Slack channel as they use it to answer my questions. Thanks, Andrew Fish > On May

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
%2BvQ9rqlQ0aZvsMDMNfbCUM6bqBk6Kb3xk%2BZFmWPQK0wALSI4ZlSFZdlKJo%2BjGNOHT2Mkb4NBe7jeKsOcNkEogpKFe0NnEy1YkFMkzFk0VxUUpB8CoKh1KyvsMukLKR1y/MEHVSdMdhqgCD2dg5WITHsmJhRcfx/YNTOi6rt4SjqTwOGNmbNsQduhimJYtiOK4hMFA2Dn7uQR6pBel65KhqUZTlPNFUu5VKLVbJ5IleUODMcjrtVSHtRmOYkxMtJ4iAA Thanks, Andrew Fish > On May 18, 2023, at 11:45 AM, And

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
traveling and in Cupertino with lots of meetings so I did not have time to adjust the compiler flags…. Thanks, Andrew Fish > On May 18, 2023, at 10:24 AM, Andrew (EFI) Fish wrote: > > Mike, > > I guess my other question… If this turns out to be a compiler bug should we >

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
that will not return you from CpuDeadLoop() that will just fall into the next function. That might work if CpuDeadLoop() was inlined, but if it was a call you would start running the next function in the binary. Thanks, Andrew Fish > On May 18, 2023, at 10:36 AM, Rebecca Cran wrote: > > W

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
Mike, I guess my other question… If this turns out to be a compiler bug should we scope the change to the broken toolchain. I’m not sure what the right answer is for that, but I want to ask the question? Thanks, Andrew Fish > On May 18, 2023, at 10:19 AM, Michael D Kinney >

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
Yea, but I think you want static and volatile on the global. But good idea as for the non XIP case you can just modify the global. It might be a good idea to document the debugging flow in the header for CpuDeadLoop()... Thanks, Andrew Fish > On May 18, 2023, at 10:19 AM, Kinney, Michae

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
Mike, Good point, that is why we are using the stack …. The only other thing I can think of is to pass the address of Index to some inline assembler, or an asm no op function, to give it a side effect the compiler can’t resolve. Thanks, Andrew Fish > On May 18, 2023, at 10:05 AM, Kin

Re: [edk2-devel] CpuDeadLoop() is optimized by compiler

2023-05-18 Thread Andrew Fish via groups.io
the compiler issue. Thanks, Andrew Fish > On May 18, 2023, at 8:36 AM, Michael D Kinney > wrote: > > Hi Ray, > > So the code generated does deadloop, but is just not easy to resume from as > we have been able to do in the past. > > We use CpuDeadloop() for 2 purposes.

Re: [edk2-devel] Building error

2023-05-18 Thread Andrew Fish via groups.io
In the WmiAwcc.asl file it looks like the 1109th byte has some invalid UTF-8 encoding. So it looks like the file got edited with an editor that us using an encoding other than ASCII or UTF-8? Thanks, Andrew Fish > On May 18, 2023, at 1:43 AM, Eva.Ss.Feng (ńTÉșÉș) > wrote: > >

Re: [edk2-devel] DSC nightmare

2023-02-22 Thread Andrew Fish via groups.io
MdePkg/Library/BaseMemoryLibOptDxe [5] https://uefi.org/specifications Thanks, Andrew Fish > On Feb 19, 2023, at 5:36 PM, Benjamin Mordaunt > wrote: > > Hi, > > I am working on implementing a new Arm platform in edk2-platforms, and have > reached the stage of tacklin

Re: [edk2-devel] regarding calling UEFI runtime services (mainly SetVariable) from linux or android OS which is running on xen+tianocore UEFI

2023-02-06 Thread Andrew Fish via groups.io
ate that puts RAM into self refresh. On a cold boot it allocates the memory, so you are starting over. Sorry I’ve never looked at the Xen code before so I’m sight reading. Thanks, Andrew Fish > Thanks & Regards > Ritul Guru > +91-9916513186 > > > On Mon, Feb 6, 2023 a

Re: [edk2-devel] USB: reducing/removing EHCI and XHCI logging when bulk transfer requests timeout

2022-11-29 Thread Andrew Fish via groups.io
> On Nov 29, 2022, at 11:47 AM, Rebecca Cran wrote: > > On 11/29/22 12:43, Andrew Fish via groups.io wrote: >>> On Nov 29, 2022, at 11:12 AM, Rebecca Cran wrote: >>> >>> I've been working on the UsbNetworkPkg drivers that Richard Ho submitted. >>&g

Re: [edk2-devel] USB: reducing/removing EHCI and XHCI logging when bulk transfer requests timeout

2022-11-29 Thread Andrew Fish via groups.io
Are those DEBUG prints or report status code? Thanks, Andrew Fish > -- > Rebecca Cran > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96712): https://edk2.groups.io/g/devel/message/96712 Mute This

Re: [edk2-devel] On RPi4 and Juno, gBS->Stall(1) takes 10us and 100us respectively

2022-11-28 Thread Andrew Fish via groups.io
b.h [5] https://github.com/tianocore/edk2/blob/master/ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c#L18 Thanks, Andrew Fish > On Nov 28, 2022, at 11:02 AM, Rebecca Cran wrote: > > I've been doing some work on USB and ended up realizing that gBS->Stall(1) is > taking much lon

Re: [edk2-devel] Access 64bit address space in 32bit mode

2022-11-09 Thread Andrew Fish via groups.io
Vincent, Thanks! I’d forgotten about that path. The other answer is defer the work to a DXE driver that runs 64-bit x86. Thanks, Andrew Fish > On Nov 9, 2022, at 10:58 AM, vincent zimmer wrote: > > we have the challenge of 32-bit PEI needing to access 64-bit addresses to > su

Re: [edk2-devel] How to add a DXE driver to an OVMF image?

2022-11-09 Thread Andrew Fish via groups.io
> On Nov 9, 2022, at 10:29 AM, d.meneses via groups.io > wrote: > > Thank you Andrew for your reply. > > Your explanation about the Driver Binding protocol cleared up some questions > of mine. > > Regarding the BDS, I recon I have some reading to do before I understand what > you said

Re: [edk2-devel] How to add a DXE driver to an OVMF image?

2022-11-09 Thread Andrew Fish via groups.io
> On Nov 4, 2022, at 6:20 AM, d.meneses via groups.io > wrote: > > Using DebugLib instead to print a message, I was able to confirm that my > driver is now running properly: > cat debug.log | grep Hello > This works both when adding it in the OVMF build and also when inserted by > UEFITool.

Re: [edk2-devel] How to add a DXE driver to an OVMF image?

2022-11-03 Thread Andrew Fish via groups.io
image from the QEMU command line. [1] https://uefi.org/specs/UEFI/2.10/03_Boot_Manager.html#removable-media-boot-behavior Thanks, Andrew Fish > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#95905): https://edk2.groups.io/g/devel/mes

Re: [edk2-devel] How to add a DXE driver to an OVMF image?

2022-11-02 Thread Andrew Fish via groups.io
a dependency expression. The Depex is for ordering the early drivers that don’t follow the UEFI Driver Model. So for example you have to configure your chipset, and SPI driver to get UEFI NVRAM working etc. Thanks, Andrew Fish > On Nov 2, 2022, at 5:58 PM, Pedro Falcato wrote: > > Hi!

Re: [edk2-devel] TPM2 EventLog EFI vs. ACPI

2022-09-17 Thread Andrew Fish via groups.io
> On Sep 17, 2022, at 11:31 AM, Jason Andryuk wrote: > > On Fri, Sep 16, 2022 at 10:28 PM Andrew Fish via groups.io > wrote: >> >> Is it possible to query the address from fw_cfg? > > Hi, Andrew, > > I believe QEMU puts "commands" into

Re: [edk2-devel] TPM2 EventLog EFI vs. ACPI

2022-09-16 Thread Andrew Fish via groups.io
Is it possible to query the address from fw_cfg? Thanks, Andrew Fish > On Sep 16, 2022, at 12:45 PM, Jason Andryuk wrote: > > Hi, > > I've noticed an issue with the TPM2 EventLog. OVMF exposes the TPM > Event Log via EFI and ACPI, but they have different address

Re: [edk2-devel] [PATCH] Maintainers.txt: Update email address

2022-09-15 Thread Andrew Fish via groups.io
Reviewed-by: Andrew Fish > On Sep 15, 2022, at 9:58 AM, Michael D Kinney > wrote: > > Reviewed-by: Michael D Kinney <mailto:michael.d.kin...@intel.com>> > > >> -Original Message- >> From: Nickle Wang mailto:nick...@nvidia.com>> &

Re: [edk2-devel] Error building MdeModulePkg.dsc with CLANG38 (clang 11.0.1)

2022-09-06 Thread Andrew Fish via groups.io
That is a missing EFIAPI. > On Sep 6, 2022, at 4:46 PM, Rebecca Cran wrote: > > I noticed that MdeModulePkg/MdeModulePkg.dsc doesn't build with clang 11: I > get an error in CapsuleApp: > > > build -p MdeModulePkg/MdeModulePkg.dsc -a X64 -t CLANG38 -b DEBUG > > ... > >

Re: [edk2-devel] [PATCH 1/1] MdePkg: Use ANSI colors to indicate debug message severity

2022-09-01 Thread Andrew Fish via groups.io
example. > Rebecca, I think this feature flag is going to control the output of edk2 DEBUG. In an abstract sense DEBUG is not Terminal or ConOut. It could be mapped to the same device, but it does not have to be. So maybe PcdDebugAnsiSeqSupport or DebugLibAnsiSeqSupport? Thanks, Andrew

Re: [edk2-devel] How to restrict HTTPS boot to a single address

2022-08-26 Thread Andrew Fish via groups.io
Rafael, I’m not sure this matches exactly what you are looking for, but the OVMF (Virtual Machine) has some configuration options around HTTPS boot [1]. That might be a good place to start. [1] https://github.com/tianocore/edk2/blob/master/OvmfPkg/README#L232 Thanks, Andrew Fish > On

Re: [edk2-devel] BaseTools no longer builds on macOS: "error: unknown warning option '-Werror=stringop-overflow'"

2022-08-25 Thread Andrew Fish via groups.io
erflow endif endif +endif LIBS = -lCommon ifeq ($(CYGWIN), CYGWIN) Thanks, Andrew Fish > On Aug 25, 2022, at 10:45 AM, Andrew Fish via groups.io > wrote: > > Rebecca, > > FYI /usr/bin/gcc has been a redirector into clang for a lot of years. > > The build picks di

Re: [edk2-devel] BaseTools no longer builds on macOS: "error: unknown warning option '-Werror=stringop-overflow'"

2022-08-25 Thread Andrew Fish via groups.io
X), llvm) # gcc 12 trips over device path handling BUILD_CFLAGS += -Wno-error=stringop-overflow endif endif +endif LIBS = -lCommon ifeq ($(CYGWIN), CYGWIN) [1] https://github.com/tianocore/edk2/blob/master/BaseTools/Source/C/Makefiles/header.makefile#L83 Thanks, Andrew Fish >

Re: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table

2022-08-23 Thread Andrew Fish via groups.io
mention this. Thanks, Andrew Fish > On Aug 23, 2022, at 2:28 PM, Rohit Mathew wrote: > > Hi Andrew, > > From: Andrew Fish mailto:af...@apple.com>> > Sent: 23 August 2022 21:11 > To: devel@edk2.groups.io <mailto:devel@edk2.groups.io>; Rohit Mathew > mailt

Re: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table

2022-08-23 Thread Andrew Fish via groups.io
UINT32MmioSize; >> + UINT32OverflowInterrupt; >> + UINT32OverflowInterruptFlags; > > [Rohit] Would it be better to have a type (possibly bitfield struct) instead > of a plain UINT32 for Flags? (MPAM ACPI 1.0, section 2.1.1, table 5 - > Interrupt fla

Re: [edk2-devel] Building C static Library for UEFI

2022-08-09 Thread Andrew Fish via groups.io
] https://github.com/tianocore/edk2/blob/master/UnitTestFrameworkPkg/Library/CmockaLib/CmockaLib.inf#L28 [4] https://github.com/tianocore/edk2/blob/master/OvmfPkg/OvmfPkgX64.dsc#L111 Thanks, Andrew Fish > On Jul 30, 2022, at 7:25 AM, Ayush Singh wrote: > > Hello everyone. There are s

Re: [edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-26 Thread Andrew Fish via groups.io
thub.com/tianocore/edk2/blob/master/BaseTools/Scripts/efi_lldb.py Thanks, Andrew Fish > Yours Sincerely, > > Ayush Singh > > > > On 7/26/22 00:24, Andrew Fish wrote: >> I guess I could at least dump to the end (req)…. Going backwards is a bit >> painful in x86

Re: [edk2-devel] [Patch v3 3/3] Maintainers.txt: Remove reviewer Harry Han

2022-07-25 Thread Andrew Fish via groups.io
Reviewed-by: Andrew Fish > On Jul 21, 2022, at 2:07 PM, Michael D Kinney > wrote: > > Cc: Harry Han > Cc: Andrew Fish > Cc: Leif Lindholm > Signed-off-by: Michael D Kinney > Reviewed-by: Harry Han > --- > Maintainers.txt | 2 -- > 1 file change

Re: [edk2-devel] [Patch v3 0/3] Update Maintainers.txt

2022-07-25 Thread Andrew Fish via groups.io
Reviewed-by: Andrew Fish > On Jul 21, 2022, at 2:07 PM, Michael D Kinney > wrote: > > Cc: Anthony Perard > Cc: Julien Grall > Cc: Daniel Schaefer > Cc: Sean Rhodes > Cc: Debkumar De > Cc: Erdem Aktas > Cc: Harry Han > Cc: Gary Lin > Cc: Andrew Fis

Re: [edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-25 Thread Andrew Fish via groups.io
hello_world_std.efi[0x140001b8c]: c3 retq So the faulting function is getting passed a bad pointer as its 1st arg. Thanks, Andrew Fish > On Jul 25, 2022, at 11:45 AM, Andrew Fish wrote: > > Ops… Looks like your PE/COFF is linked at 0x00014000, so 0x

Re: [edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-25 Thread Andrew Fish via groups.io
that looks like the fault. I don’t see that pattern in your .s file…. Can you figure out what function is @ 0x140001b60 in the PE/COFF image. Do you have a map file from the linker? Thanks, Andrew Fish PS Again sorry I don’t have anything installed to crack PDB files. Thanks, Andrew Fish > On

Re: [edk2-devel] Casting i128 into f64 in UEFI Rust pagefaults

2022-07-25 Thread Andrew Fish via groups.io
for any tools that dump the binary. Thanks, Andrew Fish > On Jul 25, 2022, at 10:33 AM, Ayush Singh wrote: > > Hello everyone.While running Rust tests in UEFI environment, I have come > across a numeric test that causes a pagefault. A simple reproducible example > for this

Re: [edk2-devel] Clarification of Memory management in PEI phase

2022-06-22 Thread Andrew Fish via groups.io
be as simple as just adding a new HOB type to represent free pool. [1] https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Pei/Memory/MemoryServices.c#L878 Thanks, Andrew Fish > On Jun 22, 2022, at 12:39 PM, Brian J. Johnson wrote: > > Sorry for the late response to th

Re: [edk2-devel] Aurora build failure

2022-06-22 Thread Andrew Fish via groups.io
I’m guessing all the CI testing is on Python 3.8.x I noticed one of the CI pipes is asking for Python 3.8 [1] [1] https://github.com/tianocore/edk2/blob/master/.azurepipelines/Ubuntu-PatchCheck.yml Thanks, Andrew Fish > On Jun 22, 2022, at 7:34 AM, Andrew (EFI) Fish wrote: > > T

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Suppress read only relocs errors on XCODE5 X64 toolchain

2022-06-22 Thread Andrew Fish via groups.io
Historically what would happen is any assembler that generated a relocation in the .text section would fail to link with Xcode and we would have to convert it to RIP relative addressing after the fact. Thanks, Andrew Fish > Theo wanted to prepare a V2 with an enhanced commit message a

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Suppress read only relocs errors on XCODE5 X64 toolchain

2022-06-22 Thread Andrew Fish via groups.io
I reached out to the Xcode ld64 maintainer to make sure it is safe to use -read_only_relocs suppress this way. Thanks, Andrew Fish > On Jun 18, 2022, at 8:19 PM, Andrew Fish via groups.io > wrote: > > Marvin, > > I’ll look into this. > > The history here is

Re: [edk2-devel] Aurora build failure

2022-06-22 Thread Andrew Fish via groups.io
That looks like an issue with using Python 3.9 as it changed tostring to tobyte. > On Jun 22, 2022, at 7:25 AM, Shivraj Patil wrote: > >  > Hello, > I am observing the following failure while trying to build Aurora > AU_LINUX_EMBEDDED_LE.PRODUCT.1.0_TARGET_ALL.01.318.215. Please have a look

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Suppress read only relocs errors on XCODE5 X64 toolchain

2022-06-18 Thread Andrew Fish via groups.io
Marvin, I’ll look into this. The history here is the original ld64 flags are what was required for proper function. I got them directly from the main ld64 maintainer. Big picture ld64 is the macOS and iOS linker, and it does not have official support for other targets, especially embedded.

Re: [edk2-devel] Windows 10 build failing

2022-06-17 Thread Andrew Fish via groups.io
ll/RegisterFilterLibNull.inf CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf SmmCpuRendezvousLib|MdePkg/Library/SmmCpuRendezvousLibNull/SmmCpuRendezvousLibNull.inf Thanks, Andrew Fish > I saw some posts that this was resolved back in 2021, yet I'm still getting > hit with it. > Any advice on

Re: [edk2-devel] Running OVMF on crosvm

2022-06-16 Thread Andrew Fish via groups.io
it to hang > * Remove VirtioFsDxe dependency as crosvm seems to choke on certain things > it's doing too I hit something like this in another context. I root caused it to the VirtioFsDxe being coded to a recent version of the VirtIo Spec (it is a newer EFI driver) and my VM was on an old

Re: [edk2-devel] Does edk2 also link to crt0-efi like GNU-EFI *

2022-06-16 Thread Andrew Fish via groups.io
github.com/tianocore/edk2/blob/master/MdePkg/Library/UefiApplicationEntryPoint/ApplicationEntryPoint.c Thanks, Andrew Fish > The problem was that I couldn't find a way to go from `efi_main -> > rust lang_start` earlier. After all, it is such a low-level detail > that there is almost no documentatio

Re: [edk2-devel] Does edk2 also link to crt0-efi like GNU-EFI

2022-06-16 Thread Andrew Fish via groups.io
www.programmershideaway.xyz/post5/) > > [1] https://github.com/tianocore/edk2/blob/master/MdePkg/Library/UefiApplicationEntryPoint/ApplicationEntryPoint.c Thanks, Andrew Fish > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Re

Re: [edk2-devel] Clarification of Memory management in PEI phase

2022-06-09 Thread Andrew Fish via groups.io
emory region, and FreePages just marks that HOB as not used. That code is also in this file [1]. TL;DR there is no pool manager in PEI. [1] https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Core/Pei/Memory/MemoryServices.c#L878 Thanks, Andrew Fish > Ayush Singh > > > &g

Re: [edk2-devel] ovmf miscompiles with gcc-12

2022-06-08 Thread Andrew Fish via groups.io
OPTIONAL, IN VOID *NewStack, ... ) Thanks, Andrew Fish PS The Xcode clang always emits the frame pointer to enable stack walks. > On Jun 7, 2022, at 4:14 AM, Jiri Slaby wrote: > > On 07. 06. 22, 13:07, Gerd Hoffmann wrote: >> On Tue, Jun 07, 2022 at 1

[edk2-devel] [ArmVirtPkg] So in 2014 would could not start an ARM FV @ address 0x00000000, why is that still true today?

2022-06-03 Thread Andrew Fish via groups.io
) gArmTokenSpaceGuid.PcdFvBaseAddress|gArmTokenSpaceGuid.PcdFvSize FV = FVMAIN_COMPACT Thanks, Andrew Fish -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90206): https://edk2.groups.io/g/devel/message/90206 Mute This Topic: https

Re: [edk2-devel] including redfish libs results in multiple definitions of symbols

2022-05-25 Thread Andrew Fish via groups.io
factors for the library classes was to not have to change your vendors driver INF file id you wanted to use a different instance of the DebugLib etc. Thanks, Andrew Fish > On May 25, 2022, at 9:07 PM, Ethin Probst wrote: > > aren't the Base*Libs there in case you want to override

Re: [edk2-devel] including redfish libs results in multiple definitions of symbols

2022-05-25 Thread Andrew Fish via groups.io
Reviewed-by: Nickle Wang Acked-by: Leif Lindholm Reviewed-by: Michael D Kinney Thanks, Andrew Fish > /usr/bin/ld: UefiSortLib.obj (symbol from plugin): in function > `PerformQuickSort': > (.text+0x0): multiple definition of `PerformQuickSort'; BaseSortLib.obj >

Re: [edk2-devel] [edk2] [PATCH v1 1/1] OvmfPkg/TdxDxe: Remove AsmRelocateApMailBoxLoopStart prefix at call

2022-05-25 Thread Andrew Fish via groups.io
I think we need to -D OPENSSL_NO_APPLE_CRYPTO_RANDOM in the INF. Thanks, Andrew Fish > On May 25, 2022, at 7:39 PM, Rebecca Cran wrote: > > It's Library/OpensslLib/openssl/include/crypto/rand.h > > # include > > # if defined(__APPLE__) && !defined(O

Re: [edk2-devel] [edk2] [PATCH v1 1/1] OvmfPkg/TdxDxe: Remove AsmRelocateApMailBoxLoopStart prefix at call

2022-05-25 Thread Andrew Fish via groups.io
What is pulling in Availability.h? That sound more like and #ifdef issue in some 3rd party header? I think I might have seen that in SSL headers? > On May 25, 2022, at 6:26 PM, Rebecca Cran wrote: > > Reviewed-by: Rebecca Cran > Tested-by: Rebecca Cran > > This lets the build get further,

[edk2-devel] Can you create a PCI Option ROM and place it in an FV in a single build?

2022-05-24 Thread Andrew Fish via groups.io
OptionRomPkg/AtapiPassThruDxe/AtapiPassThruDxe.inf What I can’t figure out is how to get that PCI ROM in the FV? Thanks, Andrew Fish -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89989): https://edk2.groups.io/g/devel/message/89989 Mute

Re: [edk2-devel] Question about PCD and FW_BASE_ADDRESS

2022-05-09 Thread Andrew Fish via groups.io
37C DEFINE FVMAIN_SIZE = 0x00348000 DEFINE SECFV_OFFSET = 0x003CC000 DEFINE SECFV_SIZE= 0x34000 !endif [1] https://github.com/tianocore/edk2/blob/master/OvmfPkg/OvmfPkgDefines.fdf.inc Thanks, Andrew Fish PS Note sometimes I configure my builds to place this in the Buil

Re: [edk2-devel] Debug OVMF

2022-05-09 Thread Andrew Fish via groups.io
ots of interweb searching. But even if something goes wrong I can probably help out on the mailing list. Thanks, Andrew Fish PS It should be possible to use the efi_debugging.py Python classes with any debugger that supports Python, or to use the services from other gdb debugging scripts etc. &

Re: [edk2-devel] [rfc] Remove support for unsupported tool_chain_tags

2022-05-04 Thread Andrew Fish via groups.io
I can sign up to maintain XCODE. I think Rebecca has been running test builds with XCODE. The XCODE5 names comes from the compiler flags needing to change for Xcode 5. Yes 2013 called and wants it compiler back. Thanks, Andrew Fish > On May 2, 2022, at 4:24 PM, Sean wr

Re: [edk2-devel] [edk2-discuss] GSoC Proposal

2022-04-14 Thread Andrew Fish via groups.io
o to them it was easier to move a lot of the chipset init code into PEI as that is the world they had to figure out to get memory turned on. I mean why learn EFI if you don’t have to? So that is how we get so much code in IA32 (i386) on some platforms. This start kind of biased future choices and

Re: [edk2-devel][PATCH v3 1/8] IntelFsp2Pkg: X64 compatible changes to support PEI in 64bit

2022-04-06 Thread Andrew Fish via groups.io
>> -global ASM_PFX(AsmReadEsp) >> -ASM_PFX(AsmReadEsp): >> +global ASM_PFX(AsmReadStackPointer) >> +ASM_PFX(AsmReadStackPointer): >> mov eax, esp >> ret >> > > I guess it's possible that bootloader sets up the stack above 4G. > If that's

Re: [edk2-devel] need help - edk2 build issue

2022-04-05 Thread Andrew Fish via groups.io
.org/v3/index.json;, "version": "2.15.05", "flags": ["set_path", "host_specific"] } Thanks, Andrew Fish > On Apr 5, 2022, at 1:09 PM, Ghorai, Sukumar wrote: > > Hi, > > would you pl help me to resolve this edk2 build issue (TOT code

Re: [edk2-devel] CryptoPkg build broken using XCODE5 (Availability.h not found)

2022-03-29 Thread Andrew Fish via groups.io
=uninitialized -DOPENSSL_NO_APPLE_CRYPTO_RANDOM # # AARCH64 uses strict alignment and avoids SIMD registers for code that may execute Thanks, Andrew Fish > On Mar 29, 2022, at 10:33 AM, Rebecca Cran wrote: > > A build of CryptoPkg with XCODE5 on macOS is now trying to include > Av

Re: [edk2-devel] [PATCH 3/3] Basetools: turn off gcc12 warning

2022-03-29 Thread Andrew Fish via groups.io
> On Mar 29, 2022, at 2:38 PM, Andrew Fish via groups.io > wrote: > > > >> On Mar 29, 2022, at 11:14 AM, gr...@grantlmul.xyz >> <mailto:gr...@grantlmul.xyz> wrote: >> >> While I can't test this myself, the following does appear to result i

Re: [edk2-devel] [PATCH 3/3] Basetools: turn off gcc12 warning

2022-03-29 Thread Andrew Fish via groups.io
efiles/app.makefile # gcc 12 trips over device path handling -BUILD_CFLAGS += -Wno-error=stringop-overflow +BUILD_CFLAGS += -Wno-error=stringop-overflow -Wno-unknown-warning-option LIBS = -lCommon ifeq ($(CYGWIN), CYGWIN) Thanks, Andrew Fish > LIBS = -lCommon > ifeq ($(CYGWIN), CYGWIN) &g

Re: [edk2-devel] Question about UEFI, AddressSanitizer and MMU mappings

2022-03-25 Thread Andrew Fish via groups.io
ob/master/MdeModulePkg/MdeModulePkg.dec#L979 Thanks, Andrew Fish > On Mar 25, 2022, at 2:07 AM, Marvin Häuser wrote: > > Hey Pedro, > > ASan is somewhat listed for „LLVM Optimizations“. > A quick and dirty reference for UEFI UBSan can be found here: > https://github.com/acidanthera/O

Re: [edk2-devel] Debugging scripts: "Add support for gdb and lldb"

2022-03-15 Thread Andrew Fish via groups.io
Rebecca, That would be awesome. I’m happy to help, and answer questions. I’ve been kind of swamped in my day job lately so this would really help. Thanks, Andrew Fish > On Mar 15, 2022, at 8:48 PM, Rebecca Cran wrote: > > Given the lack of progress on this for many

[edk2-devel] Unit Test and sanitizers

2022-02-23 Thread Andrew Fish via groups.io
7ff7bde35978 r14 = 0x0001020cdc80 r15 = 0x000108da8010 AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV t.c:13 in main ==5312==ABORTING zsh: abort ./a.out Thanks, Andrew Fish -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sen

Re: [edk2-devel] PcdDebugPropertyMask in DSC: How to I set different values for PEI and DXE?

2022-02-17 Thread Andrew Fish via groups.io
ory, we cannot support setting a FixedAtBuild > PCD for each > module type. > Mike, Yea I’m thinking this is a good reason to maybe not add more knobs. I was trying to get tricky and have code conditionally use a global so I could use the lib XIP when I shot myself in the foot. Thanks, Andr

Re: [edk2-devel] PcdDebugPropertyMask in DSC: How to I set different values for PEI and DXE?

2022-02-17 Thread Andrew Fish via groups.io
abling [Components.$(PEI_ARCH)] and [Components.$(DXE_ARCH)] > In my case PEI_ARCH == DXE_ARCH so this kind of trick is not helpful. The reality is this trick only works for non virtualized X64 platforms and the edk2 supports a lot more flavors of platforms than X64. Thanks, Andrew Fis

  1   2   3   4   5   6   7   8   9   10   >