Re: RFC: develop feature branches in main repo

2010-11-09 Thread Bart Cerneels
On Tue, Nov 9, 2010 at 17:04, Ian Monroe i...@monroe.nu wrote: On Tue, Nov 9, 2010 at 9:57 AM, Leo Franchi lfran...@kde.org wrote: On Tuesday, November 09, 2010 09:50:29 AM Ian Monroe wrote: I know some people are still using Gitorious repos and such for the ongoing work. However recently

Re: Review Request: Change resizing behaviour of OrganizeCollectionDialog

2010-11-10 Thread Bart Cerneels
On 2010-11-10 12:10:47, Bart Cerneels wrote: Just tried it and it's indeed an improvement. Should I push it or can you. Philipp Schmidt wrote: You will need to do that, i neither have a git account at kde yet nor write access to the amarok repository. Done! - Bart

Re: Review Request: Fixes bugs 250746, 250750 and partially fixes bug 245646

2010-11-21 Thread Bart Cerneels
On 2010-11-21 09:44:15, Bart Cerneels wrote: Ah, using the actions certainly is a nice move. The removeRow path for deleting playlistbrowser items is a tricky one, so why not avoid it when possible. Thanks for the fix. Pushed to git master: http://commits.kde.org/amarok

Re: starting from scratch on mediadevice

2010-11-22 Thread Bart Cerneels
the Thursday meeting according to your schedule? Also, make sure to push your local work branch to git as fast as possible. The git command goes something like this: git push origin IncrementalOpmlDirectory:stecchino-IncrementalOpmlDirectory Bart On Fri, Oct 22, 2010 at 20:44, Bart Cerneels bart.cerne

Re: Review Request: Implements the wishlist item 185397 - Saved playlist default name could be smarter

2010-11-25 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100168/#review402 --- Thanks for the patch. I'm sure this feature will be much loved

Re: Review Request: Save selected tracks to already saved playlist or a new playlist

2010-12-01 Thread Bart Cerneels
On 2010-12-01 08:31:06, Bart Cerneels wrote: Bart Cerneels wrote: Wonderful, looks like my very long comment is not saved, great. Short version: Patch has usability problems because of conflict with Playlist design, not meant as a playlist editor. Partial saving

Re: Amarok build failure on armel for Kubuntu

2010-12-09 Thread Bart Cerneels
On Thu, Dec 9, 2010 at 16:41, Scott Kitterman ubu...@kitterman.com wrote: markey sent asked me to write this list to mention to one of the other amarok developers that we have a problem on Kubuntu that because qreal != double on armel amarok won't build at the moment on that arch.

Re: Playdar Collection

2010-12-16 Thread Bart Cerneels
On Thu, Dec 16, 2010 at 11:51, Mark Kretschmann kretschm...@kde.org wrote: Hey all, recently several people have noticed that our new Playdar Collection is causing a slowdown in startup time. I'm wondering, should we not default-disable this feature? 1) It causes unnecessary slowdown. 2)

Re: Preventing scripts blocking Amarok - any taker?

2010-12-16 Thread Bart Cerneels
On Thu, Dec 16, 2010 at 14:20, Mark Kretschmann kretschm...@kde.org wrote: On Thu, Dec 16, 2010 at 2:17 PM, Bart Cerneels bart.cerne...@kde.org wrote: On Thu, Dec 16, 2010 at 13:59, Mark Kretschmann kretschm...@kde.org wrote: On Thu, Dec 16, 2010 at 12:22 PM, Myriam Schweingruber myr...@kde.org

Re: Preventing scripts blocking Amarok - any taker?

2010-12-16 Thread Bart Cerneels
On Thu, Dec 16, 2010 at 15:02, Mark Kretschmann kretschm...@kde.org wrote: On Thu, Dec 16, 2010 at 2:48 PM, Bart Cerneels bart.cerne...@kde.org wrote: On Thu, Dec 16, 2010 at 14:20, Mark Kretschmann kretschm...@kde.org wrote: On Thu, Dec 16, 2010 at 2:17 PM, Bart Cerneels bart.cerne...@kde.org

[Amarok] b53fae0 Revert Implement metadataChanged() to keep the vi

2010-12-18 Thread Bart Cerneels
commit b53fae0a4273747cefc679caace25baec941339a branch master Author: Bart Cerneels bart.cerne...@kde.org Date: Sat Dec 18 19:40:58 2010 +0100 Revert Implement metadataChanged() to keep the view from resetting This reverts commit 9ab7462612680caa5af99285aca0b8b186ac893e

Re: Bug #155075 - Podcast filename dialog

2010-12-20 Thread Bart Cerneels
On Sun, Dec 19, 2010 at 16:59, sandeep sandy.8...@gmail.com wrote: Hi, I've decided to take up this junior job (Bug #155075). So after looking at the code a bit I found that the podcast settings are stored in a database. So I guess the filename configuration should go in there too. Is there

Re: This time of the year again: Splash Screen

2010-12-23 Thread Bart Cerneels
On Thu, Dec 23, 2010 at 11:30, Nikhil Marathe nsm.nik...@gmail.com wrote: On Thu, Dec 23, 2010 at 3:09 PM, Mark Kretschmann kretschm...@kde.org wrote: Hey Amarok Team, first of all, a happy Christmas to all of you (in case your are Christian, otherwise, just a happy holiday)! Our release of

Re: Bart's suggestion to build release build regularly

2010-12-27 Thread Bart Cerneels
On Mon, Dec 27, 2010 at 10:36, Valorie Zimmerman valorie.zimmer...@gmail.com wrote: I saw notice of this new commit this morning in #amarok: [01:16] CIA-50 Bart Cerneels master * rv2.3.90-82-geff5427 amarok/src/ (5 files in 3 dirs): [01:16] CIA-50 Include updated category in signal. [01:16

Re: Bug #155075: Podcast filename configuration

2011-01-01 Thread Bart Cerneels
On Sat, Jan 1, 2011 at 00:26, sandeep sandy.8...@gmail.com wrote: Hi, I'm working on this bug, and I wondered if the filename configuration should come under general podcast settings or under each individual podcast channel's settings. What's your opinion on this? Sandeep From my experience

Re: tagging 2.4 in a week

2011-01-01 Thread Bart Cerneels
On Sat, Jan 1, 2011 at 10:37, Lydia Pintscher ly...@kde.org wrote: Heya folks :) The schedule says tagging of 2.4 is in a week. How does everyone feel about that? Yay? Nay? Cheers Lydia I'll be traveling and won't be able to solve any last-minute bugs. On the other had I don't think

Amarok mobile roadmap

2011-01-05 Thread Bart Cerneels
Hi guys markey and me are seriously considering working hard on a mobile port for this: http://qt-apps.org/news/?id=340 I've been investigating how to do such a port for a few months so let me share my insights. * The future is Qt Quick: UI design will be done completely using QML, C++ is only

Re: Bug #155075: Podcast filename configuration

2011-01-29 Thread Bart Cerneels
- Original message - Hi, I've been working on this bug for a while now (intermittently). I was wondering how the filename configuration dialog should be displayed i.e should it come in the menu that appears when the user right clicks on a podcast channel, or instead should it be

Re: GSoC Project

2011-02-08 Thread Bart Cerneels
On Wed, Feb 9, 2011 at 08:26, Vavelin Kevin kusag...@gmail.com wrote: I take a look on http://community.kde.org/GSoC/2011/Ideas#Project:_Playlist_sharing and i think i'll working on for gsoc (I'm actually on licence engineer at 3iL). But i have one more feature for that, integration with

Re: Google Summer Of Code

2011-02-09 Thread Bart Cerneels
On Tue, Feb 8, 2011 at 23:49, Philipp Schmidt philschm...@gmx.net wrote: Am Samstag 05 Februar 2011, 21:32:33 schrieb Nikhil Marathe: Hi, I don't see any summer of code ideas for Amarok. […] I don't have any ideas right now, but I would be willing to mentor some other idea if it is

Re: Ipod development support

2011-02-09 Thread Bart Cerneels
On Wed, Feb 9, 2011 at 11:11, Jochen Bauer joba@googlemail.com wrote: Hi developers, Is anyone currently developing the Ipod integration in amarok? Is there anyone of you who wants to do such a thing anyway? Xevix, who did the most of the ipod stuff so far said once that he even has no

Re: Review Request: Podcast episode filename configuration

2011-02-20 Thread Bart Cerneels
://git.reviewboard.kde.org/r/100686/ --- (Updated Feb. 19, 2011, 5:36 p.m.) Review request for Amarok and Bart Cerneels. Summary --- Adds a dialog to configure podcast episode filenames. Added a filenamelayout column

Re: changing rating in playlist inline editor

2011-02-23 Thread Bart Cerneels
On Wed, Feb 23, 2011 at 16:01, Edward Hades Toroshchin edward.ha...@gmail.com wrote: Hey guys, I've recently tried to change a song's rating in the playlist. And I didn't like it much. To change the rating you have to do the following: 1. Click the stars in the playlist. 2. Wait a little

Re: Return Playdarcollection from the Dead ;)

2011-02-25 Thread Bart Cerneels
On Wed, Feb 23, 2011 at 19:06, Stefan Derkits ste...@derkits.at wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hey, Yeah, Leo and I talked about putting together a 'dummy service' for it, which would allow enable/disable and configuration, and I still think that's a good idea, but it

Re: Review Request: gpodder.net Service (Podcast Directory Podcast Provider)

2011-03-01 Thread Bart Cerneels
: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100582/ --- (Updated March 1, 2011, 11:50 p.m.) Review request for Amarok, Leo Franchi and Bart Cerneels

Re: Google Summer Of Code

2011-03-04 Thread Bart Cerneels
On Tue, Mar 1, 2011 at 23:24, Vavelin Kevin kusag...@gmail.com wrote: Hi all, i want to know more about http://community.kde.org/GSoC/2011/Ideas#Project:_Playlist_sharing . I don't know what is HTTP streaming and NAT traversal. I take a look on telepathy and already have knowledge in Qt, C++

Re: RFC: disabled (or not yet enabled) collections in the browser

2011-03-04 Thread Bart Cerneels
On Fri, Mar 4, 2011 at 18:38, Mark Kretschmann kretschm...@kde.org wrote: On Fri, Mar 4, 2011 at 12:21 PM, Bart Cerneels bart.cerne...@kde.org wrote: On Mon, Jul 19, 2010 at 15:37, Bart Cerneels bart.cerne...@kde.org wrote: I want to make it possible to list a collection in the CB

Re: Another question about Gpodder

2011-03-07 Thread Bart Cerneels
On Mon, Mar 7, 2011 at 12:03, Stefan Derkits ste...@derkits.at wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hey, On 03/07/2011 11:57 AM, Valorie Zimmerman wrote: In notice that on the website, there is an option to sync podcasts across devices. I assume for that to happen in

Re: Review Request: Only expose one menubar

2011-03-17 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100882/#review2017 --- Ship it! Yup, it works. Thanks for reminding me of desktop

Re: vision creation - next step - first draft

2011-03-18 Thread Bart Cerneels
On Wed, Mar 16, 2011 at 21:33, Lydia Pintscher ly...@kde.org wrote: Heya folks :) Valorie, Teo and I sat down to write the first draft for the vision based on the input we gathered on the wiki page and in the meeting. Now it's time to get feedback from all of you and polish it. What we have

Re: Amarok design meeting

2011-03-21 Thread Bart Cerneels
On Sun, Mar 20, 2011 at 15:23, Teo Mrnjavac t...@kde.org wrote: On Fri, Mar 18, 2011 at 14:55, Teo Mrnjavac t...@kde.org wrote: On Fri, Mar 18, 2011 at 08:20, Bart Cerneels bart.cerne...@kde.org wrote: Now back to implementing that vision. Over. Hello team, I have taken the liberty

Mentoring Collection refactor

2011-03-25 Thread Bart Cerneels
Anyone want to mentor this? If not it will be retracted. http://community.kde.org/GSoC/2011/Ideas#Project:_Self_Contained_Collection ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request: Bug 261062 - JJ: Mark episodes to keep

2011-04-01 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100998/#review2300 --- Overall it looks very good, just worried about some possible

Re: Bug 149453

2011-04-15 Thread Bart Cerneels
On Thu, Apr 14, 2011 at 23:23, sandeep sandy.8...@gmail.com wrote: Hi, Can someone please explain what exactly needs to be done here? Thanks, Sandeep ___ Amarok-devel mailing list Amarok-devel@kde.org

Re: Review Request: Add autoscroll function to the lyrics applet.

2011-04-21 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101155/#review2786 --- Didn't test the patch but the concept and code look good. How

Re: Grooveshark service implementation.

2011-04-21 Thread Bart Cerneels
On Thu, Apr 21, 2011 at 13:17, Lydia Pintscher ly...@kde.org wrote: On Thu, Apr 21, 2011 at 07:09, Krzysztof Klinikowski kkszy...@gmail.com wrote: Hello, I don't know how other programmers writting about features that they're coding but here's my: On my spare time I'm working at new

Re: Bug 149453

2011-04-23 Thread Bart Cerneels
On Sat, Apr 23, 2011 at 20:13, sandeep sandy.8...@gmail.com wrote: Hi, I found this : http://www.last.fm/api/show?service=407 which gives details about the artist.getImages function in the last.fm API. It can be used to get artist images but I don't know how it's supposed to be used and

Re: Grooveshark service implementation.

2011-04-26 Thread Bart Cerneels
is bullcrap I think. They're using JavaScript in their web application so anyone could look at their sources. Ads could be blocked too. Most of people doing that. Well, it's sad but we cannot do anything more in that case I think. 2011/4/21 Bart Cerneels bart.cerne...@kde.org On Thu, Apr 21

Re: patch

2011-05-24 Thread Bart Cerneels
On Sun, May 22, 2011 at 12:27, raminder sodhi rjsso...@gmail.com wrote: I was thinking of of a patch in amarok in which we add an auto complete in the address bar used in amarok (beneath the paly/pause button) could somebody guide me for the same. I was thinking of doing the same as dolphin

Re: Review Request: Podcast episode filename configuration

2011-05-25 Thread Bart Cerneels
, 2011, 5:03 p.m.) Review request for Amarok and Bart Cerneels. Summary --- Adds a dialog to configure podcast episode filenames. Added a filenamelayout column to podcastchannels table and a member to PodcastMeta to hold the filename layout. Podcast database version updated

Re: Re: New Dynamic Playlist

2011-06-04 Thread Bart Cerneels
On Sat, Jun 4, 2011 at 19:51, Ralf Engels ralf-eng...@gmx.de wrote: Hi Myriam, Valorie I am wondering. Which of the many improvements suck? - The example biases which demonstrate to a novice user some of the features and are instantly usable? - The removal/merging of the three bias

Re: Review Request: Do not show the OSD if a fullscreen application is active

2011-06-04 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101508/#review3676 --- I think this is a nice feature. I've been starting to QtCreator

Re: Bug Bounty for bug 223400 ipod playlist support

2011-06-09 Thread Bart Cerneels
. - Better looking desktop UI: less gray, more variation in UI surfaces in any color scheme. - Lot's of bugfixes. I'll promise you the donation will go a long way towards a much more enjoyable. Vriendelijke groeten terug ;), Bart Cerneels Limburg, België

Re: Amarok 2.4.1 memory use

2011-06-10 Thread Bart Cerneels
in about 20 minutes. I have to kill it or the machine starts to thrash. I have about 11500 tracks, which I guess is a largish collection? On Fri, Jun 10, 2011 at 01:22, Jerome Yuzyk jer...@supernet.ab.ca wrote: On Thursday, June 09, 2011 02:14:54 AM Bart Cerneels bart.cerne...@kde.org wrote

GSoC:Podcast Synchronization via gpodder.net by Lucas Lira Gomes

2011-06-10 Thread Bart Cerneels
http://www.google-melange.com/gsoc/proposal/review/google/gsoc2011/llg/1 Name:Lucas Lira Gomes Freenode Nick: MaskMaster or MestreArsenal Location(City, Country and Time Zone): Recife, Brazil (GMT -3) E-mail/GTalk:x8luca...@gmail.com Student at UFPE(Federal University of Pernambuco) As you

Re: load own taglib extensions

2011-06-12 Thread Bart Cerneels
On Sun, Jun 12, 2011 at 06:51, Mathias Panzenböck grosser.meister.mo...@gmx.net wrote: Hi. I wrote my own taglib extensions for a few file formats. Is there a clean way to load them into amarok without patching taglib/taglib-extras? Would I have to change amaroks source or can I somehow

Re: Review Request: tag reading support for s3m, it and xm files

2011-06-15 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101598/#review3900 --- Style and logic looks OK to me. I can't comment on the

Re: Amarok mysql database details

2011-06-15 Thread Bart Cerneels
On Wed, Jun 15, 2011 at 16:32, sandeep sandy.8...@gmail.com wrote: Hi, Is there any way to see what tables exist in the embedded database used by Amarok and the columns in those tables? Is it documented? Thanks, Sandeep DatabaseUpdater::createTables() is what you need. It's not better

Re: Review Request: Fix finalization of track copy process to media device collections (#238912)

2011-06-17 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101652/#review3959 --- Ship it! Seems to work. Managed to copy successfully to an

Re: Bug 263640: JJ: moving a music folder, collection won't inform user of stale reference

2011-07-10 Thread Bart Cerneels
On Sun, Jul 10, 2011 at 16:15, Sandeep sandy.8...@gmail.com wrote: Hi, I compiled the GIT version of Amarok and playback does stop after 5 playlist errors. I can have unavailable tracks grayed out like Bart suggested, but if the tracks are unavailable then playback will stop. I think that

Fwd: Rich or plain text?

2011-08-07 Thread Bart Cerneels
More appropriate for the developer list. Most developers don't read the user list as often. -- Forwarded message -- From: Ryan McCoskrie ryan.mccosk...@gmail.com Date: Sat, Aug 6, 2011 at 01:16 Subject: Rich or plain text? To: ama...@kde.org I've just started hacking amarok by

Re: input for next release schedule

2011-08-15 Thread Bart Cerneels
On Sun, Aug 14, 2011 at 13:54, Stefan Derkits ste...@derkits.at wrote: Hey, We should think about the schedule for the next release. Can you please provide input for that in this thread? Also please let people know what was discussed at the BoFs in Berlin during the Desktop Summit. I was

Re: Review Request: Update Amarok to work with Cagibi = 0.2.0 D-BUS API

2011-08-22 Thread Bart Cerneels
request for Amarok and Bart Cerneels. Summary --- Cagibi 0.2.0 changed the D-BUS API including method locations and the return format of deviceDetails. At the same time, since Amarok still has KDE 4.4 as the lowest requirement, Cagibi 0.1.0 compatibility is required. This patch

Re: Review Request: Bug 280382: Unable to add applets to Context View (Wrench is absent when zero applets present)

2011-08-22 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102395/#review5909 --- Ship it! Hah, looks like a stupid little logic bug that does

Re: input for next release schedule

2011-08-25 Thread Bart Cerneels
On Fri, Aug 19, 2011 at 17:35, Lydia Pintscher ly...@kde.org wrote: Thanks for the input so far guys but none of that is entirely helpful in creating the actual schedule. I need to know what people want to work on and how much time you'll need for it roughly. Let's pick this up again. What

Re: Review Request: Enable find as you type support in the playlist

2011-08-26 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102442/#review6023 --- Search-as-you-type is obviously preferred, but it needs to be

Re: Pre dev-days sprint

2011-09-09 Thread Bart Cerneels
I do have something I can work on for Qt at this sprint. But I'm already busy the weekend before the dev-days so can't make it. Hope to be at the devdays itself though. On Fri, Sep 9, 2011 at 12:10, Mark Kretschmann kretschm...@kde.org wrote: Hey guys, this is the latest development regarding

Re: Review Request: Amazon store WIP patch

2011-09-13 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102596/#review6470 --- src/services/amazon/AmazonCollection.h

Re: Review Request: [GSoC] Amarok integration with gpodder.net

2011-09-27 Thread Bart Cerneels
the service is experiencing it's usual overload. - Bart Cerneels On Sept. 24, 2011, 2:25 p.m., Lucas Gomes wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102600

Roktober 2011 is on, want to help?

2011-10-10 Thread Bart Cerneels
Hey, I realized yesterday it's October and as usual we forgot to launch our yearly fundraiser. Want to help out getting this published in a couple of days? http://amarok.kde.org/en/node/836 Bart ___ Amarok-devel mailing list Amarok-devel@kde.org

Re: Review Request: [GSoC] Amarok integration with gpodder.net (Playlist synchronisation stuff)

2011-10-14 Thread Bart Cerneels
. No special cases allowed. Will have to be fixed after committing. - Bart Cerneels On Oct. 13, 2011, 9:25 p.m., Lucas Gomes wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org

Re: Review Request: [GSoC] Amarok integration with gpodder.net (GPodder stuff)

2011-10-14 Thread Bart Cerneels
. - Bart Cerneels On Oct. 13, 2011, 9:25 p.m., Lucas Gomes wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102844

Re: Review Request: Fix iphone 3G handling in amarok

2011-10-17 Thread Bart Cerneels
have an iPhone to test, but I'll check with a regular iPod and see how it integrates with the rest of the media devices. - Bart Cerneels On Oct. 14, 2011, 4:59 p.m., Manu Wagner wrote: --- This is an automatically generated e-mail

Re: Review Request: [GSoC] Amarok integration with gpodder.net (GPodder stuff)

2011-10-17 Thread Bart Cerneels
On Sun, Oct 16, 2011 at 23:25, Lucas Lira Gomes x8luca...@gmail.com wrote: Hi Stefan, Fixed some Stuff (use of #DEFINES instead of constants creation of own nam), but found some serious Problems: Good, but you can't use The::networkAccessManager() as the nam or KDE will keep asking if you

Re: Review Request: [GSoC] Amarok integration with gpodder.net (GPodder stuff)

2011-10-18 Thread Bart Cerneels
On Mon, Oct 17, 2011 at 22:58, Lucas Lira Gomes x8luca...@gmail.com wrote: Hi Stefan, we can do this way, but I think it isn't efficient. We only want to know where we stopped, so there is no need to make more than one episode action. Unless something like play history is a to-do for Amarok

Re: Review Request: iPod connection assistant: rework iPod identification

2011-10-25 Thread Bart Cerneels
for proper iP* detection with the current mediadevice codebase. In the near future (post 2.5 release) we should together try to find a simpler and easier to maintain solution. Commit it now and I'll do some testing later. The patch certainly looks fine. - Bart Cerneels On Oct. 25, 2011, 1:20

Re: Review Request: Done some improvements on Gpodder Service

2011-11-03 Thread Bart Cerneels
be attached to the variable name. src/services/gpodder/GpodderProvider.cpp http://git.reviewboard.kde.org/r/103034/#comment6818 What about the other possible episode actions? I'll take a look at the provider not appearing at runtime, probably a QtGroupingProxy thing. - Bart Cerneels

Re: Review Request: Change misleading/ambiguous message when deleting tracks from collection (bug 263693)

2011-11-03 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103026/#review7895 --- Ship it! Ship It! - Bart Cerneels On Nov. 2, 2011, 1:06 p.m

Re: Review Request: Done some improvements on Gpodder Service

2011-11-04 Thread Bart Cerneels
/103034/ --- (Updated Nov. 4, 2011, 1:27 a.m.) Review request for Amarok, Stefan Derkits and Bart Cerneels. Description --- Done some improvements on GPodder Service. Fixes: * Annoying popup related to KIO (wrapper around

Re: Review Request: Done some improvements on Gpodder Service

2011-11-04 Thread Bart Cerneels
arguments to differentiate them from real functions. Also makes the already very long connect statements slightly less long. No need to change them back, just making my personal preference clear. - Bart Cerneels On Nov. 4, 2011, 1:27 a.m., Lucas Gomes wrote

Re: Review Request: Re-Add old Normal moodbar style

2011-11-04 Thread Bart Cerneels
/r/103036/#comment6827 We should use an Enum here, not hardcoded numerical values. If you add this it's OK to commit. - Bart Cerneels On Nov. 3, 2011, 9:22 p.m., Florian Eßer wrote: --- This is an automatically generated e

Re: Review Request: Re-Add old Normal moodbar style

2011-11-04 Thread Bart Cerneels
On Nov. 4, 2011, 7:43 a.m., Bart Cerneels wrote: src/moodbar/MoodbarManager.cpp, line 337 http://git.reviewboard.kde.org/r/103036/diff/1/?file=40181#file40181line337 We should use an Enum here, not hardcoded numerical values. If you add this it's OK to commit. Has

Re: [amarok] /: Add option to toggle showing of browser background images

2011-11-06 Thread Bart Cerneels
On Sun, Nov 6, 2011 at 13:29, Rick W. Chen stuffcor...@archlinux.us wrote: On 06 Nov 2011 09:22 +0100, Bart Cerneels: Micro option! And as far as I can tell because only one user complained on the forums. Unless Rick has a personal preference. Still, we need to be very hesitant to add micro

Re: [amarok] /: Add option to toggle showing of browser background images

2011-11-07 Thread Bart Cerneels
On Mon, Nov 7, 2011 at 02:58, Rick W. Chen stuffcor...@archlinux.us wrote: On 06 Nov 2011 21:41 +0100, Bart Cerneels: On Sun, Nov 6, 2011 at 13:29, Rick W. Chen stuffcor...@archlinux.us wrote: On 06 Nov 2011 09:22 +0100, Bart Cerneels: Micro option! And as far as I can tell because only one

FYI: Re: Qt 4.8 QUrl.toLocalFile behavior change, impacts to KUrl (and friends)

2011-11-07 Thread Bart Cerneels
We should build with QURL_NO_CAST_FROM_QSTRING in the 2.6 cycle to make sure amarok works correctly with Qt 4.8. On Thu, Oct 27, 2011 at 23:35, Thiago Macieira thi...@kde.org wrote: On Thursday, 27 de October de 2011 23:17:49 Milian Wolff wrote: On Thursday 27 October 2011 21:11:11 Thiago

Re: [amarok] /: Separate delete and trash collection tree actions

2011-11-14 Thread Bart Cerneels
I think this one should be reverted. It adds one more entry in an already long menu (comfortable max is 5). And this creates the possibility of accidental data loss. Preferred fix: delete action on iPod collection. This needs some refactoring I think. On Sat, Nov 12, 2011 at 16:13, Matěj Laitl

Idea for cue-sheet support.

2011-11-25 Thread Bart Cerneels
Hi team, here is a braindump after some chatting with Ralf on IRC. - Detect cue-sheets in collectionscanner, report them as regular playlist files. - SqlScanResultProcessor handles cue sheets different from other playlists. Stores timecoded urls (partial playback) indatabase for each entry. -

[amarok] /: Fix volume control not working.

2011-11-25 Thread Bart Cerneels
Git commit 219298b2481cb228d05f8c963d28b40500ad2507 by Bart Cerneels. Committed on 25/11/2011 at 15:17. Pushed by shanachie into branch 'master'. Fix volume control not working. QA fail: should have been spotted in review and integration testing. CCMAIL:amarok-devel@kde.org M +1-0

Re: Fwd: [LikeBack: Like] #2721 (2.4.90 - fr)

2011-11-28 Thread Bart Cerneels
On Mon, Nov 28, 2011 at 15:25, Mathias Panzenböck grosser.meister.mo...@gmx.net wrote: On 11/28/2011 12:08 PM, Myriam Schweingruber wrote: On Sun, Nov 27, 2011 at 23:35, Mathias Panzenböck grosser.meister.mo...@gmx.net  wrote: PS: Since a while sound stops to work when I pause a song. It

Re: [amarok] /: Now It's possible to use formated strings for prefix and suffix in Playlist's layout items.

2011-11-28 Thread Bart Cerneels
This feature should have waited until after 2.5 release is opened again for new features. New code creates an additional risk of regressions we can do without. If this is just a minimal feature I would like to see it reverted. Bart On Sun, Nov 27, 2011 at 05:57, Sergey Ivanov 123k...@gmail.com

Re: Where to place generic equalizer facilities.

2011-12-04 Thread Bart Cerneels
On Fri, Dec 2, 2011 at 23:53, Ryan McCoskrie ryan.mccosk...@gmail.com wrote: I've been doing some on off work to make some standard functions for scripts and plugins to controll the equalizer through. So far I have been placing all of these in the EngineController class (and giving

Re: Shutdown of V3 of the Echo Nest API is imminent.

2011-12-15 Thread Bart Cerneels
Something for 2.6, if there is a volunteer that is. Any takers? Looks like libechonest is v4 already [1]. Is it source/binary compatible with the earlier v3 supporting lebechonest? [1] https://github.com/echonest/libechonest On Wed, Dec 14, 2011 at 16:27, Leo Franchi lfran...@gmail.com wrote:

Re: Shutdown of V3 of the Echo Nest API is imminent.

2011-12-15 Thread Bart Cerneels
On Thu, Dec 15, 2011 at 12:35, Stefan Derkits ste...@derkits.at wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, On 12/15/2011 10:26 AM, Bart Cerneels wrote: [1] https://github.com/echonest/libechonest this is (at least for our use case) the wrong libechonest (objective-c

Re: Should we support building utilities without building player?

2011-12-20 Thread Bart Cerneels
On Mon, Dec 19, 2011 at 00:15, Matěj Laitl ma...@laitl.cz wrote: Hi amarok-devel, while trying to solve Gentoo bug 390831 [1] I've found that it is currently (master branch) impossible to build Amarok utilities (amarokcollectionscanner and amarok_afttagger) without building the player itself.

Re: [amarok/strohel-for-2.6] src: Get rid of UpdateCapability entirely - it was no longer used

2011-12-20 Thread Bart Cerneels
+1 While I understand there were good arguments made for the use of the rather complicated Capability pattern, it clearly was applied to eagerly. We need to think about code readability (and clarity of architecture) and maintainability for the long run. On Tue, Dec 20, 2011 at 13:09, Matěj Laitl

Re: Request for review: my patch queue for 2.6

2011-12-20 Thread Bart Cerneels
Just make sure you squash the commits that belong together :) And don't forget to Changelog in the same commit! On Tuesday, December 20, 2011, Matěj Laitl ma...@laitl.cz wrote: Hi Amarockers, already annouced on IRC, repeating here: please review strohel-for-2.6 branch [1] that I've pushed to

Amarok out of string freeze, let's plan features

2011-12-21 Thread Bart Cerneels
It took a bit longer then first planned, but 2.5 is now released. Like I mentioned before [1], it would be better for planning and quality if we try to stick to a known list of features or enhancements for each release. So what features do you have planned or would strongly suggest to make it

Re: Request for review: my patch queue for 2.6

2011-12-27 Thread Bart Cerneels
On Sat, Dec 24, 2011 at 15:40, Matěj Laitl ma...@laitl.cz wrote: On 20. 12. 2011 Bart Cerneels wrote: Just make sure you squash the commits that belong together :) Do you mean some specific commits? E.g. there are 3 UpdateCapability removal- related commits, but each one stands on its own

Re: Review Request: Add an absolute date filter

2011-12-27 Thread Bart Cerneels
feature. I have not tested it yet though. How does it integrate with the query editor dialog? - Bart Cerneels On Dec. 26, 2011, 8:50 p.m., Daniel Faust wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: 2.5.0 tarball problems

2011-12-28 Thread Bart Cerneels
This problem sneaked in through auto-generated translations at release time. Most developers are running very recent kdelibs versions (latest stable or even git) and we don't have an automated build testing system to catch these. We do rely on packagers to notify us of problems in their specific

Re: Amarok installer size

2012-01-03 Thread Bart Cerneels
Is this really so important w.r.t. all the other things on the TODO? I would not spend any time on a marginal (1.1/88) reduction of installer size if it take mare then half an hour. We've got plenty of bugs/features/UI improvements to focus on. On Mon, Jan 2, 2012 at 15:51, Sven Krohlas

Re: Bug 290123 - broken context view with KDE 4.8

2012-01-04 Thread Bart Cerneels
How about we just branch of the v2.5.0 tag, which does not have any i18n changes? i.e. make it a real bugfix release. On Tue, Jan 3, 2012 at 16:35, Sven Krohlas s...@asbest-online.de wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Heya, with the release of KDE 4.8 we are going to have

Re: Review request: MemoryMeta changes and new iPod collection

2012-01-11 Thread Bart Cerneels
On Tue, Jan 10, 2012 at 14:55, Matěj Laitl laitl...@fjfi.cvut.cz wrote: Hi list and mainly Bart, please review memorymeta-tweaks branch [1] in my personal git clone which contains changes that I needed for iPod collection rewrite. [1]

Re: Review request: MemoryMeta changes and new iPod collection

2012-01-19 Thread Bart Cerneels
On Tue, Jan 17, 2012 at 00:11, Matěj Laitl ma...@laitl.cz wrote: On 11. 1. 2012 Bart Cerneels wrote: With a small bit of work, UmsCollection could get support for:  * album covers if MetaFile::FileAlbum::{image(),hasImage()} is implemented * compilations if MetaFile::FileAlbum

Re: Review Request: Possibility to give an UMS-Collaction a descriptive name

2012-01-20 Thread Bart Cerneels
minutes. - Bart Cerneels On Jan. 20, 2012, 11:41 a.m., Volker Christian wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103736

Re: Review Request: Fix for bug 289751

2012-01-24 Thread Bart Cerneels
discovered in code review a lot earlier I guess. Will you commit? - Bart Cerneels On Jan. 23, 2012, 9:46 a.m., Volker Christian wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103774

Re: Review Request: Bump the taglib dependency to 1.7

2012-01-24 Thread Bart Cerneels
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103781/#review10068 --- Ship it! Needs to be mentioned in the README as well. - Bart

Re: Review Request: Some changes to make Amarok appearance more pretty

2012-01-30 Thread Bart Cerneels
in the podcast view. - Bart Cerneels On Jan. 29, 2012, 6:42 p.m., Lucas Gomes wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103603

Re: Review Request: Change GUI strings in Configuration dialog to reduce user confusion

2012-02-06 Thread Bart Cerneels
a big implementation detail that should not be expose to the user to me. - Bart Cerneels On Feb. 5, 2012, 11:56 a.m., Matěj Laitl wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r

Re: Incremental scanning

2012-02-06 Thread Bart Cerneels
On Wed, Feb 1, 2012 at 14:31, Ville Ranki ville.ra...@iki.fi wrote: Hello, I've been implementing incremental scanning for Amarok. Reason for this is that with large connection on a slow network share (sftp over ADSL for example) scanning can take hours. Also currently all scanned files

  1   2   3   >