Re: Review Request 127468: Fix for the infinite loop in case a home-burned or old audio CD is inserted

access or should I push this in your name? - Heiko Becker On März 23, 2016, 8:32 nachm., Stefano Pettini wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126682: Replace deprecated ffmpeg 2.x functions.

://git.reviewboard.kde.org/r/126682/. Could you please update the patch if there's something missing or abandon it if that isn't the case. Thank you! - Heiko Becker On Jan. 9, 2016, 7:24 vorm., Diane Trout wrote: > > --- > This is an auto

D13044: Fix build/test on FreeBSD

heikobecker accepted this revision. heikobecker added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D13044 To: tcberner, heikobecker, #freebsd Cc: #amarok, amarok-devel

D13180: Switch to the Attica framework

heikobecker accepted this revision as: heikobecker. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH use-system-attica (branched from master) REVISION DETAIL https://phabricator.kde.org/D13180 To: pino, #amarok, heikobecker Cc: amarok-devel

D10708: New context area

heikobecker added a comment. In D10708#211228 , @malteveerman wrote: > Analyzer should work as well, if you are using the gstreamer phonon backend. Vlc backend doesn't work unfortunately. Ok, I indeed use the vlc backend. REPOSITORY

Re: A proposal to release 2.9

Hello everybody, On 01/26/18 13:45, Matěj Laitl wrote: > Hi Stefano, > I totally agree, 2.9 should be released to push the work done to users. I agree, although I don't really know how adoption by distros will turn out, considering Qt4 is EOL since quite some time, same for KDELibs (although not

D10526: Port core application away from kdelibs4

heikobecker added a comment. In D10526#207631 , @asturmlechner wrote: > fwitw I've build-tested the patch and it builds and starts up fine. Same here, and it also fixes some issues I experienced earlier. REPOSITORY R181 Amarok

D10699: add .arcconfig

heikobecker accepted this revision. heikobecker added a comment. This revision is now accepted and ready to land. This can even go to master. REPOSITORY R181 Amarok BRANCH kf5 REVISION DETAIL https://phabricator.kde.org/D10699 To: kpiwowarski, markey, heikobecker Cc: heikobecker,

D10699: add .arcconfig

This revision was automatically updated to reflect the committed changes. Closed by commit R181:49c6c31638d3: add .arcconfig (authored by kpiwowarski, committed by heikobecker). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10699?vs=27639=27730 REVISION

D10708: New context area

heikobecker added a comment. FWIW: It builds and Albums, Current Track and Lyrics work. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D10708 To: malteveerman, #amarok Cc: heikobecker, #amarok, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar,

Re: Amarok 2.9.0 "Hibernaculum" released

Hi Alex, > I got the source code right away but when I try to build the kf5 branch I > get an error that it can't find FindMygpo-qt5.cmake (I installed > libmygpo-qt5-devel, I'm using Fedora). I searched through my system and > indeed there's no FindMygpo-qt5. Any idea where I can find that file?

kf5 branch merged into master

Hi, as it turns out merging the kf5 branch into master wasn't that difficult after all and so I just pushed it to git.kde.org. This means master is now based on Qt5/KF5. I also created a 2.9 branch earlier for possible bug fixes for 2.9.0. Cheers, Heiko

Re: Amarok 2.9.0 "Hibernaculum" released

On 03/07/18 22:44, Alex Arvelaez wrote: > How do I stop cmake from building the tests? I'm getting an error about > missing libgmock, I tried passing -DKDE4_BUILD_TESTS=OFF to cmake but > it didn't do much. -DBUILD_TESTING=OFF (which is the canonical cmake option for that) Cheers, Heiko

D11239: Fix build with Qt 5.11

heikobecker accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11239 To: arojas, #amarok, heikobecker Cc: nhuisman, paul, yaohanchen, malteveerman, markey, cochise, tbettler, Smar, ricktimmis,

D11169: Another QUrl fix

heikobecker accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11169 To: malteveerman, #amarok, heikobecker Cc: #amarok, nhuisman, paul, yaohanchen, malteveerman, markey, cochise,

D11169: Another QUrl fix

This revision was automatically updated to reflect the committed changes. Closed by commit R181:21e9356387e9: Another QUrl fix (authored by malteveerman, committed by heikobecker). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11169?vs=29061=29288 REVISION

D10924: Disable Discogs and Google cover search temporarily

heikobecker created this revision. heikobecker added a reviewer: Amarok. Restricted Application added a project: Amarok. heikobecker requested review of this revision. REVISION SUMMARY Both are currently broken and and because a release is probably very near disable them for now. REPOSITORY

D10923: Make Webkit optional

heikobecker created this revision. heikobecker added a reviewer: Amarok. Restricted Application added a project: Amarok. heikobecker requested review of this revision. REVISION SUMMARY Qt4Webkit is old, utterly unmaintained and insecure. Quite a number of distros have abandoned it or are in

D10923: Make Webkit optional

heikobecker added a comment. In D10923#215754 , @markey wrote: > Is this patch meant for master? Because the branch is "webkit-optional". Yes, I just had a local branch for arc diff because I have multiple unrelated commits which aren't

Re: Amarok 2.9.0 "Hibernaculum" released

Hello Michał, On 03/08/18 12:57, Michał Zając wrote: > /root/amarok/amarok-2.9.0/src/playlist/proxymodels/SortAlgorithms.cpp: > In member function ‘bool Playlist::multilevelLessThan::operator()(const > QAbstractItemModel*, int, int) const’: >

D11534: Some small changes and fixes

heikobecker added inline comments. INLINE COMMENTS > Logger.h:61 > +template class... FuncArgs> > +void newProgressOperation( KJob *job, const QString , Object > *obj = nullptr, Func slot = nullptr, Qt::ConnectionType type = > Qt::AutoConnection, FuncArgs... args ) > +{

D11710: Workaround for clang bug 23029

This revision was automatically updated to reflect the committed changes. Closed by commit R181:7dc476a2a28a: Workaround for clang bug 23029 (authored by malteveerman, committed by heikobecker). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE

D11710: Workaround for clang bug 23029

heikobecker accepted this revision. heikobecker added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D11710 To: malteveerman, #amarok, heikobecker Cc: heikobecker, #amarok, nhuisman,

D11349: Reactivate wikipedia applet

heikobecker added a comment. The method is only available since kpackage-5.42.0. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D11349 To: malteveerman, #amarok, markey Cc: heikobecker, markey, #amarok, nhuisman, paul, yaohanchen, malteveerman, cochise, tbettler,

Re: A proposal to release 2.9

Hi, On 02/24/18 23:58, Stefano Pettini wrote: > it looks like there's a general agreement on releasing 2.9 from master, > Myriam is also fine with the plan. I said in the past I wanted to do it > but I have no experience and time so if Heiko can do it then I would > prefer this solution. I

D16422: Do not reset equalizer on clicking cancel if equalizer toggle is off.

heikobecker accepted this revision. heikobecker added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D16422 To: elbinp, #amarok, heikobecker Cc: heikobecker, amarok-devel

D16422: Do not reset equalizer on clicking cancel if equalizer toggle is off.

This revision was automatically updated to reflect the committed changes. Closed by commit R181:1049bef08812: Do not reset equalizer on clicking cancel if equalizer toggle is off. (authored by elbinp, committed by heikobecker). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE

D16422: Do not reset equalizer on clicking cancel if equalizer toggle is off.

heikobecker added a comment. I can push it for you, but I need your email address. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D16422 To: elbinp, #amarok, heikobecker Cc: heikobecker, amarok-devel

D15810: Fix a typo in FindMySQL.cmake and add leniency for libmysqld on windows

heikobecker accepted this revision as: heikobecker. heikobecker added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D15810 To: sdepiets, #amarok, heikobecker Cc: #amarok,

D18674: Add missing QStandardPaths to fix build

heikobecker accepted this revision. heikobecker added a comment. Yeah, that didn't happen for me as well, but QSP is actually used (line 75). REPOSITORY R181 Amarok BRANCH buildfix REVISION DETAIL https://phabricator.kde.org/D18674 To: asturmlechner, #amarok, markey, yurchor,

D18671: Fix unnecessary cmake warnings (Qt5_FOUND to FALSE), use QT_REQUIRED_VERSION

heikobecker accepted this revision as: heikobecker. heikobecker added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R181 Amarok BRANCH master REVISION DETAIL https://phabricator.kde.org/D18671 To: asturmlechner, #amarok, markey, heikobecker Cc:

Re: Missing icons outside of DE

Hey, sorry for the late answer. On Dienstag, 30. April 2019 11:37:03 CEST, Bennett Piater wrote: Hi! I'm running Amarok KF5 2.9.7* without DE (i3wm, qt5ct, archlinux). I cannot see most icons, e.g. in the settings menu or top-level library selection. I do see some, such as the play button or

Re: Translations tracking for Amarok 2.8

Hello Luigi, On Sonntag, 17. November 2019 20:05:58 CET, Luigi Toscano wrote: We are still tracking the translations of the last Qt4 Amarok branch (2.9). Can I safely assume that the next version, whenever it happens, will be Qt5-based (master), which means that we can stop tracking that

D24413: Fix Increase/Decrease Volume shortcuts

heikobecker added a comment. In D24413#542042 , @wbauer wrote: > In D24413#542035 , @ognarb wrote: > > > Since the method is only one line long, why not using lambda instead here? > > >

D24817: Restore scripting functionalities and Qt bindings.

heikobecker added a comment. Nice! I don't want to discourage you, but while QtScript is still there it has been deprecated. Perhaps this still makes sense as a intermediate step, but at some point this should be ported to the QJS* classes from Qt5Qml (e.g. like done for kio

D24381: Register Play/Pause as global shortcut again

heikobecker accepted this revision. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24381 To: wbauer, #amarok, schweingruber, heikobecker Cc: schweingruber, amarok-devel, #amarok

D24135: Fix missing directory separators when saving podcasts to disk

heikobecker accepted this revision. heikobecker added a comment. This revision is now accepted and ready to land. Do you have commit access or should I push this for you? REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D24135 To: jyasi, #amarok, heikobecker Cc:

D27369: Fix loading of lyrics from lyrics.wikia.com

This revision was automatically updated to reflect the committed changes. Closed by commit R181:7f966e2a46c9: Fix loading of lyrics from lyrics.wikia.com (authored by pgomes, committed by heikobecker). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE

D27370: Fix metainfo generation for Amarok applets

This revision was automatically updated to reflect the committed changes. Closed by commit R181:7feeea8583fa: Fix metainfo generation for Amarok applets (authored by pgomes, committed by heikobecker). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE

D27371: Fix error of Wikipedia entering in an infinite recursion of page loading

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R181:2084224e4c30: Fix error of Wikipedia entering in an infinite recursion of page loading (authored by pgomes, committed

D27370: Fix metainfo generation for Amarok applets

heikobecker added a comment. If you give me your email address I'll properly set the git authorship information. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D27370 To: pgomes, #amarok, amarok-devel, heikobecker Cc: heikobecker, #amarok, amarok-devel

D24817: Restore scripting functionalities and Qt bindings.

heikobecker requested changes to this revision. heikobecker added a comment. This revision now requires changes to proceed. How are those bindings generated? I assume they change depending on the used Qt version? Could it be feasible to convince cmake to generate them during build time?

D27370: Fix metainfo generation for Amarok applets

heikobecker accepted this revision as: heikobecker. heikobecker added a comment. This revision is now accepted and ready to land. Thanks! Do you have commit access or should I push this for you? REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D27370 To: pgomes,

D13438: Removed obsolete PackagePath role from AppletModel

heikobecker requested changes to this revision. heikobecker added a comment. This revision now requires changes to proceed. I'm sorry for stepping in soo late, but this has really become too huge to review and does multiple things at once. Could you please split it up? I'll push an older

D13438: Removed obsolete PackagePath role from AppletModel

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R181:cc57275e701c: Removed obsolete PackagePath role from AppletModel (authored by malteveerman, committed by

D27369: Fix loading of lyrics from lyrics.wikia.com

heikobecker accepted this revision. This revision is now accepted and ready to land. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D27369 To: pgomes, #amarok, amarok-devel, heikobecker Cc: #amarok, pgomes, amarok-devel

D27371: Fix error of Wikipedia entering in an infinite recursion of page loading

heikobecker added inline comments. INLINE COMMENTS > WikipediaEngine.cpp:496 > query.addQueryItem( QLatin1String("srprop"), QLatin1String("size") ); > -query.addQueryItem( QLatin1String("srredirects"), QString::number(1) ); > +//query.addQueryItem( QLatin1String("srredirects"),

D26008: Include the gmock prefix in the search path

heikobecker added a comment. Herald added a project: Amarok. Herald removed a subscriber: Amarok. e17a38b179197d9afa303de6e254fbc284c5fa9e did something similar, I suppose this can be closed? REPOSITORY R181

Re: New release

Hello Jonathan, On Dienstag, 14. April 2020 12:53:22 CEST, Jonathan Riddell wrote: For KDE neon we're about to move to a new Ubuntu LTS base which seems to have mariadb 10.3 https://launchpad.net/ubuntu/+source/mariadb-10.3 So this should work for us but I don't think the current Amarok master

Re: Move to gitlab?

Hello Pedro, On Dienstag, 14. April 2020 15:49:33 CEST, Pedro de Carvalho Gomes wrote: Thank you and the sysadmins for the move to Gitlab. Is the plan to continue with Phabricator for code review, or will this be moved to Gitlab? I think we can finish the reviews which started on Phabricator

D28593: Fix copying and moving files to collection

heikobecker accepted this revision. heikobecker added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > TokenDropTarget.cpp:211 > > -Q_EMIT changed(); > +emit changed(); > } Any particular reason to change this? Admittedly it doesn't really matter,

D28284: Add FindMariaDB.cmake module and use it if MySQL is not found

heikobecker accepted this revision as: heikobecker. This revision is now accepted and ready to land. REPOSITORY R181 Amarok BRANCH mysqle-split-for-phab REVISION DETAIL https://phabricator.kde.org/D28284 To: asturmlechner, #amarok, heikobecker, wbauer Cc: amarok-devel, vmatare, pgomes,

D28593: Fix copying and moving files to collection

heikobecker added a comment. Oh, and although it was closed because of a missing backtrace it looks like this would fix: https://bugs.kde.org/show_bug.cgi?id=411716 REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D28593 To: pgomes, #amarok, amarok-devel, heikobecker

D27949: Conclude porting of Last.fm to Amarok KF5

heikobecker accepted this revision as: heikobecker. This revision is now accepted and ready to land. REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D27949 To: pgomes, amarok-devel, #amarok, heikobecker Cc: heikobecker, asturmlechner, amarok-devel, #amarok, pgomes,

Re: New release

Hey Pedro and all, On Sonntag, 12. April 2020 09:51:33 CEST, Pedro de Carvalho Gomes wrote: I think the main reason for the delay of a new version is now concluded (or at least in a decent state), which was the port to KF5. There's also one major issue, which is the deprecation of mysql

Re: Move to gitlab?

On Freitag, 27. März 2020 04:09:04 CET, Myriam Schweingruber wrote: Hi Heiko, On Thu, 26 Mar 2020 at 23:53, Heiko Becker wrote: Hello, having asked multiple people for their email addresses and the general awkwardness of arc, I begin to wonder if Amarok should move to gitlab. The move

Announce: Amarok moved to gitlab

Hey, the always helpful sysadmins moved Amarok's repo to gitlab: https://invent.kde.org/kde/amarok That means you'll have to do something like $ git remote set-url --push g...@invent.kde.org:kde/amarok.git Trying to push to git.kde.org:amarok will result in an error. It's still replicated

D28165: Fix compatibility with modern MySQL

This revision was automatically updated to reflect the committed changes. Closed by commit R181:7d8f4bfa8b5d: Fix compatibility with modern MySQL (authored by vmatare, committed by heikobecker). REPOSITORY R181 Amarok CHANGES SINCE LAST UPDATE

Move to gitlab?

Hello, having asked multiple people for their email addresses and the general awkwardness of arc, I begin to wonder if Amarok should move to gitlab. The move will happen anyway at some point, but we could already start now and some projects already have done so: https://invent.kde.org/

D27949: Conclude porting of Last.fm to Amarok KF5

heikobecker added inline comments. INLINE COMMENTS > LastFmServiceConfig.h:37 > +#endif > + > /** Any reason not to use a generated export header for that? REPOSITORY R181 Amarok REVISION DETAIL https://phabricator.kde.org/D27949 To: pgomes, amarok-devel, #amarok Cc: heikobecker,

D28165: Fix compatibility with modern MySQL

heikobecker accepted this revision. heikobecker added a comment. Builds fine here with mariadb and WITH_MYSQL_EMBEDDED=TRUE. I assume you don't have commit access and you'll need somebody to push this patch for you, right? REPOSITORY R181 Amarok REVISION DETAIL

Re: New release

Hey, On Tuesday, 5 May 2020 12:46:07 CEST, Pedro de Carvalho Gomes wrote: Hi Myriam and others, I have pushed the working branch to replace QTScript: https://invent.kde.org/kde/amarok/-/tree/replace_Qtscript_with_QtQml Nice. Sorry, I know I promised to look into that, but even in these

Re: New release

On Wednesday, 6 May 2020 00:45:43 CEST, Heiko Becker wrote: Finally: I strongly agree that we should release an Alpha version as soon as possible. We should just merge the open pull requests, a release it. I know how to create tags and so. But I don't know what version would it be. Nor I am

Move to gitlab?

Hello, having asked multiple people for their email addresses and the general awkwardness of arc, I begin to wonder if Amarok should move to gitlab. The move will happen anyway at some point, but we could already start and some projects already have done so: https://invent.kde.org/ Regards,

Re: Activitifilter for invent notifications

Hi Myriam, hi all, On 11.12.20 12:58, Myriam Schweingruber wrote: Hi all, as you can see here: https://invent.kde.org/sysadmin/activityfilter to get notifications about commits and merge requests directly into this mailing list, we need to

Re: New attempt of an Alpha release

On Monday, 1 February 2021 00:31:01 CET, Heiko Becker wrote: On Sunday, 31 January 2021 23:15:19 CET, Pedro de Carvalho Gomes wrote: I managed to figure out what changed from Kdelibs4 to KF5. I have updated those at release_scripts/RELEASE_HOWTO. Probably there are things I missed, so feel

T14088: Publish amarok-2.9.71.tar.xz

heikobecker added a comment. You can spread https://download.kde.org/unstable/amarok/2.9.71/amarok-2.9.71.tar.xz.mirrorlist as soon as it shows on some mirrors. I took the liberty to publish this, but I can't close the ticket. TASK DETAIL https://phabricator.kde.org/T14088 To:

Re: New attempt of an Alpha release

On Sunday, 31 January 2021 23:15:19 CET, Pedro de Carvalho Gomes wrote: I managed to figure out what changed from Kdelibs4 to KF5. I have updated those at release_scripts/RELEASE_HOWTO. Probably there are things I missed, so feel free to improve it. Up to now I have uploaded to the download

Re: New attempt of an Alpha release

On Wednesday, 3 February 2021 16:56:42 CET, Myriam Schweingruber wrote: Please everyone, have a look at the article on the web page, the draft can be found here: https://amarok.kde.org/en/node/889 Thanks! A few notes: * Not entirely sure how to phrase that best to avoid confusion, but there

Re: New attempt of an Alpha release

Hello Myriam, hello all, On Monday, 1 February 2021 02:26:30 CET, Myriam Schweingruber wrote: Another question: have the translators and distributions been notified? I know it is just an alpha release, but this would at least give them time to prepare for future releases. Was there an embargo

Re: Important: ChangeLog from now on, and some other reminders

On Wednesday, 3 February 2021 17:11:15 CET, Myriam Schweingruber wrote: Hi all, starting from the 2.9.0.71 tag, please use the ChangeLog again for all major changes. It is essential to keep track of feature additions and removals, major commits and changes in the underlying structure (DB

Re: New attempt of an Alpha release

Hi Pedro, do you know how? I noticed that the docs for that mostly speak about KDELibs4 times (which kind of makes sense, considering there wasn't a Qt5/KF5 release yet). If you want I could do the release and update the docs in the process, or if you want to do it yourself put at least the

Re: New attempt of an Alpha release

On Wednesday, 3 February 2021 16:56:42 CET, Myriam Schweingruber wrote: Please everyone, have a look at the article on the web page, the draft can be found here: https://amarok.kde.org/en/node/889 Thanks! A few notes: * Not entirely sure how to phrase that best to avoid confusion, but there