Re: A proposal to release 2.9

2018-01-26 Thread Matěj Laitl
Hi Stefano, I totally agree, 2.9 should be released to push the work done to users. I unfortunately won't find time to do it myself, but: try to start making the release yourself! ;) It should be documented quite well. If you get stuck or need help with particular tasks, speak up on ML (and CC

Re: Review Request 129192: Add namespace to desktop and appdata files

2017-02-23 Thread Matěj Laitl
thinking about value/risk of this change. Pro: according to standards. Con: existing .desktop links may stop working. Has anyone tested this for example with Amarok shortcut in panel, desktop in various DEs? Others, what do you think? - Matěj Laitl On Říj. 16, 2016, 4:12 odp., Luigi Toscano

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Matěj Laitl
> On Říj. 16, 2016, 12:06 odp., Matěj Laitl wrote: > > Looks good, but see one question below. > > > > Also, I wonder what the consequences would be? People loosing custom-set > > file associations? What about shortcuts in panels etc.? I also think MediaPl

Re: Review Request 129055: [amarok] Fixed Space key binded as a global shortcut (which breaks keyboard usage for the session).

2016-10-16 Thread Matěj Laitl
commit access. Since kf5 is a development branch and there are few people to review, feel free to push to it directly unless you explicitly want a review (perhaps for something controversial). - Matěj Laitl On Zář. 27, 2016, 10:13 odp., Alexandr Akulich wrote

Re: Review Request 129192: Add namespace to desktop and appdata files

2016-10-16 Thread Matěj Laitl
least for consistency. - Matěj Laitl On Říj. 15, 2016, 9:44 odp., Luigi Toscano wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 128246: Lyrics browser switched to the same background of the every other context applet

2016-07-11 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128246/#review97291 --- Ship it! Ship It! - Matěj Laitl On Čec. 10, 2016, 11

Re: Review Request 128248: Remove non SSL option for Wikipedia applet

2016-06-20 Thread Matěj Laitl
parate patch. Applies also to the change few lines below. - Matěj Laitl On Čer. 19, 2016, 11:44 dop., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboar

Re: Review Request 128246: Lyrics browser switched to the same background of the every other context applet

2016-06-19 Thread Matěj Laitl
good to me, let's merge this and let wider user base test it. - Matěj Laitl On Čer. 19, 2016, 3:01 dop., Stefano Pettini wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Amarok release (was: Fetching googlemock)

2014-12-14 Thread Matěj Laitl
On 14. 12. 2014 Myriam Schweingruber wrote: Can we please make a release soon, Matěj? That's what I wanted to do for ages, but having a full-time job and furnishing a flat takes more time than I've ever expected. :-| I still plan want to do it, but if someone is faster than me (Ralf?

Re: Fetching googlemock

2014-12-14 Thread Matěj Laitl
On 14. 12. 2014 Konrad Zemek wrote: Git submodule approach looks promising, however I have some concerns: a) this makes test depend on 'your' github repositories; we cannot guarantee they won't go away etc. b) this makes testing Amarok require internet connection, at least initially;

Re: Fetching googlemock

2014-12-14 Thread Matěj Laitl
On 14. 12. 2014 Konrad Zemek wrote: Matěj Laitl wrote: How big is tarballed gtest + gmock? Can we just embed them in our release tarballs? Else we can create something like amarok-testlibs-$version.tar.bz2, but that would be more work and effort. tarred and bzipped, the repos take 588KB

Re: Fetching googlemock

2014-12-13 Thread Matěj Laitl
On 13. 12. 2014 Konrad Zemek wrote: gmock sources are still not packaged by distributions, and compiling Amarok with tests on is still troublesome (I still use a cmake-gui based approach where I manually set paths to my pre-compiled gmock lib, as I outlined in an email some months ago). I

Re: Review Request 120930: Flac and Mp3 modified to FLAC and MP3 on dialog.

2014-11-01 Thread Matěj Laitl
access please push this. (please don't forget BUG, REVIEW, FIXED-IN tags) - Matěj Laitl On Oct. 31, 2014, 11:49 p.m., Duilio Felix wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 120399: Amarok: If waiting on the fadeout to pause, prevent pausing again.

2014-09-28 Thread Matěj Laitl
situation), but perhaps we can do what you envisioned on the bug, i.e. pause instantenously when pause is pressed within pausin fadeout? - Matěj Laitl On Sept. 28, 2014, 2:39 a.m., Martin Lyth wrote: --- This is an automatically generated e

Re: Review Request 118864: Don't prompt the user if the directories are not empty when moving tracks to trash

2014-07-24 Thread Matěj Laitl
the HACKING folder) src/core/collections/CollectionLocation.cpp https://git.reviewboard.kde.org/r/118864/#comment43803 excess whitespace, please remove - Matěj Laitl On July 24, 2014, 4:19 p.m., Robert Marshall wrote

Re: Review Request 119405: Stop passing -std=iso9899:1999 to CMAKE_C_FLAGS.

2014-07-23 Thread Matěj Laitl
have commit access?) - Matěj Laitl On July 22, 2014, 2:32 p.m., Raphael Kubo da Costa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119405

Re: Review Request 119412: Fix the way PHAACG2.py is invoked in the build system.

2014-07-23 Thread Matěj Laitl
was apparently introduced by accident), so thanks for it and ship it! (I haven't tested it, the the diff looks completely fine) - Matěj Laitl On July 22, 2014, 8:20 p.m., Raphael Kubo da Costa wrote: --- This is an automatically

Re: Review Request 119429: Display 'random tracks' rather than 'random songs' in the appropriate bias in a dynamic mode playlist

2014-07-23 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119429/#review62969 --- Ship it! Looks good to me, ship it and thanks. :) - Matěj

Re: Review Request 119429: Display 'random tracks' rather than 'random songs' in the appropriate bias in a dynamic mode playlist

2014-07-23 Thread Matěj Laitl
On July 23, 2014, 5:12 p.m., Matěj Laitl wrote: Looks good to me, ship it and thanks. :) Please don't forget to add relevant tags to commit: REVIEW: ... BUG: ... FIXED-IN: ... - Matěj --- This is an automatically generated e-mail

Re: Amarok v2.8.1

2014-05-09 Thread Matěj Laitl
On Thu, May 8, 2014 at 8:41 PM, Dan Meltzer parallelgrapefr...@gmail.com wrote: Hi Everyone, Hi Dan, first, thanks for all your recent work on Amarok, especially for taking care of review requests and other similar long-overdue taks! I was talking With Mark this morning, and I think it would

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-01-05 Thread Matěj Laitl
for the string - use i18nc() call with context like time format for specifying track length - hours, minutes, seconds 2. respect Amarok coding style - spaces around arguments - Matěj Laitl On Jan. 5, 2014, 11:25 a.m., Abhay Sombanshi wrote

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-01-04 Thread Matěj Laitl
places to match) - Matěj Laitl On Jan. 3, 2014, 6:33 p.m., Abhay Sombanshi wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114752

Re: Review Request 110036: WIP - Simple equalizer scripting

2014-01-03 Thread Matěj Laitl
On July 2, 2013, 12:50 p.m., Mark Kretschmann wrote: Any news on this? Could you please upload the patch again? There has been no feedback for 6 months and I believe this could have been superseded by Scripting GSoC 2013 project - should this be discarded? - Matěj

Re: Review Request 109369: Bug #254404: Copy files to USB storage devices in display order by sorting tracks in CollectionLocation.cpp

2014-01-03 Thread Matěj Laitl
too invasive complication for little gain - it should be discarded unless anybody plans to simplify this. - Matěj Laitl On March 12, 2013, 7:27 p.m., Anmol Ahuja wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 114765: Bug 322016 - Apply button is always enabled in Playlist Layout Editor dialog

2014-01-03 Thread Matěj Laitl
may fix that in a separate review request (not in this one as we want style fixes separate from other fixes) - Matěj Laitl On Dec. 31, 2013, 6:04 p.m., Nilesh Suthar wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 114752: BugFix : 291400 - Maximum allowed length in CollectionBrowser filter dialog

2014-01-03 Thread Matěj Laitl
to top of the cpp file and than use it at appropriate places. This improves maintainability. src/widgets/MetaQueryWidget.cpp https://git.reviewboard.kde.org/r/114752/#comment33328 I suggest to create local variable for the display format for better maintainability. - Matěj Laitl On Dec

Re: Review Request 114736: Bug 299431 The text in the notification area located in the lower left corner is cut when copying several tracks to the collection at the same time.

2014-01-03 Thread Matěj Laitl
around arguments. - Matěj Laitl On Dec. 30, 2013, 7:20 a.m., Nilesh Suthar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114736

Re: Review Request 114563: Make sure not to use video stream when transcoding to Opus

2013-12-20 Thread Matěj Laitl
formats may need a similar option, don't they? - Matěj Laitl On Dec. 20, 2013, 11:06 a.m., Martin Brodbeck wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114563

Re: Review Request 114406: Fetch cover picture from METADATA_BLOCK_PICTURE tag

2013-12-12 Thread Matěj Laitl
comitting, also please add ChangeLog entry: BUG: 328451 FIXED-IN: 2.9 - Matěj Laitl On Dec. 11, 2013, 3:45 p.m., Martin Brodbeck wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114406

Re: Review Request 114282: Make the scripts translatable through KDE translation system

2013-12-07 Thread Matěj Laitl
. - Matěj Laitl On Dec. 7, 2013, 6:06 p.m., Yuri Chornoivan wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114282

Re: Review Request 114282: Make the scripts translatable through KDE translation system

2013-12-07 Thread Matěj Laitl
On Dec. 7, 2013, 6:43 p.m., Matěj Laitl wrote: Good to go from me, given all the circumstances. Please add following tags to the commit message when comitting, also please add a line into Changelog: CCBUG: 305264 FUXED-IN: 2.9 - Matěj

Re: Review Request 114148: Clean up the leftover of strigi removal

2013-11-27 Thread Matěj Laitl
the leftover. - Matěj Laitl On Nov. 27, 2013, 12:02 p.m., Jekyll Wu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114148

Re: Review Request 113389: GSoC 2013 Revamping Scripting - Part 5/6 : Misc shared/

2013-11-17 Thread Matěj Laitl
/#comment31479 why the need for a custom method? - Matěj Laitl On Oct. 22, 2013, 6:06 p.m., Anmol Ahuja wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113389

Re: phonon5 and times

2013-11-14 Thread Matěj Laitl
On 14. 11. 2013 Harald Sitter wrote: for phonon5 we can: a) keep it and rename it to timeUpdateInterval (to align with rename of tick) b) drop the interval; always use =100 msc updates c) drop the interval; always use ~100 msc (if VLC is ticking faster than that we go 100) d) any of b) or

Re: Review Request 113272: GSoC 2013 - Advanced Importers - 1/4: Changes in StatSyncing framework

2013-11-14 Thread Matěj Laitl
indentation - Matěj Laitl On Nov. 6, 2013, 8:19 p.m., Konrad Zemek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113272

Re: Review Request 113277: GSoC 2013 - Advanced Importers - 3/4: Tests for importers framework and concrete importers

2013-11-14 Thread Matěj Laitl
database (hint hint)) - Matěj Laitl On Nov. 6, 2013, 8:24 p.m., Konrad Zemek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113277

Re: Review Request 113777: Lazy load scriptable service tracks

2013-11-10 Thread Matěj Laitl
as it is random otherwise. - Matěj Laitl On Nov. 9, 2013, 10:21 p.m., Anmol Ahuja wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113777

Review Request 113666: GSoC: MTP (Android) Collection Rewrite

2013-11-05 Thread Matěj Laitl
with greater variety of devices needed. Thanks, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 113272: GSoC 2013 - Advanced Importers - 1/4: Changes in StatSyncing framework

2013-11-05 Thread Matěj Laitl
. ReviewBoard fools me (actually rather probable) 3. You uploaded a diff between old part 1 and new part 1, not the complete new part 1. I'm sorry it took too long for me just to realize this. - Matěj Laitl On Oct. 21, 2013, 6:34 p.m., Konrad Zemek wrote

Re: phonon5 and the metadata

2013-11-03 Thread Matěj Laitl
On 2. 11. 2013 Harald Sitter wrote: Strawpoll: What do you prefer? What do you use right now? QStringList Player::metaData(Enum e); or QStringList Player::metaData(QString s); // as per [1] In Amarok we only use (and prefer) metaData(Enum e); feel free to remove the QString one.

Re: Review Request 113057: I am trying to kill Bug 322016 - Apply button is always enabled in Playlist Layout Editor dialog

2013-10-22 Thread Matěj Laitl
On Oct. 2, 2013, 7:34 p.m., Matěj Laitl wrote: Hi, thanks for your patch. Unfortunately, this is not the right approach. Instead of tracking user changes, the logic under apply button should be: 1. watch every state change in the applicable controls and pressing of the apply button

Re: Review Request 113356: GSoC 2013: Revamping Amarok's Scripting Interface

2013-10-22 Thread Matěj Laitl
On Oct. 20, 2013, 3:36 p.m., Matěj Laitl wrote: Thanks for finally posting this patch, please give me a couple of days to review it. I guess this review could be discarded because you've resubmitted it in multiple parts? - Matěj

Re: Review Request 113356: GSoC 2013: Revamping Amarok's Scripting Interface

2013-10-20 Thread Matěj Laitl
of days to review it. - Matěj Laitl On Oct. 20, 2013, 3:13 p.m., Anmol Ahuja wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113356

Re: Review Request 113346: BugFix: 317902 - Issue a warning when transcoding is not possible

2013-10-19 Thread Matěj Laitl
Designer UI) src/transcoding/TranscodingAssistantDialog.ui http://git.reviewboard.kde.org/r/113346/#comment30639 The text could be even more helpful, i.e. tell user what she needs to install (ffmpeg or libav with ffmpeg wrapper). - Matěj Laitl On Oct. 19, 2013, 11:12 a.m., Jai Luthra wrote

Re: Review Request 113346: BugFix: 317902 - Issue a warning when transcoding is not possible

2013-10-19 Thread Matěj Laitl
On Oct. 19, 2013, 7:49 p.m., Matěj Laitl wrote: src/core-impl/collections/support/CollectionLocationDelegateImpl.h, lines 41-42 http://git.reviewboard.kde.org/r/113346/diff/3/?file=203475#file203475line41 TranscodingAssistantDialog knows what encoders are available (see its

Re: Review Request 113346: BugFix: 317902 - Issue a warning when transcoding is not possible

2013-10-19 Thread Matěj Laitl
property, it must be left to default (false) to make this string translatable. - Matěj Laitl On Oct. 19, 2013, 9:48 p.m., Jai Luthra wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Review Request 113272: GSoC 2013 - Advanced Importers - 1/4: Changes in StatSyncing framework

2013-10-17 Thread Matěj Laitl
thanks for splitting it into meaningful pieces, this way it is more manageable. - Matěj Laitl On Oct. 16, 2013, 7:11 p.m., Konrad Zemek wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: GSoC 2013 is over, please merge your code

2013-10-10 Thread Matěj Laitl
On 11. 10. 2013 Myriam Schweingruber wrote: Hi all, congratulations again to all our students for passing GSoC, you did great work! But now it is time to bring in your code from you scratch repo into master. Of course going through reviewboard is not a bad idea, but please, do this ASAP

Re: Review Request 113057: I am trying to kill Bug 322016 - Apply button is always enabled in Playlist Layout Editor dialog

2013-10-02 Thread Matěj Laitl
( settingsDiffer ); where settingsDiffer is a bool with obvious meaning. - Matěj Laitl On Oct. 2, 2013, 7:27 p.m., Ricardo Varas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113057

Re: Changes in GMock

2013-10-01 Thread Matěj Laitl
On 1. 10. 2013 Konrad Zemek wrote: The way I see it, possible solutions are: * go the way of Mir: find sources installed by Kubuntu's package in FindGmock.cmake (in Mir it's FindGtest.cmake) downsides: depends on how distro packages gmock; e.g. Arch has no gmock package in official

Re: MTP gsoc nexus 4 testing

2013-09-29 Thread Matěj Laitl
. Make sure it can be disabled from appearing again with a checkbox. I've added a passive notification, please check that it appears in your case. Matěj Laitl wrote: Bart wrote: I was a bit confused because I didn't see the N4 yet in collection browser while it was shown to be scanning

Re: Review Request 112802: Extend dbus unterface for reading and writing the rating of the current song

2013-09-20 Thread Matěj Laitl
another undocumented ad-hoc method). For writing let's wait for the outcome of the discussion on the MPRIS list. - Matěj Laitl On Sept. 18, 2013, 9:34 p.m., Alex Busenius wrote: --- This is an automatically generated e-mail

Re: Review Request 112815: Properly fix read compilation tag in APE (musepack...) files

2013-09-19 Thread Matěj Laitl
://git.reviewboard.kde.org/r/112815/#comment29769 Shouldn't that be toBool() isCompilation is AFAIK a boolean value. - Matěj Laitl On Sept. 19, 2013, 3:12 p.m., Bruno Léon wrote: --- This is an automatically generated e-mail. To reply, visit: http

Re: Implementing CUE sheet support in Amarok

2013-09-15 Thread Matěj Laitl
On 15. 9. 2013 Abhinandan Ramprasath wrote: Hi, After spending a lot of time staring at the code, I would like to propose the following changes to implement CUE sheet support in Amarok. Most of the necessary CUE decoding and track splitting functions are already available in

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Matěj Laitl
/engines/wikipedia/WikipediaEngine.cpp http://git.reviewboard.kde.org/r/112706/#comment29461 Ditto m_ prefix. src/context/engines/wikipedia/WikipediaEngine.cpp http://git.reviewboard.kde.org/r/112706/#comment29460 I believe this debugging is not needed. - Matěj Laitl On Sept. 12, 2013

Re: Review Request 112706: Allow to use Wikipedia over SSL

2013-09-12 Thread Matěj Laitl
be the default, let's heat those NSA supercomputers a bit. src/context/applets/wikipedia/WikipediaApplet.cpp http://git.reviewboard.kde.org/r/112706/#comment29472 nitpick: spaces 'round args - Matěj Laitl On Sept. 12, 2013, 10:44 p.m., Frank Meerkoetter wrote

Re: Propose: Change behaviour that 'Amarok guesses Album from Filepath if no album-tag is set

2013-09-06 Thread Matěj Laitl
On 6. 9. 2013 Mathias Dietrich wrote: unfortunately, nobody replied to my reminder That's why I needed to create a patch and to opened review request: https://git.reviewboard.kde.org/r/112551/ I have starred it which means that I'll get to review it sooner or later, unfortunately probably

Re: Review Request 112023: Disable move/copy actions for non-writeable UMS collections.

2013-09-01 Thread Matěj Laitl
These fwd-declarations are no longer needed. - Matěj Laitl On Aug. 25, 2013, 11:09 p.m., Frank Meerkoetter wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112023

Re: Review Request 111824: Adds multithreaded transcoding to IpodCollection ie fixes BUG 317093

2013-08-25 Thread Matěj Laitl
On Aug. 25, 2013, 10:47 a.m., Mark Kretschmann wrote: Does anyone here have an actual iDevice for testing this? I'll handle the patch incl. testing, but I'm unfortunately rather time-constrained now, so in the worst case it'll have to wait till the second half of September. Sorry about

Re: Review Request 109369: Bug #254404: Copy files to USB storage devices in display order by sorting tracks in CollectionLocation.cpp

2013-08-25 Thread Matěj Laitl
On Aug. 25, 2013, 10:49 a.m., Mark Kretschmann wrote: What's the current status of this patch? Well, the question is whether we want such big complication of code for little gain. I fear that not, at not least in the current for of the patch. I'd be also against adding another duplicate of

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

2013-08-25 Thread Matěj Laitl
/tag_helpers/APETagHelper.cpp http://git.reviewboard.kde.org/r/112266/#comment28493 Does the spec say what format does disc number has? Perhaps we should be able to read both formats? - Matěj Laitl On Aug. 25, 2013, 1:17 p.m., Bruno Léon wrote

Re: Review Request 112266: Fix reading Album Artist / Compilation / Disc Number in APE tags

2013-08-25 Thread Matěj Laitl
On Aug. 25, 2013, 2:06 p.m., Matěj Laitl wrote: shared/tag_helpers/APETagHelper.cpp, lines 33-37 http://git.reviewboard.kde.org/r/112266/diff/1/?file=184486#file184486line33 Hmm, is there a specification somewhere that says what the proper identifiers are? I fear of backwards

Re: Review Request 112255: UMS: Fix set album cover

2013-08-24 Thread Matěj Laitl
have been left broken for such a long time. - Matěj Laitl On Aug. 25, 2013, 12:11 a.m., Frank Meerkoetter wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112255

Re: BACKPORT keyword

2013-08-18 Thread Matěj Laitl
On 18. 8. 2013 Mark Kretschmann wrote: Heya, I just had a smart idea, which happens rarely enough: If we make commits where we already know that they should be backported later, put the keyword BACKPORT in the commit log. Later when we assemble the stable branch we can then simply grep over

Re: Review Request 112023: Disable move/copy actions for non-writeable UMS collections.

2013-08-17 Thread Matěj Laitl
On Aug. 12, 2013, 6:57 p.m., Matěj Laitl wrote: src/core/collections/Collection.h, lines 125-135 http://git.reviewboard.kde.org/r/112023/diff/1/?file=178093#file178093line125 Hmm, I don't like the combination of 2 bools to signify 3 possible values (because you introduce one

Re: Review Request 110187: Don't communicate with mysql by env vars and autogenerated files

2013-08-16 Thread Matěj Laitl
On Aug. 16, 2013, 9:19 a.m., Mark Kretschmann wrote: What's the status of this patch? Please merge, after testing this locally and resolving the two very minor issues that I and Kondard have found. - Matěj --- This is an

Re: ToolTips and Automatic Formatting

2013-08-16 Thread Matěj Laitl
On 16. 8. 2013 Mark Kretschmann wrote: Heya, as we noticed recently, many of Amarok's ToolTips look very ugly and have readability issues because they are not formatted. Therefore a longer ToolTip is being rendered as one giant long line. The Qt API offers automatic formatting with

Re: Review Request 110920: Fight warnings.

2013-08-15 Thread Matěj Laitl
On July 2, 2013, 12:53 p.m., Matěj Laitl wrote: If it compiles with the const, it cannot hurt, ship it! Albert Astals Cid wrote: Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting? I forgot to commit

Re: Sync Amarok wiki documentation to git before 2.8?

2013-08-14 Thread Matěj Laitl
On 13. 8. 2013 Yuri Chornoivan wrote: написане Tue, 13 Aug 2013 19:08:48 +0300, Matěj Laitl ma...@laitl.cz: Hi Yuri, I'm really close to tagging Amarok 2.8 final. The last thing in my checklist is Amarok Handbook: do you think that syncing the in-progress wiki docs to git before

Sync Amarok wiki documentation to git before 2.8?

2013-08-13 Thread Matěj Laitl
Hi Yuri, I'm really close to tagging Amarok 2.8 final. The last thing in my checklist is Amarok Handbook: do you think that syncing the in-progress wiki docs to git before release is a good idea? (Myriam already said it is okay with her) The thing it that I think that shipping in-progress 2.8

Re: Review Request 111626: Fix Amarok crash with Audio CD inserted

2013-08-12 Thread Matěj Laitl
On July 22, 2013, 2:57 p.m., Lukáš Tinkl wrote: The problem is that udisks2 no longer associates drives with a block device, nothing we can circumvent. Christoph Feck wrote: Does commit b92df276 (Do not clean the cache in UDisks2 backend) work around this udisks2 issue, in other

Re: Review Request 112040: Do not create duplicate UMS collections for encrypted volumes

2013-08-12 Thread Matěj Laitl
, it is best to create a switch()/case with all the variants and no default: label to get notified on new enum values by the compiler in future. - Matěj Laitl On Aug. 12, 2013, 8:44 p.m., Frank Meerkoetter wrote

Re: Review Request 112040: Do not create duplicate UMS collections for encrypted volumes

2013-08-12 Thread Matěj Laitl
nesting, so something like if( !sv ) retrun false; would save you one nesting, which we like. src/core-impl/collections/umscollection/UmsCollection.cpp http://git.reviewboard.kde.org/r/112040/#comment27787 code style nitpick: spaces around args - Matěj Laitl On Aug

Re: Review Request 112040: Do not create duplicate UMS collections for encrypted volumes

2013-08-12 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112040/#review37614 --- Ship it! Yay, ship after 2.8 is tagged! - Matěj Laitl

Re: Triggering Copy to Collection from within a Service

2013-08-09 Thread Matěj Laitl
On 9. 8. 2013 Mark Kretschmann wrote: Heya, the Jamendo service has a Download button that currently triggers the download of a torrent file, and then starts a bittorrent application (if present) to download an album. However, this function uses a deprecated API from Jamendo, and what's

Re: Propose: Change behaviour that 'Amarok guesses Album from Filepath if no album-tag is set

2013-07-30 Thread Matěj Laitl
On 30. 7. 2013 Mathias Dietrich wrote: So what would be the ideal solution for you, in case someone wants to step up and to fix this ? a) In additional checkbox in options which enables / disables this feature b) Change the behaviour to only start guessing when artist, trackname and

Re: Soft/hard dependency requirements post 2.8 - input, please

2013-07-29 Thread Matěj Laitl
On 29. 7. 2013 Myriam Schweingruber wrote: with the GSoC projects we discovered a few dependency requirements that will be necessary. libcdio 0.90 This is usually fine, the distros package the libraries *for us* (applications), not for themselves, so if we declare the dependency in advance

Re: Soft/hard dependency requirements post 2.8 - input, please

2013-07-29 Thread Matěj Laitl
On 29. 7. 2013 0inkane wrote: Hi, as apackager (Chakra) who's subscribed to this mailing list I guess I can help answering your question: libcdio is unfortunately not ABI compatible (I guess you're interested in ABI, not API) Actually not, I assumed ABI incompatibility. What matters here

Re: Review Request 111635: PlaybackConfig: add option whether playback should start on track add

2013-07-27 Thread Matěj Laitl
/diff/ Testing --- Thanks, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 111635: PlaybackConfig: add option whether playback should start on track add

2013-07-25 Thread Matěj Laitl
--- On July 24, 2013, 4:41 p.m., Matěj Laitl wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111635

Re: Review Request 110187: Don't communicate with mysql by env vars and autogenerated files

2013-07-25 Thread Matěj Laitl
. Just one very minor thing down below. src/core-impl/collections/db/sql/mysqlecollection/MySqlEmbeddedStorage.cpp http://git.reviewboard.kde.org/r/110187/#comment26926 I propose moving this just before --default-storage-engine=MyISAM as it was. - Matěj Laitl On July 19

String freeze exception for Amarok (Extragear)

2013-07-24 Thread Matěj Laitl
Hi translators, I'd like to request a string freeze exception (2 new strings) for Amarok. We changed mouse behaviour in 2.8 Beta, but it turned out the change was too drastic for some users, so we decided to introduce an option. The patch is at

Re: Review Request 111635: PlaybackConfig: add option whether playback should start on track add

2013-07-24 Thread Matěj Laitl
://git.reviewboard.kde.org/r/111635/diff/ Testing --- Thanks, Matěj Laitl ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-23 Thread Matěj Laitl
. With uidUrl(), you have much better chance of Playlist::Controller::insertOptioned() will find the original track (from the right collection). - Matěj Laitl On July 23, 2013, 12:36 p.m., Konrad Zemek wrote

Re: Propose: Change behaviour that 'Amarok guesses Album from Filepath if no album-tag is set

2013-07-23 Thread Matěj Laitl
On 23. 7. 2013 Alan Ezust wrote: I really hate it when tags are written to my files by media players if all I am doing is importing and playing the songs. No, you don't understand, Amarok has never written guessed tags to any files (unless you requested that). Amarok merely displays the

Re: Review Request 111655: Reimplement RecentlyPlayedListWidget

2013-07-23 Thread Matěj Laitl
/111655/#comment26887 Nice catch! Please commit this separately right away. - Matěj Laitl On July 23, 2013, 9:21 p.m., Konrad Zemek wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org

Re: Propose: Change behaviour that 'Amarok guesses Album from Filepath if no album-tag is set

2013-07-22 Thread Matěj Laitl
On 22. 7. 2013 Mathias Dietrich wrote: although it did not work in Amarok 2.7.1 and before, we now have the following behavior in Amarok-git, which is according to Matěj no bug and wanted: 1. Collect multiple songs in one folder 2. Ensure that the songs have no album-tag 3. Start Amarok

Re: Review Request 111512: MPRIS2: avoid updating Metadata when between tracks

2013-07-15 Thread Matěj Laitl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111512/#review35987 --- Ship it! Yeah, ship it! - Matěj Laitl On July 15, 2013, 3

Amarok 2.8 Beta Tarballs Available

2013-07-05 Thread Matěj Laitl
sv tr uk zh_CN zh_TW Thanks for packaging, Matěj Laitl on behalf of The Amarok Team signature.asc Description: This is a digitally signed message part. ___ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo

Amarok 2.8 Beta Release

2013-07-05 Thread Matěj Laitl
Hi everybody, I'm happy to let you know that Amarok 2.8 Beta has just been released to the public. This release boasts many improvements all over place, great amount of bug fixes and behaviour corrections. It also should work with KDE 4.11 just fine. Please see

Re: Review Request 110920: Fight warnings.

2013-07-02 Thread Matěj Laitl
it! - Matěj Laitl On June 9, 2013, 9:53 p.m., Wolf-Michael Bolle wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110920

Re: Review Request 111275: putting Artist - Title of the current track to the clipboard using a shortcut

2013-06-30 Thread Matěj Laitl
On June 28, 2013, 6:59 p.m., Mark Kretschmann wrote: Nice patch! I recall we used to have this feature in an earlier Amarok version, but it got lost at some point :) Do you have push rights for kde git, or should we push it for you? fleissig fleissig wrote: I don't have

Re: Review Request 111275: putting Artist - Title of the current track to the clipboard using a shortcut

2013-06-28 Thread Matěj Laitl
: one extra whitespace - Matěj Laitl On June 27, 2013, 9:48 p.m., fleissig fleissig wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111275

Re: Review Request 111275: putting Artist - Title of the current track to the clipboard using a shortcut

2013-06-28 Thread Matěj Laitl
/#comment25827 Oh this is convoluted. What about QString text; Meta::ArtistPtr artist = currentTrack-artist(); if( artist ) text = artist-prettyName() + - ; text += currentTrack-prettyName() clipboard-setText( text ); - Matěj Laitl On June 28, 2013, 9:18

Re: [amarok] /: Make playlist-related actions consistent throughout Amarok code (behaviour change)

2013-06-27 Thread Matěj Laitl
On 27. 6. 2013 Myriam Schweingruber wrote: On Wed, Jun 26, 2013 at 9:34 PM, Matěj Laitl ma...@laitl.cz wrote: Options for the activate (double or single click, per configuration, if we so choose) action; feel free to suggest more: a) append track to playlist and start playing perhaps

[amarok] /: Collection Browser: replace Artist by Album Artist by default

2013-06-27 Thread Matěj Laitl
Git commit 78415dfb1d44c59a0f53748071ce57b794abd83a by Matěj Laitl. Committed on 27/06/2013 at 18:13. Pushed by laitl into branch 'master'. Collection Browser: replace Artist by Album Artist by default CHANGES: * Collection Browser: Artist level was renamed to Track Artist and replaced

Re: Static code analysis available

2013-06-27 Thread Matěj Laitl
On 27. 6. 2013 Mark Kretschmann wrote: Hi all, we have now available static code analysis from two different tools. Both of the tool chains are not yet automated, i.e. not integrated with the CI and updated automatically, but they currently depend on manual uploading of Amarok source tree

[amarok] src/playlist: PlaylistController: revert double-clicking to append start playing if not already

2013-06-26 Thread Matěj Laitl
Git commit a036b39f164ebe8e5060f4ea48bf8854ba6aa87e by Matěj Laitl. Committed on 26/06/2013 at 20:18. Pushed by laitl into branch 'master'. PlaylistController: revert double-clicking to append start playing if not already I dislike this behaviour strongly, but it is fair to level the playing

[amarok] src/browsers: Collection Browser: revert to showing Various Artists even under Artist level [RFC]

2013-06-26 Thread Matěj Laitl
Git commit c336d3777393a177c340f487d14508a6788e519a by Matěj Laitl. Committed on 26/06/2013 at 19:54. Pushed by laitl into branch 'master'. Collection Browser: revert to showing Various Artists even under Artist level [RFC] I don't like this, because it is illogical and shows some of your

Re: Fwd: [amarok] [Bug 321081] Lyrics not fetching for any tracks

2013-06-22 Thread Matěj Laitl
On 18. 6. 2013 Myriam Schweingruber wrote: Subject: [amarok] [Bug 321081] Lyrics not fetching for any tracks https://bugs.kde.org/show_bug.cgi?id=321081 FYI. It is indeed NOT in the list of required dependencies in the README file, we only list the QtScriptgenerator This is fine and

  1   2   3   4   5   6   >