Re: Review Request 129192: Add namespace to desktop and appdata files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/ --- (Updated Feb. 26, 2017, 8:42 p.m.) Status -- This change has been

Re: Review Request 129192: Add namespace to desktop and appdata files

> On Feb. 23, 2017, 1:04 p.m., Matěj Laitl wrote: > > Ah, sorry for inactivity. Issue dropped. > > > > OTOH I'm still thinking about value/risk of this change. Pro: according to > > standards. Con: existing .desktop links may stop working. Has anyone tested > > this for example with Amarok

Re: Review Request 129192: Add namespace to desktop and appdata files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/#review102578 --- Ah, sorry for inactivity. Issue dropped. OTOH I'm still

Re: Review Request 129192: Add namespace to desktop and appdata files

> On Oct. 16, 2016, 12:06 p.m., Matěj Laitl wrote: > > src/CMakeLists.txt, lines 955-958 > > > > > > What about these .desktop files? I seems that these should be moved, > > too, at least for consistency. > >

Re: Review Request 129192: Add namespace to desktop and appdata files

> On Ott. 16, 2016, 12:06 p.m., Matěj Laitl wrote: > > src/CMakeLists.txt, lines 955-958 > > > > > > What about these .desktop files? I seems that these should be moved, > > too, at least for consistency. > >

Re: Review Request 129192: Add namespace to desktop and appdata files

> On Ott. 16, 2016, 11:12 p.m., Matthias Klumpp wrote: > > Please rename the .desktop files too, the name of the .desktop file and the > > value of the `` tag must match for this to work. > > The DBus activation and Wayland window mapping will also only work with the > > renamed .desktop

Re: Review Request 129192: Add namespace to desktop and appdata files

> On Oct. 16, 2016, 9:12 p.m., Matthias Klumpp wrote: > > Please rename the .desktop files too, the name of the .desktop file and the > > value of the `` tag must match for this to work. > > The DBus activation and Wayland window mapping will also only work with the > > renamed .desktop files.

Re: Review Request 129192: Add namespace to desktop and appdata files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/#review100051 --- Please rename the .desktop files too, the name of the

Re: Review Request 129192: Add namespace to desktop and appdata files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/ --- (Updated Ott. 16, 2016, 4:12 p.m.) Review request for Amarok and

Re: Review Request 129192: Add namespace to desktop and appdata files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/ --- (Updated Ott. 16, 2016, 4:10 p.m.) Review request for Amarok and

Re: Review Request 129192: Add namespace to desktop and appdata files

> On Ott. 16, 2016, 12:06 p.m., Matěj Laitl wrote: > > Looks good, but see one question below. > > > > Also, I wonder what the consequences would be? People loosing custom-set > > file associations? What about shortcuts in panels etc.? > > Matěj Laitl wrote: > I also think

Re: Review Request 129192: Add namespace to desktop and appdata files

> On Říj. 16, 2016, 12:06 odp., Matěj Laitl wrote: > > Looks good, but see one question below. > > > > Also, I wonder what the consequences would be? People loosing custom-set > > file associations? What about shortcuts in panels etc.? I also think MediaPlayer2::DesktopEntry() needs to be

Re: Review Request 129192: Add namespace to desktop and appdata files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/#review100035 --- Looks good, but see one question below. Also, I wonder

Review Request 129192: Add namespace to desktop and appdata files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129192/ --- Review request for Amarok. Repository: amarok Description --- -