RE: [PATCH] drm/amdgpu: Estimate RAS reservation when report capacity v2

2024-05-28 Thread Zhou1, Tao
To: amd-gfx@lists.freedesktop.org; Zhou1, Tao > Cc: Zhang, Hawking ; Kuehling, Felix > ; Kasiviswanathan, Harish > > Subject: [PATCH] drm/amdgpu: Estimate RAS reservation when report capacity v2 > > Add estimate of how much vram we need to reserve for RAS when caculating the

RE: [PATCH] drm/amdgpu: Estimate RAS reservation when report capacity

2024-05-27 Thread Zhou1, Tao
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: amd-gfx On Behalf Of Hawking > Zhang > Sent: Tuesday, May 28, 2024 10:21 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhou1, Tao ; Kuehling, Felix > ; Kasiviswanathan, Hari

RE: [PATCH] drm/amdgpu: fix typo in amdgpu_ras_aca_sysfs_read() function

2024-05-27 Thread Zhou1, Tao
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Tao Zhou > -Original Message- > From: Wang, Yang(Kevin) > Sent: Monday, May 27, 2024 3:47 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > ; Chai, Thomas > Subject: [P

RE: [PATCH 1/2] drm/amdgpu: add RAS is_rma flag

2024-05-26 Thread Zhou1, Tao
[AMD Official Use Only - AMD Internal Distribution Only] > -Original Message- > From: Yang, Stanley > Sent: Thursday, May 23, 2024 9:57 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org > Cc: Zhou1, Tao > Subject: RE: [PATCH 1/2] drm/amdgpu: add RAS is_rma flag >

RE: [PATCH] drm/amdgpu: correct hbm field in boot status

2024-05-21 Thread Zhou1, Tao
[AMD Official Use Only - AMD Internal Distribution Only] Reviewed-by: Tao Zhou > -Original Message- > From: Zhang, Hawking > Sent: Tuesday, May 21, 2024 3:12 PM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao > Cc: Zhang, Hawking > Subject: [PATCH] drm/amdgpu:

RE: [PATCH] drm/amdgpu: update type of buf size to u32 for eeprom functions

2024-05-20 Thread Zhou1, Tao
is better, will create a new patch for the purpose. Tao _ From: Zhang, Hawking Sent: Monday, May 20, 2024 11:23 AM To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao Subject: RE: [PATCH] drm/amdgpu: update type

RE: [PATCH 3/3] drm/amdgpu: fix ACA no query result after gpu reset

2024-05-17 Thread Zhou1, Tao
[AMD Official Use Only - AMD Internal Distribution Only] The series is Reviewed-by: Tao Zhou > -Original Message- > From: Wang, Yang(Kevin) > Sent: Friday, May 17, 2024 11:41 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > ; Chai, Thomas &

RE: [PATCH] drm/amdgpu: add ACA error query support for umc_v12_0

2024-04-25 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Wang, Yang(Kevin) > Sent: Wednesday, April 17, 2024 11:10 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > ; Chai, Thomas > Subject: [PATCH] drm/amdgpu: add ACA error query

RE: [PATCH] drm/amdgpu: skip to create ras xxx_err_count node when ACA is enabled

2024-04-25 Thread Zhou1, Tao
April 24, 2024 10:50 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > > Subject: [PATCH] drm/amdgpu: skip to create ras xxx_err_count node when ACA > is enabled > > skip to create 'xxx_err_count' node when ACA is enabled. > > Signed-off-by: Yan

RE: [PATCH 4/4] drm/amdgpu: avoid dump mca bank log muti times during ras ISR

2024-04-25 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Wang, Yang(Kevin) > Sent: Tuesday, April 23, 2024 4:27 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > ; Li, Candice > Subject: [PATCH 4/4] drm/amdgpu: avoid dump mca bank

RE: [PATCH 15/15] drm/amdgpu: Use new interface to reserve bad page

2024-04-22 Thread Zhou1, Tao
[AMD Official Use Only - General] With my concern fixed, the series is: Reviewed-by: Tao Zhou > -Original Message- > From: Chai, Thomas > Sent: Thursday, April 18, 2024 5:35 PM > To: Christian König ; amd- > g...@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, T

RE: [PATCH 10/15] drm/amdgpu: retire bad pages for umc v12_0

2024-04-22 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Chai, Thomas > Sent: Thursday, April 18, 2024 10:59 AM > To: amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; Li, Candice > ; Wang, Yang(Kevin) ; Yang, > Stanley ;

RE: [PATCH] drm/amdgpu: Use driver mode reset for data poison

2024-04-16 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: Hawking Zhang > Sent: Tuesday, April 16, 2024 2:16 PM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao > Cc: Zhang, Hawking > Subject: [PATCH] drm/amdgpu: Use driver mode res

RE: [PATCH] drm/amdgpu: Use driver mode reset for data poison handling

2024-04-15 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: Hawking Zhang > Sent: Tuesday, April 16, 2024 12:34 PM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao > Cc: Zhang, Hawking > Subject: [PATCH] drm/amdgpu: Use driver mode res

RE: [PATCH V2] drm/amdgpu: Fix incorrect return value

2024-04-12 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: Chai, Thomas > Sent: Friday, April 12, 2024 4:56 PM > To: amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; Li, Candice > ; Wang, Yang(Kevin) ; Y

RE: [PATCH] drm/amdgpu: add new aca smu callback func parse_error_code{}

2024-04-11 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Yang > Wang > Sent: Friday, April 12, 2024 10:54 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > ; Wang, Yang(Kevin) > Subject:

RE: [PATCH] drm/amdgpu: Fix incorrect return value

2024-04-08 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Chai, Thomas > Sent: Wednesday, April 3, 2024 3:07 PM > To: amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; Li, Candice > ; Wang, Yang(Kevin) ; Yang, > Stanley ;

RE: [PATCH] drm/amdgpu: Fix incorrect return value

2024-04-08 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Chai, Thomas > Sent: Sunday, April 7, 2024 10:21 AM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Li, Candice > ; Wang, Yang(Kevin) ; Yang, > Stanley > Subject: RE: [PATCH] d

RE: [PATCH] drm/amdgpu: Fix incorrect return value

2024-04-03 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Chai, Thomas > Sent: Wednesday, April 3, 2024 3:07 PM > To: amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; Li, Candice > ; Wang, Yang(Kevin) ; Yang, > Stanley ;

RE: [PATCH] drm/amdgpu: Update EEPROM RAS table for mismatched table version

2024-03-29 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of Candice Li > Sent: Wednesday, March 27, 2024 2:16 PM > To: amd-gfx@lists.freedesktop.org > Cc: Li, Candice > Subject: [PATCH] drm/amdgpu: Update EEPROM RAS table for mismatched table > version > > Update

RE: [PATCH] drm/amdgpu: refine function signature of amdgpu_aca_get_error_data()

2024-03-28 Thread Zhou1, Tao
[AMD Official Use Only - General] I think argument is more proper than signature here, with this fixed, the patch is: Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Yang > Wang > Sent: Thursday, March 28, 2024 1:53 PM > To: amd-gfx@lists.freedesktop.org > Cc:

RE: [PATCH 3/3] drm/amdgpu: make reset method configurable for RAS poison

2024-03-17 Thread Zhou1, Tao
[AMD Official Use Only - General] I can remove the support for SOC15_IH_CLIENTID_VMC from v10, but the reset type should be changed from bool to uint32 for all versions. Regards, Tao > -Original Message- > From: Zhang, Hawking > Sent: Sunday, March 17, 2024 6:10 PM > To

RE: [PATCH] drm/amdgpu: add ras event id support for ACA

2024-03-17 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: Wang, Yang(Kevin) > Sent: Monday, March 18, 2024 10:25 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > ; Wang, Yang(Kevin) > Subject: [PATCH] drm/amd

RE: [PATCH] drm/amdgpu: add ras event id support

2024-03-14 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Yang > Wang > Sent: Thursday, March 14, 2024 4:12 PM > To: amd-gfx@lists.freedesktop.org > Cc: Wang, Yang(Kevin) ; Zhang, Hawking > > Subject: [PATCH] drm/amdgpu: add ras event id

RE: [PATCH 1/5] drm/amdgpu: add new bit definitions for GC 9.0 PROTECTION_FAULT_STATUS

2024-03-10 Thread Zhou1, Tao
[AMD Official Use Only - General] Ping for the series... > -Original Message- > From: Zhou1, Tao > Sent: Friday, February 23, 2024 4:24 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhou1, Tao > Subject: [PATCH 1/5] drm/amdgpu: add new bit defi

RE: [PATCH Review 1/1] drm/amdgpu: Fix ineffective ras_mask settings

2024-02-21 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of > Stanley.Yang > Sent: Wednesday, February 21, 2024 10:27 PM > To: amd-gfx@lists.freedesktop.org > Cc: Yang, Stanley > Subject: [PATCH Review 1/1] drm/amdgpu: Fix ineffective

RE: [PATCH 5/5] drm/amdgpu: skip GFX FED error in page fault handling

2024-02-19 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Monday, February 19, 2024 8:40 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 5/5] drm/amdgpu: skip GFX FED error in page fault handling > > > > On

RE: [PATCH] drm/amdgpu: Do not enable/disable bif ras irq from guest

2024-02-17 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: Zhang, Hawking > Sent: Sunday, February 18, 2024 3:31 PM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yang, > Stanley ; Chai, Thomas > Cc: Zhang, Hawking > Subject: [

RE: [PATCH] drm/amd/pm: Retrieve UMC ODECC error count from aca bank

2024-02-03 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Candice Li > Sent: Friday, February 2, 2024 7:13 PM > To: amd-gfx@lists.freedesktop.org > Cc: Li, Candice > Subject: [PATCH] drm/amd/pm: Retrieve UMC ODECC error count from aca

RE: [PATCH] drm/amdgpu: skip call ras_late_init if ras block is not supported

2024-01-21 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: Wang, Yang(Kevin) > Sent: Monday, January 22, 2024 1:29 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > ; Wang, Yang(Kevin) > Subject: [PATCH]

RE: [PATCH] drm/amdgpu: skip call ras_late_init if ras feature is not enabled

2024-01-18 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: Wang, Yang(Kevin) > Sent: Thursday, January 18, 2024 3:50 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > ; Wang, Yang(Kevin) > Subject: [PATCH]

RE: [PATCH 3/5] drm/amdgpu: Use asynchronous polling to handle umc_v12_0 poisoning

2024-01-17 Thread Zhou1, Tao
[AMD Official Use Only - General] _ From: Chai, Thomas Sent: Thursday, January 18, 2024 11:06 AM To: Zhang, Hawking ; amd-gfx@lists.freedesktop.org Cc: Zhou1, Tao ; Li, Candice ; Wang, Yang(Kevin) ; Yang, Stanley

RE: [PATCH 2/2] update check condition of query for ras page retire

2024-01-17 Thread Zhou1, Tao
[AMD Official Use Only - General] Sure, will revert related patch in the next version. Regards, Tao > -Original Message- > From: Zhang, Hawking > Sent: Wednesday, January 17, 2024 8:09 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org > Cc: Zhou1, Tao > Subje

RE: [PATCH] drm/amdgpu: fix UBSAN array-index-out-of-bounds for ras_block_string[]

2024-01-16 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Yang > Wang > Sent: Tuesday, January 16, 2024 7:02 PM > To: amd-gfx@lists.freedesktop.org > Cc: Wang, Yang(Kevin) ; Zhang, Hawking > > Subject: [PATCH] drm/amdgpu: fix UBSAN

RE: [PATCH] drm/amdgpu: Drop unnecessary sentences about CE and deferred error.

2024-01-03 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Candice Li > Sent: Thursday, January 4, 2024 1:25 PM > To: amd-gfx@lists.freedesktop.org > Cc: Li, Candice > Subject: [PATCH] drm/amdgpu: Drop unnecessary sentences about CE and >

RE: [PATCH] drm/amdgpu: Support poison error injection via ras_ctrl debugfs

2024-01-03 Thread Zhou1, Tao
[AMD Official Use Only - General] Please also update the description of error type in "DOC: AMDGPU RAS debugfs control interface" for ras_debugfs_ctrl_write. With that fixed, the patch is: Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Candice Li > Sent:

RE: [PATCH 05/14] drm/amdgpu: add amdgpu ras aca query interface

2024-01-03 Thread Zhou1, Tao
tures", is there a scenario where the aca flag is a must? Regards, Tao > -Original Message- > From: Zhang, Hawking > Sent: Wednesday, January 3, 2024 8:00 PM > To: Wang, Yang(Kevin) ; amd- > g...@lists.freedesktop.org > Cc: Zhou1, Tao ; Chai, Thomas > Subject: RE: [PATCH 05/14]

RE: [PATCH 3/3] drm/amdgpu: Centralize ras cap query to amdgpu_ras_check_supported

2024-01-02 Thread Zhou1, Tao
[AMD Official Use Only - General] The series is: Reviewed-by: Tao Zhou > -Original Message- > From: Hawking Zhang > Sent: Tuesday, January 2, 2024 10:16 PM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yang, > Stanley ; Wang, Yang(Kevin) > ; Chai, Thomas ; L

RE: [PATCH 3/3] drm/amdgpu: Replace DRM_* with dev_* in amdgpu_psp.c

2024-01-02 Thread Zhou1, Tao
[AMD Official Use Only - General] The series is: Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Hawking > Zhang > Sent: Tuesday, January 2, 2024 11:45 AM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yang, > Stanley ; Wang, Yang(Kevin

RE: [PATCH 3/3] drm/amdgpu: Centralize ras cap query to amdgpu_ras_check_supported

2024-01-02 Thread Zhou1, Tao
[AMD Official Use Only - General] The series is: Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Hawking > Zhang > Sent: Tuesday, January 2, 2024 11:45 AM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yang, > Stanley ; Wang, Yang(Kevin

RE: [PATCH 2/3] drm/amdgpu: Query ras capablity from psp

2024-01-02 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Zhang, Hawking > Sent: Tuesday, January 2, 2024 1:38 PM > To: Wang, Yang(Kevin) ; amd- > g...@lists.freedesktop.org; Zhou1, Tao ; Yang, Stanley > ; Chai, Thomas ; Li, Candice > > Cc: Deucher, Alexan

RE: [PATCH Review V3 1/1] drm/amdgpu: Fix ecc irq enable/disable unpaired

2023-12-21 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of > Stanley.Yang > Sent: Thursday, December 21, 2023 2:05 PM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > Cc: Yang, Stanley > Subject: [PATCH Review V3 1/1] drm/amdgpu:

RE: [PATCH] drm/amdgpu: Drop redundant unsigned >=0 comparision 'amdgpu_gfx_rlc_init_microcode()'

2023-12-21 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Srinivasan > Shanmugam > Sent: Wednesday, December 20, 2023 10:40 PM > To: Deucher, Alexander ; Koenig, Christian > > Cc: SHANMUGAM, SRINIVASAN ; amd- > g...@lists.freedesktop.org

RE: [PATCH] drm/amdgpu: Use kzalloc instead of kmalloc+__GFP_ZERO in amdgpu_ras.c

2023-12-20 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Srinivasan > Shanmugam > Sent: Tuesday, December 19, 2023 10:12 PM > To: Deucher, Alexander ; Koenig, Christian > > Cc: SHANMUGAM, SRINIVASAN ; amd- > g...@lists.freedesktop.org >

RE: [PATCH] drm/amdgpu: handle extra UE register entries for gfx v9_4_3

2023-10-31 Thread Zhou1, Tao
; From: Yang, Stanley > Sent: Tuesday, October 31, 2023 7:02 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhou1, Tao > Subject: RE: [PATCH] drm/amdgpu: handle extra UE register entries for gfx > v9_4_3 > > [AMD Official Use Only - General] > >

RE: [PATCH Review 1/1] drm/amdgpu: Enable mca debug mode mode for apu

2023-10-18 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Stanley.Yang > Sent: Wednesday, October 18, 2023 8:22 PM > To: amd-gfx@lists.freedesktop.org > Cc: Yang, Stanley > Subject: [PATCH Review 1/1] drm/amdgpu: Enable mca debug mode mode for apu [Tao] the

RE: [PATCH Review 1/1] drm/amdgpu: Workaround to skip kiq ring test during ras gpu recovery

2023-10-17 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of > Stanley.Yang > Sent: Tuesday, October 17, 2023 10:37 PM > To: amd-gfx@lists.freedesktop.org > Cc: Yang, Stanley > Subject: [PATCH Review 1/1] drm/amdgpu: Workaround to skip kiq ring test > during ras

Re: [PATCH 4/5] drm/amdgpu: bypass RAS error reset in some conditions

2023-10-13 Thread Zhou1, Tao
by ras fatal error. Regards, Tao From: Zhang, Hawking Sent: Thursday, October 12, 2023 9:14 PM To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org ; Yang, Stanley ; Li, Candice ; Chai, Thomas ; Wang, Yang(Kevin) Subject: RE: [PATCH 4/5] drm/amdgpu: bypass RAS

RE: [PATCH Review 1/1] drm/amdgpu: Fix potential null pointer derefernce

2023-09-27 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of > Stanley.Yang > Sent: Thursday, September 28, 2023 11:46 AM > To: amd-gfx@lists.freedesktop.org > Cc: Yang, Stanley > Subject: [PATCH Review 1/1] drm/amdgpu: Fix potential null

RE: [PATCH Review 1/1] drm/amdgpu: Skip ring test during ras in recovery

2023-09-27 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of > Stanley.Yang > Sent: Thursday, September 28, 2023 11:42 AM > To: amd-gfx@lists.freedesktop.org > Cc: Yang, Stanley > Subject: [PATCH Review 1/1] drm/amdgpu: Skip ring test

RE: [PATCH 3/3] drm/amdgpu: change if condition for bad channel bitmap update

2023-09-19 Thread Zhou1, Tao
[AMD Official Use Only - General] Thanks for catch it, will update the patch. Tao > -Original Message- > From: Wang, Yang(Kevin) > Sent: Tuesday, September 19, 2023 11:34 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang, > Hawking ; Yang, Stanley ; >

RE: [PATCH Review V2 1/1] drm/amdgpu: Fix false positive error log

2023-09-17 Thread Zhou1, Tao
[AMD Official Use Only - General] The update is fine for me, but since "!block_obj || !block_obj->hw_ops" is not considered as error status, can we change the dev_dbg_once to dev_info_once? With that fixed, the patch is: Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On

RE: [PATCH] drm/amdgpu: Correct se_num and reg_inst for gfx v9_4_3 ras counters

2023-09-06 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Hawking > Zhang > Sent: Wednesday, September 6, 2023 6:12 PM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yang, > Stanley ; Li, Candice ; Chai, > Thomas

RE: [PATCH 3/3] drm/amdgpu: Add umc v12_0 ras functions

2023-09-04 Thread Zhou1, Tao
[AMD Official Use Only - General] The series is: Reviewed-by: Tao Zhou > -Original Message- > From: Li, Candice > Sent: Monday, September 4, 2023 3:20 PM > To: amd-gfx@lists.freedesktop.org > Cc: Li, Candice ; Zhou1, Tao > Subject: [PATCH 3/3] drm/amdgpu: Add umc v

RE: [PATCH] drm/amdgpu: Allow issue disable gfx ras cmd to firmware

2023-08-23 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Hawking > Zhang > Sent: Thursday, August 24, 2023 9:49 AM > To: amd-gfx@lists.freedesktop.org; Yang, Stanley ; > Zhou1, Tao > Cc: Zhang, Hawking > Sub

RE: [PATCH] drm/amdgpu: Remove unnecessary ras cap check

2023-08-09 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: Hawking Zhang > Sent: Wednesday, August 9, 2023 7:22 PM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao > Cc: Zhang, Hawking > Subject: [PATCH] drm/amdgpu: Remove unnecessary ras

RE: [PATCH Review 1/1] drm/amdgpu: Check APU flag to disable RAS

2023-07-23 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of > Stanley.Yang > Sent: Friday, July 21, 2023 9:18 PM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; > Zhou1, Tao ; Chai, Thomas ; Li, > Candice

RE: [PATCH 2/2] drm/amdgpu: not update the same version ras ta

2023-07-20 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Chai, Thomas > Sent: Wednesday, July 19, 2023 8:40 PM > To: amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; Li, Candice > ; Yang, Stanley ; Chai, Thomas > > Subj

RE: [PATCH 1/2] drm/amdgpu: add ta initialization failure check condition

2023-07-20 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Chai, Thomas > Sent: Wednesday, July 19, 2023 8:40 PM > To: amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; Li, Candice > ; Yang, Stanley ; Chai, Thomas > > Subj

RE: [PATCH Review V3 2/2] drm/amdgpu: Disable RAS by default on APU flatform

2023-07-13 Thread Zhou1, Tao
[AMD Official Use Only - General] The series is: Reviewed-by: Tao Zhou > -Original Message- > From: Stanley.Yang > Sent: Friday, July 14, 2023 11:42 AM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; > Zhou1, Tao ; Chai, Thomas ; Li, > Candice > Cc: Yan

RE: [PATCH 3/3] drm/amdgpu: Issue ras enable_feature for gfx ip only

2023-07-03 Thread Zhou1, Tao
[AMD Official Use Only - General] The series is: Reviewed-by: Tao Zhou > -Original Message- > From: Zhang, Hawking > Sent: Monday, July 3, 2023 4:56 PM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yang, > Stanley ; Chai, Thomas ; Li, > Candice > Cc: Zhan

RE: [PATCH Review V2 1/1] drm/amdgpu: Remove redundant poison consumption handler function

2023-06-20 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Stanley.Yang > Sent: Monday, June 19, 2023 9:50 PM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; > Zhou1, Tao ; Chai, Thomas > Cc: Yang, Stanley > Subject: [PATCH Review V2 1/1] drm/amdgpu: Re

RE: [PATCH Review 2/2] drm/amdgpu: Add checking mc_vram_size

2023-06-13 Thread Zhou1, Tao
[AMD Official Use Only - General] With my concerns fixed, the series is: Reviewed-by: Tao Zhou > -Original Message- > From: Stanley.Yang > Sent: Tuesday, June 13, 2023 11:53 AM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; > Zhou1, Tao > Cc: Yang, Stanley

RE: [PATCH Review 1/2] drm/amdgpu: Optimze checking ras supported

2023-06-13 Thread Zhou1, Tao
[AMD Official Use Only - General] [Tao] typo in title: Optimze -> Optimize > -Original Message- > From: Stanley.Yang > Sent: Tuesday, June 13, 2023 11:53 AM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking ; > Zhou1, Tao > Cc: Yang, Stanley > Subject: [PATC

RE: [PATCH 2/2] drm/amdgpu: Enable gfx v11_0_3 ras if poison mode is supported

2023-06-12 Thread Zhou1, Tao
[AMD Official Use Only - General] The series is: Reviewed-by: Tao Zhou > -Original Message- > From: Zhang, Hawking > Sent: Sunday, June 11, 2023 6:46 PM > To: amd-gfx@lists.freedesktop.org; Yang, Stanley ; Li, > Candice ; Chai, Thomas ; > Zhou1, Tao > Cc: Zhan

RE: [PATCH 1/2] drm/amdgpu: Only create err_count sysfs when hw_op is supported

2023-06-12 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Zhang, Hawking > Sent: Sunday, June 11, 2023 6:46 PM > To: amd-gfx@lists.freedesktop.org; Yang, Stanley ; Li, > Candice ; Chai, Thomas ; > Zhou1, Tao > Cc: Zhang, Hawking > Subject: [PATCH 1/2]

RE: [PATCH v3 6/6] drm/amdgpu: add RAS POISON interrupt funcs for jpeg_v4_0

2023-05-16 Thread Zhou1, Tao
Horatio ; Xu, Feifei > ; Zhou1, Tao ; Jiang, Sonny > ; Limonciello, Mario ; > Liu, Leo ; Zhang, Hawking > Subject: [PATCH v3 6/6] drm/amdgpu: add RAS POISON interrupt funcs for > jpeg_v4_0 > > Add ras_poison_irq and functions. And fix the amdgpu_irq_put call trace in > jpe

RE: [PATCH v2 1/2] drm/amdgpu: separate ras irq from vcn instance irq for UVD_POISON

2023-05-15 Thread Zhou1, Tao
023 10:28 AM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > ; Xu, Feifei ; Liu, Leo > ; Jiang, Sonny ; Limonciello, Mario > ; Liu, HaoPing (Alan) ; > Zhou, Bob ; Zhang, Horatio ; > Zhang, Hawking > Subject: [PATCH v2 1/2] drm/amdgpu: separ

RE: [PATCH 1/2] drm/amdgpu: fix amdgpu_irq_put call trace in jpeg_v4_0_hw_fini

2023-05-08 Thread Zhou1, Tao
[AMD Official Use Only - General] The series is: Reviewed-by: Tao Zhou > -Original Message- > From: Horatio Zhang > Sent: Monday, May 8, 2023 6:20 PM > To: amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Zhou1, Tao > ; Xu, Feifei ; Liu, Leo > ; Jiang, Sonny ;

RE: [PATCH 2/2] drm/amdgpu: fix amdgpu_irq_put call trace in vcn_v4_0_hw_fini

2023-05-08 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: amd-gfx On Behalf Of Horatio > Zhang > Sent: Monday, May 8, 2023 6:20 PM > To: amd-gfx@lists.freedesktop.org > Cc: Liu, HaoPing (Alan) ; Zhang, Horatio > ; Xu, Feifei ; Zhou1, Tao > ; Jiang, Sonn

RE: [PATCH] drm/amdgpu/gfx: disable cp_ecc_error_irq only when gfx ras is enabled in suspend

2023-05-07 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: Chen, Guchun > Sent: Saturday, May 6, 2023 8:16 PM > To: amd-gfx@lists.freedesktop.org; Deucher, Alexander > ; Zhang, Hawking ; > Lazar, Lijo ; Zhou1, Tao ; Koenig, > Christia

RE: [PATCH] drm/amdgpu: disable sdma ecc irq only when sdma RAS is enabled in suspend

2023-05-06 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: Chen, Guchun > Sent: Saturday, May 6, 2023 5:04 PM > To: amd-gfx@lists.freedesktop.org; Deucher, Alexander > ; Zhang, Hawking ; > Lazar, Lijo ; Zhou1, Tao ; Koenig, > Christia

RE: [PATCH Review 2/2] drm/amdgpu: correct ras enabled flag

2023-04-10 Thread Zhou1, Tao
[AMD Official Use Only - General] The series is: Reviewed-by: Tao Zhou > -Original Message- > From: Stanley.Yang > Sent: Monday, April 10, 2023 7:48 PM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Zhou1, Tao > Cc: Yang, Stanley > Subject: [PATCH R

RE: [PATCH 1/2] drm/amdgpu: optimize redundant code in umc_v8_10

2023-04-03 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Chai, Thomas > Sent: Monday, April 3, 2023 3:00 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org > Cc: Zhang, Hawking ; Li, Candice > ; Yang, Stanley > Subject: RE: [PATCH 1/2] drm/amdgpu: op

RE: [PATCH 1/2] drm/amdgpu: optimize redundant code in umc_v8_10

2023-04-02 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Chai, Thomas > Sent: Monday, April 3, 2023 9:59 AM > To: amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; Li, Candice > ; Yang, Stanley ; Chai, > Thomas > Subj

RE: [PATCH] drm/amdgpu: correct xgmi_wafl block name

2023-03-28 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: Zhang, Hawking > Sent: Tuesday, March 28, 2023 6:50 PM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao > Cc: Zhang, Hawking > Subject: [PATCH] drm/amdgpu: correct xgmi_wafl b

RE: [PATCH] drm/amdgpu: Add fatal error handling in nbio v4_3

2023-03-22 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: Zhang, Hawking > Sent: Thursday, March 23, 2023 10:24 AM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yang, > Stanley ; Li, Candice ; Chai, > Thomas > Cc: Zhang, Hawking &

RE: [PATCH 10/10] drm/amdgpu: drop ras check at asic level for new blocks

2023-03-13 Thread Zhou1, Tao
[AMD Official Use Only - General] The series is: Reviewed-by: Tao Zhou > -Original Message- > From: Zhang, Hawking > Sent: Monday, March 13, 2023 9:44 AM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yang, > Stanley ; Li, Candice ; Chai, > Thomas > Cc: Zhan

RE: [PATCH 01/11] drm/amdgpu: Move jpeg ras block init to ras sw_init

2023-03-05 Thread Zhou1, Tao
> -Original Message- > From: Zhang, Hawking > Sent: Monday, March 6, 2023 10:32 AM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yang, > Stanley ; Li, Candice ; Chai, > Thomas > Cc: Zhang, Hawking > Subject: [PATCH 01/11] drm/amdgpu: Move jpeg ras b

RE: [PATCH] drm/amdgpu: Make umc_v8_10_convert_error_address static and remove unused variable

2023-02-23 Thread Zhou1, Tao
Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Candice > Li > Sent: Friday, February 24, 2023 12:25 PM > To: amd-gfx@lists.freedesktop.org > Cc: Li, Candice > Subject: [PATCH] drm/amdgpu: Make umc_v8_10_convert_error_address static > and remove unused variable

RE: [PATCH 2/2] drm/amdgpu: exclude duplicate pages from UMC RAS UE count

2023-02-21 Thread Zhou1, Tao
Ping... > -Original Message- > From: Zhou1, Tao > Sent: Monday, February 20, 2023 11:17 AM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Yang, Stanley ; Chai, > Thomas ; Li, Candice ; Lazar, > Lijo > Cc: Zhou1, Tao > Subject: [PATCH 2/2] drm/amdg

RE: [PATCH 2/2] drm/amdgpu: add bad_page_threshold check in ras_eeprom_check_err

2023-02-21 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Yang, Stanley > Sent: Tuesday, February 21, 2023 5:34 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang, > Hawking ; Chai, Thomas ; > Li, Candice > Subject: RE: [PATCH 2/2] drm/amdgpu: add bad

RE: [PATCH] drm/amdgpu: don't increase UMC RAS UE count if no new bad page

2023-02-14 Thread Zhou1, Tao
[AMD Official Use Only - General] OK, I'll add a new function to do the check. Tao > -Original Message- > From: Zhang, Hawking > Sent: Tuesday, February 14, 2023 6:03 PM > To: Yang, Stanley ; Zhou1, Tao > ; amd-gfx@lists.freedesktop.org; Chai, Thomas > ; Li, Cand

RE: [PATCH] drm/amdgpu: don't increase UMC RAS UE count if no new bad page

2023-02-13 Thread Zhou1, Tao
> -Original Message- > From: Lazar, Lijo > Sent: Tuesday, February 14, 2023 12:55 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang, > Hawking ; Yang, Stanley > ; Chai, Thomas ; Li, Candice > > Subject: Re: [PATCH] drm/amdgpu: don't increase UMC RAS

RE: [PATCH] drm/amdgpu: don't increase UMC RAS UE count if no new bad page

2023-02-13 Thread Zhou1, Tao
> -Original Message- > From: Lazar, Lijo > Sent: Monday, February 13, 2023 8:38 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang, > Hawking ; Yang, Stanley > ; Chai, Thomas ; Li, Candice > > Subject: Re: [PATCH] drm/amdgpu: don't increase UMC RAS UE co

RE: [PATCH] drm/amdgpu: don't increase UMC RAS UE count if no new bad page

2023-02-13 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Zhang, Hawking > Sent: Friday, February 10, 2023 11:02 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Yang, > Stanley ; Chai, Thomas ; Li, > Candice > Subject: RE: [PATCH] drm/amdgpu: don't incr

RE: [PATCH] drm/amdgpu: allow query error counters for specific IP block

2023-01-03 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: Zhang, Hawking > Sent: Wednesday, January 4, 2023 12:25 AM > To: amd-gfx@lists.freedesktop.org; Zhou1, Tao ; Yang, > Stanley ; Li, Candice ; Chai, > Thomas > Cc: Zhang, Hawking &

RE: [PATCH 2/2] drm/amdgpu: enable RAS poison for VCN 2.6

2022-11-21 Thread Zhou1, Tao
[AMD Official Use Only - General] Ping... > -Original Message- > From: Zhou1, Tao > Sent: Wednesday, November 2, 2022 10:36 AM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Deucher, Alexander > > Cc: Zhou1, Tao ; Lazar, Lijo > Subject: [PATCH 2/2

RE: [PATCH Reivew 1/1] drm/amdgpu: fix use-after-free during gpu recovery

2022-11-20 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of > Stanley.Yang > Sent: Thursday, November 17, 2022 11:01 AM > To: amd-gfx@lists.freedesktop.org > Cc: Wang, YuBiao ; andrey.grodzov...@amd.com; > Yang, Stanley > Subject: [PATCH

RE: [PATCH] drm/amdgpu: Add umc channel index mapping table for umc_v8_10

2022-11-13 Thread Zhou1, Tao
[AMD Official Use Only - General] Reviewed-by: Tao Zhou > -Original Message- > From: Chai, Thomas > Sent: Monday, November 14, 2022 9:52 AM > To: amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; Li, Candice > ; Chai, Thomas &

RE: [PATCH 1/4] drm/amdgpu: add RAS page retirement functions for MCA

2022-10-21 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Zhang, Hawking > Sent: Friday, October 21, 2022 12:15 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Yang, > Stanley ; Chai, Thomas ; Li, > Candice > Subject: RE: [PATCH 1/4] drm/amdgpu: ad

RE: [PATCH 1/4] drm/amdgpu: add RAS page retirement functions for MCA

2022-10-20 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Zhang, Hawking > Sent: Thursday, October 20, 2022 5:13 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Yang, > Stanley ; Chai, Thomas ; Li, > Candice > Subject: RE: [PATCH 1/4] drm/amdgpu: ad

RE: [PATCH 4/4] drm/amdgpu: remove ras_error_status parameter for UMC poison handler

2022-10-20 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Zhang, Hawking > Sent: Thursday, October 20, 2022 5:30 PM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Yang, > Stanley ; Chai, Thomas ; Li, > Candice > Subject: RE: [PATCH 4/4] drm/amdgpu: re

RE: [PATCH 2/2] drm/amdgpu: Add poison mode query for umc v8_10_0

2022-10-10 Thread Zhou1, Tao
[AMD Official Use Only - General] The series is: Reviewed-by: Tao Zhou > -Original Message- > From: amd-gfx On Behalf Of Candice > Li > Sent: Monday, October 10, 2022 2:47 PM > To: amd-gfx@lists.freedesktop.org > Cc: Li, Candice > Subject: [PATCH 2/2] drm/amdgpu: Add poison mode query

RE: [PATCH 1/4] drm/amdgpu: export umc error address translation interface

2022-09-25 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Yang, Stanley > Sent: Monday, September 26, 2022 11:15 AM > To: Zhou1, Tao ; amd-gfx@lists.freedesktop.org; Zhang, > Hawking > Subject: RE: [PATCH 1/4] drm/amdgpu: export umc error address translation >

RE: [PATCH 2/2] drm/amdgpu: add umc ras functions for umc v8_10_0

2022-07-12 Thread Zhou1, Tao
[AMD Official Use Only - General] The series is: Reviewed-by: Tao Zhou > -Original Message- > From: Chai, Thomas > Sent: Wednesday, July 13, 2022 11:25 AM > To: amd-gfx@lists.freedesktop.org > Cc: Chai, Thomas ; Zhang, Hawking > ; Zhou1, Tao ; > Clements, John ;

RE: [PATCH Review v2 2/2] drm/amdgpu: print umc correctable error address

2022-05-24 Thread Zhou1, Tao
> -Original Message- > From: Stanley.Yang > Sent: Tuesday, May 24, 2022 10:31 PM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Zhou1, Tao ; Quan, Evan > ; Lazar, Lijo > Cc: Yang, Stanley > Subject: [PATCH Review v2 2/2] drm/amdgpu: print umc cor

RE: [PATCH Review 2/2] drm/amdgpu: print umc correctable error address

2022-05-23 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Stanley.Yang > Sent: Monday, May 23, 2022 4:17 PM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Zhou1, Tao ; Quan, > Evan ; Lazar, Lijo > Cc: Yang, Stanley > Subject: [PATCH Review 2/

RE: [PATCH Review 1/1] drm/amdgpu: support ras on SRIOV

2022-05-18 Thread Zhou1, Tao
> -Original Message- > From: Stanley.Yang > Sent: Wednesday, May 18, 2022 11:44 PM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Zhou1, Tao > Cc: Yang, Stanley > Subject: [PATCH Review 1/1] drm/amdgpu: support ras on SRIOV > > support umc

RE: [PATCH Review 1/1] drm/amdgpu: support ras on SRIOV

2022-05-18 Thread Zhou1, Tao
[AMD Official Use Only - General] > -Original Message- > From: Stanley.Yang > Sent: Wednesday, May 18, 2022 4:32 PM > To: amd-gfx@lists.freedesktop.org; Zhang, Hawking > ; Zhou1, Tao > Cc: Yang, Stanley > Subject: [PATCH Review 1/1] drm/amdgpu: support ras on S

  1   2   3   4   >