Re: [PATCH] drm/scheduler: add NULL pointer check for run queue (v2)

On 07/16/2018 05:54 PM, Michel Dänzer wrote: On 2018-07-16 11:23 AM, Junwei Zhang wrote: To check rq pointer before adding entity into it. That avoids NULL pointer access in some case. v2: move the check to caller Suggested-by: Christian König Signed-off-by: Junwei Zhang ---

RE: [PATCH 2/2] drm/amdgpu: change ring priority after pushing the job

Reviewed-by: Chunming Zhou for series. -Original Message- From: amd-gfx [mailto:amd-gfx-boun...@lists.freedesktop.org] On Behalf Of Christian K?nig Sent: Monday, July 16, 2018 9:25 PM To: amd-gfx@lists.freedesktop.org Subject: [PATCH 2/2] drm/amdgpu: change ring priority after pushing

[PATCH 1/2] drm/amdgpu: Add kfd2kgd.set_compute_idle interface

This allows automatic switching to the compute power profile depending on compute activity. Signed-off-by: Felix Kuehling Reviewed-by: Eric Huang --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.c| 8 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd.h| 1 +

[PATCH 2/2] drm/amdkfd: Call kfd2kgd.set_compute_idle

User mode queue submissions don't go through KFD. Therefore we don't know exactly when compute is idle or not idle. We use the existence of user mode queues on a device as an approximation. register_process is called when the first queue of a process is created. Conversely unregister_process is

Re: KMS does not work on MSI B350M MORTAR with AMD Ryzen 3 2200g

Dear Alex, Thank you for your response. Am 16.07.2018 um 18:30 schrieb Alex Deucher: On Mon, Jul 16, 2018 at 12:14 PM, Paul Menzel wrote: Dear Linux folks, Trying to boot Debian Buster/testing with Linux 4.16.16 on a MSI B350M MORTAR [1] with a Ryzen 3 2200g and a monitor connected over

[PATCH] drm/amd/display: Fix DP HBR2 Eye Diagram Pattern on Carrizo

From: Hersen Wu [why] dp hbr2 eye diagram pattern for raven asic is not stabled. workaround is to use tp4 pattern. But this should not be applied to asic before raven. [how] add new bool varilable in asic caps. for raven asic, use the workaround. for carrizo, vega, do not use workaround.

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

On Mon, Jul 16, 2018 at 12:05 PM, Michel Dänzer wrote: > On 2018-07-13 08:47 PM, Marek Olšák wrote: >> On Fri, Jul 13, 2018 at 4:28 AM, Michel Dänzer wrote: >>> On 2018-07-12 07:03 PM, Marek Olšák wrote: On Thu, Jul 12, 2018, 3:31 AM Michel Dänzer wrote: > > What is the rationale

Re: dmesg warning during init

Finally was able to reproduce with your commit too (a79a94c676e5b06d43b7b236dbf22b70d2b11b39). It's definitely not 100% triggerable hence my bisect missing it. Tom On 07/16/2018 01:14 PM, Tom St Denis wrote: With the tip of drm-next I get this KASAN immediately. Tom On 07/16/2018 12:40 PM,

Re: dmesg warning during init

With the tip of drm-next I get this KASAN immediately. Tom On 07/16/2018 12:40 PM, Michel Dänzer wrote: On 2018-07-16 06:36 PM, Tom St Denis wrote: Will in a bit.  I'm tracking down a KASAN oops that the tip of drm-next causes with unigine-heaven. Is it different from the one I reported an

Re: dmesg warning during init

Might be though it's definitely a heisenbug since I zeroed in on that commit easily but now I can't reproduce it with 10+ cycles of loading/killing unigine-heaven On 07/16/2018 12:54 PM, Tom St Denis wrote: On 07/16/2018 12:40 PM, Michel Dänzer wrote: On 2018-07-16 06:36 PM, Tom St Denis

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

On Mon, Jul 16, 2018 at 11:25 AM, Takashi Iwai wrote: > On Mon, 16 Jul 2018 17:10:43 +0200, > Harry Wentland wrote: >> >> >> >> On 2018-07-15 10:36 AM, Alex Deucher wrote: >> > On Sat, Jul 14, 2018 at 12:31 PM, Takashi Iwai wrote: >> >> On Sat, 14 Jul 2018 14:03:26 +0200, >> >> jimqu wrote: >>

Re: dmesg warning during init

On 07/16/2018 12:40 PM, Michel Dänzer wrote: On 2018-07-16 06:36 PM, Tom St Denis wrote: Will in a bit.  I'm tracking down a KASAN oops that the tip of drm-next causes with unigine-heaven. Is it different from the one I reported an hour ago?

Re: dmesg warning during init

On 2018-07-16 06:36 PM, Tom St Denis wrote: > Will in a bit.  I'm tracking down a KASAN oops that the tip of drm-next > causes with unigine-heaven. Is it different from the one I reported an hour ago? https://lists.freedesktop.org/archives/amd-gfx/2018-July/024207.html -- Earthling Michel

Re: dmesg warning during init

Will in a bit. I'm tracking down a KASAN oops that the tip of drm-next causes with unigine-heaven. (geez, on vacation for a week and my Raven is suffering hehehehehe) Tom On 07/16/2018 12:35 PM, Michel Dänzer wrote: On 2018-07-16 05:55 PM, Tom St Denis wrote: I have the same now and get

Re: dmesg warning during init

On 2018-07-16 05:55 PM, Tom St Denis wrote: > I have the same now and get the attached dmesg. Still all question marks. :( Anyway, looks like it's probably from ttm_bo_delayed_delete, but that still doesn't tell us where the BO is really freed from. Can you try the attached patch and see if the

Re: KMS does not work on MSI B350M MORTAR with AMD Ryzen 3 2200g

On Mon, Jul 16, 2018 at 12:14 PM, Paul Menzel wrote: > Dear Linux folks, > > > Trying to boot Debian Buster/testing with Linux 4.16.16 on a MSI B350M MORTAR > [1] > with a Ryzen 3 2200g and a monitor connected over HDMI, when kernel mode > setting > (KMS) is enabled the monitor does not receive

Re: Error on boot with Raven Ridge

Yep, https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-drm-next On Mon, Jul 16, 2018 at 12:32 PM Harry Wentland wrote: > What kernel are you running? amd-staging-drm-next? > > Harry > > On 2018-07-15 07:02 PM, Bráulio Bhavamitra wrote: > > Although it is reported on dmesg, the system

Re: [PATCH 1/4] drm/amdgpu/pp/smu7: use a local variable for toc indexing

Series is: Reviewed-by: Rex Zhumailto:re...@amd.com>> Best Regards Rex ?? Outlook for Android From: amd-gfx on behalf of Alex Deucher Sent: Thursday, July 12, 2018 10:39:38 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher,

Re: [PATCH libdrm] amdgpu: add amdgpu_bo_handle_type_kms_noimport

On 2018-07-13 08:47 PM, Marek Olšák wrote: > On Fri, Jul 13, 2018 at 4:28 AM, Michel Dänzer wrote: >> On 2018-07-12 07:03 PM, Marek Olšák wrote: >>> On Thu, Jul 12, 2018, 3:31 AM Michel Dänzer wrote: What is the rationale for this? I.e. why do you want to not store some handles in

Re: dmesg warning during init

I have the same now and get the attached dmesg. Tom On 07/16/2018 10:25 AM, Michel Dänzer wrote: On 2018-07-16 02:10 PM, Tom St Denis wrote: Hi all, Back from vacation, booting up the latest drm-next kernel and noticed this warning on boot. Attached. I like the comment in the commit

Re: [PATCH 3/3] drm/amdgpu/pp: switch smu callback type for get_argument()

Series is: Reviewed-by: Rex Zhumailto:re...@amd.com>> Best Regards Rex ?? Outlook for Android From: amd-gfx on behalf of Alex Deucher Sent: Friday, July 13, 2018 4:23:06 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander

Re: [PATCH 6/7] drm/amdgpu: remove job->adev

On 2018-07-13 05:19 PM, Christian König wrote: > We can get that from the ring. > > Signed-off-by: Christian König This change introduced the attached oops when running the piglit max-texture-size test, after which the test process hangs. Note that the test always triggers the out of memory

Re: Error on boot with Raven Ridge

What kernel are you running? amd-staging-drm-next? Harry On 2018-07-15 07:02 PM, Bráulio Bhavamitra wrote: > Although it is reported on dmesg, the system still boots normally > > [    8.253073] amdgpu: [powerplay] dpm has been enabled > [    8.253210] [drm] DM_PPLIB:   40 in kHz > [   

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

On Mon, 16 Jul 2018 17:10:43 +0200, Harry Wentland wrote: > > > > On 2018-07-15 10:36 AM, Alex Deucher wrote: > > On Sat, Jul 14, 2018 at 12:31 PM, Takashi Iwai wrote: > >> On Sat, 14 Jul 2018 14:03:26 +0200, > >> jimqu wrote: > >>> > >>> > >>> > >>> 在 2018/7/13 23:07, Takashi Iwai 写道: >

Re: 答复: 答复: [alsa-devel] 答复: [PATCH] vgaswitchroo: set audio client id according to bound gpu client id

On 2018-07-15 10:36 AM, Alex Deucher wrote: > On Sat, Jul 14, 2018 at 12:31 PM, Takashi Iwai wrote: >> On Sat, 14 Jul 2018 14:03:26 +0200, >> jimqu wrote: >>> >>> >>> >>> 在 2018/7/13 23:07, Takashi Iwai 写道: On Wed, 11 Jul 2018 13:12:01 +0200, Takashi Iwai wrote: > And the forced

Re: [alsa-devel] [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

On Mon, Jul 16, 2018 at 04:47:11PM +0200, Takashi Iwai wrote: > On Mon, 16 Jul 2018 16:43:42 +0200, > Lukas Wunner wrote: > > > > On Mon, Jul 16, 2018 at 02:06:35PM +0800, Jim Qu wrote: > > > + > > > + list_for_each_entry(client, _priv.clients, list) { > > > + if (!client_is_audio(client)

Re: [alsa-devel] [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

On Mon, Jul 16, 2018 at 02:06:35PM +0800, Jim Qu wrote: > + > + list_for_each_entry(client, _priv.clients, list) { > + if (!client_is_audio(client) || client_id(client) != > + VGA_SWITCHEROO_UNKNOWN_ID) Don't you have to check for client_id(client) !=

Re: [alsa-devel] [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

On Mon, 16 Jul 2018 16:43:42 +0200, Lukas Wunner wrote: > > On Mon, Jul 16, 2018 at 02:06:35PM +0800, Jim Qu wrote: > > + > > + list_for_each_entry(client, _priv.clients, list) { > > + if (!client_is_audio(client) || client_id(client) != > > +

Re: [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

在 2018/7/16 22:02, Lukas Wunner 写道: On Sat, Jul 14, 2018 at 02:15:24PM +0800, jimqu wrote: ??? 2018/7/13 17:27, Lukas Wunner ??: On Fri, Jul 13, 2018 at 04:06:02PM +0800, Jim Qu wrote: On modern laptop, there are more and more platforms have two GPUs, and each of them maybe have audio

Re: dmesg warning during init

Am 16.07.2018 um 16:25 schrieb Michel Dänzer: On 2018-07-16 02:10 PM, Tom St Denis wrote: Hi all, Back from vacation, booting up the latest drm-next kernel and noticed this warning on boot. Attached. I like the comment in the commit 5c200f56506a142451f17dbea7befa76dd74a942: "This shouldn't

Re: dmesg warning during init

On 2018-07-16 02:10 PM, Tom St Denis wrote: > Hi all, > > Back from vacation, booting up the latest drm-next kernel and noticed > this warning on boot. Attached. > > I like the comment in the commit 5c200f56506a142451f17dbea7befa76dd74a942: > > "This shouldn't happen, but if it does, we'll get

Re: [PATCH 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

On Sat, Jul 14, 2018 at 02:15:24PM +0800, jimqu wrote: > ??? 2018/7/13 17:27, Lukas Wunner ??: > >On Fri, Jul 13, 2018 at 04:06:02PM +0800, Jim Qu wrote: > >>On modern laptop, there are more and more platforms > >>have two GPUs, and each of them maybe have audio codec > >>for HDMP/DP output.

[PATCH 2/2] drm/amdgpu: change ring priority after pushing the job

Pushing a job can change the ring assignment of an entity. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 4 +++- drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 6 -- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git

[PATCH 1/2] drm/amdgpu: allow for more flexible priority handling

Allow to call amdgpu_ring_priority_get() after pushing the ring to the scheduler. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c

Re: [V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

On Mon, 16 Jul 2018 08:06:35 +0200, Jim Qu wrote: > > On modern laptop, there are more and more platforms > have two GPUs, and each of them maybe have audio codec > for HDMP/DP output. For some dGPU which is no output, > audio codec usually is disabled. > > In currect HDA audio driver, it will

Re: [V2 1/2] ALSA: HDA: use PCI_BASE_CLASS_DISPLAY to replace PCI_CLASS_DISPLAY_VGA

On Mon, 16 Jul 2018 08:06:34 +0200, Jim Qu wrote: > > Except PCI_CLASS_DISPLAY_VGA, some PCI class is sometimes > PCI_CLASS_DISPLAY_3D or PCI_CLASS_DISPLAY_OTHER. > > Signed-off-by: Jim Qu Applied this one now, as it's basically an individual fix. thanks, Takashi

dmesg warning during init

Hi all, Back from vacation, booting up the latest drm-next kernel and noticed this warning on boot. Attached. I like the comment in the commit 5c200f56506a142451f17dbea7befa76dd74a942: "This shouldn't happen, but if it does, we'll get a backtrace of the caller, and update the pin_size values

[PATCH] mm, oom: distinguish blockable mode for mmu notifiers

From: Michal Hocko There are several blockable mmu notifiers which might sleep in mmu_notifier_invalidate_range_start and that is a problem for the oom_reaper because it needs to guarantee a forward progress so it cannot depend on any sleepable locks. Currently we simply back off and mark an

Re: [PATCH] drm/scheduler: add NULL pointer check for run queue (v2)

On 2018-07-16 11:23 AM, Junwei Zhang wrote: > To check rq pointer before adding entity into it. > That avoids NULL pointer access in some case. > > v2: move the check to caller > > Suggested-by: Christian König > Signed-off-by: Junwei Zhang > --- > drivers/gpu/drm/scheduler/gpu_scheduler.c |

Re: [PATCH] drm/scheduler: add NULL pointer check for run queue (v2)

Am 16.07.2018 um 11:23 schrieb Junwei Zhang: To check rq pointer before adding entity into it. That avoids NULL pointer access in some case. v2: move the check to caller Suggested-by: Christian König Signed-off-by: Junwei Zhang Reviewed-by: Christian König ---

[PATCH] drm/scheduler: add NULL pointer check for run queue (v2)

To check rq pointer before adding entity into it. That avoids NULL pointer access in some case. v2: move the check to caller Suggested-by: Christian König Signed-off-by: Junwei Zhang --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 5 + 1 file changed, 5 insertions(+) diff --git

Re: [PATCH] drm/scheduler: add NULL pointer check for run queue

On 07/16/2018 05:11 PM, Christian König wrote: Am 16.07.2018 um 11:01 schrieb Zhang, Jerry (Junwei): On 07/16/2018 04:31 PM, Christian König wrote: Am 16.07.2018 um 04:59 schrieb Junwei Zhang: To check rq pointer before adding entity into it. That avoids NULL pointer access in some case.

Re: [PATCH] drm/scheduler: add NULL pointer check for run queue

Am 16.07.2018 um 11:01 schrieb Zhang, Jerry (Junwei): On 07/16/2018 04:31 PM, Christian König wrote: Am 16.07.2018 um 04:59 schrieb Junwei Zhang: To check rq pointer before adding entity into it. That avoids NULL pointer access in some case. Suggested-by: Christian König Signed-off-by:

Re: [PATCH] drm/scheduler: add NULL pointer check for run queue

On 07/16/2018 04:31 PM, Christian König wrote: Am 16.07.2018 um 04:59 schrieb Junwei Zhang: To check rq pointer before adding entity into it. That avoids NULL pointer access in some case. Suggested-by: Christian König Signed-off-by: Junwei Zhang ---

Re: [PATCH] drm/scheduler: add NULL pointer check for run queue

Am 16.07.2018 um 04:59 schrieb Junwei Zhang: To check rq pointer before adding entity into it. That avoids NULL pointer access in some case. Suggested-by: Christian König Signed-off-by: Junwei Zhang --- drivers/gpu/drm/scheduler/gpu_scheduler.c | 4 1 file changed, 4 insertions(+)

Re: Crash report from dmesg after suspend/resume

Yeah, known issue, patch is on the mailing list. Regards, Christian. Am 16.07.2018 um 00:59 schrieb Bráulio Bhavamitra: Everything still works. [36725.271678] BUG: unable to handle kernel NULL pointer dereference at [36725.271688] PGD 0 P4D 0 [36725.271697] Oops: 0002 [#1]

Re: [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

On Tue, Jul 10, 2018 at 04:14:10PM +0200, Michal Hocko wrote: > On Tue 10-07-18 16:40:40, Leon Romanovsky wrote: > > On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > > > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > > > This is the v2 of RFC based on the feedback I've received

[V2 2/2] vgaswitchreoo: set audio client id in vgaswitchreoo enable function

On modern laptop, there are more and more platforms have two GPUs, and each of them maybe have audio codec for HDMP/DP output. For some dGPU which is no output, audio codec usually is disabled. In currect HDA audio driver, it will set all codec as VGA_SWITCHEROO_DIS, the audio which is binded to

[V2 1/2] ALSA: HDA: use PCI_BASE_CLASS_DISPLAY to replace PCI_CLASS_DISPLAY_VGA

Except PCI_CLASS_DISPLAY_VGA, some PCI class is sometimes PCI_CLASS_DISPLAY_3D or PCI_CLASS_DISPLAY_OTHER. Signed-off-by: Jim Qu --- sound/pci/hda/hda_intel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c index