Re: [PATCH] drm/amdgpu: use spin_lock_irqsave to avoid deadlock by local interrupt

2022-01-10 Thread Deucher, Alexander
[AMD Official Use Only] Acked-by: Alex Deucher From: Chen, Guchun Sent: Monday, January 10, 2022 12:13 AM To: amd-gfx@lists.freedesktop.org ; Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; Zytaruk, Kelly ; Huang, Qiliang (Warden) ; Zhang, Bokun Cc

Re: [PATCH] drm/amd/amdgpu: Add pcie indirect support to amdgpu_mm_wreg_mmio_rlc()

2022-01-07 Thread Deucher, Alexander
[AMD Official Use Only] Acked-by: Alex Deucher From: amd-gfx on behalf of Tom St Denis Sent: Friday, January 7, 2022 7:07 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom Subject: [PATCH] drm/amd/amdgpu: Add pcie indirect support to

RE: [PATCH v2] drm/amdgpu: Enable second VCN for certain Navy Flounder.

2022-01-06 Thread Deucher, Alexander
[Public] > -Original Message- > From: amd-gfx On Behalf Of > Peng Ju Zhou > Sent: Thursday, January 6, 2022 2:30 AM > To: amd-gfx@lists.freedesktop.org > Subject: [PATCH v2] drm/amdgpu: Enable second VCN for certain Navy > Flounder. > > Certain Navy Flounder cards have 2 VCNs, enable

RE: [PATCH] drm/amdgpu: Use correct VIEWPORT_DIMENSION for DCN2

2022-01-06 Thread Deucher, Alexander
[Public] > -Original Message- > From: amd-gfx On Behalf Of > Harry Wentland > Sent: Wednesday, January 5, 2022 3:39 PM > To: amd-gfx@lists.freedesktop.org; Koenig, Christian > ; Lee, Becle ; Huang, > Rex ; Huang, Ray > Cc: Wentland, Harry > Subject: [PATCH] drm/amdgpu: Use correct

Re: [PATCH 2/2] drm/amdgpu: don't set s3 and s0ix at the same time

2022-01-04 Thread Deucher, Alexander
[AMD Official Use Only] I don't think this will work properly. The in_s3 flag was mainly for runtime pm vs system suspend. I'm not sure if in_s0ix is properly handled everywhere we check in_s3. Alex From: amd-gfx on behalf of Mario Limonciello Sent:

Re: [PATCH 1/2] drm/amdgpu: explicitly check for s0ix when evicting resources

2022-01-04 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Mario Limonciello Sent: Monday, January 3, 2022 10:23 AM To: amd-gfx@lists.freedesktop.org Cc: Limonciello, Mario Subject: [PATCH 1/2] drm/amdgpu: explicitly check for s0ix when evicting

RE: Expecting to revert commit 55285e21f045 "fbdev/efifb: Release PCI device ..."

2021-12-21 Thread Deucher, Alexander
[Public] > -Original Message- > From: Deucher, Alexander > Sent: Tuesday, December 21, 2021 12:01 PM > To: Linus Torvalds ; Imre Deak > ; amd-gfx@lists.freedesktop.org > Cc: Daniel Vetter ; Kai-Heng Feng > > Subject: RE: Expecting to revert commit 55285e21f045 &qu

RE: Expecting to revert commit 55285e21f045 "fbdev/efifb: Release PCI device ..."

2021-12-21 Thread Deucher, Alexander
[Public] > -Original Message- > From: Linus Torvalds > Sent: Monday, December 20, 2021 5:21 PM > To: Imre Deak ; Koenig, Christian > ; Pan, Xinhui ; > Wentland, Harry > Cc: Daniel Vetter ; Deucher, Alexander > ; Kai-Heng Feng > ; amd-gfx list g...@lists.fre

RE: Expecting to revert commit 55285e21f045 "fbdev/efifb: Release PCI device ..."

2021-12-21 Thread Deucher, Alexander
[Public] > -Original Message- > From: Linus Torvalds > Sent: Monday, December 20, 2021 5:05 PM > To: Imre Deak > Cc: Daniel Vetter ; Deucher, Alexander > ; Kai-Heng Feng > > Subject: Re: Expecting to revert commit 55285e21f045 "fbdev/efifb: Release > PCI

Re: [PATCH 10/19] drm/amd/display: Changed pipe split policy to allow for multi-display pipe split

2021-12-17 Thread Deucher, Alexander
[AMD Official Use Only] Maybe add Bug links for: https://gitlab.freedesktop.org/drm/amd/-/issues/1522 https://gitlab.freedesktop.org/drm/amd/-/issues/1709 https://gitlab.freedesktop.org/drm/amd/-/issues/1655 https://gitlab.freedesktop.org/drm/amd/-/issues/1403

Re: [PATCH 4/4] drm/amdgpu: Access the FRU on Aldebaran

2021-12-17 Thread Deucher, Alexander
[AMD Official Use Only] Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Kent Russell Sent: Friday, December 17, 2021 10:31 AM To: amd-gfx@lists.freedesktop.org Cc: Russell, Kent Subject: [PATCH 4/4] drm/amdgpu: Access the FRU on Aldebaran

Re: [PATCH] drm/amdgpu: Try To using WARN() instead BUG() avoid kernel panic

2021-12-17 Thread Deucher, Alexander
[Public] I think these are pretty fundamental errors. You should never hit them in practice and if you do, I think a BUG is fine. Alex From: ZhiJie.Zhang Sent: Thursday, December 16, 2021 9:38 PM To: Koenig, Christian ; Deucher, Alexander ; amd-gfx

Re: [PATCH 4/5] drm/amdgpu: Initialize Aldebaran RLC function pointers

2021-12-16 Thread Deucher, Alexander
[Public] If it needs to be in drm-next, please make sure it lands there. Alex From: amd-gfx on behalf of Liu, Shaoyun Sent: Thursday, December 16, 2021 12:51 PM To: Skvortsov, Victor ; Alex Deucher Cc: Ming, Davis ; Chen, JingWen ; amd-gfx list ; Deng,

Re: [PATCH] drm/amdgpu: Filter security violation registers

2021-12-16 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Bokun Zhang Sent: Wednesday, December 15, 2021 7:52 PM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Bokun Subject: [PATCH] drm/amdgpu: Filter security violation registers Recently, there is

Re: [PATCH v2 1/2] drm/amd/pm: fix reading SMU FW version from amdgpu_firmware_info on YC

2021-12-13 Thread Deucher, Alexander
[Public] Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Mario Limonciello Sent: Monday, December 13, 2021 10:08 AM To: amd-gfx@lists.freedesktop.org Cc: Limonciello, Mario Subject: [PATCH v2 1/2] drm/amd/pm: fix reading SMU FW version from

Re: [PATCH] drm/amdgpu: use adev_to_drm to get drm_device pointer

2021-12-13 Thread Deucher, Alexander
[AMD Official Use Only] Reviewed-by: Alex Deucher From: Chen, Guchun Sent: Sunday, December 12, 2021 11:08 PM To: amd-gfx@lists.freedesktop.org ; Deucher, Alexander ; Koenig, Christian ; Pan, Xinhui ; Yu, Lang Cc: Chen, Guchun Subject: [PATCH] drm/amdgpu

Re: [PATCH] drm/amdgpu: fix dropped backing store handling in amdgpu_dma_buf_move_notify

2021-12-10 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Friday, December 10, 2021 3:39 AM To: amd-gfx@lists.freedesktop.org ; alexdeuc...@gmail.com Subject: [PATCH] drm/amdgpu: fix dropped backing store handling in

Re: [PATCH] drm/amdgpu: don't skip runtime pm get on A+A config

2021-12-09 Thread Deucher, Alexander
[Public] No objections from me. Acked-by: Alex Deucher From: Christian König Sent: Thursday, December 9, 2021 10:34 AM To: Quan, Evan ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amdgpu: don't skip runtime pm get

Re: [PATCH] drm/amd/pm: skip gfx cgpg in the s0ix suspend-resume

2021-12-09 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: Liang, Prike Sent: Wednesday, December 8, 2021 8:51 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Huang, Ray ; Limonciello, Mario ; Liang, Prike Subject: [PATCH] drm/amd/pm: skip gfx cgpg in the s0ix

Re: [PATCH 2/2] drm/amdgpu: free vkms_output after use

2021-12-06 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Flora Cui Sent: Monday, December 6, 2021 1:34 AM To: =guchun.c...@amd.com <=guchun.c...@amd.com>; Yuan, Perry ; Shi, Leslie ; amd-gfx@lists.freedesktop.org Cc: Shi, Leslie ; Cui, Flora Subject:

Re: [PATCH] drm/amdgpu: don't override default ECO_BITs setting

2021-12-06 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Hawking Zhang Sent: Saturday, December 4, 2021 6:24 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: [PATCH] drm/amdgpu: don't override default ECO_BITs setting Leave this bit as

Re: [PATCH] drm/amdkfd: Correct the value of the no_atomic_fw_version variable

2021-12-02 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: amd-gfx on behalf of chen gong Sent: Thursday, December 2, 2021 3:56 AM To: amd-gfx@lists.freedesktop.org Cc: Sider, Graham ; Gong, Curry Subject: [PATCH] drm/amdkfd: Correct the value of the no_atomic_fw_version

Re: [PATCH] drm/amdgpu/display: Only set vblank_disable_immediate when PSR is not enabled

2021-11-30 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: Nicholas Kazlauskas Sent: Tuesday, November 30, 2021 9:53 AM To: amd-gfx@lists.freedesktop.org Cc: Kazlauskas, Nicholas ; Wentland, Harry ; Deucher, Alexander Subject: [PATCH] drm/amdgpu/display: Only set

Re: [PATCH] drm/amdgpu/sriov/vcn: skip ip revision check case to ip init for SIENNA_CICHLID

2021-11-29 Thread Deucher, Alexander
[Public] Yes, that makes more sense. Alex From: Chen, Guchun Sent: Wednesday, November 24, 2021 9:21 PM To: Chen, Guchun ; Alex Deucher ; Jian, Jane Cc: Deucher, Alexander ; Chen, JingWen ; amd-gfx list Subject: RE: [PATCH] drm/amdgpu/sriov/vcn: skip ip

Re: [PATCH 3/3] drm/amdgpu: check atomic flag to differeniate with legacy path

2021-11-24 Thread Deucher, Alexander
[AMD Official Use Only] Series is: Reviewed-by: Alex Deucher From: Cui, Flora Sent: Tuesday, November 23, 2021 9:43 PM To: Chen, Guchun ; amd-gfx@lists.freedesktop.org ; Deucher, Alexander Cc: Cui, Flora ; Alex Deucher Subject: [PATCH 3/3] drm/amdgpu: check

Re: [PATCH] drm/amdgpu/sriov/vcn: skip ip revision check case to ip init for SIENNA_CICHLID

2021-11-23 Thread Deucher, Alexander
[Public] Can we just add a check for the new IP version in that case? This looks really hacky. Alex From: Jane Jian Sent: Tuesday, November 23, 2021 6:34 AM To: amd-gfx@lists.freedesktop.org ; Deucher, Alexander ; Chen, Guchun ; Chen, JingWen Cc: Jian

Re: [PATCH 3/3] drm/amd/pm: Print the error on command submission

2021-11-23 Thread Deucher, Alexander
[AMD Official Use Only] Series is: Reviewed-by: Alex Deucher From: Tuikov, Luben Sent: Monday, November 22, 2021 5:25 PM To: amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Deucher, Alexander Subject: [PATCH 3/3] drm/amd/pm: Print the error on command

Re: [PATCH 2/2] drm/amdgpu: check atomic flag to differeniate with legacy path

2021-11-22 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: amd-gfx on behalf of Flora Cui Sent: Monday, November 22, 2021 4:03 AM To: amd-gfx@lists.freedesktop.org ; Chen, Guchun Cc: Cui, Flora Subject: [PATCH 2/2] drm/amdgpu: check atomic flag to differeniate with legacy path

Re: [PATCH 1/2] drm/amdgpu: fix vkms hrtimer settings

2021-11-22 Thread Deucher, Alexander
, Flora ; amd-gfx@lists.freedesktop.org ; Deucher, Alexander Subject: RE: [PATCH 1/2] drm/amdgpu: fix vkms hrtimer settings [Public] Series is: Reviewed-by: Guchun Chen +Alex to comment this series as well. Regards, Guchun -Original Message- From: Cui, Flora Sent: Monday, November 22

Re: [PATCH 14/16] drm/amd/display: add else to avoid double destroy clk_mgr

2021-11-22 Thread Deucher, Alexander
[Public] Do you want to change the ASICREV_IS_BEIGE_GOBY_P() check to else if as well? maybe something like: if (ASICREV_IS_SIENNA_CICHLID_P(clk_mgr_base->ctx->asic_id.hw_internal_rev) || ASICREV_IS_DIMGREY_CAVEFISH_P(clk_mgr_base->ctx->asic_id.hw_internal_rev) ||

Re: [PATCH] drm/amdgpu: Declare Unpin BO api as static

2021-11-18 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Ramesh Errabolu Sent: Thursday, November 18, 2021 5:11 PM To: amd-gfx@lists.freedesktop.org Cc: Errabolu, Ramesh ; kernel test robot Subject: [PATCH] drm/amdgpu: Declare Unpin BO api as static

Re: [PATCH 2/6] drm/amdgpu: stop getting excl fence separately

2021-11-16 Thread Deucher, Alexander
[AMD Official Use Only] Acked-by: Alex Deucher From: Christian König Sent: Tuesday, November 16, 2021 5:43 AM To: amd-gfx@lists.freedesktop.org ; Deucher, Alexander Subject: Re: [PATCH 2/6] drm/amdgpu: stop getting excl fence separately Adding Alex. Once

Re: [PATCH] drm/amdgpu: always reset the asic in suspend

2021-11-15 Thread Deucher, Alexander
with the multiple freeze and thaw cycles. Alex From: Christian König Sent: Monday, November 15, 2021 8:41 AM To: Alex Deucher ; Deucher, Alexander Cc: amd-gfx list Subject: Re: [PATCH] drm/amdgpu: always reset the asic in suspend I was just about to write up my

Re: [PATCH] drm/amd/pm: Remove artificial freq level on Navi1x

2021-11-15 Thread Deucher, Alexander
[AMD Official Use Only] Acked-by: Alex Deucher From: Lazar, Lijo Sent: Monday, November 15, 2021 2:42 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Zhang, Hawking ; Wang, Yang(Kevin) ; Quan, Evan Subject: [PATCH] drm/amd/pm: Remove artificial

Re: [PATCH v2 3/3] drm/amdkfd: convert misc checks to IP version checking

2021-11-10 Thread Deucher, Alexander
[AMD Official Use Only] Series is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Graham Sider Sent: Tuesday, November 9, 2021 5:42 PM To: amd-gfx@lists.freedesktop.org Cc: Kuehling, Felix ; Kasiviswanathan, Harish ; Sider, Graham Subject: [PATCH v2

Re: [PATCH 0/5] 0 MHz is not a valid current frequency

2021-10-18 Thread Deucher, Alexander
; Russell, Kent Cc: Deucher, Alexander Subject: RE: [PATCH 0/5] 0 MHz is not a valid current frequency [AMD Official Use Only] +Kent who maintains the Rocm tool From: amd-gfx On Behalf Of Lazar, Lijo Sent: Thursday, October 14, 2021 1:07 AM To: Tuikov, Luben ; amd-gfx@lists.freedesktop.org Cc

Re: [PATCH] drm/amdgpu: print warning and taint kernel if lockup timeout is disabled

2021-09-30 Thread Deucher, Alexander
[AMD Official Use Only] Acked-by: Alex Deucher From: Christian König Sent: Thursday, September 30, 2021 6:00 AM To: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: print warning and taint kernel if lockup timeout is disabled

Re: [PATCH 04/66] drm/amdgpu: fill in IP versions from IP discovery table

2021-09-22 Thread Deucher, Alexander
[AMD Official Use Only] Fixed locally. Thanks! Alex From: Kuehling, Felix Sent: Wednesday, September 22, 2021 12:58 PM To: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 04/66] drm/amdgpu: fill in IP versions from IP discovery table

RE: [PATCHv2 1/2] x86/MCE/AMD: Export smca_get_bank_type symbol

2021-09-22 Thread Deucher, Alexander
[Public] > -Original Message- > From: amd-gfx On Behalf Of > Borislav Petkov > Sent: Wednesday, September 22, 2021 7:34 AM > To: Joshi, Mukul ; Alex Deucher > > Cc: linux-e...@vger.kernel.org; x...@kernel.org; linux- > ker...@vger.kernel.org; mi...@redhat.com; mche...@kernel.org; >

Re: [PATCH 46/66] drm/amdgpu/pm/amdgpu_smu: convert more IP version checking

2021-09-22 Thread Deucher, Alexander
[Public] Fixed locally. From: Lazar, Lijo Sent: Wednesday, September 22, 2021 4:16 AM To: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 46/66] drm/amdgpu/pm/amdgpu_smu: convert more IP version checking On 9/21/2021 11:37 PM, Alex

Re: [PATCH 29/66] drm/amdgpu/display/dm: convert to IP version checking

2021-09-22 Thread Deucher, Alexander
[AMD Official Use Only] Fixed locally. Alex From: Lazar, Lijo Sent: Wednesday, September 22, 2021 3:37 AM To: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 29/66] drm/amdgpu/display/dm: convert to IP version checking On 9/21/2021

Re: [PATCH 23/66] drm/amdgpu/amdgpu_smu: convert to IP version checking

2021-09-22 Thread Deucher, Alexander
[Public] Fixed locally. Thanks! From: Lazar, Lijo Sent: Wednesday, September 22, 2021 3:32 AM To: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 23/66] drm/amdgpu/amdgpu_smu: convert to IP version checking On 9/21/2021 11:36 PM, Alex

Re: [PATCH 11/66] drm/amdgpu: filter out radeon PCI device IDs

2021-09-22 Thread Deucher, Alexander
[AMD Official Use Only] Fixed locally. Thanks! From: Lazar, Lijo Sent: Wednesday, September 22, 2021 12:41 AM To: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 11/66] drm/amdgpu: filter out radeon PCI device IDs On 9/21/2021 11:36

Re: [PATCH] drm/amd/display: Set the domain as GTT when VRAM size <= 32 MB

2021-08-26 Thread Deucher, Alexander
, Nicholas ; Deucher, Alexander ; Wu, Hersen Cc: amd-gfx@lists.freedesktop.org ; Mahapatra, Rajib Subject: [PATCH] drm/amd/display: Set the domain as GTT when VRAM size <= 32 MB [Why] In lower carve out (<= 32 MB) devices, it was unable to pin framebuffer in VRAM domain for some BO alloc

Re: [PATCH] drm/amdgpu: reenable BACO support for 699F:C7 polaris12 SKU

2021-08-25 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: Quan, Evan Sent: Tuesday, August 24, 2021 11:58 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Chen, Guchun ; Quan, Evan Subject: [PATCH] drm/amdgpu: reenable BACO support for 699F:C7 polaris12 SKU

Re: [PATCH] drm/amd/amdgpu: New debugfs interface for MMIO registers (v4)

2021-08-25 Thread Deucher, Alexander
[AMD Official Use Only] I think it would be good to put the IOCTL structures in their own header to make it easier to share with umr. No need to put it in uapi area though. We also need a umr branch that utilizes this to upstream the changes. Alex From:

RE: [PATCH] drm/amd/pm: And destination bounds checking to struct copy

2021-08-23 Thread Deucher, Alexander
l) ; Quan, > Evan ; amd-gfx@lists.freedesktop.org; dri- > de...@lists.freedesktop.org; Deucher, Alexander > ; Tuikov, Luben > ; Grodzovsky, Andrey > ; Li, Dennis ; > Sundararaju, Sathishkumar ; Kim, > Jonathan ; Wang, Kevin(Yang) > ; Nieto, David M ; Feng, > Kenneth ; Lee Jones ; > Clem

Re: [PATCH] drm/amdgpu: update PSP BL cmd IDs

2021-08-03 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: amd-gfx on behalf of Clements, John Sent: Tuesday, August 3, 2021 4:20 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Hawking Subject: [PATCH] drm/amdgpu: update PSP BL cmd IDs [AMD Official Use Only] Submitting

Re: [PATCH] drm/amdgpu/display: fix DMUB firmware version info

2021-08-03 Thread Deucher, Alexander
[AMD Official Use Only] Reviewed-by: Alex Deucher From: S, Shirish Sent: Tuesday, August 3, 2021 4:42 AM To: Wentland, Harry ; Kazlauskas, Nicholas ; Deucher, Alexander Cc: amd-gfx@lists.freedesktop.org ; S, Shirish Subject: [PATCH] drm/amdgpu/display: fix

Re: [PATCH] drm/amd/pm: update yellow carp pmfw interface version

2021-07-30 Thread Deucher, Alexander
[AMD Official Use Only] Acked-by: Alex Deucher From: amd-gfx on behalf of Xiaomeng Hou Sent: Thursday, July 29, 2021 10:40 PM To: amd-gfx@lists.freedesktop.org Cc: Hou, Xiaomeng (Matthew) ; Liu, Aaron Subject: [PATCH] drm/amd/pm: update yellow carp pmfw

Re: [PATCH v4] drm/amdgpu: fix the doorbell missing when in CGPG issue for renoir.

2021-07-29 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Yifan Zhang Sent: Thursday, July 29, 2021 5:46 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Yifan Subject: [PATCH v4] drm/amdgpu: fix the doorbell missing when in CGPG issue for renoir. If GC

Re: [PATCH] drm/amdgpu: Rename amdgpu_acpi_is_s0ix_supported

2021-07-26 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: Vishwakarma, Pratik Sent: Monday, July 26, 2021 8:33 AM To: Deucher, Alexander ; Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Vishwakarma, Pratik Subject: [PATCH] drm/amdgpu: Rename amdgpu_acpi_is_s0ix_supported

Re: [PATCH V2 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x

2021-07-23 Thread Deucher, Alexander
-gfx@lists.freedesktop.org Cc: Deucher, Alexander Subject: Re: [PATCH V2 1/2] drm/amd/pm: restore user customized OD settings properly for NV1x The series looks good to me, though I prefer to use a common logic to restore od settings so that smuv12,smuv13 gets the restore feature by default once

Re: [PATCH] drm/amdgpu: Add msix restore for pass-through mode

2021-07-22 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: Chengzhe Liu Sent: Thursday, July 22, 2021 1:49 AM To: amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Koenig, Christian ; Deucher, Alexander ; Xiao, Jack ; Zhang, Hawking ; Xu, Feifei ; Wang, Kevin(Yang) ; Liu, Cheng

Re: [PATCH] drm/amdgpu: Check pmops for desired suspend state

2021-07-22 Thread Deucher, Alexander
22, 2021 1:27 AM To: Deucher, Alexander ; amd-gfx@lists.freedesktop.org Cc: Vishwakarma, Pratik Subject: [PATCH] drm/amdgpu: Check pmops for desired suspend state [Why] User might set mem_sleep as deep and it will result in amdgpu resume errors. [How] Check with pm for default suspend state

Re: [PATCH v2 0/2] Fix regression on embedded panels caused by enabling ASSR

2021-07-21 Thread Deucher, Alexander
[Public] Series looks good to me. Thanks! Alex From: amd-gfx on behalf of Stylon Wang Sent: Wednesday, July 21, 2021 12:25 AM To: amd-gfx@lists.freedesktop.org Cc: Wang, Chao-kai (Stylon) ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing ; Siqueira,

Re: [PATCH] drm/amdgpu: Fix documentaion for amdgpu_bo_add_to_shadow_list

2021-07-19 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Anson Jacob Sent: Monday, July 19, 2021 11:19 AM To: amd-gfx@lists.freedesktop.org Cc: Jacob, Anson Subject: [PATCH] drm/amdgpu: Fix documentaion for amdgpu_bo_add_to_shadow_list make htmldocs

Re: [PATCH 2/5] drm/amdgpu: Change a few function names

2021-07-16 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Oak Zeng Sent: Thursday, July 15, 2021 9:25 PM To: amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; Kuehling, Felix ; Liu, Leo ; Zeng, Oak ; Zhang, Hawking Subject: [PATCH 2/5] drm/amdgpu: Change

Re: [PATCH 1/5] drm/amdgpu: Fix a printing message

2021-07-16 Thread Deucher, Alexander
[Public] Please use dev_info rather than DRM_INFO. Alex From: amd-gfx on behalf of Oak Zeng Sent: Thursday, July 15, 2021 9:25 PM To: amd-gfx@lists.freedesktop.org Cc: Xu, Feifei ; Kuehling, Felix ; Liu, Leo ; Zeng, Oak ; Zhang, Hawking Subject: [PATCH

Re: [PATCH] drm/amdgpu: Put MODE register in wave debug info

2021-07-15 Thread Deucher, Alexander
[Public] As far as I know, umr is the only user of this and it shouldn't cause any problems there. Acked-by: Alex Deucher From: amd-gfx on behalf of Joseph Greathouse Sent: Tuesday, June 29, 2021 11:47 PM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom

Re: [PATCH 2/3] drm/amdgpu: Fix a printing message

2021-07-15 Thread Deucher, Alexander
[Public] I think it's more consistent to use dev_info since we already use that pretty extensively in the driver. Alex From: amd-gfx on behalf of Chen, Jiansong (Simon) Sent: Wednesday, July 14, 2021 10:51 PM To: Alex Deucher ; Zeng, Oak Cc: Xu, Feifei ;

Re: [PATCH] drm/amdgpu: update the golden setting for vangogh

2021-07-14 Thread Deucher, Alexander
[AMD Official Use Only] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Xiaojian Du Sent: Wednesday, July 14, 2021 5:32 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray ; Du, Xiaojian Subject: [PATCH] drm/amdgpu: update the golden setting for vangogh

Re: AMDGPU error: "[drm:amdgpu_dm_atomic_commit_tail [amdgpu]] *ERROR* Waiting for fences timed out!"

2021-06-28 Thread Deucher, Alexander
[Public] Thanks for narrowing this down. There is new PCO SDMA firmware available (attached). Can you try it? Thanks, Alex From: amd-gfx on behalf of Michel Dänzer Sent: Thursday, June 24, 2021 6:51 AM To: Alex Deucher Cc: xgqt ; amd-gfx list Subject:

Re: [PATCH v3] drm/radeon: Call radeon_suspend_kms() in radeon_pci_shutdown() for Loongson64

2021-06-28 Thread Deucher, Alexander
[Public] Applied. Thanks. For whatever reason, I never got this patch and couldn't find it in patchwork. Alex From: Koenig, Christian Sent: Wednesday, June 23, 2021 4:25 AM To: Tiezhu Yang ; Deucher, Alexander Cc: airl...@linux.ie ; amd-gfx

Re: [PATCH] drm/amdgpu: fix amdgpu_preempt_mgr_new()

2021-06-21 Thread Deucher, Alexander
; Daniel Vetter ; Deucher, Alexander ; Dave Airlie ; Koenig, Christian ; Dan Carpenter Subject: Re: [PATCH] drm/amdgpu: fix amdgpu_preempt_mgr_new() Am 18.06.21 um 23:18 schrieb Alex Deucher: > On Fri, Jun 18, 2021 at 11:40 AM Felix Kuehling > wrote: >> Am 2021-06-18 um 4:39

Re: [PATCH v3] drm/amd/amdgpu: Use IP discovery data to determine VCN enablement instead of MMSCH

2021-06-17 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Peng Ju Zhou Sent: Thursday, June 17, 2021 3:46 AM To: amd-gfx@lists.freedesktop.org Cc: Zhang, Bokun Subject: [PATCH v3] drm/amd/amdgpu: Use IP discovery data to determine VCN enablement instead

Re: [PATCH] drm/amdgpu: use adev_to_drm to get drm_device

2021-06-09 Thread Deucher, Alexander
[Public] We already use the macro everywhere else upstream, so this just makes it consistent. Alex From: amd-gfx on behalf of Felix Kuehling Sent: Wednesday, June 9, 2021 11:32 AM To: Tuikov, Luben ; Chen, Guchun ; amd-gfx@lists.freedesktop.org Subject:

Re: [PATCH] drm/amd/display: Fix build break

2021-06-08 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Anson Jacob Sent: Tuesday, June 8, 2021 11:36 AM To: amd-gfx@lists.freedesktop.org Cc: Brol, Eryk ; Li, Sun peng (Leo) ; Wentland, Harry ; Zhuo, Qingqing ; Siqueira, Rodrigo ; Li, Roman ; Jacob,

Re: [PATCH] drm/amd/pm: fix warning reported by kernel test robot

2021-06-07 Thread Deucher, Alexander
[Public] Acked-by: Alex Deucher From: amd-gfx on behalf of Xiaomeng Hou Sent: Monday, June 7, 2021 8:45 AM To: amd-gfx@lists.freedesktop.org Cc: Huang, Ray ; Hou, Xiaomeng (Matthew) ; Wang, Kevin(Yang) Subject: [PATCH] drm/amd/pm: fix warning reported by

Re: [PATCH] drm/amdgpu: Modify GC register access to use _SOC15 macros

2021-06-04 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: Khaire, Rohit Sent: Friday, June 4, 2021 12:38 PM To: amd-gfx@lists.freedesktop.org ; Deucher, Alexander ; Zhang, Hawking ; Deng, Emily ; Liu, Monk ; Zhou, Peng Ju ; Chen, Horace Cc: Ming, Davis ; Khaire, Rohit

Re: [PATCH] drm/amdgpu: Enable RLCG read/write interface for Sienna Cichlid

2021-06-04 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Rohit Khaire Sent: Friday, June 4, 2021 11:24 AM To: amd-gfx@lists.freedesktop.org ; Deucher, Alexander ; Zhang, Hawking ; Deng, Emily ; Liu, Monk ; Zhou, Peng Ju ; Chen, Horace Cc: Ming, Davis

Re: [PATCH] drm/amdgpu: Fix incorrect register offsets for Sienna Cichlid

2021-06-04 Thread Deucher, Alexander
op.org ; Deucher, Alexander ; Zhang, Hawking ; Deng, Emily ; Liu, Monk ; Zhou, Peng Ju ; Chen, Horace Cc: Ming, Davis ; Khaire, Rohit ; Koenig, Christian ; Khaire, Rohit Subject: [PATCH] drm/amdgpu: Fix incorrect register offsets for Sienna Cichlid RLC_CP_SCHEDULERS and RLC_SPARE_INT0 have dif

Re: [PATCH 1/1] drm/amd/display: WARN_ON cleanups

2021-05-27 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: Das, Nirmoy Sent: Thursday, May 27, 2021 8:16 AM To: Wentland, Harry Cc: Deucher, Alexander ; Koenig, Christian ; amd-gfx@lists.freedesktop.org Subject: RE: [PATCH 1/1] drm/amd/display: WARN_ON cleanups [AMD Official

Re: [PATCH 1/1] drm/amd/display: do not dereference on NULL

2021-05-27 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: Das, Nirmoy Sent: Thursday, May 27, 2021 8:07 AM To: Wentland, Harry Cc: Deucher, Alexander ; Koenig, Christian ; amd-gfx@lists.freedesktop.org ; Das, Nirmoy Subject: [PATCH 1/1] drm/amd/display: do not dereference

Re: [PATCH 3/3] drm/amdgpu: Use delayed work to collect RAS error counters

2021-05-26 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: Tuikov, Luben Sent: Wednesday, May 26, 2021 12:43 PM To: amd-gfx@lists.freedesktop.org Cc: Tuikov, Luben ; Deucher, Alexander ; Koenig, Christian ; Clements, John ; Zhang, Hawking Subject: [PATCH 3/3] drm/amdgpu: Use

Re: [PATCH] drm/amdgpu: Add vbios info ioctl interface

2021-05-19 Thread Deucher, Alexander
t; + __u8 date[32]; > +}; From: Gu, JiaWei (Will) Sent: Tuesday, May 18, 2021 1:58 AM To: Nieto, David M ; Koenig, Christian ; amd-gfx@lists.freedesktop.org ; mar...@gmail.com ; Deucher, Alexander Cc: Deng, Emily Subject: RE: [PATCH] drm/amdgpu: Add vbios info ioctl interface [Public] Hi

Re: [PATCH] drm/amdgpu: disable 3DCGCG on picasso/raven1 to avoid compute hang

2021-05-18 Thread Deucher, Alexander
, Changfeng ; Deucher, Alexander ; Alex Deucher ; Das, Nirmoy Cc: Huang, Ray ; amd-gfx list Subject: RE: [PATCH] drm/amdgpu: disable 3DCGCG on picasso/raven1 to avoid compute hang [Public] Nirmoy’s patch landed already if I understand correctly. d41a39dda140 drm/scheduler: improve job

Re: [PATCH] drm/amdgpu: disable 3DCGCG on picasso/raven1 to avoid compute hang

2021-05-18 Thread Deucher, Alexander
[Public] + Nirmoy I thought we disabled all but one of the compute queues on raven due to this issue. Maybe that patch never landed? Wasn't this the same issue that was exposed by Nirmoy's patch that provided better load balancing across queues? Alex From:

Re: [PATCH] drm/amdgpu: stop touching sched.ready in the backend

2021-05-18 Thread Deucher, Alexander
[Public] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Christian König Sent: Tuesday, May 18, 2021 11:50 AM To: Zhu, James Cc: amd-gfx@lists.freedesktop.org Subject: [PATCH] drm/amdgpu: stop touching sched.ready in the backend This unfortunately

Re: [PATCH] drm/amdgpu: Unmap all MMIO mappings

2021-05-18 Thread Deucher, Alexander
; Wentland, Harry Cc: ppaala...@gmail.com ; Deucher, Alexander ; gre...@linuxfoundation.org ; helg...@kernel.org ; Kuehling, Felix Subject: Re: [PATCH] drm/amdgpu: Unmap all MMIO mappings Ping Andrey On 2021-05-17 3:31 p.m., Andrey Grodzovsky wrote: > Access to those must be prevented p

Re: [PATCH] drm/amdgpu: Complete multimedia bandwidth interface

2021-05-13 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Liu, Monk Sent: Thursday, May 13, 2021 7:50 AM To: Zhang, Bokun ; amd-gfx@lists.freedesktop.org Cc: Zhang, Bokun Subject: RE: [PATCH] drm/amdgpu:

Re: [PATCH] drm/amd/amdgpu: psp program IH_RB_CTRL on sienna_cichlid

2021-05-13 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: YuBiao Wang Sent: Thursday, May 13, 2021 6:33 AM To: amd-gfx@lists.freedesktop.org Cc: Grodzovsky, Andrey ; Quan, Evan ; Chen, Horace ; Tuikov, Luben ; Koenig, Christian ; Deucher, Alexander ; Xiao, Jack ; Zhang

RE: [PATCH 1/2] drm/amdgpu: Don't query CE and UE errors

2021-05-12 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: Tuikov, Luben > Sent: Wednesday, May 12, 2021 1:03 PM > To: amd-gfx@lists.freedesktop.org > Cc: Tuikov, Luben ; Deucher, Alexander > ; sta...@vger.kernel.org > Subject: [PATCH 1/2] drm/amdgpu: Don't query CE and UE errors

Re: [PATCH] drm/amdgpu: Add compile flag for securedisplay

2021-05-11 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: amd-gfx on behalf of Jinzhou Su Sent: Tuesday, May 11, 2021 9:51 PM To: amd-gfx@lists.freedesktop.org Cc: Su, Jinzhou (Joe) ; Huang, Ray Subject: [PATCH] drm/amdgpu: Add

Re: [PATCH] drm/amdgpu: Align serial size in drm_amdgpu_info_vbios

2021-05-11 Thread Deucher, Alexander
[AMD Public Use] It's being used by umr and some other smi tools to provide vbios information for debugging. Alex From: amd-gfx on behalf of Marek Olšák Sent: Tuesday, May 11, 2021 4:18 AM To: Christian König Cc: Kees Cook ; Gu, JiaWei (Will) ; amd-gfx

Re: [PATCH v6 04/16] drm/amdkfd: Split kfd suspend from devie exit

2021-05-11 Thread Deucher, Alexander
com ; daniel.vet...@ffwll.ch ; Wentland, Harry Cc: ppaala...@gmail.com ; Deucher, Alexander ; gre...@linuxfoundation.org ; helg...@kernel.org ; Kuehling, Felix ; Grodzovsky, Andrey Subject: [PATCH v6 04/16] drm/amdkfd: Split kfd suspend from devie exit Helps to expdite HW related st

Re: [PATCH] drm/amdgpu: Field type update in drm_amdgpu_info_vbios

2021-05-11 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Please update the umr patch as well. Acked-by: Alex Deucher From: amd-gfx on behalf of Jiawei Gu Sent: Tuesday, May 11, 2021 1:31 AM To: amd-gfx@lists.freedesktop.org Cc: StDenis, Tom ; Gu, JiaWei (Will)

Re: [PATCH libdrm] Revert "tests/amdgpu: fix bo eviction test issue"

2021-05-07 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] For libdrm tests, please open a gitlab merge request: https://gitlab.freedesktop.org/mesa/drm/-/merge_requests Alex From: amd-gfx on behalf of Yu, Lang Sent: Friday, May 7, 2021 3:10 AM To: Chen, Guchun ;

Re: [PATCH] drm/amdgpu: set vcn mgcg flag for picasso

2021-05-05 Thread Deucher, Alexander
[AMD Public Use] Acked-by: Alex Deucher From: Sundararaju, Sathishkumar Sent: Tuesday, May 4, 2021 5:27 AM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Liu, Leo ; Sundararaju, Sathishkumar Subject: [PATCH] drm/amdgpu: set vcn mgcg flag

RE: [PATCH] Revert "drm/radeon/si_dpm: Replace one-element array with flexible-array in struct SISLANDS_SMC_SWSTATE"

2021-05-05 Thread Deucher, Alexander
[AMD Public Use] > -Original Message- > From: Gustavo A. R. Silva > Sent: Tuesday, May 4, 2021 6:43 PM > To: Deucher, Alexander ; amd- > g...@lists.freedesktop.org > Cc: Gustavo A . R . Silva > Subject: Re: [PATCH] Revert "drm/radeon/si_dpm: Replace one-ele

Re: [PATCH] Update NV SIMD-per-CU to 2

2021-05-03 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Please fix the subject: drm/amdgpu: Update NV SIMD-per-CU to 2 With that fixed, the patch is: Reviewed-by: Alex Deucher From: amd-gfx on behalf of Joseph Greathouse Sent: Monday, May 3, 2021 1:25 PM To:

RE: Radeon NI: GIT kernel with the nislands_smc commit doesn't boot on a Freescale P5040 board and P.A.Semi Nemo board

2021-04-30 Thread Deucher, Alexander
[AMD Public Use] + Gustavo, amd-gfx > -Original Message- > From: Christian Zigotzky > Sent: Friday, April 30, 2021 8:00 AM > To: gustavo...@kernel.org; Deucher, Alexander > > Cc: R.T.Dickinson ; Darren Stevens zone.net>; mad skateman ; linuxppc-dev > ; Ol

Re: [PATCH] drm/amdgpu: fix r initial values

2021-04-28 Thread Deucher, Alexander
[AMD Public Use] Reviewed-by: Alex Deucher From: amd-gfx on behalf of Victor Zhao Sent: Wednesday, April 28, 2021 12:40 AM To: amd-gfx@lists.freedesktop.org Cc: Zhao, Victor Subject: [PATCH] drm/amdgpu: fix r initial values Sriov gets suspend of IP block

Re: [PATCH 1/2] drm/amd/pm: new gpu_metrics structure for pmfw attached timestamp

2021-04-28 Thread Deucher, Alexander
[AMD Public Use] Assuming the updated table it 64 bit aligned, the series is: Reviewed-by: Alex Deucher From: Quan, Evan Sent: Tuesday, April 27, 2021 9:43 PM To: amd-gfx@lists.freedesktop.org Cc: Deucher, Alexander ; Kasiviswanathan, Harish ; Quan, Evan

Re: [PATCH] drm/amdgpu: fix r initial values

2021-04-27 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Good catch. I think we should probably just return 0 at the end to keep the semantics of the original code before this was broken out into a separate helper function. Alex From: amd-gfx on behalf of Victor

Re: [PATCH 1/2] drm/scheduler: Change scheduled fence track

2021-04-26 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Fair point. Either way works for me. Alex From: Christian König Sent: Monday, April 26, 2021 3:48 PM To: Deucher, Alexander Cc: amd-gfx list ; Sun, Roy ; Nieto, David M Subject: Re: [PATCH 1/2] drm

Re: [PATCH 1/2] drm/scheduler: Change scheduled fence track

2021-04-26 Thread Deucher, Alexander
From: amd-gfx on behalf of Deucher, Alexander Sent: Monday, April 26, 2021 3:24 PM To: Christian König Cc: amd-gfx list ; Sun, Roy ; Nieto, David M Subject: Re: [PATCH 1/2] drm/scheduler: Change scheduled fence track [AMD Official Use Only - Internal Distribution Only] [AMD Official Use Only

Re: [PATCH 1/2] drm/scheduler: Change scheduled fence track

2021-04-26 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] No objections from me. Thanks! Alex From: Christian König Sent: Monday, April 26, 2021 2:49 AM To: Deucher, Alexander Cc: Nieto, David M ; Sun, Roy ; amd-gfx list Subject: Re: [PATCH 1/2] drm/scheduler

Re: [PATCH] drm/amd/display: get socBB from VBIOS for dcn302

2021-04-21 Thread Deucher, Alexander
[AMD Official Use Only - Internal Distribution Only] Acked-by: Alex Deucher From: amd-gfx on behalf of Aurabindo Pillai Sent: Wednesday, April 21, 2021 3:17 PM To: amd-gfx@lists.freedesktop.org Cc: Lakha, Bhawanpreet ; Kazlauskas, Nicholas ; R, Bindu

Re: [PATCH v3 01/20] drm/amdgpu: Add error handling to amdgpu_dm_initialize_dp_connector()

2021-04-21 Thread Deucher, Alexander
, Rodrigo ; open list ; Kazlauskas, Nicholas ; Somasundaram, Meenakshikumar ; David Airlie ; Pillai, Aurabindo ; Daniel Vetter ; Bas Nieuwenhuizen ; Deucher, Alexander ; Cornij, Nikola ; Wentland, Harry ; Koenig, Christian Subject: Re: [PATCH v3 01/20] drm/amdgpu: Add error handling

<    1   2   3   4   5   6   7   8   9   10   >