RE: [PATCH] platform/x86: Add missing LPS0 functions for AMD

2021-05-04 Thread Limonciello, Mario
[AMD Public Use] > Subject: [PATCH] platform/x86: Add missing LPS0 functions for AMD Rafael might be willing to fix it up on commit, but if you end up needing to re-spin I think technically this subsystem prefix to match other stuff committed to this file should be: "ACPI: PM: s2idle:" > >

Re: [PATCH] drm/amd/display: Fully switch to dmub for all dcn21 asics

2021-10-18 Thread Limonciello, Mario
On 10/15/2021 17:31, roman...@amd.com wrote: From: Roman Li [Why] On renoir usb-c port stops functioning on resume after f/w update. New dmub firmware caused regression due to conflict with dmcu. With new dmub f/w dmcu is superseded and should be disabled. [How] - Disable dmcu for all dcn21.

Re: [PATCH] drm/amd/display: Fully switch to dmub for all dcn21 asics

2021-10-18 Thread Limonciello, Mario
On 10/18/2021 08:38, Harry Wentland wrote: On 2021-10-15 18:31, roman...@amd.com wrote: From: Roman Li [Why] On renoir usb-c port stops functioning on resume after f/w update. New dmub firmware caused regression due to conflict with dmcu. With new dmub f/w dmcu is superseded and should be

RE: [PATCH] drm/amdgpu: During s0ix don't wait to signal GFXOFF

2021-10-01 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Friday, October 1, 2021 08:26 > To: Lazar, Lijo > Cc: amd-gfx list ; Deucher, Alexander > ; Limonciello, Mario > ; Zhang, Hawking ; > Wang, Yang(Kevin) ; Quan, Evan > > Subject: Re: [PATCH] drm/

RE: [PATCH 2/2] drm/amdgpu: don't set s3 and s0ix at the same time

2022-01-04 Thread Limonciello, Mario
[AMD Official Use Only] Maybe it was used more widely previously? The only place that I found it in use was amdgpu_device_evict_resources. From: Deucher, Alexander Sent: Tuesday, January 4, 2022 11:24 To: Limonciello, Mario ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH 2/2] drm/amdgpu

RE: [RFC 2/2] drm/amd/pm: Add support for reacting to platform profile notification

2021-11-11 Thread Limonciello, Mario
don't make changes going to high power mode? > Thanks, > Lijo > > > *From:* Lazar, Lijo > > *Sent:* Wednesday, November 10, 2021 10:05 > > *To:* Alex Deucher ; Limonciello, Mario > > > > *Cc:* amd-gfx list > > *Subject:* Re: [RFC 2/2] drm/amd/pm: Add su

RE: [RFC 2/2] drm/amd/pm: Add support for reacting to platform profile notification

2021-11-10 Thread Limonciello, Mario
ented by the OEM, but then still notify amdgpu dGPU to tune for power saving or performance workload. From: Lazar, Lijo Sent: Wednesday, November 10, 2021 10:05 To: Alex Deucher ; Limonciello, Mario Cc: amd-gfx list Subject: Re: [RFC 2/2] drm/amd/pm: Add support for reacting to platform profile n

RE: [PATCH] drm/amd/display: Look at firmware version to determine using dmub on dcn21

2021-10-29 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Friday, October 29, 2021 15:24 > To: Limonciello, Mario > Cc: amd-gfx list ; Li, Roman > > Subject: Re: [PATCH] drm/amd/display: Look at firmware version to determine > using dmub on dcn21 > > O

Re: [PATCH v2] drm/amdgpu/pm: drop pp_power_profile_mode support for yellow carp

2021-10-29 Thread Limonciello, Mario
On 10/29/2021 15:57, Alex Deucher wrote: On Fri, Oct 29, 2021 at 11:34 AM Mario Limonciello wrote: This was added by commit bd8dcea93a7d ("drm/amd/pm: add callbacks to read/write sysfs file pp_power_profile_mode") but the feature was deprecated from PMFW. Remove it from the driver.

RE: [PATCH v2] drm/amd/display: Look at firmware version to determine using dmub on dcn21

2021-10-31 Thread Limonciello, Mario
[Public] > -Original Message- > From: Li, Roman > Sent: Friday, October 29, 2021 18:12 > To: Alex Deucher ; Limonciello, Mario > > Cc: amd-gfx list > Subject: RE: [PATCH v2] drm/amd/display: Look at firmware version to > determine using dmub on dcn21 > >

RE: [PATCH] drm/amdgpu/pm: Don't show pp_power_profile_mode for YC and later APUs

2021-10-31 Thread Limonciello, Mario
*states = ATTR_STATE_UNSUPPORTED; } From: Lazar, Lijo Sent: Saturday, October 30, 2021 10:06 To: Alex Deucher Cc: Limonciello, Mario ; amd-gfx@lists.freedesktop.org; Deucher, Alexander Subject: Re: [PATCH] drm/amdgpu/pm: Don't show pp_power_profile_mode for YC and later APUs [Public

Re: [PATCH] drm/amdgpu/pm: drop pp_power_profile_mode support for APUs

2021-10-28 Thread Limonciello, Mario
On 10/28/2021 22:08, Alex Deucher wrote: On Thu, Oct 28, 2021 at 10:35 PM Huang Rui wrote: On Thu, Oct 28, 2021 at 10:53:36AM -0500, Mario Limonciello wrote: Although this has been plumbed for Renoir, Green Sardine, Van Gogh, and Yellow Carp the functionality in the SMU doesn't do anything

Re: [v3] drm/amdgpu: reset asic after system-wide suspend aborted (v3)

2021-12-01 Thread Limonciello, Mario
On 11/24/2021 23:48, Prike Liang wrote: Do ASIC reset at the moment Sx suspend aborted behind of amdgpu suspend to keep AMDGPU in a clean reset state and that can avoid re-initialize device improperly error. Currently,we just always do asic reset in the amdgpu resume until sort out the PM abort

RE: [PATCH] drm/amd/pm: fix reading SMU FW version from amdgpu_firmware_info on YC

2021-12-13 Thread Limonciello, Mario
[Public] > -Original Message- > From: Chen, Guchun > Sent: Sunday, December 12, 2021 21:36 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org > Cc: Limonciello, Mario > Subject: RE: [PATCH] drm/amd/pm: fix reading SMU FW version from > amdgpu_firmware

RE: [PATCH 2/2] drm/amd: move variable to local scope

2021-12-10 Thread Limonciello, Mario
[AMD Official Use Only] > -Original Message- > From: Koenig, Christian > Sent: Friday, December 10, 2021 10:07 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org > Subject: Re: [PATCH 2/2] drm/amd: move variable to local scope > > > > Am 1

RE: [PATCH 2/2] drm/amd: move variable to local scope

2021-12-10 Thread Limonciello, Mario
[AMD Official Use Only] > -Original Message- > From: Koenig, Christian > Sent: Friday, December 10, 2021 10:19 > To: Limonciello, Mario ; Koenig, Christian > ; amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH 2/2] drm/amd: move variable to local scope > &

RE: [PATCH] drm/amdgpu: correct the wrong cached state for GMC on PICASSO

2021-12-13 Thread Limonciello, Mario
[Public] > -Original Message- > From: Chen, Guchun > Sent: Monday, December 13, 2021 21:49 > To: Quan, Evan ; amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander ; Quan, Evan > ; Limonciello, Mario > Subject: RE: [PATCH] drm/amdgpu: correct the wrong

Re: [PATCH v2 1/2] drm/amd/pm: fix reading SMU FW version from amdgpu_firmware_info on YC

2021-12-13 Thread Limonciello, Mario
I've pushed it already after Alex's review comment. I'll send an extra patch tomorrow for this extra cleanup. Get Outlook for Android<https://aka.ms/AAb9ysg> From: Chen, Guchun Sent: Monday, December 13, 2021 8:41:17 PM To: Limonciello, Mario ; a

Re: [v3] drm/amdgpu: reset asic after system-wide suspend aborted (v3)

2021-12-13 Thread Limonciello, Mario
On 11/24/2021 23:48, Prike Liang wrote: Do ASIC reset at the moment Sx suspend aborted behind of amdgpu suspend to keep AMDGPU in a clean reset state and that can avoid re-initialize device improperly error. Currently,we just always do asic reset in the amdgpu resume until sort out the PM abort

Re: [PATCH 1/2] drm/amd/pm: Add information about SMU11 firmware version

2021-07-21 Thread Limonciello, Mario
, 2021 12:18 AM To: amd-gfx@lists.freedesktop.org Cc: Limonciello, Mario Subject: [PATCH 1/2] drm/amd/pm: Add information about SMU11 firmware version This information is useful for root causing issues with S0ix. Signed-off-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/smu11/smu_v11_0

RE: [PATCH v2] drm/amd/display: explicitly update clocks when DC is set to D3 in s0i3

2022-01-05 Thread Limonciello, Mario
[Public] > -Original Message- > From: Wentland, Harry > Sent: Wednesday, January 5, 2022 15:26 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org > Cc: Zhuo, Qingqing (Lillian) ; Scott Bruce > ; Chris Hixon ; > spassw...@web.de > Subject: Re:

RE: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-11 Thread Limonciello, Mario
[AMD Official Use Only] > -Original Message- > From: Bert Karwatzki > Sent: Tuesday, January 11, 2022 19:12 > To: amd-gfx@lists.freedesktop.org > Cc: Limonciello, Mario ; Kazlauskas, Nicholas > ; Zhuo, Qingqing (Lillian) > ; Scott Bruce ; Chris Hixon > >

Re: [PATCH] drm/amdgpu: don't do resets on APUs which don't support it

2022-01-13 Thread Limonciello, Mario
On 1/13/2022 00:56, Lazar, Lijo wrote: Hi Alex, What about something like this? bool amdgpu_device_reset_on_suspend(struct amdgpu_device *adev) {     if (adev->in_s0ix || adev->gmc.xgmi.num_physical_nodes > 1)     return false;     switch

Re: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-13 Thread Limonciello, Mario
On 1/13/2022 03:16, Bert Karwatzki wrote: Am Mittwoch, dem 12.01.2022 um 02:08 + schrieb Limonciello, Mario: [AMD Official Use Only] -Original Message- From: Bert Karwatzki Sent: Tuesday, January 11, 2022 19:12 To: amd-gfx@lists.freedesktop.org Cc: Limonciello, Mario ; Kazlauskas

RE: [PATCH] drm/amd: apply s0ix codepath to more cases

2022-01-11 Thread Limonciello, Mario
[AMD Official Use Only] > -Original Message- > From: Lazar, Lijo > Sent: Tuesday, January 11, 2022 12:54 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org > Cc: Bjoren Dasse > Subject: Re: [PATCH] drm/amd: apply s0ix codepath to more cases > >

RE: [PATCH v2] drm/amd: Warn users about potential s0ix problems

2022-01-17 Thread Limonciello, Mario
to an aborted suspend. From: Lazar, Lijo Sent: Monday, January 17, 2022 11:20 To: Limonciello, Mario ; amd-gfx@lists.freedesktop.org Cc: Bjoren Dasse Subject: Re: [PATCH v2] drm/amd: Warn users about potential s0ix problems Any problem with PMFW sequence in the way Linux handles s2idle when it's

RE: [PATCH v2] drm/amd: Warn users about potential s0ix problems

2022-01-17 Thread Limonciello, Mario
[Public] This has been sitting a week or so. Bump on review for this patch. > -Original Message- > From: Limonciello, Mario > Sent: Tuesday, January 11, 2022 14:00 > To: amd-gfx@lists.freedesktop.org > Cc: Limonciello, Mario ; Bjoren Dasse > > Subject: [PATCH v2

RE: [PATCH v2] drm/amdgpu: skipping SDMA hw_init and hw_fini for S0ix.

2022-02-10 Thread Limonciello, Mario
[Public] > -Original Message- > From: Mahapatra, Rajib > Sent: Thursday, February 10, 2022 07:35 > To: Liang, Prike ; Limonciello, Mario > ; Deucher, Alexander > > Cc: amd-gfx@lists.freedesktop.org; S, Shirish ; > Mahapatra, Rajib > Subject: [PATCH v2

Re: [PATCH v3 04/12] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-13 Thread Limonciello, Mario
On 2/13/2022 02:20, Lukas Wunner wrote: On Fri, Feb 11, 2022 at 01:32:42PM -0600, Mario Limonciello wrote: The `is_thunderbolt` attribute is currently a dumping ground for a variety of things. It's not as arbitrary as it may seem. Quite a bit of thought went into the current design.

RE: [PATCH v2 4/9] PCI: mark USB4 devices as removable

2022-02-11 Thread Limonciello, Mario
[Public] > -Original Message- > From: Mika Westerberg > Sent: Friday, February 11, 2022 04:35 > To: Limonciello, Mario > Cc: Bjorn Helgaas ; Andreas Noever > ; open list:PCI SUBSYSTEM p...@vger.kernel.org>; open list:THUNDERBOLT DRIVER u...@vger.kernel.o

RE: [PATCH v2 3/9] PCI: drop `is_thunderbolt` attribute

2022-02-11 Thread Limonciello, Mario
[Public] > -Original Message- > From: Mika Westerberg > Sent: Friday, February 11, 2022 04:24 > To: Limonciello, Mario > Cc: Bjorn Helgaas ; Andreas Noever > ; open list:PCI SUBSYSTEM p...@vger.kernel.org>; open list:THUNDERBOLT DRIVER u...@vger.kernel.o

Re: [PATCH v3 03/12] PCI: Move check for old Apple Thunderbolt controllers into a quirk

2022-02-11 Thread Limonciello, Mario
On 2/11/2022 15:35, Bjorn Helgaas wrote: On Fri, Feb 11, 2022 at 01:32:41PM -0600, Mario Limonciello wrote: `pci_bridge_d3_possible` currently checks explicitly for a Thunderbolt controller to indicate that D3 is possible. As this is used solely for older Apple systems, move it into a quirk

Re: [PATCH 1/2] drm: Add GPU reset sysfs event

2022-03-08 Thread Limonciello, Mario
On 3/8/2022 10:57, Sharma, Shashank wrote: On 3/8/2022 5:55 PM, Andrey Grodzovsky wrote: You can read on their side here - https://www.phoronix.com/scan.php?page=news_item=AMD-STB-Linux-5.17 and see their patch. THey don't have as clean interface as we do to retrieve the buffer and currently

RE: [PATCH 1/2] drm: Add GPU reset sysfs event

2022-03-08 Thread Limonciello, Mario
[AMD Official Use Only] > -Original Message- > From: Sharma, Shashank > Sent: Tuesday, March 8, 2022 12:09 > To: Limonciello, Mario ; Grodzovsky, Andrey > ; Lazar, Lijo ; Shashank > Sharma ; amd- > g...@lists.freedesktop.org; S-k, Shyam-sundar ; > Goswam

Re: drm/amdgpu: only check for _PR3 on dGPUs

2022-03-09 Thread Limonciello, Mario
On 3/9/2022 14:12, Alex Deucher wrote: We don't support runtime pm on APUs. They support more dynamic power savings using clock and powergating. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff

RE: [PATCH] amdgpu/pm: Don't show `smartshift_*_power` files for APUs

2022-03-10 Thread Limonciello, Mario
? > -Original Message- > From: Sundararaju, Sathishkumar > Sent: Thursday, March 10, 2022 05:19 > To: Lazar, Lijo ; Limonciello, Mario > ; amd-gfx@lists.freedesktop.org > Subject: RE: [PATCH] amdgpu/pm: Don't show `smartshift_*_power` files for > APUs > > [AMD Official Us

Re: drm/amdgpu: do not enable asic reset for raven2

2022-02-17 Thread Limonciello, Mario
On 2/17/2022 03:07, Chen Gong wrote: The GPU reset function of raven2 is not maintained or tested, so it should be very unstable. Now the amdgpu_asic_reset function is added to amdgpu_pmops_suspend, which causes the S3 test of raven2 to fail, so the asic_reset of raven2 is ignored here.

Re: [PATCH v4 00/10] Overhaul `is_thunderbolt`

2022-02-16 Thread Limonciello, Mario
On 2/16/2022 08:44, Alex Deucher wrote: On Wed, Feb 16, 2022 at 9:34 AM Mika Westerberg wrote: Hi all, On Tue, Feb 15, 2022 at 01:07:00PM -0600, Limonciello, Mario wrote: On 2/15/2022 01:29, Lukas Wunner wrote: On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote: drivers

RE: [PATCH] drm/amd: Check if ASPM is enabled from PCIe subsystem

2022-02-16 Thread Limonciello, Mario
[AMD Official Use Only] > > commit 0064b0ce85bb ("drm/amd/pm: enable ASPM by default") enabled > ASPM > > by default but a variety of hardware configurations it turns out that this > > caused a regression. > > > > * PPC64LE hardware does not support ASPM at a hardware level. > >

RE: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-28 Thread Limonciello, Mario
[AMD Official Use Only] > > On Fri, Feb 25, 2022 at 11:42:24AM -0600, Bjorn Helgaas wrote: > > That would just leave the "PCI_VSEC_ID_INTEL_TBT implies external- > facing" > > assumption above. Not having a Thunderbolt spec, I have no idea how > > you deal with that. > > You can download the

RE: [PATCH v5 3/7] PCI: Drop the `is_thunderbolt` attribute from PCI core

2022-02-28 Thread Limonciello, Mario
[AMD Official Use Only] > -Original Message- > From: Lukas Wunner > Sent: Monday, February 28, 2022 16:33 > To: Bjorn Helgaas > Cc: Limonciello, Mario ; Mika Westerberg > ; Michael Jamet > ; open list:PCI SUBSYSTEM p...@vger.kernel.org>; open li

Re: [PATCH v4 00/10] Overhaul `is_thunderbolt`

2022-02-15 Thread Limonciello, Mario
On 2/15/2022 01:29, Lukas Wunner wrote: On Mon, Feb 14, 2022 at 06:01:50PM -0600, Mario Limonciello wrote: drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c | 2 +- drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c | 2 +- drivers/gpu/drm/nouveau/nouveau_vga.c | 4 +-

RE: [PATCH] drm/amdgpu: skipping SDMA IP suspend for S0ix.

2022-02-02 Thread Limonciello, Mario
[Public] > -Original Message- > From: Mahapatra, Rajib > Sent: Wednesday, February 2, 2022 03:07 > To: Liang, Prike ; Limonciello, Mario > ; Deucher, Alexander > > Cc: amd-gfx@lists.freedesktop.org; S, Shirish ; > Mahapatra, Rajib > Subject: [PATCH] d

Re: [PATCH] drm/amdgpu: skipping SDMA IP suspend for S0ix.

2022-02-02 Thread Limonciello, Mario
On 2/2/2022 08:16, Alex Deucher wrote: On Wed, Feb 2, 2022 at 4:07 AM Rajib Mahapatra wrote: [Why] amdgpu error observed if suspend is aborted during S0i3 resume. [How] If suspend is aborted for some reason during S0i3 resume cycle, it follows amdgpu errors in resume. Skipping SDMA ip in

RE: [PATCH v6 4/4] drm/amd: Only run s3 or s0ix if system is configured properly

2022-01-27 Thread Limonciello, Mario
, 2022 08:50 To: Limonciello, Mario ; amd-gfx@lists.freedesktop.org Cc: Liang, Prike Subject: Re: [PATCH v6 4/4] drm/amd: Only run s3 or s0ix if system is configured properly [Public] Series is: Reviewed-by: Alex Deucher mailto:alexander.deuc...@amd.com>> ___

RE: [PATCH v2] drm/amdgpu: skipping SDMA hw_init and hw_fini for S0ix.

2022-02-10 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Thursday, February 10, 2022 09:28 > To: Limonciello, Mario > Cc: Mahapatra, Rajib ; Liang, Prike > ; Deucher, Alexander ; > amd-gfx@lists.freedesktop.org; S, Shirish > Subject: Re: [PATCH v2] drm/amdgp

RE: [PATCH v2] drm/amdgpu: skipping SDMA hw_init and hw_fini for S0ix.

2022-02-10 Thread Limonciello, Mario
[Public] > > VG doesn't do s0i3 right? > > Right. > > > No, YC should not take a similar fix.YC had an architectural change and > > to > > avoid a "similar" problem takes > 26db706a6d77b9e184feb11725e97e53b7a89519. > > Isn't that likely just a workaround for the same issue? This seems

RE: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-14 Thread Limonciello, Mario
[Public] > > > > > > > > > > > >> I think the revert is fine once we figure out where we're missing > > > >> calls to: > > > >> > > > >> .optimize_pwr_state = dcn21_optimize_pwr_state, > > > >> .exit_optimized_pwr_state = dcn21_exit_optimized_pwr_state, > > > >> > > > >> These

RE: [PATCH v2] drm/amd: Warn users about potential s0ix problems

2022-01-18 Thread Limonciello, Mario
[Public] That is what I was hoping to convey with the warning messages. I'll take a stab at rewording them and send out an updated revision. From: Liang, Prike Sent: Tuesday, January 18, 2022 02:28 To: Limonciello, Mario ; Lazar, Lijo ; amd-gfx@lists.freedesktop.org Cc: Bjoren Dasse Subject

RE: [PATCH v4] drm/amd: Warn users about potential s0ix problems

2022-01-20 Thread Limonciello, Mario
[Public] Add back on Lijo and Prike, my mistake they got dropped from CC. > -Original Message- > From: Limonciello, Mario > Sent: Tuesday, January 18, 2022 21:41 > To: amd-gfx@lists.freedesktop.org > Cc: Limonciello, Mario ; Bjoren Dasse > > Subject: [PATCH v4

RE: [PATCH v4] drm/amd: Warn users about potential s0ix problems

2022-01-21 Thread Limonciello, Mario
Thanks, > Prike > > -Original Message- > > From: Limonciello, Mario > > Sent: Friday, January 21, 2022 3:59 AM > > To: amd-gfx@lists.freedesktop.org; Lazar, Lijo ; Liang, > > Prike > > Cc: Bjoren Dasse > > Subject: RE: [PATCH v4] drm/amd: Warn users

RE: [PATCH v2] drm/amd/display: explicitly update clocks when DC is set to D3 in s0i3

2022-01-06 Thread Limonciello, Mario
[Public] > -Original Message- > From: Thorsten Leemhuis > Sent: Thursday, January 6, 2022 05:39 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org > Cc: Zhuo, Qingqing (Lillian) ; Scott Bruce > ; Chris Hixon ; > spassw...@web.de > Subject: Re:

RE: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-07 Thread Limonciello, Mario
[AMD Official Use Only] > I think the revert is fine once we figure out where we're missing calls to: > > .optimize_pwr_state = dcn21_optimize_pwr_state, > .exit_optimized_pwr_state = dcn21_exit_optimized_pwr_state, > > These are already part of dc_link_detect, so I suspect

RE: amd-staging-drm-next breaks suspend

2022-01-19 Thread Limonciello, Mario
[Public] > -Original Message- > From: Bert Karwatzki > Sent: Wednesday, January 19, 2022 15:52 > To: amd-gfx@lists.freedesktop.org > Cc: Limonciello, Mario ; Kazlauskas, Nicholas > ; Zhuo, Qingqing (Lillian) > ; Scott Bruce ; Alex Deucher > ; Chris Hixon > Su

Re: drm/amd/display: Call dc_stream_release for remove link enc assignment

2022-01-24 Thread Limonciello, Mario
On 1/24/2022 12:57, Nicholas Kazlauskas wrote: [Why] A porting error resulted in the stream assignment for the link being retained without being released - a memory leak. [How] Fix the porting error by adding back the dc_stream_release() intended as part of the original patch. Fixes:

RE: [PATCH v5 2/4] drm/amd: add support to check whether the system is set to s3

2022-01-26 Thread Limonciello, Mario
reset might not be the right move. From: Lazar, Lijo Sent: Wednesday, January 26, 2022 09:11 To: Limonciello, Mario ; amd-gfx@lists.freedesktop.org Cc: Liang, Prike Subject: Re: [PATCH v5 2/4] drm/amd: add support to check whether the system is set to s3 Talking from generic API perspective

RE: [PATCH v5 4/4] drm/amd: don't reset dGPUs that don't go through system S3

2022-01-26 Thread Limonciello, Mario
[AMD Official Use Only] > -Original Message- > From: Limonciello, Mario > Sent: Tuesday, January 25, 2022 22:10 > To: amd-gfx@lists.freedesktop.org > Cc: Liang, Prike ; Limonciello, Mario > > Subject: [PATCH v5 4/4] drm/amd: don't reset dGPUs that don't go through &

RE: [PATCH v5 2/4] drm/amd: add support to check whether the system is set to s3

2022-01-26 Thread Limonciello, Mario
e resume doesn't work with/without reset? > > > > Thanks, > > Lijo > > > > From: Limonciello, Mario > > Sent: Wednesday, January 26, 2022 8:47:05 PM > > To: Lazar, Lijo ; amd-gfx@lists.freedesktop.org g...@lists.freedesktop.org> > > Cc: Liang, Prike

RE: [PATCH v5 2/4] drm/amd: add support to check whether the system is set to s3

2022-01-26 Thread Limonciello, Mario
[Public] That was intentional - shouldn't dGPU always be going through S3 path currently? From: Lazar, Lijo Sent: Wednesday, January 26, 2022 09:06 To: Limonciello, Mario ; amd-gfx@lists.freedesktop.org Cc: Liang, Prike ; Limonciello, Mario Subject: Re: [PATCH v5 2/4] drm/amd: add support

RE: [PATCH v5] drm/amd/display: Revert W/A for hard hangs on DCN20/DCN21

2022-01-14 Thread Limonciello, Mario
[AMD Official Use Only] > > > > > >> I think the revert is fine once we figure out where we're missing calls to: > >> > >> .optimize_pwr_state = dcn21_optimize_pwr_state, > >> .exit_optimized_pwr_state = dcn21_exit_optimized_pwr_state, > >> > >> These are already part of

Re: drm/amd/amdgpu: Add ip_discovery_text sysfs entry (v2)

2022-01-25 Thread Limonciello, Mario
A few suggestion ideas inline. On 1/25/2022 12:18, Tom St Denis wrote: Newer hardware has a discovery table in hardware that the kernel will rely on instead of header files for things like IP offsets. This sysfs entry adds a simple to parse table of IP instances and segment offsets. Produces

RE: [PATCHv2] drm/amdgpu: disable ASPM on Intel AlderLake based systems

2022-04-08 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Friday, April 8, 2022 14:09 > To: Gong, Richard > Cc: Deucher, Alexander ; Koenig, Christian > ; Pan, Xinhui ; Dave Airlie > ; Daniel Vetter ; Limonciello, Mario > ; Maling list - DRI developers de.

RE: [PATCH] drm/amdgpu: disable ASPM for legacy products that don't support ASPM

2022-04-08 Thread Limonciello, Mario
[Public] > -Original Message- > From: Gong, Richard > Sent: Friday, April 8, 2022 11:20 > To: Limonciello, Mario ; Deucher, Alexander > ; Koenig, Christian > ; Pan, Xinhui ; > airl...@linux.ie; dan...@ffwll.ch > Cc: amd-gfx@lists.freedesktop.org; dri-de...@list

RE: [PATCH] drm/amdgpu: disable ASPM for legacy products that don't support ASPM

2022-04-08 Thread Limonciello, Mario
top.org; linux- > ker...@vger.kernel.org; Limonciello, Mario ; > Gong, Richard > Subject: [PATCH] drm/amdgpu: disable ASPM for legacy products that don't > support ASPM > > Active State Power Management (ASPM) feature is enabled since kernel > 5.14. > However there are some legacy product

RE: [PATCH] drm/amdgpu: Ensure HDA function is suspended before ASIC reset

2022-04-07 Thread Limonciello, Mario
t; gfx list ; Chiu, Solomon > ; Limonciello, Mario > ; Quan, Evan ; > Tuikov, Luben > Subject: Re: [PATCH] drm/amdgpu: Ensure HDA function is suspended > before ASIC reset > > On Thu, Apr 7, 2022 at 8:21 AM Kai-Heng Feng > wrote: > > > > DP/HDMI audio on AMD PR

RE: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-13 Thread Limonciello, Mario
[Public] > On Wed, Apr 13, 2022 at 3:43 AM Paul Menzel > wrote: > > > > Dear Richard, > > > > > > Thank you for sending out v4. > > > > Am 12.04.22 um 23:50 schrieb Richard Gong: > > > Active State Power Management (ASPM) feature is enabled since kernel > 5.14. > > > There are some AMD GFX

RE: [PATCH 13/16] drm/amd/display: Don't set dpms_off for seamless boot

2023-10-04 Thread Limonciello, Mario
[AMD Official Use Only - General] > From: Daniel Miess > > [Why] > eDPs fail to light up with seamless boot enabled > > [How] > When seamless boot is enabled don't configure dpms_off > in disable_vbios_mode_if_required. > > Reviewed-by: Charlene Liu > Cc: Mario Limonciello > Cc: Alex Deucher

RE: [PATCH] drm/amd: Disable ASPM for VI w/ all Intel systems

2023-10-23 Thread Limonciello, Mario
[Public] > -Original Message- > From: Deucher, Alexander > Sent: Monday, October 23, 2023 09:22 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org > Cc: Limonciello, Mario ; > paolo.gent...@canonical.com > Subject: RE: [PATCH] drm/amd: Disable ASPM for

Re: [V9 1/9] drivers core: Add support for Wifi band RF mitigations

2023-08-18 Thread Limonciello, Mario
On 8/18/2023 4:24 PM, Greg KH wrote: On Fri, Aug 18, 2023 at 11:26:11AM +0800, Evan Quan wrote: drivers/base/Makefile | 1 + drivers/base/wbrf.c | 280 ++ Why is a wifi-specific thing going into drivers/base/? confused,

Re: [V9 1/9] drivers core: Add support for Wifi band RF mitigations

2023-08-21 Thread Limonciello, Mario
On 8/19/2023 5:50 AM, Greg KH wrote: On Fri, Aug 18, 2023 at 05:49:14PM -0500, Limonciello, Mario wrote: On 8/18/2023 4:24 PM, Greg KH wrote: On Fri, Aug 18, 2023 at 11:26:11AM +0800, Evan Quan wrote: drivers/base/Makefile | 1 + drivers/base/wbrf.c

RE: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based systems

2022-04-20 Thread Limonciello, Mario
exander ; Koenig, Christian > ; Limonciello, Mario > > Subject: Re: [PATCHv4] drm/amdgpu: disable ASPM on Intel Alder Lake based > systems > > On Wed, Apr 20, 2022 at 5:02 PM Paul Menzel > wrote: > > > > Dear Richard, > > > > > > Am 20.04.22 um

RE: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle

2022-05-17 Thread Limonciello, Mario
on reset only for a suspend situation. Remember it's in amdgpu_acpi.c. So it would be amdgpu_acpi_need_reset_on_suspend()? It's a bit lengthy. From: Lazar, Lijo Sent: Tuesday, May 17, 2022 11:25 To: Limonciello, Mario ; amd-gfx@lists.freedesktop.org Cc: Limonciello, Mario Subject: Re: [PATCH

RE: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle

2022-05-17 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Tuesday, May 17, 2022 08:43 > To: Limonciello, Mario > Cc: amd-gfx list > Subject: Re: [PATCH] drm/amd: Don't reset dGPUs if the system is going to > s2idle > > On Tue, May 17, 2022 at 9:39 AM

RE: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle

2022-05-17 Thread Limonciello, Mario
[Public] No, it mode2 reset that it uses for failure case. From: Lazar, Lijo Sent: Tuesday, May 17, 2022 11:51 To: Limonciello, Mario ; amd-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/amd: Don't reset dGPUs if the system is going to s2idle [Public] Ya, second is too lengthy. Better

RE: [PATCH] drm/amdkfd: Select PCI_P2PDMA and DMABUF_MOVE_NOTIFY instead of depending

2022-07-07 Thread Limonciello, Mario
[Public] > -Original Message- > From: Errabolu, Ramesh > Sent: Thursday, July 7, 2022 15:30 > To: Limonciello, Mario ; amd- > g...@lists.freedesktop.org; Kuehling, Felix > Cc: Limonciello, Mario > Subject: RE: [PATCH] drm/amdkfd: Select PCI_P2PDMA and > DM

Re: [PATCH] drm/amd/display: Ignore First MST Sideband Message Return Error

2022-07-11 Thread Limonciello, Mario
On 7/11/2022 16:52, Rodrigo Siqueira wrote: From: Fangzhi Zuo [why] The first MST sideband message returns AUX_RET_ERROR_HPD_DISCON on a certain Intel platform. Aux transaction is considered a failure if HPD unexpectedly pulled low. The actual aux transaction success in such case, hence do not

Re: [PATCH v2] drm/amd/display: Ignore First MST Sideband Message Return Error

2022-07-11 Thread Limonciello, Mario
On 7/11/2022 17:10, Rodrigo Siqueira wrote: From: Fangzhi Zuo [why] The first MST sideband message returns AUX_RET_ERROR_HPD_DISCON on a certain Intel platform. Aux transaction is considered a failure if HPD unexpectedly pulled low. The actual aux transaction success in such case, hence do not

Re: [21/21] drm/amd/display: Ignore First MST Sideband Message Return Error

2022-07-12 Thread Limonciello, Mario
On 7/12/2022 10:42, Solomon Chiu wrote: From: Fangzhi Zuo [why] First MST sideband message returns AUX_RET_ERROR_HPD_DISCON on certain intel platform. Aux transaction considered failure if HPD unexpected pulled low. The actual aux transaction success in such case, hence do not return error.

Re: [PATCH] drm/amd/display: Add a proper DMI match for Precision devices

2022-07-12 Thread Limonciello, Mario
On 7/12/2022 10:59, Rodrigo Siqueira wrote: We had an MST fix for some DELL devices that got merged, but we missed other products. This commit adds the other missing Precision devices. Cc: Mario Limonciello Cc: Jerry Zuo Cc: Qian Fu Cc: Alex Deucher Fixes: 9fcd8af669d7 ("drm/amd/display:

RE: [PATCH] drm/amd: Don't show warning on reading vbios values for SMU13 3.1

2022-06-16 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Quan, Evan > Sent: Wednesday, June 15, 2022 22:37 > To: Alex Deucher ; Limonciello, Mario > ; Feng, Kenneth > Cc: amd-gfx list > Subject: RE: [PATCH] drm/amd: Don't show warning on reading vbios v

RE: [PATCH] drm/amd: Revert "drm/amd/display: keep eDP Vdd on when eDP stream is already enabled"

2022-06-16 Thread Limonciello, Mario
[Public] + people associated with original patch being reverted for comments > -Original Message- > From: Limonciello, Mario > Sent: Wednesday, June 15, 2022 17:30 > To: amd-gfx@lists.freedesktop.org > Cc: Limonciello, Mario ; Aaron Ma > > Subject: [PATCH] drm

RE: [PATCH v2 27/29] ACPI: video: Drop Clevo/TUXEDO NL5xRU and NL5xNU acpi_backlight=native quirks

2022-07-13 Thread Limonciello, Mario
[Public] > -Original Message- > From: Werner Sembach > Sent: Wednesday, July 13, 2022 12:08 > To: Hans de Goede ; Ben Skeggs > ; Karol Herbst ; Lyude > ; Daniel Dadap ; Maarten > Lankhorst ; Maxime Ripard > ; Thomas Zimmermann ; > Jani Nikula ; Joonas Lahtinen > ; Rodrigo Vivi ; >

RE: [PATCHv5] drm/amdgpu: vi: disable ASPM on Intel Alder Lake based systems

2022-05-02 Thread Limonciello, Mario
l test robot ; LKML ker...@vger.kernel.org>; Maling list - DRI developers de...@lists.freedesktop.org>; Limonciello, Mario > > Subject: Re: [PATCHv5] drm/amdgpu: vi: disable ASPM on Intel Alder Lake > based systems > > Reviewed-by: Alex Deucher > > On Fri, Apr 29, 2022 at 1

Re: Revert "drm/amd/pm: keep the BACO feature enabled for suspend"

2022-05-10 Thread Limonciello, Mario
On 5/10/2022 08:51, Alex Deucher wrote: This reverts commit eaa090538e8d21801c6d5f94590c3799e6a528b5. Commit ebc002e3ee78 ("drm/amdgpu: don't use BACO for reset in S3") stops using BACO for reset during suspend, so it's no longer necessary to leave BACO enabled during suspend. This fixes

RE: Fwd: Re: amd | ASUS ROG Strix G513QY fails to resume from suspend [regression] (#2008)

2022-05-10 Thread Limonciello, Mario
[Public] > -Original Message- > From: Thorsten Leemhuis > Sent: Tuesday, May 10, 2022 05:33 > To: Paul Menzel ; regressi...@lists.linux.dev > Cc: amd-gfx@lists.freedesktop.org; Limonciello, Mario > > Subject: Re: Fwd: Re: amd | ASUS ROG Strix G513QY fails to

Re: [PATCH] drm: amd: amdgpu: ACPI: Add comment about ACPI_FADT_LOW_POWER_S0

2022-08-25 Thread Limonciello, Mario
On 8/24/2022 12:32, Rafael J. Wysocki wrote: From: Rafael J. Wysocki According to the ACPI specification [1], the ACPI_FADT_LOW_POWER_S0 flag merely means that it is better to use low-power S0 idle on the given platform than S3 (provided that the latter is supported) and it doesn't preclude

RE: [PATCH] ACPI: x86: s2idle: Revmoe unused variable hid

2022-10-26 Thread Limonciello, Mario
[Public] > -Original Message- > From: Hung, Alex > Sent: Wednesday, October 26, 2022 12:34 > To: amd-gfx@lists.freedesktop.org; Deucher, Alexander > ; Limonciello, Mario > > Cc: Siqueira, Rodrigo ; Hung, Alex > > Subject: [PATCH] ACPI: x86: s2idle:

Re: [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

2022-10-25 Thread Limonciello, Mario
On 10/25/2022 15:25, Hans de Goede wrote: Hi Matthew, On 10/25/22 21:32, Matthew Garrett wrote: On Tue, Oct 25, 2022 at 08:50:54PM +0200, Hans de Goede wrote: That is a valid point, but keep in mind that this is only used on ACPI platforms and then only on devices with a builtin LCD panel

Re: [1/2] drm/amd/pm: update SMU IP v13.0.4 driver interface version

2022-10-13 Thread Limonciello, Mario
On 10/13/2022 00:46, Tim Huang wrote: Update the SMU driver interface version to V7. Signed-off-by: Tim Huang --- .../swsmu/inc/pmfw_if/smu13_driver_if_v13_0_4.h | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git

Re: [2/2] drm/amd/pm: add SMU IP v13.0.4 IF version define to V7

2022-10-13 Thread Limonciello, Mario
On 10/13/2022 00:46, Tim Huang wrote: The pmfw has changed the driver interface version, so keep same with the fw. Signed-off-by: Tim Huang Cc: sta...@vger.kernel.org #6.0 Reviewed-by: Mario Limonciello --- drivers/gpu/drm/amd/pm/swsmu/inc/smu_v13_0.h | 2 +- 1 file changed, 1

Re: [20/23] drm/amd/display: Fix watermark calculation

2022-10-07 Thread Limonciello, Mario
On 10/6/2022 16:26, Qingqing Zhuo wrote: From: Alvin Lee Watermark calculation was incorrect due to missing brackets. Reviewed-by: Rodrigo Siqueira Acked-by: Qingqing Zhuo Signed-off-by: Alvin Lee This just landed upstream for 6.0 and is a trivial fix for what the intention was, it

Re: drm/amd/display: explicitly disable psr_feature_enable appropriately

2022-10-07 Thread Limonciello, Mario
On 10/6/2022 23:28, Shirish S wrote: [Why] If psr_feature_enable is set to true by default, it continues to be enabled for non capable links. [How] explicitly disable the feature on links that are not capable of the same. Signed-off-by: Shirish S Reviewed-by: Leo Li This has been a problem

Re: [01/23] drm/amd/display: Update PMFW z-state interface for DCN314

2022-10-07 Thread Limonciello, Mario
On 10/6/2022 16:26, Qingqing Zhuo wrote: From: Nicholas Kazlauskas [Why] Request from PMFW to change the messaging format to specify whether we support z-state via individual bits. [How] Update the args we pass in the support message. Reviewed-by: Charlene Liu Acked-by: Qingqing Zhuo

Re: [PATCH] drm/amd/display: Enable dpia support for dcn314

2022-10-03 Thread Limonciello, Mario
On 10/3/2022 13:00, roman...@amd.com wrote: From: Roman Li [Why] DCN 3.1.4 supports DPIA. [How] - Set dpia_supported flag for dcn314 in dmub_hw_init() - Remove comment that becomes irrelevant after this change. Signed-off-by: Roman Li Reviewed-by: Nicholas Kazlauskas FYI As this is

Re: [PATCH 0/4] Fix S3 and S4 issues related to fbdev

2022-08-09 Thread Limonciello, Mario
On 8/9/2022 10:50, Alex Deucher wrote: On Tue, Aug 9, 2022 at 11:10 AM Mario Limonciello wrote: Moving to the generic fbdev helper introduced a regression in S4 support on Hawaii PRO graphics cards. A workaround commit was introduced to avoid this S4 regression until the root cause could be

Re: [23/33] drm/amd/display: cursor update command incomplete

2022-11-01 Thread Limonciello, Mario
On 10/20/2022 10:46, Rodrigo Siqueira wrote: From: Max Tseng Missing send cursor_rect width & Height into DMUB. PSR-SU would use these information. But missing these assignment in last refactor commit Reviewed-by: Anthony Koo Acked-by: Rodrigo Siqueira Signed-off-by: Max Tseng --- This

RE: [PATCH v6 20/45] drm/amd: Parse both v1 and v2 TA microcode headers using same function

2023-01-05 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Lazar, Lijo > Sent: Thursday, January 5, 2023 07:22 > To: Limonciello, Mario ; Deucher, Alexander > ; linux-ker...@vger.kernel.org > Cc: Javier Martinez Canillas ; Carlos Soriano Sanchez > ; amd-gfx@

RE: [PATCH] drm/amd: Only load TA microcode for psp v12_0 once

2023-01-10 Thread Limonciello, Mario
[AMD Official Use Only - General] > -Original Message- > From: Alex Deucher > Sent: Tuesday, January 10, 2023 13:29 > To: Limonciello, Mario > Cc: amd-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/amd: Only load TA microcode for psp v12_0 once > > On T

RE: [PATCH v4 27/27] drm/amd: Optimize SRIOV switch/case for PSP microcode load

2023-01-04 Thread Limonciello, Mario
[Public] > -Original Message- > From: Christian König > Sent: Wednesday, January 4, 2023 07:18 > To: Limonciello, Mario ; Deucher, Alexander > ; linux-ker...@vger.kernel.org > Cc: Pan, Xinhui ; Lazar, Lijo ; > Javier Martinez Canillas ; dri- > de...@lists.

RE: [PATCH v5 10/45] drm/amd: Load VCN microcode during early_init

2023-01-04 Thread Limonciello, Mario
[Public] > -Original Message- > From: Alex Deucher > Sent: Wednesday, January 4, 2023 11:16 > To: Limonciello, Mario > Cc: Deucher, Alexander ; linux- > ker...@vger.kernel.org; Pan, Xinhui ; Lazar, Lijo > ; Javier Martinez Canillas ; dri- > de...@lists.

  1   2   3   >